Re: Adding a new thread model to GCC

2022-12-24 Thread Jonathan Yong via Gcc-patches
On 12/24/22 21:22, i.nix...@autistici.org wrote: On 2022-12-24 15:57, i.nix...@autistici.org wrote: On 2022-12-24 15:42, i.nix...@autistici.org wrote: fixed and tested. Jonathan Yong, could you please apply the attached patch too? kings regards! oh no... please wait. fixed now. bootst

Re: Re: [PATCH] RISC-V: Fix ICE for avl_info deprecated copy and pp_print error.

2022-12-24 Thread 钟居哲
I just want to make sure. You mean the bootstrap can pass now with this patch? If yes, plz merge this patch. Thank you so much. juzhe.zh...@rivai.ai From: Andreas Schwab Date: 2022-12-25 00:58 To: juzhe.zhong CC: gcc-patches Subject: Re: [PATCH] RISC-V: Fix ICE for avl_info deprecated copy and

[Committed] Tweak new gcc.target/i386/pr107548-1.c for -march=cascadelake.

2022-12-24 Thread Roger Sayle
My recently added testcases gcc.target/i386/pr107548-[12].c need to be tweaked slightly for -march=cascadelake. Committed as obvious. 2022-12-24 Roger Sayle gcc/testsuite/ChangeLog PR target/107548 * gcc.target/i386/pr107548-1.c: Match both vmovd and movd. * gcc.targ

Re: Adding a new thread model to GCC

2022-12-24 Thread i.nixman--- via Gcc-patches
On 2022-12-24 15:57, i.nix...@autistici.org wrote: On 2022-12-24 15:42, i.nix...@autistici.org wrote: fixed and tested. Jonathan Yong, could you please apply the attached patch too? kings regards! oh no... please wait. fixed now. bootstrapped successfully! Jonathan Yong, could you pl

Re: [PATCH] libgccjit: Fix a failing test

2022-12-24 Thread Guillaume Gomez via Gcc-patches
Ping David Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez a écrit : > Forgot it indeed, thanks for notifying me! > > I modified the commit message to add it and added it into this email. > > Le mer. 14 déc. 2022 à 16:12, Antoni Boucher a écrit : > >> Thanks! >> >> In your patch, you're missing t

[PATCH] cp: warn uninitialized const/ref in base class [PR80681]

2022-12-24 Thread Charlie Sale via Gcc-patches
On this example: ``` struct Fine { private: const int f; }; struct BuggyA { const int a; int &b; }; struct BuggyB : private BuggyA { }; ``` g++ currently emits: ``` test.cc:3:19: warning: non-static const member ‘const int Fine::f’ in class without a constructor [-Wuninit

[PATCH] Ada, Darwin: Do not link libgcc statically on Darwin [PR108202].

2022-12-24 Thread Iain Sandoe via Gcc-patches
Tested on i686, x86-64 darwin, x86_64-linux (with a 32b multilib). OK for trunk? Iain --- 8< --- Normally, GCC executables are built with -static-libstdc++ -static-libgcc on Darwin. This is fine in most cases, because GCC executables typically do not use exceptions. However gnat1 does use exce

Re: [PATCH] libstdc++: Test for tzdata.zi before fallback version files.

2022-12-24 Thread Iain Sandoe
> On 24 Dec 2022, at 12:25, Andreas Schwab wrote: > > On Dez 24 2022, Iain Sandoe via Gcc-patches wrote: > >> @@ -1083,6 +1078,14 @@ namespace std::chrono >> if (*zif >> hash >> label >> version) >> if (hash == '#' && label == "version") >>return version; >> +#if defined __

[pushed] libgcc, Darwin: No early install for the compatibility libgcc_s.1.dylib.

2022-12-24 Thread Iain Sandoe via Gcc-patches
Tested on i686, x86_64 Darwin and x86_64-linux-gnu (with a 32b multilib). pushed to master, thanks Iain --- 8< --- On Darwin, GCC now uses a libgcc_s.1.1 for builtins and forwards the system unwinder. We do, however, build a backwards compatibility libgcc_s.1.dylib. However, this is not needed b

Re: [PATCH] RISC-V: Fix ICE for avl_info deprecated copy and pp_print error.

2022-12-24 Thread Andreas Schwab
On Dez 23 2022, juzhe.zh...@rivai.ai wrote: > * config/riscv/riscv-vsetvl.cc (change_insn): Remove pp_print. > (avl_info::avl_info): Add copy function. > (vector_insn_info::dump): Remove pp_print. > * config/riscv/riscv-vsetvl.h: Add copy function. Survived bootstr

Re: Adding a new thread model to GCC

2022-12-24 Thread i.nixman--- via Gcc-patches
On 2022-12-24 15:42, i.nix...@autistici.org wrote: fixed and tested. Jonathan Yong, could you please apply the attached patch too? kings regards! oh no... please wait.

Re: Adding a new thread model to GCC

2022-12-24 Thread i.nixman--- via Gcc-patches
On 2022-12-24 13:50, i.nix...@autistici.org wrote: On 2022-12-24 05:58, NightStrike wrote: I think this might have broken fortran. I'm assuming because the backtrace includes gthr.h, and I just did a git pull: In file included from /tmp/rtmingw/mingw/include/windows.h:71, fro

Re: Adding a new thread model to GCC

2022-12-24 Thread i.nixman--- via Gcc-patches
On 2022-12-24 05:58, NightStrike wrote: I think this might have broken fortran. I'm assuming because the backtrace includes gthr.h, and I just did a git pull: In file included from /tmp/rtmingw/mingw/include/windows.h:71, from ../libgcc/gthr-default.h:606, fro

Re: [PATCH] libstdc++: Test for tzdata.zi before fallback version files.

2022-12-24 Thread Andreas Schwab
On Dez 24 2022, Iain Sandoe via Gcc-patches wrote: > @@ -1083,6 +1078,14 @@ namespace std::chrono >if (*zif >> hash >> label >> version) > if (hash == '#' && label == "version") > return version; > +#if defined __NetBSD__ > +if (string ver; ifstream(zoneinfo_dir() + "/TZD

Re: [PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol.

2022-12-24 Thread Iain Sandoe
> On 24 Dec 2022, at 12:12, Jonathan Wakely wrote: > > > > On Sat, 24 Dec 2022, 11:35 Iain Sandoe via Libstdc++, > wrote: > If this is not the right place to export the symbol (or you do not want > to export it in the general case), I can always add a platform-specific > file for it. S

Re: [PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol.

2022-12-24 Thread Jonathan Wakely via Gcc-patches
On Sat, 24 Dec 2022, 11:35 Iain Sandoe via Libstdc++, wrote: > If this is not the right place to export the symbol (or you do not want > to export it in the general case), I can always add a platform-specific > file for it. So far, tested on x86_64-darwin21, wider testing will > follow over

Re: [PATCH] libstdc++, testsuite: Correct an init.

2022-12-24 Thread Jonathan Wakely via Gcc-patches
On Sat, 24 Dec 2022, 11:43 Iain Sandoe via Libstdc++, wrote: > Noticed while debugging tz info support on Darwin, unless I miss > some other reasoning... > OK for trunk? > Doh, thanks. OK for trunk. Iain > > --- 8< --- > > in leap_seconds.cc, we are testing to see if the function that > overri

Re: [PATCH] libstdc++: Test for tzdata.zi before fallback version files.

2022-12-24 Thread Jonathan Wakely via Gcc-patches
On Sat, 24 Dec 2022, 11:40 Iain Sandoe via Libstdc++, wrote: > I tested this (along with the other posted patches for zoneinfo) using > an installation built from the 2022g release on x86_64-darwin21. Wider > testing will follow. If we are in an installation without the tzdata.zi > then althoug

[PATCH] libstdc++, testsuite: Correct an init.

2022-12-24 Thread Iain Sandoe via Gcc-patches
Noticed while debugging tz info support on Darwin, unless I miss some other reasoning... OK for trunk? Iain --- 8< --- in leap_seconds.cc, we are testing to see if the function that overrides the default zoneinfo directory has been called. That is implemented with a static boolean that needs to

[PATCH] libstdc++: Test for tzdata.zi before fallback version files.

2022-12-24 Thread Iain Sandoe via Gcc-patches
I tested this (along with the other posted patches for zoneinfo) using an installation built from the 2022g release on x86_64-darwin21. Wider testing will follow. If we are in an installation without the tzdata.zi then although we'll report the version OK, the available functionality will be basi

[PATCH] libstdc++: Export the __gnu_cxx::zoneinfo_dir_override symbol.

2022-12-24 Thread Iain Sandoe via Gcc-patches
If this is not the right place to export the symbol (or you do not want to export it in the general case), I can always add a platform-specific file for it. So far, tested on x86_64-darwin21, wider testing will follow over the holidays. OK for trunk? Iain --- 8< --- This symbol needs to

Re: [PATCH V2] Disable sched1 in functions that call setjmp

2022-12-24 Thread Alexander Monakov via Gcc-patches
On Sat, 24 Dec 2022, Jose E. Marchesi wrote: > However, there is something I don't understand: wouldn't sched2 > introduce the same problem when -fsched2-use-superblocks is specified? Superblocks are irrelevant, a call instruction does not end a basic block and the problematic motion happens wi

Re: [PATCH V2] Disable sched1 in functions that call setjmp

2022-12-24 Thread Richard Biener via Gcc-patches
> Am 24.12.2022 um 10:54 schrieb Jose E. Marchesi : > >  Am 24.12.2022 um 09:11 schrieb Alexander Monakov via Gcc-patches : >>> >>>  On Fri, 23 Dec 2022, Qing Zhao wrote: BTW, Why sched1 is not enabled on x86 by default? >>> >>> Register allocation is tricky on x8

Re: [PATCH] libstdc++, configure: Fix GLIBCXX_ZONEINFO_DIR configuration macro.

2022-12-24 Thread Jonathan Wakely via Gcc-patches
On Sat, 24 Dec 2022, 09:56 Iain Sandoe, wrote: > Hi, > > > On 23 Dec 2022, at 23:17, Jonathan Wakely wrote: > > > > On Fri, 23 Dec 2022, 17:06 Iain Sandoe via Libstdc++, < > libstd...@gcc.gnu.org> wrote: > > This is a patch for comment on the approach - tested on x86_64-darwi21 > > thoughts? >

Re: [PATCH] libstdc++, configure: Fix GLIBCXX_ZONEINFO_DIR configuration macro.

2022-12-24 Thread Iain Sandoe
Hi, > On 23 Dec 2022, at 23:17, Jonathan Wakely wrote: > > On Fri, 23 Dec 2022, 17:06 Iain Sandoe via Libstdc++, > wrote: > This is a patch for comment on the approach - tested on x86_64-darwi21 > thoughts? > Iain > > --- 8< --- > > Testing on Darwin revealed that the GLIBCXX_ZONEINFO_DI

Re: [PATCH V2] Disable sched1 in functions that call setjmp

2022-12-24 Thread Jose E. Marchesi via Gcc-patches
>> Am 24.12.2022 um 09:11 schrieb Alexander Monakov via Gcc-patches >> : >> >>  >>> On Fri, 23 Dec 2022, Qing Zhao wrote: >>> >>> BTW, Why sched1 is not enabled on x86 by default? >> >> Register allocation is tricky on x86 due to small number of general-purpose >> registers, and sched1 can m

Re: [PATCH V2] Disable sched1 in functions that call setjmp

2022-12-24 Thread Richard Biener via Gcc-patches
> Am 24.12.2022 um 09:11 schrieb Alexander Monakov via Gcc-patches > : > >  >> On Fri, 23 Dec 2022, Qing Zhao wrote: >> >> BTW, Why sched1 is not enabled on x86 by default? > > Register allocation is tricky on x86 due to small number of general-purpose > registers, and sched1 can make it ev

Re: [PATCH V2] Disable sched1 in functions that call setjmp

2022-12-24 Thread Alexander Monakov via Gcc-patches
On Fri, 23 Dec 2022, Qing Zhao wrote: > BTW, Why sched1 is not enabled on x86 by default? Register allocation is tricky on x86 due to small number of general-purpose registers, and sched1 can make it even more difficult. I think before register pressure modeling was added, sched1 could not be e