Re: [PATCH] bug in emergency cxa pool free()

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, Aug 16, 2022 at 9:15 PM Keef Aragon wrote: > > This probably has never actually affected anyone in practice. The normal > ABI implementation just uses malloc and only falls back to the pool on > malloc failure. But if that happens a bunch of times the freelist gets out > of order which vio

Re: [PATCH v4] rs6000: Fix incorrect RTL for Power LE when removing the UNSPECS [PR106069]

2022-08-16 Thread Xionghu Luo via Gcc-patches
On 2022/8/16 14:53, Kewen.Lin wrote: Hi Xionghu, Thanks for the updated version of patch, some comments are inlined. on 2022/8/11 14:15, Xionghu Luo wrote: On 2022/8/11 01:07, Segher Boessenkool wrote: On Wed, Aug 10, 2022 at 02:39:02PM +0800, Xionghu Luo wrote: On 2022/8/9 11:01, Kewen

Re: [PATCH] x86: Support vector __bf16 type.

2022-08-16 Thread Hongtao Liu via Gcc-patches
On Tue, Aug 16, 2022 at 3:50 PM Kong, Lingling via Gcc-patches wrote: > > Hi, > > The patch is support vector init/broadcast/set/extract for __bf16 type. > The __bf16 type is a storage type. > > OK for master? Ok. > > gcc/ChangeLog: > > * config/i386/i386-expand.cc (ix86_expand_sse_movcc):

Re: [PATCH V4] rs6000: Optimize cmp on rotated 16bits constant

2022-08-16 Thread Jiufu Guo via Gcc-patches
Gentle ping: https://gcc.gnu.org/pipermail/gcc-patches/2022-July/598769.html BR, Jeff(Jiufu) Jiufu Guo writes: > Hi, > > When checking eq/neq with a constant which has only 16bits, it can be > optimized to check the rotated data. By this, the constant building > is optimized. > > As the exam

Re: [PATCH] rs6000: avoid ineffective replacement of splitters

2022-08-16 Thread Jiufu Guo via Gcc-patches
Hi, "Kewen.Lin" writes: > Hi Jeff, > > on 2022/8/12 14:39, Jiufu Guo via Gcc-patches wrote: >> Hi, >> >> As a comment in >> https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599556.html >> >> Those splitters call rs6000_emit_set_const directly, and the replacements >> are never used. Usin

Re: [RFC]rs6000: split complicated constant to memory

2022-08-16 Thread Jiufu Guo via Gcc-patches
Hi, Segher Boessenkool writes: > Hi! > > On Mon, Aug 15, 2022 at 01:25:19PM +0800, Jiufu Guo wrote: >> This patch tries to put the constant into constant pool if building the >> constant requires 3 or more instructions. >> >> But there is a concern: I'm wondering if this patch is really profi

Re: [COMMITTED] Abstract interesting ssa-names from GORI.

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 21:16, Andrew MacLeod wrote: On 8/16/22 04:21, Aldy Hernandez wrote: On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, const vec &path) worklist.safe_push (arg); }

[COMMITTED] Abstract interesting ssa-names from GORI.

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 04:21, Aldy Hernandez wrote: On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, const vec &path) worklist.safe_push (arg); } } + else if (gassign *ass = dyn_cast

[PATCH] d: Fix #error You must define PREFERRED_DEBUGGING_TYPE if DWARF is not supported (PR105659)

2022-08-16 Thread Iain Buclaw via Gcc-patches
Hi, Because targetdm contains hooks pertaining to both the target platform and cpu, it tries to pull in both platform and cpu headers via tm_d.h in the source file where TARGETDM_INITIALIZER is used. Since 12.0, this has caused problems when there is no platform (*-elf), resulting in default-d.cc

Re: [PATCH] c++: Extend -Wpessimizing-move to other contexts

2022-08-16 Thread Marek Polacek via Gcc-patches
On Tue, Aug 16, 2022 at 03:23:18PM -0400, Jason Merrill wrote: > On 8/2/22 16:04, Marek Polacek wrote: > > In my recent patch which enhanced -Wpessimizing-move so that it warns > > about class prvalues too I said that I'd like to extend it so that it > > warns in more contexts where a std::move can

Re: [PATCH] xtensa: Prevent emitting integer additions of constant zero

2022-08-16 Thread Max Filippov via Gcc-patches
Hi Suwa-san, On Tue, Aug 16, 2022 at 5:42 AM Takayuki 'January June' Suwa wrote: > > In a few cases, obviously omitable add instructions can be emitted via > invoking gen_addsi3. > > gcc/ChangeLog: > > * config/xtensa/xtensa.md (addsi3_internal): Rename from "addsi3". > (addsi3):

Re: [PATCH] c++: Extend -Wpessimizing-move to other contexts

2022-08-16 Thread Jason Merrill via Gcc-patches
On 8/2/22 16:04, Marek Polacek wrote: In my recent patch which enhanced -Wpessimizing-move so that it warns about class prvalues too I said that I'd like to extend it so that it warns in more contexts where a std::move can prevent copy elision, such as: T t = std::move(T()); T t(std::move(

[PATCH] bug in emergency cxa pool free()

2022-08-16 Thread Keef Aragon
This probably has never actually affected anyone in practice. The normal ABI implementation just uses malloc and only falls back to the pool on malloc failure. But if that happens a bunch of times the freelist gets out of order which violates some of the invariants of the freelist (as well as the c

Re: [PATCH 0/5] IEEE 128-bit built-in overload support.

2022-08-16 Thread Segher Boessenkool
Hi! On Tue, Aug 16, 2022 at 08:07:48PM +0200, Jakub Jelinek wrote: > On Thu, Aug 11, 2022 at 08:44:17PM +, Joseph Myers wrote: > > On Thu, 11 Aug 2022, Michael Meissner via Gcc-patches wrote: > > > In looking at it, I now believe that the type for _Float128 and __float128 > > > should always b

[PATCH][_GLIBCXX_ASSERTIONS] Activate __glibcxx_requires_string/__glibcxx_requires_string_len

2022-08-16 Thread François Dumont via Gcc-patches
Following my remark about tests XFAIL-ing when running 'make check' I'd like to propose this to avoid this situation.     libstdc++: [_GLIBCXX_ASSERTIONS] Activate basic _GLIBCXX_DEBUB_PEDANTIC checks     Activate __glibcxx_requires_string/__glibcxx_requires_string_len in basic _GLIBCXX_ASSE

Re: [PATCH 0/5] IEEE 128-bit built-in overload support.

2022-08-16 Thread Jakub Jelinek via Gcc-patches
On Thu, Aug 11, 2022 at 08:44:17PM +, Joseph Myers wrote: > On Thu, 11 Aug 2022, Michael Meissner via Gcc-patches wrote: > > > In looking at it, I now believe that the type for _Float128 and __float128 > > should always be the same within the compiler. Whether we would continue to > > use the

[wwwdocs] Add C++23 papers approved by WG21 at the July plenary

2022-08-16 Thread Marek Polacek via Gcc-patches
We have a lot of new papers to implement. I've also opened PRs for them. Pushed. commit c6f8ab1adad76d2b43f6cbdacd84202131ae1e5c Author: Marek Polacek Date: Tue Aug 16 13:39:34 2022 -0400 cxx-status: Add C++23 papers approved by WG21 at the July plenary diff --git a/htdocs/projects/cxx-

OpenMP patch ping

2022-08-16 Thread Tobias Burnus
I would like to ping the following OpenMP patches. First two non-pings but just RFC: - "Restore 'GOMP_offload_unregister_ver' functionality" https://gcc.gnu.org/pipermail/gcc-patches/2022-July/597918.html * QUESTION: See 'assert' question in email exchange (linked email message + emails b

Re: Ping^2: 2 libcpp patches

2022-08-16 Thread Joseph Myers
On Tue, 16 Aug 2022, Lewis Hyatt via Gcc-patches wrote: > For the first patch, I think it is a worthwhile goal to fix all the > places where libcpp fails to support UTF-8 correctly, and this is one > of two remaining ones that I'm aware of. I can fix the other case > (handling of #pragma push_macr

Re: ICE after folding svld1rq to vec_perm_expr duing forwprop

2022-08-16 Thread Richard Sandiford via Gcc-patches
Prathamesh Kulkarni writes: > On Tue, 9 Aug 2022 at 18:42, Richard Biener > wrote: >> >> On Tue, Aug 9, 2022 at 12:10 PM Prathamesh Kulkarni >> wrote: >> > >> > On Mon, 8 Aug 2022 at 14:27, Richard Biener >> > w>> > > >> > > >> > > /* If result vector has greater length than input vector, >

[PATCH][pushed] docs: remove link to www.bullfreeware.com from install

2022-08-16 Thread Martin Liška
As mentioned at https://gcc.gnu.org/PR106637#c2, the discontinued providing binaries. PR target/106637 gcc/ChangeLog: * doc/install.texi: Remove link to www.bullfreeware.com --- gcc/doc/install.texi | 4 1 file changed, 4 deletions(-) diff --git a/gcc/doc/install.texi b/gc

Re: [PATCH 0/2] RISC-V: Support _Float16 type and implement zfh and zfhmin extension

2022-08-16 Thread Kito Cheng via Gcc-patches
This patch set has been committed to trunk. On Wed, Aug 10, 2022 at 11:44 PM Kito Cheng wrote: > > This patch set implements Zfh and Zfhmin, adds soft-float for _Float16, and > enables _Float16 type in C++ mode. > > Zfh and Zfhmin are extensions for IEEE half precision, both are ratified in > J

[wwwdocs] Update C++ DR table from Core Language Issue TOC, Revision 109

2022-08-16 Thread Marek Polacek via Gcc-patches
A lot of updates this time. Pushed. commit 0a423169f0abf14b765493d7b11b790d847494e8 Author: Marek Polacek Date: Tue Aug 16 11:32:24 2022 -0400 cxx-dr-status: Update from C++ Core Language Issue TOC, Revision 109 diff --git a/htdocs/projects/cxx-dr-status.html b/htdocs/projects/cxx-dr-st

[Patch] OpenMP: Fix var replacement with 'simd' and linear-step vars [PR106548]

2022-08-16 Thread Tobias Burnus
The testcase is just a copy of linear-1 with 'omp ... for' replaced by 'omp ... for simd', matching what the PR report referred to. The problem occurs for 'omp ... for simd linear( i : step)' when 'step' is a variable when a omp_fn... is generated - as in this case, the original variable is use

[PING^6] nvptx: Allow '--with-arch' to override the default '-misa' (was: nvptx multilib setup)

2022-08-16 Thread Thomas Schwinge
Hi Tom! Ping. Grüße Thomas On 2022-08-06T21:20:38+0200, I wrote: > Hi Tom! > > Ping. > > > Grüße > Thomas > > > On 2022-07-27T17:48:58+0200, I wrote: >> Hi Tom! >> >> Ping. >> >> >> Grüße >> Thomas >> >> >> On 2022-07-20T14:46:03+0200, I wrote: >>> Hi Tom! >>> >>> Ping. >>> >>> >>> Grüße >>

[PING^7] nvptx: forward '-v' command-line option to assembler, linker

2022-08-16 Thread Thomas Schwinge
Hi Tom! Ping. Grüße Thomas On 2022-08-06T21:20:23+0200, I wrote: > Hi Tom! > > Ping. > > > Grüße > Thomas > > > On 2022-07-27T17:48:46+0200, I wrote: >> Hi Tom! >> >> Ping. >> >> >> Grüße >> Thomas >> >> >> On 2022-07-20T14:44:36+0200, I wrote: >>> Hi Tom! >>> >>> Ping. >>> >>> >>> Grüße >>

Re: [Patch] Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566]

2022-08-16 Thread Tobias Burnus
Fixed subject line: "absent linear" should be "absent linear step" in the subject line; i.e. with "step" added: "Fortran: OpenMP fix declare simd inside modules and absent linear step [PR106566]" I have also decided to move the 'step = 1' to openmp.cc, which also set it before with the old pre

Re: [PATCH] soft-fp: Update soft-fp from glibc

2022-08-16 Thread Kito Cheng via Gcc-patches
Hi Joseph: I saw other soft-fp updates will also ask for some approval on the list too, anyway I know that now :) Thanks! On Tue, Aug 16, 2022 at 10:18 PM Joseph Myers wrote: > > On Tue, 16 Aug 2022, Kito Cheng wrote: > > > ping > > Under our write access policies, "Importing files maintained o

[PATCH] fortran: Add -static-libquadmath support [PR46539]

2022-08-16 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch is a revival of the https://gcc.gnu.org/legacy-ml/gcc-patches/2014-10/msg00771.html patch. While trunk configured against recent glibc and with linker --as-needed support doesn't really need to link against -lquadmath anymore, there are still other targets where libquadmat

Re: [PATCH] Support threading of just the exit edge

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 05:18, Richard Biener wrote: On Mon, 15 Aug 2022, Aldy Hernandez wrote: On Mon, Aug 15, 2022 at 9:24 PM Andrew MacLeod wrote: heh. or just + int_range<2> r; + if (!fold_range (r, const_cast (cond_stmt)) + || !r.singleton_p (&val)) if you do not provide a range

Re: [PATCH] soft-fp: Update soft-fp from glibc

2022-08-16 Thread Joseph Myers
On Tue, 16 Aug 2022, Kito Cheng wrote: > ping Under our write access policies, "Importing files maintained outside the tree from their official versions." does not require review or approval. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Avoid further recomputations in path_range_query once path is finalized.

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, Aug 16, 2022 at 3:59 PM Aldy Hernandez wrote: > > [Richi, I'm trying to make things more obvious for others working for the > cose base. What do you think?] > > This makes a few things explicit to avoid misuse. First, we add a > flag to differentiate between a path whose depdenency range

[Patch] Fortran: OpenMP fix declare simd inside modules and absent linear [PR106566]

2022-08-16 Thread Tobias Burnus
This patch fixes two issues – the first was reported to me by email but it also shows up in the official OpenMP examples (see PR). Namely: Inside a module, 'gfc_match(" ( %s )")' fails as the symbol is already host associated. (The symbol is the current procedure name.) Solution: Match with pass

[PATCH] Refactor back_threader_profitability

2022-08-16 Thread Richard Biener via Gcc-patches
The following refactors profitable_path_p in the backward threader, splitting out parts that can be computed once the exit block is known, parts that contiguously update and that can be checked allowing for the path to be later identified as FSM with larger limits, possibly_profitable_path_p, and f

[PATCH] Avoid further recomputations in path_range_query once path is finalized.

2022-08-16 Thread Aldy Hernandez via Gcc-patches
[Richi, I'm trying to make things more obvious for others working for the cose base. What do you think?] This makes a few things explicit to avoid misuse. First, we add a flag to differentiate between a path whose depdenency ranges are being computed, and a path that is finalized and no further

[PATCH] Fix bogus -Wstringop-overflow warning in Ada

2022-08-16 Thread Eric Botcazou via Gcc-patches
Hi, the following bogus warning: In function 'lto26', inlined from 'main' at /home/eric/gnat/bugs/V721-018/b~lto26.adb:237:7: lto26.adb:11:13: warning: writing 1 byte into a region of size 0 [-Wstringop- overflow=] 11 | Set (R, (7, 0, 84, Stream_Element (I), 0, 0, 0), 1); |

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 3:48 PM Andrew MacLeod wrote: > > > On 8/16/22 06:25, Aldy Hernandez wrote: > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > >> The remaining issue I have with the path_range_query is that > >> we re-use the same instance in the back threader but the > >> class

Re: Where in C++ module streaming to handle a new bitfield added in "tree_decl_common"

2022-08-16 Thread Qing Zhao via Gcc-patches
> On Aug 16, 2022, at 8:37 AM, Richard Biener > wrote: > > On Tue, Aug 16, 2022 at 2:16 PM Nathan Sidwell wrote: >> >> On 8/15/22 10:03, Richard Biener wrote: >>> On Mon, Aug 15, 2022 at 3:29 PM Nathan Sidwell via Gcc-patches >>> wrote: On 8/2/22 10:44, Qing Zhao wrote: > Hi,

Ping^2: 2 libcpp patches

2022-08-16 Thread Lewis Hyatt via Gcc-patches
On Wed, Jul 20, 2022 at 8:56 PM Lewis Hyatt wrote: > > Hello- > > May I please ping these two preprocessor patches? > > For PR103902: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596704.html > > For PR55971: > https://gcc.gnu.org/pipermail/gcc-patches/2022-June/596820.html > > Thanks! He

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 06:25, Aldy Hernandez wrote: On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: The remaining issue I have with the path_range_query is that we re-use the same instance in the back threader but the class doesn't provide any way to "restart", aka give m_path a lifetime. The "st

Re: Where in C++ module streaming to handle a new bitfield added in "tree_decl_common"

2022-08-16 Thread Qing Zhao via Gcc-patches
> On Aug 15, 2022, at 9:28 AM, Nathan Sidwell wrote: > > On 8/2/22 10:44, Qing Zhao wrote: >> Hi, Nathan, >> I am adding a new bitfield “decl_not_flexarray” in “tree_decl_common” >> (gcc/tree-core.h) for the new gcc feature -fstrict-flex-arrays. >> >> diff --git a/gcc/tree-core.h b/gcc/t

Re: [PATCH] Support threading of just the exit edge

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Richard Biener wrote: > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 16, 2022 at 11:18 AM Richard Biener wrote: > > > > > > On Mon, 15 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Mon, Aug 15, 2022 at 9:24 PM Andrew MacLeod > > > > wrote: > > > > > > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Andrew MacLeod via Gcc-patches
On 8/16/22 05:28, Richard Biener wrote: On Tue, 16 Aug 2022, Aldy Hernandez wrote: On Tue, Aug 16, 2022 at 11:08 AM Aldy Hernandez wrote: On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: On Tue, 16 Aug 2022, Aldy Hernandez wrote: On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wro

Re: [PATCH] fortran: Expand ieee_arithmetic module's ieee_value inline [PR106579]

2022-08-16 Thread FX via Gcc-patches
Hi, >> Why looping over fields? The class type is a simple type with only one >> member (and it should be an integer, we can assert that). > > I wanted to make sure it has exactly one field. > The ieee_arithmetic.F90 module in libgfortran surely does that, but I've > been worrying about some use

[PATCH] xtensa: Prevent emitting integer additions of constant zero

2022-08-16 Thread Takayuki 'January June' Suwa via Gcc-patches
In a few cases, obviously omitable add instructions can be emitted via invoking gen_addsi3. gcc/ChangeLog: * config/xtensa/xtensa.md (addsi3_internal): Rename from "addsi3". (addsi3): New define_expand in order to reject integer additions of constant zero. --- gcc/config/

Re: Where in C++ module streaming to handle a new bitfield added in "tree_decl_common"

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, Aug 16, 2022 at 2:16 PM Nathan Sidwell wrote: > > On 8/15/22 10:03, Richard Biener wrote: > > On Mon, Aug 15, 2022 at 3:29 PM Nathan Sidwell via Gcc-patches > > wrote: > >> > >> On 8/2/22 10:44, Qing Zhao wrote: > >>> Hi, Nathan, > >>> > >>> I am adding a new bitfield “decl_not_flexarray”

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022, 14:26 Richard Biener wrote: > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 16, 2022 at 1:38 PM Richard Biener > wrote: > > > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener > wrote: > > > > > >

Re: [PATCH] c++: Extend -Wpessimizing-move to other contexts

2022-08-16 Thread Marek Polacek via Gcc-patches
Ping. (The other std::move patches depend on this one.) (can_do_rvo_p is renamed to can_elide_copy_prvalue_p in the PR90428 patch.) On Tue, Aug 02, 2022 at 07:04:47PM -0400, Marek Polacek via Gcc-patches wrote: > In my recent patch which enhanced -Wpessimizing-move so that it warns > about class

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 16, 2022 at 1:38 PM Richard Biener wrote: > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > > > > > The remaining issue I have with the path_range_query is that > >

Re: [PATCH] s390: Implement vec_set with vec_merge and, vec_duplicate.

2022-08-16 Thread Andreas Krebbel via Gcc-patches
On 8/12/22 16:48, Robin Dapp wrote: > Hi, > > similar to other backends this patch implements vec_set via > vec_merge and vec_duplicate instead of an unspec. This opens up > more possibilites to combine instructions. > > Bootstrapped and regtested. No regressions. > > Is it OK? > > Regards >

[PATCH] Stop backwards thread discovery when leaving a loop

2022-08-16 Thread Richard Biener via Gcc-patches
The backward threader copier cannot deal with the situation of copying blocks belonging to different loops and will reject those paths late. The following uses this to prune path discovery, saving on compile-time. Note the off-loop block is still considered as entry edge origin. Bootstrapped and

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 1:38 PM Richard Biener wrote: > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > > > The remaining issue I have with the path_range_query is that > > > we re-use the same instance in the back threader but the

Re: Where in C++ module streaming to handle a new bitfield added in "tree_decl_common"

2022-08-16 Thread Nathan Sidwell via Gcc-patches
On 8/15/22 10:03, Richard Biener wrote: On Mon, Aug 15, 2022 at 3:29 PM Nathan Sidwell via Gcc-patches wrote: On 8/2/22 10:44, Qing Zhao wrote: Hi, Nathan, I am adding a new bitfield “decl_not_flexarray” in “tree_decl_common” (gcc/tree-core.h) for the new gcc feature -fstrict-flex-arrays.

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Jakub Jelinek wrote: > On Tue, Aug 16, 2022 at 11:41:06AM +, Richard Biener wrote: > > Can you also amend the extend.texi documentation? I think the > > behavior will be special enough to worth mentioning it (I don't see > > any of -ffinite-math-only effect on isnan/isinf

Re: [PATCH] driver: fix environ corruption after putenv() [PR106624]

2022-08-16 Thread Martin Liška
On 8/16/22 13:48, Sergei Trofimovich wrote: > From: Sergei Trofimovich > > The bug appeared afte r13-2010-g1270ccda70ca09 "Factor out > jobserver_active_p" slightly changed `putenv()` use from allocating > to non-allocating: > > -xputenv (concat ("MAKEFLAGS=", dup, NULL)); > +xputenv (ji

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Jakub Jelinek via Gcc-patches
On Tue, Aug 16, 2022 at 11:41:06AM +, Richard Biener wrote: > Can you also amend the extend.texi documentation? I think the > behavior will be special enough to worth mentioning it (I don't see > any of -ffinite-math-only effect on isnan/isinf mentioned though). Like this? --- gcc/doc/extend

[PATCH] driver: fix environ corruption after putenv() [PR106624]

2022-08-16 Thread Sergei Trofimovich via Gcc-patches
From: Sergei Trofimovich The bug appeared afte r13-2010-g1270ccda70ca09 "Factor out jobserver_active_p" slightly changed `putenv()` use from allocating to non-allocating: -xputenv (concat ("MAKEFLAGS=", dup, NULL)); +xputenv (jinfo.skipped_makeflags.c_str ()); `xputenv()` (and `putenv()

Re: [PATCH] s390: Implement vec_extract via vec_select.

2022-08-16 Thread Andreas Krebbel via Gcc-patches
On 8/12/22 16:19, Robin Dapp wrote: > Hi, > > vec_select can handle dynamic/runtime masks nowadays. Therefore we can > get rid of the UNSPEC_VEC_EXTRACT that was preventing further > optimizations like combining instructions with vec_extract patterns. > > Bootstrapped and regtested. No regressio

Re: [PATCH] Support threading of just the exit edge

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 1:32 PM Richard Biener wrote: > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Tue, Aug 16, 2022 at 11:18 AM Richard Biener wrote: > > > > > > On Mon, 15 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Mon, Aug 15, 2022 at 9:24 PM Andrew MacLeod > > > > wrote: >

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Jakub Jelinek wrote: > On Mon, Aug 15, 2022 at 03:06:16PM +0200, Jakub Jelinek via Gcc-patches wrote: > > On Mon, Aug 15, 2022 at 12:07:38PM +, Richard Biener wrote: > > > Ah, I misread > > > > > > +static rtx > > > +expand_builtin_issignaling (tree exp, rtx target) > > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > The remaining issue I have with the path_range_query is that > > we re-use the same instance in the back threader but the > > class doesn't provide any way to "restart", aka give m_path > >

Re: [PATCH] Implement __builtin_issignaling

2022-08-16 Thread Jakub Jelinek via Gcc-patches
On Mon, Aug 15, 2022 at 03:06:16PM +0200, Jakub Jelinek via Gcc-patches wrote: > On Mon, Aug 15, 2022 at 12:07:38PM +, Richard Biener wrote: > > Ah, I misread > > > > +static rtx > > +expand_builtin_issignaling (tree exp, rtx target) > > +{ > > + if (!validate_arglist (exp, REAL_TYPE, VOID_TY

[committed] d: Update DIP links in gdc documentation to point at upstream repository

2022-08-16 Thread Iain Buclaw via Gcc-patches
Hi, This patch fixes the broken DIP links in the GDC documentation. The wiki links probably worked at some point in the distant past, but now the official location of tracking all D Improvement Proposals is on the upstream dlang/DIPs GitHub repository. Regtested, committed to mainline, and backp

Re: [PATCH] Support threading of just the exit edge

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 16, 2022 at 11:18 AM Richard Biener wrote: > > > > On Mon, 15 Aug 2022, Aldy Hernandez wrote: > > > > > On Mon, Aug 15, 2022 at 9:24 PM Andrew MacLeod > > > wrote: > > > > > > > > heh. or just > > > > > > > > > > > > + int_range<2> r

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > The remaining issue I have with the path_range_query is that > we re-use the same instance in the back threader but the > class doesn't provide any way to "restart", aka give m_path > a lifetime. The "start a new path" API seems to essent

Re: [PATCH] Teach vectorizer to deal with bitfield accesses (was: [RFC] Teach vectorizer to deal with bitfield reads)

2022-08-16 Thread Andre Vieira (lists) via Gcc-patches
Hi, New version of the patch attached, but haven't recreated the ChangeLog yet, just waiting to see if this is what you had in mind. See also some replies to your comments in-line below: On 09/08/2022 15:34, Richard Biener wrote: @@ -2998,7 +3013,7 @@ ifcvt_split_critical_edges (class loop

Re: [PATCH] Support threading of just the exit edge

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 11:18 AM Richard Biener wrote: > > On Mon, 15 Aug 2022, Aldy Hernandez wrote: > > > On Mon, Aug 15, 2022 at 9:24 PM Andrew MacLeod wrote: > > > > > > heh. or just > > > > > > > > > + int_range<2> r; > > > + if (!fold_range (r, const_cast (cond_stmt)) > > > +

[PATCH][pushed] VR: add more virtual dtors

2022-08-16 Thread Martin Liška
Likewise pushed as obvious. Martin Add 2 virtual destructors in order to address: gcc/alloc-pool.h:522:5: warning: destructor called on non-final 'value_range_equiv' that has virtual functions but non-virtual destructor [-Wdelete-non-abstract-non-virtual-dtor] gcc/ggc.h:166:3: warning: destruc

[PATCH][pushed] VR: mitigate -Wfinal-dtor-non-final-class clang warnings

2022-08-16 Thread Martin Liška
Pushed as obvious. Martin Fixes: gcc/value-range-storage.h:129:40: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-final-class] gcc/value-range-storage.h:146:36: warning: class with destructor marked 'final' cannot be inherited from [-Wfinal-dtor-non-fi

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > > > On Thu, 11 Aug 2022, Aldy Hernandez wrote: > > > > > On Thu, Aug 11, 2022 at 3:59 PM Andrew MacLeod > > > wrote: > > > > > > > > > > > > On 8/11/22 07:42, Richard Biener wrote: > > > > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Tue, Aug 16, 2022 at 11:08 AM Aldy Hernandez wrote: > > > > On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: > > > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > > > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener > > > > wrote:

[PATCH] middle-end/106630 - avoid ping-pong between extract_muldiv and match.pd

2022-08-16 Thread Richard Biener via Gcc-patches
The following avoids ping-pong between the match.pd pattern changing (sizetype) ((a_9 + 1) * 48) to (sizetype)(a_9 + 1) * 48 and extract_muldiv performing the reverse transform by restricting the match.pd pattern to narrowing conversions as the comment indicates. Bootstrapped and tested on x86_64-

Re: [PATCH] Support threading of just the exit edge

2022-08-16 Thread Richard Biener via Gcc-patches
On Mon, 15 Aug 2022, Aldy Hernandez wrote: > On Mon, Aug 15, 2022 at 9:24 PM Andrew MacLeod wrote: > > > > heh. or just > > > > > > + int_range<2> r; > > + if (!fold_range (r, const_cast (cond_stmt)) > > + || !r.singleton_p (&val)) > > > > > > if you do not provide a range_query t

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 11:08 AM Aldy Hernandez wrote: > > On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: > > > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > > > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > > > > > > > @@ -599,6 +592,30 @@ path_range_query::compute_import

Re: [PATCH][pushed] VR: add missing override keyworks

2022-08-16 Thread Aldy Hernandez via Gcc-patches
Thanks. On Tue, Aug 16, 2022 at 11:07 AM Martin Liška wrote: > > Pushing as it follows the same pattern as: > > virtual void set (tree, tree, value_range_kind = VR_RANGE) override; > > Martin > > Address: > > gcc/value-range-equiv.h:57:8: warning: 'set_undefined' overrides a member > function

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Tue, Aug 16, 2022 at 10:32 AM Richard Biener wrote: > > On Tue, 16 Aug 2022, Aldy Hernandez wrote: > > > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > > > > > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, > > > const vec &path) > > > worklis

Re: [PATCH] LoongArch: Provide fmin/fmax RTL pattern

2022-08-16 Thread Lulu Cheng
Looks good to me. 在 2022/8/16 下午4:08, Xi Ruoyao 写道: A simple optimization. Ok for trunk? -- >8 -- We already had smin/smax RTL pattern using fmin/fmax instruction. But for smin/smax, it's unspecified what will happen if either operand is NaN. So we would generate calls to libc fmin/fmax fu

[PATCH][pushed] VR: add missing override keyworks

2022-08-16 Thread Martin Liška
Pushing as it follows the same pattern as: virtual void set (tree, tree, value_range_kind = VR_RANGE) override; Martin Address: gcc/value-range-equiv.h:57:8: warning: 'set_undefined' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] gcc/value-range-eq

Re: [x86 PATCH] PR target/106577: force_reg may clobber operands during split.

2022-08-16 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Tue, Aug 16, 2022 at 10:14 AM Richard Sandiford > wrote: >> >> Richard Biener via Gcc-patches writes: >> > On Fri, Aug 12, 2022 at 10:41 PM Roger Sayle >> > wrote: >> >> >> >> >> >> This patch fixes PR target/106577 which is a recent ICE on valid >> >> regression >

[PATCH][pushed] analyzer: add more final override keywords

2022-08-16 Thread Martin Liška
Pushed as obvious. Martin gcc/analyzer/ChangeLog: * region-model.cc: Fix -Winconsistent-missing-override clang warning. * region.h: Likewise. --- gcc/analyzer/region-model.cc | 4 ++-- gcc/analyzer/region.h| 3 ++- 2 files changed, 4 insertions(+), 3 deletions(

[PATCH][pushed] i386: add 'final' and 'override' to scalar_chain

2022-08-16 Thread Martin Liška
In c3ed9e0d6e96d8697e4bab994f8acbc5506240ee, David added some "final override" and since that there are 2 new warnings that need the same treatment: gcc/config/i386/i386-features.h:186:8: warning: 'convert_op' overrides a member function but is not marked 'override' [-Winconsistent-missing-overri

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Mon, Aug 15, 2022 at 11:53 AM Richard Biener wrote: > > On Thu, 11 Aug 2022, Aldy Hernandez wrote: > > > On Thu, Aug 11, 2022 at 3:59 PM Andrew MacLeod wrote: > > > > > > > > > On 8/11/22 07:42, Richard Biener wrote: > > > > This avoids going BBs outside of the path when adding def chains > >

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, 16 Aug 2022, Aldy Hernandez wrote: > On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > > > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, > > const vec &path) > > worklist.safe_push (arg); > > } > > } > > + else if

Re: [x86 PATCH] PR target/106577: force_reg may clobber operands during split.

2022-08-16 Thread Richard Biener via Gcc-patches
On Tue, Aug 16, 2022 at 10:14 AM Richard Sandiford wrote: > > Richard Biener via Gcc-patches writes: > > On Fri, Aug 12, 2022 at 10:41 PM Roger Sayle > > wrote: > >> > >> > >> This patch fixes PR target/106577 which is a recent ICE on valid regression > >> caused by my introduction of a *testti

Re: [committed] doc: Update link to "Memory Model" paper

2022-08-16 Thread Martin Liška
On 3/28/21 23:38, Gerald Pfeifer wrote: > The original link redirected, alas the new location gives a 404 "Not > Found". Luckily I found what looks like a more stable location. Hi. The newly selected location gives 403, which is not a friendly return code: wget https://www.researchgate.net/publ

Re: [PATCH] Tame path_range_query::compute_imports

2022-08-16 Thread Aldy Hernandez via Gcc-patches
On Thu, Aug 11, 2022 at 1:42 PM Richard Biener wrote: > @@ -599,6 +592,30 @@ path_range_query::compute_imports (bitmap imports, const > vec &path) > worklist.safe_push (arg); > } > } > + else if (gassign *ass = dyn_cast (def_stmt)) > + { > +

Re: [x86 PATCH] PR target/106577: force_reg may clobber operands during split.

2022-08-16 Thread Richard Sandiford via Gcc-patches
Richard Biener via Gcc-patches writes: > On Fri, Aug 12, 2022 at 10:41 PM Roger Sayle > wrote: >> >> >> This patch fixes PR target/106577 which is a recent ICE on valid regression >> caused by my introduction of a *testti_doubleword pre-reload splitter in >> i386.md. During the split pass befor

[PATCH] LoongArch: Provide fmin/fmax RTL pattern

2022-08-16 Thread Xi Ruoyao via Gcc-patches
A simple optimization. Ok for trunk? -- >8 -- We already had smin/smax RTL pattern using fmin/fmax instruction. But for smin/smax, it's unspecified what will happen if either operand is NaN. So we would generate calls to libc fmin/fmax functions with -fno-finite-math-only (the default for all

[PATCH][pushed] docs: fix link destination

2022-08-16 Thread Martin Liška
Pushed as obvious. Martin gcc/fortran/ChangeLog: * gfortran.texi: Fix link destination to a valid URL. --- gcc/fortran/gfortran.texi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/fortran/gfortran.texi b/gcc/fortran/gfortran.texi index d34e0b5e8f9..59d673b

Re: [09/23] Add a cut-down version of std::span (array_slice)

2022-08-16 Thread Richard Sandiford via Gcc-patches
Richard Biener writes: > On Wed, Aug 10, 2022 at 6:04 PM Martin Jambor wrote: >> >> Hello, >> >> I have one more question/comment about array_slice. Ever since I >> started to use it... >> >> On Fri, Nov 13 2020, Richard Sandiford via Gcc-patches wrote: >> > A later patch wants to be able to pas

Re: [PATCH] soft-fp: Update soft-fp from glibc

2022-08-16 Thread Kito Cheng via Gcc-patches
ping On Wed, Aug 10, 2022 at 10:23 PM Kito Cheng wrote: > > This patch is updating all soft-fp from glibc, most changes are > copyright years update, removing "Contributed by" lines and update URL for > license, and changes other than those update are adding conversion > function between IEEE hal

Re: [RFA configure parts] aarch64: Make cc1 &co handle --with options

2022-08-16 Thread Richard Sandiford via Gcc-patches
Richard Earnshaw writes: > On 05/08/2022 14:53, Richard Sandiford via Gcc-patches wrote: >> Richard Earnshaw writes: >>> On 13/06/2022 15:33, Richard Sandiford via Gcc-patches wrote: On aarch64, --with-arch, --with-cpu and --with-tune only have an effect on the driver, so “./xgcc -B./ -

[PATCH] x86: Support vector __bf16 type.

2022-08-16 Thread Kong, Lingling via Gcc-patches
Hi, The patch is support vector init/broadcast/set/extract for __bf16 type. The __bf16 type is a storage type. OK for master? gcc/ChangeLog: * config/i386/i386-expand.cc (ix86_expand_sse_movcc): Handle vector BFmode. (ix86_expand_vector_init_duplicate): Support vector BF