Re: [PATCH] Complete __gnu_debug::basic_string

2021-03-20 Thread François Dumont via Gcc-patches
Following your feedback here is the simplified version. I grouped it with the patch I submitted before. On 19/03/21 8:41 pm, Jonathan Wakely wrote: On 16/03/21 21:55 +0100, François Dumont via Libstdc++ wrote: Following: https://gcc.gnu.org/pipermail/libstdc++/2021-March/052158.html Here is

[PATCH] C++ modules: fix alloc-dealloc-mismatch ASAN issue

2021-03-20 Thread Martin Liška
Hi. The patch fixes the alloc-dealloc-mismatch reported by ASAN. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/cp/ChangeLog: PR c++/99687 * module.cc (fini_modules): Call vec_free instead of delete. --- gcc/cp

Re: 回复: [PATCH v4 1/2] MIPS: Not trigger error for pre-R6 and -mcompact-branches=always

2021-03-20 Thread Maciej W. Rozycki
On Sat, 20 Mar 2021, Jeff Law wrote: > > > I think what you're trying to do here is set up a scenario where you're > > > defaulting to mips32r6 and compact-branches, but not error if something > > > specifies -mcpu=mips32r2 or something similar, right? > > > > > Yes. If we introduce the build tim

Re: [PATCH v2] x86: Check cfun != NULL before accessing silent_p

2021-03-20 Thread Uros Bizjak via Gcc-patches
On Sat, Mar 20, 2021 at 4:55 PM H.J. Lu wrote: > > On Sat, Mar 20, 2021 at 6:46 AM Martin Liška wrote: > > > > On 3/20/21 1:21 PM, H.J. Lu wrote: > > > |Since construct_container may be called with cfun == NULL, check cfun != > > > NULL before accessing silent_p. | > > > > Thank you for the quic

Re: [PING][PATCH] adjust "partly out of bounds" warning (PR 98503)

2021-03-20 Thread Jeff Law via Gcc-patches
On 3/18/2021 4:18 PM, Martin Sebor via Gcc-patches wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564483.html The review of this patch digressed into a design discussion of a new, more capable implementation of -Wstrict-aliasing, but the proposed patch turning just this on

Re: [wwwdocs] arm,aarc64: add initial gcc-11/changes.html entries

2021-03-20 Thread Gerald Pfeifer
Hi Kyrylo, On Tue, 26 Jan 2021, Kyrylo Tkachov via Gcc-patches wrote: > This patch adds the arm and aarch64 sections changes.html for GCC 11. this is nice! One question: why GCC 11.0 in the following? The first release is going to be GCC 11.1, and we general refer to major releases - could we s

[PATCH 23/24] pdbout: Handle names of ctor and dtor functions.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 28 +++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index d9ad659cd9a..0f5315f7f07 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -2175,7 +2175,33 @@ get_tree_name (tree t) static const char anon_ns[] = "

[PATCH 24/24] pdbout: Handle functions with parts in cold section.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 226 ++- gcc/pdbout.h | 2 + 2 files changed, 170 insertions(+), 58 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 0f5315f7f07..b4528fb79e8 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -71,6 +71,7 @@ static void

[PATCH 22/24] pdbout: Split large fieldlists when necessary.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 151 ++- gcc/pdbout.h | 1 + 2 files changed, 151 insertions(+), 1 deletion(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 3d15c620db5..d9ad659cd9a 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -84,7 +84,7 @@ static struct

[PATCH 21/24] pdbout: Don't output unused types.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 256 ++- gcc/pdbout.h | 1 + 2 files changed, 254 insertions(+), 3 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 8dbd8f58a87..3d15c620db5 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -1438,7 +1438,8 @@ write_typ

[PATCH 20/24] pdbout: Output file and line number of type definitions.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 208 ++- gcc/pdbout.h | 10 +++ 2 files changed, 217 insertions(+), 1 deletion(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index dae5c1ef679..8dbd8f58a87 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -79,6 +79,7 @@ static struc

[PATCH 19/24] pdbout: Handle typedefs to anonymous types.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 79 +++- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 0cae4d33469..dae5c1ef679 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -3344,6 +3344,8 @@ alias_hasher::equal (const value_t

[PATCH 18/24] pdbout: Append template information to struct or function name.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 346 ++- 1 file changed, 344 insertions(+), 2 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index fb40f066bd9..0cae4d33469 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -73,6 +73,7 @@ static void pdbout_end_block (unsign

[PATCH 16/24] pdbout: Output definitions of bitfields within structs.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 93 ++-- gcc/pdbout.h | 8 + 2 files changed, 99 insertions(+), 2 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 7d493513e06..d3f251f22d2 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -85,6 +85,7 @@ static stru

[PATCH 17/24] pdbout: Prepend namespaces to struct and function names.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 93 ++-- 1 file changed, 91 insertions(+), 2 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index d3f251f22d2..fb40f066bd9 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -1484,24 +1484,113 @@ pdbout_finish (const char *fil

[PATCH 14/24] pdbout: Output definitions of structs and classes.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 469 ++- gcc/pdbout.h | 51 ++ 2 files changed, 517 insertions(+), 3 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 9701aaf8902..3bfec519877 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -83,6 +83,7 @@ static s

[PATCH 15/24] pdbout: Output definitions of unions.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 62 +++- gcc/pdbout.h | 1 + 2 files changed, 57 insertions(+), 6 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 3bfec519877..7d493513e06 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -829,6 +829,7 @@ free_type (st

[PATCH 13/24] pdbout: Output information about enums.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 449 +++ gcc/pdbout.h | 43 + 2 files changed, 492 insertions(+) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 5089203e339..9701aaf8902 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -46,6 +46,8 @@ #define FIRST_TYPE_NUM

[PATCH 11/24] pdbout: Output array types.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 133 +++ gcc/pdbout.h | 15 ++ 2 files changed, 148 insertions(+) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index fa3b1fb0312..8376b0e762c 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -79,6 +79,7 @@ static struct pdb_type *

[PATCH 12/24] pdbout: Handle type declarations and typedefs.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 76 +++- gcc/pdbout.h | 22 +++ 2 files changed, 97 insertions(+), 1 deletion(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 8376b0e762c..5089203e339 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -55,6 +55,7 @@ st

[PATCH 10/24] pdbout: Output information about CV type modifiers.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 85 gcc/pdbout.h | 11 +++ 2 files changed, 96 insertions(+) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 08bb14364e5..fa3b1fb0312 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -78,6 +78,7 @@ static struct pdb_type *t

[PATCH 08/24] pdbout: Output function prototypes.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 338 ++- gcc/pdbout.h | 23 2 files changed, 359 insertions(+), 2 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 040ac6fe8e4..64f7c1d71bc 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -32,6 +32,7 @@ #include

[PATCH 09/24] pdbout: Output information about pointers.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 131 --- gcc/pdbout.h | 36 ++ 2 files changed, 161 insertions(+), 6 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 64f7c1d71bc..08bb14364e5 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -76,6 +76,7 @@

[PATCH 07/24] pdbout: Output line numbers.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 150 ++- gcc/pdbout.h | 10 2 files changed, 159 insertions(+), 1 deletion(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index a4424fa470d..040ac6fe8e4 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -54,6 +54,11 @@ static voi

[PATCH 06/24] pdbout: Output checksums and names of source files.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 195 ++- gcc/pdbout.h | 16 + 2 files changed, 209 insertions(+), 2 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 29b0d1c131f..a4424fa470d 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -32,6 +32,7 @@ #include

[PATCH 04/24] pdbout: Output details of variables within functions.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 1272 +- gcc/pdbout.h | 969 ++ 2 files changed, 2238 insertions(+), 3 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 17011134d7a..2f5b52b6fc3 100644 --- a/gcc/pdbout.c +++ b/gcc/p

[PATCH 05/24] pdbout: Handle optimized variables.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 242 ++- gcc/pdbout.h | 21 + 2 files changed, 260 insertions(+), 3 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index 2f5b52b6fc3..29b0d1c131f 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -51,6 +51,7 @@ static vo

[PATCH 02/24] pdbout: Output details of local variables.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 417 ++- gcc/pdbout.h | 89 +++ 2 files changed, 504 insertions(+), 2 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index e8f39bb64ea..feaab37cc37 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -25,13 +25,37 @@

[PATCH 03/24] pdbout: Output function details.

2021-03-20 Thread Mark Harmstone
--- gcc/pdbout.c | 149 +-- gcc/pdbout.h | 12 + 2 files changed, 158 insertions(+), 3 deletions(-) diff --git a/gcc/pdbout.c b/gcc/pdbout.c index feaab37cc37..17011134d7a 100644 --- a/gcc/pdbout.c +++ b/gcc/pdbout.c @@ -29,14 +29,25 @@ #inclu

[PATCH 01/24] Add -gcodeview debugging option

2021-03-20 Thread Mark Harmstone
This is a series of patches to allow gcc to emit debugging information in the PE-specific CodeView format, which allows Microsoft debuggers to work with mingw EXEs. The format is semi-documented: Microsoft have open-sourced some of their header files at https://github.com/microsoft/microsoft-pdb, a

[PATCH v2] x86: Check cfun != NULL before accessing silent_p

2021-03-20 Thread H.J. Lu via Gcc-patches
On Sat, Mar 20, 2021 at 6:46 AM Martin Liška wrote: > > On 3/20/21 1:21 PM, H.J. Lu wrote: > > |Since construct_container may be called with cfun == NULL, check cfun != > > NULL before accessing silent_p. | > > Thank you for the quick fix. > > Please use the minimal reproducer for a test-case: >

Re: 回复: [PATCH v4 1/2] MIPS: Not trigger error for pre-R6 and -mcompact-branches=always

2021-03-20 Thread Jeff Law via Gcc-patches
On 3/3/2021 8:33 PM, yunqiang...@cipunited.com wrote: On 2/23/21 3:14 AM, YunQiang Su wrote: For MIPSr6, we may wish to use compact-branches only. Currently, we have to use `always' option, while it is mark as conflict with pre-R6. cc1: error: unsupported combination: ‘mips32r2’ -mcompact-b

Re: [PATCH] cprop_hardreg: Ensure replacement reg has compatible mode [PR99221]

2021-03-20 Thread Jeff Law via Gcc-patches
On 3/12/2021 10:54 AM, Stefan Schulze Frielinghaus via Gcc-patches wrote: In addition to the existing check also ask the target whether a replacement register may be accessed in a different mode than it was set before. Bootstrapped and regtested on IBM Z. Ok for mainline? gcc/ChangeLog:

Re: [PATCH] c-family: Fix PR94272 -fcompare-debug issue even for C [PR99230]

2021-03-20 Thread Jeff Law via Gcc-patches
On 3/18/2021 2:48 AM, Jakub Jelinek via Gcc-patches wrote: Hi! The following testcase results in -fcompare-debug failure. The problem is the similar like in PR94272 https://gcc.gnu.org/pipermail/gcc-patches/2020-March/542562.html When genericizing, with -g0 we have just a TREE_SIDE_EFFECTS DO_

Re: enable sqrt insns for cdce3.c

2021-03-20 Thread Jeff Law via Gcc-patches
On 3/9/2021 11:30 PM, Alexandre Oliva wrote: The test expects shrink-wrapping of the fsqrt call, but that will only occur when there is a usable sqrt insn. Arrange for dejagnu to add the options that enable the sqrt insn, if one is available, and to skip the test otherwise. H-P, this *should

Re: [PATCH] Fix typo in gcc/asan.c comment

2021-03-20 Thread Jeff Law via Gcc-patches
On 3/7/2021 4:10 PM, Ahamed Husni via Gcc-patches wrote: Hi all, This is my first contribution for an open source project. Please guide me if anything is missing. diff --git a/gcc/gcc/asan.c b/gcc/gcc/asan.c index 89ecd99b182..836f50bd44a 100755 --- a/gcc/gcc/asan.c +++ b/gcc/gcc/asan.c @

[committed] [PR99680] Check empty constraint before using CONSTRAINT_LEN.

2021-03-20 Thread Vladimir Makarov via Gcc-patches
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99680 The patch was successfully bootstrapped on x86-64. commit c1ab0c0336d85f5e97739060ecf77fd05ac86d2a Author: Vladimir N. Makarov Date: Sat Mar 20 10:50:03 2021 -0400 [PR99680] Check empty constraint before using

Re: [committed] libstdc++: Add std::is_scoped_enum for C++23

2021-03-20 Thread Tim Song via Gcc-patches
On Sat, Mar 20, 2021 at 3:58 AM Jonathan Wakely wrote: > > > > On Sat, 20 Mar 2021, 01:13 Tim Song via Libstdc++, > wrote: >> >> On Fri, Mar 19, 2021 at 3:13 PM Jonathan Wakely via Libstdc++ >> wrote: >> > >> > Implement this C++23 feature, as proposed by P1048R1. >> > >> > This implementation

Re: [PATCH] x86: Check cfun != NULL before accessing silent_p

2021-03-20 Thread Martin Liška
On 3/20/21 1:21 PM, H.J. Lu wrote: |Since construct_container may be called with cfun == NULL, check cfun != NULL before accessing silent_p. | Thank you for the quick fix. Please use the minimal reproducer for a test-case: $ cat va-arg-pack-1.C #include void abort() { double ld; va_list

[PATCH] x86: Check cfun != NULL before accessing silent_p

2021-03-20 Thread H.J. Lu via Gcc-patches
Since construct_container may be called with cfun == NULL, check cfun != NULL before accessing silent_p. gcc/ PR target/99679 * config/i386/i386.c (construct_container): Check cfun != NULL before accessing silent_p. gcc/testsuite/ PR target/99679 * g++.ta

Re: [patch, fortran] Also use size estimate for vector-matrix matmul

2021-03-20 Thread Thomas Koenig via Gcc-patches
Hi Jerry and Steve, Yes Ok for trunk. Thanks for the heads-up and the review, committed as r11-7742. Best regards Thomas

Re: [committed] libstdc++: Add std::is_scoped_enum for C++23

2021-03-20 Thread Jonathan Wakely via Gcc-patches
On Sat, 20 Mar 2021, 01:13 Tim Song via Libstdc++, wrote: > On Fri, Mar 19, 2021 at 3:13 PM Jonathan Wakely via Libstdc++ > wrote: > > > > Implement this C++23 feature, as proposed by P1048R1. > > > > This implementation assumes that a C++23 compiler supports concepts > > already. I don't see an