Re: [PATCH] Add type arg to TARGET_LIBC_HAS_FUNCTION

2020-09-28 Thread Richard Biener via Gcc-patches
On Mon, Sep 28, 2020 at 7:28 PM Tom de Vries wrote: > > [ was: Re: [Patch][nvptx] return true in libc_has_function for > function_sincos ] > > On 9/26/20 6:47 PM, Tobias Burnus wrote: > > Found when looking at PR97203 (but having no effect there). > > > > The GCC ME optimizes with -O1 (or higher)

RE: [PATCH v2 3/16]middle-end Add basic SLP pattern matching scaffolding.

2020-09-28 Thread Richard Biener
On Mon, 28 Sep 2020, Tamar Christina wrote: > > > > -Original Message- > > From: Gcc-patches On Behalf Of Tamar > > Christina > > Sent: Monday, September 28, 2020 3:56 PM > > To: Richard Biener > > Cc: nd ; gcc-patches@gcc.gnu.org; o...@ucw.cz > > Subject: RE: [PATCH v2 3/16]middle-end

RE: [PATCH v2 5/16]middle-end: Add shared machinery for matching patterns involving complex numbers.

2020-09-28 Thread Richard Biener
On Mon, 28 Sep 2020, Tamar Christina wrote: > Hi Richi, > > > -Original Message- > > From: rguent...@c653.arch.suse.de On > > Behalf Of Richard Biener > > Sent: Monday, September 28, 2020 2:22 PM > > To: Tamar Christina > > Cc: gcc-patches@gcc.gnu.org; nd ; o...@ucw.cz > > Subject: Re:

[PATCH] arm&aarch64: subdivide the type attribute "alu_shfit_imm"

2020-09-28 Thread Qian Jianhua
The type attribute "alu_shfit_imm" is subdivided into "alu_shift_imm_lsl_1to4" and "alu_shift_imm_other", to accommodate optimazations of some microarchitectures. Here is the detailed discussion. https://gcc.gnu.org/pipermail/gcc/2020-September/233594.html ChangeLog: 2020-09-29 Qian jianhua gcc

[PATCH] Fix GCC 10+ build failure with zstd version 1.2.0 or older.

2020-09-28 Thread Jim Wilson
Extends the configure check for zstd.h to also verify the zstd version, since gcc requires features that only exist in 1.3.0 and newer. Without this patch we get a build error for lto-compress.c when using an old zstd version. Tested with builds using zstd 0.5.1, 1.2.0, 1.3.0, and 1.3.3, and chec

Re: [PATCH] RISC-V/libgcc: Use `-fasynchronous-unwind-tables' for LIB2_DIVMOD_FUNCS

2020-09-28 Thread Maciej W. Rozycki
Hi Jim, > On Sun, Aug 30, 2020 at 11:39 PM Kito Cheng wrote > > Hi Maciej: > > LGTM, thanks for your patch! > > I don't see this patch in the FSF GCC tree. Maciej are you going to > commit it? Or do you want us to commit it for you? Since my departure from WDC I have been largely away, trave

[committed] analyzer: remove unused field

2020-09-28 Thread David Malcolm via Gcc-patches
I added this field (and the struct itself) in the rewrite of region and value-handling (808f4dfeb3a95f50f15e71148e5c1067f90a126d), but the field was never used. Found by cppcheck. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 20d16d61dd22a9bfb66d5c4a383d193037

[committed] analyzer: add some missing FINAL OVERRIDEs

2020-09-28 Thread David Malcolm via Gcc-patches
Spotted by cppcheck. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as c0ed6afef7897f32dc199da9a5430664fcbb61bb. gcc/analyzer/ChangeLog: * region-model.h (binop_svalue::dyn_cast_binop_svalue): Remove redundant "virtual". Add FINAL OVERRIDE.

[committed] analyzer: fix ICE on non-pointer longjmp [PR97233]

2020-09-28 Thread David Malcolm via Gcc-patches
Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as r11-3512-g01eabbeadb645959d5dcb0f00f41c3565a8f54f1. gcc/analyzer/ChangeLog: PR analyzer/97233 * analyzer.cc (is_longjmp_call_p): Require the initial argument to be a pointer. * engine

[committed] analyzer: fix sm_state_map::print

2020-09-28 Thread David Malcolm via Gcc-patches
In 10fc42a8396072912e9d9d940fba25950b3fdfc5 I converted state_t from unsigned to const state *, but missed this comparison against 0. Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu. Pushed to master as 53d28fd4e16f163a9bd0c323f432914804f1348a. gcc/analyzer/ChangeLog: * prog

Re: [Patch, Fortran] libgomp: Silence unpack's may be used uninitialized warning

2020-09-28 Thread Damian Rouson
I've been seeing similar messages to this one for quite some time now -- I think ~1 year. I don't often use unpack so there are likely many other causes too. I haven't take the time to isolate them, but if I can do so easily, I'll submit reports. Damian On Mon, Sep 28, 2020 at 2:12 PM Tobias Bu

Re: [PATCH] New patch for the port of gccgo to GNU/Hurd

2020-09-28 Thread Ian Lance Taylor via Gcc-patches
On Fri, Sep 25, 2020 at 8:04 AM Svante Signell wrote: > > Latest Debian snapshot of gcc (20200917-1) FTBFS due to a missing hurd > entry in the // +build line of libgo/go/net/fd_posix.go. Attached is a > patch for that missing entry. Thanks. Committed to mainline. Ian

Re: [PATCH, rs6000] Add non-relative jump table support on Power Linux

2020-09-28 Thread Segher Boessenkool
Hi hao Chen, On Wed, Sep 09, 2020 at 04:55:29PM +0800, HAO CHEN GUI wrote: >     Thanks for your advice. I removed macros defined in linux64.h and > linux.h. So they take relative jump tables by default. When > no-relative-jumptables is set, the absolute jump tables are taken. All > things rele

[PATCH] c++: Diagnose visitors with different return types for std::visit [PR95904]

2020-09-28 Thread Ville Voutilainen via Gcc-patches
Not completely tested yet. This does fix the problem of converting incompatible pointer-to-function types, and thus gets rid of the suggestion that compiling the code with -fpermissive is a possibility. There is a special-casing for visit() for visitation of a single variant, and there we don't eve

Re: [PING][PATCH] correct handling of indices into arrays with elements larger than 1 (PR c++/96511)

2020-09-28 Thread Martin Sebor via Gcc-patches
On 9/25/20 11:17 PM, Jason Merrill wrote: On 9/22/20 4:05 PM, Martin Sebor wrote: The rebased and retested patches are attached. On 9/21/20 3:17 PM, Martin Sebor wrote: Ping: https://gcc.gnu.org/pipermail/gcc-patches/2020-September/553906.html (I'm working on rebasing the patch on top of the

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Thomas Rodgers via Gcc-patches
Jonathan Wakely writes: > On 11/09/20 16:58 -0700, Thomas Rodgers wrote: >>From: Thomas Rodgers >> >>This patch supercedes both the Add C++2a synchronization support patch >>being replied to *and* the patch adding wait/notify_* to atomic_flag. >> >>Add support for - >> * atomic_flag::wait/noti

[Patch, Fortran] libgomp: Silence unpack's may be used uninitialized warning

2020-09-28 Thread Tobias Burnus
There are more warnings, but I picked this one which shows up with default build options for GCC trunk – twice for each generated file: ../../../../repos/gcc/libgfortran/generated/unpack_i2.c:128:12: warning: ‘rstride’ may be used uninitialized [-Wmaybe-uninitialized] ../../../../repos/gcc/libgf

libbacktrace patch committed: Create mtest.dsym

2020-09-28 Thread Ian Lance Taylor via Gcc-patches
This libbacktrace patch creates mtest.dsym when using dsymutil. This is for PR 97082, but it probably doesn't fix the PR. Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. Committed to mainline. Ian PR libbacktrace/97082 * Makefile.am (check_DATA): Add mtest.dSYM if USE_DSYMUTIL.

Re: [PATCH] c++: Incomplete parameter mappings during normalization

2020-09-28 Thread Patrick Palka via Gcc-patches
On Mon, 28 Sep 2020, Jason Merrill wrote: > On 9/25/20 4:44 PM, Patrick Palka wrote: > > In the testcase concepts7.C below, we currently reject the call to f1 > > but we accept the call to f2, even though their associated constraints > > are functionally equivalent. > > Rather, because they are n

libbacktrace patch committed: Only use dsymutil with Mach-O

2020-09-28 Thread Ian Lance Taylor via Gcc-patches
This patch changes the libbacktrace tests to only run dsymutil when building for Mach-O. This should fix GCC PR 97227. Bootstrapped and ran libbacktrace tests on x86_64-pc-linux-gnu. Committed to mainline. Ian PR libbacktrace/97227 * configure.ac (USE_DSYMUTIL): Define instead of HAVE_DSYMUTIL

Re: [PATCH] options: Save and restore opts_set for Optimization and Target options

2020-09-28 Thread Jakub Jelinek via Gcc-patches
On Mon, Sep 28, 2020 at 09:50:00PM +0200, Stefan Schulze Frielinghaus wrote: > This patch breaks quite a view test cases (target-attribute/tattr-*) on > IBM Z. Having a look at function cl_target_option_restore reveals that > some members of opts_set are reduced to 1 or 0 depending on whether a >

Re: [PATCH] arm: Add a couple of extra stack-protector tests

2020-09-28 Thread Christophe Lyon via Gcc-patches
On Wed, 23 Sep 2020 at 20:33, Richard Sandiford wrote: > > These tests were inspired by the corresponding aarch64 ones that I just > committed. They already pass. > > Tested on arm-linux-gnueabi, arm-linux-gnueabihf and armeb-eabi. > OK for trunk? > > Richard > > > gcc/testsuite/ > * gcc.

Re: [PATCH] options: Save and restore opts_set for Optimization and Target options

2020-09-28 Thread Stefan Schulze Frielinghaus via Gcc-patches
On Sun, Sep 13, 2020 at 10:29:22AM +0200, Jakub Jelinek via Gcc-patches wrote: > On Fri, Sep 11, 2020 at 11:29:52AM +0200, Jakub Jelinek via Gcc-patches wrote: > > On Fri, Sep 11, 2020 at 09:46:37AM +0200, Christophe Lyon via Gcc-patches > > wrote: > > > I'm seeing an ICE with this new test on mos

Re: [PATCH] RISC-V/libgcc: Use `-fasynchronous-unwind-tables' for LIB2_DIVMOD_FUNCS

2020-09-28 Thread Jim Wilson
On Sun, Aug 30, 2020 at 11:39 PM Kito Cheng wrote > Hi Maciej: > LGTM, thanks for your patch! I don't see this patch in the FSF GCC tree. Maciej are you going to commit it? Or do you want us to commit it for you? Jim

Re: [PATCH] RISC-V: Define __riscv_cmodel_medany for PIC mode.

2020-09-28 Thread Jim Wilson
On Thu, Sep 24, 2020 at 10:46 PM Kito Cheng wrote: > > - According the conclusion in RISC-V C API document, we decide to deprecat >the __riscv_cmodel_pic marco > > - __riscv_cmodel_pic is deprecated and will removed in next GCC >release. Looks good to me. By the way, you can self appro

Re: [PATCH] c++: Incomplete parameter mappings during normalization

2020-09-28 Thread Jason Merrill via Gcc-patches
On 9/25/20 4:44 PM, Patrick Palka wrote: In the testcase concepts7.C below, we currently reject the call to f1 but we accept the call to f2, even though their associated constraints are functionally equivalent. Rather, because they are not functionally equivalent. The reason satisfaction diff

Re: [PATCH] tree-optimization/97151 - improve PTA for C++ operator delete

2020-09-28 Thread Jason Merrill via Gcc-patches
On 9/28/20 3:56 AM, Richard Biener wrote: On Fri, 25 Sep 2020, Jason Merrill wrote: On 9/25/20 2:30 AM, Richard Biener wrote: On Thu, 24 Sep 2020, Jason Merrill wrote: On 9/24/20 3:43 AM, Richard Biener wrote: On Wed, 23 Sep 2020, Jason Merrill wrote: On 9/23/20 2:42 PM, Richard Biener wr

Re: [PATCH v3] c++: Implement -Wrange-loop-construct [PR94695]

2020-09-28 Thread Jason Merrill via Gcc-patches
On 9/28/20 12:30 PM, Marek Polacek wrote: On Sat, Sep 26, 2020 at 01:22:41AM -0400, Jason Merrill wrote: +bool +ref_conv_binds_directly_p (tree type, tree expr) +{ + gcc_assert (TYPE_REF_P (type)); + conversion *conv = implicit_conversion (type, TREE_TYPE (expr), expr, +

Re: [OG10] Backporting + merge of GCC 10 into branch + pre-applying (OpenMP: Handle cpp_implicit_alias in declare-target discovery)

2020-09-28 Thread Tobias Burnus
On 9/18/20 7:51 PM, Tobias Burnus wrote: On 9/17/20 7:04 PM, Tobias Burnus wrote: OG10 = devel/omp/gcc-10 Added additionally: And now: 3a857fecdc2 Merge remote-tracking branch 'origin/releases/gcc-10' into devel/omp/gcc-10 845a9a25733 OpenMP: Handle cpp_implicit_alias in declare-target di

[patch] Do not use doloop pattern with pragma Unroll

2020-09-28 Thread Eric Botcazou
Hi, this fixes the following Ada failure on 64-bit PowerPC: -FAIL: gnat.dg/unroll4.adb scan-rtl-dump-times loop2_unroll "optimized: loop unrolled 7 times" 2 The IVOPTS pass detects a doloop pattern and consequently discombobulates the loop sufficiently as to make it hard for the RTL unrolling

Re: [PATCH v3] c, c++: Implement -Wsizeof-array-div [PR91741]

2020-09-28 Thread Marek Polacek via Gcc-patches
On Tue, Sep 22, 2020 at 04:07:41PM -0400, Jason Merrill wrote: > On 9/22/20 1:29 PM, Marek Polacek wrote: > > Ping. > > The C++ change is OK. Ping for the C parts. > > On Tue, Sep 15, 2020 at 04:33:05PM -0400, Marek Polacek via Gcc-patches > > wrote: > > > On Tue, Sep 15, 2020 at 09:04:41AM +02

Re: [PATCH] c++: Implement -Wrange-loop-construct [PR94695]

2020-09-28 Thread Marek Polacek via Gcc-patches
On Fri, Sep 25, 2020 at 04:31:16PM -0600, Martin Sebor wrote: > On 9/24/20 6:05 PM, Marek Polacek via Gcc-patches wrote: > > This new warning can be used to prevent expensive copies inside range-based > > for-loops, for instance: > > > >struct S { char arr[128]; }; > >void fn () { > >

[PATCH] Add type arg to TARGET_LIBC_HAS_FUNCTION

2020-09-28 Thread Tom de Vries
[ was: Re: [Patch][nvptx] return true in libc_has_function for function_sincos ] On 9/26/20 6:47 PM, Tobias Burnus wrote: > Found when looking at PR97203 (but having no effect there). > > The GCC ME optimizes with -O1 (or higher) the >   a = sinf(x) >   b = cosf(x) > to __builtin_cexpi(x, &a, &b)

RE: [PATCH v2 3/16]middle-end Add basic SLP pattern matching scaffolding.

2020-09-28 Thread Tamar Christina
> -Original Message- > From: Gcc-patches On Behalf Of Tamar > Christina > Sent: Monday, September 28, 2020 3:56 PM > To: Richard Biener > Cc: nd ; gcc-patches@gcc.gnu.org; o...@ucw.cz > Subject: RE: [PATCH v2 3/16]middle-end Add basic SLP pattern matching > scaffolding. > > Hi Richi,

[committed] aarch64: Fix ordering of aarch64-cores.def

2020-09-28 Thread Alex Coplan
Hi all, This patch moves the entry for Neoverse N2 (an Armv8.5-A CPU) after Saphira (an Armv8.4-A CPU) to preserve the overall ordering in the file. Committing as obvious. Thanks, Alex --- gcc/ChangeLog: * config/aarch64/aarch64-cores.def: Move neoverse-n2 after saphira. * con

Re: [PATCH v2] builtins: rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-09-28 Thread will schmidt via Gcc-patches
On Fri, 2020-09-04 at 12:52 -0300, Raoni Fassina Firmino via Gcc-patches wrote: > Changes since v1[1]: > - Fixed english spelling; > - Fixed code-style; > - Changed match operand predicate in feclearexcept and feraiseexcept; > - Changed testcase options; > - Minor changes in test code to

Re: [PATCH v3] c++: Implement -Wrange-loop-construct [PR94695]

2020-09-28 Thread Marek Polacek via Gcc-patches
On Sat, Sep 26, 2020 at 01:22:41AM -0400, Jason Merrill wrote: > > +bool > > +ref_conv_binds_directly_p (tree type, tree expr) > > +{ > > + gcc_assert (TYPE_REF_P (type)); > > + conversion *conv = implicit_conversion (type, TREE_TYPE (expr), expr, > > + /*c_cas

Re: [PATCH] Add Missing FSF copyright notes for some x86 intrinsic headers

2020-09-28 Thread H.J. Lu via Gcc-patches
On Mon, Sep 28, 2020 at 9:04 AM Hongyu Wang via Gcc-patches wrote: > > Hi, > > Some x86 intrinsic headers is missing FSF copyright notes. This patch add > the missed notes for those headers. > > OK for master? > > gcc/ChangeLog: > > * config/i386/amxbf16intrin.h: Add FSF copyright notes. > * confi

RE: [PATCH v2 5/16]middle-end: Add shared machinery for matching patterns involving complex numbers.

2020-09-28 Thread Tamar Christina
Hi Richi, > -Original Message- > From: rguent...@c653.arch.suse.de On > Behalf Of Richard Biener > Sent: Monday, September 28, 2020 2:22 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; o...@ucw.cz > Subject: Re: [PATCH v2 5/16]middle-end: Add shared machinery for matching >

[PATCH] Add Missing FSF copyright notes for some x86 intrinsic headers

2020-09-28 Thread Hongyu Wang via Gcc-patches
Hi, Some x86 intrinsic headers is missing FSF copyright notes. This patch add the missed notes for those headers. OK for master? gcc/ChangeLog: * config/i386/amxbf16intrin.h: Add FSF copyright notes. * config/i386/amxint8intrin.h: Ditto. * config/i386/amxtileintrin.h: Ditto. * config/i386/avx51

Re: Fix handling of gimple_clobber in ipa_modref

2020-09-28 Thread Jan Hubicka
> Hi Honza, > > > On Sat, 26 Sep 2020 at 22:03, Jan Hubicka wrote: > > > > > On September 26, 2020 12:04:24 AM GMT+02:00, Jan Hubicka > > > wrote: > > > >Hi, > > > >while adding check for gimple_clobber I reversed the return value > > > >so instead of ignoring the statement ipa-modref gives up

Re: [PATCH] irange_pool class

2020-09-28 Thread Andrew MacLeod via Gcc-patches
On 9/18/20 1:03 PM, Aldy Hernandez wrote: On 9/18/20 6:42 PM, Andrew MacLeod wrote: On 9/18/20 8:28 AM, David Malcolm wrote:I think of a "pool allocator" as something that makes a small number of large allocation under the covers, and then uses that to serve large numbers of fixed sized small a

Re: [PATCH] generalized range_query class for multiple contexts

2020-09-28 Thread Andrew MacLeod via Gcc-patches
On 9/28/20 11:27 AM, Martin Sebor wrote: On 9/25/20 11:41 AM, Andrew MacLeod wrote: Since you have replied to this thread, whats your opinion whether there should be an extra API entry point for range/value_after_stmt or whether that should be rolled into  the range_of_stmt routine, and an

Re: [PATCH 4/4] libstdc++: Rearrange some range adaptors' data members

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 28/09/20 09:11 -0400, Patrick Palka via Libstdc++ wrote: On Mon, 28 Sep 2020, Jonathan Wakely wrote: On 28/09/20 00:48 -0400, Patrick Palka via Libstdc++ wrote: > Since the standard range adaptors are specified to derive from the empty > class view_base, making their first data member store

Re: Fix handling of gimple_clobber in ipa_modref

2020-09-28 Thread Christophe Lyon via Gcc-patches
Hi Honza, On Sat, 26 Sep 2020 at 22:03, Jan Hubicka wrote: > > > On September 26, 2020 12:04:24 AM GMT+02:00, Jan Hubicka > > wrote: > > >Hi, > > >while adding check for gimple_clobber I reversed the return value > > >so instead of ignoring the statement ipa-modref gives up. Fixed thus. > > >

Re: [PATCH] generalized range_query class for multiple contexts

2020-09-28 Thread Martin Sebor via Gcc-patches
On 9/25/20 11:41 AM, Andrew MacLeod wrote: On 9/23/20 7:53 PM, Martin Sebor via Gcc-patches wrote: On 9/18/20 12:38 PM, Aldy Hernandez via Gcc-patches wrote: As part of the ranger work, we have been trying to clean up and generalize interfaces whenever possible. This not only helps in reducing

RE: [PATCH v2 3/16]middle-end Add basic SLP pattern matching scaffolding.

2020-09-28 Thread Tamar Christina
Hi Richi, Thanks for the review! Just some answers to your questions: > -Original Message- > From: rguent...@c653.arch.suse.de On > Behalf Of Richard Biener > Sent: Monday, September 28, 2020 1:37 PM > To: Tamar Christina > Cc: gcc-patches@gcc.gnu.org; nd ; o...@ucw.cz > Subject: Re:

Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-28 Thread Tom de Vries
On 9/28/20 4:17 PM, Andrew Stubbs wrote: > On 28/09/2020 15:02, Tom de Vries wrote: >>> This patch simply skips barriers when they would "wait" for only one >>> thread (the current thread). This means that teams nested inside other >>> teams now run independently, instead of strictly in lock-step,

Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-28 Thread Andrew Stubbs
On 28/09/2020 15:02, Tom de Vries wrote: This patch simply skips barriers when they would "wait" for only one thread (the current thread). This means that teams nested inside other teams now run independently, instead of strictly in lock-step, and is only valid as long as inner teams are limited

Re: dg-options after board/cflags

2020-09-28 Thread Jose E. Marchesi via Gcc-patches
>> Your patch dealt with board/multilib_flags, but the same problem exists >> for board/cflags and many other flag-containing options. > > What's the use case for that? IIUC board flags are supposed to be ones > that are absolutely required for executables to run with a given board, > such as

Re: [PATCH] amdgcn, nvptx: Disable OMP barriers in nested teams

2020-09-28 Thread Tom de Vries
On 9/18/20 1:25 PM, Andrew Stubbs wrote: > This patch fixes a problem in which nested OpenMP parallel regions cause > errors if the number of inner teams is not balanced (i.e. the number of > loop iterations is not divisible by the number of physical threads). A > testcase is included. > > On NVPT

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 11/09/20 16:58 -0700, Thomas Rodgers wrote: From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_o

RE: [PATCH v2 9/16][docs] Add some missing test directive documentaion.

2020-09-28 Thread Tamar Christina
Hi Sandra, > -Original Message- > From: Sandra Loosemore > Sent: Friday, September 25, 2020 10:35 PM > To: Tamar Christina ; gcc-patches@gcc.gnu.org > Cc: nd ; jos...@codesourcery.com > Subject: Re: [PATCH v2 9/16][docs] Add some missing test directive > documentaion. > > On 9/25/20 8:29

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 11/09/20 16:58 -0700, Thomas Rodgers wrote: From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_o

Re: [PATCH] libstdc++: Add C++2a synchronization support

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 11/09/20 16:58 -0700, Thomas Rodgers wrote: From: Thomas Rodgers This patch supercedes both the Add C++2a synchronization support patch being replied to *and* the patch adding wait/notify_* to atomic_flag. Add support for - * atomic_flag::wait/notify_one/notify_all * atomic::wait/notify_o

Re: [PATCH v2 5/16]middle-end: Add shared machinery for matching patterns involving complex numbers.

2020-09-28 Thread Richard Biener
On Fri, 25 Sep 2020, Tamar Christina wrote: > Hi All, > > This patch adds shared machinery for detecting patterns having to do with > complex number operations. The class ComplexPattern provides helpers for > matching and ultimately undoing the permutation in the tree by rebuilding the > graph.

Re: [PATCH 4/4] libstdc++: Rearrange some range adaptors' data members

2020-09-28 Thread Patrick Palka via Gcc-patches
On Mon, 28 Sep 2020, Jonathan Wakely wrote: > On 28/09/20 00:48 -0400, Patrick Palka via Libstdc++ wrote: > > Since the standard range adaptors are specified to derive from the empty > > class view_base, making their first data member store the underlying > > view is suboptimal, for if the underly

Re: Ping [PATCH] RX add control register PC

2020-09-28 Thread Darius Galis
Hello, Could you please let me know the status of this patch? Thank you, Darius Galis On 26-Aug-20 1:24 PM, Darius Galis wrote: Hello, Thank you for adjusting the patch. I don't have commit privileges, so if you could please commit it, that would be great. Best regards, Darius Galis On 25-Au

Re: [PATCH v2 4/16]middle-end: Add dissolve code for when SLP fails and non-SLP loop vectorization is to be tried.

2020-09-28 Thread Richard Biener
On Fri, 25 Sep 2020, Tamar Christina wrote: > Hi All, > > This adds the dissolve code to undo the patterns created by the pattern > matcher > in case SLP is to be aborted. > > As mentioned in the cover letter this has one issue in that the number of > copies > can needed can change depending o

Re: [PATCH v2] builtins: rs6000: Add builtins for fegetround, feclearexcept and feraiseexcept [PR94193]

2020-09-28 Thread Raoni Fassina Firmino via Gcc-patches
Ping.

Re: [PATCH v2 3/16]middle-end Add basic SLP pattern matching scaffolding.

2020-09-28 Thread Richard Biener
On Fri, 25 Sep 2020, Tamar Christina wrote: > Hi All, > > This patch adds the basic infrastructure for doing pattern matching on SLP > trees. > This is done immediately after the SLP tree creation because it can change the > shape of the tree in radical ways and so we would like to do it before

Re: [PATCH] Enable GCC support for AMX

2020-09-28 Thread Hongyu Wang via Gcc-patches
Thanks! I'll ask my colleague to help check in the patch. Kirill Yukhin 于2020年9月28日周一 下午7:38写道: > Hello, > > On 12 сен 01:00, Hongyu Wang wrote: > > Hi > > > > Thanks for your review, and sorry for the late reply. It took a while > > to finish the runtime test. > > Thanks for your fixes! The pa

Re: [PATCH v2 1/16]middle-end: Refactor refcnt to use SLP_TREE_REF_COUNT for consistency

2020-09-28 Thread Richard Biener
On Fri, 25 Sep 2020, Tamar Christina wrote: > Hi All, > > This is a small refactoring which introduces SLP_TREE_REF_COUNT and replaces > the uses of refcnt with it. This for consistency between the other > properties. > > A similar patch was pre-approved last year but since there are more use

Re: [PATCH v2 0/16][RFC][AArch64/Arm/SVE/SVE2/MVE]middle-end Add support for SLP vectorization of complex number instructions.

2020-09-28 Thread Richard Biener
On Fri, 25 Sep 2020, Tamar Christina wrote: > Hi All, > > This patch series adds support for SLP vectorization of complex instructions > [1]. > > These instructions exist only in their vector forms and require you to > recognize > two statements in parallel. Complex operations usually require

Re: [PATCH] Enable GCC support for AMX

2020-09-28 Thread Kirill Yukhin via Gcc-patches
Hello, On 12 сен 01:00, Hongyu Wang wrote: > Hi > > Thanks for your review, and sorry for the late reply. It took a while > to finish the runtime test. Thanks for your fixes! The patch is OK for trunk. -- Thanks, K

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Richard Biener
On Mon, 28 Sep 2020, Jan Hubicka wrote: > > On Mon, 28 Sep 2020, Jan Hubicka wrote: > > > > > > > > > > Hmm, no - it expects the gimple_call_use/clobber_set to include > > > > actions of the called function itself (const functions none here) > > > > but for passed-by-value the loads may be in th

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Jan Hubicka
> On Mon, 28 Sep 2020, Jan Hubicka wrote: > > > > > > > Hmm, no - it expects the gimple_call_use/clobber_set to include > > > actions of the called function itself (const functions none here) > > > but for passed-by-value the loads may be in the call itself > > > which is where it uses gimple_cal

Re: [PATCH V2] aarch64: Do not alter force_reg returned rtx expanding pauth builtins

2020-09-28 Thread Andrea Corallo
Richard Sandiford writes: > Andrea Corallo writes: >> Hi all, >> >> here the reworked patch addressing Richard's suggestions. >> >> Regtested and bootsraped on aarch64-linux-gnu. >> >> Okay for trunk? > > OK, thanks. > > Richard Into trunk as 92f0d3d03a7. Thanks! Andrea

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Richard Biener
On Mon, 28 Sep 2020, Jan Hubicka wrote: > > > > Hmm, no - it expects the gimple_call_use/clobber_set to include > > actions of the called function itself (const functions none here) > > but for passed-by-value the loads may be in the call itself > > which is where it uses gimple_call_arg_flags to

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Jan Hubicka
> > Hmm, no - it expects the gimple_call_use/clobber_set to include > actions of the called function itself (const functions none here) > but for passed-by-value the loads may be in the call itself > which is where it uses gimple_call_arg_flags to skip unused ones. > > But note that PTA uses gimp

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Richard Biener
On Mon, 28 Sep 2020, Jan Hubicka wrote: > > On Mon, 28 Sep 2020, Jan Hubicka wrote: > > > > > Hi, > > > ipa-reference, ipa-pure-const and ipa-modref could use the knowledge > > > about bulitins which is currently harwired into > > > ref_maybe_used_by_call_p_1, call_may_clobber_ref_p_1 and the PTA

Re: [PATCH V2] aarch64: Do not alter force_reg returned rtx expanding pauth builtins

2020-09-28 Thread Richard Sandiford
Andrea Corallo writes: > Hi all, > > here the reworked patch addressing Richard's suggestions. > > Regtested and bootsraped on aarch64-linux-gnu. > > Okay for trunk? OK, thanks. Richard

Re: [PATCH 4/4] libstdc++: Rearrange some range adaptors' data members

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 28/09/20 00:48 -0400, Patrick Palka via Libstdc++ wrote: Since the standard range adaptors are specified to derive from the empty class view_base, making their first data member store the underlying view is suboptimal, for if the underlying view also derives from view_base then the two view_ba

Re: [PATCH 3/4] libstdc++: Add test that tracks range adaptors' sizes

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 28/09/20 00:48 -0400, Patrick Palka via Libstdc++ wrote: libstdc++-v3/ChangeLog: * testsuite/std/ranges/adaptors/sizeof.cc: New test. OK. .../testsuite/std/ranges/adaptors/sizeof.cc | 49 +++ 1 file changed, 49 insertions(+) create mode 100644 libstdc++-v3/testsui

Re: [PATCH 1/4] libstdc++: Reduce the size of an unbounded iota_view

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 28/09/20 00:48 -0400, Patrick Palka via Libstdc++ wrote: libstdc++-v3/ChangeLog: * include/std/ranges (iota_view::_M_bound): Give it [[no_unique_address]]. * testsuite/std/ranges/iota/iota_view.cc: Check that an unbounded iota_view has minimal size. OK. lib

Re: [PATCH 2/4] libstdc++: Reduce the size of a subrange with empty sentinel type

2020-09-28 Thread Jonathan Wakely via Gcc-patches
On 28/09/20 00:48 -0400, Patrick Palka via Libstdc++ wrote: libstdc++-v3/ChangeLog: * include/bits/ranges_util.h (subrange::_M_end): Give it [[no_unique_adcress]]. * testsuite/std/ranges/subrange/sizeof.cc: New test. OK. libstdc++-v3/include/bits/ranges_util.h |

[PATCH 2/2] arm: Improve handling of relocations with small offsets with -mpure-code on v6m (PR96770)

2020-09-28 Thread Christophe Lyon via Gcc-patches
With -mpure-code on v6m (thumb-1), we can use small offsets with upper/lower relocations to avoid the extra addition of the offset. This patch accepts expressions symbol+offset as legitimate constants when the literal pool is disabled, making sure that the offset is within the range supported by t

[PATCH 1/2] arm: Avoid indirection with -mpure-code on v6m (PR96967)

2020-09-28 Thread Christophe Lyon via Gcc-patches
With -mpure-code on v6m (thumb-1), to avoid a useless indirection when building the address of a symbol, we want to consider SYMBOL_REF as a legitimate constant. This way, we build the address using a series of upper/lower relocations instead of loading the address from memory. This patch also fix

[PATCH V2] aarch64: Do not alter force_reg returned rtx expanding pauth builtins

2020-09-28 Thread Andrea Corallo
Hi all, here the reworked patch addressing Richard's suggestions. Regtested and bootsraped on aarch64-linux-gnu. Okay for trunk? Thanks! Andrea >From 946d22aa247f2d1bb0c6b10a6e6db415b34feff2 Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Mon, 21 Sep 2020 13:52:45 +0100 Subject: [PATCH

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Jan Hubicka
> On Mon, 28 Sep 2020, Jan Hubicka wrote: > > > Hi, > > ipa-reference, ipa-pure-const and ipa-modref could use the knowledge > > about bulitins which is currently harwired into > > ref_maybe_used_by_call_p_1, call_may_clobber_ref_p_1 and the PTA > > computation. This patch breaks out logic implem

Re: [PATCH] switch lowering: limit number of cluster attemps

2020-09-28 Thread Richard Biener via Gcc-patches
On Fri, Sep 25, 2020 at 4:15 PM Martin Liška wrote: > > On 9/25/20 3:45 PM, Richard Biener wrote: > > On Fri, Sep 25, 2020 at 3:32 PM Martin Liška wrote: > >> > >> On 9/25/20 3:18 PM, Richard Biener wrote: > >>> On Fri, Sep 25, 2020 at 11:13 AM Martin Liška wrote: > > Hello. > > >

Re: [PATCH] assorted improvements for fold_truth_andor_1

2020-09-28 Thread Richard Biener via Gcc-patches
On Fri, Sep 25, 2020 at 3:39 PM Alexandre Oliva wrote: > > > This patch introduces various improvements to the logic that merges > field compares. > > Before the patch, we could merge: > > (a.x1 EQNE b.x1) ANDOR (a.y1 EQNE b.y1) > > into something like: > > (((type *)&a)[Na] & MASK) EQNE (((

Re: [PATCH] generalized range_query class for multiple contexts

2020-09-28 Thread Aldy Hernandez via Gcc-patches
On 9/25/20 3:17 PM, Andrew MacLeod wrote: On 9/24/20 5:51 PM, Martin Sebor via Gcc-patches wrote: On 9/18/20 12:38 PM, Aldy Hernandez via Gcc-patches wrote: 3. Conversion of sprintf/strlen pass to class. This is a nonfunctional change to the sprintf/strlen passes. That is, no effort was

Re: Export info about side effects of builtins out of tree-ssa-alias.c

2020-09-28 Thread Richard Biener
On Mon, 28 Sep 2020, Jan Hubicka wrote: > Hi, > ipa-reference, ipa-pure-const and ipa-modref could use the knowledge > about bulitins which is currently harwired into > ref_maybe_used_by_call_p_1, call_may_clobber_ref_p_1 and the PTA > computation. This patch breaks out logic implemented in the f

Re: [PATCH v2 2/2] rs6000: Expand vec_insert in expander instead of gimple [PR79251]

2020-09-28 Thread Richard Biener via Gcc-patches
On Sat, Sep 26, 2020 at 12:41 AM Segher Boessenkool wrote: > > On Fri, Sep 25, 2020 at 08:58:35AM +0200, Richard Biener wrote: > > On Thu, Sep 24, 2020 at 9:38 PM Segher Boessenkool > > wrote: > > > after which I get (-march=znver2) > > > > > > setg: > > > vmovd %edi, %xmm1 > > >

Re: [PATCH] tree-optimization/97151 - improve PTA for C++ operator delete

2020-09-28 Thread Richard Biener
On Fri, 25 Sep 2020, Jason Merrill wrote: > On 9/25/20 2:30 AM, Richard Biener wrote: > > On Thu, 24 Sep 2020, Jason Merrill wrote: > > > >> On 9/24/20 3:43 AM, Richard Biener wrote: > >>> On Wed, 23 Sep 2020, Jason Merrill wrote: > >>> > On 9/23/20 2:42 PM, Richard Biener wrote: > > On

[Ada] Add missing end location information

2020-09-28 Thread Eric Botcazou
In some cases we would fail to put the end location information on the outermost BIND_EXPR of a function, which is problematic when there is a dynamic stack allocation. Tested on x86_64-suse-linux, applied on the mainline. This makes the following tweak to lower_try_finally_dup_block obsolete:

[Ada] Fix bogus alignment warning on address clause

2020-09-28 Thread Eric Botcazou
This is a regression present on the mainline and 10 branch: the compiler gives a bogus alignment warning on an address clause and a discriminated record type with variable size. Tested on x86_64-suse-linux, applied on the mainline and 10 branch. 2020-09-28 Eric Botcazou * gcc-inter