Re: *ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Paul Richard Thomas via Gcc-patches
Hi Thomas, I am fine with this being in frontend-passes.c - it was just a question :-) resolve.c has become too large anyway. The testcase looks familiar! Don't forget to commit and push the additional source too. OK for 10-- and all the affected branches. Cheers Paul On Sat, 18 Jul 2020 at

gcc.dg/attr-copy-6.c: Require visibility.

2020-07-18 Thread Hans-Peter Nilsson
Another trivial one, committed. gcc/testsuite: * gcc.dg/attr-copy-6.c: Require visibility. --- gcc/gcc/testsuite/gcc.dg/attr-copy-6.c.orig Mon Jan 13 22:30:47 2020 +++ gcc/gcc/testsuite/gcc.dg/attr-copy-6.c Sun Jul 19 05:44:12 2020 @@ -2,6 +2,7 @@ { dg-do compile } { dg-skip-

gcc.dg/Wno-frame-address.c: Skip for cris and mmix.

2020-07-18 Thread Hans-Peter Nilsson
Long-standing FAIL remedied; committed. Maybe better to list the targets that *do* support arbitrary frame access? gcc/testsuite: * gcc.dg/Wno-frame-address.c: Skip for cris and mmix. --- gcc/gcc/testsuite/gcc.dg/Wno-frame-address.c.orig Mon Jan 13 22:30:47 2020 +++ gcc/gcc/testsuite/g

Re: pragma-eof.c

2020-07-18 Thread Hans-Peter Nilsson
On Sat, 18 Jul 2020, Jakub Jelinek wrote: > On Sat, Jul 18, 2020 at 05:04:56PM -0400, David Edelsohn via Gcc-patches > wrote: > > H-P, > > > > After your patch to the testsuite, the cpp/pragma-eof.c testcase is > > failing on all targets. Would you please investigate and fix? > > That is because

Re: pragma-eof.c

2020-07-18 Thread Jakub Jelinek via Gcc-patches
On Sat, Jul 18, 2020 at 05:04:56PM -0400, David Edelsohn via Gcc-patches wrote: > H-P, > > After your patch to the testsuite, the cpp/pragma-eof.c testcase is > failing on all targets. Would you please investigate and fix? That is because the dg-error directive had line number of the last line i

Re: pragma-eof.c

2020-07-18 Thread David Edelsohn via Gcc-patches
H-P, After your patch to the testsuite, the cpp/pragma-eof.c testcase is failing on all targets. Would you please investigate and fix? Thanks, David

[PATCH] c++: Add __builtin_bit_cast to implement std::bit_cast [PR93121]

2020-07-18 Thread Jakub Jelinek via Gcc-patches
Hi! The following patch adds __builtin_bit_cast builtin, similarly to clang or MSVC which implement std::bit_cast using such an builtin too. It checks the various std::bit_cast requirements, when not constexpr evaluated acts pretty much like VIEW_CONVERT_EXPR of the source argument to the destinat

Re: *ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Thomas Koenig via Gcc-patches
Hi Paul, The patch looks fine to me but I have two questions: (i) Why is this not done in resolve.c? Of course it doesn't matter where the function resides :-) I put it into frontend-passes.c because it makes heavy use of gfc_code_walker, and out of habit. If you prefer, I can of course move

Re: *ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Paul Richard Thomas via Gcc-patches
Hi Thomas, The patch looks fine to me but I have two questions: (i) Why is this not done in resolve.c? (ii) Is Martin's reduced reproducer not the basis for a testcase? Regards Paul On Sat, 18 Jul 2020 at 11:58, Thomas Koenig via Fortran wrote: > Ping? > > > the attached patch fixes a 9/10/

Re: PING [PATCH] x86-64: Define ASM_OUTPUT_ALIGNED_DECL_LOCAL

2020-07-18 Thread H.J. Lu via Gcc-patches
On Sat, Jul 18, 2020 at 8:15 AM Jan Hubicka wrote: > > > On Sun, Jul 12, 2020 at 5:05 AM H.J. Lu wrote: > > > > > > On Fri, Jun 26, 2020 at 2:02 PM H.J. Lu wrote: > > > > > > > > Define ASM_OUTPUT_ALIGNED_DECL_LOCAL for large local common symbol. > > > > > > > > gcc/ChangeLog: > > > > > > > >

Re: PING [PATCH] x86-64: Define ASM_OUTPUT_ALIGNED_DECL_LOCAL

2020-07-18 Thread Jan Hubicka
> On Sun, Jul 12, 2020 at 5:05 AM H.J. Lu wrote: > > > > On Fri, Jun 26, 2020 at 2:02 PM H.J. Lu wrote: > > > > > > Define ASM_OUTPUT_ALIGNED_DECL_LOCAL for large local common symbol. > > > > > > gcc/ChangeLog: > > > > > > * config/i386/x86-64.h (ASM_OUTPUT_ALIGNED_DECL_LOCAL): New. > > >

Re: PING [PATCH] x86-64: Define ASM_OUTPUT_ALIGNED_DECL_LOCAL

2020-07-18 Thread H.J. Lu via Gcc-patches
On Sun, Jul 12, 2020 at 5:05 AM H.J. Lu wrote: > > On Fri, Jun 26, 2020 at 2:02 PM H.J. Lu wrote: > > > > Define ASM_OUTPUT_ALIGNED_DECL_LOCAL for large local common symbol. > > > > gcc/ChangeLog: > > > > * config/i386/x86-64.h (ASM_OUTPUT_ALIGNED_DECL_LOCAL): New. > > > > gcc/testsuite/C

[PATCH] x86: Add __cpuidex and include guard to

2020-07-18 Thread H.J. Lu via Gcc-patches
Add void __cpuidex (int __cpuid_info[4], int __leaf, int __subleaf); as well as include guard to . gcc/ PR target/95973 PR target/96238 * config/i386/cpuid.h: Add include guard. (__cpuidex): New. gcc/testsuite/ PR target/95973 PR target/96238

*ping* [patch, fortran] Fix PR 96018, wrong code caused by implicit_pure

2020-07-18 Thread Thomas Koenig via Gcc-patches
Ping? the attached patch fixes a 9/10/11 regression where we left over an implicit_pure attribute when a non-implicit_pure procedure was called. The fix is explained in the ChangeLog.

[PATCH] gimple-fold: Handle bitfields in fold_const_aggregate_ref_1 [PR93121]

2020-07-18 Thread Jakub Jelinek via Gcc-patches
Hi! When working on __builtin_bit_cast that needs to handle bitfields too, I've made the following change to handle at least some bitfields in fold_const_aggregate_ref_1 (those that have integral representative). It already handles some, but only those that start and end at byte boundaries. Boots

[PATCH] fold-const: Handle bitfields in native_encode_initializer [PR93121]

2020-07-18 Thread Jakub Jelinek via Gcc-patches
Hi! When working on __builtin_bit_cast that needs to handle bitfields too, I've made the following change to handle at least some bitfields in native_encode_initializer (those that have integral representative). Bootstrapped/regtested on {x86_64,i686,powerpc64{,le}}-linux, ok for trunk? 2020-07-