Here, the problem was that tsubst_friend_function was modifying the
CONSTRAINT_INFO for the friend template to have the constraints for one
instantiation, which fell down when we went to adjust it for another
instantiation. Fixed by deferring substitution of trailing requirements
until we try to c
[C++ PATCH] c++: is unnecessarily redundant, you can just write [PATCH].
On 1/24/20 6:20 PM, Marek Polacek wrote:> I neglected to add a proper
diagnostic for the reference dynamic_cast> case when the operand of a
dynamic_cast doesn't refer to a public base> of Derived, resulting in
suboptimal
Here the problem was that we were remembering the lookup in template scope,
and then trying to reuse that lookup in the instantiation without
substituting into it at all. The simplest solution is to not try to
remember a lookup that finds a class-scope declaration, as in that case
doing the normal
On Fri, 2020-01-24 at 19:53 -0500, David Malcolm wrote:
> This patch fixes various build failures seen with gcc 4.4
>
> gcc prior to 4.6 complains about:
>
> error: #pragma GCC diagnostic not allowed inside functions
>
> for various uses of PUSH_IGNORE_WFORMAT and POP_IGNORE_WFORMAT.
> This pa
This patch fixes various build failures seen with gcc 4.4
gcc prior to 4.6 complains about:
error: #pragma GCC diagnostic not allowed inside functions
for various uses of PUSH_IGNORE_WFORMAT and POP_IGNORE_WFORMAT.
This patch makes them a no-op with such compilers.
The patch also fixes variou
I neglected to add a proper diagnostic for the reference dynamic_cast
case when the operand of a dynamic_cast doesn't refer to a public base
of Derived, resulting in suboptimal error message
error: call to non-'constexpr' function 'void* __cxa_bad_cast()'
Tested x86_64-linux, ok for trunk?
20
On Fri, 24 Jan 2020, Prathamesh Kulkarni wrote:
> The middle-end representation issue of ERF_RETURNS_ARG still remains,
> which restricts the attribute till first four args. The patch simply
> emits sorry(), for arguments beyond first four..
I think this should be fixed (e.g. make the middle-end
When we thread through the successor of a joiner block we make a clone
of the joiner block and redirect its outgoing edges. Of course if
there's cases where we can't redirect an edge, then bad things will
happen.
The code already checked for EDGE_ABNORMAL to suppress threading in
that case. Bu
On Fri, 24 Jan 2020 22:20:43 +0100
Jakub Jelinek wrote:
> On Fri, Jan 24, 2020 at 07:57:22AM +, slyfox.inbox.ru via gcc-patches
> wrote:
> > From: Sergei Trofimovich
> >
> > From: Sergei Trofimovich
> >
> > asan's test allocates 2 pages via pvalloc(kPageSize + 100)
> > and makes sure der
any_template_parm_r was looking at the args of an alias template-id, but we
need to look at all args of a member alias/typedef, including implicit ones
from the enclosing class.
Tested x86_64-pc-linux-gnu, applying to trunk.
PR c++/93377 - ICE with member alias in constraint.
* pt
On Fri, Jan 24, 2020 at 07:57:22AM +, slyfox.inbox.ru via gcc-patches wrote:
> From: Sergei Trofimovich
>
> From: Sergei Trofimovich
>
> asan's test allocates 2 pages via pvalloc(kPageSize + 100)
> and makes sure dereference of 'kPageSize + 101' does not
> trigger asan checks.
>
> glibc's
From: "Dragan Mladjenovic"
diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html
index ef27c9b..7736990 100644
--- a/htdocs/gcc-10/changes.html
+++ b/htdocs/gcc-10/changes.html
@@ -623,7 +623,14 @@ a work-in-progress.
-
+MIPS
+
+ The mips*-*-linux* targets now mark object
On Fri, Jan 24, 2020 at 12:46 PM David Edelsohn wrote:
> On Fri, Jan 24, 2020 at 12:00 PM Jason Merrill wrote:
> >
> > On 1/24/20 8:45 AM, David Edelsohn wrote:
> > > There is no ChangeLog entry for the testsuite changes.
> >
> > I don't believe in ChangeLog entries for testcases, but I'll add o
On Fri, Jan 24, 2020 at 12:00 PM Jason Merrill wrote:
>
> On 1/24/20 8:45 AM, David Edelsohn wrote:
> > There is no ChangeLog entry for the testsuite changes.
>
> I don't believe in ChangeLog entries for testcases, but I'll add one for
> the target-supports.exp change, thanks.
Is this a general p
Another place we need to unshare cached expressions.
Tested x86_64-pc-linux-gnu, applying to trunk.
PR c++/92852 - ICE with generic lambda and reference var.
* constexpr.c (maybe_constant_value): Likewise.
---
gcc/cp/constexpr.c | 2 +-
gcc/testsuit
The _Eq and _Ord enumerations can be combined into one, reducing the
number of constructors needed for the comparison category types. The
redundant equal enumerator can be removed and equivalent used in its
place. The _Less and _Greater enumerators can be renamed because 'less'
and 'greater' are al
On 1/17/20 4:03 PM, Marek Polacek wrote:
Since e4511ca2e9ecdb51d41b64452398f8e2df575668 force_paren_expr can create
a VIEW_CONVERT_EXPR so that we have something to set REF_PARENTHESIZED_P
on, while not making the expression dependent. But tsubst_copy can't cope
with such a VIEW_CONVERT_EXPR, be
On 1/24/20 8:45 AM, David Edelsohn wrote:
There is no ChangeLog entry for the testsuite changes.
I don't believe in ChangeLog entries for testcases, but I'll add one for
the target-supports.exp change, thanks.
I'm also still trying to determine if Wconversion-pr40752.c requires
-fsigned-cha
writes:
> From: Andrew Pinski
>
> Like I mentioned in https://gcc.gnu.org/ml/gcc/2020-01/msg00157.html,
> The shift by a register should be just COSTS_N_INSNS (1) rather than
> COSTS_N_INSNS (2). This allows lshift_cheap_p to return true now
> and converting switches to be using shift and other
PR analyzer/93349 reports an ICE in IPA pass: simdclone for
some input files when -fanalyzer is supplied, with:
error: location references block not in block tree
The root cause is that the analyzer touches input_location in some
places (to make it easier to track down which source construct the
This fixes a long standing minor issue with the H8 port. Again, given
the very narrow scope here, I'm going forward even though we're in
stage4.
The H8 port will ICE under the right (wrong?) circumstances when we get
an unexpected operand in an asm, particularly asms that want to output
the name
Hi Julian,
On 1/10/20 2:51 AM, Julian Brown wrote:
Actually, it does not seem to work if one modifies the test
case a bit. The following code compiles – but I think it
should not: […]
At least the last line has x%A%i twice but it is accepted.
This bit is fixed by:
https://gcc.gnu.org/ml/gcc-
On 24/01/2020 15:12, Jonathan Wakely wrote:
On 24/01/20 15:09 +, Jonathan Wakely wrote:
On 24/01/20 13:55 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 12:19, Jonathan Wakely wrote:
On 24/01/20 11:48 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 11:04, Jonathan Wakely wrote:
Ping.
On Fri, Jan 17, 2020 at 04:03:09PM -0500, Marek Polacek wrote:
> Since e4511ca2e9ecdb51d41b64452398f8e2df575668 force_paren_expr can create
> a VIEW_CONVERT_EXPR so that we have something to set REF_PARENTHESIZED_P
> on, while not making the expression dependent. But tsubst_copy can't cope
I've pushed these to wwwdocs.
commit b1bd21c81af3bc3098fca4293af164a6c6a4544a
Author: Jonathan Wakely
Date: Fri Jan 24 15:30:06 2020 +
Make it clear C++2a support is experimental
diff --git a/htdocs/gcc-10/changes.html b/htdocs/gcc-10/changes.html
index ef27c9bb..dcce6b86 100644
---
Hello-
There was a comment on PR67224:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c33 suggesting to
document this feature in changes.html. Here would be my suggestion, in case
that's desirable. Thanks!
-Lewis
commit 6aad009fb93ced5fc79867a79a9021adec0d23d1
Author: Lewis Hyatt
Date: Tue
On 24/01/20 15:09 +, Jonathan Wakely wrote:
On 24/01/20 13:55 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 12:19, Jonathan Wakely wrote:
On 24/01/20 11:48 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 11:04, Jonathan Wakely wrote:
On 23/01/20 16:23 +, Richard Earnshaw (
As described in https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01660.html
I've had to change the personal branch space configuration slightly to
avoid problems with ambiguous refs. This patch updates wwwdocs to
reflect that change. It also adds documentation for the new
contrib/git-add-user-br
On 24/01/20 13:55 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 12:19, Jonathan Wakely wrote:
On 24/01/20 11:48 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 11:04, Jonathan Wakely wrote:
On 23/01/20 16:23 +, Richard Earnshaw (lists) wrote:
On 21/01/2020 18:58, Richard Earns
As reported in PR93409, the build of libgomp/plugin/plugin-gcn.c fails
with a bunch of error messages when building with
--with-multilib-list=m32,m64,mx32
The reason is that the GCN plugin assumes 64bit pointers. As with HSA,
the build is only enabled for x86-64 and "-m32" is excluded. — Howev
I've committed this patch to fix an ICE building the
gcc.dg/vect/fast-math-pr55281.c testcase.
The problem was that the combine pass was trying to use the "unle" and
"ungt" FP comparison operators. There's no hardware support for these,
so the operators should have been rejected, but the predi
On Fri, Jan 24, 2020 at 3:27 AM Maciej W. Rozycki wrote:
>
> Provide means, in the form of a `--with-toolexeclibdir=' configuration
> option, to override the default installation directory for target
> libraries, otherwise known as $toolexeclibdir. This is so that it is
> possible to get newly-bu
Whilst trying to convert the add vendor branch script to work with
personal branches I encountered a minor issue where git would report
ambiguous refs when checking out the new branch.
It turns out that this is because git considers / to be
ambiguous if both
refs/heads//
and
refs/remot
On 24/01/2020 12:19, Jonathan Wakely wrote:
On 24/01/20 11:48 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 11:04, Jonathan Wakely wrote:
On 23/01/20 16:23 +, Richard Earnshaw (lists) wrote:
On 21/01/2020 18:58, Richard Earnshaw (lists) wrote:
This patch documents some of the script
Jason,
There is no ChangeLog entry for the testsuite changes.
I'm also still trying to determine if Wconversion-pr40752.c requires
-fsigned-char option.
Thanks, David
Ping
Richard Sandiford writes:
> PR91323 was fixed for x86 and sparc in target code, but aarch64
> instead relies on the target-independent comparison splitters.
> Since LTGT is an unordered-signalling operation, we should split
> it into unordered-signalling operations for any input that could
>
I noticed, but ignored this code when addressing p80005, but having
fixed up defined(X) on the modules branch, I could see where it came
from, and it's obviously wrong as we've just pulled out a string
contant from the token.
pushed to trunk.
nathan
--
Nathan Sidwell
2020-01-24 Nathan Sidwell
On 24/01/20 11:48 +, Richard Earnshaw (lists) wrote:
On 24/01/2020 11:04, Jonathan Wakely wrote:
On 23/01/20 16:23 +, Richard Earnshaw (lists) wrote:
On 21/01/2020 18:58, Richard Earnshaw (lists) wrote:
This patch documents some of the scripts that I've published for
managing the perso
On 24/01/2020 11:04, Jonathan Wakely wrote:
On 23/01/20 16:23 +, Richard Earnshaw (lists) wrote:
On 21/01/2020 18:58, Richard Earnshaw (lists) wrote:
This patch documents some of the scripts that I've published for
managing the personal and vendor spaces on the server. It also
covers some
On Tue, 21 Jan 2020 at 04:35, Joseph Myers wrote:
>
> On Mon, 20 Jan 2020, Prathamesh Kulkarni wrote:
>
> > Hi,
> > This patch attempts to add returns_arg attribute for c-family
> > languages. For C++ methods, first arg is assumed to be this pointer,
>
> This is missing .texi documentation explain
Provide means, in the form of a `--with-toolexeclibdir=' configuration
option, to override the default installation directory for target
libraries, otherwise known as $toolexeclibdir. This is so that it is
possible to get newly-built libraries, particularly the shared ones,
installed in a comm
On 23/01/20 16:23 +, Richard Earnshaw (lists) wrote:
On 21/01/2020 18:58, Richard Earnshaw (lists) wrote:
This patch documents some of the scripts that I've published for
managing the personal and vendor spaces on the server. It also
covers some of the other features that those scripts ena
You didn't provide a ChangeLog entry. Please be sure to add one.
OK for master and gcc-9 branch, with the ChangeLog entry. Thanks.
On 23/01/20 21:59 -0800, Thomas Rodgers wrote:
TBB 2020 added deprecation warnings which produced output not expected by
check_effective_target_tbb-backend
---
lib
Jeff Law writes:
> Finding a way to drop the naked clobbers/uses would be a better way
> forward. I'm a bit surprised we need them as much as we apparently do.
> We're conflating issues a bit here though.
FWIW, I think they're a really useful feature. E.g. they help when
modelling the lifetimes
On Thu, Jan 23, 2020 at 05:13:20PM -0500, David Malcolm wrote:
[...]
>
> Fixes build on s390x-ibm-linux-gnu for stage 1, at least, with no
> testsuite regressions. Full bootstrap and regression test run
> in progress.
Thank you for taking care of this! With your new patch I can
successfully boot
Hi Julian,
the gfortran part is rather obvious and it and the test case look fine
to me → OK.
The oacc-mem.c also looks okay, but I assume Thomas needs to
rubber-stamp it.
Tobias
On 1/10/20 2:49 AM, Julian Brown wrote:
This patch fixes a bug with mapping Fortran components (i.e. with the
ma
Jakub Jelinek writes:
> Hi!
>
> The following patch makes sure we punt in the 3 spots if precision is above
> MAX_BITSIZE_MODE_ANY_INT.
>
> Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk?
>
> 2020-01-23 Jakub Jelinek
>
> PR target/93376
> * simplify-rtx.c (simpl
On Mon, 20 Jan 2020 at 12:09, Jakub Jelinek wrote:
>
> On Mon, Jan 20, 2020 at 12:04:12PM +0100, Richard Biener wrote:
> >
> > We were pruning type-local subroutine DIEs if their context is unused
> > despite us later needing those DIEs as abstract origins for inlines.
> > The patch makes code alr
Admittedly an early PING.
On 1/22/20 11:59 AM, Tobias Burnus wrote:
Hi Thomas, hi all,
first, I have now attached a different fix for PR 85781 (= original
bug). Can you have a look?
I have the feeling (but didn't check) that your patch does not handle
the following variant of the test case:
Hi Thomas,
On 23.01.20 15:32, Thomas Schwinge wrote:
> On 2020-01-20T15:01:01+0100, "Harwath, Frederik"
> wrote:
>> On 16.01.20 17:00, Thomas Schwinge wrote:
>>> On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
>>> wrote:
>> Ok to push the commit to master?
>
> Thanks, OK. Reviewed-by: Thom
50 matches
Mail list logo
