Re: [Patch,Fortran] PR92629 - ICE in convert_mpz_to_unsigned, at fortran/simplify.c:173

2019-11-24 Thread Janne Blomqvist
On Sun, Nov 24, 2019 at 10:47 PM Harald Anlauf wrote: > > In convert_mpz_to_unsigned, an assert was triggered when a positive > argument larger than HUGE() of the respective kind was passed while > -fno-range-check was specified. The assert should be consistently > skipped in this case. > > Regte

Re: [PATCH, rs6000] Refactor FP vector comparison operators

2019-11-24 Thread Kewen.Lin
Hi Segher, on 2019/11/23 上午12:08, Segher Boessenkool wrote: > Hi! >> 2019-11-21 Kewen Lin >> >> * config/rs6000/vector.md (vector_fp_comparison_simple): >> New code iterator. >> (vector_fp_comparison_complex): Likewise. >> (vector_ for VEC_F and >> vector_fp_comparison_s

Re: [patch, committed] PR92100 Formatted stream IO irreproducible read with binary data in file

2019-11-24 Thread Jerry DeLisle
On 11/24/19 2:20 PM, Jerry DeLisle wrote: Committed this as simple one liner.  I will probably backport this in a few days. Jerry Committed r278660 M    libgfortran/ChangeLog M    libgfortran/io/transfer.c 2019-11-24  Jerry DeLisle  PR fortran/92100 io/transfer.c (data_t

Re: [PATCH v3] PR92398: Fix testcase failure of pr72804.c

2019-11-24 Thread luoxhu
Hi, >> +++ b/gcc/testsuite/gcc.target/powerpc/pr72804-1.c > >> +/* store generates difference instructions as below: >> + P9: mtvsrdd;xxlnot;stxv. >> + P8/P7/P6 LE: not;not;std;std. >> + P8 BE: mtvsrd;mtvsrd;xxpermdi;xxlnor;stxvd2x. >> + P7/P6 BE: std;std;addi;lxvd2x;xxlnor;stxvd2x. */ >

Re: [PATCH] Fix attribute access issues

2019-11-24 Thread Martin Sebor
On 11/22/19 6:03 PM, Jakub Jelinek wrote: Hi! On Thu, Nov 21, 2019 at 06:09:34PM -0700, Martin Sebor wrote: PR middle-end/83859 * c-attribs.c (handle_access_attribute): New function. (c_common_attribute_table): Add new attribute. (get_argument_type): New function

[patch, committed] PR92100 Formatted stream IO irreproducible read with binary data in file

2019-11-24 Thread Jerry DeLisle
Committed this as simple one liner. I will probably backport this in a few days. Jerry Committed r278660 M libgfortran/ChangeLog M libgfortran/io/transfer.c 2019-11-24 Jerry DeLisle PR fortran/92100 io/transfer.c (data_transfer_init_worker): Use

Re: [PATCH 4/4] Fix autoinc cbranch

2019-11-24 Thread Segher Boessenkool
On Sun, Nov 24, 2019 at 08:55:37PM +0100, Bernd Schmidt wrote: > On 11/24/19 8:43 PM, Segher Boessenkool wrote: > > But. Allowing autoinc into jump insns means those jump insns may then > > eventually need an output reload; it may just have been because of that? > > That's almost certainly the re

[Patch,Fortran] PR92629 - ICE in convert_mpz_to_unsigned, at fortran/simplify.c:173

2019-11-24 Thread Harald Anlauf
In convert_mpz_to_unsigned, an assert was triggered when a positive argument larger than HUGE() of the respective kind was passed while -fno-range-check was specified. The assert should be consistently skipped in this case. Regtested on x86_64-pc-linux-gnu. OK for trunk / 9 / 8? Thanks, Harald

Re: [PATCH 4/4] Fix autoinc cbranch

2019-11-24 Thread Bernd Schmidt
On 11/24/19 8:43 PM, Segher Boessenkool wrote: > But. Allowing autoinc into jump insns means those jump insns may then > eventually need an output reload; it may just have been because of that? That's almost certainly the reasoning, but as I pointed out in my original mail - reload is careful aro

Re: [PATCH 4/4] Fix autoinc cbranch

2019-11-24 Thread Segher Boessenkool
On Sun, Nov 24, 2019 at 11:39:05AM -0600, Segher Boessenkool wrote: > On Sun, Nov 24, 2019 at 03:19:49PM +0100, Bernd Schmidt wrote: > > - /* This continue is deliberate. We do not want the uses of the > > -jump put into reg_next_use because it is not considered safe to > > -combine a

Re: [C++ PATCH] Fix concepts vs. PCH (PR c++/92458, take 2)

2019-11-24 Thread Jason Merrill
On 11/22/19 3:08 PM, Jakub Jelinek wrote: On Fri, Nov 22, 2019 at 02:43:25PM -0500, Jason Merrill wrote: @@ -5358,6 +5410,18 @@ struct tree_cache_traits : simple_cache_map_traits, tree> { }; We should probably use tree_hash instead of default_hash_traits here. OK with or without that chan

Re: [PATCH] m68k architecture: support ccmode + lra

2019-11-24 Thread Jeff Law
On 11/21/19 10:30 AM, ste...@franke.ms wrote: > Hi there, > > here is mc68k's patch to switch the m68k architecture over to ccmode and > lra. See https://github.com/mc68kghost/gcc 68k-ccmode branch. Bernd Schmidt posted a conversion of the m68k port to ccmode a couple weeks before yours. We've al

Re: [PATCH 2/4] The main m68k cc0 conversion

2019-11-24 Thread Jeff Law
On 11/23/19 12:54 PM, Oleg Endo wrote: > On Sat, 2019-11-23 at 10:36 -0700, Jeff Law wrote: >> >>> Any news on this? I would be in favor of merging these patches as I >>> have >>> tested them successfully on Debian by building the gcc-snapshot >>> package >>> with the patches applied. I used all fo

Re: [PATCH 1/4] MSP430: Disable TM clone registry by default

2019-11-24 Thread Jozef Lawrynowicz
On Sun, 24 Nov 2019 10:10:51 -0700 Jeff Law wrote: > On 11/24/19 7:20 AM, Jozef Lawrynowicz wrote: > > On Sun, 17 Nov 2019 12:11:23 -0700 > > Jeff Law wrote: > > > >> On 11/7/19 2:34 PM, Jozef Lawrynowicz wrote: > >>> Given that MSP430 is a resource constrained, embedded target disabling >

Re: [PATCH 4/4] Fix autoinc cbranch

2019-11-24 Thread Segher Boessenkool
Hi! On Sun, Nov 24, 2019 at 03:19:49PM +0100, Bernd Schmidt wrote: > - /* This continue is deliberate. We do not want the uses of the > - jump put into reg_next_use because it is not considered safe to > - combine a preincrement with a jump. */ > - if (JUMP_P (insn)) > -

Re: [C++ PATCH] c++/91353 - P1331R2: Allow trivial default init in constexpr contexts.

2019-11-24 Thread Jason Merrill
On 11/16/19 5:23 PM, Marek Polacek wrote: [ Working virtually on Baker Island. ] This patch implements C++20 P1331, allowing trivial default initialization in constexpr contexts. I used Jakub's patch from the PR which allowed uninitialized variables in constexpr contexts. But the hard part was

Re: [PATCH 1/4] MSP430: Disable TM clone registry by default

2019-11-24 Thread Jeff Law
On 11/24/19 7:20 AM, Jozef Lawrynowicz wrote: > On Sun, 17 Nov 2019 12:11:23 -0700 > Jeff Law wrote: > >> On 11/7/19 2:34 PM, Jozef Lawrynowicz wrote: >>> Given that MSP430 is a resource constrained, embedded target disabling >>> transactional memory by default is a good idea to save on code size

[patch, fortran] Fix PR 91783

2019-11-24 Thread Thomas Koenig
Hello world, this patch fixes a 10 regression in dependency checking. The approach is simple - if gfc_dep_resolver is handed references with _data, remove that. Regression-tested. OK for trunk? Regards Thomas Do not look at _data component in gfc_dep_resolver. 2019-11-24 Thomas Koen

Re: Convert inliner to new param infrastructure

2019-11-24 Thread Rainer Orth
Hi Jan, > This patch adds opt_for_fn for all cross module params used by inliner > so they can be modified at function granuality. With inlining almost always > there are three functions to consider (callee and caller of the inlined edge > and the outer function caller is inlined to). > > I alway

Re: [PATCH 4/4] MSP430: Deprecate -minrt option

2019-11-24 Thread Jozef Lawrynowicz
On Sun, 17 Nov 2019 14:00:58 -0700 Jeff Law wrote: > On 11/7/19 2:41 PM, Jozef Lawrynowicz wrote: > > Support for the MSP430 -minrt option has been removed from Newlib, since > > all the > > associated behaviour is now dynamic. Initialization code run before main is > > only > > included when n

Re: [PATCH 1/4] MSP430: Disable TM clone registry by default

2019-11-24 Thread Jozef Lawrynowicz
On Sun, 17 Nov 2019 12:11:23 -0700 Jeff Law wrote: > On 11/7/19 2:34 PM, Jozef Lawrynowicz wrote: > > Given that MSP430 is a resource constrained, embedded target disabling > > transactional memory by default is a good idea to save on code size in > > the runtime library. > > > > It can still be

Re: [PATCH 4/4] Fix autoinc cbranch

2019-11-24 Thread Bernd Schmidt
On 11/19/19 1:27 AM, Segher Boessenkool wrote: > The combine parts are okay for trunk, if you keep an eye out :-) Thanks, now committed. That leaves the auto-inc-dec part. Since we're being adventurous, I've also bootstrapped and tested the following in the meantime (on the gcc135 machine). This j

Re: [PATCH ix86] Fix rtx_costs for flag-setting adds

2019-11-24 Thread Bernd Schmidt
On 11/22/19 6:05 PM, Uros Bizjak wrote: > Indeed, this is a different case, an overflow test that results in one > CMP insn. I think, we should check if the second operand is either 0 > (then proceed as it is now), or if the second operand equals first > operand of PLUS insn, then we actually emit

Update: [patch, libfortran] Fix EOF handling in array I/O

2019-11-24 Thread Thomas Koenig
Here's an update to the previous patch. Upon reflection, I think it is better for performance to have two versions of the loop so the test is only performed when it is needed. So, OK for trunk? Regards Thomas Fix EOF handling for arrays. 2019-11-23 Thomas Koenig Harald Anl