[MIPS] Fix for the wrong argument sequence in MSA builtin for FMADD/MADDV family.

Hi all, This patch makes the behavior of __builtin_msa_ fmadd/fmsub/maddv match the expected one. While not a recent regression, it would be nice if this can be back-ported in order to minimize the fragmentation. Best regards, Dragan gcc/ChangeLog: 2019-05-20 Prachi Godbole Robe

Re: [PATCH] tbb-backend effective target should check ability to link TBB

On 5/21/19 10:51 PM, Jonathan Wakely wrote: On 21/05/19 22:47 +0200, François Dumont wrote: On 5/21/19 3:50 PM, Jonathan Wakely wrote: On 20/05/19 21:41 -0700, Thomas Rodgers wrote: With the addition of "-ltbb" to the v3_target_compile flags (so as to, you know, actually try to link tbb). Tes

Re: C++ PATCH for c++/90548 - ICE with generic lambda and empty pack

On 5/20/19 6:08 PM, Marek Polacek wrote: We ICE here because we are accessing call_args even though it's empty: (gdb) p (*call_args).is_empty() $5 = true It's empty because the pack processed by tsubst_pack_expansion expanded into an empty vector, so nothing got pushed onto call_args. So handl

Re: [RS6000] Don't pass -many to the assembler

On Tue, May 21, 2019 at 09:48:10AM -0500, Segher Boessenkool wrote: > > +static const char * > > +rs6000_machine_from_flags (void) > > +{ > > + if ((rs6000_isa_flags & (ISA_3_0_MASKS_SERVER & ~ISA_2_7_MASKS_SERVER)) > > != 0) > > +return "power9"; > > + if ((rs6000_isa_flags & (ISA_2_7_MASKS

Re: [PATCH 1/2] Add support for IVOPT

Hi Richard, On Fri, 17 May 2019 at 18:47, Richard Sandiford wrote: > > Kugan Vivekanandarajah writes: > > [...] > >> > +{ > >> > + struct mem_address parts = {NULL_TREE, integer_one_node, > >> > + NULL_TREE, NULL_TREE, NULL_TREE}; > >> > >> Might be better

[RFC][PR88838][SVE] Use 32-bit WHILELO in LP64 mode

Hi, Attached RFC patch attempts to use 32-bit WHILELO in LP64 mode to fix the PR. Bootstarp and regression testing ongoing. In earlier testing, I ran into an issue related to fwprop. I will tackle that based on the feedback for the patch. Thanks, Kugan From 4e9837ff9c0c080923f342e83574a6fdba2b3d9

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

on 2019/5/21 下午6:20, Richard Biener wrote: > On Tue, 21 May 2019, Kewen.Lin wrote: > >> on 2019/5/21 上午12:37, Segher Boessenkool wrote: >>> On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > I think we should have two hooks: one is called with the struct loop as > parameter; and t

Re: Go patch committed: Intrinsify runtime/internal/atomic functions

On Sun, May 19, 2019 at 5:22 AM Andreas Schwab wrote: > ../../../libgo/go/runtime/mbitmap.go: In function > ‘runtime.setMarked.runtime.markBits’: > ../../../libgo/go/runtime/mbitmap.go:291:9: internal compiler error: > Segmentation fault > 291 | atomic.Or8(m.bytep, m.mask) > | ^

Re: RFA: fix PR90553, IRA assigning a call-clobbered reg to call with post-increment

> From: Vladimir Makarov > Date: Tue, 21 May 2019 17:05:50 -0400 > Yes, the patch is ok to commit.  Thank you for working on the problem. > > It is hard to reproduce the same problem in LRA as LRA mostly follows > IRA decisions. > > I'll probably do the analogous patch for LRA on this week. T

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

Maciej Rozycki wrote: On Thu, 16 May 2019, Jacob Bachmeyer wrote: I suspect the origins may be different, however as valuable as your observation is functional problems have precedence over issues with code structuring, so we need to fix the problem at hand first. I'm sure DejaGNU mainta

Re: [RFC] SHIFT_COUNT_TRUNCATED and shift_truncation_mask

On 5/15/19 8:30 AM, Robin Dapp wrote: >> It would really help if you could provide testcases which show the >> suboptimal code and any analysis you've done. > > I tried introducing a define_subst pattern that substitutes something > one of two other subst patterns already changed. > > The first s

Re: [PATCH] Strip target_clones in copy attribute (PR lto/90500).

On 5/21/19 3:32 AM, Martin Liška wrote: > Hi. > > As suggested by Joseph, the patch is about not copying > target_clones attributes in handle_copy_attribute. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > > gcc/c-family

Re: [PATCH,RFC 0/3] Support for CTF in GCC

Thanks for your feedback. Comments inline. On 05/21/2019 03:28 AM, Richard Biener wrote: GCC RFC patch set : Patch 1 is a simple addition of a new function lang_GNU_GIMPLE to check for GIMPLE frontend. I don't think you should need this - the GIMPLE "frontend" is intended for unit testing only

Re: [PATCH] Implement LWG 3062, Unnecessary decay_t in is_execution_policy_v

The revised attached patch has been ested x86_64-linux, committed to trunk. >From 5f8aeeb98477d6555d65a45d1d2aed84b26863c9 Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Tue, 21 May 2019 12:02:35 -0700 Subject: [PATCH] LWG 3062 - Unnecessary decay_t in is_execution_policy_v * include/pst

PING^1: V2 [PATCH] i386: Insert ENDBR for NOTE_INSN_DELETED_LABEL only if needed

On Sat, Feb 16, 2019 at 7:02 AM H.J. Lu wrote: > > On Thu, Feb 14, 2019 at 08:13:32PM -0800, H.J. Lu wrote: > > NOTE_INSN_DELETED_LABEL is used to mark what used to be a 'code_label', > > but was not used for other purposes than taking its address and was > > transformed to mark that no code jumps

PING^1: [PATCH] i386: Properly encode xmm16-xmm31/ymm16-ymm31 for vector move

On Fri, Feb 22, 2019 at 8:25 AM H.J. Lu wrote: > > Hi Jan, Uros, > > This patch fixes the wrong code bug: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89229 > > Tested on AVX2 and AVX512 with and without --with-arch=native. > > OK for trunk? > > Thanks. > > H.J. > -- > i386 backend has > > INT

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

On Thu, 16 May 2019, Jacob Bachmeyer wrote: > > I suspect the origins may be different, however as valuable as your > > observation is functional problems have precedence over issues with code > > structuring, so we need to fix the problem at hand first. I'm sure > > DejaGNU maintainers will

Re: RFA: fix PR90553, IRA assigning a call-clobbered reg to call with post-increment

On 2019-05-20 9:58 p.m., Hans-Peter Nilsson wrote: I was looking into why I couldn't trivially move cris-elf to "use init_array". It appeared that it wasn't the hooks into that machinery that went wrong, but that a compiler bug is plaguing __libc_init_array. It's been there since at least 4.7

Re: [C++ Patch] Two literal operator template location fixes

On 5/21/19 7:03 AM, Paolo Carlini wrote: Hi, also in my back queue a few more location fixes (of course ;) Tested x86_64-linux. OK.

Re: [C++ PATCH] Add test for DR 1940 - static_assert in anonymous unions

On 5/21/19 11:11 AM, Marek Polacek wrote: clarified that static_assert in anonymous unions are permitted, but nowhere in the testsuite do we test that. Tested on x86_64-linux, ok for trunk? 2019-05-21 Marek Polacek DR 1940 - static_assert in anonymous unio

Re: [C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

On 5/21/19 12:34 PM, Paolo Carlini wrote: Hi, On 21/05/19 16:57, Jason Merrill wrote: On 5/16/19 7:12 PM, Paolo Carlini wrote: Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me tha

Re: [PATCH] tbb-backend effective target should check ability to link TBB

On 21/05/19 22:47 +0200, François Dumont wrote: On 5/21/19 3:50 PM, Jonathan Wakely wrote: On 20/05/19 21:41 -0700, Thomas Rodgers wrote: With the addition of "-ltbb" to the v3_target_compile flags (so as to, you know, actually try to link tbb). Tested x86_64-linux, committed to trunk. This

Re: [PATCH] tbb-backend effective target should check ability to link TBB

On 5/21/19 3:50 PM, Jonathan Wakely wrote: On 20/05/19 21:41 -0700, Thomas Rodgers wrote: With the addition of "-ltbb" to the v3_target_compile flags (so as to, you know, actually try to link tbb). Tested x86_64-linux, committed to trunk. This didn't work, I still get a FAIL for every pstl te

[PATCH, i386]: Fix PR90547, ICE in gen_lowpart_general

2019-05-21 Uroš Bizjak PR target/90547 * config/i386/i386.md (anddi_1 to andsi_1_zext splitter): Avoid calling gen_lowpart with CONST operand. testsuite/ChangeLog: 2019-05-21 Uroš Bizjak PR target/90547 * gcc.target/i386/pr90547.c: New test. Bootstrapped and regressio

Re: [PATCH PR57534]Support strength reduction for MEM_REF in slur

Hi Bin, On 5/16/19 11:00 AM, Bin.Cheng wrote: > On Thu, May 16, 2019 at 11:50 PM Bill Schmidt wrote: >> Thanks, Bin and Richard -- I am out of the office until Tuesday, so will >> review >> when I get back. Bin, please CC me on SLSR patches as otherwise I might miss >> them. Thanks! > Thanks f

Re: preserve more debug stmts in gimple jump threading

On May 17, 2019, Jeff Law wrote: > OK. Presumably creating a reliable testcase was painful? Heh, that it might even possible didn't even cross my mind. I was happy enough to be able to exercise and inspect the before&after IR for most of the new code paths in the patch in a GCC bootstrap, by p

Re: dg-require-ifunc syntax

Rainer Orth writes: > Hi Iain, > >> Hi Dominique, >> >>> On 19 May 2019, at 15:10, Dominique d'Humières wrote: >>> >>> AFAICT the syntax for dg-require-ifunc seems to be >>> >>> /* { dg-require-ifunc "" } */ >>> >>> with two sets of exceptions: >>> >>> (1) gcc.target/i386/pr90500-*.c >>> >>

[PATCH][GCC][AArch64] Make processing less fragile in config.gcc

Hi All, Due to config.gcc all the options need to be on one line because of the grep lines which would select only the first line of the option. This causes it not to select the right bits on options that are spread over multiple lines when the --with-arch configure option is used. The issue hap

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

Hi Joseph, On Mon, May 20, 2019 at 10:42:45PM +, Joseph Myers wrote: > (SVN will remain > readonly, just as the old CVS repository remains available readonly). > That the git-svn mirror is useful for many purposes for which people want > to use git also provides a clear argument against nee

[PATCH, Darwin, testsuite] Fix PR67958

This a series of tests that require specific scan-asms in some cases because of the different codegen for Dawin. Added some explanations too. tested on x86_64-darwin and x86_64-linux-gnu applied to mainline, Iain gcc/testsuite/ 2019-05-21 Iain Sandoe PR testsuite/67958 * gcc

[PATCH, Darwin, testsuite] Fix PR 63891.

This is a testcase failing because one part of the codegen is (correctly) generating the scan-asm-not signature. Fixed by altering the build options. tested on x86_64-darwin16, applied to mainline, Iain gcc/testsuite/ 2019-05-21 Iain Sandoe PR target/63891 * gcc.dg/darwin-wea

Re: [PATCH GCC]Correct cand_chain and stmt_cand_map for copy/cast

On 5/15/19 6:09 AM, Richard Biener wrote: > On Wed, May 15, 2019 at 7:54 AM bin.cheng wrote: >> Hi, >> I noticed that cand_chain (first_interp/next_interp) is not maintained >> correctly >> in slsr_process_copy/slsr_process_cast (now slsr_process_copycast). This one >> fixes the issue, as well a

Re: [C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

Hi, On 21/05/19 16:57, Jason Merrill wrote: On 5/16/19 7:12 PM, Paolo Carlini wrote: Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me that by way of access_path the existing appro

[PATCH 6/6] rs6000: wz -> d+p7

2019-05-21 Segher Boessenkool * config/rs6000/constraints.md (define_register_constraint "wz"): Delete. * config/rs6000/rs6000.h (enum r6000_reg_class_enum): Delete RS6000_CONSTRAINT_wz. * config/rs6000/rs6000.c (rs6000_debug_reg_global): Adjust.

[PATCH 5/6] rs6000: wl -> d+p6

2019-05-21 Segher Boessenkool * config/rs6000/constraints.md (define_register_constraint "wl"): Delete. * config/rs6000/rs6000.h (enum r6000_reg_class_enum): Delete RS6000_CONSTRAINT_wl. * config/rs6000/rs6000.c (rs6000_debug_reg_global): Adjust.

[PATCH 3/6] rs6000: wk -> ws+p8v

2019-05-21 Segher Boessenkool * config/rs6000/constraints.md (define_register_constraint "wk"): Delete. * config/rs6000/rs6000.h (enum r6000_reg_class_enum): Delete RS6000_CONSTRAINT_wk. * config/rs6000/rs6000.c (rs6000_debug_reg_global): Adjust.

[PATCH 4/6] rs6000: wm -> wa+p8v

2019-05-21 Segher Boessenkool * config/rs6000/constraints.md (define_register_constraint "wm"): Delete. * config/rs6000/rs6000.h (enum r6000_reg_class_enum): Delete RS6000_CONSTRAINT_wm. * config/rs6000/rs6000.c (rs6000_debug_reg_global): Adjust.

[PATCH 2/6] rs6000: wj -> wi+p8v

Also deletes VS_64dm, it's unused. 2019-05-21 Segher Boessenkool * config/rs6000/constraints.md (define_register_constraint "wj"): Delete. * config/rs6000/rs6000.h (enum r6000_reg_class_enum): Delete RS6000_CONSTRAINT_wj. * config/rs6000/rs6000.c (rs600

[PATCH 0/6] rs6000: Some more easy "enabled" cases

This converts some more constraints to a simpler constraint plus enabled formulation. Tested on p7 powerpc64-linux {-m32,-m64}; still testing on p8 and p9 LE, will commit if that succeeds. Segher Segher Boessenkool (6): wh -> d+p8v wj -> wi+p8v wk -> ws+p8v wm -> wa+p8v wl -> d+p6

[PATCH 1/6] rs6000: wh -> d+p8v

This replaces the "wh" constraint by "d", with isa "p8v". 2019-05-21 Segher Boessenkool * config/rs6000/constraints.md (define_register_constraint "wh"): Delete. * config/rs6000/rs6000.h (enum r6000_reg_class_enum): Delete RS6000_CONSTRAINT_wh. * config

[PATCH, i386]: Introduce signbit2 expander

Based on the recent work that enabled vectorization of __builtin_signbit on aarch64. 2019-05-21 Uroš Bizjak * config/i386/sse.md (VF1_AVX2): New mode iterator. (signbit2): New expander testsuite/ChangeLog: 2019-05-21 Uroš Bizjak * gcc.target/i386/vect-signbitf.c: New test. B

Re: Follow-up-fix 2 to "[PATCH] Move PR84877 fix elsewhere (PR bootstrap/88450)"

On 5/12/19 10:01 PM, Hans-Peter Nilsson wrote: >> Date: Tue, 30 Apr 2019 11:37:17 -0600 >> From: Jeff Law > >> On 2/10/19 6:09 PM, Hans-Peter Nilsson wrote: >>> Here's the follow-up, getting rid of the observed >>> alignment-padding in execute/930126-1.c: the x parameter in f >>> spuriously being

[PATCH] i386: Generate standard floating point scalar operation patterns

On Wed, May 15, 2019 at 2:29 PM Richard Sandiford wrote: > > "H.J. Lu" writes: > > On Thu, Feb 7, 2019 at 9:49 AM H.J. Lu wrote: > >> > >> Standard scalar operation patterns which preserve the rest of the vector > >> look like > >> > >> (vec_merge:V2DF > >>(vec_duplicate:V2DF > >>

Re: *Ping* Re: [PATCH] PR c/43673 - Incorrect warning in dfp printf.

On 5/20/19 6:56 PM, luoxhu wrote: > Ping for GCC-10. I thought this was a NAK in its current form. See Ryan's c#1 in the BZ. jeff

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

On Tue, May 21, 2019 at 05:28:51PM +0200, Christophe Lyon wrote: > On Wed, 15 May 2019 at 18:06, Rich Felker wrote: > > > > On Wed, May 15, 2019 at 03:59:39PM +, Szabolcs Nagy wrote: > > > On 15/05/2019 16:37, Rich Felker wrote: > > > > On Wed, May 15, 2019 at 05:12:11PM +0200, Christophe Lyon

Re: [PATCH] PR bootstrap/87338: Fix ia64 bootstrap comparison regression in r257511

On 5/21/19 7:08 AM, James Clarke wrote: > On 26 Apr 2019, at 15:24, Jeff Law wrote: >> On 4/26/19 2:01 AM, Jakub Jelinek wrote: >>> On Fri, Apr 26, 2019 at 08:58:18AM +0200, Richard Biener wrote: On Thu, Apr 25, 2019 at 7:52 PM James Clarke wrote: > > By using ASM_OUTPUT_LABEL, r2575

Re: Fix MEM_REF creation for shared stack slots

On May 21, 2019 5:17:43 PM GMT+02:00, Jeff Law wrote: >On 5/21/19 8:37 AM, Jan Hubicka wrote: >>> And that should be done at RTL creation time instead of >>> repeatedly over and over. Like with the following. >>> >>> Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. >> >> Thanks, >> f

Re: [C++ PATCH] Using decls

On 5/21/19 10:43 AM, Marek Polacek wrote: Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: -/* Process a local-scope or namespace-scope using declaration. SCOPE +/* Process a local-scope or namespace-scope using declaration. + FIX

Re: [ARM/FDPIC v5 03/21] [ARM] FDPIC: Force FDPIC related options unless -mno-fdpic is provided

On Wed, 15 May 2019 at 18:06, Rich Felker wrote: > > On Wed, May 15, 2019 at 03:59:39PM +, Szabolcs Nagy wrote: > > On 15/05/2019 16:37, Rich Felker wrote: > > > On Wed, May 15, 2019 at 05:12:11PM +0200, Christophe Lyon wrote: > > >> On Wed, 15 May 2019 at 16:37, Rich Felker wrote: > > >>> On

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On 5/21/19 4:20 AM, Richard Biener wrote: > On Tue, 21 May 2019, Kewen.Lin wrote: > >> on 2019/5/21 上午12:37, Segher Boessenkool wrote: >>> On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > I think we should have two hooks: one is called with the struct loop as > parameter; and th

Re: CPUID Patch for IDT Winchip

On Tue, May 21, 2019 at 9:46 AM Uros Bizjak wrote: > > On Tue, May 21, 2019 at 12:20 AM tedheadster wrote: > > > > On Mon, May 20, 2019 at 2:57 PM Uros Bizjak wrote: > > > > > > On Mon, May 20, 2019 at 6:12 PM tedheadster wrote: > > > > Did you instead mean "zeroing %EBX and %ECX regs should be

Re: Fix MEM_REF creation for shared stack slots

On 5/21/19 8:37 AM, Jan Hubicka wrote: >> And that should be done at RTL creation time instead of >> repeatedly over and over. Like with the following. >> >> Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. > > Thanks, > for TBAA stats I now get > > Alias oracle query stats: > refs

[C++ PATCH] Add test for DR 1940 - static_assert in anonymous unions

clarified that static_assert in anonymous unions are permitted, but nowhere in the testsuite do we test that. Tested on x86_64-linux, ok for trunk? 2019-05-21 Marek Polacek DR 1940 - static_assert in anonymous unions. * g++.dg/DRs/dr1940.C: New test.

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On 21/05/2019 15:44, Jeff Law wrote: > On 5/21/19 8:24 AM, Richard Earnshaw (lists) wrote: >> On 20/05/2019 23:42, Joseph Myers wrote: >> >>> I'm not particularly concerned with distinguishing between different names >>> and email addresses for an author depending on when or in what capacity >>>

[PATCH] x86: Don't allocate stack frame nor align stack if not needed

get_frame_size () returns used stack slots during compilation, which may be optimized out later. This patch does the followings: 1. Add no_stack_frame to machine_function to indicate that the function doesn't need a stack frame. 2. Change ix86_find_max_used_stack_alignment to set no_stack_frame.

[PATCHv2] debug: make -feliminate-unused-debug-symbols the default [PR debug/86964]

From: Thomas De Schampheleire In addition to making -feliminate-unused-debug-symbols work for the DWARF format (see [1]), make this option the default. This behavior was the case before, e.g. under gcc 4.9.x. [1] https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=269925 This change requires

Re: [C++ Patch] PR 67184 ("Missed optimization with C++11 final specifier")

On 5/16/19 7:12 PM, Paolo Carlini wrote: Hi, when Roberto Agostino and I implemented the front-end devirtualization of final overriders we missed this case, where it comes from the base. It seems to me that by way of access_path the existing approach can be neatly extended. Tested x86_64-linu

Re: [RS6000] Don't pass -many to the assembler

Hi! On Tue, May 21, 2019 at 10:22:26PM +0930, Alan Modra wrote: > This is a repost of > https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00911.html with a small > tweak to rs6000_machine_from_flags (&~ instead of ^). > > Bootstrapped and regression tested powerpc64le-linux power8 and > power9. OK t

Re: [C++ PATCH] Using decls

On 5/21/19 10:43 AM, Marek Polacek wrote: Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: -/* Process a local-scope or namespace-scope using declaration. SCOPE +/* Process a local-scope or namespace-scope using declaration. + FIX

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On 5/21/19 8:24 AM, Richard Earnshaw (lists) wrote: > On 20/05/2019 23:42, Joseph Myers wrote: > >> I'm not particularly concerned with distinguishing between different names >> and email addresses for an author depending on when or in what capacity >> they contributed a change, or with the case

Re: [C++ PATCH] Using decls

Thanks for the patch and sorry for nitpicking: On Tue, May 21, 2019 at 10:32:31AM -0400, Nathan Sidwell wrote: > -/* Process a local-scope or namespace-scope using declaration. SCOPE > +/* Process a local-scope or namespace-scope using declaration. > + FIXME This ain't look right. You meant t

Re: Fix MEM_REF creation for shared stack slots

> And that should be done at RTL creation time instead of > repeatedly over and over. Like with the following. > > Bootstrap / regtest on x86_64-unknown-linux-gnu in progress. Thanks, for TBAA stats I now get Alias oracle query stats: refs_may_alias_p: 3022975 disambiguations, 3321454 queries

[C++ PATCH] Using decls

This patch reimplements using-decl handling. It removes the double lookup of the target name, and commonizes the local- and namespace- scope handling into a single function. Applying to trunk. nathan -- Nathan Sidwell 2019-05-21 Nathan Sidwell gcc/cp/ * name-lookup.h (struct cp_binding_

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

On Tue, May 21, 2019 at 12:12 PM Richard Biener wrote: > > On Mon, May 20, 2019 at 4:51 PM Feng Xue OS > wrote: > > > > > I don't see how it is safe in a late pass when it is not safe in an > > > > > earlier one. Optimization is imperfect - we could fail to remove > > > an "obvious" never taken

Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git

On 20/05/2019 23:42, Joseph Myers wrote: > I'm not particularly concerned with distinguishing between different names > and email addresses for an author depending on when or in what capacity > they contributed a change, or with the cases where a patch was committed > for someone else and SVN s

[PATCH] Handle ABS_EXPR in rewrite_to_defined_overflow

The following makes us properly rewrite ABS_EXPR to avoid undefined overflow when hoisting it from a not always executed region. Bootstrap & regtest on x86_64-unknown-linux-gnu in progress. Richard. 2019-05-21 Richard Biener * gimple-fold.c (arith_code_with_undefined_signed_overflo

Re: [PATCH] [aarch64] Introduce flags for SVE2.

Hi Matthew, On 5/15/19 4:11 PM, Matthew Malcomson wrote: > Matthew Malcomson writes: >> @@ -326,16 +326,22 @@ int opt_ext_cmp (const void* a, const void* b) Cheers Richard -- modified patch attached and inlined. MM This looks ok to me FWIW (you'll still need maintainer approval). The size o

Re: [PATCH] tbb-backend effective target should check ability to link TBB

On 20/05/19 21:41 -0700, Thomas Rodgers wrote: With the addition of "-ltbb" to the v3_target_compile flags (so as to, you know, actually try to link tbb). Tested x86_64-linux, committed to trunk. This didn't work, I still get a FAIL for every pstl test when tbb.x86_64 and tbb-devel.x86_64 are

[PATCH] A jump threading opportunity for condition branch

Hi, This patch implements a new opportunity of jump threading for PR77820. In this optimization, conditional jumps are merged with unconditional jump. And then moving CMP result to GPR is eliminated. It looks like below: p0 = a CMP b goto ; p1 = c CMP d goto ; # phi = PHI

Re: Fix MEM_REF creation for shared stack slots

On Tue, 21 May 2019, Richard Biener wrote: > On Tue, 21 May 2019, Jan Hubicka wrote: > > > > > So about 8times of aliasing_component_refs hitrate. > > > > > > OK, one issue with the patch is that it restores TBAA for the > > > access which we may _not_ do IIRC. > > > > I can see that with stack

Re: [RS6000] PR90545, gcc.target/powerpc/fold-vec-splats-floatdouble.c fails

Hi Alan, On Tue, May 21, 2019 at 09:01:29PM +0930, Alan Modra wrote: > Bootstrapped powerpc64le-linux power8 and power9, OK to apply? > > I figure a tweak to register_move_cost is better than sprinkling ?s > in instruction alternatives. Yup. > PR 90545 PR target/90545 > * config/r

Re: [PATCH] PR bootstrap/87338: Fix ia64 bootstrap comparison regression in r257511

On 26 Apr 2019, at 15:24, Jeff Law wrote: > On 4/26/19 2:01 AM, Jakub Jelinek wrote: >> On Fri, Apr 26, 2019 at 08:58:18AM +0200, Richard Biener wrote: >>> On Thu, Apr 25, 2019 at 7:52 PM James Clarke wrote: By using ASM_OUTPUT_LABEL, r257511 forced the assembler to start a new bu

[RS6000] Don't pass -many to the assembler

This is a repost of https://gcc.gnu.org/ml/gcc-patches/2018-12/msg00911.html with a small tweak to rs6000_machine_from_flags (&~ instead of ^). Bootstrapped and regression tested powerpc64le-linux power8 and power9. OK to apply now that we're in stage1? * config/rs6000/rs6000.h (ASM_OPT_

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Tue, May 21, 2019 at 12:20:50PM +0200, Richard Biener wrote: > On Tue, 21 May 2019, Kewen.Lin wrote: > > > on 2019/5/21 上午12:37, Segher Boessenkool wrote: > > > On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > > >>> I think we should have two hooks: one is called with the struct loop

[PATCH] Fix names of _Lock_policy constants in libstdc++ manual

* doc/xml/manual/shared_ptr.xml: Fix names of lock policy constants. I'll commit this to trunk shortly (and maybe backport it in my next round of doc backports). commit b82fec365a7d9404b94bf5df8b9c1266b3bd4c38 Author: Jonathan Wakely Date: Tue May 21 12:29:55 2019 +0100 Fix names

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: > > On 5/21/19 11:38 AM, Richard Biener wrote: > > On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: > >> > >> On 5/13/19 1:41 AM, Martin Liška wrote: > >>> On 11/8/18 9:56 AM, Martin Liška wrote: > On 11/7/18 11:23 PM, Jeff Law wrote: > >>>

[RS6000] PR90545, gcc.target/powerpc/fold-vec-splats-floatdouble.c fails

Bootstrapped powerpc64le-linux power8 and power9, OK to apply? I figure a tweak to register_move_cost is better than sprinkling ?s in instruction alternatives. PR 90545 * config/rs6000/rs6000.c (rs6000_register_move_cost): Increase power9 direct move cost. * testsu

Re: Fix MEM_REF creation for shared stack slots

On Tue, 21 May 2019, Jan Hubicka wrote: > > > So about 8times of aliasing_component_refs hitrate. > > > > OK, one issue with the patch is that it restores TBAA for the > > access which we may _not_ do IIRC. > > I can see that with stack sharing we have one memory location that for a > while is o

Re: [PATCH][RFC] Fix PR90510, VEC_PERM -> BIT_INSERT folding

On Mon, 20 May 2019, Richard Biener wrote: > On Sun, 19 May 2019, Richard Sandiford wrote: > > > Richard Biener writes: > > > This adds, incrementally ontop of moving VEC_PERM_EXPR folding > > > to match.pd (but not incremental patch - sorry...), folding > > > of single-element insert permutatio

Re: Fix MEM_REF creation for shared stack slots

> > So about 8times of aliasing_component_refs hitrate. > > OK, one issue with the patch is that it restores TBAA for the > access which we may _not_ do IIRC. I can see that with stack sharing we have one memory location that for a while is of type A and later is rewritten by type B, but we alrea

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Tue, May 21, 2019 at 02:03:04PM +0800, Kewen.Lin wrote: > on 2019/5/21 上午12:37, Segher Boessenkool wrote: > > On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > >>> I think we should have two hooks: one is called with the struct loop as > >>> parameter; and the other is called for every

Re: [PATCH] Strip target_clones in copy attribute (PR lto/90500).

On 5/21/19 11:41 AM, Dominique d'Humières wrote: > Hi Martin, > > /* { dg-require-ifunc } */ > > should be > > /* { dg-require-ifunc ""} */ > > and the same for pr90500-2.c (see > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01152.html) > > TIA > > Dominique > I'm addressing that in pat

[C++ Patch] Two literal operator template location fixes

Hi, also in my back queue a few more location fixes (of course ;) Tested x86_64-linux. Thanks, Paolo. /cp 2019-05-21 Paolo Carlini * parser.c (cp_parser_template_declaration_after_parameters): Use DECL_SOURCE_LOCATION in literal operator template errors.

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

On 5/21/19 11:38 AM, Richard Biener wrote: > On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: >> >> On 5/13/19 1:41 AM, Martin Liška wrote: >>> On 11/8/18 9:56 AM, Martin Liška wrote: On 11/7/18 11:23 PM, Jeff Law wrote: > On 10/30/18 6:28 AM, Martin Liška wrote: >> On 10/30/18 11:03

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Tue, May 21, 2019 at 01:50:31PM +0800, Kewen.Lin wrote: > on 2019/5/20 下午10:43, Jeff Law wrote: > > On 5/20/19 4:24 AM, Segher Boessenkool wrote: > >> Let me try to answer a bit here... > >> > >> On Mon, May 20, 2019 at 11:28:26AM +0200, Richard Biener wrote: > >>> On Thu, 16 May 2019, li...@lin

Re: [PATCH,RFC 0/3] Support for CTF in GCC

On Mon, May 20, 2019 at 7:56 PM Indu Bhagat wrote: > > Background : > CTF is the Compact Ansi-C Type Format. It is a format designed to express some > characteristics (specifically Type information) of the data types in a C > program. CTF format is compact and fast; It was originally designed for

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Tue, 21 May 2019, Kewen.Lin wrote: > on 2019/5/21 上午12:37, Segher Boessenkool wrote: > > On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > >>> I think we should have two hooks: one is called with the struct loop as > >>> parameter; and the other is called for every statement in the lo

Re: [PATCH] fix diagnostic quoting/spelling in rs6000

On Mon, May 20, 2019 at 11:31:17PM +, Joseph Myers wrote: > Where you refer to 'homogeneous % aggregates', are such aggregates > in the rs6000 case (or in the case where the ABI changed) really > restricted to the type float, or do they apply more generally to some > other floating-point typ

Re: [PATCH] Remove empty loop with assumed finiteness (PR tree-optimization/89713)

On Mon, May 20, 2019 at 4:51 PM Feng Xue OS wrote: > > > I don't see how it is safe in a late pass when it is not safe in an > > > earlier one. Optimization is imperfect - we could fail to remove > > an "obvious" never taken exit and still have a loop that appears to be > > finite according to ou

Re: [PATCH v2 2/3] Add predict_doloop_p target hook

On Mon, May 20, 2019 at 01:31:10PM -0600, Jeff Law wrote: > On 5/15/19 10:44 AM, Segher Boessenkool wrote: > > But we can be allocated a floating point register, or memory, instead. > > That is heavily discouraged (by making it more expensive), but it can > > still happen. This is a jump_insn so i

Re: [PATCH v3 2/3] Add predict_doloop_p target hook

On Mon, 20 May 2019, Segher Boessenkool wrote: > On Mon, May 20, 2019 at 08:43:59AM -0600, Jeff Law wrote: > > > I think we should have two hooks: one is called with the struct loop as > > > parameter; and the other is called for every statement in the loop, if > > > the hook isn't null anyway. O

Re: [PATCH] Strip target_clones in copy attribute (PR lto/90500).

> On 21 May 2019, at 10:48, Martin Liška wrote: > > On 5/21/19 11:41 AM, Dominique d'Humières wrote: >> Hi Martin, >> >> /* { dg-require-ifunc } */ >> >> should be >> >> /* { dg-require-ifunc ""} */ >> >> and the same for pr90500-2.c (see >> https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01

Re: [PATCH] Strip target_clones in copy attribute (PR lto/90500).

> Le 21 mai 2019 à 11:48, Martin Liška a écrit : > > On 5/21/19 11:41 AM, Dominique d'Humières wrote: >> Hi Martin, >> >> /* { dg-require-ifunc } */ >> >> should be >> >> /* { dg-require-ifunc ""} */ >> >> and the same for pr90500-2.c (see >> https://gcc.gnu.org/ml/gcc-patches/2019-05/msg

Re: Simplify more EXACT_DIV_EXPR comparisons

On Tue, May 21, 2019 at 4:13 AM Martin Sebor wrote: > > On 5/20/19 3:16 AM, Richard Biener wrote: > > On Mon, May 20, 2019 at 10:16 AM Marc Glisse wrote: > >> > >> On Mon, 20 May 2019, Richard Biener wrote: > >> > >>> On Sun, May 19, 2019 at 6:16 PM Marc Glisse wrote: > > Hello, >

Re: [PATCH] Strip target_clones in copy attribute (PR lto/90500).

On 5/21/19 11:41 AM, Dominique d'Humières wrote: > Hi Martin, > > /* { dg-require-ifunc } */ > > should be > > /* { dg-require-ifunc ""} */ > > and the same for pr90500-2.c (see > https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01152.html) > > TIA > > Dominique > Hi. Thanks, should I fix

Re: [PATCH] Strip target_clones in copy attribute (PR lto/90500).

Hi Martin, /* { dg-require-ifunc } */ should be /* { dg-require-ifunc ""} */ and the same for pr90500-2.c (see https://gcc.gnu.org/ml/gcc-patches/2019-05/msg01152.html) TIA Dominique

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: > > On 5/13/19 1:41 AM, Martin Liška wrote: > > On 11/8/18 9:56 AM, Martin Liška wrote: > >> On 11/7/18 11:23 PM, Jeff Law wrote: > >>> On 10/30/18 6:28 AM, Martin Liška wrote: > On 10/30/18 11:03 AM, Jakub Jelinek wrote: > > On Mon, Oct 29

[PATCH] Strip target_clones in copy attribute (PR lto/90500).

Hi. As suggested by Joseph, the patch is about not copying target_clones attributes in handle_copy_attribute. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/c-family/ChangeLog: 2019-05-21 Martin Liska PR lto/90500

Re: Fix MEM_REF creation for shared stack slots

On Tue, 21 May 2019, Jan Hubicka wrote: > Hi, > while creating shared stack slots we create a fake void * pointer and > merge the corresponidng points-to sets. Later ao_ref_from_mem constructs > mem_ref to feed alias oracle from. Since pointer is void we then > dereference it and keep with void_t

Re: [PATCH] Convert contrib/mklog script to Python 3

On Tue, May 21, 2019 at 10:47 AM Janne Blomqvist wrote: > > On Tue, May 21, 2019 at 10:32 AM Martin Liška wrote: > > > > Hi. > > > > There's a regression I see after the transition to python3: > > > > $ cat /tmp/patch > > diff --git a/gcc/testsuite/gcc.dg/pr90263.c b/gcc/testsuite/gcc.dg/pr90263.

  1   2   >