Re: [C/C++ PATCH] Fix promoted switch condition out of range diagnostics (PR c/89888, take 2)

2019-04-18 Thread Jason Merrill
On Tue, Apr 9, 2019 at 2:39 PM Jakub Jelinek wrote: > On Tue, Apr 09, 2019 at 09:06:33AM +0200, Jakub Jelinek wrote: > > Alternatively, I believe we could remove from the patch the in-place > > replacement of CASE_LABEL_EXPRs with LABEL_EXPRs if we want to remove, > > just splay_tree_remove those,

Re: [C/C++ PATCH] Further typedef duplicate decl fixes (PR c++/90108)

2019-04-18 Thread Jason Merrill
OK. On Wed, Apr 17, 2019 at 11:25 PM Jakub Jelinek wrote: > > Hi! > > As reported, the newly added testcase ICEs with --param ggc-min-heapsize=0. > The problem is that while the remove type is not referenced by anything > else, it is a distinct type created to hold the attributes, there is anothe

Re: [PATCH][C++] Improve compile-time by ordering expensive checks last

2019-04-18 Thread Jason Merrill
OK. On Wed, Apr 17, 2019 at 6:44 AM Richard Biener wrote: > > On Tue, 16 Apr 2019, Richard Biener wrote: > > > > > Two cases from a -fsynax-only tramp3d callgrind profile. > > Amended by two others. > > Bootstrapped and tested on x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > 2019-0

Re: [PATCH][stage1] Enhance target and target_clone error messages.

2019-04-18 Thread Martin Sebor
On 4/18/19 5:09 AM, Martin Liška wrote: Hi. The patch distinguishes among target and target_clone attribute when reporting for an error. I've also reworded the affected error messages a bit. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed after stag

[PATCH] Delegate PSTL configuration to pstl/pstl_config.h

2019-04-18 Thread Thomas Rodgers
* include/bits/c++config: Remove explicit PSTL configuration macros and use definitions from . >From 198662c6e2ee6b1a6b363c2a515c05ef1ca949bd Mon Sep 17 00:00:00 2001 From: Thomas Rodgers Date: Thu, 18 Apr 2019 16:55:40 -0700 Subject: [PATCH] Delegate PSTL configuration to pstl

Re: [PATCH][IRA] Fix PR87871: [9 Regression] testcases fail after r265398 on arm

2019-04-18 Thread Peter Bergner
On 4/18/19 4:39 PM, Vladimir Makarov wrote: > On 4/18/19 11:24 AM, Peter Bergner wrote: >> I have confirmed we now assign pseudo p116 to r0 in the ARM test case >> as well as a similar assignment issue on POWER. >> >> This passed bootstrap and regtesting with no regressions on >> powerpc64le-linux

Re: [PATCH][IRA] Fix PR87871: [9 Regression] testcases fail after r265398 on arm

2019-04-18 Thread Vladimir Makarov
On 4/18/19 11:24 AM, Peter Bergner wrote: PR87871 exposes a couple of problems. One problem fixed here is that IRA incorrectly adds a conflict in some cases where we have a simple register copy between a pseudo reg and a hard reg. This stopped us from assigning the pseudo reg to that hard reg

Re: [PATCH] Improve implementation of parallel equal()

2019-04-18 Thread Jonathan Wakely
On 18/04/19 21:43 +0100, Jonathan Wakely wrote: --- a/libstdc++-v3/include/pstl/glue_algorithm_impl.h +++ b/libstdc++-v3/include/pstl/glue_algorithm_impl.h @@ -757,7 +757,7 @@ __pstl::__internal::__enable_if_execution_policy<_ExecutionPolicy, bool> equal(_ExecutionPolicy&& __exec, _ForwardIterat

[PATCH] tree-call-cdce: If !HONOR_NANS do not make code with NaNs (PR88055)

2019-04-18 Thread Segher Boessenkool
If we don't HONOR_NANS we should not try to use any unordered comparison results. Best case those will just be optimized away; realistically, they ICE. For example, the rs6000 backend has some code that specifically checks we never do this. This patch fixes it. Bootstrapped and tested on powerp

Re: [PATCH] Improve implementation of parallel equal()

2019-04-18 Thread Jonathan Wakely
On 16/04/19 12:39 -0700, Thomas Rodgers wrote: * include/pstl/algorithm_impl.h (__internal::__brick_equal): use "4 iterator" version of std::equal(). (__internal::__brick_equal): use simd for random access iterators on unsequenced execution policies.

Re: Adding noexcept-specification on tuple constructors (LWG 2899)

2019-04-18 Thread Jonathan Wakely
On 16/04/19 17:59 +0100, Nina Dinka Ranns wrote: On Tue, 16 Apr 2019 at 15:18, Jonathan Wakely wrote: On 16/04/19 14:08 +0100, Nina Dinka Ranns wrote: >Tested on Linux-PPC64 >Adding noexcept-specification on tuple constructors (LWG 2899) Thanks, Nina! This looks great, although as I think Vi

[PATCH v2] Use builtin sort instead of shell sort

2019-04-18 Thread Émeric Dupont
Some build environments and configuration options may lead to the make variable PLUGIN_HEADERS being too long to be passed as parameters to the shell `echo` command, leading to a "write error" message when making the target install-plugin. The following patch fixes this issue by using the [Make $(

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Martin Sebor
On 4/18/19 9:59 AM, Richard Sandiford wrote: Martin Sebor writes: On 4/18/19 6:07 AM, Richard Sandiford wrote: "Richard Earnshaw (lists)" writes: On 18/04/2019 03:38, Martin Sebor wrote: The fix for pr89797 committed in r270326 was limited to targets with NUM_POLY_INT_COEFFS == 1 which I th

Re: [PATCH v2] Add error message for target_clones and AVX512 ISAs (PR target/89929).

2019-04-18 Thread H.J. Lu
On Thu, Apr 18, 2019 at 4:07 AM Martin Liška wrote: > > Hi. > > I'm sending updated version of that patch. The patch rejects usage of AVX512 > ISAs (except AVX512F) > for target attribute for C++ multiversioning and for target_clone attribute. > > Patch can bootstrap on x86_64-linux-gnu and survi

Re: [C++ Patch/RFC] PR 89900 ("[9 Regression] ICE: Segmentation fault (in check_instantiated_arg)")

2019-04-18 Thread Jason Merrill
On Mon, Apr 15, 2019 at 1:08 PM Paolo Carlini wrote: > > Hi, > > On 12/04/19 20:29, Jason Merrill wrote: > > On 4/11/19 11:20 AM, Paolo Carlini wrote: > >> Hi, > >> > >> over the last few days I spent some time on this regression, which at > >> first seemed just a minor error-recovery issue, but t

Fix inliner ICE with flattening

2019-04-18 Thread Jan Hubicka
Hi, the testcase (which I fialed to annotate correctly for testsuite) triggers situation where we forget to update overall summary after flattenin and later ICE in verification that estimates match. Bootstrapped/regtested x86_64-linux, comitted. Index: ChangeLog ==

New German PO file for 'gcc' (version 9.1-b20190414)

2019-04-18 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the German team of translators. The file is available at: https://translationproject.org/latest/gcc/de.po (This file, 'gcc-9.1-b20190414.de.po',

[C++ PATCH] PR c++/87554 - ICE with extern template and reference member.

2019-04-18 Thread Jason Merrill
The removed code ended up setting DECL_INITIAL to the INIT_EXPR returned by split_nonconstant_init, which makes no sense. This code was added back in 1996, so any rationale is long lost. Tested x86_64-pc-linux-gnu, applying to trunk. * decl.c (cp_finish_decl): Don't set DECL_INITIAL of e

Re: [PATCH] PR translation/90118 Missing space between words

2019-04-18 Thread Richard Sandiford
Christophe Lyon writes: > Hi, > > This patch adds the missing space before '%<' in > config/aarch64/aarch64.c and gcc/cp/call.c. It also updates the > check-internal-format-escaping.py checker to warn about such cases. > > OK? > > Christophe > > diff --git a/contrib/check-internal-format-escaping.

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Richard Sandiford
Martin Sebor writes: > On 4/18/19 6:07 AM, Richard Sandiford wrote: >> "Richard Earnshaw (lists)" writes: >>> On 18/04/2019 03:38, Martin Sebor wrote: The fix for pr89797 committed in r270326 was limited to targets with NUM_POLY_INT_COEFFS == 1 which I think is all but aarch64. The

[PATCH][IRA] Fix PR87871: [9 Regression] testcases fail after r265398 on arm

2019-04-18 Thread Peter Bergner
PR87871 exposes a couple of problems. One problem fixed here is that IRA incorrectly adds a conflict in some cases where we have a simple register copy between a pseudo reg and a hard reg. This stopped us from assigning the pseudo reg to that hard reg which we wanted to do in the testsuite test c

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Martin Sebor
On 4/18/19 6:07 AM, Richard Sandiford wrote: "Richard Earnshaw (lists)" writes: On 18/04/2019 03:38, Martin Sebor wrote: The fix for pr89797 committed in r270326 was limited to targets with NUM_POLY_INT_COEFFS == 1 which I think is all but aarch64. The tests for the fix have been failing with

[PATCH] PR translation/90118 Missing space between words

2019-04-18 Thread Christophe Lyon
Hi, This patch adds the missing space before '%<' in config/aarch64/aarch64.c and gcc/cp/call.c. It also updates the check-internal-format-escaping.py checker to warn about such cases. OK? Christophe diff --git a/contrib/check-internal-format-escaping.py b/contrib/check-internal-format-escaping

Re: [RFC] D support for S/390

2019-04-18 Thread Robin Dapp
Hi Rainer, > I noticed you missed one piece of Iain's typeinfo.cc patch, btw.: > > diff --git a/gcc/d/typeinfo.cc b/gcc/d/typeinfo.cc > --- a/gcc/d/typeinfo.cc > +++ b/gcc/d/typeinfo.cc > @@ -886,7 +886,7 @@ public: > if (cd->isCOMinterface ()) > flags |= ClassFlags::isCOMclass; >

Re: [PATCH] S/390: Fix PR89952 incorrect CFI

2019-04-18 Thread Robin Dapp
Hi, > + Establish an ANTI dependency between r11 and r15 restores from FPRs > + to prevent the instructions scheduler from reordering them since > + this would break CFI. No further handling in the sched_reorder > + hook is required since the r11 and r15 restore will never appear in > +

[PATCH] gdbhooks.py: Fix UnicodeDecodeErrors when printing trees with corrupt codes

2019-04-18 Thread Eugene Sharygin
Hi, This silences UnicodeDecodeError Python exceptions raised when trying to print a tree with a corrupt (or uninitialized) code in Gdb: Python Exception 'utf-8' codec can't decode byte 0xb8 in position 0: invalid start byte: With this patch, TreePrinter would print such trees generically

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Christophe Lyon
On Thu, 18 Apr 2019 at 14:08, Richard Sandiford wrote: > > "Richard Earnshaw (lists)" writes: > > On 18/04/2019 03:38, Martin Sebor wrote: > >> The fix for pr89797 committed in r270326 was limited to targets > >> with NUM_POLY_INT_COEFFS == 1 which I think is all but aarch64. > >> The tests for t

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Richard Sandiford
"Richard Earnshaw (lists)" writes: > On 18/04/2019 03:38, Martin Sebor wrote: >> The fix for pr89797 committed in r270326 was limited to targets >> with NUM_POLY_INT_COEFFS == 1 which I think is all but aarch64. >> The tests for the fix have been failing with an ICE on aarch64 >> because it suffer

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Richard Earnshaw (lists)
On 18/04/2019 09:58, Richard Earnshaw (lists) wrote: > On 18/04/2019 03:38, Martin Sebor wrote: >> The fix for pr89797 committed in r270326 was limited to targets >> with NUM_POLY_INT_COEFFS == 1 which I think is all but aarch64. >> The tests for the fix have been failing with an ICE on aarch64 >>

Re: [PATCH][stage1] Enhance target and target_clone error messages.

2019-04-18 Thread Martin Liška
On 4/18/19 1:09 PM, Martin Liška wrote: > Hi. > > The patch distinguishes among target and target_clone attribute when > reporting for an error. I've also reworded the affected error messages > a bit. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be inst

[PATCH][stage1] Enhance target and target_clone error messages.

2019-04-18 Thread Martin Liška
Hi. The patch distinguishes among target and target_clone attribute when reporting for an error. I've also reworded the affected error messages a bit. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed after stage1 opens? Thanks, Martin --- gcc/cgraphc

[PATCH v2] Add error message for target_clones and AVX512 ISAs (PR target/89929).

2019-04-18 Thread Martin Liška
Hi. I'm sending updated version of that patch. The patch rejects usage of AVX512 ISAs (except AVX512F) for target attribute for C++ multiversioning and for target_clone attribute. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin >From

Re: Fix UB in int_const_binop

2019-04-18 Thread Richard Biener
On Thu, Apr 18, 2019 at 11:16 AM Richard Sandiford wrote: > > When testing PR 85164, the baseline bootstrap-ubsan results had > a lot of failures from int_const_binop. This is because with the > new overflow handling we can sometimes do: > > poly_res = res; > > on an uninitialised res. > >

Re: Fix two ubsan failures (PR85164)

2019-04-18 Thread Richard Biener
On Thu, Apr 18, 2019 at 11:13 AM Richard Sandiford wrote: > > Two fixes for UB when handling very large offsets. The calculation in > force_int_to_mode would have been correct if signed integers used modulo > arithmetic, so just switch to unsigned types. The calculation in > rtx_addr_can_trap_p_

[PATCH] Fix PR90131, wrong-debug

2019-04-18 Thread Richard Biener
This fixes another case similar to the fixed PR89892, mergephi via remove_forwarder_block_with_phi caused out-of-date debug binds to become live and thus needs similar treatment as remove_forwarder_block. Previously it didn't even bother to move debug stmts because the destination always has mul

Fix UB in int_const_binop

2019-04-18 Thread Richard Sandiford
When testing PR 85164, the baseline bootstrap-ubsan results had a lot of failures from int_const_binop. This is because with the new overflow handling we can sometimes do: poly_res = res; on an uninitialised res. Tested with bootstrap-ubsan on aarch64-linux-gnu and x86_64-linux-gnu. OK to

Fix two ubsan failures (PR85164)

2019-04-18 Thread Richard Sandiford
Two fixes for UB when handling very large offsets. The calculation in force_int_to_mode would have been correct if signed integers used modulo arithmetic, so just switch to unsigned types. The calculation in rtx_addr_can_trap_p_1 didn't handle overflow properly, so switch to known_subrange_p inst

Re: [PATCH] avoid aarch64 ICE on large vectors (PR 89797)

2019-04-18 Thread Richard Earnshaw (lists)
On 18/04/2019 03:38, Martin Sebor wrote: > The fix for pr89797 committed in r270326 was limited to targets > with NUM_POLY_INT_COEFFS == 1 which I think is all but aarch64. > The tests for the fix have been failing with an ICE on aarch64 > because it suffers from more or less the same problem but i

Re: [PATCH, GCC, AARCH64] Add GNU note section with BTI and PAC.

2019-04-18 Thread James Greenhalgh
On Thu, Apr 04, 2019 at 05:01:06PM +0100, Sudakshina Das wrote: > Hi Richard > > On 03/04/2019 11:28, Richard Henderson wrote: > > On 4/3/19 5:19 PM, Sudakshina Das wrote: > >> + /* PT_NOTE header: namesz, descsz, type. > >> + namesz = 4 ("GNU\0") > >> + descsz = 16 (Size of the program p

[PATCH, committed] Update my email address

2019-04-18 Thread Iain Sandoe
.. belatedly, it slipped my mind. Iain main-patch.diff Description: Binary data

Re: [PATCH] i18n fix for gimple-ssa-sprintf.c (PR translation/79183)

2019-04-18 Thread Richard Biener
On Thu, 18 Apr 2019, Jakub Jelinek wrote: > Hi! > > This patch fixes the following messages, so that they are translatable even > to languages that don't use the english > Plural-Forms: nplurals=2; plural=n != 1; > See > https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html#Plu