MAINTAINERS: add myself

2019-01-21 Thread Jiufu Guo
2019-01-21 Jiufu Guo * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 268134) +++ MAINTAINERS (working copy) @@ -400,6 +400,7 @@ Matthew Gretton-Dann

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Joseph Myers
On Mon, 21 Jan 2019, H.J. Lu wrote: > The testcase at > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931 > > with -frounding-math. __floattisf and __floattidf from libgcc2.c give > the wrong results for FE_UPWARD and FE_TOWARDZERO. I suggest writing a test that looks something like gcc.dg

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 4:58 PM Joseph Myers wrote: > > On Tue, 22 Jan 2019, Terry Guo wrote: > > > Hi Joseph, > > > > I believe HJ is proposing patch to fix bug > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931. In the test case > > of the bug, the "#pragma STDC FENV_ACCESS ON" is used and t

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Joseph Myers
On Tue, 22 Jan 2019, Terry Guo wrote: > Hi Joseph, > > I believe HJ is proposing patch to fix bug > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88931. In the test case > of the bug, the "#pragma STDC FENV_ACCESS ON" is used and there are Which isn't supported by GCC. Any test involving roundin

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Terry Guo
On Tue, Jan 22, 2019 at 7:48 AM Joseph Myers wrote: > > On Mon, 21 Jan 2019, H.J. Lu wrote: > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > FSTYPE > > FUNC (DWtype u) > > { > > ... > > } > > > > have no rounding mode support. We should replace __floattisf, __floattidf, > > __floatunti

Re: [RS6000] PR88614, output_operand: invalid %z value

2019-01-21 Thread Segher Boessenkool
On Tue, Jan 22, 2019 at 10:59:57AM +1030, Alan Modra wrote: > > I think this would be nicer if you still used insn alternatives here. > > What is needed for that? > > A new symbol constraint especially for __tls_get_addr? Actually two > new constraints for ppc64, one for small model, the other fo

Re: [RS6000] PR88614, output_operand: invalid %z value

2019-01-21 Thread Alan Modra
On Mon, Jan 21, 2019 at 08:22:58AM -0600, Segher Boessenkool wrote: > On Mon, Jan 21, 2019 at 10:48:57PM +1030, Alan Modra wrote: > > Here's what the revised approach looks like, but without using new > > unspecs. Bootstrap and regression test on powerpc64le-linux and > > powerpc64-linux biarch co

libgo patch committed: Fix build for ARM GNU/Linux

2019-01-21 Thread Ian Lance Taylor
This patch to libgo fixes the build for ARM GNU/Linux. It was failing with ../../../libgo/go/internal/cpu/cpu.go:138:2: error: reference to undefined name 'doinit' 138 | doinit() | ^ This patch fixes it by adding in Go 1.12 internal/cpu/cpu_arm.go, and the code in runtime that initiali

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Joseph Myers
On Mon, 21 Jan 2019, H.J. Lu wrote: > TI->SF and TI->DF conversions in libgcc2.c: > > FSTYPE > FUNC (DWtype u) > { > ... > } > > have no rounding mode support. We should replace __floattisf, __floattidf, > __floatuntisf and __floatuntidf in libgcc2.c with these from soft-fp. Please explain w

libgo patch committed: Solaris fixes

2019-01-21 Thread Ian Lance Taylor
This libgo patch fixes the build and some tests for Solaris after the recent update to 1.12beta2. It also changes c-archive mode to fetch argc/argv/env from /proc, which fixes it to work instead of crashing as it did before. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu and x86_64-sun-

Go patch committed: Stop archive iterator on error

2019-01-21 Thread Ian Lance Taylor
In the Go frontend, if there is an error reading or parsing an archive header, the Archive_iterator code would return a dummy header but would not mark itself as done. The effect is that an invalid archive leads to an endless loop reading and re-reading the same archive header. Avoid that by sett

[committed] Fix DECL_OMP_PRIVATE_MEMBER copying in C++ cdtors (PR c++/88949)

2019-01-21 Thread Jakub Jelinek
Hi! For DECL_OMP_PRIVATIZED_MEMBER vars, we can't really share the DECL_VALUE_EXPR between the abstract cdtor and base/complete etc. cdtors, it contains the this PARM_DECL and we need to adjust it to whatever the particular variant has. Fixed thusly, bootstrapped/regtested on x86_64-linux and i68

[PATCH] Fix up thread_jump handling of jumps with clobbers (PR rtl-optimization/88904)

2019-01-21 Thread Jakub Jelinek
Hi! The following patch is miscompiled on arm thumb1, where there is (jump_insn 32 31 33 4 (parallel [ (set (pc) (if_then_else (ne (zero_extract:SI (reg:SI 3 r3 [orig:127 ret+8 ] [127]) (const_int 1 [0x1]) (const_

[PATCH] Fix REG_EQUAL notes for doubleword POPCOUNT etc. unops (PR target/88905)

2019-01-21 Thread Jakub Jelinek
Hi! add_equal_note has special code to handle properly doubleword POPCOUNT and similar builtins, e.g. for POPCOUNT if we don't have DImode POPCOUNT, it can be expanded as 2 SImode POPCOUNTs added together, but for the REG_EQUAL note we want lowpart SImode SUBREG of DImode POPCOUNT. Unfortunately,

[PATCH] Fix block copy/move/compare expansion (PR rtl-optimization/86334, PR target/88906)

2019-01-21 Thread Jakub Jelinek
Hi! Apparently RTL DSE doesn't perform any kind of escape analysis for e.g. frame pointer related addresses, instead relies on TREE_ADDRESSABLE being set on MEM_EXPR VAR_DECLs if the address could leak to other functions. Since PR49454 expr.c contains code to force those to be addressable if they

Re: [PATCH] Fix latent SLP bugs and a memleak

2019-01-21 Thread Richard Sandiford
Richard Biener writes: > @@ -5742,8 +5740,14 @@ vectorize_fold_left_reduction (stmt_vec_info stmt_info, >auto_vec vec_oprnds0; >if (slp_node) > { > - vect_get_vec_defs (op0, NULL_TREE, stmt_info, &vec_oprnds0, NULL, > - slp_node); > + auto_vec > vec_defs

Re: testsuite dg-directives glitches

2019-01-21 Thread Dominique d'Humières
Hi Manfred, > could someone please check and commit? Tested and committed as obvious at r268125. Thanks for the patch. Dominique

Re: V3 [PATCH] i386: Add pass_remove_partial_avx_dependency

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 10:54 AM Jeff Law wrote: > > On 1/7/19 6:55 AM, H.J. Lu wrote: > > On Sun, Dec 30, 2018 at 8:40 AM H.J. Lu wrote: > >> On Wed, Nov 28, 2018 at 12:17 PM Jeff Law wrote: > >>> On 11/28/18 12:48 PM, H.J. Lu wrote: > On Mon, Nov 5, 2018 at 7:29 AM Jan Hubicka wrote: > >

[PATCH, d] Committed merge with upstream dmd

2019-01-21 Thread Iain Buclaw
Hi, This patch merges the D front-end implementation with dmd upstream 180465274. Main bulk of it reduces the memory footprint of the CTFE interpreter by replacing new with emplacement new in many places. Bootstrapped and regression tested on x86_64-linux-gnu. Committed to trunk as r268124. --

Re: [PATCH] introduce effective-target fold_memcpy

2019-01-21 Thread Martin Sebor
On 1/21/19 1:18 AM, Richard Biener wrote: On Sat, Jan 19, 2019 at 12:25 AM Martin Sebor wrote: Some of the -Warray-bounds and -Wrestrict tests are prone to failing on targets like arm-eabi and others that use different parameters to decide which memcpy calls should be folded to MEM_REF (those

[PATCH, i386]: Fix PR88938, ICE in extract_insn

2019-01-21 Thread Uros Bizjak
We need to sanitize operands to fit insn predicates. 2019-01-21 Uroš Bizjak PR target/88938 * config/i386/i386.c (ix86_expand_builtin) [case IX86_BUILTIN_BEXTRI32, case IX86_BUILTIN_BEXTRI64]: Sanitize operands. testsuite/ChangeLog: 2019-01-21 Uroš Bizjak PR target/88938

Re: C++ PATCH for c++/78244 - narrowing conversion in template not detected, part 2

2019-01-21 Thread Jason Merrill
On 1/18/19 9:12 AM, Marek Polacek wrote: On Thu, Jan 17, 2019 at 04:17:29PM -0500, Jason Merrill wrote: On 1/17/19 2:09 PM, Marek Polacek wrote: This patch ought to fix the rest of 78244, a missing narrowing warning in decltype. As I explained in Bugzilla, there can be three scenarios: 1) dec

Re: [C++ PATCH] Fix -fsanitize=pointer-compare,pointer-subtract ICEs in templates (PR sanitizer/88901)

2019-01-21 Thread Jason Merrill
On 1/18/19 5:38 PM, Jakub Jelinek wrote: Hi! When processing_template_decl, all we care about is diagnostics and the return type if it is not dependent; other spots that add sanitization do nothing if processing_template_decl and the following patch does that for the two recently added ones. Wi

Re: V3 [PATCH] i386: Add pass_remove_partial_avx_dependency

2019-01-21 Thread Jeff Law
On 1/7/19 6:55 AM, H.J. Lu wrote: > On Sun, Dec 30, 2018 at 8:40 AM H.J. Lu wrote: >> On Wed, Nov 28, 2018 at 12:17 PM Jeff Law wrote: >>> On 11/28/18 12:48 PM, H.J. Lu wrote: On Mon, Nov 5, 2018 at 7:29 AM Jan Hubicka wrote: >> On 11/5/18 7:21 AM, Jan Hubicka wrote: Did you me

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 9:09 AM H.J. Lu wrote: > > On Mon, Jan 21, 2019 at 8:59 AM Uros Bizjak wrote: > > > > On Mon, Jan 21, 2019 at 5:56 PM H.J. Lu wrote: > > > > > > On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > > > > > > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > > >

[PATCH] Add target-zlib to top-level configure, use zlib from libphobos

2019-01-21 Thread Iain Buclaw
Hi, Following on from the last, this adds target-zlib to target_libraries and updates libphobos build scripts to link to libz_convenience.a. The D front-end already has target-zlib in d/config-lang.in. Is the top-level part OK? I considered disabling target-zlib if libphobos is not being built,

Re: [patch] Document AMD GCN features.

2019-01-21 Thread Jeff Law
On 1/18/19 4:42 AM, Andrew Stubbs wrote: > Hi, > > This patch adds the documentation needed for the newly-added AMD GCN > back end. > > OK to commit? > > Andrew > > 190118-gcc-gcn-docs.patch > > Document AMD GCN. > > 2019-01-18 Andrew Stubbs > > gcc/ > * doc/extend.tex (AMD GC

Re: [PATCH] sched-ebb.c: avoid moving table jumps (PR rtl-optimization/88423)

2019-01-21 Thread Jeff Law
On 1/18/19 10:32 AM, David Malcolm wrote: > PR rtl-optimization/88423 reports an ICE within sched-ebb.c's > begin_move_insn, failing the assertion at line 175, where there's > no fall-through edge: > > 171 rtx_insn *x = NEXT_INSN (insn); > 172 if (e) > 173 gcc_checking_as

[committed][PATCH][GCC][AArch64] Fix big-endian and ILP32 fail for simd-clone test

2019-01-21 Thread Tamar Christina
Hi All, This fixes the failing testcase for simd-clone-7.cc for the ILP32 case and big-endian. Regtested on aarch64-none-linux-gnu and aarch6_be-none-elf and no issues. Committed under the GCC obvious rule. Thanks, Tamar gcc/testsuite/ChangeLog: 2019-01-21 Tamar Christina * g++.

RE: [EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-01-21 Thread Tamar Christina
Hi Richard, > -Original Message- > From: Richard Sandiford > Sent: Monday, January 21, 2019 16:42 > To: Tamar Christina > Cc: Steve Ellcey ; christophe.l...@linaro.org; gcc- > patc...@gcc.gnu.org; nd > Subject: Re: [EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI > > Tamar

Re: [PATCH] doc: showcase a "union of vectors" pattern (PR 88698)

2019-01-21 Thread Alexander Monakov
On Mon, 21 Jan 2019, Richard Biener wrote: > > Sorry, I don't see what you mean here; can you give an example or elaborate? > > when you call a function with v4si signature but want to pass it a result > from a __mm intrinsic you'd need a temporary union to do the marshalling. > I think you can u

Re: [C++ Patch] Locations related grokdeclarator tweak

2019-01-21 Thread Paolo Carlini
Hi, On 21/01/19 18:22, Jason Merrill wrote: On 1/18/19 6:13 AM, Paolo Carlini wrote: a tweak to typespec_loc, where the existing conditional turns out to be just a special case of the full min_location that we want in order to do the right thing for testcases like diagnostic/trailing1.C. Test

Re: [C++ PATCH] [PR87770] test partial specializations for type dependence

2019-01-21 Thread Jason Merrill
On 1/18/19 1:55 AM, Alexandre Oliva wrote: When instantiating a partial specialization of a template member function for a full specialization of a class template, we test whether the context of variables local to the partial specialization, i.e., the partial specialization itself, is dependent,

Re: [C++ Patch] Locations related grokdeclarator tweak

2019-01-21 Thread Jason Merrill
On 1/18/19 6:13 AM, Paolo Carlini wrote: a tweak to typespec_loc, where the existing conditional turns out to be just a special case of the full min_location that we want in order to do the right thing for testcases like diagnostic/trailing1.C. Tested x86_64-linux. This is OK, but I don't thi

Re: Patch ping (Re: [wwwdocs] Add __cpp_* feature macros to C++20 entries + other changes that have those in projects/cxx_status.html)

2019-01-21 Thread Jonathan Wakely
On 21/01/19 17:36 +0100, Jakub Jelinek wrote: On Mon, Jan 21, 2019 at 04:11:04PM +, Jonathan Wakely wrote: > I'd like to ping this patch. For P0941R2 I think we can just say it's supported. For the library docs I said we support it since GCC 5.1 because that's when we started defining featu

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 8:59 AM Uros Bizjak wrote: > > On Mon, Jan 21, 2019 at 5:56 PM H.J. Lu wrote: > > > > On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > > > > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > > > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > > > > >

Re: libgo patch committed: Update to Go1.12beta2

2019-01-21 Thread Ian Lance Taylor
On Mon, Jan 21, 2019 at 4:22 AM Matthias Klose wrote: > > On 18.01.19 20:04, Ian Lance Taylor wrote: > > I have committed a patch to update libgo to the Go 1.12beta2 release. > > > > As usual this sort of update is too large to include all changes in > > this e-mail. I've included changes to gccg

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Uros Bizjak
On Mon, Jan 21, 2019 at 5:56 PM H.J. Lu wrote: > > On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > > > FSTYPE > > > FUNC (DWtype u) > > > { > > > ... > > > } > > > > > > ha

Re: [PATCH] Fix issues with -Waddress-of-packed-member

2019-01-21 Thread Jeff Law
On 1/20/19 10:10 AM, Bernd Edlinger wrote: > On 1/20/19 4:40 PM, H.J. Lu wrote: >> On Sun, Jan 20, 2019 at 5:29 AM Bernd Edlinger >> wrote: >>> Hi, >>> >>> >>> I tried to build linux yesterday, and became aware that there are a few >>> false-positive warnings with -Waddress-of-packed-member: >>> >

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 8:43 AM Uros Bizjak wrote: > > On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > > > TI->SF and TI->DF conversions in libgcc2.c: > > > > FSTYPE > > FUNC (DWtype u) > > { > > ... > > } > > > > have no rounding mode support. We should replace __floattisf, __floattidf, >

Re: [PATCH] Fix issues with -Waddress-of-packed-member

2019-01-21 Thread Jeff Law
On 1/20/19 6:29 AM, Bernd Edlinger wrote: > Hi, > > > I tried to build linux yesterday, and became aware that there are a few > false-positive warnings with -Waddress-of-packed-member: > > struct t { > char a; > int b; > int *c; > int d[10]; > } __attribute__((packed)); > > struct t t0;

Re: [PATCH] Fix gcc.dg/utf-array.c testcase

2019-01-21 Thread Jeff Law
On 1/21/19 9:00 AM, Tamar Christina wrote: > Forwarding to list. > >> -Original Message- >> From: Tamar Christina >> Sent: Monday, January 21, 2019 15:25 >> To: 'Jakub Jelinek' ; Jason Merrill >> Cc: gcc-patches@gcc.gnu.org >> Subject: RE: [PATCH] Fix gcc.dg/utf-array.c testcase >> >> Hi,

Re: [PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread Uros Bizjak
On Mon, Jan 21, 2019 at 5:15 PM H.J. Lu wrote: > > TI->SF and TI->DF conversions in libgcc2.c: > > FSTYPE > FUNC (DWtype u) > { > ... > } > > have no rounding mode support. We should replace __floattisf, __floattidf, > __floatuntisf and __floatuntidf in libgcc2.c with these from soft-fp. > >

Re: [EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-01-21 Thread Richard Sandiford
Tamar Christina writes: > Hi All, > > The simd-clone-7.cc tests seem to fail on big-endian with > > testsuite/g++.dg/vect/simd-clone-7.cc:7:1: warning: GCC does not currently > support mixed size types for 'simd' functions > > The test probably miss an effective target check? The current conditi

Re: Patch ping (Re: [wwwdocs] Add __cpp_* feature macros to C++20 entries + other changes that have those in projects/cxx_status.html)

2019-01-21 Thread Jakub Jelinek
On Mon, Jan 21, 2019 at 04:11:04PM +, Jonathan Wakely wrote: > > I'd like to ping this patch. > > For P0941R2 I think we can just say it's supported. For the library > docs I said we support it since GCC 5.1 because that's when we started > defining feature test macros. The point of the paper

Re: [PATCH] Fix -Wattribute-alias option

2019-01-21 Thread Martin Sebor
On 1/21/19 8:55 AM, Bernd Edlinger wrote: On 1/21/19 4:42 PM, Arnd Bergmann wrote: On Sat, Jan 19, 2019 at 11:06 AM Bernd Edlinger wrote: Hi, the command line option -Wattribute-alias (w/o the "=1") is currently broken, and only -Wno-attribute-alias is still working, but what is worse, is

[PATCH] x86-64: Use TI->SF and TI->DF conversions in soft-fp

2019-01-21 Thread H.J. Lu
TI->SF and TI->DF conversions in libgcc2.c: FSTYPE FUNC (DWtype u) { ... } have no rounding mode support. We should replace __floattisf, __floattidf, __floatuntisf and __floatuntidf in libgcc2.c with these from soft-fp. PR libgcc/88931 * config/i386/64/t-softfp-compat (libgcc2

Re: [PATCH]i386: Add BDESC2 for ix86_isa_flags2 and refine all related.

2019-01-21 Thread Uros Bizjak
On Mon, Jan 21, 2019 at 11:00 AM Hongtao Liu wrote: > > Hi Uros, > > There are > > struct builtin_description > { > const HOST_WIDE_INT mask; > const enum insn_code icode; > const char *const name; > const enum ix86_builtins code; > const enum rtx_code comparison; > const int flag; > }

Re: Patch ping (Re: [wwwdocs] Add __cpp_* feature macros to C++20 entries + other changes that have those in projects/cxx_status.html)

2019-01-21 Thread Jonathan Wakely
On 21/01/19 14:40 +0100, Jakub Jelinek wrote: Hi! On Sat, Jan 12, 2019 at 02:08:15PM +0100, Jakub Jelinek wrote: Here is an updated patch, that in addition to that makes 9 URLs as we now have #cxx in gcc-9/changes.html and adds missing P0941R2 entry that clang table has. For that one I'm not 1

RE: [EXT] Re: [Patch 2/4][Aarch64] v2: Implement Aarch64 SIMD ABI

2019-01-21 Thread Tamar Christina
Hi All, The simd-clone-7.cc tests seem to fail on big-endian with testsuite/g++.dg/vect/simd-clone-7.cc:7:1: warning: GCC does not currently support mixed size types for 'simd' functions The test probably miss an effective target check? Cheers, Tamar > -Original Message- > From: gcc-

RE: [PATCH] Fix gcc.dg/utf-array.c testcase

2019-01-21 Thread Tamar Christina
Forwarding to list. > -Original Message- > From: Tamar Christina > Sent: Monday, January 21, 2019 15:25 > To: 'Jakub Jelinek' ; Jason Merrill > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH] Fix gcc.dg/utf-array.c testcase > > Hi, > > These fail on aarch64*-*-* and arm*-*-* too, but

[PATCH][GCC] Fix oversized shifts in PR/88903 testcase.

2019-01-21 Thread Tamar Christina
Hi All, The testcase for PR/tree-optimization 88903 hits undefined behavior for the overwide shifts. This is causing the testcases to fail for all Arm platforms. This updates the testcase to add an explicit & such that the behavior is consistent. Regtested on aarch64-none-linux-gnu and no issue

Re: [PATCH] Fix -Wattribute-alias option

2019-01-21 Thread Arnd Bergmann
On Mon, Jan 21, 2019 at 4:55 PM Bernd Edlinger wrote: > On 1/21/19 4:42 PM, Arnd Bergmann wrote: > > On Sat, Jan 19, 2019 at 11:06 AM Bernd Edlinger > > wrote: > >> > >> Hi, > >> > >> the command line option -Wattribute-alias (w/o the "=1") is currently > >> broken, > >> and only -Wno-attribute-

Re: [PATCH] Fix -Wattribute-alias option

2019-01-21 Thread Bernd Edlinger
On 1/21/19 4:42 PM, Arnd Bergmann wrote: > On Sat, Jan 19, 2019 at 11:06 AM Bernd Edlinger > wrote: >> >> Hi, >> >> the command line option -Wattribute-alias (w/o the "=1") is currently broken, >> and only -Wno-attribute-alias is still working, but what is worse, is that >> the #pragma GCC diagn

Re: [PATCH] Fix -Wattribute-alias option

2019-01-21 Thread Arnd Bergmann
On Sat, Jan 19, 2019 at 11:06 AM Bernd Edlinger wrote: > > Hi, > > the command line option -Wattribute-alias (w/o the "=1") is currently broken, > and only -Wno-attribute-alias is still working, but what is worse, is that > the #pragma GCC diagnostic fails to recognize the string "-Wattribute-alia

[PATCH] Fix latent SLP bugs and a memleak

2019-01-21 Thread Richard Biener
When investigating some issues I ran into two SLP op gathering issues. *You may not ask for SLP vector def ops in the wrong order* Both vectorizable_comparison and vectorize_fold_left_reduction fall into this trap. I've also fixed a memleak uncovered by valgrind that I ran on the above fix and

[PATCH] Fix PR88934

2019-01-21 Thread Richard Biener
This fixes PR88934 and makes vect_mask_constant_operand_p a little bit more sensible by consistently looking at the first comparison operand rather than a different one depending on whether this is a COND_EXPR vs. a tcc_comparison one. The first one happens to be non-constant if any is. We'll s

Re: Fortran vector math header

2019-01-21 Thread Joseph Myers
On Mon, 21 Jan 2019, Martin Liška wrote: > I like the if('lp64'), if('ilp32') approach and I'm sending patch > candidate for that. Would it be accepted by glibc folks? Since glibc supports libmvec for x86_64, both 64-bit and x32, but not for 32-bit x86, those particular conditionals are insuffi

Re: [RS6000] PR88614, output_operand: invalid %z value

2019-01-21 Thread Segher Boessenkool
On Mon, Jan 21, 2019 at 10:48:57PM +1030, Alan Modra wrote: > On Mon, Jan 21, 2019 at 12:08:33AM +1030, Alan Modra wrote: > > Hmm, if I invent a couple of new unspecs, UNSPEC_TLSGD_NOMARK and > > UNSPEC_TLSLD_NOMARK, using them in place of UNSPEC_TLSGD and > > UNSPEC_TLSLD when !TARGET_TLS_MARKERS

Patch ping (Re: [wwwdocs] Add __cpp_* feature macros to C++20 entries + other changes that have those in projects/cxx_status.html)

2019-01-21 Thread Jakub Jelinek
Hi! On Sat, Jan 12, 2019 at 02:08:15PM +0100, Jakub Jelinek wrote: > Here is an updated patch, that in addition to that makes 9 URLs as we now > have #cxx in gcc-9/changes.html and adds missing P0941R2 entry that clang > table has. For that one I'm not 100% sure what to say, I've copied all the >

Re: [PATCH] PR libstdc++/88782 avoid ODR problems in std::make_shared

2019-01-21 Thread Jonathan Wakely
On 18/01/19 21:28 +, Jonathan Wakely wrote: The old version of _Sp_counted_ptr_inplace::_M_get_deleter (up to GCC 8.2.0) expects to be passed a real std::typeinfo object, so mixing that with the new definition of the __shared_ptr constructor (which always passes the fake tag) leads to accessi

Re: V3 [PATCH] c-family: Update unaligned adress of packed member check

2019-01-21 Thread H.J. Lu
On Mon, Jan 21, 2019 at 4:57 AM Maxim Kuvyrkov wrote: > > Hi H.J., > > I've bisected compiler crash on building linux kernel for ARM down to this > commit. Search for > == > fs/ntfs/super.c:597:3: internal compiler error: Segmentation fault > == > in > https://ci.linaro.org/view/tcwg_kernel-gnu

Re: V3 [PATCH] c-family: Update unaligned adress of packed member check

2019-01-21 Thread Maxim Kuvyrkov
Hi H.J., I've bisected compiler crash on building linux kernel for ARM down to this commit. Search for == fs/ntfs/super.c:597:3: internal compiler error: Segmentation fault == in https://ci.linaro.org/view/tcwg_kernel-gnu/job/tcwg_kernel-build-gnu-master-arm-mainline-defconfig/285/artifact/arti

Re: [PATCH] PR libstdc++/88782 avoid ODR problems in std::make_shared

2019-01-21 Thread Jonathan Wakely
On 21/01/19 11:32 +, Jonathan Wakely wrote: On 21/01/19 12:16 +0100, Richard Biener wrote: On Mon, Jan 21, 2019 at 12:08 PM Jonathan Wakely wrote: On 21/01/19 09:13 +0100, Richard Biener wrote: On Fri, Jan 18, 2019 at 10:29 PM Jonathan Wakely wrote: The old version of _Sp_counted_ptr_

Re: libgo patch committed: Update to Go1.12beta2

2019-01-21 Thread Matthias Klose
On 18.01.19 20:04, Ian Lance Taylor wrote: > I have committed a patch to update libgo to the Go 1.12beta2 release. > > As usual this sort of update is too large to include all changes in > this e-mail. I've included changes to gccgo-specific files below. > > Bootstrapped and ran Go testsuite on

Re: [RS6000] PR88614, output_operand: invalid %z value

2019-01-21 Thread Alan Modra
On Mon, Jan 21, 2019 at 12:08:33AM +1030, Alan Modra wrote: > Hmm, if I invent a couple of new unspecs, UNSPEC_TLSGD_NOMARK and > UNSPEC_TLSLD_NOMARK, using them in place of UNSPEC_TLSGD and > UNSPEC_TLSLD when !TARGET_TLS_MARKERS then that should be enough to > tell when we have a -mno-tls-markers

Re: [PATCH] PR libstdc++/88782 avoid ODR problems in std::make_shared

2019-01-21 Thread Jonathan Wakely
On 21/01/19 12:16 +0100, Richard Biener wrote: On Mon, Jan 21, 2019 at 12:08 PM Jonathan Wakely wrote: On 21/01/19 09:13 +0100, Richard Biener wrote: >On Fri, Jan 18, 2019 at 10:29 PM Jonathan Wakely wrote: >> >> The old version of _Sp_counted_ptr_inplace::_M_get_deleter (up to GCC >> 8.2.0)

incorrect parsing of -fopt-info

2019-01-21 Thread Ulrich Drepper
There is a problem with parsing the second part of the -fopt-info command line parameter in case there is an equal sign followed by a filename with a dash: $ g++ -c -O -fopt-info-all=some-file u.cc cc1plus: warning: unknown option ‘all=some’ in ‘-fopt-info-all=some-file’ cc1plus: error: unrecogniz

Re: [RFC] [Patch] [Debug] Add new NOTE to be used for debugging.

2019-01-21 Thread Alan Hayward
(Apologies this isn’t using the reply id) FYI, I tried the patch below and I’m happy it fixes the GDB issue in PR debug/88432. In the meantime, GDB HEAD has a workaround to disable stack protection in the GDB testsuite, and a KFAILed test for the exact bug. See: https://sourceware.org/ml/gdb-pat

Re: [PATCH][GCC][Arm] Rewrite arm testcase to use intrinsics

2019-01-21 Thread Ramana Radhakrishnan
On 20/01/2019 15:48, Segher Boessenkool wrote: > Hi! > > On Thu, Jan 17, 2019 at 03:02:00PM +, Tamar Christina wrote: >> This test was added back when builtins were being used instead of ACLE >> intrinsics. The test as far as I can tell is really testing vcombine, >> however some of these bui

Re: Implement C++20 feature P0600r1: nodiscard in the library

2019-01-21 Thread Jonathan Wakely
On 20/01/19 17:09 +0100, Ulrich Drepper wrote: Since a previous patch introduced the _GLIBCXX_NODISCARD macro it is now simple to implement the rest of P0600. The parts specific to C++20 were already added, this patch adds the attribute to the other functions. Even though the feature specifies

Re: [PATCH] Use __builtin_is_constant_evaluated some more (PR libstdc++/86590)

2019-01-21 Thread Jonathan Wakely
On 19/01/19 23:56 +0100, Jakub Jelinek wrote: Hi! The following patch uses __builtin_is_constant_evaluated for __constant_string_p and __constant_char_array_p - in constexpr contexts, all the strings or arrays should be constant, and by doing it this way the compiler should be able to optimize b

Re: [PATCH] PR libstdc++/88782 avoid ODR problems in std::make_shared

2019-01-21 Thread Richard Biener
On Mon, Jan 21, 2019 at 12:08 PM Jonathan Wakely wrote: > > On 21/01/19 09:13 +0100, Richard Biener wrote: > >On Fri, Jan 18, 2019 at 10:29 PM Jonathan Wakely wrote: > >> > >> The old version of _Sp_counted_ptr_inplace::_M_get_deleter (up to GCC > >> 8.2.0) expects to be passed a real std::typein

Re: [PATCH] doc: showcase a "union of vectors" pattern (PR 88698)

2019-01-21 Thread Richard Biener
On Mon, Jan 21, 2019 at 10:14 AM Alexander Monakov wrote: > > On Mon, 21 Jan 2019, Richard Biener wrote: > > > I'm not sure whether it's permitted to use this in C++ or not (and whether > > the C usage is now officially sanctioned other than via a non-normative > > footnote) - but at least GCC wil

Re: [PATCH] PR libstdc++/88782 avoid ODR problems in std::make_shared

2019-01-21 Thread Jonathan Wakely
On 21/01/19 09:13 +0100, Richard Biener wrote: On Fri, Jan 18, 2019 at 10:29 PM Jonathan Wakely wrote: The old version of _Sp_counted_ptr_inplace::_M_get_deleter (up to GCC 8.2.0) expects to be passed a real std::typeinfo object, so mixing that with the new definition of the __shared_ptr const

[PATCH]i386: Add BDESC2 for ix86_isa_flags2 and refine all related.

2019-01-21 Thread Hongtao Liu
Hi Uros, There are struct builtin_description { const HOST_WIDE_INT mask; const enum insn_code icode; const char *const name; const enum ix86_builtins code; const enum rtx_code comparison; const int flag; }; Since "mask" is used for both ix86_isa_flags and ix86_isa_flags2, buitins wi

Re: Fortran vector math header

2019-01-21 Thread Jakub Jelinek
On Mon, Jan 21, 2019 at 10:36:20AM +0100, Martin Liška wrote: > @@ -11338,7 +11339,7 @@ gfc_match_gcc_unroll (void) >return MATCH_ERROR; > } > > -/* Match a !GCC$ builtin (b) attributes simd flags form: > +/* Match a !GCC$ builtin (b) attributes simd if(target) flags form: > > The para

Re: Fortran vector math header

2019-01-21 Thread Martin Liška
On 1/21/19 10:19 AM, Jakub Jelinek wrote: > On Mon, Jan 21, 2019 at 10:09:01AM +0100, Martin Liška wrote: >> @@ -11351,6 +11352,7 @@ match >> gfc_match_gcc_builtin (void) >> { >>char builtin[GFC_MAX_SYMBOL_LEN + 1]; >> + char target[GFC_MAX_SYMBOL_LEN + 1]; >> >>if (gfc_match (" ( %n )

Re: Fortran vector math header

2019-01-21 Thread Jakub Jelinek
On Mon, Jan 21, 2019 at 10:09:01AM +0100, Martin Liška wrote: > @@ -11351,6 +11352,7 @@ match > gfc_match_gcc_builtin (void) > { >char builtin[GFC_MAX_SYMBOL_LEN + 1]; > + char target[GFC_MAX_SYMBOL_LEN + 1]; > >if (gfc_match (" ( %n ) attributes simd", builtin) != MATCH_YES) > re

Re: [PATCH] doc: showcase a "union of vectors" pattern (PR 88698)

2019-01-21 Thread Alexander Monakov
On Mon, 21 Jan 2019, Richard Biener wrote: > I'm not sure whether it's permitted to use this in C++ or not (and whether > the C usage is now officially sanctioned other than via a non-normative > footnote) - but at least GCC will guarantee that it works. My impression is that, via the "active mem

Re: Fortran vector math header

2019-01-21 Thread Martin Liška
On 1/21/19 8:58 AM, Jakub Jelinek wrote: > On Mon, Jan 21, 2019 at 08:47:42AM +0100, Martin Liška wrote: >> diff --git a/gcc/fortran/decl.c b/gcc/fortran/decl.c >> index 3314e176881..5c7c062574b 100644 >> --- a/gcc/fortran/decl.c >> +++ b/gcc/fortran/decl.c >> @@ -11351,6 +11351,7 @@ match >> gfc_

Re: [PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option

2019-01-21 Thread Kyrill Tkachov
Hi David, On 19/01/19 01:36, David Malcolm wrote: On Fri, 2019-01-18 at 19:25 +, Andrea Corallo wrote: > Hi all, > this patch add gcc_jit_context_add_driver_option to the libgccjit ABI > and a testcase for it. > > Using this interface is now possible to pass options affecting > assembler and

[PATCH][gcc] libgccjit: introduce gcc_jit_context_add_driver_option

2019-01-21 Thread Andrea Corallo
Hi all, Second version of the patch addressing David's comment about all-non-failing-tests.h Adds gcc_jit_context_add_driver_option to the libgccjit ABI and a testcase for it. Using this interface is now possible to pass options affecting assembler and linker. Does not introduce regressions r

[PATCH] Revert a hunk from r261322 (PR lto/88876).

2019-01-21 Thread Martin Liška
Hi. The patch puts back ::get_create for a node that can be seen first time. It's due to -O0 optimize attribute. It was unable to write properly LTO test-case for it. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 201

Re: [PATCH, zlib] Rename libzgcj_convenience to libz_convenience

2019-01-21 Thread Richard Biener
On Sun, Jan 20, 2019 at 8:34 PM Iain Buclaw wrote: > > Hi, > > As a prerequisite for enabling subdir-objects to libphobos configure > scripts, the build should be linking to a zlib convenience library, > rather than building the zlib sources directly from libphobos. > > Looking at the existing con

Re: [PATCH] doc: showcase a "union of vectors" pattern (PR 88698)

2019-01-21 Thread Richard Biener
On Sun, Jan 20, 2019 at 11:40 AM Alexander Monakov wrote: > > Hi, > > PR 88698 ("Relax generic vector conversions") is asking to be more permissive > about type compatibility for generic vector types. While I don't think that's > a good idea per se, from a "compiler user" point of view I also see

Re: [PATCH] introduce effective-target fold_memcpy

2019-01-21 Thread Richard Biener
On Sat, Jan 19, 2019 at 12:25 AM Martin Sebor wrote: > > Some of the -Warray-bounds and -Wrestrict tests are prone to failing > on targets like arm-eabi and others that use different parameters to > decide which memcpy calls should be folded to MEM_REF (those that do > are copies of small power-of

Re: [PATCH] Don't use align > MAX_SUPPORTED_STACK_ALIGNMENT in assign_stack_temp_for_type (PR bootstrap/88450)

2019-01-21 Thread Eric Botcazou
> Bootstrapped/regtested on x86_64-linux and i686-linux, but that doesn't mean > much, because MAX_SUPPORTED_STACK_ALIGNMENT there is 1 << 28. Guess more > useful would be to test it on mingw where BIGGEST_ALIGNMENT is often higher > than MAX_SUPPORTED_STACK_ALIGNMENT. > > Thoughts on this? > >

Re: [PATCH] PR libstdc++/88782 avoid ODR problems in std::make_shared

2019-01-21 Thread Richard Biener
On Fri, Jan 18, 2019 at 10:29 PM Jonathan Wakely wrote: > > The old version of _Sp_counted_ptr_inplace::_M_get_deleter (up to GCC > 8.2.0) expects to be passed a real std::typeinfo object, so mixing that > with the new definition of the __shared_ptr constructor (which always > passes the fake tag)

Re: [PATCH] Fix leak in splay-tree

2019-01-21 Thread Richard Biener
On Fri, Jan 18, 2019 at 10:27 PM Tom Tromey wrote: > > Philippe Waroquiers noticed a memory leak in gdb, which he tracked > down to a bug in splay-tree. splay_tree_remove does not call the > `delete_key' function when it removes the old node; but it should. > > I looked at every splay tree in GCC

Re: [PATCH] i386: Move Intel intrinsics head files to

2019-01-21 Thread Richard Biener
On Sun, 20 Jan 2019, Uros Bizjak wrote: > On Sun, Jan 20, 2019 at 4:11 PM H.J. Lu wrote: > > > > On Sun, Jan 20, 2019 at 4:03 AM Uros Bizjak wrote: > > > > > > On 1/19/19, H.J. Lu wrote: > > > > According to Intel Intrinsics Guide: > > > > > > > > https://software.intel.com/sites/landingpage/In