Re: [C++ Patch] PR 84636 ("internal compiler error: Segmentation fault (identifier_p()/grokdeclarator())")

2018-12-01 Thread Jason Merrill
On 11/21/18 7:03 PM, Paolo Carlini wrote: ... in fact I'm thinking that the below - which directly checks for unqualified_id to be non-null in both places - may be a better variant: among other things it means that for related testcases like: typedef void a(); struct A { a a1: 1; }; we get the

Re: RFA/RFC: Add stack recursion limit to libiberty's demangler

2018-12-01 Thread Cary Coutant
> That section is "Writing Robust Programs." Robustness guarantees have > to be different for utilities and servers. A robust server doesn't > crash because of arbitrary user input, but there are servers that > demangle names that are provided by the user. So we need two modes for > the demangle

Re: [C++ PATCH] Fix xvalue COND_EXPR handling (PR c++/88103)

2018-12-01 Thread Jason Merrill
On 11/29/18 4:52 PM, Jakub Jelinek wrote: Hi! On the following testcase, build_conditional_expr_1 tries hard to make sure that if both arguments are xvalue_p (or one is and the other throw) the result is still xvalue_p. But, later on we call unary_complex_lvalue, which does rationalize_conditio

Re: [C++ PATCH] Fix C++ parser endless diagnostics on CPP_PRAGMA_EOL (PR c++/88258)

2018-12-01 Thread Jason Merrill
On 11/30/18 3:54 PM, Jakub Jelinek wrote: Hi! The following testcase endlessly diagnoses a syntax error. The problem is that the various C++ parser routines to skip tokens until something happily skip over CPP_PRAGMA that starts a pragma line, but always stop at CPP_PRAGMA_EOL, but the caller ex

[committed] C++ PATCH to add test for c++/79629

2018-12-01 Thread Marek Polacek
Tested x86_64-linux, applying to trunk. 2018-12-01 Marek Polacek PR c++/79629 * g++.dg/other/error35.C: New test. diff --git gcc/testsuite/g++.dg/other/error35.C gcc/testsuite/g++.dg/other/error35.C new file mode 100644 index 000..e9c8371f18b --- /dev/null +++ gcc/tes

[committed] C++ PATCH to add test for c++/83856

2018-12-01 Thread Marek Polacek
Tested x86_64-linux, applying to trunk. 2018-12-01 Marek Polacek PR c++/83856 * g++.dg/cpp1y/lambda-generic-83856.C: New test. diff --git gcc/testsuite/g++.dg/cpp1y/lambda-generic-83856.C gcc/testsuite/g++.dg/cpp1y/lambda-generic-83856.C new file mode 100644 index 000

[committed] C++ PATCH to add test for c++/87523

2018-12-01 Thread Marek Polacek
Tested x86_64-linux, applying to trunk. 2018-12-01 Marek Polacek PR c++/87523 * g++.dg/cpp1y/lambda-generic-87523.C: New test. diff --git gcc/testsuite/g++.dg/cpp1y/lambda-generic-87523.C gcc/testsuite/g++.dg/cpp1y/lambda-generic-87523.C new file mode 100644 index 000

[PATCH, libphobos] Committed add support for riscv to glibc bindings

2018-12-01 Thread Iain Buclaw
Hi, This patch is backported from druntime master, which adds support for riscv to the core D runtime library. Tested on x86_64-linux-gnu targeting riscv64-linux-gnu, and ran unittests under qemu. Committed to trunk as r266713 -- Iain commit b24441f388f2c75ba56ea2b00056dfd8c12b3456 Author: Iai

[PATCH,Fortran] RFC: Setup locale for Fortran programs

2018-12-01 Thread Janne Blomqvist
This patch initializes the locale system when using a Fortran main program. For non-Fortran main programs that link to libgfortran this is not done, as such programs are expeced to handle locales themselves. Following the approach used by python (https://www.python.org/dev/peps/pep-0538/ ), if the

Re: [doc, rfc] document __builtin_setjmp and __builtin_longjmp

2018-12-01 Thread Sandra Loosemore
On 12/1/18 2:27 AM, Andreas Schwab wrote: On Nov 30 2018, Sandra Loosemore wrote: +@code{__builtin_setjmp} and @code{__builtin_longjmp} use GCC's normal Please avoid starting the sentence with a non-capital. OK, I can fix that easily enough. I was really looking more for comments on focu

[wwwdocs] readings.html -- two broken z/Architecture links

2018-12-01 Thread Gerald Pfeifer
I've been getting "A possible equivalent for dz9zr002 was not found." (or similar) for these two pages for a while. If you have suitable links to cover these, please go ahead and add them; for the time being I committed the patch below. Gerald Index: readings.html ===

Re: [PATCH] v4: C/C++: add fix-it hints for missing '&' and '*' (PR c++/87850)

2018-12-01 Thread Jason Merrill
On 11/30/18 6:48 PM, David Malcolm wrote: On Tue, 2018-11-20 at 22:23 +, Joseph Myers wrote: On Tue, 20 Nov 2018, David Malcolm wrote: Should I do: You should do whatever is appropriate for the warning in question. But if what's appropriate for the warning in question includes types tha

Re: [testsuite] Require ucn support in gdc.test/compilable/ddoc12.d (PR d/88039)

2018-12-01 Thread Iain Buclaw
On Thu, 29 Nov 2018 at 15:12, Rainer Orth wrote: > > Hi Iain, > > > On Tue, 27 Nov 2018 at 20:32, Rainer Orth > > wrote: > >> > >> Hi Mike, > >> > >> > On Nov 27, 2018, at 2:18 AM, Rainer Orth > >> > wrote: > >> >> > >> >> Some assemblers, including the Solaris one, don't support UTF-8 > >> >>

Re: [committed] Trivial testsuite fix to cope with Indu's recent change

2018-12-01 Thread Indu Bhagat
This regression slipped in because my testing was a week old. The predict-22.c is a commit of Nov 28. Thanks Jeff. I saw this regression yesterday and was about to send the patch shortly. I should have kept the patch tested proactively. Thanks Indu On 12/01/2018 08:56 AM, Jeff Law wrote:

[wwwdocs] gcc-4.9/changes.html -- tweak openmp.org link

2018-12-01 Thread Gerald Pfeifer
This one seems to have escaped my http->https changes for openmp.org the last month(s). Committed. Gerald Index: gcc-4.9/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.9/changes.html,v retrieving revision 1.96 diff -u -r1.

Re: [PATCH 2/6] ifcvt: Allow constants operands in noce_convert_multiple_sets.

2018-12-01 Thread Jeff Law
On 11/15/18 4:34 AM, Robin Dapp wrote: >> This may ultimately be too simplistic. There are targets where some >> constants are OK, but others may not be. By checking the predicate >> like this I think you can cause over-aggressive if-conversion if the >> target allows a range of integers in the

[wwwdocs] news/chill.html - tweak a link

2018-12-01 Thread Gerald Pfeifer
www.itu.int has moved to https. Committed. Gerald Index: news/chill.html === RCS file: /cvs/gcc/wwwdocs/htdocs/news/chill.html,v retrieving revision 1.9 diff -u -r1.9 chill.html --- news/chill.html 30 Sep 2018 14:38:54 -

[wwwdocs] Adjust address of Doxygen in codingconventions.html

2018-12-01 Thread Gerald Pfeifer
Committed. Gerald Index: codingconventions.html === RCS file: /cvs/gcc/wwwdocs/htdocs/codingconventions.html,v retrieving revision 1.89 diff -u -r1.89 codingconventions.html --- codingconventions.html 28 Nov 2018 23:39:31 -

[committed] Trivial testsuite fix to cope with Indu's recent change

2018-12-01 Thread Jeff Law
Indu's change to clean up some profiling dumps clearly wasn't regression tested as it fails on every target. We have an edge to a block with a call to an explicitly marked cold function in it. We consider that a precise prediction. Indu's change reflects that information into the dump file, ch

Re: C++ PATCH to implement C++20 P0634R3, Down with typename!

2018-12-01 Thread Marek Polacek
On Sat, Dec 01, 2018 at 10:57:12AM -0500, Jason Merrill wrote: > On 11/30/18 6:08 PM, Marek Polacek wrote: > > + TYPENAME_OPTIONAL_P is true if the typename keyword is optional in this > > + context. */ > ... > > + TYPENAME_OPTIONAL_P is true if the typename keyword is optional in > > + th

Re: C++ PATCH to implement C++20 P0634R3, Down with typename!

2018-12-01 Thread Jason Merrill
On 11/30/18 6:08 PM, Marek Polacek wrote: + TYPENAME_OPTIONAL_P is true if the typename keyword is optional in this + context. */ ... + TYPENAME_OPTIONAL_P is true if the typename keyword is optional in + this context. You have a couple of these left over from the previous patch. OK

Re: [doc, rfc] document __builtin_setjmp and __builtin_longjmp

2018-12-01 Thread Andreas Schwab
On Nov 30 2018, Sandra Loosemore wrote: > +@code{__builtin_setjmp} and @code{__builtin_longjmp} use GCC's normal Please avoid starting the sentence with a non-capital. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "A