Re: Async I/O patch with compilation fix

2018-08-18 Thread Christophe Lyon
On Fri, 17 Aug 2018 at 17:41, Thomas Koenig wrote: > > Hi Christophe, > Hi, > sorry that this took so long, but a holiday followed by a > business trip seven timezones away can do that :-) > Sorry, I am on holidays too, and not back yet :) > > I applied this patch, and again I still see regressi

[PATCH, LTO wrappers] If we're not building a plugin don't try to invoke it.

2018-08-18 Thread Iain Sandoe
Hi, The LTO wrappers are built and installed whether a plug-in is built or not. If one then tries to do --version or --help on those tools, it fails because the plugin is missing. A simple solution is not to try and invoke --plugin when we’re not building it. OK for trunk? Iain gcc/

Re: PR libstdc++/68222 Hide safe iterator operators

2018-08-18 Thread François Dumont
Here is the new proposal. It is indeed possible to keep _Safe_iterator and just add a _Category template parameter to it. I introduce a friend declaration to access container _Base nested typedef from the safe iterator. I review the safe const_iterator constructor from safe iterator. I now c

[PATCH, Darwin] Do not run dsymutil automatically, when -save-temps is on the command line.

2018-08-18 Thread Iain Sandoe
Hi Folks, The point of running dsymutil automatically from collect2 is that it (collect2, lto-wrapper, etc) might be generating or using compiler temporary files that will be deleted at the end of the link process. dsymutil requires that it can see the objects actually used in the link since it a

Fix test 86658 in Debug mode

2018-08-18 Thread François Dumont
This test fails when using 'make check-debug' because it redefines _GLIBCXX_DEBUG. Using dg-options fixes this problem. Committed as trivial. François diff --git a/libstdc++-v3/testsuite/25_algorithms/copy/86658.cc b/libstdc++-v3/testsuite/25_algorithms/copy/86658.cc index 600747a..dd4f7ba 100

[PATCH, driver specs] Put -flto-partition= on the collect2 c/l

2018-08-18 Thread Iain Sandoe
Hi While working on the Darwin LTO issues I noticed that collect2 looks for "-flto-partition=none” in its command line option, but it doesn’t get passed. So - is the attached patch the right idea, or should collect2 be looking in the COLLECT_GCC_OPTIONS as the lto-wrapper does? (or maybe it s

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-18 Thread Martin Sebor
On 08/17/2018 05:01 PM, Bernd Edlinger wrote: On 08/17/18 22:17, Martin Sebor wrote: On 08/17/2018 12:44 PM, Bernd Edlinger wrote: On 08/17/18 20:23, Martin Sebor wrote: On 08/17/2018 06:14 AM, Joseph Myers wrote: On Fri, 17 Aug 2018, Jeff Law wrote: On 08/16/2018 05:01 PM, Joseph Myers wro

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-18 Thread Martin Sebor
On 08/17/2018 09:32 PM, Jeff Law wrote: On 08/17/2018 02:17 PM, Martin Sebor wrote: On 08/17/2018 12:44 PM, Bernd Edlinger wrote: On 08/17/18 20:23, Martin Sebor wrote: On 08/17/2018 06:14 AM, Joseph Myers wrote: On Fri, 17 Aug 2018, Jeff Law wrote: On 08/16/2018 05:01 PM, Joseph Myers wrot

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-18 Thread Bernd Edlinger
On 08/18/18 18:46, Richard Sandiford wrote: > Bernd Edlinger writes: >> On 08/18/18 12:40, Richard Sandiford wrote: >>> Bernd Edlinger writes: Hi everybody, On 08/16/18 08:36, Bernd Edlinger wrote: > Jeff Law wrote: >> I wonder if the change to how we set up the initializer

VEC_DUPLICATE_EXPR options (was Re: [PATCH, RFC, rs6000] enable GIMPLE folding of vec_splat)

2018-08-18 Thread Richard Sandiford
Richard Biener writes: > On Tue, Aug 7, 2018 at 9:25 PM Will Schmidt wrote: >> >> Hi >> Enable GIMPLE folding of the vec_splat() intrinsic. >> >> For review.. feedback is expected. :-) >> >> I came up with the following after spending some time poking around >> at the tree_vec_extract() and vecto

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-18 Thread Richard Sandiford
Bernd Edlinger writes: > On 08/18/18 12:40, Richard Sandiford wrote: >> Bernd Edlinger writes: >>> Hi everybody, >>> >>> On 08/16/18 08:36, Bernd Edlinger wrote: Jeff Law wrote: > I wonder if the change to how we set up the initializers is ultimately > changing the section those go i

Re: [RFC] [PATCH][C][ADA] use function descriptors instead of trampolines in C

2018-08-18 Thread Uecker, Martin
When running the test suite with this patch applied and "-fno-trampolines", there are some errors. Most of it is expected (e.g. nested-6.c calls qsort which fails because it has not itself been compiled with -fno-trampolines). One test case for __builtin_call_with_static_chain in gcc.dg/cwsc1.cfa

Re: [PATCH, X86] Test for MACH-O before HAVE_AS_GOTOFF_IN_DATA

2018-08-18 Thread Richard Biener
On August 18, 2018 2:40:01 PM GMT+02:00, Iain Sandoe wrote: >Hi, > >If we use an assembler which supports HAVE_AS_GOTOFF_IN_DATA, >(e.g. a modern GAS) on Darwin, we produce wrong code because the >gotoff-in-data test is conducted before the mach-o case. > >This should be a no-op on non-Darwin targ

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-18 Thread Bernd Edlinger
On 08/18/18 12:40, Richard Sandiford wrote: > Bernd Edlinger writes: >> Hi everybody, >> >> On 08/16/18 08:36, Bernd Edlinger wrote: >>> Jeff Law wrote: I wonder if the change to how we set up the initializers is ultimately changing the section those go into and ultimately causing an ove

[PATCH, X86] Test for MACH-O before HAVE_AS_GOTOFF_IN_DATA

2018-08-18 Thread Iain Sandoe
Hi, If we use an assembler which supports HAVE_AS_GOTOFF_IN_DATA, (e.g. a modern GAS) on Darwin, we produce wrong code because the gotoff-in-data test is conducted before the mach-o case. This should be a no-op on non-Darwin targets, since the Darwin test is guarded on #ifdef TARGET_MACHO. Boots

Re: patch to bug #86829

2018-08-18 Thread Giuliano Augusto Faulin Belinassi
ping On Sat, Aug 4, 2018 at 10:22 AM, Giuliano Augusto Faulin Belinassi wrote: > Closes bug #86829 > > Description: Adds substitution rules for both sin(atan(x)) and > cos(atan(x)). These formulas are replaced by x / sqrt(x*x + 1) and 1 / > sqrt(x*x + 1) respectively, providing up to 10x speedup.

Re: [PING] [PATCH] Fix wrong code with truncated string literals (PR 86711/86714)

2018-08-18 Thread Bernd Edlinger
nker-plugin -flto-partition=none execution test FAIL: c-c++-common/torture/builtin-arith-overflow-p-17.c -O0 execution test FAIL: c-c++-common/torture/builtin-arith-overflow-p-17.c -O2 execution test FAIL: c-c++-common/torture/builtin-arith-overflow-p-17.c -O2 -flto -fno-use-linker-plugin -

Re: [PATCH] convert braced initializers to strings (PR 71625)

2018-08-18 Thread Richard Sandiford
Bernd Edlinger writes: > Hi everybody, > > On 08/16/18 08:36, Bernd Edlinger wrote: >> Jeff Law wrote: >>> I wonder if the change to how we set up the initializers is ultimately >>> changing the section those go into and ultimately causing an overflow of >>> the .sdata section. >> >> >> Yes, tha

Re: [RFC][PATCH][mid-end] Optimize immediate choice in comparisons.

2018-08-18 Thread Richard Sandiford
Uros Bizjak writes: > Hello! >>> gcc/testsuite/ >>> Changelog for gcc/testsuite/Changelog >>> 2018-08-14 Vlad Lazar >>> >>> * gcc.target/aarch64/imm_choice_comparison.c: New. >>> >>> gcc/ >>> Changelog for gcc/Changelog >>> 2018-08-14 Vlad Lazar >>> * expmed.h (canonicalize_compariso

Re: [PATCH] PR86844: Fix for store merging

2018-08-18 Thread Eric Botcazou
> Eric, didn't your patches explicitely handle this case of a non-constant > inbetween? Only if there is no overlap at all, otherwise you cannot do things simply. > Can you have a look / review here? Jakub is probably more qualified to give a definitive opinion, as he wrote check_no_overlap and

Re: [RFC][PATCH][mid-end] Optimize immediate choice in comparisons.

2018-08-18 Thread Uros Bizjak
Hello! >> gcc/testsuite/ >> Changelog for gcc/testsuite/Changelog >> 2018-08-14 Vlad Lazar >> >> * gcc.target/aarch64/imm_choice_comparison.c: New. >> >> gcc/ >> Changelog for gcc/Changelog >> 2018-08-14 Vlad Lazar >> * expmed.h (canonicalize_comparison): New declaration. >> * ex