Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-29 Thread Bernd Edlinger
On 09/29/16 22:38, Jason Merrill wrote: > On Thu, Sep 29, 2016 at 3:58 PM, Bernd Edlinger > wrote: >> Unfortunately, without that exception there is a false positive: >> >> In file included from ../../gcc-trunk/gcc/ada/gcc-interface/decl.c:30:0: >> ../../gcc-trunk/gcc/ada/gcc-interface/decl.c: In

Fwd: [PATCH] gcc: Fix sysroot relative paths for MinGW

2016-09-29 Thread Tadek Kijkowski
Can I have plain-text mode, please, gmail? -- Forwarded message -- From: Tadek Kijkowski Date: 2016-09-30 5:16 GMT+02:00 Subject: Re: [PATCH] gcc: Fix sysroot relative paths for MinGW To: Jeff Law CC: gcc-patches@gcc.gnu.org 2016-09-29 21:16 GMT+02:00 Jeff Law : > On 09/23/2016

[PATCH] read-md.c: track column numbers

2016-09-29 Thread David Malcolm
This patch adds rudimentary column-number tracking to read-md.c, to give more precise locations for messages for problems in .md files (and in the RTL frontend I'm working on): ../../src/gcc/config/i386/i386.md:1204:22: error: unknown rtx code `define_mood_iterator' ../../src/gcc/config/i386/i386

[committed] testsuite cleanups for nios2-elf

2016-09-29 Thread Sandra Loosemore
I've checked in this patch to clean up some test failures I noticed on nios2-elf. This bare-metal target defaults to -fno-delete-null-pointer-checks at the request of Altera, because address 0 is valid and is typically where the interrupt vector lives. So tests for behavior that depends on -

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Tadek Kijkowski
The fixincl executable uses system function to call applyfix or to direcly patch a header file, with parameters enclosed in single quotes. The problem is that MinGW system function just calls cmd.exe, which doesn't strip quotes from parameters and completely ignores quotes for embedding spaces in p

Re: [PATCH], Backport PR 77670 fix to GCC 6.3

2016-09-29 Thread Segher Boessenkool
On Thu, Sep 29, 2016 at 06:04:47PM -0400, Michael Meissner wrote: > I tried building spec 2006 with the current gcc 6.x branch, and gamess, > soplex, > and povray fail when I use -mcpu=power9 -mpower9-minmax. > > The patch for the trunk applies to the GCC 6.x branch, and I was able to build > all

Re: Implement P0001R1 - C++17 removal of register storage class specifier

2016-09-29 Thread Joseph Myers
This is missing documentation of the new -Wregister option in invoke.texi. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Tadek Kijkowski
Hold on. I have much improved version almost ready. It passes all the tests now. 2016-09-30 0:15 GMT+02:00 Bruce Korb : > I usually try to catch emails with "fixincludes" in the title. > Can I please get a copy of the original patch? Thanks. > > > On 09/29/16 11:44, Jeff Law wrote: >> >> On 09/22

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Bruce Korb
OK, I found it. Looks like my MUA is getting too aggressive with its filtering. What Jeff said, plus I would prefer the tail end looking like: + +#else + +#define system_with_shell system // normal call + +#endif /* defined(__MINGW32__) */ and modifying the call to use "system_with_shell". The p

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Bruce Korb
I usually try to catch emails with "fixincludes" in the title. Can I please get a copy of the original patch? Thanks. On 09/29/16 11:44, Jeff Law wrote: On 09/22/2016 11:26 PM, Tadek Kijkowski wrote: The fixincl executable uses system function to call applyfix or to direcly patch a header file

Re: [PATCH], Backport PR 77670 fix to GCC 6.3

2016-09-29 Thread Michael Meissner
I tried building spec 2006 with the current gcc 6.x branch, and gamess, soplex, and povray fail when I use -mcpu=power9 -mpower9-minmax. The patch for the trunk applies to the GCC 6.x branch, and I was able to build all of Spec 2006 with the patched compiler. I did a bootstrap build and make chec

RE: [PATCH] Fix PR tree-optimization/77654

2016-09-29 Thread Doug Gilmore
> From: Christophe Lyon [christophe.l...@linaro.org] > Sent: Thursday, September 29, 2016 12:17 PM > To: Matthew Fortune > Cc: Doug Gilmore; Richard Biener; gcc-patches@gcc.gnu.org; rgue...@gcc.gnu.org > Subject: Re: [PATCH] Fix PR tree-optimization/77654 > ... > > Since this commit, I've noticed

Re: [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP

2016-09-29 Thread Alan Modra
On Thu, Sep 29, 2016 at 10:55:20AM -0400, David Edelsohn wrote: > Alan, > > This patch broke bootstrap on AIX. sysv4.opt is not included on AIX. > References to sysv4.opt-specific flags have to be protected in > rs6000.c. Sorry. I have reverted the change to rs6000_opt_vars. svn r240639. --

Re: [PATCH 2/2] Extend -falign-FOO=N to N[,M[,N2[,M2]]]

2016-09-29 Thread Denys Vlasenko
On 09/29/2016 07:32 PM, Denys Vlasenko wrote: +#ifdef SUBALIGN_LOG We want to avoid adding new #defines; existing ones are being converted to target hooks. I suspect the best way is to record whether an M value was specified, and override it in the x86 option_override if required. If that's inf

[PATCH, i386]: Check maximum ext_level before calling CPUID with 0x80000008

2016-09-29 Thread Uros Bizjak
Hello! ... otherwise we can call CPUID with out-of range level. Also, simplify xgetbv checks. 2016-09-29 Uros Bizjak * config/i386/driver-i386.c (host_detect_local_cpu): Check maximum ext_level before calling CPUID with 0x8008. Simplify xgetbv checks. Bootstrapped and regres

Re: Implement P0001R1 - C++17 removal of register storage class specifier

2016-09-29 Thread Jason Merrill
OK. On Thu, Sep 29, 2016 at 4:21 PM, Jakub Jelinek wrote: > Hi! > > This patch pedwarns in C++17 on register storage class specifier, unless > it is diagnosed errorneous for other reasons and unless it is used in the > GNU global or local register variable extension. Even in C++17, users can > u

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-29 Thread Jason Merrill
On Thu, Sep 29, 2016 at 3:58 PM, Bernd Edlinger wrote: > Unfortunately, without that exception there is a false positive: > > In file included from ../../gcc-trunk/gcc/ada/gcc-interface/decl.c:30:0: > ../../gcc-trunk/gcc/ada/gcc-interface/decl.c: In function 'int > adjust_packed(tree, tree, int)':

Implement P0001R1 - C++17 removal of register storage class specifier

2016-09-29 Thread Jakub Jelinek
Hi! This patch pedwarns in C++17 on register storage class specifier, unless it is diagnosed errorneous for other reasons and unless it is used in the GNU global or local register variable extension. Even in C++17, users can use -Wno-register to suppress the pedwarn, and for C++98-C++14 users can

[PATCH] Fix -Wimplicit-fallthrough -C, handle some more comment styles and comments in between FALLTHRU comment and label

2016-09-29 Thread Jakub Jelinek
Hi! The following patch does a few things: 1) fixes -Wimplicit-fallthrough -C (with -C the PREV_FALLTHROUGH flag is on the CPP_COMMENT token, we need to propagate it to the C/C++ token's flags in the FEs) 2) it accepts a comment in between /* FALLTHRU */ comment and the case/default keyw

Re: PATCH to add more FALLTHRU markers

2016-09-29 Thread Jakub Jelinek
On Thu, Sep 29, 2016 at 06:21:13PM +0200, Marek Polacek wrote: > On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote: > > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > > > Not sure if I read this code correctly, but if we fall through from > > > V32HImode, and we have

Use version namespace in normal mode

2016-09-29 Thread François Dumont
Hi I think _GLIBCXX_BEGIN_NAMESPACE_ALGO should default to _GLIBCXX_BEGIN_NAMESPACE_VERSION when parallel mode is not active. Same for _GLIBCXX_BEGIN_NAMESPACE_CONTAINER, no ? * include/bits/c++config (_GLIBCXX_BEGIN_NAMESPACE_ALGO) (_GLIBCXX_END_NAMESPACE_ALGO): Default to respec

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-29 Thread Bernd Edlinger
On 09/29/16 20:52, Bernd Edlinger wrote: > On 09/29/16 20:03, Jason Merrill wrote: >> >> What do you think about dropping the TYPE_UNSIGNED exception as well? >> I don't see what difference that makes. >> > > > If I drop that exception, then I could also drop the check for > INTEGER_TYPE and the wh

Re: [PATCH 2/2] [ARC] [libgcc] Fix defines

2016-09-29 Thread Andrew Burgess
* Claudiu Zissulescu [2016-07-08 13:41:23 +0200]: > Don't use CPU macros, use CPU feature macros. > > libgcc/ > 2016-05-26 Claudiu Zissulescu > > * config/arc/lib1funcs.S (__mulsi3): Use feature defines instead > of checking for cpus. > (__umulsidi3, __umulsi3_highpart, __

Re: [PATCH 1/2] [ARC] [libgcc] Add support for QuarkSE processor.

2016-09-29 Thread Andrew Burgess
* Claudiu Zissulescu [2016-07-08 13:41:22 +0200]: > libgcc/ > 2016-05-26 Claudiu Zissulescu > > * config/arc/dp-hack.h (ARC_OPTFPE): Define. > (__ARC_NORM__): Use instead ARC_OPTFPE. > * config/arc/fp-hack.h: Likewise. > * config/arc/lib1funcs.S (ARC_OPTFPE): Define.

Re: [PATCH] Disable compact casesi patterns for arcv2

2016-09-29 Thread Andrew Burgess
* Claudiu Zissulescu [2016-09-29 10:41:02 +0200]: > Here it is. The previous version had more mods which should be in a > different patch. > > Please let me know if you still have issues with it, > Claudiu > > gcc/ > 2016-05-09 Claudiu Zissulescu > > * common/config/arc/arc-common.

Re: [PATCH] gcc: Fix sysroot relative paths for MinGW

2016-09-29 Thread Jeff Law
On 09/23/2016 12:31 AM, Tadek Kijkowski wrote: Prevent paths relative to sysroot directory from being transformed to Windows form with MSYS prefix. See: http://www.mingw.org/wiki/Posix_path_conversion 2016-09-23 Tadek Kijkowski * gcc/Makefile.in: Fix sysroot relative paths for MinGW

Re: [PATCH] Fix PR tree-optimization/77654

2016-09-29 Thread Christophe Lyon
On 23 September 2016 at 17:55, Matthew Fortune wrote: > Doug Gilmore writes: >> > From: Richard Biener [rguent...@suse.de] >> > Sent: Thursday, September 22, 2016 12:43 AM >> > To: Doug Gilmore >> > Cc: gcc-patches@gcc.gnu.org; rgue...@gcc.gnu.org >> > Subject: RE: [PATCH] Fix PR tree-optimizatio

Re: [ARM] Fix new constraints and attributes of SI/HI data movement patterns

2016-09-29 Thread Christophe Lyon
On 29 September 2016 at 14:45, Kyrill Tkachov wrote: > > On 29/09/16 09:45, Matthew Wahab wrote: >> >> The patch at https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01975.html >> added constraints and "arch" attributes to some data movement patterns, >> to fix wrongly generating MOVW instructions whe

[PATCH, i386 testsuite]: Simplify feature bit tests in feature check headers

2016-09-29 Thread Uros Bizjak
Hello! There is no point in writing e.g. "if ((ecx & bit_OSXSAVE) == (bit_OSXSAVE))", for single-bit constants. Simplify this to "if (ecx & bit_OSXSAVE)". 2016-09-29 Uros Bizjak * gcc.target/i386/adx-check.h (main): Simplify feature bit tests. * gcc.target/i386/avx2-check.h (main): Di

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-29 Thread Bernd Edlinger
On 09/29/16 20:03, Jason Merrill wrote: > On Wed, Sep 28, 2016 at 12:09 PM, Bernd Edlinger > wrote: >> On 09/28/16 16:41, Jason Merrill wrote: >>> On Tue, Sep 27, 2016 at 11:10 AM, Bernd Edlinger >>> wrote: On 09/27/16 16:42, Jason Merrill wrote: > On Tue, Sep 27, 2016 at 10:28 AM, Bernd

Re: [PATCH, i386]: Fix PR 77756, _-get_cpuid() returns wrong values for level 7 (extended features)

2016-09-29 Thread Uros Bizjak
On Wed, Sep 28, 2016 at 11:32 PM, Uros Bizjak wrote: > 2016-09-28 Uros Bizjak I have reverted my previous patch and committed the following: 2016-09-29 Uros Bizjak PR target/77756 * config/i386/cpuid.h (__get_cpuid_count): New. (__get_cpuid): Rename __level to __leaf. testsu

Re: [PATCH] fixincludes: fix fixincludes for MinGW

2016-09-29 Thread Jeff Law
On 09/22/2016 11:26 PM, Tadek Kijkowski wrote: The fixincl executable uses system function to call applyfix or to direcly patch a header file, with parameters enclosed in single quotes. This problem is that MinGW system function just calls cmd.exe, which doesn't strip quotes from parameters and c

Re: gcc build problem (i386.c) -- missing declaration

2016-09-29 Thread Louis Krupp
My target was gfortran. In any case, someone else fixed this problem. Louis On Thu, 29 Sep 2016 11:10:15 -0700 Jeff Law wrote > On 09/22/2016 04:52 PM, Louis Krupp wrote: > > As of revision 240383 , i386.c isn't compiling. The errors are: > > > > In file included from ../..

Re: gcc build problem (i386.c) -- missing declaration

2016-09-29 Thread Jeff Law
On 09/22/2016 04:52 PM, Louis Krupp wrote: As of revision 240383 , i386.c isn't compiling. The errors are: In file included from ../../gcc_trunk/gcc/target-def.h:106:0, from ../../gcc_trunk/gcc/config/i386/i386.c:81: ./target-hooks-def.h:92:38: error: ‘hook_uint_uintp_false’ wa

Re: C++ PATCH for c++/68703 (dependent vector length)

2016-09-29 Thread Jason Merrill
On Wed, Sep 28, 2016 at 2:43 PM, David Edelsohn wrote: > Hi, Jason > > This patch added testcases g++.dg/ext/vector32.C and vector32a.C, but > there is no gcc/testsuite/ChangeLog entry. > > The testcases are failing on AIX with a strange ICE: > > src/gcc/testsuite/g++.dg/ext/vector32.C: In functio

Re: [PATCH] Make -Wint-in-bool-context warn on suspicious shift ops

2016-09-29 Thread Jason Merrill
On Wed, Sep 28, 2016 at 12:09 PM, Bernd Edlinger wrote: > On 09/28/16 16:41, Jason Merrill wrote: >> On Tue, Sep 27, 2016 at 11:10 AM, Bernd Edlinger >> wrote: >>> On 09/27/16 16:42, Jason Merrill wrote: On Tue, Sep 27, 2016 at 10:28 AM, Bernd Edlinger wrote: > On 09/27/16 16:10, F

Re: [PATCH] Fix PR55152

2016-09-29 Thread Andrew Pinski
On Thu, Sep 29, 2016 at 8:23 PM, Richard Biener wrote: > On Thu, 29 Sep 2016, Richard Biener wrote: > >> On Wed, 28 Sep 2016, Joseph Myers wrote: >> >> > On Wed, 28 Sep 2016, Richard Biener wrote: >> > >> > > Index: gcc/testsuite/gcc.dg/pr55152.c >> > >

Re: PATCH to fix g++.dg/cpp0x/fallthrough2.C

2016-09-29 Thread Jason Merrill
OK. On Thu, Sep 29, 2016 at 9:26 AM, Marek Polacek wrote: > On Thu, Sep 29, 2016 at 03:20:26PM +0200, Jakub Jelinek wrote: >> Shouldn't that be { target c++14_down } instead? > > Didn't know about that. Thus: > > 2016-09-29 Marek Polacek > > * g++.dg/cpp0x/fallthrough2.C: Use the c++1

Re: [PATCH] Machine-readable RTL dumps: print_rtx_function

2016-09-29 Thread Jeff Law
On 09/29/2016 11:25 AM, Bernd Schmidt wrote: On 09/29/2016 07:47 PM, David Malcolm wrote: This patch adds a new function, print_rtx_function, intended for use for generating function dumps suitable for parsing by the RTL frontend, but also intended to be human-readable, and human-authorable.

Re: [PATCH][RTL ifcvt] Transform (X == CST) ? -CST : Y into (X == CST) ? -X : Y when conditional negation is available

2016-09-29 Thread Jeff Law
On 09/28/2016 10:33 AM, Kyrill Tkachov wrote: FWIW, the simpler form of the transformation is already done just prior to leaving SSA form in tree-ssa-uncprop.c. So there may not be a ton of opportunities for the simpler form in the RTL optimizers. Indeed there weren't that many places, but th

Re: [PATCH 2/2] Extend -falign-FOO=N to N[,M[,N2[,M2]]]

2016-09-29 Thread Denys Vlasenko
On 09/29/2016 04:45 PM, Bernd Schmidt wrote: On 09/28/2016 02:57 PM, Denys Vlasenko wrote: No change from past behavior: Tested that "-falign-functions" uses an arch-dependent alignment. Tested that "-O2" uses an arch-dependent alignment. Tested that "-O2 -falign-functions=N" uses explicitly giv

Re: [PATCH] Machine-readable RTL dumps: print_rtx_function

2016-09-29 Thread Bernd Schmidt
On 09/29/2016 07:47 PM, David Malcolm wrote: This patch adds a new function, print_rtx_function, intended for use for generating function dumps suitable for parsing by the RTL frontend, but also intended to be human-readable, and human-authorable. (note 1 0 4 (nil) NOTE_INSN_DELETED)

Re: [PATCH] print-rtx.c: add 'h', v' and 'p' prefixes to regnos

2016-09-29 Thread Jeff Law
On 09/28/2016 10:49 AM, Bernd Schmidt wrote: On 09/28/2016 06:36 PM, Jeff Law wrote: A "p" prefix for pseudos might still be a good idea, but there's still the issue of a real "p0" register name causing confusion. So how do you think we should deal with distinguishing between the different regi

[PATCH] Machine-readable RTL dumps: print_rtx_function

2016-09-29 Thread David Malcolm
This patch adds a new function, print_rtx_function, intended for use for generating function dumps suitable for parsing by the RTL frontend, but also intended to be human-readable, and human-authorable. I put the function in its own file (rather than print-rtl.c) to avoid having to recompile all t

Re: PATCH to add more FALLTHRU markers

2016-09-29 Thread Marek Polacek
On Tue, Sep 27, 2016 at 07:57:17PM +0100, Richard Sandiford wrote: > Marek Polacek writes: > > Currently Makefile.in contains -Wno-error for several of the insn-* files, > > but > > after further investigation I think with this patch we won't need them > > anymore. > > I'm not removing it until

Re: PATCH to add more FALLTHRU markers

2016-09-29 Thread Marek Polacek
On Tue, Sep 27, 2016 at 09:58:20PM +0200, Jakub Jelinek wrote: > On Tue, Sep 27, 2016 at 09:29:10PM +0200, Florian Weimer wrote: > > Not sure if I read this code correctly, but if we fall through from > > V32HImode, and we have TARGET_SSE2 set, we execute this code: > > > > tmp = "p"; > >

Fix missing -Wimplicit-fallthrough warning

2016-09-29 Thread Marek Polacek
Here, a missing -Wimplicit-fallthrough warning was caused by a misplaced FALLTHROUGH_LABEL_P check. As it is now, for FALLTHROUGH_LABEL_P we'd never gotten around to 1933 /* So that next warn_implicit_fallthrough_r will start looking for 1934a new sequence starting w

Fix missing FALLTHRU comments

2016-09-29 Thread Marek Polacek
My upcoming fix revealed more places that were missing a fall through marker. Bootstrapped/regtested on x86_64-linux, ppc64-linux, and aarch64-linux-gnu with my fix, applying to trunk. 2016-09-29 Marek Polacek * rtti.c (involves_incomplete_p): Add fall through comment. * dwar

Re: [PATCH][v4] GIMPLE store merging pass

2016-09-29 Thread Kyrill Tkachov
On 29/09/16 16:37, Pat Haugen wrote: On 09/28/2016 10:59 AM, Bill Schmidt wrote: Bill, could you or someone else with access to Power benchmarking try this patch out on some benchmarks that you usually use? The new pass in this patch is on by default and can be turned off by -fno-store-mergi

Re: [PATCH][v4] GIMPLE store merging pass

2016-09-29 Thread Pat Haugen
On 09/28/2016 10:59 AM, Bill Schmidt wrote: >> Bill, could you or someone else with access to Power benchmarking try this >> patch out on some benchmarks >> > that you usually use? The new pass in this patch is on by default and can >> > be turned off by -fno-store-merging >> > if needed. Jakub

Re: Fix LTO_STREAMER_DEBUG build

2016-09-29 Thread Richard Biener
On September 29, 2016 4:54:36 PM GMT+02:00, Thomas Schwinge wrote: >Hi! > >While working on something else, I found LTO_STREAMER_DEBUG broken. >Enabling (#define) gcc/lto-stream.h:LTO_STREAMER_DEBUG, some further >checking is done on the LTO streamer (writer/reader), and some >additional >debuggi

Re: [PATCH][v4] GIMPLE store merging pass

2016-09-29 Thread Kyrill Tkachov
Hi Richard, Thanks for the detailed comments, I'll be working on addressing them. Below are answers to some of your questions: On 29/09/16 11:45, Richard Biener wrote: + + /* If we're inserting a non-bytesized width or not at a byte boundary + use an intermediate wide_int to perform the b

Re: [v3 PATCH] Make optional::reset noexcept, make optional::value work in constant expressions.

2016-09-29 Thread Ville Voutilainen
On 29 September 2016 at 17:43, Jonathan Wakely wrote: >> +int main() >> +{ >> + static_assert(test()); >> +} > > > Can this second test use { dg-do compile } instead? Yes it can, and it should (we shouldn't run what we don't need to run, the suite is heavy-weight enough already), well spotted. I

[PATCH v2] add -fprolog-pad=N option to c-family

2016-09-29 Thread Torsten Duwe
In case anybody missed it, the Linux kernel side to make use of this has also been finished meanwhile. Of course it can not be accepted without compiler support; and this feature patch is much more versatile than just Linux kernel live patching on a single architecture. Changes since the previous

Re: [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP

2016-09-29 Thread David Edelsohn
Alan, This patch broke bootstrap on AIX. sysv4.opt is not included on AIX. References to sysv4.opt-specific flags have to be protected in rs6000.c. In file included from /gsa/yktgsa-p4/06/gnu/aix/7.1/power/include/c++/4.8.4/cstddef:42:0, from /gsa/yktgsa/home/e/d/edelsohn/instal

Fix LTO_STREAMER_DEBUG build

2016-09-29 Thread Thomas Schwinge
Hi! While working on something else, I found LTO_STREAMER_DEBUG broken. Enabling (#define) gcc/lto-stream.h:LTO_STREAMER_DEBUG, some further checking is done on the LTO streamer (writer/reader), and some additional debugging hooks are provided. In the end, I didn't use this facility for my debugg

Explicitly list all tree codes in gcc/tree-streamer.c:record_common_node (was: [PR lto/77458] Avoid ICE in offloading with differing _FloatN, _FloatNx types)

2016-09-29 Thread Thomas Schwinge
Hi Richard! On Mon, 19 Sep 2016 13:25:01 +0200, Richard Biener wrote: > On Mon, Sep 19, 2016 at 1:19 PM, Thomas Schwinge > wrote: > > On Mon, 19 Sep 2016 10:18:35 +0200, Richard Biener > > wrote: > >> On Fri, Sep 16, 2016 at 3:32 PM, Thomas Schwinge > >> wrote: > >> > --- gcc/tree-streamer.c

Re: [PATCH 2/2] Extend -falign-FOO=N to N[,M[,N2[,M2]]]

2016-09-29 Thread Bernd Schmidt
On 09/28/2016 02:57 PM, Denys Vlasenko wrote: This change makes it possible to align functions to 64-byte boundaries *if* this does not introduce huge amount of padding. I'm still somewhat undecided, but it seems like a decent enough way to expose these possibilities to the user, so unless so

Re: [v3 PATCH] Make optional::reset noexcept, make optional::value work in constant expressions.

2016-09-29 Thread Jonathan Wakely
On 29/09/16 17:22 +0300, Ville Voutilainen wrote: --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/optional/observers/6.cc @@ -0,0 +1,39 @@ +// { dg-options "-std=gnu++17" } +// { dg-do run } + +// Copyright (C) 2016 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Li

[PATCH, Fortran] PR fortran/77764 - ICE in is_anonymous_component

2016-09-29 Thread Fritz Reese
ICE in [1] is due to failure to null-guard map components in gfc_compare_union_types. Attached is [obvious] fix - will commit soon without complaints. --- Fritz Reese [1] https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77764 2016-09-29 Fritz Reese Fix ICE for maps with zero components.

[v3 PATCH] Make optional::reset noexcept, make optional::value work in constant expressions.

2016-09-29 Thread Ville Voutilainen
These tidbits were reported by Eric Fiselier. They are fairly simple conformance issues. Tested on Linux-x64. 2016-09-29 Ville Voutilainen Make optional::reset noexcept, make optional::value work in constant expressions. * include/std/optional (_M_get): Make constexpr. (reset)

[PATCH, Fortran] PR fortran/77782 - ICE in gfc_get_union_type

2016-09-29 Thread Fritz Reese
ICE in [1] is due to an incomplete fix for PR fortran/77327 (r239819, see [2],[3]). Specifically in interface.c (gfc_compare_derived_types) I overlooked the case where FL_UNION type symbols could be compared as equal to FL_STRUCTURE type symbols, which is _never_ correct. The faulty logic causes a

Re: [PATCH, RFC] gcov: dump in a static dtor instead of in an atexit handler

2016-09-29 Thread Martin Liška
On 09/29/2016 03:00 PM, Nathan Sidwell wrote: > On 09/29/16 08:54, Nathan Sidwell wrote: >> On 09/29/16 08:49, Martin Liška wrote: >>> Ideally we should have a macro for each target telling whether it supports >>> priorities or not. >>> However, we probably don't have? I would suggest to make the t

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 14:37 +0100, Andre Vieira (lists) wrote: Hi Jonathan, On 27/09/16 16:11, Jonathan Wakely wrote: The test might not be very good, but tests some small integer values and some other values where accuracy is lost for one or other of the alternative implementations mentioned above. If

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Andre Vieira (lists)
Hi Jonathan, On 27/09/16 16:11, Jonathan Wakely wrote: > > The test might not be very good, but tests some small integer values > and some other values where accuracy is lost for one or other of the > alternative implementations mentioned above. If this FAILs for some > 32-bit targets we might ne

Re: PATCH to fix g++.dg/cpp0x/fallthrough2.C

2016-09-29 Thread Marek Polacek
On Thu, Sep 29, 2016 at 03:20:26PM +0200, Jakub Jelinek wrote: > Shouldn't that be { target c++14_down } instead? Didn't know about that. Thus: 2016-09-29 Marek Polacek * g++.dg/cpp0x/fallthrough2.C: Use the c++14_down target. diff --git gcc/testsuite/g++.dg/cpp0x/fallthrough2.C gc

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 13:12 +0100, Jonathan Wakely wrote: On 29/09/16 14:02 +0200, Rainer Orth wrote: Hi Jonathan, If only there was some way the Solaris team could contact us so we could coordinate and stop adding more and more hacks to mess with each others headers. But I assume they don't have access

Re: PATCH to fix g++.dg/cpp0x/fallthrough2.C

2016-09-29 Thread Jakub Jelinek
On Thu, Sep 29, 2016 at 03:13:57PM +0200, Marek Polacek wrote: > This test failed with make check-c++1z because in C++1z we don't get the > expected message. > > Bootstrapped/regtested on x86_64-linux, applying to trunk. > > 2016-09-29 Marek Polacek > > * g++.dg/cpp0x/fallthrough2.C: On

Re: [PR lto/77458] Avoid ICE in offloading with differing _FloatN, _FloatNx types

2016-09-29 Thread Thomas Schwinge
Hi Richard! On Mon, 19 Sep 2016 13:25:01 +0200, Richard Biener wrote: > On Mon, Sep 19, 2016 at 1:19 PM, Thomas Schwinge > wrote: > > On Mon, 19 Sep 2016 10:18:35 +0200, Richard Biener > > wrote: > >> On Fri, Sep 16, 2016 at 3:32 PM, Thomas Schwinge > >> wrote: > >> > --- gcc/tree-streamer.c

Re: [PATCH] DWARF: remove pessimistic DWARF version checks for imported entities

2016-09-29 Thread Dominique d'Humières
I have bootstrapped revision r240599 with the patch https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01315.html without any problem. However compiling the following Fortran tests FAIL: gfortran.dg/binding_label_tests_16.f03 -g (internal compiler error) FAIL: gfortran.dg/module_commons_3.f90

PATCH to fix g++.dg/cpp0x/fallthrough2.C

2016-09-29 Thread Marek Polacek
This test failed with make check-c++1z because in C++1z we don't get the expected message. Bootstrapped/regtested on x86_64-linux, applying to trunk. 2016-09-29 Marek Polacek * g++.dg/cpp0x/fallthrough2.C: Only expect the warning in C++11 and C++14. diff --git gcc/testsuite/g

Re: [PATCH, RFC] gcov: dump in a static dtor instead of in an atexit handler

2016-09-29 Thread Nathan Sidwell
On 09/29/16 08:54, Nathan Sidwell wrote: On 09/29/16 08:49, Martin Liška wrote: Ideally we should have a macro for each target telling whether it supports priorities or not. However, we probably don't have? I would suggest to make the test conditional just for main targets which support prioriti

Re: [PATCH, RFC] gcov: dump in a static dtor instead of in an atexit handler

2016-09-29 Thread Nathan Sidwell
On 09/29/16 08:49, Martin Liška wrote: Ideally we should have a macro for each target telling whether it supports priorities or not. However, we probably don't have? I would suggest to make the test conditional just for main targets which support priorities? or a dg_effective_target test. Pr

Re: [PATCH] print-rtx.c: add 'h', v' and 'p' prefixes to regnos

2016-09-29 Thread David Malcolm
On Wed, 2016-09-28 at 18:49 +0200, Bernd Schmidt wrote: > On 09/28/2016 06:36 PM, Jeff Law wrote: > > > A "p" prefix for pseudos might still be a good idea, but there's > > > still > > > the issue of a real "p0" register name causing confusion. > > So how do you think we should deal with distinguis

Re: [PATCH, RFC] gcov: dump in a static dtor instead of in an atexit handler

2016-09-29 Thread Martin Liška
On 09/29/2016 11:00 AM, Rainer Orth wrote: > Hi Martin, > >> On 08/12/2016 04:08 PM, Martin Liška wrote: >>> On 08/10/2016 02:53 PM, Nathan Sidwell wrote: On 08/10/16 06:43, Martin Liška wrote: > Hello. > > There are multiple PRs (mentioned in ChangeLog) which suffer from > mi

Re: [ARM] Fix new constraints and attributes of SI/HI data movement patterns

2016-09-29 Thread Kyrill Tkachov
On 29/09/16 09:45, Matthew Wahab wrote: The patch at https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01975.html added constraints and "arch" attributes to some data movement patterns, to fix wrongly generating MOVW instructions when not supported by the targets. This was needed to fix a broken bui

[PATCH][3/2] Fix PR77768

2016-09-29 Thread Richard Biener
Another one - this time with the testcase from the other PR. Bootstrapped / tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-09-29 Richard Biener PR tree-optimization/77768 * tree-ssa-pre.c (eliminate_dom_walker::before_dom_children): Handle stores to reado

Re: [PATCH] Fix PR55152

2016-09-29 Thread Richard Biener
On Thu, 29 Sep 2016, Richard Biener wrote: > On Wed, 28 Sep 2016, Joseph Myers wrote: > > > On Wed, 28 Sep 2016, Richard Biener wrote: > > > > > Index: gcc/testsuite/gcc.dg/pr55152.c > > > === > > > --- gcc/testsuite/gcc.dg/pr55152.

Re: [PATCH v3] Optimize strchr to strlen

2016-09-29 Thread Oleg Endo
On Fri, 2016-09-23 at 23:10 +0900, Oleg Endo wrote: > On Fri, 2016-09-23 at 14:07 +, Wilco Dijkstra wrote: > > > > After discussion (https://gcc.gnu.org/ml/gcc-patches/2016-09/msg007 > > 18 > > .html) > > here is the latest version of the strchr patch.  This uses a gimple > > statement for > >

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 14:02 +0200, Rainer Orth wrote: Hi Jonathan, If only there was some way the Solaris team could contact us so we could coordinate and stop adding more and more hacks to mess with each others headers. But I assume they don't have access to the www or email, because the only other expl

[accaf, Fortran, patch, v1] Generate caf-reference chains only from the first coarray reference on, and more.

2016-09-29 Thread Andre Vehreschild
Hi all, attached patch fixes an addressing issue for coarrays *in* derived types. Before the patch the caf runtime reference chain was generated from the start of the symbol to the last reference *and* the reference chain upto the coarray in the derived type was used to call the caf_*_by_ref () fu

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Rainer Orth
Hi Jonathan, >>If only there was some way the Solaris team could contact us so we >>could coordinate and stop adding more and more hacks to mess with each >>others headers. But I assume they don't have access to the www or >>email, because the only other explanation is too rude to say on a >>publi

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 11:47 +0100, Jonathan Wakely wrote: On 29/09/16 12:39 +0200, Rainer Orth wrote: Hi Jonathan, That would suggest Solaris uses include/c_std/cmath (where I forgot to add the new overloads) rather than include/c_global/cmath ... is that right? Alternatively it's using c_global/cmath

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Rainer Orth
Hi Jonathan, >>It turns out the #undef's are from : >> >>#if __cplusplus >= 201103L >>#undef _GLIBCXX_USE_C99_MATH >>#undef _GLIBCXX_USE_C99_MATH_TR1 >>#endif >> >>No idea what this nonsense is trying to accomplish! It's already in >>Solaris 11.3, however. > > Wow. > > If only there was some wa

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 12:39 +0200, Rainer Orth wrote: Hi Jonathan, That would suggest Solaris uses include/c_std/cmath (where I forgot to add the new overloads) rather than include/c_global/cmath ... is that right? Alternatively it's using c_global/cmath but _GLIBCXX_USE_C99_MATH_TR1 is not defined, as

Re: [PATCH][v4] GIMPLE store merging pass

2016-09-29 Thread Richard Biener
On Wed, 28 Sep 2016, Kyrill Tkachov wrote: > Hi all, > > This is v4 of the pass. It addresses feedback by Bernhard, including typo > fixes and > skipping of debug statements. > Also, I've extended it to handle the case from PR 23684 and included that > testcase > in the patch. Merging now trigge

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Rainer Orth
Hi Jonathan, >>That would suggest Solaris uses include/c_std/cmath (where I forgot to >>add the new overloads) rather than include/c_global/cmath ... is that >>right? > > Alternatively it's using c_global/cmath but _GLIBCXX_USE_C99_MATH_TR1 > is not defined, as the new overloads are inside that bl

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Rainer Orth
Hi Jonathan, > That would suggest Solaris uses include/c_std/cmath (where I forgot to > add the new overloads) rather than include/c_global/cmath ... is that > right? no, include/cmath points to the c_global version. Rainer -- ---

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 10:10 +0100, Jonathan Wakely wrote: On 29/09/16 10:54 +0200, Rainer Orth wrote: Hi Jonathan, This adds the new 3D std::hypot() functions. This implementation seems to be faster than the naïve sqrt(x*x + y*y + z*z) implementation, or hypot(hypot(x, y), z), and should be a bit more a

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Jonathan Wakely
On 29/09/16 10:54 +0200, Rainer Orth wrote: Hi Jonathan, This adds the new 3D std::hypot() functions. This implementation seems to be faster than the naïve sqrt(x*x + y*y + z*z) implementation, or hypot(hypot(x, y), z), and should be a bit more accurate at very large or very small values due to

Re: [PATCH, RFC] gcov: dump in a static dtor instead of in an atexit handler

2016-09-29 Thread Rainer Orth
Hi Martin, > On 08/12/2016 04:08 PM, Martin Liška wrote: >> On 08/10/2016 02:53 PM, Nathan Sidwell wrote: >>> On 08/10/16 06:43, Martin Liška wrote: Hello. There are multiple PRs (mentioned in ChangeLog) which suffer from missing capability of gcov to save counters for fun

Re: [PATCH] Define 3-argument overloads of std::hypot for C++17 (P0030R1)

2016-09-29 Thread Rainer Orth
Hi Jonathan, > This adds the new 3D std::hypot() functions. This implementation seems > to be faster than the naïve sqrt(x*x + y*y + z*z) implementation, or > hypot(hypot(x, y), z), and should be a bit more accurate at very large > or very small values due to reducing the arguments by the largest

[PATCH] Disable compact casesi patterns for arcv2

2016-09-29 Thread Claudiu Zissulescu
Here it is. The previous version had more mods which should be in a different patch. Please let me know if you still have issues with it, Claudiu gcc/ 2016-05-09 Claudiu Zissulescu * common/config/arc/arc-common.c (arc_option_optimization_table): Remove compact casesi option

[ARM] Fix new constraints and attributes of SI/HI data movement patterns

2016-09-29 Thread Matthew Wahab
The patch at https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01975.html added constraints and "arch" attributes to some data movement patterns, to fix wrongly generating MOVW instructions when not supported by the targets. This was needed to fix a broken build but also resulted in MOVW instructions

Re: [PATCH v3] Optimize strchr to strlen

2016-09-29 Thread Richard Biener
On Wed, Sep 28, 2016 at 5:45 PM, Jason Merrill wrote: > OK. > > On Wed, Sep 28, 2016 at 11:43 AM, Wilco Dijkstra > wrote: >> Jason Merrill wrote: >>> I think this broke g++.dg/ext/builtin10.C. >> >> That's odd. It appears if you add a fold in gimple-fold.c, it no longer >> calls the >> folding

Re: [PATCH PR77718]

2016-09-29 Thread Richard Biener
On Wed, Sep 28, 2016 at 5:51 PM, Aaron Sawdey wrote: > This patch that Bernd put in PR77718 seems to be fine. Bootstrap and > regtest done on powerpc64le, no new failures. Ok for trunk? Ok. Richard. > 2016-09-28 Bernd Schmidt > > * builtins.c (expand_builtin_memcmp): don't swap args

Re: [PATCH] Detect whether target can use -fprofile-update=atomic

2016-09-29 Thread Rainer Orth
Hi Martin, > 2016-09-06 Martin Liska > > * gcc.dg/profile-update-warning.c: New test. [...] > diff --git a/gcc/testsuite/gcc.dg/profile-update-warning.c > b/gcc/testsuite/gcc.dg/profile-update-warning.c > new file mode 100644 > index 000..0614fad > --- /dev/null > +++ b/gcc/testsuite

Re: [PATCH 2/2] Extend -falign-FOO=N to N[,M[,N2[,M2]]]

2016-09-29 Thread Florian Weimer
* Denys Vlasenko: > Example syntax is -falign-functions=64,9: "align to 64 by skipping up to > 9 bytes (not inclusive)". IOW: "after a call insn, CPU will always be able > to fetch at least 9 bytes of insns". Is it possible to set this using the optimize function attribute? For example, we could

Re: [PATCH][v4] GIMPLE store merging pass

2016-09-29 Thread Kyrill Tkachov
On 29/09/16 08:36, Richard Biener wrote: On Wed, 28 Sep 2016, Pat Haugen wrote: On 09/28/2016 10:54 AM, Kyrill Tkachov wrote: +fstore-merging +Common Var(flag_store_merging) Optimization +Use the tree store merging pass. + Did you purposely leave off "Report" for this option? I noticed the o

Re: [PATCH][v4] GIMPLE store merging pass

2016-09-29 Thread Richard Biener
On Wed, 28 Sep 2016, Pat Haugen wrote: > On 09/28/2016 10:54 AM, Kyrill Tkachov wrote: > > +fstore-merging > > +Common Var(flag_store_merging) Optimization > > +Use the tree store merging pass. > > + > > Did you purposely leave off "Report" for this option? I noticed the option > didn't show up

  1   2   >