Re: [PATCH, rs6000] Fix PR target/71733, ICE with -mcpu=power9 -mno-vsx

2016-07-10 Thread Alan Modra
On Sat, Jul 09, 2016 at 10:26:55AM -0500, Peter Bergner wrote: > The problem occurs when we have an altivec store, which is what the original > test case had: > > bergner@genoa:~/gcc/BUGS/sawdey/altivec$ cat vec_store.i > typedef __attribute__((altivec(vector__))) __attribute__((aligned(16))) > u

Re: [PATCH] Giant concepts patch

2016-07-10 Thread Andrew Sutton
Ah sure. Jason has been vetting my post-Jacksonville concepts patch in the branch jason/concepts-rewrite. I just pulled this off the github GCC mirror this morning to look at an outstanding question. Resulted in the previous 2 patches. I tried building a fresh pull of your cmcstl2 and got an off-b

Re: RFA: new pass to warn on questionable uses of alloca() and VLAs

2016-07-10 Thread Manuel López-Ibáñez
+Walloca +LangEnabledBy(C ObjC C++ ObjC++) +; in common.opt + +Walloca= +LangEnabledBy(C ObjC C++ ObjC++) +; in common.opt + I'm not sure what you think the above means, but this is an invalid use of LangEnabledBy(). (It would be nice if the .awk scripts were able to catch it and give an error

Re: Importing gnulib into the gcc tree

2016-07-10 Thread David Malcolm
On Sun, 2016-07-10 at 22:13 +0100, Manuel López-Ibáñez wrote: > On 10 July 2016 at 17:04, Manuel López-Ibáñez > wrote: > > Hi Ayush, > > > > Some suggestions: > > Also, it may be a good idea to configure with: > > --enable-languages=c,ada,c++,java,go,fortran,objc,obj-c++ --enable > -multilib >

Re: RFA: new pass to warn on questionable uses of alloca() and VLAs

2016-07-10 Thread Martin Sebor
On 07/08/2016 05:48 AM, Aldy Hernandez wrote: [New thread now that I actually have a tested patch :)]. ... I have overhauled the options and added extensive documentation to invoke.texi explaining them. See the included testcases. I have tried to add a testcase for everything the pass current

Re: Importing gnulib into the gcc tree

2016-07-10 Thread Manuel López-Ibáñez
On 10 July 2016 at 17:04, Manuel López-Ibáñez wrote: > Hi Ayush, > > Some suggestions: Also, it may be a good idea to configure with: --enable-languages=c,ada,c++,java,go,fortran,objc,obj-c++ --enable-multilib so that you get as much coverage as possible. Cheers, Manuel.

Re: [v3 PATCH] Implement std::optional.

2016-07-10 Thread Ville Voutilainen
On 10 July 2016 at 20:15, Jonathan Wakely wrote: > All the references to [X.Y.4] could refer to something sensible now, > as we know where it landed in the CD. Using stable names might be > better than instable clause numbers though. Every time I find a 20.a.b > refernce in our headers it's wrong

Re: [PATCH] Add code-hoisting to GIMPLE

2016-07-10 Thread Andrew Pinski
On Fri, Jul 8, 2016 at 12:16 AM, Richard Biener wrote: > > This is a final candidate patch to add code-hoisting to GIMPLE. > > I've already committed several patches fixing fallout and the following > one adds -fno-code-hoisting (I renamed the option) to a few testcases. > I filed PRs for the case

Re: [v3 PATCH] Implement std::optional.

2016-07-10 Thread Jonathan Wakely
On 07/07/16 13:00 +0300, Ville Voutilainen wrote: Implement std::optional. * include/Makefile.am: Add optional to exported headers. * include/Makefile.in: Likewise. * include/std/optional: New. All the references to [X.Y.4] could refer to something sensible now, as we know where it

Re: Importing gnulib into the gcc tree

2016-07-10 Thread Manuel López-Ibáñez
Hi Ayush, Some suggestions: * When resubmitting a patch, also add again the Changelog. * Use '.diff' or '.patch' as an extension, so that mail readers can open the file as text. * Mention that you have a copyright assignment in place already (I'm assuming you have one already, no?). * Mention how

Re: [RFC] Convert TYPE_ALIGN_OK into an TYPE_LANG_FLAG

2016-07-10 Thread Bernd Edlinger
On 07/10/16 10:23, Eric Botcazou wrote: >> I expect it still has an effect due to the same reason as the >> DECL_OFFSET_ALIGN thing - memory reference expansion doesn't gather >> information from the full reference but tries to re-cover it from >> the pieces returned from get_inner_reference. So I

Re: [PATCH] Giant concepts patch

2016-07-10 Thread Andrew Sutton
I just tried building a fresh pull of cmcstl2, and I'm not seeing any errors as a result of not handling those missing codes in tsubst_constraint. At one point, I think it was not possible to get those other constraints in this context because they were nested in a parm_constr. But that seems obvio

Re: Improve insert/emplace robustness to self insertion

2016-07-10 Thread Jonathan Wakely
On 09/07/16 20:29 -0400, David Edelsohn wrote: On Sat, Jul 9, 2016 at 7:59 PM, Jonathan Wakely wrote: On 09/07/16 13:47 -0400, David Edelsohn wrote: This patch has caused some new libstdc++ testsuite failures on AIX. Which patch? My last patch only added a new test, that can't have caused

Re: [RFC] Convert TYPE_ALIGN_OK into an TYPE_LANG_FLAG

2016-07-10 Thread Eric Botcazou
> I expect it still has an effect due to the same reason as the > DECL_OFFSET_ALIGN thing - memory reference expansion doesn't gather > information from the full reference but tries to re-cover it from > the pieces returned from get_inner_reference. So I guess we need > to fix that first. The sit

Re: [PATCH] Allow fwprop to undo vectorization harm (PR68961)

2016-07-10 Thread Uros Bizjak
On Wed, Jul 6, 2016 at 3:18 PM, Richard Biener wrote: >> > 2016-07-04 Richard Biener >> > >> > PR rtl-optimization/68961 >> > * fwprop.c (propagate_rtx): Allow SUBREGs of VEC_CONCAT and CONCAT >> > to simplify to a non-constant. >> > >> > * gcc.target/i386/pr68961.c: New testca

Re: [PATCH 2/2] Optimize fortran loops with +-1 step.

2016-07-10 Thread Andreas Schwab
marxin writes: > diff --git a/gcc/testsuite/gfortran.dg/ldist-1.f90 > b/gcc/testsuite/gfortran.dg/ldist-1.f90 > index ea3990d..2030328 100644 > --- a/gcc/testsuite/gfortran.dg/ldist-1.f90 > +++ b/gcc/testsuite/gfortran.dg/ldist-1.f90 > @@ -32,4 +32,4 @@ end Subroutine PADEC > ! There are 5 lega