Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu

2016-01-06 Thread Thomas Preud'homme
On Tuesday, January 05, 2016 10:47:38 AM Kyrill Tkachov wrote: > Hi Thomas, Hi Kyrill, > > > > diff --git a/gcc/testsuite/g++.dg/pr67989.C > > b/gcc/testsuite/g++.dg/pr67989.C index > > 90261c450b4b9429fb989f7df62f3743017c7363..61be8e172a96df5bb76f7ecd8543dadf > > 825e7dc7 100644 > > --- a/gcc/t

RE: Fix 61441 [5/5] Disable various transformations for signaling NaN operands

2016-01-06 Thread Saraswati, Sujoy (OSTL)
Hi, > On Thu, Nov 26, 2015 at 08:38:55AM +, Saraswati, Sujoy (OSTL) wrote: > > PR tree-optimization/61441 > > * gcc.dg/pr61441.c: New testcase. > > Note the testcase fails on i686-linux, and even -fexcess-precision=standard > doesn't help (-ffloat-store works, but that

[patch, nvptx] document "kernel" function attribute

2016-01-06 Thread Sandra Loosemore
I've been trying to fill in missing documentation for target-specific attributes. I'm not 100% sure I've got this one correct. OK to commit? -Sandra 2016-01-06 Sandra Loosemore PR 1078 gcc/ * doc/extend.texi (Nvidia PDX Function Attributes): New section. Index: gcc/doc/extend.texi =

[gomp4] private reductions

2016-01-06 Thread Cesar Philippidis
This patch updates the way that private reductions are handled in gomp4 to be more like trunk. Before, omp lower was using a complicated mapping for private variables, but now it's treating them more like omp, with the exception of reference-type variables. This complication originated back when we

Re: [PATCH, rs6000] Handle vector reductions in swap optimization

2016-01-06 Thread David Edelsohn
On Wed, Jan 6, 2016 at 5:37 PM, Bill Schmidt wrote: > Hi, > > Swap optimization is missing some opportunities when vector reductions > are present. This patch adds logic to recognize vector-reduction > patterns and mark them as swappable. Some of these are very easy to > recognize, given the pre

Re: [gomp4] kernels offload fns

2016-01-06 Thread Cesar Philippidis
On 12/29/2015 06:19 AM, Nathan Sidwell wrote: > @@ -19385,7 +19415,7 @@ new_oacc_loop_routine (oacc_loop *parent > { >oacc_loop *loop = new_oacc_loop_raw (parent, gimple_location (call)); >int dims[GOMP_DIM_MAX]; > - int level = oacc_validate_dims (decl, attrs, dims); > + int level = oa

Re: [PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed

2016-01-06 Thread Mike Stump
On Jan 6, 2016, at 3:38 PM, Martin Sebor wrote: >>> gcc/testsuite/ChangeLog: >>> 2016-01-04 Martin Sebor >>> >>> PR c/68966 >>> * gcc.dg/atomic-fetch-bool.c: New test. >>> * gcc.dg/sync-fetch-bool.c: Same. >> >> So the tradition is to repeat "New test." rather than to say "Same."

Re: [CilkPlus] fix issues when cilk_spawn is used with nontrivial expressions

2016-01-06 Thread Mike Stump
On Jan 6, 2016, at 12:11 PM, Ryan Burn wrote: > I could additionally check that the language is c++ before checking > those flags, Please, no. Objective-C++ isn’t C++ and the string that names the language won’t strcmp with the name of the C++ language.

Re: [PATCH] Fix PR66848 by enforcing 16-bit alignment on darwin

2016-01-06 Thread Jack Howarth
Hans, You can find some complete walks in lldb for the failing boehm-gc test cases on darwin15 attached to https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66848 as well as stand-alone binaries for reproducing their failure on x86_64-apple-darwin15 (should you have access to a Mac running El Capi

Re: [PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed

2016-01-06 Thread Martin Sebor
gcc/testsuite/ChangeLog: 2016-01-04 Martin Sebor PR c/68966 * gcc.dg/atomic-fetch-bool.c: New test. * gcc.dg/sync-fetch-bool.c: Same. So the tradition is to repeat "New test." rather than to say "Same." Can we try not to make the rules any more rigid than they need

[testsuite] Skip gcc.target/sparc/20151219-1.c in 64-bit mode

2016-01-06 Thread Eric Botcazou
The test doesn't really make sense in 64-bit mode. Applied on the mainline. 2016-01-06 Eric Botcazou * gcc.target/sparc/20151219-1.c: Skip in 64-bit mode. -- Eric BotcazouIndex: gcc.target/sparc/20151219-1.c === --- gc

Re: [PATCH, i386]: Fix PR69140, stack alignment + O1 breaks with Microsoft ABI

2016-01-06 Thread Eric Botcazou
> Patch was bootstrapped and regression tested on x86_64-linux-gnu for > all default languages, Obj-C++ and Go. The patch was also tested by > the reporter by building and running Wine without problems. > > I have to admit that prologue generation is hard to test, since it has > many different cod

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

2016-01-06 Thread Jonathan Wakely
On 06/01/16 12:45 -0800, Steve Ellcey wrote: On Wed, 2016-01-06 at 20:34 +, Jonathan Wakely wrote: On 05/01/16 14:43 -0800, Steve Ellcey wrote: >While trying to build GCC with uclibc instead of glibc I ran into a build >failure in libstdc++. uclibc doesn't seem to provide the isfinite func

Re: [PATCH], PowerPC IEEE 128-bit fp, #11-rev2 (enable libgcc conversions)

2016-01-06 Thread Michael Meissner
I have reworked the libgcc library interface that was in my original patch #11. There are 2 attachments, the first attachment is for patches in the gcc space, and the second attachment is for the libgcc changes. I added the conversions between IBM extended double and IEEE 128-bit floating point t

[PATCH, rs6000] Handle vector reductions in swap optimization

2016-01-06 Thread Bill Schmidt
Hi, Swap optimization is missing some opportunities when vector reductions are present. This patch adds logic to recognize vector-reduction patterns and mark them as swappable. Some of these are very easy to recognize, given the presence of a specific unspec. For V2DF reductions, we have to rec

RE: [PATCH][MIPS] Reorder function types

2016-01-06 Thread Robert Suchanek
Hi Catherine, > > > > Robert Suchanek writes: > > > gcc/ > > > * config/mips/mips-ftypes.def: Sort to lexicographical order. > > > > The patch is fine. I don't know what we can/should commit at this stage. > > Catherine: Any idea what is acceptable? I'd think this kind of small change > > to

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

2016-01-06 Thread Steve Ellcey
On Wed, 2016-01-06 at 20:34 +, Jonathan Wakely wrote: > On 05/01/16 14:43 -0800, Steve Ellcey wrote: > >While trying to build GCC with uclibc instead of glibc I ran into a build > >failure in libstdc++. uclibc doesn't seem to provide the isfinite function > >like glibc does so that means that

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-06 Thread Evandro Menezes
Hi, Wilco. On 01/06/2016 06:04 AM, Wilco Dijkstra wrote: Here's what I had in mind when I inquired about distinguishing FCMP from FCCMP. As you can see in the patch, Exynos is the only target that cares about it, but I wonder if ThunderX or Xgene would too. What do you think? The new attribut

[patch] libstdc++/69092 Remove noexcept from function template that can throw

2016-01-06 Thread Jonathan Wakely
The _S_copy_chars template can't assume that the iterators don't throw, so shouldn't be noexcept. Tested powerpc64le-linux, committed to trunk. This is a regression from 4.8 so I'll commit to the branches too. commit ea6e9cb5377b93b11c9923bc7eee1e4f7d547eeb Author: Jonathan Wakely Date: Wed

Re: [Patch] Fix libstdc++ build when using uclibc instead of glibc

2016-01-06 Thread Jonathan Wakely
On 05/01/16 14:43 -0800, Steve Ellcey wrote: While trying to build GCC with uclibc instead of glibc I ran into a build failure in libstdc++. uclibc doesn't seem to provide the isfinite function like glibc does so that means that libstdc++ doesn't have std::isfinite. This in turn caused include

[PATCH, i386]: Fix PR69140, stack alignment + O1 breaks with Microsoft ABI

2016-01-06 Thread Uros Bizjak
Hello! Attached patch fixes a failure, where no base register can be found to save the remaining SSE (and integer) registers to stack. Since we are able to restore registers in the prollogue using: m->fs.sp_valid = (!frame_pointer_needed || (crtl->sp_is_unchanging && !stack_realign_fp)); we

Re: [CilkPlus] fix issues when cilk_spawn is used with nontrivial expressions

2016-01-06 Thread Ryan Burn
On Tue, Jan 5, 2016 at 2:35 PM, Jeff Law wrote: > On 12/25/2015 09:08 AM, Ryan Burn wrote: >> >> This patch fixes issues with cilk_spawn where bad diagnostics are >> emitted for expressions invoking conversion operators or constructor >> calls (PR69024, PR68997). >> >> It also fixes an issue with

Re: [PATCH 2/2] PR c++/68819: libcpp fallbacks and -Wmisleading-indentation

2016-01-06 Thread David Malcolm
On Mon, 2015-12-21 at 22:20 +0100, Jakub Jelinek wrote: > On Mon, Dec 21, 2015 at 02:10:17PM -0700, Jeff Law wrote: > > On 12/18/2015 01:21 PM, David Malcolm wrote: > > > > >I don't think there's a way to fix -Wmisleading-indentation if we're > > >in this state, so the first part of the following

Re: [PATCH 2/2] PR c++/68819: libcpp fallbacks and -Wmisleading-indentation

2016-01-06 Thread David Malcolm
On Mon, 2015-12-21 at 14:10 -0700, Jeff Law wrote: > On 12/18/2015 01:21 PM, David Malcolm wrote: > > > I don't think there's a way to fix -Wmisleading-indentation if we're > > in this state, so the first part of the following patch detects if > > this has happened, and effectively turns off -Wmis

[ping] pending patches

2016-01-06 Thread David Malcolm
PR c++/68795: fix uninitialized close_paren_loc in cp_parser_postfix_expression (v2): https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01915.html [PATCH 1/4] PR c++/62314: add fixit hint for missing "template <> " in explicit specialization: https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01933.ht

Re: [openacc] fix unoptimized acc_on_device

2016-01-06 Thread Jakub Jelinek
On Wed, Jan 06, 2016 at 10:48:52AM -0500, Nathan Sidwell wrote: > I've committed this to trunk. C++ needs a wrapper function to deal with the > enumerated type argument. Usually that's inlined, but when not optimizing > we need to emit a definition of the wrapper. That means marking it as an >

Re: [PATCH, rs6000] Use lxvx and stxvx for 128-bit float, etc., with -mcpu=power9

2016-01-06 Thread David Edelsohn
On Wed, Jan 6, 2016 at 1:34 PM, Bill Schmidt wrote: > Hi, > > I previously added POWER9 support for lxvx and stxvx to replace the > load-swap and swap-store patterns for POWER8. However, I missed the > fact that we have different patterns for loads and stores of 128-bit > floats and other scalars

[PATCH, rs6000] Use lxvx and stxvx for 128-bit float, etc., with -mcpu=power9

2016-01-06 Thread Bill Schmidt
Hi, I previously added POWER9 support for lxvx and stxvx to replace the load-swap and swap-store patterns for POWER8. However, I missed the fact that we have different patterns for loads and stores of 128-bit floats and other scalars. This patch expands the previous POWER9 override to catch thes

[gomp4] 2 fortran tests

2016-01-06 Thread Nathan Sidwell
These two tests ICE unless -ftree-parallelize-loops is 1. nathan 2016-01-06 Nathan Sidwell * gfortran.dg/goacc/reduction-2.f95: Set ftree-parallize-loops to 1. * gfortran.dg/goacc/combined-directives.f90: Likewise. Index: gfortran.dg/goacc/reduction-2.f95 ==

Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)

2016-01-06 Thread Kyrill Tkachov
On 06/01/16 17:13, Christian Bruel wrote: On 01/06/2016 05:23 PM, Kyrill Tkachov wrote: On 06/01/16 16:04, Kyrill Tkachov wrote: Hi Christian, On 06/01/16 14:02, Christian Bruel wrote: ping/respin https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01095.html. This patch fixes LTO for neon buil

Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)

2016-01-06 Thread Kyrill Tkachov
On 06/01/16 16:04, Kyrill Tkachov wrote: Hi Christian, On 06/01/16 14:02, Christian Bruel wrote: ping/respin https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01095.html. This patch fixes LTO for neon builtins defined with attribute target or in a pragma region. It also fixes a few discrepancies

Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)

2016-01-06 Thread Kyrill Tkachov
Hi Christian, On 06/01/16 14:02, Christian Bruel wrote: ping/respin https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01095.html. This patch fixes LTO for neon builtins defined with attribute target or in a pragma region. It also fixes a few discrepancies due to the unavailability of the neon buil

[openacc] fix unoptimized acc_on_device

2016-01-06 Thread Nathan Sidwell
I've committed this to trunk. C++ needs a wrapper function to deal with the enumerated type argument. Usually that's inlined, but when not optimizing we need to emit a definition of the wrapper. That means marking it as an openacc routine. nathan 2016-01-06 Nathan Sidwell * openacc.c

Re: [PATCH] shrink-wrap: Once more PRs 67778, 68634, and now 68909

2016-01-06 Thread Segher Boessenkool
On Wed, Jan 06, 2016 at 06:36:19AM -0600, Segher Boessenkool wrote: > This fixes this problem. Tested on the 68909 testcase, and bootstrapped > and regression checked on powerpc64-linux. Is this okay for trunk? Also tested on x86_64-linux now. Segher > 2016-01-06 Segher Boessenkool > >

Re: [PATCH] v3 of diagnostic_show_locus and rich_location (was Re: [PATCH 2/5] Reimplement diagnostic_show_locus, introducing rich_location classes (v2))

2016-01-06 Thread David Malcolm
On Tue, 2015-12-29 at 12:53 -0800, Mike Stump wrote: > On Sep 25, 2015, at 1:11 PM, David Malcolm > wrote: > > +layout::layout (diagnostic_context * context, > >> + const diagnostic_info *diagnostic) > >> > >> [...] > >> > >> + if (loc_range->m_finish.file != m_exploc.file) > >> +

Re: [PATCH, ARM] PR68674 Fix LTO support for neon builtin and error catching (ping)

2016-01-06 Thread Kyrill Tkachov
Hi Christian, On 06/01/16 14:02, Christian Bruel wrote: ping/respin https://gcc.gnu.org/ml/gcc-patches/2015-12/msg01095.html. This patch fixes LTO for neon builtins defined with attribute target or in a pragma region. It also fixes a few discrepancies due to the unavailability of the neon buil

[wwwdocs] gcc-6/changes.html: diagnostics, Levenshtein, -Wmisleading-indentation, jit

2016-01-06 Thread David Malcolm
The attached patch adds information on various things to the gcc-6/changes.html page: * source-range-tracking (the patch merges the description of the string location work into this, and updates the colorization of the example to reflect gcc-6's behavior) * fix-it hints * hints for misspelled memb

[patch] Rename bits/mutex.h to avoid clashing with glibc

2016-01-06 Thread Jonathan Wakely
Matthias discovered that the new header I created on trunk clashes with a libc header on GNU/Hurd, so this patch renames it to something unique. Tested powerpc64le-linux, committed to trunk. commit cd573d5d7d0a13be626619fa4b663941e86cdf98 Author: Jonathan Wakely Date: Wed Jan 6 12:43:07 2016

Re: [PATCH] shrink-wrap: Once more PRs 67778, 68634, and now 68909

2016-01-06 Thread Segher Boessenkool
On Mon, Jan 04, 2016 at 03:24:10PM +0100, Bernd Schmidt wrote: > >>This code is getting really quite confusing, > >>and at the least I think we > >>need more documentation of what exactly vec is supposed to contain at > >>the entry to the inner while loop here. > > > >Same as in the other loop: vec

Re: [PATCH 2/4 v2][AArch64] Add support for FCCMP

2016-01-06 Thread Wilco Dijkstra
Hi Evandro, > Here's what I had in mind when I inquired about distinguishing FCMP from > FCCMP. As you can see in the patch, Exynos is the only target that > cares about it, but I wonder if ThunderX or Xgene would too. > > What do you think? The new attributes look fine (I've got a similar outs

Re: [PATCH] c/68966 - atomic_fetch_* on atomic_bool not diagnosed

2016-01-06 Thread Marek Polacek
On Tue, Jan 05, 2016 at 11:46:52AM -0700, Martin Sebor wrote: > I just downloaded and installed an Emacs equivalent called redspace. > It does the same thing. Unfortunately, it also has the effect of > highlighting in red the one blank inserted by diff at the beginning > of empty lines. I guess th

Re: [PATCH] -Winvalid-memory-model warning not given for stdatomic.h macros (PR c/69104)

2016-01-06 Thread Marek Polacek
On Wed, Jan 06, 2016 at 11:46:32AM +0100, Andreas Schwab wrote: > * gcc.dg/atomic-invalid-2.c: Remove duplicated content. Thanks and sorry. No idea how did that happen. Marek

Re: [PATCH] -Winvalid-memory-model warning not given for stdatomic.h macros (PR c/69104)

2016-01-06 Thread Andreas Schwab
* gcc.dg/atomic-invalid-2.c: Remove duplicated content. diff --git a/gcc/testsuite/gcc.dg/atomic-invalid-2.c b/gcc/testsuite/gcc.dg/atomic-invalid-2.c index 6bf5c96..c73458e 100644 --- a/gcc/testsuite/gcc.dg/atomic-invalid-2.c +++ b/gcc/testsuite/gcc.dg/atomic-invalid-2.c @@ -57,62 +57,3

Re: [patch] ARM FreeBSD fix bootstrap

2016-01-06 Thread Richard Earnshaw (lists)
On 05/01/16 21:03, Andreas Tobler wrote: > On 05.01.16 11:32, Richard Earnshaw (lists) wrote: >> On 23/12/15 19:28, Andreas Tobler wrote: > >>> 2015-12-23 Andreas Tobler >>> >>> * config/arm/freebsd.h: Rename SUBTARGET_OVERRIDE_OPTIONS to >>> SUBTARGET_OVERRIDE_INTERNAL_OPTIONS. Adjus

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/68841: Make sure one basic block doesn't clobber CC reg usage of the other

2016-01-06 Thread Kyrill Tkachov
Hi Bernd, On 05/01/16 18:19, Kyrill Tkachov wrote: On 05/01/16 17:06, Kyrill Tkachov wrote: On 05/01/16 16:34, Bernd Schmidt wrote: On 01/05/2016 03:22 PM, Kyrill Tkachov wrote: This works around the issue but we don't want to do perform the check for pairs of simple basic blocks because t

[PATCH] Fix usage of an uninitialized variable

2016-01-06 Thread Martin Liška
Simple fix of a warning reported during bootstrap: ../../lto-plugin/lto-plugin.c: In function ‘all_symbols_read_handler’: ../../lto-plugin/lto-plugin.c:673:20: warning: ‘linker_output_str’ may be used uninitialized in this function [-Wmaybe-uninitialized] *lto_arg_ptr++ = xstrdup (linker_outpu

Re: [PATCH] PR target/68991: Add vector_memory_operand and "Bm" constraint

2016-01-06 Thread Uros Bizjak
On Wed, Jan 6, 2016 at 10:18 AM, Uros Bizjak wrote: > On Tue, Jan 5, 2016 at 10:34 PM, Richard Sandiford > wrote: >> Jakub Jelinek writes: >>> On Mon, Jan 04, 2016 at 03:25:48PM -0800, H.J. Lu wrote: LRA is fine. I should use (define_memory_constraint "Bm" "@internal Vecto

Re: [PATCH] PR target/68991: Add vector_memory_operand and "Bm" constraint

2016-01-06 Thread Uros Bizjak
On Tue, Jan 5, 2016 at 10:34 PM, Richard Sandiford wrote: > Jakub Jelinek writes: >> On Mon, Jan 04, 2016 at 03:25:48PM -0800, H.J. Lu wrote: >>> LRA is fine. I should use >>> >>> (define_memory_constraint "Bm" >>> "@internal Vector memory operand." >>> (match_operand 0 "vector_memory_operan

Re: [PATCH 2/2] Ada: add XVE/XVU parallel types to lexical scopes

2016-01-06 Thread Pierre-Marie de Rodat
Committed. Thank you! -- Pierre-Marie de Rodat

Re: [PATCH] Fix pr69012 ICE on building libgfortran for mips

2016-01-06 Thread Bernd Edlinger
On 05.01.2016 21:41, Richard Sandiford wrote: > Matthew Fortune writes: >> Bernd Edlinger writes: >>> Yes, I agree, it _should_ be a no-op, but given the complexity of >>> mips_compute_frame_info it is probably better to use cached values after >>> reload completed. >>> >>> Before reload_complete