Re: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-11-10 Thread Jeff Law
On 09/12/2015 04:38 AM, Ajit Kumar Agarwal wrote: -Original Message- From: Jeff Law [mailto:l...@redhat.com] Sent: Thursday, September 10, 2015 3:10 AM To: Ajit Kumar Agarwal; Richard Biener Cc: GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subjec

Re: [PATCH] gcc.c: new macro POST_LINK_SPECS to be able to add additional steps after linking

2015-11-10 Thread Andris Pavenis
On 11/10/2015 11:20 PM, Jeff Law wrote: On 11/10/2015 11:16 AM, Andris Pavenis wrote: One may need to execute extra steps after linking program. This is required for example for DJGPP to run stubify.exe on file generated by linker. The only way how to achieve was to use LINK_COMMAND_SPEC. It wo

[PATCH] AIX asserts

2015-11-10 Thread David Edelsohn
This patch adds some asserts of cpu and machine to fix an assert testcase and makes the defines consistent with PPC64 Linux. boottrapped on powerpc-ibm-aix7.1.0.0 * config/rs6000/aix.h (TARGET_OS_AIX_CPP_BUILTINS): Add cpu and machine asserts. Update defines for 64 bit. Thanks, David Index: ai

Re: RFC: Experimental use of Sphinx for GCC documentation

2015-11-10 Thread Sandra Loosemore
[resending, gcc-patches won't allow a screenshot attachment] On 11/10/2015 03:27 PM, David Malcolm wrote: Correct, readable and well-organized documentation are laudable goals... but I think that, to a first approximation, we're already there: I just feel that the content is hidden behind a poo

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

2015-11-10 Thread Trevor Saunders
On Tue, Nov 10, 2015 at 11:02:04PM +0100, Bernd Schmidt wrote: > On 11/09/2015 11:53 PM, Trevor Saunders wrote: > >I don't really know him, but I don't really disagree with where he wants > >to get to. However I think we work fairly different ways, and review > >things differently. When I review

Re: [PATCH], Add power9 support to GCC, patch #10 (SFmode/DFmode d-form addressing)

2015-11-10 Thread Michael Meissner
Arghh, forgot the the patch once again. [gcc] 2015-11-10 Michael Meissner * config/rs6000/constraints.md (wb constraint): New constraint for ISA 3.0 d-form scalar addressing. * config/rs6000/rs6000.c (mode_supports_vmx_dform): Add support for ISA 3.0 D

Re: [PATCH], Add power9 support to GCC, patch #10 (SFmode/DFmode d-form addressing)

2015-11-10 Thread Segher Boessenkool
On Tue, Nov 10, 2015 at 04:56:15PM -0500, Michael Meissner wrote: > This patch d-form addressing to float/double scalars for the PowerPC that was > added in ISA 3.0 (power9). This patch does not yet turn on D-form addressing > as default. It is likely that patch #11, which will add limited d-form

RE: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Robert Suchanek
Hi, > > Bernd, do you think that this check would be sufficient and safe? > > I'm not sure what would be better: check the mode, nregs plus perhaps > > consider tying only if nregs == 1. > > Hmm, but shouldn't the regno still be the same? Or is this a case where > we have a multi-word chain like a

[Patch, MIPS] Remove definition of TARGET_PROMOTE_PROTOTYPES

2015-11-10 Thread Steve Ellcey
This patch removes the definition of TARGET_PROMOTE_PROTOTYPES from MIPS, where it was defined as true, so that it now defaults to false. Currently MIPS does prototype promotion in the caller and the callee and this patch removes the TARGET_PROMOTE_PROTOTYPES macro definition so that the promotion

Re: [C/C++ PATCH] Reject declarators with huge arrays (PR c/68107, c++/68266)

2015-11-10 Thread Jeff Law
On 11/10/2015 09:36 AM, Marek Polacek wrote: While both C and C++ FEs are able to reject e.g. int a[__SIZE_MAX__ / sizeof(int)]; they are accepting code such as int (*a)[__SIZE_MAX__ / sizeof(int)]; As Joseph pointed out, any construction of a non-VLA type whose size is half or more of the addre

Re: [PR64164] drop copyrename, integrate into expand

2015-11-10 Thread Jeff Law
On 11/10/2015 03:58 PM, Alexandre Oliva wrote: On Nov 10, 2015, Alan Lawrence wrote: FAIL: gcc.target/aarch64/aapcs64/func-ret-4.c execution, -O2 Ugh, sorry. I even checked that testcase by hand before submitting the patch, because I knew it took the paths I was changing, but I didn't real

Re: [gomp4] Fix some broken tests

2015-11-10 Thread Cesar Philippidis
On 11/10/2015 12:35 PM, Nathan Sidwell wrote: > I've committed this to gomp4. In preparing the reworked firstprivate > patch changes for gomp4's gimplify.c I discovered these testcases were > passing by accident, and lacked a data clause. It used to be if a reduction was on a parallel construct,

Re: RFC: Experimental use of Sphinx for GCC documentation

2015-11-10 Thread Joseph Myers
On Mon, 9 Nov 2015, Sandra Loosemore wrote: > If we're going to switch documentation formats, I'd rather we used DocBook. > I've had to use "restructured text" before and found it really awkward. I should perhaps note that the Sphinx extensions to reST are a lot better documented than the ZWiki

Re: [PR64164] drop copyrename, integrate into expand

2015-11-10 Thread Alexandre Oliva
On Nov 10, 2015, Alan Lawrence wrote: > FAIL: gcc.target/aarch64/aapcs64/func-ret-4.c execution, -O2 Ugh, sorry. I even checked that testcase by hand before submitting the patch, because I knew it took the paths I was changing, but I didn't realize the stack store and load would amount to shif

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 11:33 PM, Robert Suchanek wrote: The reason behind the failures is that the terminated_this_insn had a different number of consecutive registers (and mode) to the input operand in a move currently being considered for tying. In the fix, I allow tying only if there is matching numbe

Re: [ptx] partitioning optimization

2015-11-10 Thread Ilya Verbin
> I've been unable to introduce a testcase for this. The difficulty is we want > to check an rtl dump from the acceleration compiler, and there doesn't > appear to be existing machinery for that in the testsuite. Perhaps > something to be added later? I haven't tried it, but doesn't /* { dg-optio

[ptx] partitioning optimization

2015-11-10 Thread Nathan Sidwell
I've committed this patch to trunk. It implements a partitioning optimization for a loop partitioned over both vector and worker axes. We can elide the inner vector partitioning state propagation, if there are no intervening instructions in the worker-partitioned outer loop other than the fork

RE: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Robert Suchanek
Hi all, > > Now that 'make check' has had enough time to run, I can see several > > regressions in the configurations where GCC still builds. > > For more details: > > http://people.linaro.org/~christophe.lyon/cross-validation/gcc/trunk/230087/report-build-info.html > > > > This also causes failu

Re: RFC: Experimental use of Sphinx for GCC documentation

2015-11-10 Thread David Malcolm
On Mon, 2015-11-09 at 16:37 -0700, Sandra Loosemore wrote: > On 11/08/2015 06:55 AM, David Malcolm wrote: > > I've been experimenting with using Sphinx [1] for GCC's documentation. > > > > [snip] > > > > The primary advantages of .rst/sphinx over .texi/texinfo I see are in > > the generated HTML: >

Re: [PATCH 10/12] always define EH_RETURN_HANDLER_RTX

2015-11-10 Thread Bernd Schmidt
On 11/09/2015 11:53 PM, Trevor Saunders wrote: I don't really know him, but I don't really disagree with where he wants to get to. However I think we work fairly different ways, and review things differently. When I review patches (mostly for stuff more directly related to Mozilla my standards

[patch] libsanitizer

2015-11-10 Thread Andreas Tobler
Hi all, the attached patch removes the hard-coded requirement for the link operation with -ldl. On FreeBSD we do not need that, it breaks compilation. The patch is tested against CentOS7.1 Ok to apply for trunk? TIA, Andreas 2015-11-10 Andreas Tobler * configure.ac: Replace the

Re: [PATCH], Add power9 support to GCC, patch #10 (SFmode/DFmode d-form addressing)

2015-11-10 Thread Michael Meissner
This patch d-form addressing to float/double scalars for the PowerPC that was added in ISA 3.0 (power9). This patch does not yet turn on D-form addressing as default. It is likely that patch #11, which will add limited d-form addressing to vector registers will enable it by default. I have boots

Re: libgo patch committed: Update to Go 1.5 release

2015-11-10 Thread Ian Lance Taylor
On Sun, Nov 8, 2015 at 9:21 AM, Rainer Orth wrote: > > There were two remaining problems: > > * Before Solaris 12, sendfile only lives in libsendfile. This lead to > link failures in gotools. > > * Solaris 12 introduced a couple more types that use _in6_addr_t, which > are filtered out by mk

Re: [RFC] [PATCH V2]: RE: [RFC] [Patch] Relax tree-if-conv.c trap assumptions.

2015-11-10 Thread Bernhard Reutner-Fischer
On November 10, 2015 1:02:57 PM GMT+01:00, Richard Biener wrote: >On Sat, Nov 7, 2015 at 12:41 PM, Kumar, Venkataramanan > wrote: >> Hi Richard, >> >> I have now implemented storing of DR and references using hash maps. >> Please find attached patch. >> >> As discussed, I am now storing the ref,

Re: [PATCH] gcc.c: new macro POST_LINK_SPECS to be able to add additional steps after linking

2015-11-10 Thread Jeff Law
On 11/10/2015 11:16 AM, Andris Pavenis wrote: One may need to execute extra steps after linking program. This is required for example for DJGPP to run stubify.exe on file generated by linker. The only way how to achieve was to use LINK_COMMAND_SPEC. It would be much easier and less error prone t

Re: Short-cut generation of simple built-in functions

2015-11-10 Thread Richard Sandiford
Richard Biener writes: > On Sat, Nov 7, 2015 at 2:31 PM, Richard Sandiford > wrote: >> This patch short-circuits the builtins.c expansion code for a particular >> gimple call if: >> >> - the function has an associated internal function >> - the target implements that internal function >> - the ca

Re: [PATCH] libcpp: add examples to source_location description

2015-11-10 Thread Jeff Law
On 11/10/2015 09:44 AM, David Malcolm wrote: This is a followup to: [PATCH 10/10] Compress short ranges into source_location which adds some worked examples of what a source_location/location_t can encode. Successfully bootstrapped®rtested on x86_64-pc-linux-gnu (although it only touches a co

Re: [patch 4/3] Header file reduction - Tools for contrib - second cut

2015-11-10 Thread Jeff Law
Andrew, can you go ahead and commit those changes into contrib? I think in a subdirectory would be best so that you can include the README. Make sure the permissions are set correctly. Applying them as a patch kept mucking them up. header-tools or somesuch should be a fine directory name

[PATCH] Fix minor fallout from output_address changes

2015-11-10 Thread Jeff Law
The ft32 and moxie ports failed to build after the recent output_address changes. Fixed thusly and committed to the trunk after verifying the moxie and ft32 ports in config-list.mk build again. Jeff commit b408dd85568c5d0c0a9673810280a8438753b60f Author: law Date: Tue Nov 10 21:11:07 2015 +

Re: [PATCH 1/2] simplify-rtx: Simplify trunc of and of shiftrt

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 06:44 PM, Segher Boessenkool wrote: Yes I know. All the rest of the code around is it like this though. Do you want this written in a saner way? I won't object to leaving it as-is for now, but in the future it would be good to keep this in mind. I'm not entirely sure what th

[PATCH, rs6000] Remove redundant logic from rs6000_secondary_reload_direct_move

2015-11-10 Thread Bill Schmidt
Hi, While investigating another issue, I observed some repeated logic in rs6000_secondary_reload_direct_move (). This patch takes it out. No functional change intended, and quite straightforward, so I'll plan to commit shortly if no concerns are raised. Bootstrapped and tested on powerpc64le-li

Re: [PATCH, applied], Add power9 support to GCC, patch #9 (config.gcc)

2015-11-10 Thread Michael Meissner
I applied this patch as obvious. I missed submitting it in my original patch for the power9 support (it was in the sandbox I was testing power9 support on). 2015-11-10 Michael Meissner * config.gcc (powerpc*-*-*, rs6000*-*-*): Add power9 to hosts that default to 64-bit. -- M

Re: [gomp4] Random omp-low.c backporting

2015-11-10 Thread Nathan Sidwell
On 11/10/15 11:28, Thomas Schwinge wrote: Hi Nathan! On Tue, 10 Nov 2015 09:19:50 -0500, Nathan Sidwell wrote: I've committed this to backport a bunch of random bits from trunk to gomp4, and thereby reduce divergence. Yeah, I had some of these on my list, too. --- omp-low.c (revision 230

[gomp4] Fix some broken tests

2015-11-10 Thread Nathan Sidwell
I've committed this to gomp4. In preparing the reworked firstprivate patch changes for gomp4's gimplify.c I discovered these testcases were passing by accident, and lacked a data clause. nathan 2015-11-10 Nathan Sidwell * testsuite/libgomp.oacc-fortran/parallel-reduction.f90: Fix data m

libgo patch committed: always use --whole-archive in go tool

2015-11-10 Thread Ian Lance Taylor
This patch changes the Go tool to always use --whole-archive when linking gccgo packages. This fixes cases where a Go package uses cgo to call C code in which the only referenced symbol is a C global variable. This is a backport of https://golang.org/cl/16775 in the master Go sources. This fixes

Re: Replace match.pd DEFINE_MATH_FNs with auto-generated lists

2015-11-10 Thread Richard Biener
On November 10, 2015 9:13:25 PM GMT+01:00, Richard Sandiford wrote: >Richard Biener writes: >> On Sat, Nov 7, 2015 at 2:23 PM, Richard Sandiford >> wrote: >>> diff --git a/gcc/genmatch.c b/gcc/genmatch.c >>> index cff32b0..7139476 100644 >>> --- a/gcc/genmatch.c >>> +++ b/gcc/genmatch.c >>> @@

Re: Replace match.pd DEFINE_MATH_FNs with auto-generated lists

2015-11-10 Thread Richard Sandiford
Richard Biener writes: > On Sat, Nov 7, 2015 at 2:23 PM, Richard Sandiford > wrote: >> diff --git a/gcc/genmatch.c b/gcc/genmatch.c >> index cff32b0..7139476 100644 >> --- a/gcc/genmatch.c >> +++ b/gcc/genmatch.c >> @@ -4638,6 +4638,11 @@ main (int argc, char **argv) >>cpp_callbacks *cb = cpp

Re: [PATCH v4] SH FDPIC backend support

2015-11-10 Thread Rich Felker
On Tue, Oct 27, 2015 at 11:01:39PM +0900, Oleg Endo wrote: > On Mon, 2015-10-26 at 22:47 -0400, Rich Felker wrote: > > On Sun, Oct 25, 2015 at 11:28:51PM +0900, Oleg Endo wrote: > > > On Fri, 2015-10-23 at 02:32 -0400, Rich Felker wrote: > > > > Here's my updated version of the FDPIC patch with all

[v3 PATCH] LWG 2510, make the default constructors of library tag types explicit.

2015-11-10 Thread Ville Voutilainen
Tested on Linux-X64. 2015-11-10 Ville Voutilainen LWG 2510, make the default constructors of library tag types explicit. * include/bits/mutex.h (defer_lock_t, try_lock_t, adopt_lock_t): Add an explicit default constructor. * include/bits/stl_pair.h (piecewise_construct_t):

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

2015-11-10 Thread Segher Boessenkool
On Mon, Nov 09, 2015 at 03:51:32AM -0600, Segher Boessenkool wrote: > > >From the original patch submission, it looks that this patch would > > also benefit x86_32. > > Yes, that is what I thought too. > > > Regarding the above code size increase - do you perhaps have a > > testcase, to see what

Re: [C/C++ PATCH] Reject declarators with huge arrays (PR c/68107, c++/68266)

2015-11-10 Thread Martin Sebor
On 11/10/2015 09:36 AM, Marek Polacek wrote: While both C and C++ FEs are able to reject e.g. int a[__SIZE_MAX__ / sizeof(int)]; they are accepting code such as int (*a)[__SIZE_MAX__ / sizeof(int)]; As Joseph pointed out, any construction of a non-VLA type whose size is half or more of the addre

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On November 10, 2015 6:29:36 PM GMT+01:00, Joseph Myers wrote: >On Tue, 10 Nov 2015, Richard Biener wrote: > >> Looks ok but I wonder if this is dead code with >> >> (for pows (POW) >> sqrts (SQRT) >> cbrts (CBRT) >> (simplify >> (pows @0 REAL_CST@1) >> (with { >> const REAL_V

Re: [PATCH], Add power9 support to GCC, patch #6 (IEEE 128-bit hardware support)

2015-11-10 Thread Michael Meissner
On Tue, Nov 10, 2015 at 12:41:07AM +, Joseph Myers wrote: > I don't see any conversions between KFmode and TImode (in either > direction, signed or unsigned) here - I suppose there are no instructions > for that? No in power9 there is no instruction that converts 128-bit integer to IEEE 128-

Re: [PATCH], Add power9 support to GCC, patch #8 (add integer multiply/add)

2015-11-10 Thread Michael Meissner
This patch adds support for the MADDLD instruciton, which is a fused multiply/add instruction for integers. At this time, it is for 64-bit multiplies only. Eventually, we will restructure 128-bit multiply so that we can use the 64x64 + 64 high bit varients. I have bootstrapped a compiler with th

Re: State of support for the ISO C++ Transactional Memory TS and remanining work

2015-11-10 Thread Torvald Riegel
On Tue, 2015-11-10 at 17:26 +, Szabolcs Nagy wrote: > On 09/11/15 00:19, Torvald Riegel wrote: > > Hi, > > > > I'd like to summarize the current state of support for the TM TS, and > > outline the current plan for the work that remains to complete the > > support. > > > > I'm aware we're at the

Re: [PATCH, i386]: Fix gcc.c-torture/compile/pr41634.c FAIL

2015-11-10 Thread Uros Bizjak
On Tue, Nov 10, 2015 at 7:14 PM, Uros Bizjak wrote: > On Tue, Nov 10, 2015 at 7:00 PM, Richard Henderson wrote: >> On 11/10/2015 06:54 PM, Uros Bizjak wrote: >>> >>> - return "movabs{}\t{%1, %0|%0, %1}"; >>> + return "movabs{}\t{%1, %P0|[%P0], %1}"; >> >> >> The thing that's missing fro

[PATCH] gcc.c: new macro POST_LINK_SPECS to be able to add additional steps after linking

2015-11-10 Thread Andris Pavenis
One may need to execute extra steps after linking program. This is required for example for DJGPP to run stubify.exe on file generated by linker. The only way how to achieve was to use LINK_COMMAND_SPEC. It would be much easier and less error prone to use new macro POST_LINK_SPEC introduced in t

Re: Enable pointer TBAA for LTO

2015-11-10 Thread Jan Hubicka
> > Index: tree.c > > === > > --- tree.c (revision 229968) > > +++ tree.c (working copy) > > @@ -13198,6 +13198,7 @@ gimple_canonical_types_compatible_p (con > >/* If the types have been previously registered and found equal > >

Re: [PATCH, i386]: Fix gcc.c-torture/compile/pr41634.c FAIL

2015-11-10 Thread Uros Bizjak
On Tue, Nov 10, 2015 at 7:00 PM, Richard Henderson wrote: > On 11/10/2015 06:54 PM, Uros Bizjak wrote: >> >> - return "movabs{}\t{%1, %0|%0, %1}"; >> + return "movabs{}\t{%1, %P0|[%P0], %1}"; > > > The thing that's missing from this, that's present in the patch that I sent > you off-list

Re: [PATCH 3a/4][AArch64] Add attribute for compatibility with ARM pipeline models

2015-11-10 Thread Ramana Radhakrishnan
On Tue, Nov 10, 2015 at 6:01 PM, Ramana Radhakrishnan wrote: > On Tue, Nov 10, 2015 at 5:50 PM, Evandro Menezes > wrote: >>2015-11-10 Evandro Menezes >> >>gcc/ >> >>* config/aarch64/aarch64.md (predicated): Copy attribute from >>"arm.md". >> >> This patch duplicates an

Re: [PATCH 3a/4][AArch64] Add attribute for compatibility with ARM pipeline models

2015-11-10 Thread Ramana Radhakrishnan
On Tue, Nov 10, 2015 at 5:50 PM, Evandro Menezes wrote: >2015-11-10 Evandro Menezes > >gcc/ > >* config/aarch64/aarch64.md (predicated): Copy attribute from >"arm.md". > > This patch duplicates an attribute from arm.md so that the same pipeline > model can be used for bot

Re: [C/C++ PATCH] Reject declarators with huge arrays (PR c/68107, c++/68266)

2015-11-10 Thread Joseph Myers
On Tue, 10 Nov 2015, Marek Polacek wrote: > While both C and C++ FEs are able to reject e.g. > int a[__SIZE_MAX__ / sizeof(int)]; > they are accepting code such as > int (*a)[__SIZE_MAX__ / sizeof(int)]; > > As Joseph pointed out, any construction of a non-VLA type whose size is half > or > more

Re: [PATCH, i386]: Fix gcc.c-torture/compile/pr41634.c FAIL

2015-11-10 Thread Richard Henderson
On 11/10/2015 06:54 PM, Uros Bizjak wrote: - return "movabs{}\t{%1, %0|%0, %1}"; + return "movabs{}\t{%1, %P0|[%P0], %1}"; The thing that's missing from this, that's present in the patch that I sent you off-list, is the thing for Intel syntax. Would you prefer to just add that bac

Re: [PATCH 02/02] C FE: add fix-it hint for . vs ->

2015-11-10 Thread Joseph Myers
On Tue, 10 Nov 2015, David Malcolm wrote: > This is the most trivial example of a real fix-it example I could think > of: if the user writes > ptr.field > rather than ptr->field. > > gcc/c/ChangeLog: > * c-typeck.c (build_component_ref): Special-case POINTER_TYPE when > generati

[PATCH, i386]: Fix gcc.c-torture/compile/pr41634.c FAIL

2015-11-10 Thread Uros Bizjak
Hello! Recent AS patches introduced the above compilation failure. We have to treat movabs operands in a special way - without %rip and inside square bracket for -masm=intel. Also, the patch removes dead code while at it. 2015-11-10 Uros Bizjak * config/i386/i386.c (ix86_print_operand):

[PATCH 3b/4][AArch64] Add scheduling model for Exynos M1

2015-11-10 Thread Evandro Menezes
2015-11-10 Evandro Menezes gcc/ * config/aarch64/aarch64-cores.def: Use the Exynos M1 sched model. * config/aarch64/aarch64.md: Include "exynos-m1.md". * config/arm/arm-cores.def: Use the Exynos M1 sched model. * config/arm/arm.md: Include "exynos-m1.md".

[PATCH 3a/4][AArch64] Add attribute for compatibility with ARM pipeline models

2015-11-10 Thread Evandro Menezes
2015-11-10 Evandro Menezes gcc/ * config/aarch64/aarch64.md (predicated): Copy attribute from "arm.md". This patch duplicates an attribute from arm.md so that the same pipeline model can be used for both AArch32 and AArch64. Bootstrapped on arm-unknown-linux-gnueabihf,

Re: [PATCH 1/2] simplify-rtx: Simplify trunc of and of shiftrt

2015-11-10 Thread Segher Boessenkool
On Tue, Nov 10, 2015 at 12:16:09PM +0100, Bernd Schmidt wrote: > On 11/09/2015 08:33 AM, Segher Boessenkool wrote: > >If we have > > > > (truncate:M1 (and:M2 (lshiftrt:M2 (x:M2) C) C2)) > > > >we can write it instead as > > > > (and:M1 (lshiftrt:M1 (truncate:M1 (x:M2)) C) C2) > > > > > >+

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread James Greenhalgh
On Tue, Nov 10, 2015 at 05:22:40PM +0100, Christophe Lyon wrote: > On 10 November 2015 at 12:41, Robert Suchanek > wrote: > > Hi Christophe, > > > >> Hi, > >> > >> Since you committed this (r230087 if I'm correct), I can see that GCC > >> fails to build > >> ligfortran for target arm-none-linuxgnu

Re: [C/C++ PATCH] Reject declarators with huge arrays (PR c/68107, c++/68266)

2015-11-10 Thread Paolo Carlini
Hi, On 11/10/2015 05:36 PM, Marek Polacek wrote: + + /* Did array size calculations overflow or does the array + cover more than half of the address-space? */ + if (COMPLETE_TYPE_P (type) + && TREE_CODE (TYPE_SIZE_UNIT (type)) == I

[PATCH][ARM] PR 68149 Fix ICE in unaligned_loaddi split

2015-11-10 Thread Kyrill Tkachov
Hi all, This ICE in this PR occurs when we're trying to split unaligned_loaddi into two SImode unaligned loads. The problem is in the addressing mode. When reload was picking the addressing mode we accepted an offset of -256 because the mode in the pattern is advertised as DImode and that was

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Joseph Myers
On Tue, 10 Nov 2015, Richard Biener wrote: > Looks ok but I wonder if this is dead code with > > (for pows (POW) > sqrts (SQRT) > cbrts (CBRT) > (simplify > (pows @0 REAL_CST@1) > (with { > const REAL_VALUE_TYPE *value = TREE_REAL_CST_PTR (@1); > REAL_VALUE_TYPE tmp; >}

Re: [PATCH][ARM][cleanup] Remove uses of CONST_DOUBLE_HIGH/LOW

2015-11-10 Thread Kyrill Tkachov
Hi Ramana, On 10/11/15 14:33, Ramana Radhakrishnan wrote: On Thu, Nov 5, 2015 at 9:32 AM, Kyrill Tkachov wrote: Hi all, This cleanup patch removes handling of CONST_DOUBLE rtxes that carry large integers. These should never be passed down from the midend and the arm backend doesn't create the

Re: State of support for the ISO C++ Transactional Memory TS and remanining work

2015-11-10 Thread Szabolcs Nagy
On 09/11/15 00:19, Torvald Riegel wrote: Hi, I'd like to summarize the current state of support for the TM TS, and outline the current plan for the work that remains to complete the support. I'm aware we're at the end of stage 1, but I'm confident we can still finish this work and hope to inclu

Re: [PATCH 01/02] PR/62314: add ability to add fixit-hints

2015-11-10 Thread David Malcolm
On Tue, 2015-11-10 at 17:26 +0100, Bernd Schmidt wrote: > On 11/10/2015 05:35 PM, David Malcolm wrote: > > + /* Nasty workaround to convince the linker to add > > + rich_location::add_fixit_insert > > + rich_location::add_fixit_remove > > + rich_location::add_fixit_replace > > +

RE: [PATCH 1/2][ARC] Add support for ARCv2 CPUs

2015-11-10 Thread Claudiu Zissulescu
> If you can name a pre-existing testcase to trigger the assert, the patch is > approved for separate check-in. The patch solves the gcc.dg/pr29921-2.c error, visible for ARC700 architecture. I will prepare a new patch for this error. Thank you for the review, Claudiu

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Mike Stump
On Nov 10, 2015, at 6:56 AM, Ilya Enkovich wrote: > 2015-11-10 17:46 GMT+03:00 Richard Biener : >> On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich >> wrote: >>> 2015-11-10 15:33 GMT+03:00 Richard Biener : On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: > Richard, > > I t

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-10 Thread Alan Lawrence
On 10/11/15 16:39, Alan Lawrence wrote: Since r229878, I've been seeing FAIL: gcc.dg/attr-weakref-1.c (test for excess errors) UNRESOLVED: gcc.dg/attr-weakref-1.c compilation failed to produce executable (both previously passing) on aarch64-none-elf, aarch64_be-none-elf, and aarch64-none-linux-

Re: [PATCH 1/2] Fix invalid left shift of negative value.

2015-11-10 Thread Mike Stump
On Nov 10, 2015, at 3:13 AM, Dominik Vogt wrote: > On Tue, Nov 10, 2015 at 12:11:23PM +0100, Dominik Vogt wrote: >> The following series of patches fixes all occurences of >> left-shifting negative constants in C code which is undefined by >> the C standard. The patches have been tested on s390x,

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-10 Thread Ramana Radhakrishnan
On Tue, Nov 10, 2015 at 4:39 PM, Alan Lawrence wrote: > On 04/11/15 14:26, Ramana Radhakrishnan wrote: >> >> >> True and I've just been reading more of the backend - We could now start >> using blocks for constant pools as well. So let's do that. >> >> How does something like this look ? >> >> Tes

Re: [Patch AArch64] Switch constant pools to separate rodata sections.

2015-11-10 Thread Alan Lawrence
On 04/11/15 14:26, Ramana Radhakrishnan wrote: True and I've just been reading more of the backend - We could now start using blocks for constant pools as well. So let's do that. How does something like this look ? Tested on aarch64-none-elf - no regressions. 2015-11-04 Ramana Radhakrishnan

[C/C++ PATCH] Reject declarators with huge arrays (PR c/68107, c++/68266)

2015-11-10 Thread Marek Polacek
While both C and C++ FEs are able to reject e.g. int a[__SIZE_MAX__ / sizeof(int)]; they are accepting code such as int (*a)[__SIZE_MAX__ / sizeof(int)]; As Joseph pointed out, any construction of a non-VLA type whose size is half or more of the address space should receive a compile-time error.

Re: [gomp4] Random omp-low.c backporting

2015-11-10 Thread Thomas Schwinge
Hi Nathan! On Tue, 10 Nov 2015 09:19:50 -0500, Nathan Sidwell wrote: > I've committed this to backport a bunch of random bits from trunk to gomp4, > and > thereby reduce divergence. Yeah, I had some of these on my list, too. > --- omp-low.c (revision 230080) > +++ omp-low.c (working copy) > @

Re: [PATCH 01/02] PR/62314: add ability to add fixit-hints

2015-11-10 Thread Bernd Schmidt
On 11/10/2015 05:35 PM, David Malcolm wrote: + /* Nasty workaround to convince the linker to add + rich_location::add_fixit_insert + rich_location::add_fixit_remove + rich_location::add_fixit_replace + to cc1 for use by diagnostic_plugin_test_show_locus, + before anything

[PATCH] libcpp: add examples to source_location description

2015-11-10 Thread David Malcolm
This is a followup to: [PATCH 10/10] Compress short ranges into source_location which adds some worked examples of what a source_location/location_t can encode. Successfully bootstrapped®rtested on x86_64-pc-linux-gnu (although it only touches a comment). OK for trunk? libcpp/ChangeLog:

Re: [RFC][PATCH] Preferred rename register in regrename pass

2015-11-10 Thread Christophe Lyon
On 10 November 2015 at 12:41, Robert Suchanek wrote: > Hi Christophe, > >> Hi, >> >> Since you committed this (r230087 if I'm correct), I can see that GCC >> fails to build >> ligfortran for target arm-none-linuxgnueabi --with-cpu=cortex-a9. > ... >> >> Can you have a look? > > Sorry for the break

[PATCH 01/02] PR/62314: add ability to add fixit-hints

2015-11-10 Thread David Malcolm
This patch adds the ability to add "fix-it hints" to a rich_location, which will be displayed when the corresponding diagnostic is printed. It does not actually add any fix-it hints (that comes in the second patch), but it adds test coverage of the machinery and printing, by using the existing dia

[PATCH 02/02] C FE: add fix-it hint for . vs ->

2015-11-10 Thread David Malcolm
This is the most trivial example of a real fix-it example I could think of: if the user writes ptr.field rather than ptr->field. gcc/c/ChangeLog: * c-typeck.c (build_component_ref): Special-case POINTER_TYPE when generating a "not a structure of union" error message, and

Re: [AArch64] Move iterators from atomics.md to iterators.md

2015-11-10 Thread James Greenhalgh
On Mon, Nov 02, 2015 at 11:44:02AM +, Matthew Wahab wrote: > Hello > > One of the review comments for the v8.1 atomics patches was that the > iterators and unspec declarations should be moved out of the atomics.md > file (https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01375.html). > > The iter

Re: [PR64164] drop copyrename, integrate into expand

2015-11-10 Thread Alan Lawrence
On 05/11/15 05:08, Alexandre Oliva wrote: [PR67753] fix copy of PARALLEL entry_parm to CONCAT target_reg for gcc/ChangeLog PR rtl-optimization/67753 PR rtl-optimization/64164 * function.c (assign_parm_setup_block): Avoid allocating a stack slot if we don't have a

Re: [PATCH] Make BB vectorizer work on sub-BBs

2015-11-10 Thread Christophe Lyon
On 10 November 2015 at 14:02, Richard Biener wrote: > On Tue, 10 Nov 2015, Christophe Lyon wrote: > >> On 6 November 2015 at 12:11, Kyrill Tkachov wrote: >> > Hi Richard, >> > >> > >> > On 06/11/15 11:09, Richard Biener wrote: >> >> >> >> On Fri, 6 Nov 2015, Richard Biener wrote: >> >> >> >>> The

[patch] libstdc++/68190 Fix return type of heterogeneous find for sets

2015-11-10 Thread Jonathan Wakely
This converts the return type of heterogeneous find members to the correct set iterator type. Tested powerpc64le-linux, committed to trunk. Will commit to the gcc-5-branch too. commit d84e13dd8a7d47016bdfc5a9f45d8658a9d16ed9 Author: Jonathan Wakely Date: Tue Nov 10 14:59:00 2015 + F

Re: [hsa 7/12] Disabling the vectorizer for GPU kernels/functions

2015-11-10 Thread Richard Biener
On Tue, 10 Nov 2015, Martin Jambor wrote: > On Fri, Nov 06, 2015 at 09:38:21AM +0100, Richard Biener wrote: > > On Thu, 5 Nov 2015, Martin Jambor wrote: > > > > > Hi, > > > > > > in the previous email I wrote we need to "change behavior" of a few > > > optimization passes. One was the flattenin

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Ilya Enkovich
2015-11-10 17:46 GMT+03:00 Richard Biener : > On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich wrote: >> 2015-11-10 15:33 GMT+03:00 Richard Biener : >>> On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: Richard, I tried it but 256-bit precision integer type is not yet supported.

Re: [RFC] Combine vectorized loops with its scalar remainder.

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 2:02 PM, Ilya Enkovich wrote: > 2015-11-10 15:30 GMT+03:00 Richard Biener : >> On Tue, Nov 3, 2015 at 1:08 PM, Yuri Rumyantsev wrote: >>> Richard, >>> >>> It looks like misunderstanding - we assume that for GCCv6 the simple >>> scheme of remainder will be used through intr

Re: [hsa 7/12] Disabling the vectorizer for GPU kernels/functions

2015-11-10 Thread Martin Jambor
On Fri, Nov 06, 2015 at 09:38:21AM +0100, Richard Biener wrote: > On Thu, 5 Nov 2015, Martin Jambor wrote: > > > Hi, > > > > in the previous email I wrote we need to "change behavior" of a few > > optimization passes. One was the flattening of GPU functions and the > > other two are in the patch

Re: [PATCH] Simple optimization for MASK_STORE.

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 1:48 PM, Ilya Enkovich wrote: > 2015-11-10 15:33 GMT+03:00 Richard Biener : >> On Fri, Nov 6, 2015 at 2:28 PM, Yuri Rumyantsev wrote: >>> Richard, >>> >>> I tried it but 256-bit precision integer type is not yet supported. >> >> What's the symptom? The compare cannot be e

Re: [Patch GCC 5/Vect] Partial backport of r228751 (pr68238)

2015-11-10 Thread James Greenhalgh
On Tue, Nov 10, 2015 at 10:11:30AM +, James Greenhalgh wrote: > > Hi, > > As requested in the PR, this patch is a partial backport of r228751. > > I can't claim any responsibility for it, but I did take it through the > paces on an aarch64-none-linux-gnu and x86_64-none-linux-gnu bootstrap/

Re: [PATCH 1/6] Use IFN_SQRT in tree-vect-patterns.c

2015-11-10 Thread Richard Biener
On Tue, Nov 10, 2015 at 11:57 AM, Richard Sandiford wrote: > Richard Biener writes: >> On Mon, Nov 9, 2015 at 5:21 PM, Richard Sandiford >> wrote: >>> In practice all targets that can vectorise sqrt define the appropriate >>> sqrt2 optab. The only case where this isn't immediately obvious >>> i

[PATCH] PR47266

2015-11-10 Thread Dominique d'Humières
I’ld like to close PR47266 as FIXED after the commit on trunk and 5.2.1 of the following test extracted from https://gcc.gnu.org/ml/fortran/2011-01/msg00094.html. The test succeeds on trunk and 5.2.1 (see https://gcc.gnu.org/ml/gcc-testresults/2015-11/msg00965.html in which it was included). O

Re: [1/2] OpenACC routine support

2015-11-10 Thread Cesar Philippidis
On 11/10/2015 12:16 AM, Jakub Jelinek wrote: > On Mon, Nov 09, 2015 at 09:28:47PM -0800, Cesar Philippidis wrote: >> Here's the patch that Nathan was referring to. I ended up introducing a >> boolean variable named first in the various functions which call >> finalize_oacc_routines. The problem the

Re: [PATCH][ARM][cleanup] Remove uses of CONST_DOUBLE_HIGH/LOW

2015-11-10 Thread Ramana Radhakrishnan
On Thu, Nov 5, 2015 at 9:32 AM, Kyrill Tkachov wrote: > Hi all, > > This cleanup patch removes handling of CONST_DOUBLE rtxes that carry large > integers. > These should never be passed down from the midend and the arm backend > doesn't create them. > The code has been there since 2007 but the arm

[gomp4] Random omp-low.c backporting

2015-11-10 Thread Nathan Sidwell
I've committed this to backport a bunch of random bits from trunk to gomp4, and thereby reduce divergence. nathan 2015-11-10 Nathan Sidwell * omp-low.c: Backport whitespace & formatting changes from trunk. (is_atomic_compatible_p): Delete. (lower_reduction_clauses): Don't call it. (expan

Re: RFC: Incomplete Draft Patches to Correct Errors in Loop Unrolling Frequencies (bugzilla problem 68212)

2015-11-10 Thread Michael Matz
Hi, On Tue, 10 Nov 2015, Richard Biener wrote: > >> +static bool > >> +same_edge_p (edge an_edge, edge another_edge) > >> +{ > >> + return ((an_edge->src == another_edge->src) > >> + && (an_edge->dest == another_edge->dest)); > >> +} > > > > > > Formatting aside (extra parentheses), I wo

Re: [PATCH][ARM] Fix costing of vmul+vcvt combine pattern

2015-11-10 Thread Ramana Radhakrishnan
On Tue, Oct 27, 2015 at 1:55 PM, Kyrill Tkachov wrote: > Hi all, > > This patch allows us to handle the *combine_vcvtf2i pattern in rtx costs by > properly identifying it > as a toint coversion. Before this I saw a pattern like: > (set (reg/i:SI 0 r0) > (fix:SI (fix:SF (mult:SF (reg:SF 16 s0 [

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-11-10 Thread Richard Biener
On Sun, Nov 8, 2015 at 10:43 AM, Kugan wrote: > > Thanks Richard for the comments. Please find the attached patches which > now passes bootstrap with x86_64-none-linux-gnu, aarch64-linux-gnu and > ppc64-linux-gnu. Regression testing is ongoing. Please find the comments > for your questions/sugge

Re: OpenACC Firstprivate

2015-11-10 Thread Nathan Sidwell
On 11/09/15 09:46, Nathan Sidwell wrote: I'm going to try and get clarification, but I think the intent is to initialize with the value seen on the device. Consider: My thinking is that the intent of the firstprivate is to initialize with the value known on the device (and behave as-if copyi

[patch] Update C++17 library implementation status

2015-11-10 Thread Jonathan Wakely
Committed to trunk. commit 49c7ea7c21cb4592233904cc1a4eb293ac6d851c Author: Jonathan Wakely Date: Tue Nov 10 14:03:39 2015 + Update C++17 library implementation status * doc/xml/manual/status_cxx2017.xml: Update. * doc/html/*: Regenerate. diff --git a/libstdc++-v3/doc/x

Re: [PATCH 2/2][ARC] Add support for ARCv2 CPUs

2015-11-10 Thread Joern Wolfgang Rennecke
On 30/10/15 11:22, Claudiu Zissulescu wrote: Hi, Please find the updated patch. Both ARC patches were tested using dg.exp. The ChangeLog entry is unchanged. This is OK.

Re: [PATCH 1/2][ARC] Add support for ARCv2 CPUs

2015-11-10 Thread Joern Wolfgang Rennecke
On 30/10/15 11:19, Claudiu Zissulescu wrote: Hi, Please find the updated patch. I will defer the secondary reload optimization which will use the ld instructions with LIMM, for the time being. Apart from the gen_compare_reg change, the patch is OK. If the v2 support mostly works like supp

  1   2   >