[PATCH] Remove more backedge threading support

2015-11-06 Thread Jeff Law
This removes the last bits of code to thread through backedges using the old threader. Behaviour is essentially the same, except some shuffling of code to ensure we always fall back to the FSM threader if a backedge is found. Bootstrapped and regression tested on x86_64-linux-gnu. Install

Re: [PATCH v3 2/2] [PR debug/67192] Further fix C loops' back-jump location

2015-11-06 Thread Jeff Law
On 11/04/2015 09:18 AM, Andreas Arnez wrote: After parsing an unconditional "while"- or "for"-loop, the C front-end generates a backward-goto statement and implicitly sets its location to the current input_location. But in some cases the parser peeks ahead first, such that input_location already

Re: [PATCH v3 1/2] [PR debug/67192] Fix C loops' back-jump location

2015-11-06 Thread Jeff Law
On 11/04/2015 09:17 AM, Andreas Arnez wrote: Since r223098 ("Implement -Wmisleading-indentation") the backward-jump generated for a C while- or for-loop can get the wrong line number. This is because the check for misleading indentation peeks ahead one token, advancing input_location to after the

Re: Move const char * -> int/fp folds to fold-const-call.c

2015-11-06 Thread Jeff Law
On 11/06/2015 08:22 AM, Richard Sandiford wrote: This patch moves folds that deal with constant string arguments and return a constant integer or floating-point value. For example, it handles strcmp ("foo", "bar") but not strstr ("foobar", "bar"), which wouldn't currently be accepted by the gimp

Re: regrename: Fix for earlyclobber operands

2015-11-06 Thread Jeff Law
On 11/06/2015 04:04 PM, Bernd Schmidt wrote: On 11/06/2015 08:30 PM, Jeff Law wrote: * regrename.c (record_out_operands): Terminate earlyclobbered operands here. Do you want to terminate those chains after step 6 is complete so that the earlyclobber output conflicts with all the other o

Re: [PATCH] x86 interrupt attribute

2015-11-06 Thread Jeff Law
On 11/06/2015 03:19 PM, H.J. Lu wrote: On Fri, Nov 6, 2015 at 7:31 AM, Uros Bizjak wrote: On Fri, Nov 6, 2015 at 3:07 PM, Yulia Koval wrote: Hi, I updated and reposted the patch. Regtested/bootstraped on x86_64/Linux and i686/Linux. Ok for trunk? This version still emits insns from ix86_fu

[PATCH/RFC] C++ FE: expression ranges (work in progress)

2015-11-06 Thread David Malcolm
Caveat: this patch is a work-in-progress, but I thought it was worth posting to check that the concept is OK. This patch builds on top of the patch kit: "[PATCH 00/10] Overhaul of diagnostics (v5)" https://gcc.gnu.org/ml/gcc-patches/2015-10/msg02536.html of which patches 1-4 are now in trunk. N

Re: [PATCH] i386: Use the STC bb-reorder algorithm at -Os (PR67864)

2015-11-06 Thread Segher Boessenkool
Adding x86 maintainer, ping? On Fri, Oct 16, 2015 at 05:53:41AM -0700, Segher Boessenkool wrote: > For x86, STC still gives better results for optimise-for-size than > "simple" does. So use STC at -Os as well. > > Is this okay for trunk? > > > Segher > > > 2015-10-16 Segher Boessenkool >

libgo patch committed: Fix unexported embedded structs

2015-11-06 Thread Ian Lance Taylor
There has been a long-standing discrepancy between the gc and the gccgo Go compilers in their handling of the type descriptors for unexported embedded structs. gccgo correctly records a PkgPath for the package where those embedded structs are defined. gc does not. The Go libraries are written exp

[gomp4] revert fortran declare changes

2015-11-06 Thread Cesar Philippidis
This patch reverts the declare cleanups I introduced in . Notably, I deleted resolve_omp_duplicate_list and resolve_oacc_declare_map. Jim, I also reverted my changes to declare-2.f95. Please make the error messages consistent with the rest

[PATCH 1/2] [graphite] do not create unnecessary dimensions in scop scattering

2015-11-06 Thread Sebastian Pop
* graphite-sese-to-poly.c (build_pbb_scattering_polyhedrons): Remove. (build_pbb_minimal_scattering_polyhedrons): New. (build_scop_scattering): Remove. (build_scop_minimal_scattering): New. (build_scop_scattering): Call build_pbb_minimal_scatt

[PATCH 2/2] add original schedule to scop

2015-11-06 Thread Sebastian Pop
From: Abderrazek Zaafrani * graphite-optimize-isl.c (optimize_isl): Call isl_union_map_is_equal. * graphite-poly.c (new_scop): Initialize original_schedule. (free_scop): Free original_schedule. * graphite-poly.h (struct scop): Add field original_schedule. * graphite-sese-to-po

[gomp4] backport trunk FE changes

2015-11-06 Thread Cesar Philippidis
I've applied this patch to gomp-4_0-branch which backports most of my front end changes from trunk. Note that I found a regression while testing, which is also present in trunk. It looks like kernels-acc-loop-reduction.c is failing because I'm incorrectly propagating the reduction variable to both

Re: [PATCH][RFC] Remove warning for SET VOIDmode -> BLKmode.

2015-11-06 Thread Jeff Law
On 11/06/2015 04:12 PM, Bernd Schmidt wrote: On 11/06/2015 10:45 PM, Jeff Law wrote: On 11/03/2015 10:16 AM, Dominik Vogt wrote: * genrecog.c (validate_pattern): Allow "set VOIDmode -> BLKmode" without warnings. First, for reference, I was initially concerned the patterns were bogus, b

[PATCH] Allow vrp to thread across backedges using FSM threader

2015-11-06 Thread Jeff Law
This is in preparation for removing a blob of code in the old threader that knew how to thread across backedges. Essentially this just allows us to try FSM threading in VRP's instance of threader. So certain jump threading happens earlier in the pipeline. It also tightens up the ssa-dom-th

Re: [PATCH][RFC] Remove warning for SET VOIDmode -> BLKmode.

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 10:45 PM, Jeff Law wrote: On 11/03/2015 10:16 AM, Dominik Vogt wrote: * genrecog.c (validate_pattern): Allow "set VOIDmode -> BLKmode" without warnings. First, for reference, I was initially concerned the patterns were bogus, but these are reasonably canonical ways to impl

Re: [libgomp] task scheduler rewrite and task priorities implementation

2015-11-06 Thread Aldy Hernandez
On 10/29/2015 08:46 AM, Aldy Hernandez wrote: Yo! As promised, here is the work implementing a new API for the task scheduler, rewriting the scheduler to fit into this new API, and implementing the task priorities that are in OpenMP > 4.1. There are also lots of cleanups and documentation. Af

Re: regrename: Fix for earlyclobber operands

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 08:30 PM, Jeff Law wrote: * regrename.c (record_out_operands): Terminate earlyclobbered operands here. Do you want to terminate those chains after step 6 is complete so that the earlyclobber output conflicts with all the other outputs? I'm not sure what you mean by your q

Re: [PATCH][RTL-ifcvt] PR rtl-optimization/67749: Do not emit separate SET insn in IF-ELSE case

2015-11-06 Thread Jeff Law
On 11/03/2015 02:09 AM, Kyrill Tkachov wrote: Hi Jeff, On 02/11/15 22:46, Jeff Law wrote: On 10/27/2015 08:49 AM, Kyrill Tkachov wrote: Hi all, This patch fixes the gcc.dg/ifcvt-2.c test for x86_64 where we were failing to if-convert. This was because in my patch at https://gcc.gnu.org/viewcv

Re: [PATCH] x86 interrupt attribute

2015-11-06 Thread H.J. Lu
On Fri, Nov 6, 2015 at 7:31 AM, Uros Bizjak wrote: > On Fri, Nov 6, 2015 at 3:07 PM, Yulia Koval wrote: >> Hi, >> >> I updated and reposted the patch. Regtested/bootstraped on >> x86_64/Linux and i686/Linux. Ok for trunk? > > This version still emits insns from ix86_function_arg, so NAK. > > Uros

Re: [PATCH] Fix warning in tree-diagnostic.h.

2015-11-06 Thread Jeff Law
On 11/03/2015 02:57 AM, Dominik Vogt wrote: On Mon, Nov 02, 2015 at 09:57:22AM -0700, Jeff Law wrote: On 11/02/2015 06:26 AM, Dominik Vogt wrote: The attached patch fixes the annoying warnings generated by diagnostic_set_last_function. Can you point out what warning you're fixing? Sure. top

Re: [sched] Dump dependency graph to a dot file

2015-11-06 Thread Jeff Law
On 11/05/2015 03:26 AM, Nikolai Bozhenov wrote: On 11/05/2015 12:18 PM, Kyrill Tkachov wrote: Hi Nikolai, On 05/11/15 08:29, Nikolai Bozhenov wrote: Hi! The attached patch adds a procedure to dump the scheduler's dependency graph into a dot file. The patch has been bootstrapped and regtested

Re: C++ PATCH for non-type constrained-type-specifiers

2015-11-06 Thread Andrew Sutton
> I started looking at allowing non-type constrained-type-specifiers in auto > deduction and then realized that we didn't handle them in function > parameters either. Fixing that brought home to me the oddity of having a > type-specifier stand in for a non-type. Mind weighing in on that on the >

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

2015-11-06 Thread Segher Boessenkool
[ reordered a bit ] On Fri, Nov 06, 2015 at 02:14:12PM -0700, Jeff Law wrote: > On 11/06/2015 07:19 AM, Kyrill Tkachov wrote: > >>>I think we should also add: > >>> && REG_P (XEXP (XEXP (x, 0), 0)) > >>> && REG_P (XEXP (XEXP (x, 1), 0)) > I tend to agree. > >Indeed, this looks better

Re: [PATCH][RFC] Remove warning for SET VOIDmode -> BLKmode.

2015-11-06 Thread Jeff Law
On 11/03/2015 10:16 AM, Dominik Vogt wrote: (Debug code removed from patch.) Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany 0001-ChangeLog gcc/ChangeLog * genrecog.c (validate_pattern): Allow "set VOIDmode -> BLKmode" without warnings. First, for reference, I was initia

Re: [RFA] Do not use libiberty's getpagesize on Android

2015-11-06 Thread Joel Brobecker
> > libiberty/ChangeLog: > > > > * configure.ac: Set AC_CV_FUNC_GETPAGESIZE to "yes" on > > Android hosts. > > * configure: Regenerate. > > > > OK to apply? > > Ok. Thank you, DJ. committed in gcc's SVN, and pushed to binutils-gdb. -- Joel

[PATCH] Implement OpenMP 4.5 region/construct nesting rules

2015-11-06 Thread Jakub Jelinek
Hi! I've committed following patch, after reading through all the OpenMP 4.5 region/construct nesting rules. Bootstrapped/regtested on x86_64-linux and i686-linux. 2015-11-06 Jakub Jelinek * gimplify.c (gimplify_omp_ordered): Fix up diagnostics wording. * omp-low.c (ch

Re: [PATCH 3/6] Share code from fold_array_ctor_reference with fold.

2015-11-06 Thread Jeff Law
On 11/04/2015 07:35 AM, Alan Lawrence wrote: s/explicitely/explicitly/ And remove the '*' from the 2nd and 3rd lines of the comment. It looks like get_ctor_element_at_index has numerous formatting problems. In particular you didn't indent the braces across the board properly. Also check for t

Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c

2015-11-06 Thread Mike Stump
On Nov 4, 2015, at 1:02 PM, Manuel López-Ibáñez wrote: > On 4 November 2015 at 09:45, Mike Stump wrote: >> in the top of the tree. This is bad as the same line appears in a PASS: and >> an XFAIL:. Each test case should be unique. Should it be updated to 64? > > I think it is sufficient to ch

Re: Change behavior of -fsched-verbose option

2015-11-06 Thread Jeff Law
On 10/22/2015 09:38 AM, Nikolai Bozhenov wrote: Hi! Currently -fsched-verbose option redirects debugging dumps to stderr if there is no dump_file for the current pass. It would be fine if there were the only scheduling pass. But for example for AArch64 there are 3 scheduling passes in the defaul

Re: [PATCH c/c++] use explicit locations for some warnings in c-pragma.c

2015-11-06 Thread Mike Stump
On Nov 4, 2015, at 1:02 PM, Manuel López-Ibáñez wrote: > 24:missing

Re: [PATCH][combine][RFC] Don't transform sign and zero extends inside mults

2015-11-06 Thread Jeff Law
On 11/06/2015 07:19 AM, Kyrill Tkachov wrote: I think we should also add: && REG_P (XEXP (XEXP (x, 0), 0)) && REG_P (XEXP (XEXP (x, 1), 0)) I tend to agree. Yep, see new patch. The "from == to" condition is for when subst is called just to simplify some code (normally with pc_rt

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-06 Thread Jeff Law
On 11/06/2015 12:30 PM, Bernd Schmidt wrote: On 11/06/2015 08:20 PM, Jeff Law wrote: So maybe what noce_mem_write_may_trap_or_fault_p is really trying to do is take objects where may_trap_or_fault_p returns false, but which in fact may fault if we write that memory? ie, working around lameness

[gomp4, committed] Remove unused DEF_ATTR_FOR_STRING and DEF_ATTR_TREE_LIST

2015-11-06 Thread Tom de Vries
Hi, this patch removes some unused DEF_ATTR_FOR_STRING and DEF_ATTR_TREE_LIST. Committed to gomp-4_0-branch. Thanks, - Tom Remove unused DEF_ATTR_FOR_STRING and DEF_ATTR_TREE_LIST 2015-11-06 Tom de Vries * builtin-attrs.def (DOT_DOT_DOT_r_r_r, DOT_DOT_DOT_DOT_r_r_r): Remove unused DEF_AT

Re: [AArch64] Fix vqtb[lx][234] on big-endian

2015-11-06 Thread Christophe Lyon
On 6 November 2015 at 18:03, James Greenhalgh wrote: > On Fri, Nov 06, 2015 at 02:49:38PM +0100, Christophe Lyon wrote: >> Hi, >> >> As mentioned by James a few weeks ago, the vqtbl[lx][234] intrinsics >> are failing on aarch64_be. >> >> The attached patch fixes them, and rewrites them using new b

Re: [OpenACC] declare directive

2015-11-06 Thread James Norris
On 11/06/2015 02:28 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 02:18:11PM -0600, James Norris wrote: On 11/06/2015 01:22 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: What exactly do you want to achieve? Why do you record it in gimplify_omp_ctx,

Re: [PATCH] [ARM] neon-testgen.ml typo

2015-11-06 Thread Christophe Lyon
On 4 November 2015 at 13:16, Ramana Radhakrishnan wrote: > On Fri, Oct 30, 2015 at 2:42 PM, Christophe Lyon > wrote: >> On 30 October 2015 at 15:33, Ramana Radhakrishnan >> wrote: >>> >>> >>> On 29/10/15 17:23, Jim Wilson wrote: I noticed a comment typo in this file while using grep to look

Re: [OpenACC] declare directive

2015-11-06 Thread Jakub Jelinek
On Fri, Nov 06, 2015 at 02:18:11PM -0600, James Norris wrote: > On 11/06/2015 01:22 PM, Jakub Jelinek wrote: > >On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: > >>What exactly do you want to achieve? Why do you record it > >>in gimplify_omp_ctx, but then only look at it in gimplify

Re: OpenACC declare directive updates

2015-11-06 Thread James Norris
Jakub, On 11/06/2015 01:49 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 01:45:09PM -0600, James Norris wrote: Okay, I'll fix this. After fixing, OK to commit? Thank you for taking the time for the review. Well, isn't this patch really dependent on the other one? Yes. Should I combine t

Re: [OpenACC] declare directive

2015-11-06 Thread James Norris
Jakub, On 11/06/2015 01:22 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: What exactly do you want to achieve? Why do you record it in gimplify_omp_ctx, but then only look at it in gimplify_body? The way you abuse gimplify_omp_ctx for that is just too u

Re: [OpenACC] declare directive

2015-11-06 Thread James Norris
Jakub, On 11/06/2015 01:03 PM, Jakub Jelinek wrote: On Fri, Nov 06, 2015 at 10:08:26AM -0600, James Norris wrote: 2015-10-27 James Norris Joseph Myers gcc/ * c-family/c-pragma.c (oacc_pragmas): Add entry for declare directive. * c-family/c-pragma.h (enu

[PATCH][AArch64] Add TARGET_IRA_CHANGE_PSEUDO_ALLOCNO_CLASS

2015-11-06 Thread Wilco Dijkstra
This patch adds support for the TARGET_IRA_CHANGE_PSEUDO_ALLOCNO_CLASS hook. When the cost of GENERAL_REGS and FP_REGS is identical, the register allocator always uses ALL_REGS even when it has a much higher cost. The hook changes the class to either FP_REGS or GENERAL_REGS depending on the mode of

Re: [PATCH 4b] diagnostic-show-locus.c changes: Insertions

2015-11-06 Thread David Malcolm
On Thu, 2015-10-29 at 22:49 -0600, Jeff Law wrote: > On 10/28/2015 12:09 PM, David Malcolm wrote: > > gcc/ChangeLog: > > * diagnostic-show-locus.c (struct point_state): New struct. > > (class colorizer): New class. > > (class layout_point): New class. > > (class layout_range): New c

Re: [patch] fix regrename pass to ensure renamings produce valid insns

2015-11-06 Thread Jeff Law
On 11/06/2015 03:48 AM, Bernd Schmidt wrote: On 06/17/2015 07:11 PM, Sandra Loosemore wrote: Index: gcc/regrename.c === --- gcc/regrename.c(revision 224532) +++ gcc/regrename.c(working copy) @@ -942,19 +942,22 @@ regrename_

Re: Allow matching of side effects in operand_equal_p

2015-11-06 Thread Jan Hubicka
> On Mon, 2 Nov 2015, Jan Hubicka wrote: > > > Hi, > > this patch adds OEP_MATCH_SIDE_EFFECT to tell operand_equal_p that the two > > operands compared are from different code paths and thus they can be matched > > even if they have side effects. > > > > I.e. > > > > volatile int a; > > > > if

Re: OpenACC declare directive updates

2015-11-06 Thread Jakub Jelinek
On Fri, Nov 06, 2015 at 01:45:09PM -0600, James Norris wrote: > Okay, I'll fix this. > > After fixing, OK to commit? > > Thank you for taking the time for the review. Well, isn't this patch really dependent on the other one? Also, wonder about BLOCK stmt in Fortran, that can give you variables

Re: OpenACC declare directive updates

2015-11-06 Thread James Norris
Jakub, On 11/06/2015 01:31 PM, Jakub Jelinek wrote: On Wed, Nov 04, 2015 at 06:32:00AM -0600, James Norris wrote: +/* Node in the linked list used for storing !$oacc declare constructs. */ + +typedef struct gfc_oacc_declare +{ + struct gfc_oacc_declare *next; + bool module_var; + gfc_omp_c

Re: [PATCH] PR54224 Warn for unused internal procedures -- update testcase

2015-11-06 Thread Jerry DeLisle
On 11/05/2015 01:48 AM, Dominique d'Humières wrote: > Is there any objection to commit the following (see comments 21 and 22)? > > Dominique > OK, simple.

Re: Unreviewed patch

2015-11-06 Thread Jeff Law
On 11/06/2015 06:29 AM, Rainer Orth wrote: The following patch has remained unrevied for a month: [build] Support init priority on Solaris https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00716.html It needs build and ia64 maintainers and someone familiar with the init priority su

Re: [RFA] Do not use libiberty's getpagesize on Android

2015-11-06 Thread DJ Delorie
> libiberty/ChangeLog: > > * configure.ac: Set AC_CV_FUNC_GETPAGESIZE to "yes" on > Android hosts. > * configure: Regenerate. > > OK to apply? Ok.

Re: Handle internal functions in is_tm_pure_call

2015-11-06 Thread Jeff Law
On 11/06/2015 12:15 PM, Richard Sandiford wrote: The upcoming changes to use internal functions for things like sqrt caused a failure in gcc.dg/tm/20100610.c, because we were trying to get call flags from the null gimple_call_fn of an IFN_SQRT call. We've been making fairly heavy use of internal

Re: OpenACC declare directive updates

2015-11-06 Thread Jakub Jelinek
On Wed, Nov 04, 2015 at 06:32:00AM -0600, James Norris wrote: > +/* Node in the linked list used for storing !$oacc declare constructs. */ > + > +typedef struct gfc_oacc_declare > +{ > + struct gfc_oacc_declare *next; > + bool module_var; > + gfc_omp_clauses *clauses; > + gfc_omp_clauses *retu

Re: regrename: Fix for earlyclobber operands

2015-11-06 Thread Jeff Law
On 11/06/2015 03:54 AM, Bernd Schmidt wrote: I have a patch which makes use of the renamer more often, and this exposed a bug with earlyclobber operands. The code that does the terminate_write step has the following comment: /* Step 5: Close open chains that overlap writes. Similar t

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 08:20 PM, Jeff Law wrote: So maybe what noce_mem_write_may_trap_or_fault_p is really trying to do is take objects where may_trap_or_fault_p returns false, but which in fact may fault if we write that memory? ie, working around lameness in may_trap_or_fault_p not knowing the context

Re: [Patch] Change to argument promotion in fixed conversion library calls

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 08:27 PM, Steve Ellcey wrote: Are you thinking of a simple function that is called on all targets or a target specific function? Maybe a target specific function would be safer. No, I think just what you have there is probably sufficient. Bernd

Re: [Patch] Change to argument promotion in fixed conversion library calls

2015-11-06 Thread Steve Ellcey
On Fri, 2015-11-06 at 20:14 +0100, Bernd Schmidt wrote: > > > + if (SCALAR_INT_MODE_P (from_mode)) > > +{ > > + /* If we need to promote the integer function argument we need to do > > Extra space at the start of the comment. > > > + it here instead of inside emit_library_call_va

Re: [OpenACC] declare directive

2015-11-06 Thread Jakub Jelinek
On Fri, Nov 06, 2015 at 08:03:52PM +0100, Jakub Jelinek wrote: > What exactly do you want to achieve? Why do you record it > in gimplify_omp_ctx, but then only look at it in gimplify_body? > The way you abuse gimplify_omp_ctx for that is just too ugly. > All the gimplification code expects that wh

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-06 Thread Jeff Law
On 11/06/2015 11:44 AM, Bernd Schmidt wrote: On 11/06/2015 07:39 PM, Jeff Law wrote: Given the name "..may_trap_or_fault_p" ISTM that its mode of operation should be to return true (the safe value) unless we can prove the write will not fault. The more cases we can prove true, the better AFAICT

Re: libgo patch committed: Update to Go 1.5 release

2015-11-06 Thread Ian Lance Taylor
On Fri, Nov 6, 2015 at 5:01 AM, Rainer Orth wrote: > Ian Lance Taylor writes: > >> I have committed a patch to libgo to update it to the Go 1.5 release. >> >> As usual for libgo updates, the actual patch is too large to attach to >> this e-mail message. I've attached the changes to the gccgo-sp

Re: [Patch] Change to argument promotion in fixed conversion library calls

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 08:04 PM, Steve Ellcey wrote: When I made this change I had one regression in the GCC testsuite (gcc.dg/fixed-point/convert-sat.c). I tracked this down to the fact that emit_library_call_value_1 does not do any argument promotion because it does not have the original tree type inf

Handle internal functions in is_tm_pure_call

2015-11-06 Thread Richard Sandiford
The upcoming changes to use internal functions for things like sqrt caused a failure in gcc.dg/tm/20100610.c, because we were trying to get call flags from the null gimple_call_fn of an IFN_SQRT call. We've been making fairly heavy use of internal functions for a while now so I think this might be

[Patch] Change to argument promotion in fixed conversion library calls

2015-11-06 Thread Steve Ellcey
This is part one of a two part patch I want to checkin in order to improve argument passing on MIPS. Right now MIPS defines TARGET_PROMOTE_PROTOTYPES as true and so short and char arguments are getting promoted in the caller and callee functions. The ABI requires callers to do the promotion and s

Re: [OpenACC] declare directive

2015-11-06 Thread Jakub Jelinek
On Fri, Nov 06, 2015 at 10:08:26AM -0600, James Norris wrote: > 2015-10-27 James Norris > Joseph Myers > > gcc/ > * c-family/c-pragma.c (oacc_pragmas): Add entry for declare directive. > * c-family/c-pragma.h (enum pragma_kind): Add PRAGMA_OACC_DECLARE. c-family/

Re: regrename: don't overflow insn_rr_info

2015-11-06 Thread Jeff Law
On 11/06/2015 04:08 AM, Bernd Schmidt wrote: This one is a fix for something that could currently only affect c6x, but I have code that exposes it on i386. When optionally gathering operand info in regrename, we can overflow the array in certain situations. This can occur when we have a situatio

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 07:39 PM, Jeff Law wrote: Given the name "..may_trap_or_fault_p" ISTM that its mode of operation should be to return true (the safe value) unless we can prove the write will not fault. The more cases we can prove true, the better AFAICT. The PLUS case looks totally wrong. Though

Re: improved RTL-level if conversion using scratchpads [half-hammock edition]

2015-11-06 Thread Jeff Law
On 11/06/2015 07:10 AM, Sebastian Pop wrote: On Fri, Nov 6, 2015 at 2:56 AM, Bernd Schmidt wrote: Formatting problem, here and in a few other places. I didn't fully read the patch this time around. I'm probably not reviewing further patches because I don't see this progressing to a state where

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-06 Thread Jeff Law
On 11/06/2015 10:21 AM, Bernd Schmidt wrote: The ifcvt scratchpad patch had some modifications to the function noce_mem_write_may_trap_or_fault_p in ifcvt, but as far as I can tell, that function itself makes no sense whatsoever. It returns true for MEM_READONLY_P which is sensible, but then it a

Revert "Add kernels-loop-nest-independent.f95"

2015-11-06 Thread Tom de Vries
Hi, this patch reverts aanother independent clause in oacc kernels region related test-case. Committed to gomp-4_0-branch. Thanks, - Tom Revert "Add kernels-loop-nest-independent.f95" 2015-07-15 Tom de Vries * gfortran.dg/goacc/kernels-loop-nest-independent.f95: New test. * testsuite/

[gomp4, committed] Revert "Add c-c++-common/goacc/kernels-loop-nest-independent.c"

2015-11-06 Thread Tom de Vries
Hi, this patch revert a independent clause in oacc kernels region related test-case. Committed to gomp-4_0-branch. Thanks, - Tom Revert "Add c-c++-common/goacc/kernels-loop-nest-independent.c" 2015-10-2 Tom de Vries Revert: 2015-07-15 Tom de Vries * c-c++-common/goacc/kernels-loop

[gomp4, committed] Revert "Use marked_independent in oacc kernels region"

2015-11-06 Thread Tom de Vries
Hi, this patch reverts the independent clause support in the oacc kernels region. The independent clause support is broken, in a subtle way. We currently set the marked_independent field in struct loop for loops with the independent clause in a kernels region. So that property holds for all

[PATCH] Do not allow irreducible loops/regions in a scop

2015-11-06 Thread Aditya Kumar
Irreducible regions are not going to be optimized by ISL so discard them early. Passes bootstrap and regtest. gcc/ChangeLog: 2015-11-06 Aditya Kumar * graphite-scop-detection.c (scop_detection::merge_sese): Entry and exit edges should not be a part of irreducible loop. (scop_

Patch for PR68106 was backported to gcc-5 branch

2015-11-06 Thread Vladimir Makarov
The following patch has been committed to gcc 5 branch as rev. 229868. The patch was bootstrapped and tested on x86/x86-64. Index: ChangeLog === --- ChangeLog (revision 229866) +++ ChangeLog (working copy) @@ -1,3 +1,12 @@ +2015-11

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

2015-11-06 Thread Nikolai Bozhenov
On 11/06/2015 08:09 PM, Kyrill Tkachov wrote: On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subr

Re: [PING][PATCH][4.9]Backport "Fix register corruption bug in ree"

2015-11-06 Thread Renlin Li
Hi Richard, I am trying to come up with a simple test case, but failed to do so. I have isolated the function where bug is triggered. However, in order to make it a useful test case, the silently corrupted register should be used somewhere, and should affect the correctness of the program. I

Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-06 Thread Bernd Schmidt
The ifcvt scratchpad patch had some modifications to the function noce_mem_write_may_trap_or_fault_p in ifcvt, but as far as I can tell, that function itself makes no sense whatsoever. It returns true for MEM_READONLY_P which is sensible, but then it also goes on an unreliable search through th

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

2015-11-06 Thread Kyrill Tkachov
On 06/11/15 17:09, Kyrill Tkachov wrote: On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subreg:SI

Re: [gomp4 05/14] omp-low: set 'omp target entrypoint' only on entypoints

2015-11-06 Thread Alexander Monakov
On Fri, 6 Nov 2015, Bernd Schmidt wrote: > On 10/30/2015 05:44 PM, Alexander Monakov wrote: > > + /* Ignore "omp target entrypoint" here: OpenMP target region functions > > are > > + called from gomp_nvptx_main. The corresponding kernel entry is > > emitted > > + from write_omp_entry. */

Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

2015-11-06 Thread Kyrill Tkachov
On 06/11/15 17:07, Nikolai Bozhenov wrote: On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subreg:SI (reg:DI 117) 4) (mult:SI (

Re: Re: [PATCH][ARM/AArch64] PR 68088: Fix RTL checking ICE due to subregs inside accumulator forwarding check

2015-11-06 Thread Nikolai Bozhenov
On 11/06/2015 04:46 PM, Ramana Radhakrishnan wrote: Hi! I faced the same issue but I had somewhat different RTL for the consumer: (insn 20 15 21 2 (set (reg/i:SI 0 r0) (minus:SI (subreg:SI (reg:DI 117) 4) (mult:SI (reg:SI 123) (reg:SI 114)

[PATCH][ARM] PR 49526: Add support for smmul,smmla,smmls instructions

2015-11-06 Thread Kyrill Tkachov
Hi all, This patch introduces support for the smmul, smmla and smmls instructions that appear in armv6 architecture levels and higher. To quote the SMMUL description from the ARMARM: "Signed Most Significant Word Multiply multiplies two signed 32-bit values, extracts the most significant 32 bit

Re: [AArch64] Fix vqtb[lx][234] on big-endian

2015-11-06 Thread James Greenhalgh
On Fri, Nov 06, 2015 at 02:49:38PM +0100, Christophe Lyon wrote: > Hi, > > As mentioned by James a few weeks ago, the vqtbl[lx][234] intrinsics > are failing on aarch64_be. > > The attached patch fixes them, and rewrites them using new builtins > instead of inline assembly. > > I wondered about

Re: [PATCH] Merge from gomp-4_5-branch to trunk

2015-11-06 Thread Martin Sebor
On 11/05/2015 09:08 PM, David Edelsohn wrote: Sorry for the incorrect blame. I thought the failure was due to GOMP changes, but it appears to be due to the placement new size changes. I am re-testing after Martin's fix. By the way, Martin, the ChangeLog entry is wrong I've fixed the ChangeLog

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-11-06 Thread Jakub Jelinek
On Fri, Nov 06, 2015 at 04:48:02PM +, Alan Lawrence wrote: > Sorry Jakub, can you clarify please, how to reproduce this failure? I've > just bootstrapped gcc-5-branch with ada and run the Ada testsuite, which has > build me gcc/ada/rts/libgnat{.a,.so,-5.so}, and I see all tests passing. > (Same

Re: [PATCH 1/2][ARM] PR/65956 AAPCS update for alignment attribute

2015-11-06 Thread Alan Lawrence
On 04/11/15 13:13, Jakub Jelinek wrote: On Mon, Jul 06, 2015 at 05:38:35PM +0100, Alan Lawrence wrote: Trying to push these now (svn!), patch 2 is going first. I realize my second iteration of patch 1/2, dropped the testcases from the first version. Okay to include those as per https://gcc.gnu.

Re: [PATCH] Merge from gomp-4_5-branch to trunk

2015-11-06 Thread Thomas Schwinge
Hi! On Fri, 6 Nov 2015 12:15:01 +0100, I wrote: > On Thu, 5 Nov 2015 10:41:41 -0500, Nathan Sidwell wrote: > > On 11/05/15 10:29, Jakub Jelinek wrote: > > > I've merged the current state of gomp-4_5-branch into trunk, after > > > bootstrapping/regtesting it on x86_64-linux and i686-linux. > > > >

Re: [PATCH] Fix PR ipa/68035

2015-11-06 Thread Jan Hubicka
> Hello. > > Following patch triggers hash calculation of items (functions and variables) > in situations where LTO mode is not utilized. > > Patch survives regression tests and bootstraps on x86_64-linux-pc. > > Ready for trunk? > Thanks, > Martin > >From 62266e21a89777c6dbd680f7c87f15abe603c0

[RFA] Do not use libiberty's getpagesize on Android

2015-11-06 Thread Joel Brobecker
Hello, Building libiberty on Android currently fails with the error message shown below. This was discovered by trying to build GDBserver for Android, which stopped building after libiberty became a GDBserver dependency. Here is the error message: [...]/getpagesize.c:64:1: error: redefinition o

Re: Move constant bitop and bswap folds to fold-const-call.c

2015-11-06 Thread Richard Biener
On November 6, 2015 4:12:56 PM GMT+01:00, Richard Sandiford wrote: >The only folds left in builtins.c were for constants, so we can remove >the builtins.c handling entirely. > >Tested on x86_64-linux-gnu, aarch64-linux-gnu and arm-linux-gnueabi. >OK to install? OK. >Thanks, >Richard > > >gcc/ >

Re: Add -fno-math-errno to gcc.dg/lto/20110201-1_0.c

2015-11-06 Thread Richard Biener
On November 6, 2015 3:34:22 PM GMT+01:00, Richard Sandiford wrote: >At the moment the ECF_* flags for a gimple call to a built-in >function are derived from the function decl, which in turn is >derived from the global command-line options. So if the compiler >is run with -fno-math-errno, we alwa

Re: [PATCH 6/6] Make SRA replace constant-pool loads

2015-11-06 Thread Richard Biener
On November 5, 2015 7:55:12 PM GMT+01:00, Alan Lawrence wrote: >On 3 November 2015 at 14:01, Richard Biener > wrote: >> >> Hum. I still wonder why we need all this complication ... > >Well, certainly I'd love to make it simpler, and if the complication >is because I've gone about trying to deal

Re: improved RTL-level if conversion using scratchpads [half-hammock edition]

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 04:52 PM, Sebastian Pop wrote: opinion). If you want a half-finished redzone allocator, I can send you a patch. Yes please. Let's get it work. Here you go. This is incomplete and does not compile, but it shows the direction I have in mind and isn't too far off. I had a simila

Re: Move #undef DEF_INTERNAL_FN to internal-fn.def

2015-11-06 Thread Jeff Law
On 11/06/2015 08:30 AM, Richard Sandiford wrote: In practice the definition of DEF_INTERNAL_FN is never reused after including internal-fn.def, so we might as well #undef it there. This becomes more obvious with a later patch that adds other DEF_INTERNAL_* directives, such as DEF_INTERNAL_OPTAB_

Re: Move #undef DEF_BUILTIN* to builtins.def

2015-11-06 Thread Jeff Law
On 11/06/2015 08:35 AM, Richard Sandiford wrote: I was confused at first why tree-core.h was undefining DEF_BUILTIN_CHKP before defining it, then undefining it again after including builtins.def. This is because builtins.def provides a default definition of DEF_BUILTIN_CHKP, but leaves it up to t

Re: [OpenACC] declare directive

2015-11-06 Thread James Norris
On 11/06/2015 10:08 AM, James Norris wrote: Thomas, I've added the issues that you pointed out. Attached is the updated patch and ChangeLog. Thanks for taking the time for your review! Errr, make that 'addressed the issues that you pointed out." Opps, Jim

Re: [vec-cmp, patch 1/6] Add optabs for vector comparison

2015-11-06 Thread Jeff Law
On 11/05/2015 09:01 AM, Ilya Enkovich wrote: 2015-10-27 23:52 GMT+03:00 Jeff Law : Sigh. I searched for the enum type, not for CODE_FOR_nothing ;( My bad. If it's easy to get rid of, yes. I believe we've got 3 uses of CODE_FOR_nothing. AFAICT in none of those cases do we care about the cod

Re: [PATCH] Make BB vectorizer work on sub-BBs

2015-11-06 Thread Jeff Law
On 11/06/2015 04:09 AM, Richard Biener wrote: On Fri, 6 Nov 2015, Richard Biener wrote: The following patch makes the BB vectorizer not only handle BB heads (until the first stmt with a data reference it cannot handle) but arbitrary regions in a BB separated by such stmts. This improves the n

Re: [PATCH] Fix PR68067

2015-11-06 Thread Jeff Law
On 11/06/2015 05:26 AM, Richard Biener wrote: On Fri, 6 Nov 2015, Alan Lawrence wrote: On 06/11/15 10:39, Richard Biener wrote: ../spec2000/benchspec/CINT2000/254.gap/src/polynom.c:358:11: error: location references block not in block tree l1_279 = PHI <1(28), l1_299(33)> ^^^ this is the er

Re: [OpenACC] declare directive

2015-11-06 Thread James Norris
Thomas, I've added the issues that you pointed out. Attached is the updated patch and ChangeLog. Thanks for taking the time for your review! Jakub, Could you queue this patch ahead of my other one for today? If it doesn't pass review, I'd like to work the weekend and have the updated patch rea

[Obivous][testsuite,aarch64/arm] Fix typo

2015-11-06 Thread Christophe Lyon
Hi, I've committed the attached fix for a comment in gcc.target/aarch64/advsimd-intrinsics/vtbX.c. (as revision 229858) Christophe. 2015-11-06 Christophe Lyon * gcc.target/aarch64/advsimd-intrinsics/vtbX.c: Fix typos in comment. ===

Re: Handle constant fp classifications in fold-const-call.c

2015-11-06 Thread Bernd Schmidt
On 11/06/2015 04:08 PM, Richard Sandiford wrote: Move the constant "is finite", "is infinite" and "is nan" queries to fold-const-call.c. I kind of missed it when that file was added, but I'm assuming it's the correct direction for things to move. Ok. Bernd

  1   2   3   >