Re: [PATCH] fold builtin_tolower, builtin_toupper

2015-07-09 Thread Ondřej Bílka
On Thu, Jul 09, 2015 at 03:46:08PM +0200, Richard Biener wrote: > On Thu, 9 Jul 2015, Bernhard Reutner-Fischer wrote: > > > gcc/ChangeLog > > > > 2015-07-09 Bernhard Reutner-Fischer > > > > * builtins.c (fold_builtin_tolower, fold_builtin_toupper): New > > static functions. > > (f

Re: [PATCH] Simple optimization for MASK_STORE.

2015-07-09 Thread Jeff Law
On 06/18/2015 08:32 AM, Yuri Rumyantsev wrote: Richard, Here is updated patch which does not include your proposal related to the target hook deletion. You wrote: I still don't understand why you need the new target hook. If we have a masked load/store then the mask is computed by an assignmen

Re: [PATCH 3/7] Fix trinary op

2015-07-09 Thread Mikhail Maltsev
On 08.07.2015 13:55, Ian Lance Taylor wrote: > I don't know of anybody who actually uses the DMGL_TYPES support. I > don't know why anybody would. > > Ian Thanks for pointing that out. I updated the testcases, so that now they don't depend on DMGL_TYPES being used. > But better still is to consi

Re: [gomp] Move openacc vector& worker single handling to RTL

2015-07-09 Thread Nathan Sidwell
This is the patch I committed. Bernd pointed out that I didn't need to be so coy about the branches in the middle of blocks at that point of the compilation anyway. So we remove a couple of unneeded insn patterns. nathan 2015-07-09 Nathan Sidwell Infrastructure: * gimple.

Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-09 Thread Kugan
On 08/07/15 00:41, Jeff Law wrote: > On 07/07/2015 06:50 AM, Kugan wrote: >> >> Thanks for the review. I have addressed your comments above in the >> attached patch. >> >> I have one question with respect to unary operation. For generic unary >> operation with INTEGER_CST, do we skip this or do w

Re: [RFC, PATCH] Split pool_allocator and create a new object_allocator

2015-07-09 Thread Martin Liška
On 07/03/2015 06:18 PM, Richard Sandiford wrote: Hi Martin, Martin Liška writes: On 07/03/2015 03:07 PM, Richard Sandiford wrote: Martin Jambor writes: On Fri, Jul 03, 2015 at 09:55:58AM +0100, Richard Sandiford wrote: Trevor Saunders writes: On Thu, Jul 02, 2015 at 09:09:31PM +0100, Ric

Re: [C++ Patch] PR 61491 (aka DR 1206)

2015-07-09 Thread Paolo Carlini
Hi, On 07/09/2015 10:53 PM, Jason Merrill wrote: On 07/09/2015 03:36 PM, Paolo Carlini wrote: Finally, we do *not* reject, as we should, the line: template<> enum A::E : char { echar }; Then, overall, is it Ok to simply suppress the pedwarn in C++11, and xfail for now the error? Should I open

Re: [patch] Fix PR middle-end/66633

2015-07-09 Thread Jakub Jelinek
On Mon, Jun 29, 2015 at 11:23:24AM +0200, Eric Botcazou wrote: > > Don't you need to handle convert_nonlocal_omp_clauses similarly (need_chain > > in that case)? > > At least looking at your r211308 commit, for !optimize you force not just > > the frame, but also chain. > > You're very likely righ

[PATCH] Fix OpenMP ICE due to fold_stmt (PR middle-end/66820)

2015-07-09 Thread Jakub Jelinek
Hi! As discussed on IRC, we have a problem because fold_stmt can call force_gimple_operand_1, which in turn does push_gimplify_context/pop_gimplify_context (NULL), even when inside of some gimplify_ctxp and thus pushes the decls into function context rather than the current gimplify_ctxp. So far

Re: RFC: Add ADDR_EXPR lowering (PR tree-optimization/66718)

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 11:21:01AM +0200, Jakub Jelinek wrote: > > Hmm, this looks like it could be split out to a function. > > Ok, will try that. Here is what I've committed after another bootstrap/regtest on x86_64-linux and i686-linux. You're right, the separate function cleaned stuff up. 2

Re: [patch] testsuite enable PIE tests on DragonFly

2015-07-09 Thread Andreas Tobler
On 09.07.15 17:30, Jeff Law wrote: On 07/09/2015 07:53 AM, John Marino wrote: DragonFly supports PIE but the tests for it are disabled. The attached patch for the trunk will enable these checks on DragonFly. Thanks for considering this! John p.s. suggested gcc/testsuite/changelog entry: 2015-

Re: [PATCH] PR target/66824: -miamcu doesn't load FP constant into register directly

2015-07-09 Thread H.J. Lu
On Thu, Jul 09, 2015 at 12:13:38PM -0700, H.J. Lu wrote: > ix86_split_long_move can optimize floating point constant move, which > can be used to optimize SFmode move for IA MCU. > > OK for trunk if there is no regression? > > > H.J. > --- > gcc/ > > PR target/66824 > * config/i386/

Re: [PATCH] Fix PR c++/30044

2015-07-09 Thread Jason Merrill
OK, thanks. Jason

Re: [C++ Patch] PR 61491 (aka DR 1206)

2015-07-09 Thread Jason Merrill
On 07/09/2015 03:36 PM, Paolo Carlini wrote: Finally, we do *not* reject, as we should, the line: template<> enum A::E : char { echar }; Then, overall, is it Ok to simply suppress the pedwarn in C++11, and xfail for now the error? Should I open a new, separate bug report about the latter? (note

Re: [PATCH 6/6] Migrate ipa-pure-const to function_summary.

2015-07-09 Thread Martin Liška
On 07/09/2015 07:44 PM, Jeff Law wrote: On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * ipa-pure-const.c (struct funct_state_d): New. (funct_state_d::default_p): Likewise. (has_function_state): Remove. (get_function_state): Likewise. (set_f

Re: [PATCH 5/6] Port IPA reference to function_summary infrastructure.

2015-07-09 Thread Martin Liška
On 07/09/2015 07:35 PM, Jeff Law wrote: On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * ipa-reference.c (ipa_ref_opt_summary_t): New class. (get_reference_optimization_summary): Use it. (set_reference_optimization_summary): Likewise. (ipa_init)

Re: [PATCH 2/6] Introduce new edge_summary class and replace ipa_edge_args_sum.

2015-07-09 Thread Martin Liška
On 07/09/2015 07:15 PM, Jeff Law wrote: On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * cgraph.c (symbol_table::create_edge): Introduce summary_uid for cgraph_edge. * cgraph.h (struct GTY): Likewise. * ipa-inline-analysis.c (estimate_function_b

Re: [PATCH] Adjust variable shift costs for IA MCU

2015-07-09 Thread H.J. Lu
On Thu, Jul 9, 2015 at 1:30 PM, Uros Bizjak wrote: > On Thu, Jul 9, 2015 at 8:05 PM, H.J. Lu wrote: >> We reduce code size for IA MCU by adjusting variable shift costs for IA >> MCU. OK for trunk? > > IMO, tuning patches should fall into "obvious" category. I don't have > any data to to do any m

Re: [PATCH] Adjust variable shift costs for IA MCU

2015-07-09 Thread Uros Bizjak
On Thu, Jul 9, 2015 at 8:05 PM, H.J. Lu wrote: > We reduce code size for IA MCU by adjusting variable shift costs for IA > MCU. OK for trunk? IMO, tuning patches should fall into "obvious" category. I don't have any data to to do any meaningful review of a cost metric for a new target. So, inst

Re: [PATCH, i386]: Fix PR 66814, ICE: gcc.target/i386/avx512f-klogic-2.c

2015-07-09 Thread Uros Bizjak
On Thu, Jul 9, 2015 at 10:17 PM, Jakub Jelinek wrote: > On Thu, Jul 09, 2015 at 10:13:49PM +0200, Uros Bizjak wrote: >> I was under impression that peephole2 pass doesn't see subregs of hard >> regs (all x86 predicates are written in this way). Even documentation >> somehow agrees with this: >> >>

Proposal to postpone release of 5.2 for a week [Was: Re: patch to fix PR66782]

2015-07-09 Thread Uros Bizjak
Hello! > The patch was bootstrapped and tested on x86/x86-64. > > Committed as rev. 225618. > > 2015-07-09 Vladimir Makarov > > PR rtl-optimization/66782 > * lra-int.h (struct lra_insn_recog_data): Add comment about > clobbered hard regs for arg_hard_regs. > * lr

Re: [PATCH, i386]: Fix PR 66814, ICE: gcc.target/i386/avx512f-klogic-2.c

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 10:13:49PM +0200, Uros Bizjak wrote: > I was under impression that peephole2 pass doesn't see subregs of hard > regs (all x86 predicates are written in this way). Even documentation > somehow agrees with this: > > '(subreg:M1 REG:M2 BYTENUM)' > > 'subreg' expressions a

Re: Tests for libgomp based on OpenMP Examples 4.0.2.

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 05:23:36PM +0300, Maxim Blumental wrote: > Now the patch is corrected (according to the previous letter) and > ready to be reviewed. I'm looking forward to your feedback. Ok, I guess while the filenames are still different, it is quite easily possible to find corresponding

Re: [PATCH, i386]: Fix PR 66814, ICE: gcc.target/i386/avx512f-klogic-2.c

2015-07-09 Thread Uros Bizjak
On Thu, Jul 9, 2015 at 9:38 PM, Jakub Jelinek wrote: > On Thu, Jul 09, 2015 at 05:22:33PM +0200, Uros Bizjak wrote: >> Hello! >> >> This ICE was caused by a peephole2 pattern that allowed non-general >> regs arguments. >> >> 2015-07-08 Uros Bizjak >> >> PR target/66814 >> * config/i386/

Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386

2015-07-09 Thread Jeff Law
On 06/01/2015 06:26 AM, Ilya Enkovich wrote: 2015-05-29 1:15 GMT+03:00 Jeff Law : Right, but you're blindly propagating. The right thing to do is look at some kind of metric to estimate when it's profitable to propagate the constant back in vs leave it hoisted out. No, the patch is not to bl

Re: [RFC, Fortran, (pr66775)] Allocatable function result

2015-07-09 Thread Steve Kargl
On Thu, Jul 09, 2015 at 08:59:08PM +0200, Andre Vehreschild wrote: > Hi Steve, > > Thanks for your knowledge. Can you support your statement that an allocatable > function has to return an allocated object by a part of the standard? I > totally agree with you that this code is ill-designed, but

Re: [PATCH, i386]: Fix PR 66814, ICE: gcc.target/i386/avx512f-klogic-2.c

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 05:22:33PM +0200, Uros Bizjak wrote: > Hello! > > This ICE was caused by a peephole2 pattern that allowed non-general > regs arguments. > > 2015-07-08 Uros Bizjak > > PR target/66814 > * config/i386/predicates.md (nonimmediate_gr_operand): New predicate. >

RE: [Patch, MIPS] Fix SYSROOT_SUFFIX_SPEC for mips-mti-linux-gnu

2015-07-09 Thread Matthew Fortune
> 2015-07-09 Steve Ellcey > > * config/mips/mti-linux.h (MIPS_SYSVERSION_SPEC): Update > to handle mips[32|64]r3 and mips[32|64]r5. OK, thanks. Matthew

Re: [C++ Patch] PR 61491 (aka DR 1206)

2015-07-09 Thread Paolo Carlini
Hi, On 07/09/2015 06:33 PM, Jason Merrill wrote: On 07/09/2015 12:09 PM, Paolo Carlini wrote: the DR got resolved in time for C++11 and Jonathan noticed that we should remove the pedwarn, not a big deal. Tested x86_64-linux. How about adding the testcase from the DR as well? OK with that cha

[gomp4.1] depend(sink) and depend(source) parsing for C

2015-07-09 Thread Aldy Hernandez
The following patch goes along with Jakub's parsing of ordered(n) loops. With it, we can now parse his testcase, along with a variety of other tests with appropriate diagnostics. The lowering to gimple is still not done, as we should agree on what needs to be emitted first. I'll follow up w

[PATCH] PR target/66824: -miamcu doesn't load FP constant into register directly

2015-07-09 Thread H.J. Lu
ix86_split_long_move can optimize floating point constant move, which can be used to optimize SFmode move for IA MCU. OK for trunk if there is no regression? H.J. --- gcc/ PR target/66824 * config/i386/i386.c (ix86_split_to_parts): Allow SFmode move for IA MCU. (

Re: [RFC, Fortran, (pr66775)] Allocatable function result

2015-07-09 Thread Andre Vehreschild
Hi Steve, Thanks for your knowledge. Can you support your statement that an allocatable function has to return an allocated object by a part of the standard? I totally agree with you that this code is ill-designed, but IMO is it not the task of the compiler to address ill design. The compiler h

Re: [gomp4.1] depend(sink) and depend(source) parsing for C

2015-07-09 Thread Jakub Jelinek
Hi! On Thu, Jul 09, 2015 at 11:24:44AM -0700, Aldy Hernandez wrote: Thanks for working on it. > + wide_int offset = wi::neg (addend, &overflow); > + addend = wide_int_to_tree (TREE_TYPE (addend), offset); > + if (overflow) > + warning_at (c_parser_peek_t

[PATCH] Adjust variable shift costs for IA MCU

2015-07-09 Thread H.J. Lu
We reduce code size for IA MCU by adjusting variable shift costs for IA MCU. OK for trunk? Thanks. H.J. --- PR target/66821 * config/i386/i386.c (iamcu_cost): Adjust variable shift costs. --- gcc/config/i386/i386.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Andrew MacLeod
On 07/09/2015 01:49 PM, Jeff Law wrote: On 07/09/2015 11:06 AM, Andrew MacLeod wrote: The total result affect 227 files. Now, predict.h is *still* more pervasive than it needs to be, but thats a different patch :-). There are a set of routines in there like optimize_{fucntion,loop,edge,bb}_f

Re: [RFC, Fortran, (pr66775)] Allocatable function result

2015-07-09 Thread Steve Kargl
On Thu, Jul 09, 2015 at 12:25:18PM +0200, Andre Vehreschild wrote: > > I need your help on how to interpret the standard(s) or how to > implement handling an allocatable function's result, when that > result is not allocated by the function. Imagine the simple > (albeit artificial) case: > > int

Small C++ PATCH to instantiation_dependent_r for TRAIT_EXPR

2015-07-09 Thread Jason Merrill
There's no reason we should have the logic for whether a TRAIT_EXPR is value-dependent in two places. Tested x86_64-pc-linux-gnu, applying to trunk. commit fcd3802b2b88251b6c0dea63b38e6f269be7713d Author: Jason Merrill Date: Tue Jul 7 23:49:21 2015 -0400 * pt.c (instantiation_dependent_

Re: [PATCH] Remove duplicate graphite statistics printers

2015-07-09 Thread Jeff Law
On 07/09/2015 11:48 AM, Bernhard Reutner-Fischer wrote: On July 9, 2015 6:48:39 PM GMT+02:00, Jeff Law wrote: On 07/09/2015 10:30 AM, Bernhard Reutner-Fischer wrote: Thanks, gcc/ChangeLog 2015-07-09 Bernhard Reutner-Fischer * graphite.h: New file. (print_graphite_statist

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Jeff Law
On 07/09/2015 11:06 AM, Andrew MacLeod wrote: On 07/08/2015 10:42 PM, Andrew MacLeod wrote: On 07/08/2015 06:43 PM, Jeff Law wrote: predict.h is actually required by gimple.h for a few reasons, enum be_predictor is used in parameter lists and a few inlines use the TAKEN, NOT_TAKEN macros Its al

Re: [PATCH] Remove duplicate graphite statistics printers

2015-07-09 Thread Bernhard Reutner-Fischer
On July 9, 2015 6:48:39 PM GMT+02:00, Jeff Law wrote: >On 07/09/2015 10:30 AM, Bernhard Reutner-Fischer wrote: >> >> Thanks, >> >> gcc/ChangeLog >> >> 2015-07-09 Bernhard Reutner-Fischer >> >> * graphite.h: New file. >> (print_graphite_statistics): Extern declaration. >> * graphi

C++ PATCHes to template parameter parsing

2015-07-09 Thread Jason Merrill
The first patch is a cleanup hoisted from the c++-concepts branch: on the branch we want to be able to parse type/template in multiple places, so Andrew factored that out, but it's a good code cleanup on the trunk as well. While looking at this and related code on the branch, I noticed that t

Re: [PATCH 6/6] Migrate ipa-pure-const to function_summary.

2015-07-09 Thread Jeff Law
On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * ipa-pure-const.c (struct funct_state_d): New. (funct_state_d::default_p): Likewise. (has_function_state): Remove. (get_function_state): Likewise. (set_function_state): Likew

Re: [PATCH 4/6] Port ipa-cp to use cgraph_edge summary.

2015-07-09 Thread Jeff Law
On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * ipa-cp.c (struct edge_clone_summary): New structure. (class edge_clone_summary_t): Likewise. (edge_clone_summary_t::initialize): New method. (edge_clone_summary_t::duplicate): Likew

Re: [PATCH] ipa-icf.c: Fix typo in dump file

2015-07-09 Thread Jeff Law
On 07/09/2015 11:32 AM, Bernhard Reutner-Fischer wrote: gcc/ChangeLog 2015-07-09 Bernhard Reutner-Fischer * ipa-icf.c (sem_item_optimizer::do_congruence_step): Fix typo in dump message. Ok for trunk if testing passes? Hmz, that's obvious, will commit tomorrow after the regst

Re: [PATCH 5/6] Port IPA reference to function_summary infrastructure.

2015-07-09 Thread Jeff Law
On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * ipa-reference.c (ipa_ref_opt_summary_t): New class. (get_reference_optimization_summary): Use it. (set_reference_optimization_summary): Likewise. (ipa_init): Remove hook holders usa

[PATCH] ipa-icf.c: Fix typo in dump file

2015-07-09 Thread Bernhard Reutner-Fischer
gcc/ChangeLog 2015-07-09 Bernhard Reutner-Fischer * ipa-icf.c (sem_item_optimizer::do_congruence_step): Fix typo in dump message. Ok for trunk if testing passes? Hmz, that's obvious, will commit tomorrow after the regstrap during night. --- gcc/ipa-icf.c | 2 +- 1 file change

Re: [PATCH 3/6] IPA inline: port inline_edge_summary to a new infrastructure.

2015-07-09 Thread Jeff Law
On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * ipa-inline-analysis.c (inline_edge_summaries): New data structure. (redirect_to_unreachable): Use renamed function get_inline_edge_summary. (edge_set_predicate): Likewise.

Re: [PATCH 2/6] Introduce new edge_summary class and replace ipa_edge_args_sum.

2015-07-09 Thread Jeff Law
On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * cgraph.c (symbol_table::create_edge): Introduce summary_uid for cgraph_edge. * cgraph.h (struct GTY): Likewise. * ipa-inline-analysis.c (estimate_function_body_sizes): Use n

[Patch, MIPS] Fix SYSROOT_SUFFIX_SPEC for mips-mti-linux-gnu

2015-07-09 Thread Steve Ellcey
This patch enables builds with mips[32|64]r3 and mips[32|64]r5 in the mips-mti-linux-gnu toolchain. t-mti-linux uses MULTILIB_MATCHES to map these to r2 but SYSROOT_SUFFIX_SPEC was not being set properly to find the sysroot (the r2 one) for these architectures. This patch fixes that problem by up

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Andrew MacLeod
On 07/08/2015 10:42 PM, Andrew MacLeod wrote: On 07/08/2015 06:43 PM, Jeff Law wrote: predict.h is actually required by gimple.h for a few reasons, enum be_predictor is used in parameter lists and a few inlines use the TAKEN, NOT_TAKEN macros Its also needed by cfghooks.h, and betwen those 2 f

Re: [PATCH 1/6] hash_set: add iterator and remove method.

2015-07-09 Thread Jeff Law
On 07/09/2015 03:13 AM, mliska wrote: gcc/ChangeLog: 2015-07-03 Martin Liska * hash-set.h (remove): New function. (iterator): New iteration class for hash_set. OK. jeff

Re: [PATCH] Remove duplicate graphite statistics printers

2015-07-09 Thread Jeff Law
On 07/09/2015 10:30 AM, Bernhard Reutner-Fischer wrote: Thanks, gcc/ChangeLog 2015-07-09 Bernhard Reutner-Fischer * graphite.h: New file. (print_graphite_statistics): Extern declaration. * graphite-scop-detection.c (print_graphite_scop_statistics, print_grap

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-09 Thread Jeff Law
On 07/09/2015 03:19 AM, Tom de Vries wrote: On 09/07/15 05:33, Jeff Law wrote: On 07/07/2015 09:58 AM, Tom de Vries wrote: [Big snip] 0001-Add-rewrite_virtuals_into_loop_closed_ssa.patch Add rewrite_virtuals_into_loop_closed_ssa 2015-07-07 Tom de Vries * tree-cfg.c (get_virtual_phi):

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jeff Law
On 07/09/2015 09:41 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 09:34:25AM -0600, Jeff Law wrote: On 07/09/2015 08:13 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: --- gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2

Re: [C++ Patch] PR 61491 (aka DR 1206)

2015-07-09 Thread Jason Merrill
On 07/09/2015 12:09 PM, Paolo Carlini wrote: the DR got resolved in time for C++11 and Jonathan noticed that we should remove the pedwarn, not a big deal. Tested x86_64-linux. How about adding the testcase from the DR as well? OK with that change. Jason

[PATCH] Remove duplicate graphite statistics printers

2015-07-09 Thread Bernhard Reutner-Fischer
graphite-scop-detection.c contained a copy of graphite.c print_graphite_statistics() and print_graphite_scop_statistics(). The latter gained a parameter to distinguish \nBefore limit_scops SCoP statistics ( from \nSCoP statistics ( Note that previously the version in gimple.c was never called (AF

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-09 Thread Jeff Law
On 07/08/2015 08:42 PM, Andrew MacLeod wrote: blah, not so trivial. One of the primary things predict.h does is create enum br_predictor by including predict,def.. so moving that enum doesnt really make sense. Fixing gimple,h isn't too bad, I could split the prediction stuff out into gimple-pre

Re: [PATCH 1/3] tree-ssa-tail-merge: add IPA ICF infrastructure.

2015-07-09 Thread Jeff Law
On 07/09/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-07-09 Martin Liska * dbgcnt.def: Add new debug counter. * ipa-icf-gimple.c (func_checker::compare_ssa_name): Add flag for strict mode. (func_checker::compare_memory_operand): Likewise. (func_che

[C++ Patch] PR 61491 (aka DR 1206)

2015-07-09 Thread Paolo Carlini
Hi, the DR got resolved in time for C++11 and Jonathan noticed that we should remove the pedwarn, not a big deal. Tested x86_64-linux. Thanks, Paolo. // /cp 2015-07-09 Paolo Carlini PR c++/61491 * pt.c (maybe_process_partial_specialization): Allow enum temp

Re: Merge DEF_GOACC_BUILTIN into DEF_GOMP_BUILTIN? (was: OpenACC middle end changes)

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 05:52:20PM +0200, Thomas Schwinge wrote: > --- gcc/builtins.def > +++ gcc/builtins.def > @@ -182,7 +182,9 @@ along with GCC; see the file COPYING3. If not see > #define DEF_GOMP_BUILTIN(ENUM, NAME, TYPE, ATTRS) \ >DEF_BUILTIN (ENUM, "__builtin_" NAME, BUILT_IN_NORMAL,

[PATCH] fix PR46029: reimplement if conversion of loads and stores [3nd submitted version of patch]

2015-07-09 Thread Abe
Below, please find the 3nd submitted version of this patch, now with some more issues resolved. Regards, Abe From 87af575347e216672e322bbc1b4ae0a5ab93507f Mon Sep 17 00:00:00 2001 From: Abe Date: Mon, 18 May 2015 14:26:29 -0500 Subject: [PATCH] fix PR46029: reimplement if conversion of lo

Merge DEF_GOACC_BUILTIN into DEF_GOMP_BUILTIN? (was: OpenACC middle end changes)

2015-07-09 Thread Thomas Schwinge
Hi! On Thu, 13 Nov 2014 19:09:49 +0100, Jakub Jelinek wrote: > On Thu, Nov 13, 2014 at 05:59:11PM +0100, Thomas Schwinge wrote: > > * should gcc/oacc-builtins.def just be merged into > > gcc/omp-builtins.def; > > Why not. The reason why they aren't in gcc/builtins.def is that > the Fortra

patch to fix PR66782

2015-07-09 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66782 The patch was bootstrapped and tested on x86/x86-64. Committed as rev. 225618. 2015-07-09 Vladimir Makarov PR rtl-optimization/66782 * lra-int.h (struct lra_insn_recog_data): Add comment about

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 09:34:25AM -0600, Jeff Law wrote: > On 07/09/2015 08:13 AM, Jakub Jelinek wrote: > >On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: > >>--- > >> gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- > >> gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- > >> gcc/testsuite/g++.dg/ub

[PATCH] [testsuite] Disable attr_thumb.c test when Thumb mode is not supported.

2015-07-09 Thread Christophe Lyon
Some multilibs do not support Thumb mode on ARM targets. This is the case for instance when target is arm-linux-gnueabihf and with -march=armv5-t: Thumb-1 hard-float VFP ABI is not implemented. In this configuration, gcc.target/arm/attr_thumb.c is failing because we switch thumb mode via an attrib

Re: [PATCH 2/3] Fully remove legacy tree-ssa-tail-merge value numbering infrastructure.

2015-07-09 Thread Jeff Law
On 07/09/2015 07:56 AM, mliska wrote: gcc/ChangeLog: 2015-07-09 Martin Liska * tree-ssa-tail-merge.c (gimple_operand_equal_value_p): Remove. (gimple_equal_p): Remove. (gsi_advance_bw_nondebug_nonlocal): Remove. (find_duplicate): Remove legacy value numbering.

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jeff Law
On 07/09/2015 08:13 AM, Jakub Jelinek wrote: On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: --- gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) I'd

Re: [RFC, PATCH 0/3] tree-ssa-tail-merge engine replacement

2015-07-09 Thread Jeff Law
On 07/09/2015 08:03 AM, mliska wrote: Hello. It's going to be almost a year Richard advised me to utilize IPA ICF infrastructure in tree-ssa-tail-merge, currently using value numbering which is quite hard to maintain. Following small patch set is kick-off and I am opened for advices. Meanwhile,

Re: [patch] testsuite enable PIE tests on DragonFly

2015-07-09 Thread Jeff Law
On 07/09/2015 07:53 AM, John Marino wrote: DragonFly supports PIE but the tests for it are disabled. The attached patch for the trunk will enable these checks on DragonFly. Thanks for considering this! John p.s. suggested gcc/testsuite/changelog entry: 2015-07-XX John Marino * lib/

Re: genmatch indent generated code

2015-07-09 Thread Michael Matz
Hi, On Thu, 9 Jul 2015, Jakub Jelinek wrote: > That violates the coding style by not using tabs ;) I knew it! Somebody would notice, pffft. Fixed in the committed version. Ciao, Michael. PS: this still isn't fully correct, as sometimes I start the strings with spaces which don't count towar

[PATCH, i386]: Fix PR 66814, ICE: gcc.target/i386/avx512f-klogic-2.c

2015-07-09 Thread Uros Bizjak
Hello! This ICE was caused by a peephole2 pattern that allowed non-general regs arguments. 2015-07-08 Uros Bizjak PR target/66814 * config/i386/predicates.md (nonimmediate_gr_operand): New predicate. * config/i386/i386.md (not peephole2): Use nonimmediate_gr_operand. (varous p

Re: genmatch indent generated code

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 02:20:08PM +0200, Michael Matz wrote: > +/* Like fprintf, but print INDENT spaces at the beginning. */ > + > +static void > +#if GCC_VERSION >= 4001 > +__attribute__((format (printf, 3, 4))) > +#endif > +fprintf_indent (FILE *f, unsigned int indent, const char *format, ...)

Re: [PATCH] fold builtin_tolower, builtin_toupper

2015-07-09 Thread Bernhard Reutner-Fischer
On 9 July 2015 at 15:46, Richard Biener wrote: > On Thu, 9 Jul 2015, Bernhard Reutner-Fischer wrote: > >> gcc/ChangeLog >> >> 2015-07-09 Bernhard Reutner-Fischer >> >> * builtins.c (fold_builtin_tolower, fold_builtin_toupper): New >> static functions. >> (fold_builtin_1): Hand

Re: [C++ Patch, obvious?] Rename warn_args_num

2015-07-09 Thread Jason Merrill
OK. Jason

Re: genmatch indent generated code

2015-07-09 Thread Jeff Law
On 07/09/2015 06:20 AM, Michael Matz wrote: Hi, while looking at gimple-match.c I got a minor stroke, so this patch makes genmatch generated (mostly) properly indented code. Sure, it could be done post-fact by an editor or something when one looks at the file, but all other generators also try

Re: [PATCH, libiberty]: Avoid "enum conversion when passing argument 1 of ‘getrusage’ is invalid in C++" warning

2015-07-09 Thread Ian Lance Taylor
On Thu, Jul 9, 2015 at 7:15 AM, Uros Bizjak wrote: > On Thu, Jul 9, 2015 at 3:00 PM, Ian Lance Taylor wrote: >> On Wed, Jul 1, 2015 at 3:07 AM, Uros Bizjak wrote: >>> >>> This patch avoids "enum conversion when passing argument 1 of >>> ‘getrusage’ is invalid in C++" warning when compiling getru

Re: [Patch wwwdocs] gcc-5/changes.html : Document AMD monitorx and mwaitx

2015-07-09 Thread Richard Biener
On Thu, Jul 9, 2015 at 4:28 PM, Kumar, Venkataramanan wrote: > Hi Gerald, > > This patch documents about AMD instructions "mwaitx" and "monitorx" in GCC- > 5 changes.html. > Please let me know if this ok to commit? > > Index: htdocs/gcc-5/changes.html > ==

Re: [PATCH][AArch64] PR target/66731 Fix fnmul insn with -frounding-math

2015-07-09 Thread Szabolcs Nagy
On 06/07/15 16:39, Marcus Shawcroft wrote: > On 6 July 2015 at 09:20, Szabolcs Nagy wrote: > >> 2015-07-06 Szabolcs Nagy >> >> * gcc.target/aarch64/fnmul-1.c: New. >> * gcc.target/aarch64/fnmul-2.c: New. >> * gcc.target/aarch64/fnmul-3.c: New. >> * gcc.target/aa

[Patch wwwdocs] gcc-5/changes.html : Document AMD monitorx and mwaitx

2015-07-09 Thread Kumar, Venkataramanan
Hi Gerald, This patch documents about  AMD instructions "mwaitx" and "monitorx" in GCC- 5 changes.html. Please let me know if this ok to commit? Index: htdocs/gcc-5/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.h

Re: Tests for libgomp based on OpenMP Examples 4.0.2.

2015-07-09 Thread Maxim Blumental
Now the patch is corrected (according to the previous letter) and ready to be reviewed. I'm looking forward to your feedback. 2015-07-09 15:56 GMT+03:00 Maxim Blumental : > > I'll have a look, that is supposed to work. > I checked the case with 'simd collapse' and found out that the problem > wa

Re: [PATCH, libiberty]: Avoid "enum conversion when passing argument 1 of ‘getrusage’ is invalid in C++" warning

2015-07-09 Thread Uros Bizjak
On Thu, Jul 9, 2015 at 3:00 PM, Ian Lance Taylor wrote: > On Wed, Jul 1, 2015 at 3:07 AM, Uros Bizjak wrote: >> >> This patch avoids "enum conversion when passing argument 1 of >> ‘getrusage’ is invalid in C++" warning when compiling getruntime.c. >> The condition is copied from sys/resource.h. >

Re: [PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread Jakub Jelinek
On Thu, Jul 09, 2015 at 03:56:35PM +0200, mliska wrote: > --- > gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- > gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- > gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) I'd actually think it would be better to give

Re: [PATCH] Limit alignment on error_mark_node variable

2015-07-09 Thread Richard Biener
On Thu, Jul 9, 2015 at 4:06 PM, H.J. Lu wrote: > On Thu, Jul 9, 2015 at 6:57 AM, Richard Biener > wrote: >> On Thu, Jul 9, 2015 at 1:08 PM, H.J. Lu wrote: >>> On Thu, Jul 9, 2015 at 2:54 AM, Richard Biener >>> wrote: On Thu, Jul 9, 2015 at 11:52 AM, H.J. Lu wrote: > On Thu, Jul 09, 20

[PATCH 1/3] tree-ssa-tail-merge: add IPA ICF infrastructure.

2015-07-09 Thread mliska
gcc/ChangeLog: 2015-07-09 Martin Liska * dbgcnt.def: Add new debug counter. * ipa-icf-gimple.c (func_checker::compare_ssa_name): Add flag for strict mode. (func_checker::compare_memory_operand): Likewise. (func_checker::compare_cst_or_decl): Handle if we

[PATCH 2/3] Fully remove legacy tree-ssa-tail-merge value numbering infrastructure.

2015-07-09 Thread mliska
gcc/ChangeLog: 2015-07-09 Martin Liska * tree-ssa-tail-merge.c (gimple_operand_equal_value_p): Remove. (gimple_equal_p): Remove. (gsi_advance_bw_nondebug_nonlocal): Remove. (find_duplicate): Remove legacy value numbering. (find_clusters_1): Likewise. ---

[PATCH 3/3] Fix ubsan tests by disabling of an optimization.

2015-07-09 Thread mliska
--- gcc/testsuite/g++.dg/ubsan/vptr-1.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-2.C | 2 +- gcc/testsuite/g++.dg/ubsan/vptr-3.C | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/testsuite/g++.dg/ubsan/vptr-1.C b/gcc/testsuite/g++.dg/ubsan/vptr-1.C index f4260c1..2183575 1

[RFC, PATCH 0/3] tree-ssa-tail-merge engine replacement

2015-07-09 Thread mliska
Hello. It's going to be almost a year Richard advised me to utilize IPA ICF infrastructure in tree-ssa-tail-merge, currently using value numbering which is quite hard to maintain. Following small patch set is kick-off and I am opened for advices. Meanwhile, I'm going to send statistics about merge

Re: [PATCH] Limit alignment on error_mark_node variable

2015-07-09 Thread H.J. Lu
On Thu, Jul 9, 2015 at 6:57 AM, Richard Biener wrote: > On Thu, Jul 9, 2015 at 1:08 PM, H.J. Lu wrote: >> On Thu, Jul 9, 2015 at 2:54 AM, Richard Biener >> wrote: >>> On Thu, Jul 9, 2015 at 11:52 AM, H.J. Lu wrote: On Thu, Jul 09, 2015 at 10:16:38AM +0200, Richard Biener wrote: > On We

[gomp4.1 WIP] omp_target_* libgomp APIs

2015-07-09 Thread Jakub Jelinek
Hi! The latest spec adds a bunch of new functions, this patch attempts to implement them, except I gave up partly in omp_target_associate_ptr and completely in omp_target_disassociate_ptr for now. As for the plugins, I think we'll want some plugin callback to support offloading device <-> offload

[PATCH] Improve if-conversion of loads

2015-07-09 Thread Richard Biener
The following improves if-conversion of loads by enabling the analysis code of -ftree-loop-if-convert-stores and using its ifcvt_could_trap_p predicate which uses information about decls being accessed unconditionally to prove the conditional accessed one cannot trap. This depends on the fix for

[PATCH] Mips: Inline memcpy for R6

2015-07-09 Thread Simon Dardis
Hello, This patch enables inline memcpy for R6 which was previously disabled and adds support for expansion when source and destination are at least half-word aligned. gcc/ * config/mips/mips.c (mips_expand_block_move): Enable inline memcpy expansion when !ISA_HAS_LWL_LWR.

Re: [PATCH] Limit alignment on error_mark_node variable

2015-07-09 Thread Richard Biener
On Thu, Jul 9, 2015 at 1:08 PM, H.J. Lu wrote: > On Thu, Jul 9, 2015 at 2:54 AM, Richard Biener > wrote: >> On Thu, Jul 9, 2015 at 11:52 AM, H.J. Lu wrote: >>> On Thu, Jul 09, 2015 at 10:16:38AM +0200, Richard Biener wrote: On Wed, Jul 8, 2015 at 5:32 PM, H.J. Lu wrote: > There is no

[patch] testsuite enable PIE tests on DragonFly

2015-07-09 Thread John Marino
DragonFly supports PIE but the tests for it are disabled. The attached patch for the trunk will enable these checks on DragonFly. Thanks for considering this! John p.s. suggested gcc/testsuite/changelog entry: 2015-07-XX John Marino * lib/target-supports.exp (check_effective_target_p

Re: genmatch indent generated code

2015-07-09 Thread Richard Biener
On Thu, Jul 9, 2015 at 2:20 PM, Michael Matz wrote: > Hi, > > while looking at gimple-match.c I got a minor stroke, so this patch makes > genmatch generated (mostly) properly indented code. Sure, it could be > done post-fact by an editor or something when one looks at the file, but > all other ge

Re: [patch] Remove target.h and alloc-pool.h from lto-streamer.h.

2015-07-09 Thread Jeff Law
On 07/09/2015 05:47 AM, Andrew MacLeod wrote: target.h and alloc-pool.h are not required by any of the streamer header files to compile, so I flattened those 2 includes from lto-streamer.h. plugin-api.h, gcov-io.h and diagnostic.h are all required to parse lto-streamer.h, so I left those in the f

Re: [PATCH] fold builtin_tolower, builtin_toupper

2015-07-09 Thread Richard Biener
On Thu, 9 Jul 2015, Bernhard Reutner-Fischer wrote: > gcc/ChangeLog > > 2015-07-09 Bernhard Reutner-Fischer > > * builtins.c (fold_builtin_tolower, fold_builtin_toupper): New > static functions. > (fold_builtin_1): Handle BUILT_IN_TOLOWER, BUILT_IN_TOUPPER. As I read it you

Re: [PATCH][13/n] Remove GENERIC stmt combining from SCCVN

2015-07-09 Thread Kyrill Tkachov
Hi Richard, On 07/07/15 15:10, Richard Biener wrote: This moves a few more patterns that show up during bootstrap. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-07-07 Richard Biener * fold-const.c (fold_binary_loc): Move (X & C2) << C

Re: [PATCH] PR target/66813: gcc.target/i386/asm-flag-5.c failed with -march=pentium

2015-07-09 Thread Uros Bizjak
On Thu, Jul 9, 2015 at 3:10 PM, H.J. Lu wrote: > gen_rtx_ZERO_EXTEND isn't suitable in ix86_md_asm_adjust since ZERO_EXTEND > may be expaned. We should call gen_zero_extendqiXi2 instead. > > OK for trunk? No, your patch will clobber flags when multiple flag outputs are used. (I plan to rewrite

[PATCH] PR target/66813: gcc.target/i386/asm-flag-5.c failed with -march=pentium

2015-07-09 Thread H.J. Lu
gen_rtx_ZERO_EXTEND isn't suitable in ix86_md_asm_adjust since ZERO_EXTEND may be expaned. We should call gen_zero_extendqiXi2 instead. OK for trunk? H.J. --- gcc/ PR target/66813 * config/i386/i386.c (ix86_md_asm_adjust): Replace gen_rtx_ZERO_EXTEND with gen_zero_extend

Re: [PATCH] Fix PR c++/30044

2015-07-09 Thread Patrick Palka
On Fri, Jun 26, 2015 at 7:40 AM, Patrick Palka wrote: > Here is a more modest approach to fixing this PR. Instead of updating > current_template_parms with each newly processed template parameter, > this patch just updates it with a "dummy" parameter level once per > parameter list. So now in ts

  1   2   >