Re: [PATCH 4/7] Fix int overflow

2015-07-07 Thread Mikhail Maltsev
On 08.07.2015 1:48, Jeff Law wrote: > I'm not questioning whether or not the test will cause a problem, but > instead questioning if the test does what you expect it to do on a 32bit > host. > > On a host where sizeof (int) == sizeof (long), that len > INT_MAX test > is always going to be false. Y

RE: [PATCH] MIPS: fix failing branch range checks for micromips

2015-07-07 Thread Moore, Catherine
Hi Andrew, > -Original Message- > From: Andrew Bennett [mailto:andrew.benn...@imgtec.com] > Sent: Tuesday, July 07, 2015 12:13 PM > To: Moore, Catherine; gcc-patches@gcc.gnu.org > Cc: Matthew Fortune > Subject: RE: [PATCH] MIPS: fix failing branch range checks for micromips > > > Ok to c

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-07 Thread Andrew MacLeod
On 07/07/2015 06:21 PM, Jeff Law wrote: On 07/07/2015 07:40 AM, Andrew MacLeod wrote: I can adjust any of this quite easily, or present them in a different way if you don't like it this way. Again, my goal is to check in just the final patch which does all the work of first 8 patches. It would

Re: [PATCH 7/7] Fix several crashes in d_find_pack

2015-07-07 Thread Jeff Law
On 07/06/2015 01:40 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 3 +++ libiberty/testsuite/demangle-expected | 12 2 files changed, 15 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 289a704..4ca285e 100644 --- a/lib

Re: [PATCH 4/7] Fix int overflow

2015-07-07 Thread Jeff Law
On 07/06/2015 06:04 PM, Mikhail Maltsev wrote: On 07.07.2015 1:55, Jeff Law wrote: len = d_number (di); - if (len <= 0) + if (len <= 0 || len > INT_MAX) return NULL; ret = d_identifier (di, len); di->last_name = ret; Isn't this only helpful if sizeof (long) > sizeof (in

Re: [PATCH 6/7] Fix DEMANGLE_COMPONENT_LOCAL_NAME

2015-07-07 Thread Jeff Law
On 07/06/2015 01:39 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 7 +++ libiberty/testsuite/demangle-expected | 4 2 files changed, 11 insertions(+) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 424b1c5..289a704 100644 --- a/libiberty

Re: [PATCH 3/7] Fix trinary op

2015-07-07 Thread Jeff Law
On 07/06/2015 01:34 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 4 +++- libiberty/testsuite/demangle-expected | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 12093cc..44a0a9b 100644 --

Re: [patch 0/9] Flattening and initial module rebuilding

2015-07-07 Thread Jeff Law
On 07/07/2015 07:40 AM, Andrew MacLeod wrote: This is a series of 9 patches which does some flattening, some module building, and some basic cleanups. I am presenting them as 9 patches for easier review. The latter couple of patches affect a lot of the same files that follow on patches then ad

Re: [patch 9/9] Final patch with all changes

2015-07-07 Thread Andrew MacLeod
On 07/07/2015 06:03 PM, Pedro Alves wrote: On 07/07/2015 02:51 PM, Andrew MacLeod wrote: *** sel-sched-ir.h (revision 225452) --- sel-sched-ir.h (working copy) *** along with GCC; see the file COPYING3. *** 22,34 #define GCC_SEL_SCHED_IR_H /* For state_t. */

Re: [PATCH 15/16][fold-const.c] Fix bigendian HFmode in native_interpret_real

2015-07-07 Thread Jeff Law
On 07/07/2015 06:37 AM, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01346.html. Fixes FAIL of advsimd-intrinsics vcreate.c on aarch64_be-none-elf from previous patch. 15_native_interpret_real.patch commit e2e7ca148960a82fc88128820f17e7cbd14173cb Author: Alan Lawre

Re: [patch 9/9] Final patch with all changes

2015-07-07 Thread Pedro Alves
On 07/07/2015 02:51 PM, Andrew MacLeod wrote: > *** sel-sched-ir.h(revision 225452) > --- sel-sched-ir.h(working copy) > *** along with GCC; see the file COPYING3. > *** 22,34 > #define GCC_SEL_SCHED_IR_H > > /* For state_t. */ > - #include "insn-attr.h" > - #includ

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-07 Thread Richard Biener
On July 7, 2015 6:29:21 PM GMT+02:00, Jim Wilson wrote: >On Tue, Jul 7, 2015 at 8:07 AM, Jeff Law wrote: >> On 06/29/2015 07:15 PM, Jim Wilson wrote: >> So if these "copies" require a conversion, then isn't it >fundamentally >> wrong to have a PHI node which copies between them? That would seem

RE: fix PR46029: reimplement if conversion of loads and stores

2015-07-07 Thread Abe
(if-conversion could directly generate masked load/stores of course and not use a scratch-pad at all in that case). IMO that`s a great idea, but I don`t know how to do it. Hints would be welcome. In particular, how does one "generate masked load/stores" at the GIMPLE level? But are we cor

Adjust -fdump-ada-spec to C++14 switch

2015-07-07 Thread Eric Botcazou
The Ada side doesn't know what to do with the move constructors of C++11 so the attached patch makes -fdump-ada-spec skip them. Tested on x86_64-suse-linux, applied on the mainline as obvious. 2015-07-07 Eric Botcazou c-family/ * c-ada-spec.h (cpp_operation): Add IS_MOVE_CONSTRUCTOR

[PATCH, committed] PR jit/66783: prevent use of opaque structs

2015-07-07 Thread David Malcolm
Prevent use of opaque structs for fields, globals and locals. Tested with "make check-jit"; jit.sum goes from 8434 to 8494 passes. Committed to trunk as r225523. gcc/jit/ChangeLog: PR jit/66783 * jit-recording.h: Within namespace gcc:jit::recording... (type::has_known_siz

[PATCH, committed] PR jit/66779: fix segfault

2015-07-07 Thread David Malcolm
Fix a segfault where expr.c:fold_single_bit_test was segfaulting due to jit_langhook_type_for_mode not handling QImode. Tested with "make check-jit"; takes jit.sum from 8289 to 8434 passes. Committed to trunk as r225522. gcc/jit/ChangeLog: PR jit/66779 * dummy-frontend.c (jit_lan

Re: [PATCH 1/3] [ARM] PR63870 NEON error messages

2015-07-07 Thread Charles Baylis
On 6 July 2015 at 11:18, Alan Lawrence wrote: > I note some parts of this duplicate my > https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01422.html , which has been > pinged a couple of times. Both Charles' patch, and my two, contain parts the > other does not... To resolve the conflicts, I suggest

[PATCH, i386]: Generate BT with immedate operand

2015-07-07 Thread Uros Bizjak
Hello! After recent x86 EXTZ/EXTZV improvements, we can extend BT splitters to generate BT instruction with immediate operands. The improvement can be seen with attached testcases. The benefit is obvious for BT with immediates 32 <= n <= 63: 0: 48 b8 00 00 00 00 00movabs $0x1000

Re: Tests for libgomp based on OpenMP Examples 4.0.2.

2015-07-07 Thread Ilya Verbin
On Tue, Jul 07, 2015 at 20:17:48 +0200, Jakub Jelinek wrote: > On Tue, Jul 07, 2015 at 08:08:16PM +0300, Maxim Blumental wrote: > > > Added 16 tests for simd construct and 10 for depend clause. > > Any new tests that aren't in Examples 4.0.* document should go one level > higher, to libgomp.{c,c++

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-07 Thread Jim Wilson
On Thu, Jul 2, 2015 at 2:07 AM, Richard Earnshaw wrote: > Not quite, ARM state still has more flexible addressing modes for > unsigned byte loads than for signed byte loads. It's even worse with > thumb1 where some signed loads have no single-register addressing mode > (ie you have to copy zero i

Re: Tests for libgomp based on OpenMP Examples 4.0.2.

2015-07-07 Thread Jakub Jelinek
On Tue, Jul 07, 2015 at 08:08:16PM +0300, Maxim Blumental wrote: > Comment on the patch: > > simd-5.f90 file is marked as xfail since the test fails because 'simd > collapse' is an unsupported combination for Fortran (which though is > valid in OpenMP API). I'll have a look, that is supposed to w

RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips jraddiusp instruction.

2015-07-07 Thread Moore, Catherine
> -Original Message- > From: Andrew Bennett [mailto:andrew.benn...@imgtec.com] > Sent: Tuesday, July 07, 2015 12:14 PM > To: Moore, Catherine; Matthew Fortune; gcc-patches@gcc.gnu.org > Subject: RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips > jraddiusp instruction. > > >

Re: [Ping^3] [PATCH, ARM, libgcc] New aeabi_idiv function for armv6-m

2015-07-07 Thread Richard Earnshaw
On 07/07/15 16:23, Tejas Belagod wrote: > Ping! > I've had a look at this (sorry for the delay). I think it's mostly OK, but I have two comments to make. 1) It's quite hard to understand the algorithm and there are no comments to aid understanding (to be fair, there aren't many comments on the

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-07 Thread Alan Lawrence
Kyrill Tkachov wrote: On 07/07/15 17:34, Alan Lawrence wrote: Kyrill Tkachov wrote: On 07/07/15 14:09, Kyrill Tkachov wrote: Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html For some context, the reference for these is at: http

Re: Tests for libgomp based on OpenMP Examples 4.0.2.

2015-07-07 Thread Maxim Blumental
Comment on the patch: simd-5.f90 file is marked as xfail since the test fails because 'simd collapse' is an unsupported combination for Fortran (which though is valid in OpenMP API). 2015-07-07 19:48 GMT+03:00 Maxim Blumental : > With this letter I propose a patch with tests for libgomp based on

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-07 Thread Kyrill Tkachov
On 07/07/15 17:34, Alan Lawrence wrote: Kyrill Tkachov wrote: On 07/07/15 14:09, Kyrill Tkachov wrote: Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html For some context, the reference for these is at: http://infocenter.arm.com/

Re: [PATCH] save takes a single integer (register or 13-bit signed immediate)

2015-07-07 Thread Eric Botcazou
> You are right, I forgot about that. Is there a mode one can use that > changes depending on the target architecture (32-bit on 32-bit > architectures and 64-bit on 64-bit architectures)? Yes, Pmode does exactly that, but you cannot use it directly in the MD file. > Or does one have to add a 32-

Tests for libgomp based on OpenMP Examples 4.0.2.

2015-07-07 Thread Maxim Blumental
With this letter I propose a patch with tests for libgomp based on OpenMP Examples 4.0.2 both for C and Fortran. The changes are: Renamed existing tests based on OpenMP Examples to make the names more clear. Added 16 tests for simd construct and 10 for depend clause. - Since

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-07 Thread Alan Lawrence
Kyrill Tkachov wrote: On 07/07/15 14:09, Kyrill Tkachov wrote: Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html For some context, the reference for these is at: http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_a

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-07 Thread Jim Wilson
On Tue, Jul 7, 2015 at 8:07 AM, Jeff Law wrote: > On 06/29/2015 07:15 PM, Jim Wilson wrote: > So if these "copies" require a conversion, then isn't it fundamentally > wrong to have a PHI node which copies between them? That would seem to > implicate the eipa_sra pass as needing to be aware of th

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-07 Thread Kyrill Tkachov
On 07/07/15 14:09, Kyrill Tkachov wrote: Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html For some context, the reference for these is at: http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_arm_neon_intrinsics_ref

RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips jraddiusp instruction.

2015-07-07 Thread Andrew Bennett
> > I'm not sure this is the right approach here. If we get a jraddiusp then the > > problem that the test is trying to cover can't possibly happen anyway. > > (The test is checking if a load and final stack adjustment are ever re- > ordered > > from what I can see.) > > > > I'd just mark the test

RE: [PATCH] MIPS: fix failing branch range checks for micromips

2015-07-07 Thread Andrew Bennett
> I see that you are naming these tests after the original branch- tests > that they were derived from. > I think it would be better to keep all of the microMIPS tests named umips-???. > I don't think preserving the original number is important. I have named the microMIPS tests umips-branch-??? to

RE: [PATCH] MIPS: Do not generate micromips code for the no-smartmips-lwxs.c testcase

2015-07-07 Thread Andrew Bennett
> Hi Andrew, > > Instead of adding the -mno-micromips option to dg-options, please change the > MIPS16 attribute to NOCOMPRESSION. > > Index: gcc.target/mips/no-smartmips-lwxs.c > === > --- gcc.target/mips/no-smartmips-lwxs.c (revisi

Re: [PING][PATCH, 1/2] Merge rewrite_virtuals_into_loop_closed_ssa from gomp4 branch

2015-07-07 Thread Tom de Vries
On 06/07/15 15:44, Richard Biener wrote: On Mon, 6 Jul 2015, Tom de Vries wrote: On 25/06/15 09:42, Tom de Vries wrote: Hi, this patch merges rewrite_virtuals_into_loop_closed_ssa (originally submitted here: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01236.html ) to trunk. Bootstrapped an

Re: RE: [Ping^3] [PATCH, ARM, libgcc] New aeabi_idiv function for armv6-m

2015-07-07 Thread Tejas Belagod
Ping! On 30/04/15 10:40, Hale Wang wrote: -Original Message- From: Hale Wang [mailto:hale.w...@arm.com] Sent: Monday, February 09, 2015 9:54 AM To: Richard Earnshaw Cc: Hale Wang; gcc-patches; Matthew Gretton-Dann Subject: RE: [Ping^2] [PATCH, ARM, libgcc] New aeabi_idiv function for arm

[gomp4] Handle deviceptr from an outer directive

2015-07-07 Thread James Norris
Hi, This patch fixes an issue where the deviceptr clause in an outer directive was being ignored during implicit variable definition on a nested directive. Committed to gomp-4_0-branch. Jim diff --git a/gcc/gimplify.c b/gcc/gimplify.c index 51aadc0..a721a52 100644 --- a/gcc/gimplify.c +++ b/gcc

Re: [PATCH, ARM] stop changing signedness in PROMOTE_MODE

2015-07-07 Thread Jeff Law
On 06/29/2015 07:15 PM, Jim Wilson wrote: This is my suggested fix for PR 65932, which is a linux kernel miscompile with gcc-5.1. The problem here is caused by a chain of events. The first is that the relatively new eipa_sra pass creates fake parameters that behave slightly differently than nor

[PATCH] libstdc++-v3/fragment.am (AM_CPPFLAGS): Add CPPFLAGS

2015-07-07 Thread Michael Haubenwallner
Hi build machinery maintainers, when the host system does not have the iconv-devel package installed, but the target-prefix does contain iconv.h, in libstdc++/include the creation of the precompiled headers fails with " not found". While libstdc++/configure detects INCICONV="-I$target_prefix/incl

Re: [gomp] Move openacc vector& worker single handling to RTL

2015-07-07 Thread Nathan Sidwell
On 07/07/15 10:22, Jakub Jelinek wrote: On Tue, Jul 07, 2015 at 10:12:56AM -0400, Nathan Sidwell wrote: Wouldn't function attributes be better for that case, and just use the internal functions for the case when the mode is being changed in the middle of function? It may be. I've been think

Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-07 Thread Jeff Law
On 07/07/2015 06:50 AM, Kugan wrote: Thanks for the review. I have addressed your comments above in the attached patch. I have one question with respect to unary operation. For generic unary operation with INTEGER_CST, do we skip this or do we have to perform the inverse operation so that the c

Re: [gomp] Move openacc vector& worker single handling to RTL

2015-07-07 Thread Jakub Jelinek
On Tue, Jul 07, 2015 at 10:12:56AM -0400, Nathan Sidwell wrote: > On 07/07/15 05:54, Jakub Jelinek wrote: > >On Mon, Jul 06, 2015 at 03:34:51PM -0400, Nathan Sidwell wrote: > > >How does this interact with > >#pragma acc routine {gang,worker,vector,seq} ? > >Or is that something to be added later

[Patch,microblaze]: Optimized Instruction prefetch with the generation of wic

2015-07-07 Thread Ajit Kumar Agarwal
All: Please find the patch for optimized usage of instruction prefetch with the generation of microblaze instruction "wic". No regressions is seen in Deja GNU tests for microblaze. [Patch,microblaze]: Optimized Instruction prefetch with the generation of wic instruction. The change

Re: [gomp] Move openacc vector& worker single handling to RTL

2015-07-07 Thread Nathan Sidwell
On 07/07/15 05:54, Jakub Jelinek wrote: On Mon, Jul 06, 2015 at 03:34:51PM -0400, Nathan Sidwell wrote: How does this interact with #pragma acc routine {gang,worker,vector,seq} ? Or is that something to be added later on? That is to be added later on. I suspect such routines will trivially

[PATCH][13/n] Remove GENERIC stmt combining from SCCVN

2015-07-07 Thread Richard Biener
This moves a few more patterns that show up during bootstrap. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-07-07 Richard Biener * fold-const.c (fold_binary_loc): Move (X & C2) << C1 -> (X << C1) & (C2 << C1) simplification ...

Re: [patch 4/9] Flatten sel-sched-dump.h and sel-sched-ir.h

2015-07-07 Thread Andrew MacLeod
On 07/07/2015 10:01 AM, Alexander Monakov wrote: On Tue, 7 Jul 2015, Andrew MacLeod wrote: This patch flattens both sel-sched-dump.h and sel-sched-ir.h. Both these files end up including cfgloop.h, so in preparation for flattening cfgloop.h, flatten these. Note they actually have only a small

RE: [PATCH] MIPS: Fix the call-[1,5,6].c tests to allow the jrc instruction to be matched when testing with microMIPS

2015-07-07 Thread Andrew Bennett
> OK. Committed as SVN 225516. Regards, Andrew

Re: [gomp4] Allow parameter declarations with deviceptr

2015-07-07 Thread Thomas Schwinge
Hi! On Wed, 1 Jul 2015 16:33:24 -0700, Cesar Philippidis wrote: > On 07/01/2015 02:25 PM, James Norris wrote: > > > This patch allows parameter declarations to be used as > > arguments to deviceptr for C and C++. Thanks! I suppose this does fix ? > Does this fix a

Re: [patch 4/9] Flatten sel-sched-dump.h and sel-sched-ir.h

2015-07-07 Thread Alexander Monakov
On Tue, 7 Jul 2015, Andrew MacLeod wrote: > This patch flattens both sel-sched-dump.h and sel-sched-ir.h. Both these files > end up including cfgloop.h, so in preparation for flattening cfgloop.h, > flatten these. Note they actually have only a small effect on what includes > them. This patch re

Re: [RFC] two-phase marking in gt_cleare_cache

2015-07-07 Thread Michael Matz
Hi, On Mon, 6 Jul 2015, Richard Biener wrote: > >> By doing so, we make the behaviour of gt_cleare_cache independent of the > >> order in which the entries are visited, turning: > >> - hard-to-trigger bugs which trigger for one visiting order but not for > >> another, into > >> - more easily tr

Re: [PATCH] Simple optimization for MASK_STORE.

2015-07-07 Thread Yuri Rumyantsev
Hi Richard, Did you have a chance to look at this updated patch? Thanks. Yuri. 2015-06-18 17:32 GMT+03:00 Yuri Rumyantsev : > Richard, > > Here is updated patch which does not include your proposal related to > the target hook deletion. > You wrote: >> I still don't understand why you need the n

[patch 4/9] Flatten sel-sched-dump.h and sel-sched-ir.h

2015-07-07 Thread Andrew MacLeod
This patch flattens both sel-sched-dump.h and sel-sched-ir.h. Both these files end up including cfgloop.h, so in preparation for flattening cfgloop.h, flatten these. Note they actually have only a small effect on what includes them. Bootstraps from scratch on x86_64-unknown-linux-gnu with no

[patch 8/9] Flatten df.h

2015-07-07 Thread Andrew MacLeod
This patch fixes up df.h. It contains 5 headers that will form part of backend.has well as hard-reg-set.h which is now going to be included by rtl.h. The other 3 includes are required for df.h to compile, and it makes sense to leave them here. furthermore, resource.h, sched-int.h and valtrac

[patch 7/9] Flatten cfgloop.h

2015-07-07 Thread Andrew MacLeod
This patch flattens cfgloop.h. cfgloopmanip.h is utilized by numerous files which include cfgloop.h, so it seems to make sense to leave it here. The other 3 header files are going to form part of backend.h, so take them out. I didn't bother posting the changes to all the source files since a

[patch 6/9] Flatten gimple-streamer.h

2015-07-07 Thread Andrew MacLeod
This one is amusing... 3 header files, all of them already included in all the files which include this. Bootstraps from scratch on x86_64-unknown-linux-gnu with no new regressions. Also compiles all the files in config-list.mk. * gimple-streamer.h: Remove all includes. Index: gimple-stre

[patch 5/9] Flatten ira-int.h

2015-07-07 Thread Andrew MacLeod
Flatten ira-int.h, yet another header that includes cfgloop.h. Most of the includes from here do actually make it into the source files, so once the include reduction is completed and we see if they are actually needed, some may go back in. Bootstraps from scratch on x86_64-unknown-linux-gnu

[patch 3/9] Flatten lra-int.h

2015-07-07 Thread Andrew MacLeod
This patch flattens lra-int.h. It currently clumps 7 includes, which no file needs more than 4. Flatten it here and find a better aggregator for rtl related files later. Bootstraps from scratch on x86_64-unknown-linux-gnu with no new regressions. Also compiles all the files in config-list.mk

[patch 2/9] flatten regset.h

2015-07-07 Thread Andrew MacLeod
This patch flattens regset.h. it only includes bitmap.h which will come from backend.h and hard-reg-set.h which is going to be included by rtl.h. The vast majority of files which include regset already include rtl.h, so its almost never needed. This patch shows the result on all files in a v

[patch 1/9] header additions and aggregators

2015-07-07 Thread Andrew MacLeod
This patch implements most of the core concepts described in my previous email (https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01846.html) It goes into detail of the analysis which resulted in this layout. Most of the unnecessary prerequisites have been removed, so we can start introducing bac

[patch 0/9] Flattening and initial module rebuilding

2015-07-07 Thread Andrew MacLeod
This is a series of 9 patches which does some flattening, some module building, and some basic cleanups. I am presenting them as 9 patches for easier review. The latter couple of patches affect a lot of the same files that follow on patches then adjust, I've decided NOT to put the automated c

[gomp4] libgomp: Remove C-only XFAILs added in "Tune XFAILs" (was: openacc id builtin)

2015-07-07 Thread Thomas Schwinge
Hi! On Fri, 26 Jun 2015 08:39:41 -0400, Nathan Sidwell wrote: > I discovered a latent bug in the openacc thread id builtin and associated > unspec. They should not be treated as constant functions, because that > causes > the compiler to consider them constant across threads. Which of course

RE: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-07-07 Thread Ajit Kumar Agarwal
-Original Message- From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Tuesday, July 07, 2015 2:21 PM To: Ajit Kumar Agarwal Cc: l...@redhat.com; GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re: [Patch,tree-optimization]: Add

[RFCv2] Add steady_clock support to condition_variable

2015-07-07 Thread Mike Crowe
If pthread_cond_timedwaitonclock_np is available in the C library it can be used it to fix part of https://gcc.gnu.org/bugzilla/show_bug.cgi?id=41861 by supporting std::chrono::steady_clock properly with std::condition_variable. This means that code using std::condition_variable::wait_for or std::

[gomp4] OpenACC device_type clause (was: OpenACC: Complete changes to disallow the independent clause after device_type)

2015-07-07 Thread Thomas Schwinge
Hi Cesar! On Tue, 7 Jul 2015 14:58:20 +0200, I wrote: > On Wed, 1 Jul 2015 07:52:13 -0500, James Norris > wrote: > > The independent clause is not available for use > > with device_type clauses associated with loop > > directives. [...] Independent of this, would you please verify (also for the

Re: [PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-07 Thread Kyrill Tkachov
Hi Alan, On 07/07/15 13:34, Alan Lawrence wrote: As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html For some context, the reference for these is at: http://infocenter.arm.com/help/topic/com.arm.doc.ihi0073a/IHI0073A_arm_neon_intrinsics_ref.pdf This patch is ok once you and Charle

[gomp4] OpenACC: Complete changes to disallow the independent clause after device_type (was: Remove clause from device_type options)

2015-07-07 Thread Thomas Schwinge
Hi! On Wed, 1 Jul 2015 07:52:13 -0500, James Norris wrote: > The independent clause is not available for use > with device_type clauses associated with loop > directives. This patch removes the usage. Thanks for noticing this! > Committed to gomp-4_0-branch > --- a/gcc/c/c-parser.c > +++ b/gc

[AArch64][2/2] Define TARGET_UNSPEC_MAY_TRAP_P for AArch64

2015-07-07 Thread Jiong Wang
A second patch to improve rtl loop iv on AArch64. We should define this to tell gcc the pattern hidden by these GOT unspec is safe from trap, so gcc could make more positive decision when handling them, for example in RTL loop iv pass, when deciding whether one instruction is invariant candidate,

[AArch64][1/2] Mark GOT related MEM rtx as const to help RTL loop IV

2015-07-07 Thread Jiong Wang
Given below testcase, the instruction which load function address from GOT table is not hoisted out of the loop while it should be, as the value is fixed at runtime. The problem is we havn't mark those GOT related mem as READONLY that RTL loop2_iv pass has make conservative decision in check_mayb

Re: [PR66726] Factor conversion out of COND_EXPR

2015-07-07 Thread Kugan
On 07/07/15 07:37, Jeff Law wrote: > On 07/04/2015 06:32 AM, Kugan wrote: > I would also verify that this turns into a MIN_EXPR. I think the patch > as-written won't detect the MIN_EXPR until the _next_ time phi-opt is > called. And one of the benefits we're really looking for here is to > remov

RE: [PATCH] MIPS: Fix the call-[1,5,6].c tests to allow the jrc instruction to be matched when testing with microMIPS

2015-07-07 Thread Moore, Catherine
> -Original Message- > From: Andrew Bennett [mailto:andrew.benn...@imgtec.com] > Sent: Tuesday, July 07, 2015 6:53 AM > To: gcc-patches@gcc.gnu.org > Cc: Moore, Catherine; Matthew Fortune > Subject: [PATCH] MIPS: Fix the call-[1,5,6].c tests to allow the jrc > instruction > to be matched

[gomp4] libgomp: XFAIL libgomp.oacc-c-c++-common/reduction-4.c for acc_device_nvidia (was: implicit firstprivate and other testcase fixes)

2015-07-07 Thread Thomas Schwinge
Hi! On Wed, 1 Jul 2015 22:19:01 +0800, Chung-Lin Tang wrote: > This patch "notices" the index variable of an acc loop (internally an OMP_FOR) > inside an OpenACC construct, and completes the implicit firstprivate > behavior as described in the spec. The firstprivate clauses and FIXME in > libgom

[PATCH 16/16][ARM/AArch64 Testsuite] Add test of vcvt{,_high}_{f16_f32,f32_f16}

2015-07-07 Thread Alan Lawrence
This is a respin of https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01349.html . Changes are to: use #if defined(__aarch64__) rather than __ARM_64BIT_STATE__; add an initial call to clean_results; use a different mechanism for adding -mfpu=neon-fp16 on ARM (specifically: we try to add that flag f

[PATCH 15/16][fold-const.c] Fix bigendian HFmode in native_interpret_real

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01346.html. Fixes FAIL of advsimd-intrinsics vcreate.c on aarch64_be-none-elf from previous patch. commit e2e7ca148960a82fc88128820f17e7cbd14173cb Author: Alan Lawrence Date: Thu Apr 9 10:54:40 2015 +0100 Fix native_interpret_real for HF

[PATCH 14/16][ARM/AArch64 testsuite] Update advsimd-intrinsics tests to add float16 vectors

2015-07-07 Thread Alan Lawrence
This is a respin of https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01347.html, removing many default values of 0x333, to complete that I introduced new macros CHECK_RESULTS{,_NAMED}_NO_FP16 as writing the same list of vector types in four places seemed too many. gcc/testsuite/ChangeLog:

[PATCH 13/16][AArch64] Add vcvt(_high)?_f32_f16 intrinsics, with BE RTL fix

2015-07-07 Thread Alan Lawrence
Unchanged since https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01345.html commit 214fcc00475a543a79ed444f9a64061215397cc8 Author: Alan Lawrence Date: Wed Jan 28 13:01:31 2015 + AArch64 6/N: vcvt{,_high}_f32_f16 (using vect_par_cnst_hi_half, fixing bigendian indices) diff --git a/gcc/co

[PATCH 12/16][AArch64] vreinterpret(q?), vget_(low|high), vld1(q?)_dup

2015-07-07 Thread Alan Lawrence
This is the remainder of https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01343.html combined with https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01344.html, putting together all the intrinsics that didn't require anything outside arm_neon.h. Also update the existing tests in aarch64/. gcc/Change

[PATCH 10/16][AArch64] vld{2,3,4}{,_lane,_dup},vcombine,vcreate

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01342.html commit ef719e5d3d6eccc5cf621851283b7c0ba1a9ee6c Author: Alan Lawrence Date: Tue Aug 5 17:52:28 2014 +0100 AArch64 3/N: v(create|combine|v(ld|st|ld...dup/lane|st...lane)[234](q?))_f16; tests vldN{,_lane,_dup} inc bigendian. Add

[PATCH 11/16][AArch64] Implement vcvt_{,high_}f16_f32

2015-07-07 Thread Alan Lawrence
This comes from https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01343.html but the other/unrelated intrinsics have moved into the next patch. gcc/ChangeLog: * config/aarch64/aarch64-simd.md (aarch64_float_truncate_lo_v2sf): Reparameterize to... (aarch64_float_truncate_lo_)

[PATCH 9/16][AArch64] Add support for float16x{4,8}_t vectors/builtins

2015-07-07 Thread Alan Lawrence
As https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01341.html commit 49cb53a94a44fcda845c3f6ef11e88f9be458aad Author: Alan Lawrence Date: Tue Dec 2 13:08:15 2014 + AArch64 2/N: Vector/__builtin basics: define+support types, movs, test ABI. Patterns, builtins, intrinsics for {ld1

[PATCH 8/16][ARM/AArch64 Testsuite] Add basic fp16 tests

2015-07-07 Thread Alan Lawrence
These were originally part of https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01340.html but I have moved into their own subdirectory and adapted them to execute on ARM also (as per https://gcc.gnu.org/ml/gcc-patches/2015-05/msg00656.html) gcc/testsuite/ChangeLog: * gcc.target/aarch64/f

[PATCH 7/16][AArch64] Add basic fp16 support

2015-07-07 Thread Alan Lawrence
Same as https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01340.html except that two of the tests have been moved into the next patch. (The remaining test is AArch64 only.) gcc/ChangeLog: * config/aarch64/aarch64-builtins.c (aarch64_fp16_type_node): New. (aarch64_init_builtins): Ma

[PATCH 5/16][ARM] Add float16x8_t intrinsics

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01337.html commit 336eb16d3061131fe8d28fad4a473d00768bfe5c Author: Alan Lawrence Date: Tue Dec 9 15:06:38 2014 + ARM float16x8_t intrinsics (v2 - fix v[sg]etq_lane_f16, add vreinterpretq_p16_f16, no vdup_n/lane/vmov_n) diff --git a

[PATCH 6/16][ARM] Remaining float16 intrinsics: vld..., vst..., vget_low/high, vcombine

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01341.html commit ae6264b144d25fadcbf219e68ddf3d8c5f40be34 Author: Alan Lawrence Date: Thu Dec 11 11:53:59 2014 + ARM 4/4 v2: v(ld|st)[234](q?|_lane|_dup), vcombine, vget_(low|high) (v2 w/ V_uf_sclr) All are tied together wi

[PATCH 2/16][ARM] PR/63870 Add __builtin_arm_lane_check.

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01334.html commit 1bb1b208a2c8c8b1ee1186c6128a498583fd64fe Author: Alan Lawrence Date: Mon Dec 8 18:36:30 2014 + Add __builtin_arm_lane_check diff --git a/gcc/config/arm/arm-builtins.c b/gcc/config/arm/arm-builtins.c index 7f5bf87..

[PATCH 4/16][ARM] Add float16x8_t type

2015-07-07 Thread Alan Lawrence
Unchanged since https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01336.html commit b9ccac6243415b304024443b74bdc97b3a5954f2 Author: Alan Lawrence Date: Mon Dec 8 18:40:24 2014 + Add float16x8_t + V8HFmode support (regardless of -mfp16-format) diff --git a/gcc/config/arm/arm-builtins.c b/

[PATCH 3/16][ARM] Add float16x4_t intrinsics

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01335.html commit 54a89a084fbd00e4de036f549ca893b74b8f58fb Author: Alan Lawrence Date: Mon Dec 8 18:40:03 2014 + ARM: float16x4_t intrinsics (v2 - fix v[sg]et_lane_f16 at -O0, no vdup_n/vmov_n) diff --git a/gcc/config/arm/arm_neon.h

[PATCH 1/16][ARM] PR/63870 Add qualifier to check lane bounds in expand

2015-07-07 Thread Alan Lawrence
As per https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01333.html (While this falls under PR/63870, and I will link to that in the ChangeLog, it is only a small step towards fixing that PR.) commit 9812db88cff20a505365f68f4065d2fbab998c9c Author: Alan Lawrence Date: Mon Dec 8 11:04:49 2014 +000

[PATCH 0/16][ARM/AArch64] Float16_t support, v2

2015-07-07 Thread Alan Lawrence
This is a respin of the series at https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01332.html, plus the two ARM patches on which these depend (https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01333.html). These two somewhat duplicate Charles Baylis' lane-bounds-checking patch at https://gcc.gnu.org/

[patch committed SH] Fix PR target/66780

2015-07-07 Thread Kaz Kojima
The attatched patch reverts a part of the change in r221165 for target/65249. It turned out that that change causes a wrong code problem PR target/66780 which is worse than the ICE with 'R0_REGS' spill failure for a specific program reported by PR65249. I've committed it on trunk and reopened PR ta

Re: [PATCH 1/3] [ARM] PR63870 NEON error messages

2015-07-07 Thread Alan Lawrence
Alan Lawrence wrote: I note some parts of this duplicate my https://gcc.gnu.org/ml/gcc-patches/2015-01/msg01422.html , which has been pinged a couple of times. Both Charles' patch, and my two, contain parts the other does not... Cheers, Alan Charles Baylis wrote: gcc/ChangeLog: Charles Bayl

[PATCH] libgomp: Introduce gomp_thread::spare_team

2015-07-07 Thread Sebastian Huber
Try to re-use the previous team to avoid the use of malloc() and free() in the normal case where number of threads is the same. Avoid superfluous destruction and initialization of team synchronization objects. Using the microbenchmark posted here https://gcc.gnu.org/ml/gcc-patches/2008-03/msg009

Re: [PATCH] Do not use floating point registers when compiling with -msoft-float for SPARC

2015-07-07 Thread Daniel Cederman
On 2015-07-07 12:32, Eric Botcazou wrote: ChangeLog must just describe the what, nothing more. If the rationale is not obvious, then a comment must be added _in the code_ itself. * config/sparc/sparc.c (sparc_function_value_regno_p): Do not return true on %f0 for a target with

Re: [PATCH] Update instruction cost for LEON

2015-07-07 Thread Daniel Cederman
On 2015-07-07 12:37, Eric Botcazou wrote: 2015-07-03 Daniel Cederman * config/sparc/sparc.c (struct processor_costs): Set div cost for leon to match UT699 and AT697F. Set mul cost for leon3 to match standard leon3. So UT699 is not a standard LEON3? LEON3 exists in

Re: [PATCH] save takes a single integer (register or 13-bit signed immediate)

2015-07-07 Thread Daniel Cederman
On 2015-07-07 12:35, Eric Botcazou wrote: 2015-06-26 Daniel Cederman * config/sparc/sparc.md: Window save takes a single integer This will probably break in 64-bit mode, the operand can be a DImode register. You are right, I forgot about that. Is there a mode one can use that

Re: [Patch, fortran, pr66578, v1] [F2008] Invalid free on allocate(...,source=a(:)) in block

2015-07-07 Thread Andre Vehreschild
Hi all, hi Paul, Paul thanks for the review. Committed as r225507. Regards, Andre -- Andre Vehreschild * Email: vehre ad gmx dot de Index: gcc/fortran/trans-expr.c === *** gcc/fortran/trans-expr.c (revision 223641) --- gcc

Re: Clean-ups in match.pd

2015-07-07 Thread Richard Biener
On Tue, Jul 7, 2015 at 12:48 PM, Eric Botcazou wrote: >> Bootstrap+testsuite on powerpc64le-unknown-linux-gnu (it looks like >> *-match.c takes about 10 minutes to compile in stage2 these days). > > Yeah, it has already taken back all the speedup brought by the rewrite of the > RTL gen* stuff by R

[PATCH] MIPS: Fix the call-[1,5,6].c tests to allow the jrc instruction to be matched when testing with microMIPS

2015-07-07 Thread Andrew Bennett
Hi, When building the call-[1,5,6].c tests for micromips the jrc rather than the jr instruction is used to call the tail* functions. I have updated the test output to allow the jrc instruction to be matched. I have tested this on the mips-mti-elf target using mips32r2/{-mno-micromips/-mmicromip

Re: Clean-ups in match.pd

2015-07-07 Thread Eric Botcazou
> Bootstrap+testsuite on powerpc64le-unknown-linux-gnu (it looks like > *-match.c takes about 10 minutes to compile in stage2 these days). Yeah, it has already taken back all the speedup brought by the rewrite of the RTL gen* stuff by Richard S. :-( -- Eric Botcazou

Re: [PATCH] Update instruction cost for LEON

2015-07-07 Thread Eric Botcazou
> 2015-07-03 Daniel Cederman > > * config/sparc/sparc.c (struct processor_costs): Set div cost > for leon to match UT699 and AT697F. Set mul cost for leon3 to > match standard leon3. So UT699 is not a standard LEON3? -- Eric Botcazou

Re: [PATCH] save takes a single integer (register or 13-bit signed immediate)

2015-07-07 Thread Eric Botcazou
> 2015-06-26 Daniel Cederman > > * config/sparc/sparc.md: Window save takes a single integer This will probably break in 64-bit mode, the operand can be a DImode register. -- Eric Botcazou

  1   2   >