RE: [PATCH, aarch64] Add prefetch support

2014-11-30 Thread Gopalasubramanian, Ganesh
Please ignore the previous patch sent. The attachment was wrong. > There's no point in the buffer or the sprintf. > The text is short enough to repeat whole pattern in the array: Updated the patch for the above suggestions. make -k check RUNTESTFLAGS="execute.exp compile.exp dg.exp" passes. Is i

[testsuite] Fix multiple definitions of _init

2014-11-30 Thread Oleg Endo
Hi, When running the testsuite on a sh-elf configuration, some test cases fail due to multiple definitions of the function '_init'. This is because on sh-elf every function is automatically prefixed with a '_' char. When defining a C function 'init' in some code, the actual name becomes '_init'

RE: [PATCH, ifcvt] Fix PR63917

2014-11-30 Thread Zhenqiang Chen
> -Original Message- > From: H.J. Lu [mailto:hjl.to...@gmail.com] > Sent: Friday, November 28, 2014 10:45 PM > To: Zhenqiang Chen > Cc: Richard Henderson; GCC Patches > Subject: Re: [PATCH, ifcvt] Fix PR63917 > > On Sun, Nov 23, 2014 at 7:47 PM, Zhenqiang Chen > wrote: > > > >> -Orig

[SH][committed] PR 63986 - fix generation of wrong code

2014-11-30 Thread Oleg Endo
Hi, As mentioned in the PR, the original fix could wrongly delete insns, which e.g. shows in the new gcc.dg/atomic/stdatomic-flag.c failures. Thus, add some more checks to make sure that it's safe to delete it. Tested with make -k check RUNTESTFLAGS="--target_board=sh-sim\{-m4/-ml,-m4/-mb}" commit

RE: [PATCH, aarch64] Add prefetch support

2014-11-30 Thread Gopalasubramanian, Ganesh
> There's no point in the buffer or the sprintf. > The text is short enough to repeat whole pattern in the array: Updated the patch for the above suggestions. Is it ok for upstream? Regards Ganesh prefetch.diff Description: prefetch.diff

Re: [PATCH] Fix ubsan and C++14 constexpr ICEs (PR sanitizer/63956)

2014-11-30 Thread Jason Merrill
On 11/27/2014 08:57 AM, Marek Polacek wrote: -/* { dg-error "is not a constant expression" "" { target c++ } 12 } */ +/* { dg-error "" "" { xfail { *-*-* } } 11 } */ Please keep the expected message. Jason

Go patch commtited: Avoid crash with self-referential type

2014-11-30 Thread Ian Lance Taylor
This patch to the Go frontend, by Chris Manghane, avoids crashing on code with self-referential types like type T interface { m() [unsafe.Sizeof(T(nil).m())]int } This kind of code is perverse but of course the compiler should not crash. This is http://golang.org/issue/6637. Bootstrapped

libgo patch committed: Add local version of move-if-change

2014-11-30 Thread Ian Lance Taylor
This patch by Peter Collingbourne adds a local variant of the move-if-change script, called mvifdiff, so that libgo can be built outside of the GCC tree. Bootstrapped on x86_64-unknown-linux-gnu. Committed to mainline. Ian Index: libgo/Makefile.am =

Re: [patch] Some std::locale improvements

2014-11-30 Thread Jonathan Wakely
Finally, does anyone know why we don't use the stored size in the facet virtual functions that return strings? e.g. virtual string do_grouping() const { return _M_data->_M_grouping; } We could save the cost of a strlen call: virtual string do_grouping() const { ret

Re: [patch] Some std::locale improvements

2014-11-30 Thread Jonathan Wakely
I think we also need this to make __numpunct_cache and __moneypunct_cache exception-safe. If we set _M_allocated=true at the start of the _M_cache functions and then an allocation throws we will delete[] the memory allocated in _M_cache, but then the cache's destructor will see _M_allocated==true

[SH][committed] Fix usage of __SHMEDIA__ in libgcc

2014-11-30 Thread Oleg Endo
Hi, In libgcc/lib1funcs.S the usage of the __SHMEDIA__ macro seems to mismatch the setup in sh/sh-c.c (sh_cpu_cpp_builtins). __SHMEDIA__ is always defined when building for SH5 / SH64, even when the subtarget is SHcompact. Thus, when building for SHcompact testing '#ifdef __SHMEDIA__' will resul

PING for build part – Re: [Build, Graphite] PR64017 - support ISL-0.14 (gcc/configure.ac and gcc/graphite*.c)

2014-11-30 Thread Tobias Burnus
PING for https://gcc.gnu.org/ml/gcc-patches/2014-11/msg03281.html Only the build changes have still to be reviewed; the Graphite part is already approved – as is the loosely related follow-up patch. Tobias Burnus wrote: This patch adds a configure check for isl_schedule_constraints_compute_sc

Re: [patch] Define new std::ios_base::failure with abi_tag("cxx11")

2014-11-30 Thread Jonathan Wakely
On 24/11/14 18:24 +0100, Tom de Vries wrote: On 24-11-14 18:12, Jonathan Wakely wrote: On 24/11/14 17:48 +0100, Tom de Vries wrote: On 14-11-14 13:18, Jonathan Wakely wrote: This adds system_error support to iostreams, including the required base class changes to std::ios_base::failure. The ab

Re: [Patch, Fortran] fortran/lang.opt cleanup

2014-11-30 Thread FX
> Regarding gfc_warning, what do you think should we do? > a) Mapping gfc_warning to gfc_warning_now as suggested in > https://gcc.gnu.org/ml/fortran/2014-11/msg00141.html I’m not totally convinced that removing buffer for warnings is safe in all cases. Probably we don’t trigger it in the testsu

Re: [Patch, Fortran] fortran/lang.opt cleanup

2014-11-30 Thread Tobias Burnus
FX wrote: Cool stuff! Thanks for doing this, and OK to commit. FX Thanks for the review. Regarding gfc_warning, what do you think should we do? a) Mapping gfc_warning to gfc_warning_now as suggested in https://gcc.gnu.org/ml/fortran/2014-11/msg00141.html or b) Do actual buffering as in h