Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 09:41:16AM +0800, Chen Gang wrote: > On 11/26/14 8:31, Joseph Myers wrote: > > On Wed, 26 Nov 2014, Chen Gang wrote: > > > >> + gcc_assert (wi::fits_to_tree_p (value, char_type_node) > >> +|| wi::fits_to_tree_p (value, short_integer_type_node) > >> +|| wi::

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Ville Voutilainen
On 26 November 2014 at 04:42, Jason Merrill wrote: > On 11/25/2014 09:41 PM, Jason Merrill wrote: >> >> Tested how, exactly? It doesn't seem to have run old-deja.exp. I tend Too hastily, sorry. I managed to notice that the tests adjusted in the patch failed, and then blissfully didn't look at t

Re: [PATCH] gcc parallel make check

2014-11-25 Thread Mike Stump
On Nov 25, 2014, at 12:15 PM, Jakub Jelinek wrote: > On Tue, Nov 25, 2014 at 03:27:40PM +0100, Tom de Vries wrote: >> This patch fixes that by ensuring that we print that unsupported message >> only once. >> >> The resulting test result comparison diff is: >> 2014-11-25 Tom de Vries >> >>

Re: [PATCH 01/05] jit.exp: Avoid embedding full paths into test results

2014-11-25 Thread Mike Stump
On Nov 25, 2014, at 5:34 PM, David Malcolm wrote: > This makes it easier to compare jit.sum files from different runs > > gcc/testsuite/ChangeLog: >* jit.dg/jit.exp (jit-dg-test): Use $name rathen than $prog >when calling jit_check_compile to avoid embedding the full path of >the test

Re: patch to fix PR63527

2014-11-25 Thread Vladimir Makarov
On 2014-11-25 9:21 PM, David Edelsohn wrote: It looks like you already fixed it. I had been looking for the patch on GCC Patches. I did a quick fix as the bootstrap was broken as soon as Mike Meissner wrote me on IRC. The fix was obvious but I postponed to send it until successful bootstra

[PATCH, ARM, libgcc] New aeabi_idiv function for armv6-m

2014-11-25 Thread Hale Wang
Hi, This patch ports the aeabi_idiv routine from Linaro Cortex-Strings (https://git.linaro.org/toolchain/cortex-strings.git), which was contributed by ARM under Free BSD license. The new aeabi_idiv routine is used to replace the one in libgcc/config/arm/lib1funcs.S. This replacement happens with

RE: [PATCH][MIPS] Fix P5600 memory cost

2014-11-25 Thread Prachi Godbole
Hi Matthew, Sorry for the delay. I was running out of memory to build and test the patch. So was in the process of acquiring more memory. I'll commit the patch in a day or two. Regards, Prachi -Original Message- From: Matthew Fortune Sent: Tuesday, November 25, 2014 8:15 PM To: Prachi

[Patch,wwwdoc]Update 5.0 change for ARM new core cortex-m7

2014-11-25 Thread Terry Guo
Hi there, This patch will document support and tuning for Cortex-M7 in GCC 5.0 changes. Is it ok to commit? BR, Terry 2014-11-26 Terry Guo * htdocs/gcc-5/changes.html: Mention Cortex-M7. Index: htdocs/gcc-5/changes.html ==

path fixing PPC bootstrap

2014-11-25 Thread Vladimir Makarov
Mike Meissner pointed me out that my last patch broke PPC bootstrap. I submitted a quick fix for it and now I am sending the path after bootstrap on ppc is done successfully. Sorry for the inconvinience. 2014-11-25 Vladimir Makarov * ira-lives.c (process_bb_node_lives): Make code

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Jason Merrill
On 11/25/2014 09:41 PM, Jason Merrill wrote: Tested how, exactly? It doesn't seem to have run old-deja.exp. I tend to use the toplevel make-c++ target. Er, check-c++. Jason

Re: [C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Jason Merrill
Tested how, exactly? It doesn't seem to have run old-deja.exp. I tend to use the toplevel make-c++ target. +FAIL: g++.old-deja/g++.bob/inherit1.C -std=c++11 depr (test for warnings, line 14) +FAIL: g++.old-deja/g++.bob/inherit1.C -std=c++11 (test for excess errors) +FAIL: g++.old-deja/g++.

Re: patch to fix PR63527

2014-11-25 Thread David Edelsohn
It looks like you already fixed it. I had been looking for the patch on GCC Patches. - David On Tue, Nov 25, 2014 at 9:08 PM, David Edelsohn wrote: > This patch broke bootstrap on AIX > > /nasfarm/edelsohn/src/src/gcc/ira-lives.c:1149:36: error: > 'REAL_PIC_OFFSET_TABLE_REGNUM' was not declared

Re: patch to fix PR63527

2014-11-25 Thread David Edelsohn
This patch broke bootstrap on AIX /nasfarm/edelsohn/src/src/gcc/ira-lives.c:1149:36: error: 'REAL_PIC_OFFSET_TABLE_REGNUM' was not declared in this scope = (find_regno_fusage (insn, USE, REAL_PIC_OFFSET_TABLE_REGNUM) ^ In file included from /nasfarm/edelsohn/

[PATCH 02/02] PR jit/64020: Fixes to handling of builtins

2014-11-25 Thread David Malcolm
Investigating PR jit/64020 showed that tree-ssa-math-opts.c was failing to optimize sin/cos operations within the JIT since this: fndecl = mathfn_built_in (type, BUILT_IN_CEXPI); was returning NULL. Several issues were present: (A) In the JIT we don't pre-build all builtins, just the ones that

[PATCH 01/02] jit-builtins.c: Fix segfault on unsupported builtins

2014-11-25 Thread David Malcolm
jit-builtins.c only supports a subset of builtin-types.def, and can fail if the user requests a builtin that uses the unsupported types. Whilst fixing PR jit/64020 I noticed that these failures read through NULL and segfault. Fix it by checking for get_type and make_builtin_function returning NUL

[PATCH 00/02] jit: Fixes to builtins handling

2014-11-25 Thread David Malcolm
Various fixes/improvements to builtins-handling within jit. Successfully bootstrapped & regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk? (am not yet officially blessed as the JIT maintainer, so I require review for the non-obvious patches)

Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Chen Gang
On 11/26/14 9:38, Joseph Myers wrote: > On Wed, 26 Nov 2014, Chen Gang wrote: > >> And I have no any ideas about the attachments in your reply mail. If it >> is really related with this thread, please let me know. > > I don't understand what attachments you are referring to. > Oh, sorry, my Thu

[PATCH 01/02] PR jit/64018: Add description of error-handling to the JIT tutorial

2014-11-25 Thread David Malcolm
gcc/jit/ChangeLog: PR jit/64018 * docs/intro/tutorial02.rst: Spell out lifetime of generated code. Add description of error-handling, taken in part from... * docs/topics/contexts.rst (Error-handling): Expand, and move some content to tutorial02.rst. --- gcc/

[PATCH 00/02] Improvements to jit documentation

2014-11-25 Thread David Malcolm
Various improvements to jit documentation Touches one of the tutorial examples, which is also used as part of the testsuite: successfully bootstrapped & regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk? (am not yet officially blessed as the JIT maintainer, so I require review for

[PATCH 02/02] Improvements to documentation of gcc_jit_context_release

2014-11-25 Thread David Malcolm
gcc/jit/ChangeLog: * docs/examples/tut02-square.c (main): Release the context earlier, to show that this is possible. Update error-handling to avoid a double-release of the context, and to avoid releasing a NULL result. * docs/intro/tutorial02.rst: Discuss g

Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Joseph Myers
On Wed, 26 Nov 2014, Chen Gang wrote: > And I have no any ideas about the attachments in your reply mail. If it > is really related with this thread, please let me know. I don't understand what attachments you are referring to. -- Joseph S. Myers jos...@codesourcery.com

[PATCH 01/03] Move gcc_jit_result implementation to a new files jit-result.{h|c}

2014-11-25 Thread David Malcolm
Whilst investigating another issue I found I had trouble locating the gcc::jit::result class. It turned out to be declared in jit-recording.h, but implemented in jit-playback.c. Move it to new files: jit-result.{h|c} gcc/jit/ChangeLog: * Make-lang.in (jit_OBJS): Add jit/jit-result.o.

[PATCH 02/03] jit-playback: Move argv-creation to its own function

2014-11-25 Thread David Malcolm
The body of playback::context::compile is rather long, at 200 lines. Start splitting it out parts of it into smaller member functions. Also, eliminate a fixed-size buffer with bounds check in favor of an auto_vec<>. gcc/jit/ChangeLog: * jit-playback.c (gcc::jit::playback::context::compil

[PATCH 00/03] JIT refactoring

2014-11-25 Thread David Malcolm
Various cleanups of the jit code Successfully bootstrapped & regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk? (am not yet officially blessed as the JIT maintainer, so I require review for the non-obvious patches)

[PATCH 03/03] jit-playback: Move dso-creation into its own function

2014-11-25 Thread David Malcolm
Continue to refactor playback::context::compile, moving the DSO-generation into its own function. gcc/jit/ChangeLog: * jit-playback.c (gcc::jit::playback::context::compile): Move DSO creation code into... (gcc::jit::playback::context::convert_to_dso): New function.

Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Chen Gang
On 11/26/14 8:31, Joseph Myers wrote: > On Wed, 26 Nov 2014, Chen Gang wrote: > >> + gcc_assert (wi::fits_to_tree_p (value, char_type_node) >> + || wi::fits_to_tree_p (value, short_integer_type_node) >> + || wi::fits_to_tree_p (value, integer_type_node) >> + || wi::fits

[PATCH 06/08] Avoid overuse of name "buffer" in tree-pretty-print.c

2014-11-25 Thread David Malcolm
Various functions in tree-pretty-print.c take a param pretty_printer *buffer and there's also a static pretty_printer *buffer; Additionally, pretty_printer instances are not buffers; they *contain* buffers (inasmuch as they have a field "buffer"). This patch renames such params from "buffer" to

[PATCH 08/08] PR/64003 workaround (uninit memory in i386.md)

2014-11-25 Thread David Malcolm
I suspect this is papering over a real problem, but I've been applying this workaround locally to keep my valgrind output clean. gcc/ChangeLog: PR/64003 * final.c (shorten_branches): Allocate insn_lengths with XCNEWVEC rather than XNEWVEC; remove subsequent per-element

[PATCH 04/08] PR jit/63854: Remove xstrdup from ipa/cgraph fprintf calls

2014-11-25 Thread David Malcolm
cgraph*.c and ipa-*.c use xstrdup on strings when dumping them via fprintf, leaking all of the duplicated buffers. Is/was there a reason for doing this? Taking them out fixes these leaks (seen when dumping is enabled): 12 bytes in 1 blocks are definitely lost in loss record 11 of 148 at 0x4A0645

[PATCH 07/08] PR jit/63854: Fix leaks in toyvm.c

2014-11-25 Thread David Malcolm
Introduce a struct toyvm_compiled_function so that we can clean things up fully, avoiding warnings from valgrind. gcc/jit/ChangeLog: PR jit/63854 (toyvm_compiled_function): New typedef. (toyvm_compiled_func) Rename to... (toyvm_compiled_code) ...this. (struc

[PATCH 05/08] PR jit/63854: Fix double-initialization within tree-pretty-print.c

2014-11-25 Thread David Malcolm
Running various JIT testcases under valgrid showed this one-time leak: 8,464 (336 direct, 8,128 indirect) bytes in 1 blocks are definitely lost in loss record 144 of 147 at 0x4A081D4: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x5DF4EA0: xcalloc (xmalloc.c:162)

[PATCH 02/08] PR jit/63854: Fix leak within jit-builtins.c

2014-11-25 Thread David Malcolm
Running testsuite/jit.dg/test-functions.c under valgrind showed this leak (amongst others): 520 (320 direct, 200 indirect) bytes in 5 blocks are definitely lost in loss record 144 of 181 at 0x4A06965: operator new(unsigned long) (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by

[PATCH 03/08] PR jit/63854: Fix leak in real.c for i386:init_ext_80387_constants

2014-11-25 Thread David Malcolm
Valgrind of testsuite/jit.dg/test-types.c showed this leak in real.c when converting the strings in init_ext_80387_constants to real. 160 bytes in 5 blocks are definitely lost in loss record 89 of 144 at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x30AF4

[PATCH 00/08] More memory leak fixes

2014-11-25 Thread David Malcolm
Various fixes/improvements to jit.exp Successfully bootstrapped & regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk?

[PATCH 01/08] PR jit/63854: Fix leak in tree-ssa-math-opts.c

2014-11-25 Thread David Malcolm
Running testsuite/jit.dg/test-functions.c under valgrind showed this leak (amongst others): 400 bytes in 10 blocks are definitely lost in loss record 142 of 181 at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x5DCDF2F: xrealloc (xmalloc.c:177) by 0x537

[PATCH 04/05] jit.exp: Verify the exit status of the spawnee

2014-11-25 Thread David Malcolm
gcc/testsuite/ChangeLog: * jit.dg/jit.exp (verify_exit_status): New function. (fixed_host_execute): Verify the exit status of the spawnee. --- gcc/testsuite/jit.dg/jit.exp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/gcc/testsuite/jit.dg/jit.e

[PATCH 05/05] Add command-line option-parsing to jit testcases

2014-11-25 Thread David Malcolm
Add command-line option-parsing to the testcases, so that we can manipulate them without needing a recompile (e.g. varying optimization levels etc). This uses getopt_long, which is a GNU extension to libc. Is that acceptable? Implement a --num-iterations option, to override the default of 5. Wh

[PATCH 02/05] PR jit/63854: Add support for running "make check-jit" under valgrind

2014-11-25 Thread David Malcolm
This commit updates jit.exp so that if RUN_UNDER_VALGRIND is present in the environment, all of the built client code using libgccjit.so is run under valgrind, with --leak-check=full. Hence: RUN_UNDER_VALGRIND= make check-jit will run all jit testcases under valgrind (taking 27 mins on my machin

[PATCH 01/05] jit.exp: Avoid embedding full paths into test results

2014-11-25 Thread David Malcolm
This makes it easier to compare jit.sum files from different runs gcc/testsuite/ChangeLog: * jit.dg/jit.exp (jit-dg-test): Use $name rathen than $prog when calling jit_check_compile to avoid embedding the full path of the testcase into the test results. --- gcc/testsuite/j

[PATCH 03/05] jit.exp: fix timeout bug inherited from dejagnu.exp

2014-11-25 Thread David Malcolm
DejaGnu's host_execute has an erroneous line that appears to be a merge conflict that went awry followed up by a reindent, and jit.exp has inherited this bug within "fixed_host_execute". Fix it within jit.exp. Reported to DejaGnu as: http://lists.gnu.org/archive/html/dejagnu/2014-11/msg1.ht

[PATCH 00/05] Fixes to jit.exp

2014-11-25 Thread David Malcolm
Various fixes/improvements to jit.exp Successfully bootstrapped & regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk? (am not yet officially blessed as the JIT maintainer, so I require review for the non-obvious patches)

[PATCH 00/05] Fixes to jit.exp

2014-11-25 Thread David Malcolm
Various fixes/improvements to jit.exp Successfully bootstrapped & regrtested on x86_64-unknown-linux-gnu (Fedora 20). OK for trunk? (am not yet officially blessed as the JIT maintainer, so I require review for the non-obvious patches)

Re: [PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-11-25 Thread Jason Merrill
On 11/25/2014 05:57 PM, Mark Wielaard wrote: This implements the DWARFv5 noreturn proposal: http://dwarfstd.org/ShowIssue.php?issue=140331.1 TREE_THIS_VOLATILE on a FUNCTION_DECL node means the function does not return normally. This catches the traditional noreturn GNU attribute, the C11 _Noret

Re: [PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-25 Thread Trevor Saunders
On Tue, Nov 25, 2014 at 09:59:46PM +0100, Jan Hubicka wrote: > > From: Trevor Saunders > > > > Hi, > > > > the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. > > It > > refers to nothing, and is called by nothing, however it is kept (I believe > > because of -fkeep-inlin

Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Joseph Myers
On Wed, 26 Nov 2014, Chen Gang wrote: > + gcc_assert (wi::fits_to_tree_p (value, char_type_node) > + || wi::fits_to_tree_p (value, short_integer_type_node) > + || wi::fits_to_tree_p (value, integer_type_node) > + || wi::fits_to_tree_p (value, long_integer_type_node)

[C++ PATCH] Diagnose conversions from string constants to char* as forbidden, not deprecated, in c++11 and above

2014-11-25 Thread Ville Voutilainen
Tested on Linux-x64. Remotely related to pr50645, which we should probably close as invalid. /cp 2014-11-26 Ville Voutilainen Diagnose string constant conversion to char* in c++11 and above as forbidden, not deprecated. * typeck.c (string_conv_p): Do a pedwarn in c++11 and above,

Re: More weakref fixes

2014-11-25 Thread H.J. Lu
On Fri, Aug 30, 2013 at 8:54 AM, Jan Hubicka wrote: > Hi, > this patch fixes gcc.dg/tree-ssa/attr-alias.c on x86-64 target. > The problem here is that we attempt to create local alias since we consider > weakref > of test() to be overwritable and at the same time available. > The change in cgraph

[PATCH] DWARF add DW_AT_noreturn on noreturn function subprogram.

2014-11-25 Thread Mark Wielaard
This implements the DWARFv5 noreturn proposal: http://dwarfstd.org/ShowIssue.php?issue=140331.1 TREE_THIS_VOLATILE on a FUNCTION_DECL node means the function does not return normally. This catches the traditional noreturn GNU attribute, the C11 _Noreturn keyword and the C++11 [[noreturn]] attribut

Re: [Patch, Fortran] convert almost all {warning,error}_now to common diagnostic

2014-11-25 Thread Tobias Burnus
FX: (a) those majority which might need buffering (gfc_error, gfc_warning); Is there a plan for those in the longer term? Well, the long-term solution is of course to support them. That requires adding buffering+discarding support to the common machinery and to use it then in gfortran. It's

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2014-11-25 Thread Jeff Law
On 11/25/14 13:57, Phil Muldoon wrote: On 25/11/14 20:37, Mike Stump wrote: On Nov 23, 2014, at 4:06 PM, FX wrote: One question to build maintainers, and one patch submitted to top-level configure.ac So, not sure who wants to review this. From the darwin perspective, Ok. I mean from my l

Re: Move dwarf2 frame tables to read-only section for AIX

2014-11-25 Thread Andrew Dixie
Hi, The following patch substantially reduces the memory requirements of GCC compiled C++ programs on AIX. Currently there are two different pieces of code to decide if a read-only or a read-write section is required for exception information: - If the target supports named sections, there is goo

Re: [PATCH, Pointer Bounds Checker, Builtins instrumentation 1/5] Builtin codes and decls

2014-11-25 Thread H.J. Lu
On Thu, Nov 6, 2014 at 3:48 AM, Ilya Enkovich wrote: > Hi, > > This is the first patch in a series to enable builtin function calls > instrumentation by Poitner Bounds Checker. Previously builtins > instrumentation was disabled in checker because it allowed two function calls > with the same f

Re: [PATCH][ARM] testsuite, use arm_eabi #3

2014-11-25 Thread Andreas Tobler
On 11.11.14 00:45, Mike Stump wrote: On Nov 10, 2014, at 2:06 PM, Andreas Tobler wrote: another one. Here I'm not really sure if there are EABI variants which do _not_ support these test cases. I think the patch is fine, just watch for any follow-on comments from an eabi/arm expert. Usuall

Re: [PATCH 2/5] combine: handle I2 a parallel of two SETs

2014-11-25 Thread Segher Boessenkool
On Tue, Nov 25, 2014 at 11:35:14AM -0700, Jeff Law wrote: > On 11/14/14 12:19, Segher Boessenkool wrote: > >If I2 is a PARALLEL of two SETs, split it into two instructions, I1 > >and I2. If there already was an I1, rename it to I0. If there > >already was an I0, don't do anything. > > > >This sur

Re: [PATCH 4/5] combine: distribute_log_links for PARALLELs of SETs

2014-11-25 Thread Segher Boessenkool
On Tue, Nov 25, 2014 at 12:37:57PM -0700, Jeff Law wrote: > This is OK once prereqs are approved. That is only 3/5 now. > You might consider pushing the two LOG_LINKs related patches forward > independently of the patch to rip apart the PARALLELs. Though I think > that all of the patches are p

Re: [PATCH 3/5] combine: add regno field to LOG_LINKS

2014-11-25 Thread Segher Boessenkool
On Tue, Nov 25, 2014 at 11:46:52AM -0700, Jeff Law wrote: > On 11/14/14 12:19, Segher Boessenkool wrote: > >With this new field in place, we can have LOG_LINKS for insns that set > >more than one register and distribute them properly in distribute_links. > >This then allows many more PARALLELs to b

Re: [Patch, Fortran] convert almost all {warning,error}_now to common diagnostic

2014-11-25 Thread FX
> (a) those majority which might need buffering (gfc_error, gfc_warning); Is there a plan for those in the longer term? > Bootstrapped and regtested on x86-64-gnu-linux. > OK for the trunk? OK

Re: [Patch, Fortran] Move gfc_internal_error to common diagnostics

2014-11-25 Thread FX
> Build and regtested on x86-64-gnu-linux. > OK for the trunk? OK

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-25 Thread Sebastian Pop
Sebastian Pop wrote: > I will bootstrap and regression test this patch on x86_64-linux and > powerpc64-linux. I will also run it on our internal benchmarks, coremark, and > the llvm test-suite. > > I will also include a longer testcase that makes sure we do not regress on > coremark. Done all th

Re: patch to fix PR63527

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 12:54 PM, H.J. Lu wrote: > On Tue, Nov 25, 2014 at 12:22 PM, Vladimir Makarov > wrote: >> The following patch fixes >> >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63527 >> >> The patch was tested and bootstrapped on x86/x86-64. >> >> Committed as rev. 218509. >> >> ht

Re: [PATCH] pr61324 pr 63649 - fix crash in ipa_comdats

2014-11-25 Thread Jan Hubicka
> From: Trevor Saunders > > Hi, > > the interesting symbol in the test case for pr61324 is __GLOBAL__sub_I_s. It > refers to nothing, and is called by nothing, however it is kept (I believe > because of -fkeep-inline-functions). That means ipa_comdats never tries to > put Aha, that explans w

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2014-11-25 Thread Phil Muldoon
On 25/11/14 20:37, Mike Stump wrote: > On Nov 23, 2014, at 4:06 PM, FX wrote: >> One question to build maintainers, and one patch submitted to top-level >> configure.ac > > So, not sure who wants to review this. From the darwin perspective, Ok. I mean from my limited viewpoint it looks fine. As

Re: [PATCH] Fix PR ipa/61190, updated

2014-11-25 Thread Jan Hubicka
> > Index: gcc/ipa-pure-const.c > > === > > --- gcc/ipa-pure-const.c (revision 215888) > > +++ gcc/ipa-pure-const.c (working copy) > > @@ -744,6 +744,8 @@ analyze_function (struct cgraph_node *fn, bool ipa > > { > > /* Thunk gets propa

Re: patch to fix PR63527

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 12:22 PM, Vladimir Makarov wrote: > The following patch fixes > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63527 > > The patch was tested and bootstrapped on x86/x86-64. > > Committed as rev. 218509. > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63527 I checked in t

Re: [patch, build] Restore bootstrap in building libcc1 on darwin

2014-11-25 Thread Mike Stump
On Nov 23, 2014, at 4:06 PM, FX wrote: > One question to build maintainers, and one patch submitted to top-level > configure.ac So, not sure who wants to review this. From the darwin perspective, Ok.

Re: [PATCH] mn10300: Fix an ICE

2014-11-25 Thread David Malcolm
On Tue, 2014-11-25 at 10:15 -0700, Jeff Law wrote: > On 11/25/14 10:14, Segher Boessenkool wrote: > > On Tue, Nov 25, 2014 at 09:44:35AM -0700, Jeff Law wrote: > >> On 11/24/14 20:37, Segher Boessenkool wrote: > >>> `lcc' is not an insn but just a pattern. This caused a build error in > >>> libgcc

patch to fix PR63527

2014-11-25 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63527 The patch was tested and bootstrapped on x86/x86-64. Committed as rev. 218509. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63527 Index: ira-lives.c === -

Re: [PATCH] gcc parallel make check

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 03:27:40PM +0100, Tom de Vries wrote: > This patch fixes that by ensuring that we print that unsupported message only > once. > > The resulting test result comparison diff is: > 2014-11-25 Tom de Vries > > * testsuite/libstdc++-prettyprinters/prettyprinters.exp:

Re: PATCH: PR rtl-optimization/64037: Miscompilation with -Os and enum class : char parameter

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 7:04 AM, Richard Biener wrote: > On Tue, Nov 25, 2014 at 4:01 PM, Richard Biener > wrote: >> On Tue, Nov 25, 2014 at 1:57 PM, H.J. Lu wrote: >>> Hi, >>> >>> The enclosed testcase fails on x86 when compiled with -Os since we pass >>> a byte parameter with a byte load in ca

Re: [PATCH, libobjc]: Remove ‘...’ is static but used in inline function ‘...’ which is not static

2014-11-25 Thread Andrew Pinski
On Tue, Nov 25, 2014 at 11:09 AM, Uros Bizjak wrote: > Hello! > > Recently, gcc bootstrap started to emit following warnings when > building libobjc: > > libobjc/sendmsg.c:338:13: warning: ‘get_implementation’ is static but > used in inline function ‘get_imp’ which is not static > libobjc/sendmsg.

[PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Chen Gang
The original length 18 is not enough for HOST_WIDE_INT printing, need use 20 instead of. Also need additional bytes for printing related prefix and suffix, and give a related check. It passes testsuite under fedora 20 x86_64-unknown-linux-gnu. 2014-11-26 Chen Gang * c-family/c-cppbui

Re: [patch c++]: Fix PR/53904

2014-11-25 Thread Jason Merrill
On 11/20/2014 02:48 PM, Kai Tietz wrote: this issue fixes a type-overflow issue caused by trying to cast a UHWI via tree_to_shwi. As soon as value gets larger then SHWI_MAX, we get an error for it. So we need to cast it via tree_to_uhwi, and then casting it to the signed variant. The problem s

Re: [PATCH 4/5] combine: distribute_log_links for PARALLELs of SETs

2014-11-25 Thread Jeff Law
On 11/14/14 12:19, Segher Boessenkool wrote: Now that LOG_LINKS are per regno, we can distribute them on PARALLELs just fine. Do so. This makes PARALLELs not lose their LOG_LINKS early when e.g. a trivial reg-reg move is combined, so that they can be used in more useful combinations as well.

Re: Document __builtin_*_overflow

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 07:50:02PM +0100, Gerald Pfeifer wrote: > Hi Jakub, > > On Wednesday 2014-11-12 14:13, Jakub Jelinek wrote: > > This patch mentions __builtin_*_overflow in gcc-5/changes.html. > > Ok for CVS? > > I've fallen a bit behind with GCC patches, sorry. > > What do you think abou

[PATCH, libobjc]: Remove ‘...’ is static but used in inline function ‘...’ which is not static

2014-11-25 Thread Uros Bizjak
Hello! Recently, gcc bootstrap started to emit following warnings when building libobjc: libobjc/sendmsg.c:338:13: warning: ‘get_implementation’ is static but used in inline function ‘get_imp’ which is not static libobjc/sendmsg.c:335:15: warning: ‘sarray_get_safe’ is static but used in inline fu

Re: [patch] Restore bootstrap on powerpc*-apple-darwin*

2014-11-25 Thread FX
>> 2014-11-24 Rohit >> >> PR bootstrap/63703 >> * config/rs6000/darwin.h (REGISTER_NAMES): Update based on 32 newly >> added GCC hard register numbers for SPE high registers. >> > > IMO, it's obvious, and as you say, doesn't touch any other target. After further confirmations

[ping^4] [libgomp] make it possible to use OMP on both sides of a fork

2014-11-25 Thread Nathaniel Smith
Ping^4 for: https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00519.html On Tue, Nov 18, 2014 at 12:53 AM, Nathaniel Smith wrote: > Hello, > > Ping for https://gcc.gnu.org/ml/gcc-patches/2014-11/msg00519.html > >> Patches posted early enough during Stage 1 and not yet fully reviewed >> may still get

Re: Document __builtin_*_overflow

2014-11-25 Thread Gerald Pfeifer
Hi Jakub, On Wednesday 2014-11-12 14:13, Jakub Jelinek wrote: > This patch mentions __builtin_*_overflow in gcc-5/changes.html. > Ok for CVS? I've fallen a bit behind with GCC patches, sorry. What do you think about this follow-up patch on top of yours? Gerald Index: changes.html =

Re: [PATCH 3/5] combine: add regno field to LOG_LINKS

2014-11-25 Thread Jeff Law
On 11/14/14 12:19, Segher Boessenkool wrote: With this new field in place, we can have LOG_LINKS for insns that set more than one register and distribute them properly in distribute_links. This then allows many more PARALLELs to be combined. Also split off new functions can_combine_{def,use}_p f

Re: [PATCH 2/5] combine: handle I2 a parallel of two SETs

2014-11-25 Thread Jeff Law
On 11/14/14 12:19, Segher Boessenkool wrote: If I2 is a PARALLEL of two SETs, split it into two instructions, I1 and I2. If there already was an I1, rename it to I0. If there already was an I0, don't do anything. This surprisingly simple patch is enough to let combine handle such PARALLELs pro

Re: [PATCH, libgfortran]: Remove unused variable

2014-11-25 Thread Steve Kargl
On Tue, Nov 25, 2014 at 07:17:17PM +0100, Uros Bizjak wrote: > > 2014-11-25 Uros Bizjak > > * intrinsics/env.c (getenv): Remove unused variable res_len. > > Bootstrapped on x86_64-linux-gnu. > > Almost trivial, but ... OK for mainline? > Yes. -- Steve

[PATCH, libgfortran]: Remove unused variable

2014-11-25 Thread Uros Bizjak
Hello! 2014-11-25 Uros Bizjak * intrinsics/env.c (getenv): Remove unused variable res_len. Bootstrapped on x86_64-linux-gnu. Almost trivial, but ... OK for mainline? Uros. Index: intrinsics/env.c === --- intrinsics/env.c

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-25 Thread Sebastian Pop
Jeff Law wrote: > On 11/24/14 21:55, Jeff Law wrote: > >On 11/24/14 18:09, Sebastian Pop wrote: > >>Sebastian Pop wrote: > >>>I removed the return -1 and started a bootstrap on powerpc64-linux. > >> > >>Bootstrap passed on top of the 4 previous patches on powerpc64-linux. > >> > >>>I will report th

Re: [PATCH] Fix a bug in bt-load.c

2014-11-25 Thread Jeff Law
On 11/25/14 10:26, Segher Boessenkool wrote: On Tue, Nov 25, 2014 at 09:41:40AM -0700, Jeff Law wrote: On 11/24/14 20:56, Segher Boessenkool wrote: This caused ICEs on sh64. `min_cost' and `def' here are supposed to refer to the same element; removing it from the heap before asking the heap fo

Re: [PATCH] Fix a bug in bt-load.c

2014-11-25 Thread Segher Boessenkool
On Tue, Nov 25, 2014 at 09:41:40AM -0700, Jeff Law wrote: > On 11/24/14 20:56, Segher Boessenkool wrote: > >This caused ICEs on sh64. > > > >`min_cost' and `def' here are supposed to refer to the same element; > >removing it from the heap before asking the heap for the key doesn't > >work (and at t

Re: [PATCH] mn10300: Fix an ICE

2014-11-25 Thread Jeff Law
On 11/25/14 10:14, Segher Boessenkool wrote: On Tue, Nov 25, 2014 at 09:44:35AM -0700, Jeff Law wrote: On 11/24/14 20:37, Segher Boessenkool wrote: `lcc' is not an insn but just a pattern. This caused a build error in libgcc. A good example of a case that would have been caught if we get to

Re: [PATCH] mn10300: Fix an ICE

2014-11-25 Thread Segher Boessenkool
On Tue, Nov 25, 2014 at 09:44:35AM -0700, Jeff Law wrote: > On 11/24/14 20:37, Segher Boessenkool wrote: > >`lcc' is not an insn but just a pattern. This caused a build error in > >libgcc. > A good example of a case that would have been caught if we get to a > point where stuff in the insn chain

[PATCH] Enhance ASAN_CHECK optimization

2014-11-25 Thread Yury Gribov
Hi all, This patch improves current optimization of ASAN_CHECKS performed by sanopt pass. In addition to searching the sanitized pointer in asan_check_map, it also tries to search for definition of this pointer. This allows more checks to be dropped when definition is not a gimple value (e.

Re: [PING][PATCH] Change contrib/test_installed for testing cross compilers

2014-11-25 Thread Jeff Law
On 11/24/14 09:51, Alan Lawrence wrote: Having just been experimenting with testing of installed compilers - yes something like this could be useful, however: to do cross-testing I found I also (a) had to set my target_list; so either an extra flag for that, or maybe just a generic 'extra_site_fl

Re: [PATCH] mn10300: Fix an ICE

2014-11-25 Thread Jeff Law
On 11/24/14 20:37, Segher Boessenkool wrote: `lcc' is not an insn but just a pattern. This caused a build error in libgcc. Tested with a cross compiler build (which fails without and succeeds with the patch). Not tested much more; this compiler really likes to ICE, something with ipa-icf. Is t

Re: [PATCH] Fix a bug in bt-load.c

2014-11-25 Thread Jeff Law
On 11/24/14 20:56, Segher Boessenkool wrote: This caused ICEs on sh64. `min_cost' and `def' here are supposed to refer to the same element; removing it from the heap before asking the heap for the key doesn't work (and at the end of the loop here we will ask for min_key on an empty heap, which t

[PATCH] pr31397 - implement -Wsuggest-override

2014-11-25 Thread tsaunders
From: Trevor Saunders Hi, this is a new warning to find places where virtual functions are over ridden, but not marked override. included test passes, I expect comments so regtest is pending, and ChangeLog is omitted. Trev --- gcc/c-family/c.opt| 5 + gcc/c

Re: [PATCH] crtstuff: Add missing semicolon

2014-11-25 Thread Jeff Law
On 11/24/14 20:44, Segher Boessenkool wrote: I wonder how this survived so long, I must be building some strange configs (it failed on an avr cross). Okay for trunk? Segher 2014-11-24 Segher Boessenkool libgcc/ * crtstuff.c (__do_glbal_ctors_1): Add missing semicolon. I think th

Re: [Patch] Improving jump-thread pass for PR 54742

2014-11-25 Thread Jeff Law
On 11/24/14 21:55, Jeff Law wrote: On 11/24/14 18:09, Sebastian Pop wrote: Sebastian Pop wrote: I removed the return -1 and started a bootstrap on powerpc64-linux. Bootstrap passed on top of the 4 previous patches on powerpc64-linux. I will report the valgrind output. The output from valg

Re: [PATCH][AArch64] Remove crypto extension from default for cortex-a53, cortex-a57

2014-11-25 Thread Kyrill Tkachov
On 25/11/14 01:36, Gerald Pfeifer wrote: On Tuesday 2014-11-18 09:38, Kyrill Tkachov wrote: Here's what I propose. + The cryptographic extensions to the ARMv8-A architecture are no + longer enabled by default when specifying the + -mcpu=cortex-a53, -mcpu=cortex-a57 or +

Re: PATCH: PR rtl-optimization/64037: Miscompilation with -Os and enum class : char parameter

2014-11-25 Thread H.J. Lu
On Tue, Nov 25, 2014 at 7:01 AM, Richard Biener wrote: > On Tue, Nov 25, 2014 at 1:57 PM, H.J. Lu wrote: >> Hi, >> >> The enclosed testcase fails on x86 when compiled with -Os since we pass >> a byte parameter with a byte load in caller and read it as an int in >> callee. The reason it only show

Re: [PATCH] Add verify_sese

2014-11-25 Thread Richard Biener
On Tue, Nov 25, 2014 at 3:59 PM, Tom de Vries wrote: > On 25-11-14 10:28, Richard Biener wrote: >> >> On Tue, Nov 25, 2014 at 1:01 AM, Tom de Vries >> wrote: >>> >>> Richard, >>> >>> I ran into a problem with my oacc kernels directive patch series where >>> tail-merge added another entry into a r

Re: [PATCH 1/2] teach mklog to get name / email from git config when available

2014-11-25 Thread Diego Novillo
On 20/11/2014, 16:51 , Tom de Vries wrote: OK for trunk? This is fine. Thanks. Diego.

[PATCH, MIPS, COMMITTED] Testsuite fixes for soft-float configurations

2014-11-25 Thread Matthew Fortune
Re: https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02879.html The new FPXX tests now work correctly for soft-float configurations. Tests should only need to specify one of the 5 floating-point options and any other options are then inferred from that. The FPXX tests were the first tests to really r

Re: PATCH: PR rtl-optimization/64037: Miscompilation with -Os and enum class : char parameter

2014-11-25 Thread Richard Biener
On Tue, Nov 25, 2014 at 4:01 PM, Richard Biener wrote: > On Tue, Nov 25, 2014 at 1:57 PM, H.J. Lu wrote: >> Hi, >> >> The enclosed testcase fails on x86 when compiled with -Os since we pass >> a byte parameter with a byte load in caller and read it as an int in >> callee. The reason it only show

  1   2   >