Re: [PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C

2014-10-16 Thread Tobias Burnus
Manuel López-Ibáñez wrote: This patch adds handling of Fortran %C using the common diagnostics machinery. This is achieved by dynamically generating a location given a location and an offset. This only works for non-macro line-maps (for now), but this is OK since Fortran does not have virtual loc

Re: [PATCH Fortran] rename gfc_warning_cmdline to gfc_warning_now_2

2014-10-16 Thread Tobias Burnus
Manuel López-Ibáñez wrote: This patch is mostly cleanups, sorry for the churn. The next one will be far more interesting. Boot®tested on x86_64-linux-gnu. OK? Looks good to me. Thanks! Tobias gcc/fortran/ChangeLog: 2014-10-16 Manuel López-Ibáñez PR fortran/44054 * gfortran.h (

Re: [RFC PATCH, i386]: Remove special PIC related __cpuid definitions from config/i386/cpuid.h

2014-10-16 Thread Uros Bizjak
On Thu, Oct 16, 2014 at 12:25 PM, Uros Bizjak wrote: >>> >> Now that %ebx is also allocatable in PIC modes, we can cleanup >>> >> config/i386/cpuid considerably. I propose to remove all PIC related >>> >> specializations of __cpuid and __cpuid_count and protect the >>> >> compilation with "#if __

Re: [PATCH] remove score-* support

2014-10-16 Thread Trevor Saunders
On Thu, Oct 16, 2014 at 11:45:37PM +0200, Matthias Klose wrote: > Am 03.10.2014 um 17:35 schrieb Jeff Law: > > On 10/03/14 08:50, tsaund...@mozilla.com wrote: > >> From: Trevor Saunders > >> > >> Hi, > >> > >> It was obsoleted back in 2011, so we're good to remove it. > >> > >> bootstrapped + regt

Re: [PATCH][4/n] Merge from match-and-simplify, hook into fold-const.c

2014-10-16 Thread Trevor Saunders
On Thu, Oct 16, 2014 at 09:14:18PM +0200, Jakub Jelinek wrote: > On Thu, Oct 16, 2014 at 06:58:25PM +, Sebastian Pop wrote: > > Richard Biener wrote: > > > To give you an example how it looks like, the following code is > > > generated for > > > > > > /* fold_negate_exprs convert - (~A) to A +

[PATCH] Fix race in libstdc++ testsuite

2014-10-16 Thread Maxim Kuvyrkov
Hi, This patch fixes a race in libstdc++ testsuite. When we split libstdc++'s testsuite into several parallel instances, it may occur that testing for features (check_v3_target_fileio in this case) is done in two sub-processes at the same time. The race occurs on the cin_unget-1.txt data file

Re: [PATCH 4/5] State cleanups -- also note for MPX work

2014-10-16 Thread David Malcolm
On Thu, 2014-10-16 at 16:06 -0600, Jeff Law wrote: > On 10/13/14 11:45, David Malcolm wrote: > > This patch contains various cleanups needed by the jit, so that we can > > rerun the compiler code repeatedly within the same process: > > > > * Introduce per-file finalization routines to clean up file

Re: [gofrontend-dev] [PATCH 0/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:44 AM, Dominik Vogt wrote: > > The following series' of patches introduce s390[x] support for > Gccgo. For practical reasons they will be submitted in separate > parts. This is the first part of the submissions with > architecture independent bug fixes and enhancements t

Re: [gofrontend-dev] [PATCH 9/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:06 AM, Dominik Vogt wrote: > > Quote shell variables that may contain whitespace in the configure > file. I cannot remember exactly whether I actually ran into a > problem, but the patch won't hurt anyway. > > ChangeLog > 2014-09-05 Dominik Vogt > > * libgo/con

Re: [gofrontend-dev] [PATCH 8/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:04 AM, Dominik Vogt wrote: > This is an optional extension of the -fgo-dump-spec option to > handle copmplex data types. It is not necessary for s390[x] but > was easy to write on top of the previous patch. > > gcc/ChangeLog > 2014-09-05 Dominik Vogt > > * godu

Re: [gofrontend-dev] [PATCH 7/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 6:02 AM, Dominik Vogt wrote: > This patch extends the -fdump-go-spec option to handle bitfields > and unions and fixes handlinx of zero length arrays. All of this > is necessary for s390[x] since the system headers use these > features. Please check the commit comment for

[fortran,patch] Handle infinities and NaNs in intrinsics code generation

2014-10-16 Thread FX
ping > After the compile-time simplification, this patch fixes the handling of > special values (infinities and NaNs) by intrinsics EXPONENT, FRACTION, > SPACING, RRSPACING & SET_EXPONENT on the code generation side. > > Bootstrapped and regtested on x86_64-linux. > OK to commit? intrinsics.

Re: [gofrontend-dev] [PATCH 6/9] Gccgo port to s390[x] -- part I

2014-10-16 Thread Ian Lance Taylor
On Tue, Sep 9, 2014 at 5:58 AM, Dominik Vogt wrote: > Eases the rediculously tight minimum stack size for goprocesses on > 64 bit systems. > > ChangeLog > 2014-09-05 Dominik Vogt > > * libgo/runtime/proc.c (runtime_newosproc): Set the thread stack size > explicitly only on 32 bi

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-16 Thread DJ Delorie
> FAIL: g++.dg/init/enum1.C -std=gnu++11 (test for errors, line 12) > FAIL: g++.dg/init/enum1.C -std=gnu++1y (test for errors, line 12) > FAIL: g++.dg/init/enum1.C -std=gnu++98 (test for errors, line 12) > > That used to complain about "enum1.C:12:1: error: no integral type can > represent

Re: Towards GNU11

2014-10-16 Thread Andrew Pinski
On Thu, Oct 16, 2014 at 3:35 PM, Andrew Pinski wrote: > On Wed, Oct 15, 2014 at 3:08 AM, Marek Polacek wrote: >> On Tue, Oct 14, 2014 at 09:23:29AM +0200, Marek Polacek wrote: >>> The consensus seems to be to go forward with this change. I will >>> commit the patch in 24 hours unless I hear obje

Re: Towards GNU11

2014-10-16 Thread Andrew Pinski
On Wed, Oct 15, 2014 at 3:08 AM, Marek Polacek wrote: > On Tue, Oct 14, 2014 at 09:23:29AM +0200, Marek Polacek wrote: >> The consensus seems to be to go forward with this change. I will >> commit the patch in 24 hours unless I hear objections. > > I made the change. Please report any fallout to

Re: [C PATCH] Don't ICE on invalid code (PR c/63549)

2014-10-16 Thread Jeff Law
On 10/16/14 14:12, Marek Polacek wrote: We ICEd on this invalid testcase because build_array_ref was getting a decl with an incomplete type as an index, and default_conversion calls require_complete_type on it - and because it's not complete, it returns error_mark_node, and then we trip on an ass

[PATCH][target/x86_64] PR 63538

2014-10-16 Thread Sriraman Tallam
Hi, I have attached patch for bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63538 Please review. Thanks Sri With -mcmodel=medium, .lrodata accesses must use far address. Here the check for TREE_CODE(decl) == VAR_DECL in function ix86_encode_section_info is removed as this does not handl

Re: -fuse-caller-save - Collect register usage information

2014-10-16 Thread Mike Stump
On Oct 16, 2014, at 2:28 PM, Tom de Vries wrote: > So I'd say the documentation is in fact correct. Agreed. I was confused. Apparently my mind likes to think in volatile and non-volatile (call-clobbered and non-call-clobbered) and I managed to map it wrong in my mind and not catch that fact I

Re: Fix nullptr access in true_regnum

2014-10-16 Thread Jeff Law
On 10/16/14 15:33, Oleg Endo wrote: Hi, While working on some SH builtins I ran into the issue that the function true_regnum in jump.c tries to access the reg_renumber array without checking for nullptr. The particular use case here is using true_regnum in a predicate that is invoked during bui

Re: [patch]add function.h flattened includes to gcc-plugin.h

2014-10-16 Thread Jeff Law
On 10/16/14 14:52, Andrew MacLeod wrote: In an attempt to not screw up every plugin user again this release, I'll try to add any flattened includes and any pre-requiresites into gcc-plugin.h, as discussed here: https://gcc.gnu.org/ml/gcc/2014-10/msg00127.html This patch adds those includes to gc

[PATCH] Optimize range tests into bittests (PR tree-optimization/63464)

2014-10-16 Thread Jakub Jelinek
Hi! This patch optimizes some range tests into bit tests, like we already do for switches in emit_case_bit_tests, but this time for a series of ored equality or anded non-equality comparisons. If at least 3 comparisons (after the contiguous range, xor and diff + xor optimizations are performed) ar

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-16 Thread Jeff Law
On 10/16/14 11:20, Marek Polacek wrote: On Wed, Oct 15, 2014 at 09:46:20PM +, Joseph S. Myers wrote: On Wed, 15 Oct 2014, Marek Polacek wrote: We've got a complaint that the "dereferencing pointer to incomplete type" error is printed for all occurrences of the incomplete type, which is too

Re: [PATCH 4/5] State cleanups -- also note for MPX work

2014-10-16 Thread Jeff Law
On 10/13/14 11:45, David Malcolm wrote: This patch contains various cleanups needed by the jit, so that we can rerun the compiler code repeatedly within the same process: * Introduce per-file finalization routines to clean up file-static variables. * Make various initializations idempotent (

[PATCH] Fix range test optimization (PR tree-optimization/63302)

2014-10-16 Thread Jakub Jelinek
Hi! This patch fixes PR63302 by using proper predicate to test if an INTEGER_CST is a not power of 2. While the issue has been originally reported for PA, the testcase shows the same issue on x86_64 (just with __int128 instead of long long). Bootstrapped/regtested on x86_64-linux and i686-linux o

Re: [PATCH][match-and-simplify] More ternary commutative ops, canonicalize operand order before generic_simplify

2014-10-16 Thread Jeff Law
On 10/16/14 05:06, Richard Biener wrote: This patch (also applicable to trunk) makes us canoncialize operand order for comparisons at the same time we canonicalize other operand order, in particular before dispatching to generic_simplify. It also adds operand canonicalization to ternary ops and

Re: [PATCH, PR61605, 2/2] Use fuse-caller-save info in pass_cprop_hardreg

2014-10-16 Thread Jeff Law
On 10/16/14 03:14, Tom de Vries wrote: Eric, this patch is the second half of the fix for PR61605. It make sure in pass_cprop_hardreg that, if available we use the call-specific information provided by fuse-caller-save, rather than the generic regs_invalidated_by_call info. The 2 patches toget

Re: [PATCH, PR61605, 1/2] Handle copy cycles in pass_cprop_hardreg

2014-10-16 Thread Jeff Law
On 10/16/14 03:13, Tom de Vries wrote: Eric, this patch is the first half of the fix for PR61605. The problem it addresses is the following: Consider this copy cycle (a = b; b = a): ... (insn 2 18 3 2 (set (reg/v:SI 1 dx [orig:86 yD.1749 ] [86]) (reg:SI 5 di [ yD.1749 ])) test.c:9 90 {

Re: [PATCH v2] Fix pr61848, linux kernel miscompile

2014-10-16 Thread Jeff Law
On 10/16/14 06:40, Markus Trippelsdorf wrote: (I've taken Alan's patch and added two new testcases.) This patch cures the linux kernel boot failure when compiled using trunk gcc. At its heart, the problem is caused by merge_decls merging from the old decl to the new decl, then copying back to t

Re: -fuse-caller-save - Collect register usage information

2014-10-16 Thread Eric Botcazou
> Having said that, in my mind, what is confusing about the name > -fuse-caller-save, is that in fact the caller-save registers are already > used in register allocation. It's just that they're used across calls > without the need to save them, but > -fuse-caller-save-across-calls-without-saving-if

Re: [PATCH] remove score-* support

2014-10-16 Thread Matthias Klose
Am 03.10.2014 um 17:35 schrieb Jeff Law: > On 10/03/14 08:50, tsaund...@mozilla.com wrote: >> From: Trevor Saunders >> >> Hi, >> >> It was obsoleted back in 2011, so we're good to remove it. >> >> bootstrapped + regtested x86_64-unknown-linux-gnu, and checked configure >> doesn't recognize score-e

[SH][committed] Fix excess failures in SH tests caused by switch to GNU11

2014-10-16 Thread Oleg Endo
Hi, Attached patch fixes warnings in some of the SH test cases which are caused by the switch to GNU11. Committed as r216351. Cheers, Oleg gcc/testsuite/ChangeLog: * gcc.target/sh/cmpstr.c: Fix excess failures caused by switch to GNU11. * gcc.target/sh/strlen.c: Likewise.

Fix nullptr access in true_regnum

2014-10-16 Thread Oleg Endo
Hi, While working on some SH builtins I ran into the issue that the function true_regnum in jump.c tries to access the reg_renumber array without checking for nullptr. The particular use case here is using true_regnum in a predicate that is invoked during builtin function expansion in the TARGET_

Re: -fuse-caller-save - Collect register usage information

2014-10-16 Thread Tom de Vries
On 11-10-14 12:46, Eric Botcazou wrote: So, I hate the name of the option, and the documentation seems wrong to me. It doesn’t use the caller saved registers for allocation, it uses the call clobbered registers for allocation. Or, one could say it uses the callee saved registers for allocation.

[PATCH diagnostics/fortran] dynamically generate locations from offset + handle %C

2014-10-16 Thread Manuel López-Ibáñez
This patch adds handling of Fortran %C using the common diagnostics machinery. This is achieved by dynamically generating a location given a location and an offset. This only works for non-macro line-maps (for now), but this is OK since Fortran does not have virtual locations (and I'm afraid it won

Re: [PATCH] Simple improvement for predicate computation in if-convert phase.

2014-10-16 Thread Jeff Law
On 10/16/14 05:52, Yuri Rumyantsev wrote: Hi All, Here is a simple enhancement for predicate computation in if-convert phase: We use notion of cd equivalence to get simpler predicate for join block, e.g. if join block has 2 predecessors with predicates p1 & p2 and p1 & !p2, we'd l

Re: [lto] don't assume pointer size

2014-10-16 Thread DJ Delorie
> > In the event that pointer sizes aren't powers of two, choose a more > > suitable alignment than (unsigned)(-1), which results in HUGE file > > sizes. Ok? > > Ok. Thanks! Committed.

Re: [flag-types.h] don't assume 32-bit ints

2014-10-16 Thread DJ Delorie
> With a ChangeLog entry yes. Thanks! Committed.

[PATCH Fortran] rename gfc_warning_cmdline to gfc_warning_now_2

2014-10-16 Thread Manuel López-Ibáñez
This patch is mostly cleanups, sorry for the churn. The next one will be far more interesting. The next patch in this series will use a function gfc_warning_now_2 that works exactly like gfc_warning_now but uses the common diagnostics machinery. My original idea was that this new function will tak

[patch]add function.h flattened includes to gcc-plugin.h

2014-10-16 Thread Andrew MacLeod
In an attempt to not screw up every plugin user again this release, I'll try to add any flattened includes and any pre-requiresites into gcc-plugin.h, as discussed here: https://gcc.gnu.org/ml/gcc/2014-10/msg00127.html This patch adds those includes to gcc-plugin.h, and also adds tm.h since i

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-16 Thread DJ Delorie
> This is okay. Thanks! Committed.

Re: [PATCH][0/n] Merge from match-and-simplify

2014-10-16 Thread Andrew Pinski
On Thu, Oct 16, 2014 at 1:38 PM, Sebastian Pop wrote: > Richard Biener wrote: >> >> I have posted 5 patches as part of a larger series to merge >> (parts) from the match-and-simplify branch. While I think >> there was overall consensus that the idea behind the project >> is sound there are techni

Re: [PATCH][0/n] Merge from match-and-simplify

2014-10-16 Thread Sebastian Pop
Richard Biener wrote: > > I have posted 5 patches as part of a larger series to merge > (parts) from the match-and-simplify branch. While I think > there was overall consensus that the idea behind the project > is sound there are technical questions left for how the > thing should look in the end

[C PATCH] Don't ICE on invalid code (PR c/63549)

2014-10-16 Thread Marek Polacek
We ICEd on this invalid testcase because build_array_ref was getting a decl with an incomplete type as an index, and default_conversion calls require_complete_type on it - and because it's not complete, it returns error_mark_node, and then we trip on an assert requiring it to be an integer type. Fi

Re: [libstdc++ PATCH] Implement the Library Fundamentals v1 variable templates for type traits

2014-10-16 Thread Ville Voutilainen
On 16 October 2014 22:25, Ville Voutilainen wrote: > Tested on Linux-x64. The {raw,}invocable_type trait and its variable templates > are not implemented yet. > > > 2014-10-16 Ville Voutilainen > > Implement the Library Fundamentals v1 variable templates for > type traits. > * inclu

Go patch committed: method names must be non-blank

2014-10-16 Thread Ian Lance Taylor
The Go language spec was clarified to say that method names must be non-blank. This patch by Chris Manghane implements this restriction in the Go frontend. This requires a couple of testsuite changes, already in the master testsuite and included in this patch. This fixes http://golang.org/issue/

Go testsuite patch committed: fix test

2014-10-16 Thread Ian Lance Taylor
I forgot to commit this testsuite patch that corresponds to the recent patch for receiver parameters (https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01591.html). Now committed to mainline. Ian Index: test/fixedbugs/bug299.go === ---

Go patch committed: Don't crash on blank interface

2014-10-16 Thread Ian Lance Taylor
This patch from Chris Manghane fixes a compiler crash when using a blank interface type. This is http://golang.org/issue/8079 . Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian diff -r f0e1f402d71c go/parse.cc --- a/go/parse.cc Thu Oct 16 11:56:29 2014

[libstdc++ PATCH] Implement the Library Fundamentals v1 variable templates for type traits

2014-10-16 Thread Ville Voutilainen
Tested on Linux-x64. The {raw,}invocable_type trait and its variable templates are not implemented yet. 2014-10-16 Ville Voutilainen Implement the Library Fundamentals v1 variable templates for type traits. * include/Makefile.am: Add the new header. * include/experimental/type

Re: [PATCH][4/n] Merge from match-and-simplify, hook into fold-const.c

2014-10-16 Thread Jakub Jelinek
On Thu, Oct 16, 2014 at 06:58:25PM +, Sebastian Pop wrote: > Richard Biener wrote: > > To give you an example how it looks like, the following code is > > generated for > > > > /* fold_negate_exprs convert - (~A) to A + 1. */ > > (simplify > > (negate (bit_not @0)) > > (if (INTEGRAL_TYPE_P

Re: [PATCH][4/n] Merge from match-and-simplify, hook into fold-const.c

2014-10-16 Thread Sebastian Pop
Richard Biener wrote: > To give you an example how it looks like, the following code is > generated for > > /* fold_negate_exprs convert - (~A) to A + 1. */ > (simplify > (negate (bit_not @0)) > (if (INTEGRAL_TYPE_P (type)) > (plus @0 { build_int_cst (TREE_TYPE (@0), 1); } ))) > > tree > gen

Go patch committed: Report init cycles in method values

2014-10-16 Thread Ian Lance Taylor
This patch from Chris Manghane fixes the Go frontend to correctly report initialization cycles involving method values. He added a test case for this in the master gc testsuite, which will be copied into the gccgo testsuite in due course. This is http://golang.org/issue/7961 . Bootstrapped and ra

Re: [PATCH] AutoFDO patch for trunk

2014-10-16 Thread Dehao Chen
Hi, Honza, I've integrated all your comments to the patch. New patch attached. Thanks, Dehao On Wed, Oct 15, 2014 at 7:28 AM, Jan Hubicka wrote: >> Index: gcc/cfgloop.c >> === >> --- gcc/cfgloop.c (revision 215826) >> +++ gcc

Re: [RFC] Compile-time gimple-checking (again)

2014-10-16 Thread Jeff Law
On 10/16/14 05:27, Richard Biener wrote: This required numerous essentially mechanical changes to the patches e.g. for the big reworking of cgraph functions to be methods. I've been working on the assumption that these various changes aren't going to require a re-review. If they're fairly mech

Re: update address taken: don't drop clobbers

2014-10-16 Thread Jeff Law
On 10/16/14 11:52, Richard Biener wrote: I'd walk the SSA_NAMEs at the end checking for zero uses. I'm curious how often that will trigger :-) Most often for the initial into SSA I guess. After that only for the cases we rename a variable which does not happen often. SRA and update-address-ta

Re: update address taken: don't drop clobbers

2014-10-16 Thread Richard Biener
On October 16, 2014 7:26:48 PM CEST, Jeff Law wrote: >On 10/16/14 08:11, Marc Glisse wrote: > >> >> I am looking into that, it must be doable. It seems not too hard, in >> maybe_register_def, to push all results from make_ssa_name to some >> data-structure (I don't think new_ssa_names gives me tha

Re: [gomp4] OpenACC / C++

2014-10-16 Thread Thomas Schwinge
Hi Jim! On Wed, 15 Oct 2014 11:21:05 -0500, James Norris wrote: > This patch adds OpenACC support to C++ in the gomp4 branch. We understand that there will be further patches required on top of this, but we shall work on that incrementally. > OK to apply? Yes, thanks! (Just noting that I hav

Re: Fix pr61848, linux kernel miscompile

2014-10-16 Thread Jeff Law
On 10/15/14 22:51, Alan Modra wrote: Target independent tests are always best, but pulling together one that is specific to a target is usually still good enough. Especially if it's an x86 target given how often those are tested by the developer community as a whole. I think for #1 in your post

Re: Check that unlinked uses do not contain ssa-names when renaming.

2014-10-16 Thread Jeff Law
On 10/16/14 06:11, Tom de Vries wrote: On 16-10-14 10:14, Richard Biener wrote: I've tried to implement the 'light verification pass' you describe above, and I've checked that the error in my patch is found, also when I remove the trigger for the verification error from my patch. Bootstrapped

Re: update address taken: don't drop clobbers

2014-10-16 Thread Jeff Law
On 10/16/14 08:11, Marc Glisse wrote: I am looking into that, it must be doable. It seems not too hard, in maybe_register_def, to push all results from make_ssa_name to some data-structure (I don't think new_ssa_names gives me that list, but there may be other ways to get it without introducing

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-16 Thread Marek Polacek
On Wed, Oct 15, 2014 at 11:52:59PM +0200, Jakub Jelinek wrote: > On Wed, Oct 15, 2014 at 03:48:20PM -0600, Jeff Law wrote: > > Isn't slamming error_mark_node well established at this point? I fact I > > recall seeing it documented to be used in this kind of way to prevent future > > errors. > > I

Re: update address taken: don't drop clobbers

2014-10-16 Thread Jeff Law
On 10/16/14 05:20, Richard Biener wrote: It doesn't even know that it has no uses (the variable still needs to be written into SSA form). OTOH it is a missed DSE opportunity before update-address-taken? Perhaps it's a missed DSE prior to update-address-taken, but I suspect there aren't many of

Re: [C PATCH] Clamp down "incomplete type" error (PR c/63543)

2014-10-16 Thread Marek Polacek
On Wed, Oct 15, 2014 at 09:46:20PM +, Joseph S. Myers wrote: > On Wed, 15 Oct 2014, Marek Polacek wrote: > > > We've got a complaint that the "dereferencing pointer to incomplete > > type" error is printed for all occurrences of the incomplete type, > > which is too verbose. Also it'd be nice

Go patch committed: Functions that call defer_retaddr not inlinable

2014-10-16 Thread Ian Lance Taylor
It does not work to split functions that call __go_set_defer_retaddr, because those functions are designed to work as a single unit. They always look like this: if (__go_set_defer_retaddr (&&L)) goto L; real_function (real_args); L: The function __go_set_defer_retaddr always return

Go patch committed: Accept trailing comma after receiver

2014-10-16 Thread Ian Lance Taylor
The Go language spec was clarified to treat a function's receiver as any other parameter list, except that it must contain exactly one parameter. The only effect of this is that a receiver may have a trailing comma after it, as in "func (r,) M()" and also that it may have extra unnecessary parenthe

Re: [PATCH, PR63307] Fix generation of new declarations in random order

2014-10-16 Thread Jeff Law
On 10/16/14 09:16, Zamyatin, Igor wrote: c-family/Changelog: 2014-10-03 Igor Zamyatin PR c/63307 * cilk.c: Include vec.h. (struct cilk_decls): New structure. (wrapper_parm_cb): Split this function to... (fill_decls_vec): ...this... (create_pa

Re: [gomp4] [1/3] OpenACC 2.0 support for libgomp - OpenACC runtime, NVidia PTX/CUDA plugin

2014-10-16 Thread Thomas Schwinge
Hi Julian! On Tue, 14 Oct 2014 17:11:18 +0100, Julian Brown wrote: > This is a slightly-updated version of the following patch, but this > time tested (with the aid of a series of patches implementing PTX > support from Bernd Schmidt), and against the gomp4 branch: > > https://gcc.gnu.org/ml/gc

IPA ICF fallout: fox for libasan and pr43077-1.c

2014-10-16 Thread Martin Liška
Hello. After IRC discussion with Jakub, I disable IPA ICF for ASAN. Second part of the patch contains fix for pr43077-1.c. Considered as pre-approved. Thanks, Martin gcc/testsuite/ChangeLog: 2014-10-16 Martin Liska * gcc.dg/guality/pr43077-1.c: IPA ICF disabled to match defi

Re: [GOOGLE] Treat artificial from aux modules as non-external

2014-10-16 Thread Xinliang David Li
Ok if large tests pass. David On Thu, Oct 16, 2014 at 9:16 AM, Teresa Johnson wrote: > The following patch fixes a LIPO issue with a virtual implicitly > instantiated destructor from an aux module that was needed when we > devirtualized a call from the primary module, but it was not available >

[aarch64] Add legitimize_address hook

2014-10-16 Thread Richard Earnshaw
AArch64 currently does not have a legitimize address hook to find better solutions for loading from addresses that are not valid. The current approach 'gets away with it' much of the time because we currently split constants during expand. We might change that soon, since it is inhibits other opt

[GOOGLE] Treat artificial from aux modules as non-external

2014-10-16 Thread Teresa Johnson
The following patch fixes a LIPO issue with a virtual implicitly instantiated destructor from an aux module that was needed when we devirtualized a call from the primary module, but it was not available (not promoted to global) in aux module since it is DECL_ARTIFICIAL. Fixes compilation issue, pa

Re: ping x 7: [PATCH] [libgomp] make it possible to use OMP on both sides of a fork

2014-10-16 Thread Jakub Jelinek
On Mon, Oct 13, 2014 at 10:16:19PM +0100, Nathaniel Smith wrote: > Got total silence the last 4 times I posted this, and users have been > bugging me about it offline, so trying again. > > This patch fixes a showstopper problem preventing the transparent use > of OpenMP in scientific libraries, es

Re: [PATCH,1/2] Extended if-conversion for loops marked with pragma omp simd.

2014-10-16 Thread Yuri Rumyantsev
Richard, Here is reduced patch as you requested. All your remarks have been fixed. Could you please look at it ( I have already sent the patch with changes in add_to_predicate_list for review). Thanks. Yuri. ChangeLog 2014-10-16 Yuri Rumyantsev (flag_force_vectorize): New variable. (edge_pred

RE: [PATCH, PR63307] Fix generation of new declarations in random order

2014-10-16 Thread Zamyatin, Igor
> > > > > > c-family/Changelog: > > > > 2014-10-03 Igor Zamyatin > > > > PR c/63307 > > * cilk.c: Include vec.h. > > (struct cilk_decls): New structure. > > (wrapper_parm_cb): Split this function to... > > (fill_decls_vec): ...this... > > (create_parm_list): ...and this.

IPA ICF fallout: fix for two ipa-icf-*.C tests

2014-10-16 Thread Martin Liška
Hello. I forgot that RUNTESTFLAGS="ipa.exp" does not execute *.C tests cases residing in testsuite/g++.dg/ipa/ folder. The patch fixes two of my newly added tests. Considered as obvious. Thank you, Martin gcc/testsuite/ChangeLog: 2014-10-16 Martin Liska * g++.dg/ipa/ipa-icf-4.C: C

Re: [patch] Fix ICE during LTRANS on big Ada application

2014-10-16 Thread Eric Botcazou
> Yes, this looks OK. Inliner coul also take care to turn the master clone > into unanalyzed node as remove_unreachable_nodes would, but I do not think > it is worth the effort. Please put the loop later in the function so it > does not slow things down unnecesarily (there are often many inline clo

Re: [RFC, PATCH]: Introduction of callgraph annotation class

2014-10-16 Thread Martin Jambor
Hi, On Thu, Oct 16, 2014 at 01:44:05PM +0200, Richard Biener wrote: > On Thu, Oct 16, 2014 at 1:40 PM, Jan Hubicka wrote: > >> > >> I don't like "generic annotation" facilities at all. Would it be possible > > > > Why? > > Because it's the way to hell if the IL has "magic" things only one > pas

Re: __intN patch 3/5: main __int128 -> __intN conversion.

2014-10-16 Thread David Edelsohn
On Thu, Oct 16, 2014 at 1:48 AM, Markus Trippelsdorf wrote: > On 2014.10.15 at 17:00 -0400, DJ Delorie wrote: >> >> > If you could implement the second option, it would be appreciated. >> >> Could you please test this for me? It builds as a powerpc-elf >> cross-compiler (at least the host half) b

[PATCH PP] Pedantic use of operator 'defined'.

2014-10-16 Thread Ben Wagner
This is a partial revert (with update) of code removed in 46794 "Update warning about defined." (This code was originally introduced with 37098 "New macro expander.") My understanding of C++11 Specification Section 16.1 [cpp.cond] and C99 Specification Section 6.10.1 is that use of 'defined' from

Re: cp/constexpr.c change needs gengtype update?

2014-10-16 Thread Andrew MacLeod
On 10/16/2014 10:16 AM, Jakub Jelinek wrote: On Thu, Oct 16, 2014 at 10:11:33AM -0400, Andrew MacLeod wrote: Just updated to trunk and I have a compilation error: /gcc/2014-10-14/gcc/gcc/cp/constexpr.c:3391:29: fatal error: gt-cp-constexpr.h: No such file or directory #include "gt-cp-constexp

Re: update address taken: don't drop clobbers

2014-10-16 Thread Richard Biener
On Thu, Oct 16, 2014 at 4:11 PM, Marc Glisse wrote: > On Thu, 16 Oct 2014, Richard Biener wrote: > >> On Wed, Oct 15, 2014 at 6:08 PM, Jeff Law wrote: >>> >>> On 10/15/14 08:35, Marc Glisse wrote: > > > > Would that extra pass be acceptable? >> >> >> Ugh, rather not. We have too

Re: cp/constexpr.c change needs gengtype update?

2014-10-16 Thread Jakub Jelinek
On Thu, Oct 16, 2014 at 10:11:33AM -0400, Andrew MacLeod wrote: > Just updated to trunk and I have a compilation error: > > /gcc/2014-10-14/gcc/gcc/cp/constexpr.c:3391:29: fatal error: > gt-cp-constexpr.h: No such file or directory > #include "gt-cp-constexpr.h" > ^ >

Re: [RFC, PATCH]: Introduction of callgraph annotation class

2014-10-16 Thread Martin Jambor
Hi, On Wed, Oct 15, 2014 at 06:26:34PM +0200, Martin Liska wrote: > Hello. > > Following patch introduces a new class called callgraph_annotation. Idea > behind the patch is to provide a generic interface one can use to register > custom info related to a cgraph_node. As you know, symbol_table

Re: cp/constexpr.c change needs gengtype update?

2014-10-16 Thread Marek Polacek
On Thu, Oct 16, 2014 at 10:11:33AM -0400, Andrew MacLeod wrote: > Just updated to trunk and I have a compilation error: > > /gcc/2014-10-14/gcc/gcc/cp/constexpr.c:3391:29: fatal error: > gt-cp-constexpr.h: No such file or directory > #include "gt-cp-constexpr.h" > ^ >

Re: Check that unlinked uses do not contain ssa-names when renaming.

2014-10-16 Thread Richard Biener
On Thu, Oct 16, 2014 at 3:57 PM, Tom de Vries wrote: > On 16-10-14 14:20, Richard Biener wrote: >>> >>> Richard, >>> > >>> >I've implemented the changes listed above, and also made the message a >>> > bit >>> >more verbose: >>> >... >>> >kernels-2.c: In function ‘main’: >>> >kernels-2.c:41:5: erro

Re: update address taken: don't drop clobbers

2014-10-16 Thread Marc Glisse
On Thu, 16 Oct 2014, Richard Biener wrote: On Wed, Oct 15, 2014 at 6:08 PM, Jeff Law wrote: On 10/15/14 08:35, Marc Glisse wrote: Would that extra pass be acceptable? Ugh, rather not. We have too many passes ;) I expected you would say that... Otherwise, what do you think should be r

cp/constexpr.c change needs gengtype update?

2014-10-16 Thread Andrew MacLeod
Just updated to trunk and I have a compilation error: /gcc/2014-10-14/gcc/gcc/cp/constexpr.c:3391:29: fatal error: gt-cp-constexpr.h: No such file or directory #include "gt-cp-constexpr.h" ^ I presume its due to : 2014-10-15 Paolo Carlini * constexpr.c:

Re: [PATCH] Make infer_loop_bounds_from_ref handle MEM_REFs, fix PR63278

2014-10-16 Thread Richard Biener
On Thu, 16 Oct 2014, Jakub Jelinek wrote: > On Thu, Oct 16, 2014 at 03:44:50PM +0200, Richard Biener wrote: > > --- gcc/testsuite/gcc.dg/tree-ssa/loop-42.c (revision 0) > > +++ gcc/testsuite/gcc.dg/tree-ssa/loop-42.c (working copy) > > @@ -0,0 +1,19 @@ > > +/* { dg-do run } */ > > +/* { dg-options

Re: Check that unlinked uses do not contain ssa-names when renaming.

2014-10-16 Thread Tom de Vries
On 16-10-14 14:20, Richard Biener wrote: Richard, > >I've implemented the changes listed above, and also made the message a bit >more verbose: >... >kernels-2.c: In function ‘main’: >kernels-2.c:41:5: error: statement uses released SSA name > for (COUNTERTYPE ii = 0; ii < N; ii++) > ^ >

Re: [PATCH] Make infer_loop_bounds_from_ref handle MEM_REFs, fix PR63278

2014-10-16 Thread Jakub Jelinek
On Thu, Oct 16, 2014 at 03:44:50PM +0200, Richard Biener wrote: > --- gcc/testsuite/gcc.dg/tree-ssa/loop-42.c (revision 0) > +++ gcc/testsuite/gcc.dg/tree-ssa/loop-42.c (working copy) > @@ -0,0 +1,19 @@ > +/* { dg-do run } */ > +/* { dg-options "-O2 -fdump-tree-cunroll-details" } */ > + > +exte

Re: [PATCH] Make infer_loop_bounds_from_ref handle MEM_REFs, fix PR63278

2014-10-16 Thread Jan Hubicka
> > The following makes us infer loop bounds for loops like > > : > # str_28 = PHI <"foo"(2), str_10(4)> > ... > str_10 = str_28 + 1; > _4 = *str_10; > if (_4 != 0) > goto ; > else > goto ; > > : > goto ; > > or > > : > # p_15 = PHI > p_6 = p_15 + 1; > *p_15 = 0

Re: [arm][patch] fix arm_neon_ok check on !arm_arch7

2014-10-16 Thread Jiong Wang
On 15/10/14 17:58, Andrew Stubbs wrote: On 15/10/14 17:34, Jiong Wang wrote: On 23/09/14 16:22, Stubbs, Andrew wrote: Maybe the original patch is better? Or maybe it should reconfigure the FPU instead of erroring out? But reconfigure it to what? Andrew, are you still working on this?

[PATCH] Make infer_loop_bounds_from_ref handle MEM_REFs, fix PR63278

2014-10-16 Thread Richard Biener
The following makes us infer loop bounds for loops like : # str_28 = PHI <"foo"(2), str_10(4)> ... str_10 = str_28 + 1; _4 = *str_10; if (_4 != 0) goto ; else goto ; : goto ; or : # p_15 = PHI p_6 = p_15 + 1; *p_15 = 0; ... if (n.1_5 > i_8) goto ; else

[PATCH][match-and-simplify] Merge from trunk

2014-10-16 Thread Richard Biener
Bootstrapped on x86_64-unknown-linux-gnu. Richard. 2014-10-16 Richard Biener Merge from trunk r216235 through r216315.

[SH][committed] Remove function fldi_ok

2014-10-16 Thread Oleg Endo
Hi, The fldi_ok function in sh.c has been returning 'true' for while. Thus it can as well be removed. Tested with 'make all-gcc', committed as r216320. Cheers, Oleg gcc/ChangeLog: * config/sh/sh-protos.h (fldi_ok): Remove. * config/sh/sh.c (fldi_ok): Likewise. (sh_secon

Re: IPA ICF fallout: i586 bootstrap failure fix

2014-10-16 Thread Martin Liška
On 10/16/2014 02:45 PM, Jakub Jelinek wrote: On Thu, Oct 16, 2014 at 02:41:36PM +0200, Martin Liška wrote: Hello. Following patch fixes i586 bootstrap failure: https://gcc.gnu.org/ml/gcc-testresults/2014-10/msg01713.html ../../src-trunk/gcc/ipa-icf.c:2096:23: error: format ‘%lu’ expects argum

Re: IPA ICF fallout: i586 bootstrap failure fix

2014-10-16 Thread Jakub Jelinek
On Thu, Oct 16, 2014 at 02:41:36PM +0200, Martin Liška wrote: > Hello. > > Following patch fixes i586 bootstrap failure: > https://gcc.gnu.org/ml/gcc-testresults/2014-10/msg01713.html > > ../../src-trunk/gcc/ipa-icf.c:2096:23: error: format ‘%lu’ expects argument > of type ‘long unsigned int’,

Re: IPA ICF fallout: i586 bootstrap failure fix

2014-10-16 Thread Jan Hubicka
> Hello. > > Following patch fixes i586 bootstrap failure: > https://gcc.gnu.org/ml/gcc-testresults/2014-10/msg01713.html > > ../../src-trunk/gcc/ipa-icf.c:2096:23: error: format ‘%lu’ expects argument > of type ‘long unsigned int’, but argument 3 has type > ‘std::list::size_type {aka unsigned

IPA ICF fallout: i586 bootstrap failure fix

2014-10-16 Thread Martin Liška
Hello. Following patch fixes i586 bootstrap failure: https://gcc.gnu.org/ml/gcc-testresults/2014-10/msg01713.html ../../src-trunk/gcc/ipa-icf.c:2096:23: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 3 has type ‘std::list::size_type {aka unsigned int}’ [-Werro

[PATCH v2] Fix pr61848, linux kernel miscompile

2014-10-16 Thread Markus Trippelsdorf
(I've taken Alan's patch and added two new testcases.) This patch cures the linux kernel boot failure when compiled using trunk gcc. At its heart, the problem is caused by merge_decls merging from the old decl to the new decl, then copying back to the old decl and discarding the new. When Jan m

  1   2   >