While working on variable concepts, I noticed that one of the added
blocks of code was no longer needed due to a previous simplification and
caused problems. Also included a new test case which triggered the
problem, and fixed a minor formatting issue.
As before, if the plan is to revive the
On Fri, 18 Jul 2014, Jan-Benedict Glaw wrote:
> This was a build using GCC's ./contrib/config-list.mk to do the build.
> It passes --enable-werror-always to top-level `configure', this is
> where the -Werror comes from.
Aha. Looks like it's of more use than theoretical pain; sounds
like this shou
Hi Andre, and welcome aboard!
The explanation you give is nice, your patch submission looks clean. Two things:
1. Do you have a copyright assignment on file with the FSF? See
https://gcc.gnu.org/contribute.html
2. Normally, all GCC patch submissions should be accompanied by a statement
say
The Go frontend had a bug in that it would not give an error for
a, b := F()
when F returned more than two results. This patch fixes the bug. I've
proposed a test case for the master testsuite in
http://codereview.appspot.com/111360045 . Bootstrapped and ran Go
testsuite on x86_64-unknown-li
Hi, the following patch implements a new dumper interface to allow
dumping of profile data for all instrumented shared libraries.
For good reasons, existing libgcov implements the dumping on a
per-shared library basis (i.e., gcov_exit is hidden, gcov_list is file
static). This allows each shared l
Hi Thomas,
This patch enables acc constructs to be used inside nested functions. I
doubt nested functions will be used much in c, but some of the openacc
fortran tutorials I've seen online make use of internal subroutines in
fortran. Those internal subroutines are implemented as nested functions.
"Jürgen Urban" writes:
> Hello Richard,
>
> > "Jürgen Urban" writes:
> > > The problem happens with the r5900 hard float configurations, e.g.:
> > > configure --target=mipsel-linux-gnu --with-float=hard --with-fpu=single
> > > --with-arch=r5900
> > > I created the attached patch which fixes this
> On Jul 17, 2014, at 11:47 PM, Matthew Fortune
> wrote:
> > Thanks for fixing this. I'm afraid I managed to get confused between
> > failures we had seen sporadically in our development work and thought
> > they were known regressions on trunk waiting to be fixed when actually
> > we were introdu
On Jul 17, 2014, at 11:47 PM, Matthew Fortune
wrote:
> Thanks for fixing this. I'm afraid I managed to get confused between
> failures we had seen sporadically in our development work and thought
> they were known regressions on trunk waiting to be fixed when actually
> we were introducing them.
Any other concern of the patch? I don't really like the name of the
parameter myself. Do you have better suggestions?
thanks,
David
On Thu, Jul 17, 2014 at 10:17 AM, Xinliang David Li wrote:
>>>
>>> I see why you do not like first_global_object_name because changing it
>>> would cause
>>> all
Hello Richard,
> "Jürgen Urban" writes:
> > The problem happens with the r5900 hard float configurations, e.g.:
> > configure --target=mipsel-linux-gnu --with-float=hard --with-fpu=single
> > --with-arch=r5900
> > I created the attached patch which fixes this problem for r5900 and
> > another pro
On Fri, Jul 18, 2014 at 9:23 PM, Jakub Jelinek wrote:
> On Fri, Jul 18, 2014 at 08:42:35PM +0400, Yuri Gribov wrote:
>> > Uh. Can you please explain this? That sounds weird.
>>
>> Sure, this caused maybe-uninitialized warnings with iterator during
>> bootstrap. It turned out that *bb_seq_addr (b
On Tue, Jul 15, 2014 at 11:23 AM, Ulrich Weigand wrote:
> Richard Biener wrote:
>> On Mon, Jul 14, 2014 at 8:55 PM, Ulrich Weigand wrote:
>> > Hello,
>> >
>> > this is an attempt to update the prior patch:
>> > https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00635.html
>> > to add a -Wpsabi note as
> For formatting, can you please just replace 8 spaces with tabs
> in the ^+ lines in the patch?
Sorry, I thought I cleared all these out but looks like I indeed
missed some whites. I should probably take some time and finally setup
my editor to do this.
> Can you avoid using // comments in code
On 07/17/2014 07:10 AM, Richard Biener wrote:
Just to mention - the "regimplification removal" and a "gimple-building
facility" is provided on the match-and-simplify branch worked on by
me and Prathamesh (a GSoC student this year). I'll present about
this during the Cauldron with the title "Unif
On Fri, Jul 18, 2014 at 12:01:21PM -0400, David Edelsohn wrote:
> This patch is okay with me if okay with the Release Managers.
Ok.
Jakub
On Mon, Jul 14, 2014 at 2:52 PM, Ulrich Weigand wrote:
> Hello,
>
> this patch updates the prior version:
> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00632.html
> to add a -Wpsabi note as discussed.
>
> (We may need to change the "GCC 4.10" string if the next release turns out
> to get a diffe
On Fri, Jul 18, 2014 at 12:13:09PM -0400, David Edelsohn wrote:
> > gcc/ChangeLog:
> >
> > * config/rs6000/rs6000.c (rs6000_function_arg): If a float argument
> > does not fit fully into floating-point registers, and there is still
> > space in the register parameter area, i
On Fri, Jul 18, 2014 at 12:11:56PM -0400, David Edelsohn wrote:
> > gcc/ChangeLog:
> >
> > * config/rs6000/rs6000.c (rs6000_function_arg_boundary): Issue
> > -Wpsabi note when encountering a type where future GCC releases
> > will apply different alignment requirements.
> >
On Mon, Jul 14, 2014 at 2:54 PM, Ulrich Weigand wrote:
> Hello,
>
> this patch updates the prior version:
> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00634.html
> to add a -Wpsabi note as discussed.
>
> Note that the warning triggers whenever type is encountered whose alignment
> *requirement*
On Wed, Jul 16, 2014 at 8:37 PM, Ulrich Weigand wrote:
> Hello,
>
> this is the variant intended for the 4.8/4.9 branches of the patch:
> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00994.html
>
> As discussed, it does *not* actually change ABI, but only warn when
> encountering a situation wher
On Wed, Jul 16, 2014 at 8:39 PM, Ulrich Weigand wrote:
> Hello,
>
> this is the variant intended for the 4.8/4.9 branches of the patch:
> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00995.html
>
> As discussed, it does *not* actually change ABI, but only warn when
> encountering a situation wher
Hello!
2014-07-18 Uros Bizjak
PR target/61794
* config/i386/sse.md (avx512f_vextract32x4_1_maskm):
Fix instruction constraint.
(avx512f_vextract32x4_1): Ditto.
testsuite/ChangeLog:
2014-07-18 Uros Bizjak
PR target/61794
* gcc.target/i386/pr61794.c: New test.
Boot
This patch is okay with me if okay with the Release Managers.
Thanks, David
On Wed, Jul 16, 2014 at 8:41 PM, Ulrich Weigand wrote:
> Hello,
>
> this is the variant intended for the 4.8/4.9 branches of the patch:
> https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01072.html
>
> As discussed, it does
Committed to trunk.
commit dacf2aec1b84828e92a06431d725a6e80413b21d
Author: redi
Date: Fri Jul 18 15:56:00 2014 +
PR libstdc++/61835
* python/libstdcxx/v6/printers.py (TemplateTypePrinter): Use
raw string.
(SingleObjContainerPrinter): Check if type printers are in use.
On Fri, Jul 18, 2014 at 11:38:22AM -0400, David Edelsohn wrote:
> This is okay with me if it is okay with the Release Managers.
Ok.
Jakub
On Fri, Jul 18, 2014 at 11:40:31AM -0400, David Edelsohn wrote:
> This patch is okay with me if it is okay with the Release Managers.
Ok.
Jakub
This patch is okay with me if it is okay with the Release Managers.
Thanks, David
On Thu, Jul 17, 2014 at 10:54 AM, Peter Bergner wrote:
> With a recent mainline libsanitizer merge from upstream, we're now seeing a
> lot of mainline ASAN test suite failures with the following error:
>
> ==2642
Hi,
when reading the gcc/opts.c sources, I noticed that the docs don't
mention -ftree-loop-distribute-patterns along the other switches enabled
with -O3.
This documentation was missing since this option's introduction in SVN
r162822 and should be backported to the 4.6, 4.7, 4.8 and 4.9 branches
(
This is okay with me if it is okay with the Release Managers.
Thanks, David
On Thu, Jul 17, 2014 at 10:56 AM, Peter Bergner wrote:
> With a recent mainline libsanitizer merge from upstream, we're now seeing a
> lot of mainline ASAN test suite failures with the following error:
>
> ==26426==ASan
On Fri, Jul 18, 2014 at 05:36:30PM +0400, Yury Gribov wrote:
> The patch was bootstrapped, regtested and asan-bootstrapped on x64.
Thanks for working on this.
For formatting, can you please just replace 8 spaces with tabs
in the ^+ lines in the patch?
sed '/^+/s//\t/g' or so.
Can you avoi
On 7/18/2014 7:28 AM, Mikael Pettersson wrote:
John David Anglin writes:
> Because the atomic sync functions in config/pa/linux-atomic.c are not
> lock free, we need to use
> __kernel_cmpxchg for the __sync_lock_release. This was found in
> glibc's pthread_spin_unlock
> implementation.
On Fri, Jul 18, 2014 at 4:05 PM, Petr Murzin wrote:
> I've fixed AVX512F tests. These tests failed on Android because they
> were using , which seem to be obsolete and is not present in
> Android sysroot.
>
> Here is the quote from
> /* This interface is obsolete. New programs should use
> and/
Then in sanitize_spec_function supposedly for "address" check
SANITIZE_USER_ADDRESS bit, for "kernel-address" added there
SANITIZE_KERNEL_ADDRESS, add all the incompatibility diagnostics for the new
invalid combinations.
Ok.
Plus, toplev.c has e.g.:
...
Now, is the same really the case for SAN
Hello,
I've fixed AVX512F tests. These tests failed on Android because they
were using , which seem to be obsolete and is not present in
Android sysroot.
Here is the quote from
/* This interface is obsolete. New programs should use
and/or instead of . */
So now tests run with Android compiler.
On Fri, Jul 18, 2014 at 05:19:39PM +0400, Dmitry Vyukov wrote:
> On Fri, Jul 18, 2014 at 4:26 PM, Jakub Jelinek wrote:
> > On Fri, Jul 18, 2014 at 03:40:15PM +0400, Yury Gribov wrote:
> >> This tiny patch adds support for KernelASan. KASan brings Asan error
> >> detection capabilities to Linux ker
Hi all,
Attached patch delays generation of Asan memory checking code
until sanopt pass. This is a first step towards global static analysis
of Asan instrumentation which would allow to
* remove redundant instrumentations
* aggregate adjacent Asan checks
* move invariant checks from loops
The pa
> One of these two seems redundant.
I get the following error without “iv_map.create (loop->num + 1);”:
"/home/roman/sec_trunk/gcc/gcc/vec.h:1184:39: error: ‘iv_map’ may be
used uninitialized in this function [-Werror=maybe-uninitialized] {
return m_vec ? m_vec->length () : 0; }"
>Can you explai
>> Also, oring in SANITIZER_ADDRESS means you add -lasan to link flags, I'd
>> guess that for -fsanitize=kernel-address you don't want to add any
libraries
>> at link time?
>
> I suspect that we don't pass -fsanitize=kernel-address during linking
> in kernel today. But I agree that it's better t
On Fri, Jul 18, 2014 at 4:26 PM, Jakub Jelinek wrote:
> On Fri, Jul 18, 2014 at 03:40:15PM +0400, Yury Gribov wrote:
>> This tiny patch adds support for KernelASan. KASan brings Asan error
>> detection capabilities to Linux kernel
>> (https://code.google.com/p/address-sanitizer/wiki/AddressSanitiz
On Fri, Jul 18, 2014 at 03:40:15PM +0400, Yury Gribov wrote:
> This tiny patch adds support for KernelASan. KASan brings Asan error
> detection capabilities to Linux kernel
> (https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel).
>
> KASan works similar to normal userspace A
On Fri, 2014-07-18 03:10:09 -0400, Hans-Peter Nilsson wrote:
> On Fri, 18 Jul 2014, Jan-Benedict Glaw wrote:
> > As a leftover of r210931, an unused variable resulted in:
> >
> > g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions
> > -fno-rtti -fasynchronous-unwind-tables -W
On Fri, Jul 18, 2014 at 3:40 PM, Yury Gribov wrote:
> Hi all,
>
> This tiny patch adds support for KernelASan. KASan brings Asan error
> detection capabilities to Linux kernel
> (https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel).
>
> KASan works similar to normal userspac
Hi all,
This tiny patch adds support for KernelASan. KASan brings Asan error
detection capabilities to Linux kernel
(https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel).
KASan works similar to normal userspace ASan but disables some options
which are not yet supported
John David Anglin writes:
> Because the atomic sync functions in config/pa/linux-atomic.c are not
> lock free, we need to use
> __kernel_cmpxchg for the __sync_lock_release. This was found in
> glibc's pthread_spin_unlock
> implementation.
>
> Tested on hppa-unknown-linux-gnu. Committ
On 18/07/2014 12:34, Roman Gareev wrote:
I suggest you use the largest available integer mode via
>mode = mode_for_size (MAX_FIXED_MODE_SIZE, MODE_INT, 0);
>type = build_nonstandard_integer_type (GET_MODE_PRECISION (mode), [01]);
Thank you for the suggestion!
>Roman, can you give this a shot?
Hi,
According to the GNU coding standards, the function name should start
in column one. Fixed it as obvious, committed as Rev.212809.
Index: gcc/ChangeLog
===
--- gcc/ChangeLog (revision 212808)
+++ gcc/ChangeLog (work
> I suggest you use the largest available integer mode via
> mode = mode_for_size (MAX_FIXED_MODE_SIZE, MODE_INT, 0);
> type = build_nonstandard_integer_type (GET_MODE_PRECISION (mode), [01]);
Thank you for the suggestion!
> Roman, can you give this a shot?
Maybe, we could use the following code
One last question:
On 18/07/2014 12:28, Roman Gareev wrote:
+ iv_map.create (loop->num + 1);
+ iv_map.safe_grow_cleared (loop->num + 1);
One of these two seems redundant.
Cheers,
Tobias
> Can you explain why all functions would need to be rewritten? I proposed
> this function as an easier way to NULL initialize the vector and did not
> expect any rewrite to be necessary.
>
> If there is no such thing, please just add a comment that your loop NULL
> initializes the vector. We can l
If a constant is defined with a static expression, and the expression
statically fails a static predicate, then the constant is not considered
as being static, as shown by this updated example (see last few lines)
1. package TestSP is
2.subtype F1 is Float with -- OK
3. Sta
This reorganizes the handling of predicates, in preparation for proper
implementation of real predicates. Several minor errors are corrected
and we properly reject improper static real predicates. Static string
predicates are now always rejected, in line with latest ARG thinking.
The following show
> On 07/08/2014 02:50 PM, Jan Hubicka wrote:
> >I am looking into tracking dynamic types now. Obviously I need to set very
> >exact rules about when these may change.
>
> Let me first say that this area is somewhat in flux in the standard;
> if we have a model of what we want the rules to be for G
Hi all,
this is my first try to submit a patch, so please be kind and correct me when I
do something wrong.
I was contracted to fix some issues listed in the bugtracker for fortran.
Please find attached my first attempt for bug PR60414 (I'll attach it to the
bug in the tracker in a second).
The
In Ada 2012, the formals of a subprogram can be incomplete types, and the
subprogram is a primitive operation of the type. If the type is subsequently
derived, it inherits the operation, and it can be explicitly overridden.
Executing main.adb must yield:
1
2
---
with Prim_Test; use Prim_Tes
Tested on x86_64-pc-linux-gnu, committed on trunk
2014-07-18 Pascal Obry
* s-crtl.ads, i-cstrea.ads (fputwc): New routine.
* a-witeio.adb (Put): On platforms where there is translation
done by the OS output the raw text.
(New_Line): Use Put above to properly han
Output lines from GNAT.Memory_Dump.Dump can now be prefixed with an offset
relative to the start of the dump, or have no prefix at all, instead of
showing an absolute address.
Test:
$ gnatmake -q dump_test
$ ./dump_test
00: 4C 6F 72 65 6D 20 69 70 73 75 6D 20 64 6F 6C 6F "Lorem ipsum dolo"
10: 72
The rules for static predicates do not allow the type name to be
parenthesized. This was not checked, but is now fixed, the following
test now gives the error indicated (compiled with -gnatld7 -gnatj55)
(it used to compile without errors).
1. package BadParenSP is
2.subtype r is inte
Previously all rep clauses were ignored in -gnatI mode, but in two
cases (enumeration rep clauses and record rep clauses), they were
not removed from the tree, causing trouble with ASIS tools. These
two cases are now consistent, and ASIS tools will see none of the
ignored rep clauses (e.g. gnatpp w
the container type is a derived type, the value of the inherited aspect is the
Reference (or Constant_Reference) operation declared for the parent type.
However, Reference is also a primitive operation of the new type, and the
inherited operation has a different signature. It is necessary to retri
On Mon, 14 Jul 2014, Tim Semeijn wrote:
> We have decided to switch domains so the mirror details have changed.
> The old domain will be up for a while but it would be best for the
> details to be edited.
>
> --
>
> http://mirror.bbln.org/gcc
> ftp://mirror.bbln.org/gcc
> rsync://mirr
Add two missing style checks for token spacing for binary operators when
switches -gnatyt, -gnatyy or -gnatyg is used.
Preserve previous behavior with debug switch -gnatd.Q
Test:
$ gcc -c pkg.ads -gnatyt -gnatl -gnatd7
Compiling: pkg.ads
1. package Pkg is
2.One : constant := 1;
On 14/7/18 2:30 PM, Chung-Lin Tang wrote:
> For the default multilib settings, it looks like you just intended to
> use -mcustom-fpu-cfg=60-2. I suggest you modify t-rtems to do that
> instead of enumerating the individual FPU insn options.
>
> Other than that, the patch looks okay.
>
> Chung-Lin
Bill Schmidt writes:
> Bernd, thanks. At this point I think I will avoid opening this can of
> worms and not worry about backporting the test case.
Sorry for the late answer (catching up on a big backlog), but the testcase
was originally added for an optimisation rather than a bug fix. It sound
This implements the final definition of the Ada 2012 restriction
No_Standard_Allocators_After_Elaboration. There are two static
cases. First appearence in task body, this one we already had
before (compiled with -gnatj55 -gnatld7)
1. procedure Pmain2 is
2.type P is access all Integer
My patch to reduce the amount of rtx garbage created:
2014-05-17 Richard Sandiford
* emit-rtl.h (replace_equiv_address, replace_equiv_address_nv): Add an
inplace argument. Store the new address in the original MEM when true.
* emit-rtl.c (change_address_1): Likewise.
On Fri, 18 Jul 2014, Jan-Benedict Glaw wrote:
> Hi!
>
> As a leftover of r210931, an unused variable resulted in:
>
> g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions
> -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing
> -Wwrite-strings -Wcast-qual -Wmissing-fo
67 matches
Mail list logo
