Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Richard Biener
On June 26, 2014 12:03:21 AM CEST, Martin Jambor wrote: >Hi, > >On Wed, Jun 25, 2014 at 03:14:31PM -0600, Jeff Law wrote: >> On 06/24/14 14:19, Martin Jambor wrote: >> >On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: >> >>Hi Martin, >> >> >> >> Well actually, I am not sure

Re: [PATCH] Fix vector rotate regression (PR tree-optimization/57233)

2014-06-25 Thread Jakub Jelinek
On Thu, Jun 26, 2014 at 07:43:55AM +0200, Marc Glisse wrote: > >+ if (compute_type == TREE_TYPE (type) > >+ && !VECTOR_INTEGER_TYPE_P (TREE_TYPE (rhs2))) > >+{ > >+ optab oplv, opl, oprv, opr, opo; > >+ oplv = optab_for_tree_code (LSHIFT_EXPR, type, optab_vec

Re: [PATCH 1/2] Enable setting sign and unsigned promoted mode (SPR_SIGNED_AND_UNSIGNED)

2014-06-25 Thread Jakub Jelinek
On Thu, Jun 26, 2014 at 11:06:26AM +1000, Kugan wrote: > >> Since our aim is to perform single bit checks, why don’t we just use > >> this representation internally (i.e. _rtx->unchanging = 1 if SRP_SIGNED > >> and _rtx->volatil = 1 if SRP_UNSIGNED). As for SUBREG_PROMOTED_SIGNED_P, > >> we still

Re: [PATCH] Fix vector rotate regression (PR tree-optimization/57233)

2014-06-25 Thread Marc Glisse
On Wed, 25 Jun 2014, Jakub Jelinek wrote: Since we've started folding (a << n) | (a >> (bitsize - n)) etc. into rotates even vectors, we've regressed code quality on targets where we do have vector shifts, but don't have vector rotates. The following patch attempts to fix it, by telling veclowe

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Adam Butcher
On 2014-06-25 21:57, Jason Merrill wrote: OK, thanks. Do you want me to apply to 4.9 too?

Re: [PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Kito Cheng
For example in arm-elf-eabi, movmem need word align, otherwise it will expand a libcall: And gcc configure with "--target=arm-elf-eabi --disable-nls --disable-shared --enable-languages=c,c++ --enable-threads=single --enable-lto --with-newlib" test.c: extern bar(unsigned char p[3][2]); void foo(in

Re: [PATCH 1/2] Enable setting sign and unsigned promoted mode (SPR_SIGNED_AND_UNSIGNED)

2014-06-25 Thread Kugan
On 26/06/14 11:06, Kugan wrote: > On 25/06/14 17:50, Jakub Jelinek wrote: >> On Wed, Jun 25, 2014 at 05:21:08PM +1000, Kugan wrote: >>> The problem with SRP_POINTER 0, SRP_SIGNED 1, SRP_UNSIGNED 2, >>> SRP_SIGNED_AND_UNSIGNED 3 (as I understand) is that, it will be >>> incompatible with TYPE_UNSIGN

Re: [PATCH] Convert XCOFF ASM_DECLARE_FUNCTION_NAME to function

2014-06-25 Thread David Edelsohn
On Wed, Jun 25, 2014 at 6:23 PM, Jan Hubicka wrote: > We do not need TOC references, but we need to output aliases there and for > that > we need to know the declaratoin, so I need to introduce DECLARE_OBJECT_NAME. > I will look into it either tonight or later this week. > Thanks for the patch :

Re: Add flag to optionally ignore ELF interposition

2014-06-25 Thread Jan Hubicka
> On Tue, May 20, 2014 at 1:04 PM, Jan Hubicka wrote: > > Hi, > > as disucssed some time ago, our assumption that every symbol of shared > > library can > > be interposed at runtime is expensive and prevents a lot of useful > > optimizations, > > including inlining or IPA propagation. > > > > Wh

[patch, libgfortran] [4.9/4.10 Regression] Internal read of negative integer broken

2014-06-25 Thread Jerry DeLisle
Hi, This bug has nothing to do with negative numbers as in the description. However, the problem is due to seeking when there are no spaces to skip. I restructured the loop so that the skipping is not done if there are no spaces. Regression tested on x86-64. New test case from the PR. OK for t

RE: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-25 Thread Thomas Preud'homme
Ok, what about the following patch and associated ChangeLog entries? 2014-06-24 Thomas Preud'homme PR tree-optimization/61375 * tree-ssa-math-opts.c (find_bswap_or_nop_1): Cancel optimization if symbolic number cannot be represented in an unsigned HOST_WIDE_INT.

Re: [PATCH 1/2] Enable setting sign and unsigned promoted mode (SPR_SIGNED_AND_UNSIGNED)

2014-06-25 Thread Kugan
On 25/06/14 17:50, Jakub Jelinek wrote: > On Wed, Jun 25, 2014 at 05:21:08PM +1000, Kugan wrote: >> The problem with SRP_POINTER 0, SRP_SIGNED 1, SRP_UNSIGNED 2, >> SRP_SIGNED_AND_UNSIGNED 3 (as I understand) is that, it will be >> incompatible with TYPE_UNSIGNED (tree) and defines of >> POINTER_EX

Re: Add flag to optionally ignore ELF interposition

2014-06-25 Thread Andrew Pinski
On Tue, May 20, 2014 at 1:04 PM, Jan Hubicka wrote: > Hi, > as disucssed some time ago, our assumption that every symbol of shared > library can > be interposed at runtime is expensive and prevents a lot of useful > optimizations, > including inlining or IPA propagation. > > While this is useful

Re: [DOC Patch] Attribute 'naked'

2014-06-25 Thread Gerald Pfeifer
On Tue, 17 Jun 2014, David Wohlferd wrote: 2014-06-17 David Wohlferd * doc/extend.texi (Function Attributes): Update 'naked' attribute doc. This patch makes sense to me and I've seen feedback on an earlier iteration that lead to this now. So, I am planning to commit this unless anyo

Re: [patch] Simplify allocator use

2014-06-25 Thread Jonathan Wakely
This simplifies some of the test changes in my last patch, I was misusing the CustomPointerAlloc due to confusion with some uncommitted changes. Tested x86_64-linux, committed to trunk. commit d1a05535e99bfecb427829d3e03ef82e0977e60c Author: Jonathan Wakely Date: Wed Jun 25 23:39:20 2014 +01

Re: [PATCH v2] gcc/dwarf2asm.c: Add dw2_asm_voutput_delta() with var_list for dw2_asm_output_delta()

2014-06-25 Thread Chen Gang
Hello maintainers: Please help check this patch when you have time, thanks. BTW: one linux kernel member found a gcc issue for the latest version (4.10.0 20140622 or later), but for old version (e.g. 4.10.0 2014060*), it is OK. It is my chance to fix it (hope can finish within 2014-06-30). Also

Re: [PATCH] Convert XCOFF ASM_DECLARE_FUNCTION_NAME to function

2014-06-25 Thread Jan Hubicka
> On Tue, Jun 24, 2014 at 2:53 PM, Jan Hubicka wrote: > > > We will also need to introduce ASM_DECLARE_OBJECT_NAME to handle the > > aliases > > of variables. I can look into that probably later this week (it is last > > week > > of my teaching and I need to do the finals) > > varasm.c defau

Re: [PATCH] Fix the "inconsident" devirtualization typo and consolidate the related code

2014-06-25 Thread Jan Hubicka
> Hi, > > the patch below fixes the (I guess now almost infamous) typo that > prints "Type inconsident devirtualization" to the dump. This dumping > has been copied and pasted to a few places so I made all of them just > use the ipa_impossible_devirt_target function to do that. The code > can be

[PATCH] Fix the "inconsident" devirtualization typo and consolidate the related code

2014-06-25 Thread Martin Jambor
Hi, the patch below fixes the (I guess now almost infamous) typo that prints "Type inconsident devirtualization" to the dump. This dumping has been copied and pasted to a few places so I made all of them just use the ipa_impossible_devirt_target function to do that. The code can be consolidated

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Martin Jambor
Hi, On Wed, Jun 25, 2014 at 03:14:31PM -0600, Jeff Law wrote: > On 06/24/14 14:19, Martin Jambor wrote: > >On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: > >>Hi Martin, > >> > > Well actually, I am not sure if we ever wanted to have a race condition > here. > Hav

Re: [PATCH, loop2_invariant, 1/2] Check only one register class

2014-06-25 Thread Jeff Law
On 06/11/14 04:05, Zhenqiang Chen wrote: On 10 June 2014 19:06, Steven Bosscher wrote: On Tue, Jun 10, 2014 at 11:22 AM, Zhenqiang Chen wrote: Hi, For loop2-invariant pass, when flag_ira_loop_pressure is enabled, function gain_for_invariant checks the pressures of all register classes. This d

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Steven Bosscher
On Wed, Jun 25, 2014 at 10:46 PM, Jeff Law wrote: > On 06/25/14 02:54, Richard Sandiford wrote: >> >> SEQUENCE is just weird though :-) It would be good to have an alternative >> representation, but that'd be a lot of work on reorg. > > Yea. And I don't think anyone is keen on rewriting reorg. R

Re: [PATCH, Cilk+, PR57541] Additional fix for issues witn array notations

2014-06-25 Thread Jeff Law
On 06/19/14 06:30, Zamyatin, Igor wrote: On 06/16/14 14:13, Zamyatin, Igor wrote: Hi All! The patch fixes ICE in array notation for the cases of incorrect arguments of Cilk+ builtins and undeclared initial index. Is it ok for trunk and 4.9? Thanks, Igor diff --git a/gcc/c/ChangeLog b/gcc/c

Re: [PATCH v2] gcc: fix segfault from calling free on non-malloc'd area

2014-06-25 Thread Jeff Law
On 06/24/14 14:05, Paul Gortmaker wrote: We see the following on a 32bit gcc installed on 64 bit host: Reading symbols from ./i586-pokymllib32-linux-gcc...done. (gdb) run Starting program: x86-pokymllib32-linux/lib32-gcc/4.9.0-r0/image/usr/bin/i586-pokymllib32-linux-gcc Program rec

Re: [PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Joseph S. Myers
On Wed, 25 Jun 2014, Sebastian Huber wrote: > On 06/25/2014 05:56 PM, Joseph S. Myers wrote: > > On Wed, 25 Jun 2014, Sebastian Huber wrote: > > > > > 2014-06-25 Sebastian Huber > > > > > > * c-parser.c (c_parser_declaration_or_fndef): Discard all type > > > qualifiers in __auto_type for

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Jeff Law
On 06/24/14 14:19, Martin Jambor wrote: On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: Hi Martin, Well actually, I am not sure if we ever wanted to have a race condition here. Have you seen any impact of --param allow-store-data-races on any benchmark? It's trivially to wri

Re: [Patch,testsuite] Fix tests that fail due to symbol visibility when -fPIC

2014-06-25 Thread Jeff Law
On 06/25/14 04:06, Vidya Praveen wrote: PING! On Wed, Jun 04, 2014 at 03:01:38PM +0100, Vidya Praveen wrote: Hello, The following test cases fail when -fPIC is passed as dejagnu multilib flag since -fPIC causes the 'availability' of the functions to be overwritable. I have fixed this by a

Re: [PATCH v2] PR bootstrap/61598

2014-06-25 Thread Trevor Saunders
On Wed, Jun 25, 2014 at 03:00:33PM -0600, Jeff Law wrote: > On 06/25/14 10:05, tsaund...@mozilla.com wrote: > >From: tbsaunde > > > >Hi, > > > >Actually we can just store const tre_node * in the hash table, and actually > >remove a const cast. > > > >bootstrapped with --enable-checking=fold on top

Re: [Patch,testsuite] Fix bind_pic_locally

2014-06-25 Thread Jeff Law
On 06/25/14 04:07, Vidya Praveen wrote: PING! On Wed, Jun 04, 2014 at 02:56:00PM +0100, Vidya Praveen wrote: Hello, This is to follow up the patch I had posted to fix bind_pic_locally some time ago (sorry, this went in to my back log for a while). To summarize, multilib_flags when it contai

[PATCH] Fix vector rotate regression (PR tree-optimization/57233)

2014-06-25 Thread Jakub Jelinek
Hi! Since we've started folding (a << n) | (a >> (bitsize - n)) etc. into rotates even vectors, we've regressed code quality on targets where we do have vector shifts, but don't have vector rotates. The following patch attempts to fix it, by telling veclower pass not to actually lower it if we ha

Re: [PATCH, 3/10] skip swapping operands used in ccmp

2014-06-25 Thread Jeff Law
On 06/25/14 08:44, Richard Earnshaw wrote: On 23/06/14 07:58, Zhenqiang Chen wrote: Hi, Swapping operands in a ccmp will lead to illegal instructions. So the patch disables it in simplify_while_replacing. The patch is separated from https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. To

Re: [PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Jeff Law
On 06/25/14 09:35, Kito Cheng wrote: Hi all: This patch is fix constant memory's symbol_ref don't have right alignment info since `exp` don't set alignment (and should not set alignment info for `exp`) , use `decl` to set_mem_attributes for right alignment info. ChangLog 2014-06-25 Kito Che

Re: [PATCH v2] PR bootstrap/61598

2014-06-25 Thread Jeff Law
On 06/25/14 10:05, tsaund...@mozilla.com wrote: From: tbsaunde Hi, Actually we can just store const tre_node * in the hash table, and actually remove a const cast. bootstrapped with --enable-checking=fold on top of my original series on x86_64-unknown-linux-gnu, and aprovied by richi on IRC,

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Jason Merrill
OK, thanks. Jason

Re: Delay RTL initialization until it is really needed

2014-06-25 Thread Jeff Law
On 06/25/14 01:09, Jan Hubicka wrote: On 06/20/14 01:51, Jan Hubicka wrote: Hi, IRA initialization shows high in profiles even when building lto objects. This patch simply delays RTL backend initialization until we really decide to output a function. In some cases this avoids the initializat

Re: [PATCH] PR bootstrap/61598

2014-06-25 Thread Jeff Law
On 06/25/14 03:46, tsaund...@mozilla.com wrote: From: Trevor Saunders Hi, Basically the same as the mingw issue, fixed similarly. Trev PR bootstrap/61598 * fold-const.c (fold_checksum_tree): fix const qualification of argument passed to hash_table::find_slot with a

[patch] Simplify allocator use

2014-06-25 Thread Jonathan Wakely
A couple of related patches that came out of some work on std::list and std::string which is not ready yet. One adds an alias template to simplify rebinding allocators. The other adds an RAII type to help manage pointers obtained from allocators. The new type means I can remove several ugly try-

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Jeff Law
On 06/25/14 02:54, Richard Sandiford wrote: and the code now uses "rtx_insn *" in hundreds of places where it would previously have used "rtx". This looks really good to me FWIW. The only thing I'm not sure about is how useful rtx_nonjump_insn would be. ISTM that jump_insn and call_insn real

Re: Instructions vs Expressions in the backend (was Re: RFA: Rework FOR_BB_INSNS iterators)

2014-06-25 Thread Jeff Law
On 06/25/14 03:36, Richard Sandiford wrote: I think this is an example of another problem with gcc coding style: that we're far too afraid of temporary variables. In David's scheme I think this would be: Historical coding style :(It's particularly bad in RTL land, but you see the same prob

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Adam Butcher
* parser.c (cp_parser_elaborated_type_specifier): Only consider template parameter lists outside of function parameter scope. * g++.dg/template/pr61537.C: New testcase. --- gcc/cp/parser.c | 31 ++- gcc/testsuite/g++.dg/t

Three pending co-array patches

2014-06-25 Thread Paul Richard Thomas
Dear Tobias, I have taken a look through the following three patches: * https://gcc.gnu.org/ml/fortran/2014-06/msg00178.html * https://gcc.gnu.org/ml/fortran/2014-06/msg00183.html * https://gcc.gnu.org/ml/fortran/2014-06/msg00187.html I can find nothing to object to in any of them; on the contra

Re: [PATCH, ARM] Enable fuse-caller-save for ARM

2014-06-25 Thread Tom de Vries
On 19-06-14 18:43, Richard Henderson wrote: On 06/19/2014 09:37 AM, Tom de Vries wrote: On 19-06-14 05:59, Richard Henderson wrote: On 06/01/2014 04:27 AM, Tom de Vries wrote: + if (TARGET_AAPCS_BASED) +{ + /* For AAPCS, IP and CC can be clobbered by veneers inserted by the + lin

Re: testsuite allocators patch

2014-06-25 Thread François Dumont
Hi With the patch this time. I would like to finally propose this patch before the one on _Rb_tree, as a separate one. I have adopted the same evolution on the tracker_allocator with even a perfect forwarding constructor to allow its usage on top of the uneq_allocator which t

Re: [Patch: RL78] Add support for 64-bit doubles

2014-06-25 Thread DJ Delorie
> The RX toolchain has a similar patch where the option is "doubles" > while the folder name is "double". There's no reason for one toolchain to be consistent with another, though. > Would it be ok to revert this line from "64-bit-doubles" to "64-bit-double" > as this? > +MULTILIB_DIRNAMES =

Re: [PATCH] Fix parts of PR61607

2014-06-25 Thread Jeff Law
On 06/25/14 08:06, Richard Biener wrote: This removes prematurely killing loops during jump threading and moves it to a spot where we know we didn't cancel the jump thread. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Ok? Thanks, Richard. 2014-06-25 Richard Biener

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 20:12 GMT+02:00 Richard Henderson : > On 06/25/2014 06:35 AM, Kai Tietz wrote: >> Hello, >> >> so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. >> So we need indeed 2 peephole2 passes. > > We don't need a second peephole pass. Please try this. > > I think th

Re: [PATCH] Fix parts of PR61607

2014-06-25 Thread Jeff Law
On 06/25/14 08:05, Richard Biener wrote: This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing is really realy old and no longer necessary while the loop-depth consideration is only valid for loop-closed PHI nodes (but we're not in loop-close

Re: [PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Sebastian Huber
On 06/25/2014 05:56 PM, Joseph S. Myers wrote: On Wed, 25 Jun 2014, Sebastian Huber wrote: 2014-06-25 Sebastian Huber * c-parser.c (c_parser_declaration_or_fndef): Discard all type qualifiers in __auto_type for atomic types. (c_parser_typeof_specifier): Discard all t

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Henderson
On 06/25/2014 06:35 AM, Kai Tietz wrote: > Hello, > > so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. > So we need indeed 2 peephole2 passes. We don't need a second peephole pass. Please try this. I think there's room for cleanup here, depending on when we leave cf

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 19:15 GMT+02:00 Jeff Law : > On 06/25/14 10:02, Kai Tietz wrote: >> >> 2014-06-25 17:50 GMT+02:00 Richard Henderson : >>> >>> On 06/25/2014 08:28 AM, Jeff Law wrote: Ask an ARM maintainer if the new code is actually better than the old code. >>> >>> >>> It isn't. >>>

Re: [PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

2014-06-25 Thread Cong Hou
On Tue, Jun 24, 2014 at 4:05 AM, Richard Biener wrote: > On Sat, May 3, 2014 at 2:39 AM, Cong Hou wrote: >> On Mon, Apr 28, 2014 at 4:04 AM, Richard Biener wrote: >>> On Thu, 24 Apr 2014, Cong Hou wrote: >>> Given the following loop: int a[N]; short b[N*2]; for (int

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 09:50, Richard Henderson wrote: On 06/25/2014 08:28 AM, Jeff Law wrote: Ask an ARM maintainer if the new code is actually better than the old code. It isn't. It appears that with the peep2 pass moved that we actually if-convert the fall-thru path of the conditional and eliminate

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 10:02, Kai Tietz wrote: 2014-06-25 17:50 GMT+02:00 Richard Henderson : On 06/25/2014 08:28 AM, Jeff Law wrote: Ask an ARM maintainer if the new code is actually better than the old code. It isn't. It appears that with the peep2 pass moved that we actually if-convert the fall-thr

Re: [PATCH] IPA REF: refactoring

2014-06-25 Thread Martin Liška
On 06/24/2014 08:21 PM, Jan Hubicka wrote: Hello, this patch changes IPA REF API to c++ style. Changes were suggested and consulted with Honza. Patch has been pre approved, will be committed if no comments. Bootstrapped on x86_64-pc-linux-gnu, no regressions. Thanks, Martin ChangeLog: 20

[PATCH v2] PR bootstrap/61598

2014-06-25 Thread tsaunders
From: tbsaunde Hi, Actually we can just store const tre_node * in the hash table, and actually remove a const cast. bootstrapped with --enable-checking=fold on top of my original series on x86_64-unknown-linux-gnu, and aprovied by richi on IRC, commited. Trev gcc/ PR bootstrap/61598

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 17:50 GMT+02:00 Richard Henderson : > On 06/25/2014 08:28 AM, Jeff Law wrote: >> Ask an ARM maintainer if the new code is actually better than the old code. > > It isn't. > >> It appears that with the peep2 pass moved that we actually if-convert the >> fall-thru path of the conditional a

Re: [PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Joseph S. Myers
On Wed, 25 Jun 2014, Sebastian Huber wrote: > 2014-06-25 Sebastian Huber > > * c-parser.c (c_parser_declaration_or_fndef): Discard all type > qualifiers in __auto_type for atomic types. > (c_parser_typeof_specifier): Discard all type qualifiers in > __typeof__ for atomi

Re: [BUILDROBOT] xtensa fallout (was: Turn DECL_SECTION_NAME into string)

2014-06-25 Thread augustine.sterl...@gmail.com
On Tue, Jun 24, 2014 at 10:20 PM, Jan Hubicka wrote: >> Hi! >> >> This is the xtensa fallout, see >> http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=272418 >> >> g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions >> -fno-rtti -fasynchronous-unwind-tables -W -Wa

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Henderson
On 06/25/2014 08:28 AM, Jeff Law wrote: > Ask an ARM maintainer if the new code is actually better than the old code. It isn't. > It appears that with the peep2 pass moved that we actually if-convert the > fall-thru path of the conditional and eliminate the conditional. Which, on the > surface se

Re: [RFC] Making fold-const sane WRT symbol visibilities

2014-06-25 Thread Joseph S. Myers
On Wed, 25 Jun 2014, Richard Biener wrote: > On Tue, 24 Jun 2014, Jan Hubicka wrote: > > > > > The problem is that the patch fails testcases that assume we do such > > > > folding at parsing > > > > time. > > > > > > > > ./testsuite/gcc/gcc.sum:FAIL: gcc.dg/pr36901-1.c (test for excess > > > >

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Ramana Radhakrishnan
[Apologies about the duplicates to folks - resending to make this hit the lists] On 25/06/14 16:28, Jeff Law wrote: On 06/25/14 09:04, Kai Tietz wrote: 2014-06-25 16:04 GMT+02:00 Jeff Law : So why is the peephole not working in its current location? Jeff Hi Jeff, that is what I read out o

[c++-concepts] constraint folding

2014-06-25 Thread Andrew Sutton
Updating constraint parsing to match changes to spec. Constraints must always left unfolded, even when non-dependent, until they are evaluated. 2014-06-25 Andrew Sutton * gcc/cp/parser.c (cp_parser_requires_clause): Don't fold expressions when parsing a requires-clause.

[PATCH] Pass correct memory attributes for build constant

2014-06-25 Thread Kito Cheng
Hi all: This patch is fix constant memory's symbol_ref don't have right alignment info since `exp` don't set alignment (and should not set alignment info for `exp`) , use `decl` to set_mem_attributes for right alignment info. ChangLog 2014-06-25 Kito Cheng * varasm.c (build_constant

Re: [PATCH, cpp] Fix line directive bug

2014-06-25 Thread Dodji Seketeli
Hello Nicholas, Nicholas Ormrod a écrit: > We currently have two possible approaches. I see the trade-offs between these > two solutions as follows: > > Adding full line directives is not implemented, and will be more > complicated than my patch. It will require someone else to implement > it,

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 09:04, Kai Tietz wrote: 2014-06-25 16:04 GMT+02:00 Jeff Law : So why is the peephole not working in its current location? Jeff Hi Jeff, that is what I read out of dumps: If peephole2 is executed early we see following pattern transformation: [ ... ] Ask an ARM maintainer if the

Re: [PATCH, 4/10] expand ccmp

2014-06-25 Thread Richard Earnshaw
On 23/06/14 07:59, Zhenqiang Chen wrote: > Hi, > > This patch includes the main logic to expand ccmp instructions. > > In the patch, > * ccmp_candidate_p is used to identify the CCMP candidate > * expand_ccmp_expr is the main entry, which calls expand_ccmp_expr_1 > to expand CCMP. > * e

[PATCH] typeof: Remove type qualifiers for atomic types

2014-06-25 Thread Sebastian Huber
function ld: @ args = 0, pretend = 0, frame = 0 @ frame_needed = 0, uses_anonymous_args = 0 @ link register save eliminated. ldr r0, [r0] bx lr .size ld, .-ld .ident "GCC: (GNU) 4.9.1 20140625 (prerelease) gcc/c/ChangeLog 2014-06-25 Sebastian

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
2014-06-25 16:04 GMT+02:00 Jeff Law : > So why is the peephole not working in its current location? > > Jeff Hi Jeff, that is what I read out of dumps: If peephole2 is executed early we see following pattern transformation: (insn 12 11 13 2 (set (reg:CC_NOOV 100 cc) (compare:CC_NOOV (ze

Re: [PATCH] Convert XCOFF ASM_DECLARE_FUNCTION_NAME to function

2014-06-25 Thread David Edelsohn
On Tue, Jun 24, 2014 at 2:53 PM, Jan Hubicka wrote: > We will also need to introduce ASM_DECLARE_OBJECT_NAME to handle the aliases > of variables. I can look into that probably later this week (it is last week > of my teaching and I need to do the finals) varasm.c defaults to ASM_OUTPUT_LABEL

RE: [Patch: RL78] Add support for 64-bit doubles

2014-06-25 Thread Kaushik Phatak
Hi DJ, >> I assume this should be "doubles" not "double" though... I had made this change as suggested, however we had some issue while integrating the tools with our eclipse plug-ins. The RX toolchain has a similar patch where the option is "doubles" while the folder name is "double". Would it

Re: [PATCH, 3/10] skip swapping operands used in ccmp

2014-06-25 Thread Richard Earnshaw
On 23/06/14 07:58, Zhenqiang Chen wrote: > Hi, > > Swapping operands in a ccmp will lead to illegal instructions. So the > patch disables it in simplify_while_replacing. > > The patch is separated from > https://gcc.gnu.org/ml/gcc-patches/2014-02/msg01407.html. > > To make it clean. The patch ad

Re: [PATCH, 2/10] prepare ccmp

2014-06-25 Thread Richard Earnshaw
On 23/06/14 07:57, Zhenqiang Chen wrote: > Hi, > > The patch makes several functions global, which will be used when > expanding ccmp instructions. > > The other change in this patch is to check CCMP when turning code into > jumpy sequence. > > OK for trunk? > This isn't a complete review. In

Re: [fortran, patch] IEEE intrinsic modules (ping)

2014-06-25 Thread Steve Kargl
On Wed, Jun 25, 2014 at 01:41:02AM +0200, FX wrote: > > If I remove the previously installed gcc, the failure again occurs. > > So, it looks like the testsuite is picking up installed *.mod files > > over the freshly built *.mod files. This is not a showstopper. > > And this is not all the tests

Re: [PATCH] Add missing -fdump-* options

2014-06-25 Thread Teresa Johnson
On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li wrote: > On Tue, May 13, 2014 at 1:39 AM, Richard Biener > wrote: >> On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson wrote: >>> I discovered that the support for the documented -fdump-* options >>> "optimized", "missed", "note" and "optall" was m

Re: [PATCH 3/3] add hash_map class

2014-06-25 Thread Martin Liška
On 06/24/2014 09:31 PM, Richard Biener wrote: On June 24, 2014 9:16:34 PM CEST, Trevor Saunders wrote: On Tue, Jun 24, 2014 at 08:23:49PM +0200, Jan Hubicka wrote: On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders Hi, This patch adds a hash_map class so we can con

[PATCH] Fix parts of PR61607

2014-06-25 Thread Richard Biener
This removes prematurely killing loops during jump threading and moves it to a spot where we know we didn't cancel the jump thread. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Ok? Thanks, Richard. 2014-06-25 Richard Biener PR tree-optimization/61607 * tre

[PATCH] Fix parts of PR61607

2014-06-25 Thread Richard Biener
This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing is really realy old and no longer necessary while the loop-depth consideration is only valid for loop-closed PHI nodes (but we're not in loop-closed SSA in DOM) - the coalescing is handled i

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Jeff Law
On 06/25/14 07:35, Kai Tietz wrote: Hello, so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. So we need indeed 2 peephole2 passes. ChangeLog 2014-06-25 Kai Tietz PR rtl-optimization/61608 * passes.def (peephole2): Readd peephole2 pass before if-af

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Marek Polacek
On Wed, Jun 25, 2014 at 03:47:37PM +0200, Jakub Jelinek wrote: > Please don't invoke undefined behavior in the asm statements. > So, "r" (&c[5]) is fine, but not &c[5][2][2] is not, &x[-1] is not, etc. > I'd say it should be ok to always just take address of the base > variable in the asm. Otherwi

Re: Re: [c++-concepts] Fix assertion failure with cp_maybe_constrained_type_specifier

2014-06-25 Thread Andrew Sutton
> I did a full 3-stage bootstrap which is the default these days. > I'll try --disable-bootstrap and see what happens. I just did a full bootstrap build and got the same errors. The errors are correct for C++11, which was enabled by default in this branch. IIRC, aggregate initialization requires t

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 3:35 PM, Kai Tietz wrote: > Hello, > > so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. > So we need indeed 2 peephole2 passes. > > ChangeLog > > 2014-06-25 Kai Tietz > > PR rtl-optimization/61608 > * passes.def (peephole2): Readd pee

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Jakub Jelinek
Hi! On Wed, Jun 25, 2014 at 03:36:38PM +0200, Marek Polacek wrote: > static void __attribute__ ((noinline, noclone)) > fn7 (void) > { > - int n = 5, i; > + int n = 5; > + volatile int i; >volatile int c[n][n][n]; > - c[5][2][2] = 2; > - c[2][5][2] = 2; > - c[2][2][5] = 2; > + asm (""

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Marek Polacek
On Wed, Jun 25, 2014 at 02:49:56PM +0200, Jakub Jelinek wrote: > On Wed, Jun 25, 2014 at 02:40:40PM +0200, Marek Polacek wrote: > > On IRC Ramana reported that on ARM ubsan/bounds-2.c test fails with -O0, > > since we write to out-of-bounds location and probably rewrite the > > frame pointer stored

[patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Kai Tietz
Hello, so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. So we need indeed 2 peephole2 passes. ChangeLog 2014-06-25 Kai Tietz PR rtl-optimization/61608 * passes.def (peephole2): Readd peephole2 pass before if-after-reload pass. Tested for arm*-none-*,

Re: [PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 02:40:40PM +0200, Marek Polacek wrote: > On IRC Ramana reported that on ARM ubsan/bounds-2.c test fails with -O0, > since we write to out-of-bounds location and probably rewrite the > frame pointer stored in the stack. This patch removes such stores > and adds some asm magi

Re: [PATCH] Fix PR c++/61537

2014-06-25 Thread Jason Merrill
On 06/24/2014 07:04 PM, Adam Butcher wrote: I've fixed these issues up in my tree and moved the test to g++.dg. Please put it in g++.dg/template; I'd prefer not to clutter the top directory. + bool template_parm_lists_apply + = parser->num_template_parameter_lists; + for (

[PATCH] Fix ubsan/bounds-2.c

2014-06-25 Thread Marek Polacek
On IRC Ramana reported that on ARM ubsan/bounds-2.c test fails with -O0, since we write to out-of-bounds location and probably rewrite the frame pointer stored in the stack. This patch removes such stores and adds some asm magic so the compiler doesn't optimize loads away as uninitialized memory r

Re: [C++ Patch/RFC] PR 49132

2014-06-25 Thread Jason Merrill
OK. Jason

[C PATCH] Better column info for return stmts (PR c/61162)

2014-06-25 Thread Marek Polacek
This is the last piece to fix PR61162: it's better to point to the expression of the return statement (if any) than to the return keyword itself. Tested x86_64-unknown-linux-gnu, applying to trunk. 2014-06-25 Marek Polacek PR c/61162 * c-parser.c (c_parser_statement_after_labe

[PATCH] Generate more efficient memory barriers for LEON3

2014-06-25 Thread Daniel Cederman
Hello, The memory barriers generated for SPARC are targeting the weakest memory model allowed for SPARC. The LEON3/4 SPARC processors are using a stronger memory model and thus have less requirements on the memory barriers. For LEON3/4, StoreStore is compiler-only, instead of "stbar", and Sto

Re: strlen: update datastructure when replacing malloc with calloc

2014-06-25 Thread Jakub Jelinek
On Wed, Jun 25, 2014 at 01:16:38PM +0200, Marc Glisse wrote: > in my calloc patch, I forgot to update the datastructure when replacing > malloc with calloc. > > Bootstrap+testsuite on x86_64-linux-gnu. > > 2014-06-25 Marc Glisse > > PR tree-optimization/57742 > gcc/ > * tree-ssa-s

strlen: update datastructure when replacing malloc with calloc

2014-06-25 Thread Marc Glisse
Hello, in my calloc patch, I forgot to update the datastructure when replacing malloc with calloc. Bootstrap+testsuite on x86_64-linux-gnu. 2014-06-25 Marc Glisse PR tree-optimization/57742 gcc/ * tree-ssa-strlen.c (handle_builtin_memset): Update strinfo after repl

Re: [PATCH] Fix forwprop pattern (T)(P + A) - (T)P -> (T)A, Part 2

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 11:12 AM, Bernd Edlinger wrote: > Hi, > > this is part 2 of my patch, which uses the undefined behaviour, and emits a > strict overflow warning. > This fixes gnat.dg/opt37.adb again. > > The diff is relative to part 1: > https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01891

Re: [PATCH] Fix forwprop pattern (T)(P + A) - (T)P -> (T)A, Part 1

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 2:30 PM, Bernd Edlinger wrote: > Hi Richard, > > I have here part 1 of this patch, which does not use undefined behaviour. > > Currently I start to think that also TYPE_SATURATING just cannot happen > here, because only some targets have saturating types, for instance ARM,

Re: [Patch,testsuite] Fix bind_pic_locally

2014-06-25 Thread Vidya Praveen
PING! On Wed, Jun 04, 2014 at 02:56:00PM +0100, Vidya Praveen wrote: > Hello, > > This is to follow up the patch I had posted to fix bind_pic_locally some time > ago (sorry, this went in to my back log for a while). > > To summarize, multilib_flags when it contains -fpic or -fPIC, overrides -f

Re: [Patch,testsuite] Fix tests that fail due to symbol visibility when -fPIC

2014-06-25 Thread Vidya Praveen
PING! On Wed, Jun 04, 2014 at 03:01:38PM +0100, Vidya Praveen wrote: > Hello, > > The following test cases fail when -fPIC is passed as dejagnu multilib > flag > since -fPIC causes the 'availability' of the functions to be overwritable. > I > have fixed this by adding bind_pic_locally to

Re: Add used_by_single_function flag for static variables

2014-06-25 Thread Richard Biener
On Mon, 23 Jun 2014, Jan Hubicka wrote: > Hi, > this is patch to add the used_by_single_function flag to varpool. In full > generality > it is a simple dataflow problem, since the variable may be referred by other > variables > as long as all of them are used by one function only. I have > bo

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Marc Glisse
On Wed, 25 Jun 2014, Richard Biener wrote: On Wed, Jun 25, 2014 at 10:54 AM, Jakub Jelinek wrote: On Wed, Jun 25, 2014 at 10:14:17AM +0200, Richard Biener wrote: Perhaps not unsurprisingly, the patch is very similar. Bootstrapped and tested on x86_64-linux. OK for trunk? Ok - please give

[PATCH] PR bootstrap/61598

2014-06-25 Thread tsaunders
From: Trevor Saunders Hi, Basically the same as the mingw issue, fixed similarly. Trev PR bootstrap/61598 * fold-const.c (fold_checksum_tree): fix const qualification of argument passed to hash_table::find_slot with a const_cast. diff --git a/gcc/ChangeLog b/gcc/ChangeL

[PATCH][match-and-simplify] Put GENERIC match-and-simplify to work

2014-06-25 Thread Richard Biener
The following patch enables running the GENERIC match-and-simplify portion via fold_{unary,binary,ternary}. One pattern needs disabling to avoid endless recursion from addr-expression expansion so I added the planned defines. I've also split the generated routines into three again (will help the

  1   2   >