Re: [patch, mips] small -mmicromips testsuite cleanup

2014-05-12 Thread Richard Sandiford
Sandra Loosemore writes: > 2014-05-12 Nathan Sidwell > Sandra Loosemore > > gcc/testsuite/ > * gcc.target/mips/loongson-simd.c: Disable micromips too. OK, thanks. Richard

Re: [patch, mips] fix JALR test in configure.ac

2014-05-12 Thread Richard Sandiford
Sandra Loosemore writes: > When configuring GCC for mips-linux-gnu, this happens: > > configure:26145: checking assembler and linker for explicit JALR relocation > conftest.s: Assembler messages: > conftest.s:2: Internal error! > Assertion failure in macro_build at > /scratch/sandra/mips-fsf/obj/

[PATCH 5/5] move many members of target_globals out of gc memory

2014-05-12 Thread tsaunders
From: Trevor Saunders Same as patch 6 in the original series. I forget if this is ok, so please tell me, and yes it was bootstrapped + regtested on x86_64-unknown-linux-gnu Trev gcc/ChangeLog: * target-globals.c (target_globals::~target_globals): new destructor. (target_globa

[PATCH 4/5] add finalizers to ggc

2014-05-12 Thread tsaunders
From: Trevor Saunders This implements finalizers by keeping a list of registered finalizers and after every mark but before sweeping check to see if any of them are for unmarked blocks. This uses the two vector and forward iteration approach I think richi agreed to. bootstrapped + regtested on

[PATCH 3/5] remove unused function

2014-05-12 Thread tsaunders
From: Trevor Saunders Same as patch 4 in the original sequence, I assume its still ok ;) gcc/ChangeLog: *ggc.h (ggc_alloc_cleared_simd_clone_stat): Remove function. --- gcc/ggc.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/gcc/ggc.h b/gcc/ggc.h index 2c567de..50fb199 1006

[PATCH 1/5] rm a bunch of _stat allocation functions

2014-05-12 Thread tsaunders
From: Trevor Saunders Hi, basically this patch is unchanged from the last time I sent this series, except I reordered the includes in rtl.c to have ggc.h come before vec.h because vec.h declares some functions from ggc.h if building a binary to run on the build machine. The problem is if the fu

Re: [PATCH, MIPS] Fix a couple of target tests for microMIPS

2014-05-12 Thread Richard Sandiford
"Moore, Catherine" writes: > 2014-05-12 Catherine Moore > > gcc/testsuite/ > * gcc.target/mips/near-far-1.c: Adjust expected output to allow > the JALS instruction. > * gcc.target/mips/near-far-2.c: Likewise. > * gcc.target/mips/near-far-4.c: Likewise. OK, thanks. Rich

[Patch ARM/testsuite] Mark pr48329.f90 as unsupported on AArch32

2014-05-12 Thread Ramana Radhakrishnan
The AArch32 SIMD unit doesn't have vector floating point divide. Handled thusly. I've chosen to inherit vector floating point divide support from target_vect_float. If this doesn't work for all targets, they can choose to override it here otherwise. Tested cross with the testcase on arm-none-l

Re: [DOC Patch] symbol rename pragmas

2014-05-12 Thread Rainer Orth
David Wohlferd writes: > I don't have permissions to commit this patch, but I do have a release on > file with the FSF. > > Problem description: > The existing docs make reference to the "two #pragma directives that change > the name used in assembly." However, the subsequent text only describes

[C PATCH] Better locinfo for -Wc++-compat (PR c/61162)

2014-05-12 Thread Marek Polacek
Tiny patch, just use available location instead of input_location. Tested x86_64. Ok? 2014-05-13 Marek Polacek PR c/61162 * c-typeck.c (convert_for_assignment): Pass location to WARN_FOR_ASSIGNMENT instead of input_location. * gcc.dg/pr61162.c: New test. dif

Re: Ping2: [PATCH] PR debug/16063. Add DW_AT_type to DW_TAG_enumeration.

2014-05-12 Thread Jason Merrill
On 04/28/2014 08:37 AM, Mark Wielaard wrote: On Mon, 2014-04-28 at 14:23 +0200, Jakub Jelinek wrote: Do you want to add DW_AT_type to DW_TAG_enumeration only if it has explicit underlying type (enum class foo: char { ... };) or even when the underlying type is computed emplicitly (then you'd jus

C++ PATCH to convert_like_real diagnostics

2014-05-12 Thread Jason Merrill
Some small changes adding more context to conversion diagnostics. Tested x86_64-pc-linux-gnu, applying to trunk. commit f84b4d6a1ef681f0070d1df7302ca76bb5918526 Author: Jason Merrill Date: Sun Apr 20 20:20:22 2014 -0400 * call.c (maybe_print_user_conv_context): New. (convert_like_re

[PATCH, PR C++/61038] - g++ -E is unusable with UDL strings

2014-05-12 Thread Ed Smith-Rowland
This patch is really a libcpp patch. But UDLs are like that ;-) Add string user-defined literals and char user-defined literals to the list of things to look out for while escaping strings in macro args. I'm not sure how to test this really. we want to write out *.ii files and verify that i

[patch, mips] small -mmicromips testsuite cleanup

2014-05-12 Thread Sandra Loosemore
The test case gcc.target/mips/loongson-simd.c fails when the multilib options include -mmicromips. This patch fixes it analogously to how this test case already ignores MIPS16ness. OK to commit? -Sandra 2014-05-12 Nathan Sidwell Sandra Loosemore gcc/testsuite/

Re: [PATCH] PR60822 (m68k, missing earlyclobber in extendplussidi)

2014-05-12 Thread Hans-Peter Nilsson
On Thu, 24 Apr 2014, Jeff Law wrote: > On 04/16/14 18:20, seg...@kernel.crashing.org wrote: > > PR target/60822 > > 2014-04-16 Segher Boessenkool > > > > * config/m68k/m68k.md (extendplussidi): Don't allow memory for > > operand 1. > Thanks. I tweaked the comment and added the testcase

[C++ Patch] PR 60373

2014-05-12 Thread Paolo Carlini
Hi, in this issue Marc noticed that the warning for ignored attribute visibility is truncated when the previous declaration belongs to a system header. Luckily the problem can be neatly fixed because it's just a consequence of not using warning_at + inform, as we should anyway. The other hunk

Re: [google gcc-4_8] LIPO: check the incompatibility of use and saved command line

2014-05-12 Thread Xinliang David Li
Ok. For non-autofdo path, I think a warning (even an error) is needed in case of mismatch. David On Mon, May 12, 2014 at 4:35 PM, Rong Xu wrote: > Hi, > > This patch adds an extra check of the incompatibility of use and saved > command line for the primary module. If the check files, we skip the

[patch, mips] fix JALR test in configure.ac

2014-05-12 Thread Sandra Loosemore
When configuring GCC for mips-linux-gnu, this happens: configure:26145: checking assembler and linker for explicit JALR relocation conftest.s: Assembler messages: conftest.s:2: Internal error! Assertion failure in macro_build at /scratch/sandra/mips-fsf/obj/binutils-src-mainline-0-mips-linux-gnu

[google gcc-4_8] LIPO: check the incompatibility of use and saved command line

2014-05-12 Thread Rong Xu
Hi, This patch adds an extra check of the incompatibility of use and saved command line for the primary module. If the check files, we skip the inclusion of all aux modules. Maybe we should check the aux module command line with the use-compilation command line directly. But I keep the old way tha

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Oleg Endo
On Mon, 2014-05-12 at 13:51 +0100, Joern Rennecke wrote: > On 12 May 2014 13:16, Christian Bruel wrote: > > > Just for my curiosity, which other targets have multi-way toggling > > support ? > > The epiphany has, sort of: you read a control register, AND and/or OR > some mask(s) to the value, >

Re: [DOC Patch] symbol rename pragmas

2014-05-12 Thread Gerald Pfeifer
On Mon, 12 May 2014, David Wohlferd wrote: 2014-05-12 David Wohlferd * doc/extend.texi: Reflect current pragma count and remove "Solaris." Thanks, I applied the patch with two changes to the ChangeLog: 1. Two spaces between name and e-mail address per GNU Coding Standard. 2. I rewr

[PATCH, MIPS] Fix a couple of target tests for microMIPS

2014-05-12 Thread Moore, Catherine
Hi Richard, This fixes a few of the near-far MIPS target tests to allow the JALS instruction for microMIPS. Okay? Thanks, Catherine 2014-05-12 Catherine Moore gcc/testsuite/ * gcc.target/mips/near-far-1.c: Adjust expected output to allow the JALS instruction. * gcc.

Re: [PING*2][PATCH] Extend mode-switching to support toggle (1/2)

2014-05-12 Thread Oleg Endo
On Mon, 2014-05-12 at 19:32 +0900, Kaz Kojima wrote: > [I'd like to add Oleg to CC list.] > > Christian Bruel wrote: > > Just saw the Jeff's approval for the RTL part. Sorry for the crossed answers > > > > remains the target maintainers. Joern, Kaz ? > > SH specific part looks OK to me. Oleg,

[msp430] no sibcall in testsuite

2014-05-12 Thread DJ Delorie
Self-explanatory. Committed. * gcc.dg/sibcall-3.c: MSP430 doesn't have sibcall. * gcc.dg/sibcall-4.c: Likewise. Index: gcc.dg/sibcall-3.c === --- gcc.dg/sibcall-3.c (revision 210340) +++ gcc.dg/sibcall-3.c (workin

Re: [RFC] Using function clones for Pointer Bounds Checker

2014-05-12 Thread Jeff Law
On 01/14/14 02:15, Ilya Enkovich wrote: Hi, I've been working for some time on the prototype of the Pointer Bounds Checker which uses function clones for instrumentation (http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03327.html). After several experiments with this approach I want to share my res

Re: [google/gcc-4_8] Add -fskeleton-type-units flag.

2014-05-12 Thread Paul Pluzhnikov
> Add -f[no-]skeleton-type-units flag to control whether GCC > generates skeleton type units. > > This patch is for the google/gcc-4_8 branch. Ok for Google branch. Thanks, -- Paul Pluzhnikov

[google/gcc-4_8] Add -fskeleton-type-units flag.

2014-05-12 Thread Cary Coutant
Add -f[no-]skeleton-type-units flag to control whether GCC generates skeleton type units. This patch is for the google/gcc-4_8 branch. I will hold off sending it upstream until we're certain that we will be disabling skeleton type units, at which point, I'll just remove the code instead of making

[DOC Patch] symbol rename pragmas

2014-05-12 Thread David Wohlferd
I don't have permissions to commit this patch, but I do have a release on file with the FSF. Problem description: The existing docs make reference to the "two #pragma directives that change the name used in assembly." However, the subsequent text only describes one. It turns out, "#pragma ex

[PATCH 0/3] Compile-time gimple checking v4

2014-05-12 Thread David Malcolm
This is v4 of the patch series. Revision history of the patch series: v1: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01148.html (this was the full 89-patch patch series I originally posted) v2: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg01549.html * eliminated the as_a_gimple_foo

[PATCH 3/3] Introduce gswitch and use it in various places

2014-05-12 Thread David Malcolm
gcc/ * gimple.h (gswitch): New subclass of gimple_stmt_with_ops, adding the invariant that stmt->code == GIMPLE_SWITCH. (is_a_helper ::test): New. (is_a_helper ::test): New. (gimple_try): Likewise. * coretypes.h (gswitch): Add forward declaration her

Re: [PATCH 71/89] Concretize gimple_cond_make_{false|true}

2014-05-12 Thread Jeff Law
On 05/12/14 14:14, David Malcolm wrote: You asked me to speak up if my factoring turned up a case where the existing code might be broken - and I'm slightly nervous about the last change above. AIUI, the invariants that hold here are that we're walking the singly-linked list of the (struct nb_it

Re: [GOOGLE] backport discriminator support from google-4_8 to google-4_9

2014-05-12 Thread Cary Coutant
> Yes, this patch is a combination of all these patches. Some of them > are already in trunk. OK for google 4.9 branch. Thanks! -cary

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Mike Stump
I put in one small fix: Doing diffs in testsuite/objc.dg/ivar-visibility-4.m.~1~: --- testsuite/objc.dg/ivar-visibility-4.m.~1~ 2014-05-12 12:04:16.0 -0700 +++ testsuite/objc.dg/ivar-visibility-4.m 2014-05-12 13:50:53.0 -0700 @@ -29,7 +29,7 @@ { int a; - /* someiva

Re: profile mode maintenance patch

2014-05-12 Thread François Dumont
On 12/05/2014 22:42, Paolo Carlini wrote: Hi, On 05/12/2014 10:14 PM, François Dumont wrote: Regarding Makefile.in I miss last time. I moved to a new system lately, a Ubuntu based one, and still need to find out what version of automake/autoreconf I need to install. For the moment I have upda

Re: [GOOGLE] backport discriminator support from google-4_8 to google-4_9

2014-05-12 Thread Dehao Chen
Yes, this patch is a combination of all these patches. Some of them are already in trunk. Dehao On Mon, May 12, 2014 at 1:28 PM, Cary Coutant wrote: > On Mon, May 12, 2014 at 1:11 PM, Dehao Chen wrote: >> This patch backports r199154 from google-4_8 to google-4_9 >> >> Bootstrapped and passed r

Re: profile mode maintenance patch

2014-05-12 Thread Paolo Carlini
Hi, On 05/12/2014 10:14 PM, François Dumont wrote: Regarding Makefile.in I miss last time. I moved to a new system lately, a Ubuntu based one, and still need to find out what version of automake/autoreconf I need to install. For the moment I have updated Makefile.in manually. Isn't this clear

Re: [gomp4] Add tables generation

2014-05-12 Thread Bernd Schmidt
On 05/08/2014 12:11 PM, Bernd Schmidt wrote: On 05/06/2014 05:32 PM, Ilya Verbin wrote: On 05 Apr 17:22, Bernd Schmidt wrote: Things seemed to work over here, but now I'm not certain whether the __start_/__stop_ functionality is GNU ld specific? Maybe we should just go back to the previous vers

Re: [PATCH 88/89] Use gimple_phi in many more places.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: This patch converts almost every usage of gsi_start_phis to act on a gimple_phi_iterator: everywhere (I believe) where the underlying statements are then accessed via a gimple_phi_ accessor. There are some places where the phi nodes then just go through ge

Re: [PATCH 62/89] Concretize gimple_label_label

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_label_label): Require a const_gimple_label rather than just a const_gimple. * cfgexpand.c (label_rtx_for_bb): Convert local from gimple to gimple_label, replacing a check against GIMPLE_LABEL with a

Re: [PATCH 52/89] Make gimple_phi_arg_edge require a gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_arg_edge): Require a gimple_phi rather than a plain gimple. * graphite-sese-to-poly.c (rewrite_phi_out_of_ssa): Require a gimple_phi_iterator; strengthen local "phi" from gimple to a gimpl

Re: [PATCH 49/89] Make add_phi_arg require a gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * tree-phinodes.h (add_phi_arg): Require a gimple_phi rather than a plain gimple. * tree-phinodes.c (add_phi_arg): Likewise. * gimple-ssa-strength-reduction.c (create_phi_basis): Strengthen local "phi" from plai

Re: [GOOGLE] backport discriminator support from google-4_8 to google-4_9

2014-05-12 Thread Cary Coutant
On Mon, May 12, 2014 at 1:11 PM, Dehao Chen wrote: > This patch backports r199154 from google-4_8 to google-4_9 > > Bootstrapped and passed regression test. > > OK for google-4_9 branch? Don't forget the follow-ons listed below. Any reason not to combine them into this patch? Looks good. Thanks!

RE: [PATCH, PR60189, Cilk+] Fix for ICE with incorrect Cilk_sync usage

2014-05-12 Thread Zamyatin, Igor
Ping. Should I prepare the patch? Thanks, Igor > > -Original Message > > From: Jason Merrill [mailto:ja...@redhat.com] > > Sent: Monday, April 14, 2014 9:49 PM > > To: Zamyatin, Igor; Jakub Jelinek > > Cc: GCC Patches (gcc-patches@gcc.gnu.org); Iyer, Balaji V > > Subject: Re: [PATCH, PR6

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Joseph S. Myers
On Mon, 12 May 2014, Manuel López-Ibáñez wrote: > I will be very surprised if the common defaults are overriding a FE > default and it is not a bug in the FE. Well, I think that needs justification, not just "very surprised". Identify (presumably in an automated way) all the cases where an opti

Re: [PATCH 71/89] Concretize gimple_cond_make_{false|true}

2014-05-12 Thread David Malcolm
On Mon, 2014-05-12 at 13:55 -0600, Jeff Law wrote: > On 04/21/14 10:57, David Malcolm wrote: > > gcc/ > > * gimple.h (gimple_cond_make_false): Require a gimple_cond. > > (gimple_cond_make_true): Likewise. > > > > * tree-cfg.c (fold_cond_expr_cond): Add a checked cast to > > gimple_c

Re: [PING][RFC][PATCH] RL78 - Add predicates to reduce code bloat when accessing volatile memory.

2014-05-12 Thread DJ Delorie
> My understanding of 'volatile' is that even the resulting code I gave as > an example is not actually volatile-safe: > > mova, !240 > ora, #32 > mov!240, a > > as the value stored in address 240 could change just before and/or just > after the 'or', and get overwritten by the sec

[GOOGLE] backport discriminator support from google-4_8 to google-4_9

2014-05-12 Thread Dehao Chen
This patch backports r199154 from google-4_8 to google-4_9 Bootstrapped and passed regression test. OK for google-4_9 branch? Thanks, Dehao Index: gcc/final.c === --- gcc/final.c (revision 210329) +++ gcc/final.c (working copy) @@ -

Re: [PATCH 51/89] Update GRAPHITE to use more concrete gimple statement classes

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * graphite-scop-detection.c (canonicalize_loop_closed_ssa): Strengthen local "psi" to be a gimple_phi_iterator and "phi" to a gimple_phi. * graphite-sese-to-poly.c (phi_arg_in_outermost_loop): Require a gimple_p

Re: [PATCH 55/89] Use gimple_call for callgraph edges

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * cgraph.h (cgraph_edge::call_stmt): Strengthen field from plain gimple to a gimple_call. (cgraph_create_edge): Require a gimple_call rather than a plain gimple. (cgraph_create_indirect_edge): Likewise. (

Re: [PING][RFC][PATCH] RL78 - Add predicates to reduce code bloat when accessing volatile memory.

2014-05-12 Thread Richard Hulme
On 09/05/14 21:20, DJ Delorie wrote: The key to the msp430 change is that I reviewed every pattern that used the predicates, and only changed the ones where the pattern was known to be volatile-safe. For the RL78, the devirtualizer may make a pattern non-volatile-safe, and many patterns are macr

Re: [PATCH 68/89] Concretize three gimple_return_ accessors

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_return_retval_ptr): Require a const_gimple_return rather than a const_gimple. (gimple_return_retval): Likewise. (gimple_return_set_retval): Require a gimple_return. * cfgexpand.c (expand_gimpl

[Patch] Change URL in commit emails to https

2014-05-12 Thread Tobias Burnus
The patch changes the URL shown in the release message to HTTPS. (Cf. https://gcc.gnu.org/viewcvs/gcc/hooks/svnmailer.conf and gcc-cvs mailing list.) OK? Tobias Index: svnmailer.conf === --- svnmailer.conf (Revision 210336) +++ sv

Re: [PATCH 71/89] Concretize gimple_cond_make_{false|true}

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_cond_make_false): Require a gimple_cond. (gimple_cond_make_true): Likewise. * tree-cfg.c (fold_cond_expr_cond): Add a checked cast to gimple_cond within region guarded by check for GIMPLE_COND.

[PATCH] Fix up ix86_expand_set_or_movmem (PR target/61060)

2014-05-12 Thread Jakub Jelinek
Hi! As discussed in the PR, ix86_expand_set_or_movmem assumes that count == 0 means !CONST_INT_P (count_exp), but that is not necessarily true with -O0 -ftree-ter, when the middle-end doesn't immediately see the length argument be integer_zerop, yet TER results in it being expanded as const0_rtx.

Re: [PATCH 89/89] Convert various gimple to gimple_phi within ssa-iterators.h

2014-05-12 Thread Jeff Law
On 04/21/14 10:58, David Malcolm wrote: gcc/ * ssa-iterators.h (FOR_EACH_PHI_OR_STMT_USE): Add checked cast to gimple_phi. (FOR_EACH_PHI_OR_STMT_DEF): Likewise. * ssa-iterators.h (single_phi_def): Require a gimple_phi. (op_iter_init_phiuse): Likewise.

Re: [PATCH 72/89] Concretize gimple_switch_index and gimple_switch_index_ptr

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_switch_index): Require a const_gimple_switch rather than a plain const_gimple. (gimple_switch_index_ptr): Likewise. * gimplify-me.c (gimple_regimplify_operands): Add checked cast to gimple_swi

Re: [PATCH 83/89] Concretize gimple_call_set_tail and gimple_call_tail_p

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_set_tail): Require a gimple_call. (gimple_call_tail_p): Likewise. * cfgexpand.c (expand_gimple_tailcall): Likewise. (expand_gimple_basic_block): Convert calls to is_gimple_call to a dyn_c

Re: [PATCH 77/89] Concretize various expressions from gimple to gimple_cond

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * ipa-split.c (check_forbidden_calls): Replace check against GIMPLE_COND with a dyn_cast_gimple_cond, introducing a gimple_cond local. * predict.c (predict_extra_loop_exits): Likewise. * tree-vrp.c (fold_predicat

Re: [PATCH 56/89] Various gimple to gimple_call conversions in IPA

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * ipa-prop.c (detect_type_change): Require a gimple_call rather than a plain gimple. (detect_type_change_ssa): Likewise. (compute_complex_assign_jump_func): Likewise. (compute_complex_ancestor_jump_func): Likewis

Re: [PATCH 87/89] Use gimple_call in some places within tree-ssa-dom.c

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * tree-ssa-dom.c (struct hashable_expr): Strengthen field call.fn_from from gimple to gimple_call. (initialize_hash_element): Replace check against GIMPLE_CALL with dyn_cast_gimple_call and update gimple_call_ uses to us

Re: [PATCH 86/89] Concretize gimple_call_copy_flags and ipa_modify_call_arguments

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_copy_flags): Require gimple_calls. * ipa-prop.c (ipa_modify_call_arguments): Require a gimple_call. * ipa-prop.h (ipa_modify_call_arguments): Likewise. * tree-inline.c (copy_bb): Replace is_gimp

Re: [PATCH 85/89] Concretize gimple_assign_nontemporal_move_p

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_assign_nontemporal_move_p): Require a const_gimple_assign rather than a const_gimple. * cfgexpand.c (expand_gimple_stmt_1): Add local assign_stmt and checked cast within "case GIMPLE_ASSIGN".

Re: [Patch: RL78] Add support for 64-bit doubles

2014-05-12 Thread DJ Delorie
I think this part is wrong (and your mailer is dropping some whitespace). "long double" should always be 64 bits, which means that libgcc must always have DFmode helpers. #define LONG_DOUBLE_TYPE_SIZE64 /*DOUBLE_TYPE_SIZE*/ -#define LIBGCC2_HAS_DF_MODE1 +#ifdef __RL78_32BIT_DOUBLES__ +#define

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Manuel López-Ibáñez
On 12/05/2014, Joseph S. Myers wrote: > On Mon, 12 May 2014, Matthias Klose wrote: > >> I didn't look close enough to the gfortran test results. PR driver/61126 >> is a >> fix for the regression introduced with the fix for the above issue. With >> this >> patch proposed by Manuel, gfortran.dg/we

Re: [PATCH 76/89] Concretize gimple_cond_{lhs|rhs}_ptr

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_cond_lhs_ptr): Require a const_gimple_cond rather than just a const_gimple_cond. (gimple_cond_rhs_ptr): Likewise. * gimplify-me.c (gimple_regimplify_operands): Add a checked cast to gimple_con

Re: [PATCH 75/89] Concretize gimple_cond_set_{lhs|rhs}

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_cond_set_lhs): Require a gimple_cond. (gimple_cond_set_rhs): Likewise. * tree-parloops.c (transform_to_exit_first_loop): Convert locals "cond_stmt" and "cond_nit" to gimple_cond, adding checked casts,

Re: [PATCH 74/89] Concretize gimple_cond_set_code

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_cond_set_code): Require a gimple_cond. * tree-complex.c (expand_complex_comparison): Add a checked cast to gimple_cond within "case GIMPLE_COND". * tree-ssa-loop-ivcanon.c (create_canonical_iv): Conv

Re: [PATCH 67/89] Make gimple_phi_arg_location require a gimple_phi.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_arg_location): Require a gimple_phi. * tree-into-ssa.c (rewrite_update_phi_arguments): Replace a check for code GIMPLE_PHI with a dyn_cast and a new local. * tree-ssa-ter.c (ter_is_replaceable_p):

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Mike Stump
On May 12, 2014, at 11:56 AM, Dimitris Papavasiliou wrote: > So we [ .. ] expect that they silently shadow the instance variables, that is > that warnings are _not_ generated. Perfect, thanks. I’ve checked it in: Committed revision 210333. Thanks for all your hard work. > So I take it that I

Re: [PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-05-12 Thread Dimitris Papavasiliou
On 05/12/2014 07:24 PM, Mike Stump wrote: On Apr 28, 2014, at 3:35 AM, Dimitris Papavasiliou wrote: + a = private;/* { dg-warning "hides instance variable" "" { xfail *-*-* } } */ + a = protected; /* { dg-warning "hides instance variable" "" { xfail *-*-* } } */ + a = public; /* {

Re: [PATCH 79/89] Concretize gimple_call_nothrow_p

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_nothrow_p): Require a gimple_call. * tree-eh.c (stmt_could_throw_p): Add checked cast to gimple_call. * tree-vect-slp.c (vect_build_slp_tree_1): Replace call to is_gimple_call with dyn_cast_gimp

Re: [PATCH 73/89] Concretize gimple_cond_{true|false}_label

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_cond_true_label): Require a const_gimple_cond rather than just a const_gimple. (gimple_cond_false_label): Likewise. * omp-low.c (diagnose_sb_2): Add checked cast to gimple_cond within case GIM

Re: [wide-int] Add fast path for hosts with HWI widening multiplication

2014-05-12 Thread Richard Henderson
On 05/08/2014 01:12 PM, Richard Sandiford wrote: > * wide-int.cc: Only include longlong.h if W_TYPE_SIZE==32 or > __SIZEOF_INT128__ is defined. FWIW, this looks pretty good to me. r~

Re: [PATCH 80/89] Tweak to gimplify_modify_expr

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimplify.c (gimplify_modify_expr): Introduce local "call_stmt". OK once prerequisites have gone in. Jeff

Re: [PATCH, PR52252] Vectorization for load/store groups of size 3.

2014-05-12 Thread Evgeny Stupachenko
The test is on general changes. However I was able to test it on x86 only. I see 2 possible solutions: 1. Set the test for x86 only. 2. Modify it so that it will pass on sparc-sun-solaris2. If 2. is not acceptable I'll create patch for 1. Currently I don't see why "in0_9 = *in_27" is not supported

Re: [PATCH 82/89] Concretize gimple_call_set_fntype

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_set_fntype): Require a gimple_call. * omp-low.c (lower_omp_1): Add a new local gimple_call "call_stmt", from a checked cast to gimple_call within the "case GIMPLE_CALL", for the regions where "st

Re: [PATCH 69/89] Make gimple_cond_set_{true|false}_label require gimple_cond.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_cond_set_true_label): Require a gimple_cond. (gimple_cond_set_false_label): Likewise. * tree-cfg.c (make_cond_expr_edges): Convert "entry" from gimple to a gimple_cond. (cleanup_dead_labels):

Re: [PATCH 81/89] Concretize gimple_call_set_fn

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_set_fn): Require a gimple_call. * trans-mem.c (dump_tm_memopt_transform): Likewise. (tm_memopt_transform_blocks): Add checked casts to gimple_call in suites guarded by is_tm_simple_{load|store},

Re: [PATCH 84/89] Concretize gimple_call_arg_flags

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_arg_flags): Require a const_gimple_call rather than a const_gimple. * gimple.c (gimple_call_fnspec): Likewise. (gimple_call_arg_flags): Likewise. This is fine, but will need tweaking once the con

Re: [PATCH 78/89] Concretize gimple_call_set_nothrow

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_set_nothrow): Require a gimple_call. * trans-mem.c (ipa_tm_insert_gettmclone_call): Likewise. (ipa_tm_transform_calls_redirect): Add checked cast to gimple call; this is only called for gsi on a

Re: [PATCH 70/89] Concretize locals within expand_omp_for_init_counts

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * omp-low.c (expand_omp_for_init_counts): Eliminate local "stmt" in favor of new locals "cond_stmt" and "assign_stmt" with more concrete types. OK once prerequisites have gone in. jeff

Re: [PATCH 65/89] Concretize three gimple_try_set_ accessors

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.c (gimple_copy): Add checked casts to gimple_try. * gimple.h (gimple_statement_base::dyn_cast_gimple_try): New. (gimple_try_set_kind): Require a gimple_try. (gimple_try_set_eval): Likewise. (gimple_try_

Re: [PATCH 66/89] Make gimple_phi_arg_location_from_edge require a gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_arg_location_from_edge): Require a gimple_phi. * tree-parloops.c (create_parallel_loop): Split up local variable "stmt", introducing other locals for the various statements created by this

Re: libsanitizer merge from upstream r208536

2014-05-12 Thread H.J. Lu
On Mon, May 12, 2014 at 4:20 AM, Konstantin Serebryany wrote: > This is the first libsanitizer merge in 4.10 (the last merge was in > December 2013). > > Tested on Ubuntu 12.04 like this: > rm -rf */{*/,}libsanitizer && make -j 50 > make -j 40 -C gcc check-g{cc,++} > RUNTESTFLAGS='--target_board=u

Re: [PATCH 65/89] Concretize three gimple_try_set_ accessors

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.c (gimple_copy): Add checked casts to gimple_try. * gimple.h (gimple_statement_base::dyn_cast_gimple_try): New. (gimple_try_set_kind): Require a gimple_try. (gimple_try_set_eval): Likewise. (gimple_try_

Re: [PATCH 63/89] Concretize gimple_eh_filter_set_types and gimple_eh_filter_set_failure

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_eh_filter_set_types): Require a gimple_eh_filter. (gimple_eh_filter_set_failure): Likewise. * gimple.c (gimple_copy): Add checked casts to gimple_eh_filter within GIMPLE_EH_FILTER case. --- OK once pr

Re: [PATCH 54/89] Make gimple_call_return_slot_opt_p require a gimple_call.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_return_slot_opt_p): Require a gimple_call rather than a plain gimple. * gimple-walk.c (walk_stmt_load_store_addr_ops): Convert usage of is_gimple_call to dyn_cast_gimple_call, introducing a new l

Re: [PATCH 48/89] Make gimple_phi_arg_def_ptr and gimple_phi_arg_has_location require a gimple_phi

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_phi_arg_def_ptr): Require a gimple_phi rather than a plain gimple. (gimple_phi_arg_has_location): Likewise. * gimple-streamer-in.c (input_phi): Return a gimple_phi rather than a plain gimple.

Re: [PATCH 39/89] Introduce gimple_omp_parallel

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_parallel): New typedef. (const_gimple_omp_parallel): New typedef. * cgraphbuild.c (build_cgraph_edges): Convert check of code against GIMPLE_OMP_PARALLEL to a dyn_cast_gimple_omp_parallel and

Re: [PATCH 36/89] Introduce gimple_omp_continue

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_continue): New typedef. (const_gimple_omp_continue): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_continue): New. (gimple_build_omp_continue): Return a gimple_omp_continue ra

Re: [PATCH, PR58066] preferred_stack_boundary update for tls expanded call

2014-05-12 Thread Wei Mi
>> Here is a patch for the test. It contains two changes: >> 1. For emutls, there will be an explicit call generated at expand >> pass, and no stack adjustment is needed. So add /* { >> dg-require-effective-target tls_native } */ in the test. >> 2. Replace cfi_def_cfa_offset with insn sequence chec

Re: [PATCH 38/89] Introduce gimple_omp_for

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_for): New. (const_gimple_omp_for): New. * gimple.h (gimple_statement_base::as_a_gimple_omp_for): New. (gimple_statement_base::dyn_cast_gimple_omp_for): New. (gimple_build_omp_for): Retu

Re: [PATCH 43/89] Introduce gimple_omp_target

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_target): New typedef. (const_gimple_omp_target): New typedef. * gimple.h (gimple_statement_base::as_a_gimple_omp_target): New. (gimple_build_omp_target): Return a gimple_omp_target rath

Re: [PATCH 54/89] Make gimple_call_return_slot_opt_p require a gimple_call.

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_return_slot_opt_p): Require a gimple_call rather than a plain gimple. * gimple-walk.c (walk_stmt_load_store_addr_ops): Convert usage of is_gimple_call to dyn_cast_gimple_call, introducing a new l

Re: [PATCH 45/89] Introduce gimple_omp_sections

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * coretypes.h (gimple_omp_sections): New typedef. (const_gimple_omp_sections): New typedef. * gimple-pretty-print.c (dump_gimple_omp_sections): Require a gimple_omp_sections rather than a plain gimple. (pp_gimpl

Re: [patch] fix impliedness of -Wunused-parameter depending on -Wexta option ordering

2014-05-12 Thread Joseph S. Myers
On Mon, 12 May 2014, Matthias Klose wrote: > I didn't look close enough to the gfortran test results. PR driver/61126 is a > fix for the regression introduced with the fix for the above issue. With this > patch proposed by Manuel, gfortran.dg/wextra_1.f now passes, and no new > regressions seen

Re: [PATCH 46/89] tree-parloops.c: Use gimple_phi in various places

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * tree-parloops.c (reduction_info::keep_res): Strengthen field from plain gimple to gimple_phi. (transform_to_exit_first_loop): Strengthen locals "phi", "nphi" to gimple_phi. Eliminate early decl of gimple_stmt_iterator

Re: [PATCH 64/89] Concretize gimple_try_set_catch_is_cleanup

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_try_set_catch_is_cleanup): Require a gimple_try. * gimplify.c (gimplify_expr): Convert local "try_" from a gimple to a gimple_try. OK after prerequisites have gone in. jeff

Re: [PATCH 61/89] Concretize gimple_call_use_set and gimple_call_clobber_set

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_call_use_set): Require a gimple_call. (gimple_call_clobber_set): Likewise. OK once prerequisites have gone in. jeff

Re: [PATCH 60/89] Concretize gimple_catch_types

2014-05-12 Thread Jeff Law
On 04/21/14 10:57, David Malcolm wrote: gcc/ * gimple.h (gimple_catch_types): Require a const_gimple_catch rather than a const_gimple. --- OK once prerequisites have gone in. jeff

  1   2   >