Re: [PATCH] testsuite: Register loaded libs

2014-04-27 Thread Mike Stump
On Apr 27, 2014, at 10:45 AM, Sebastian Huber wrote: > 2014-04-27 Sebastian Huber > > * testsuite/lib/libffi.exp (load_gcc_lib): Register loaded libs. So, I didn’t see anything that strikes me as wrong, but, I’m curious why you want this? I didn’t see any uses?

Re: [Patch 3/3] Separate `repeating` node from `alternative` node in regex

2014-04-27 Thread Tim Shen
On Sun, Apr 27, 2014 at 8:31 AM, Jonathan Wakely wrote: > This one is OK to commit too - thanks. Committed. Thanks! -- Regards, Tim Shen

Re: [Patch 2/3] Make regex's infinite loop detection accurate

2014-04-27 Thread Tim Shen
On Sun, Apr 27, 2014 at 8:30 AM, Jonathan Wakely wrote: >> This patch is OK to commit. > > > ... with the fix for the un-uglified variable name. Committed. Thanks! -- Regards, Tim Shen

Re: [Patch 1/3] Use manual regex algorithm switching

2014-04-27 Thread Tim Shen
On Sat, Apr 26, 2014 at 10:50 AM, Jonathan Wakely wrote: > This patch is OK, thanks very much. Committed. Thanks! -- Regards, Tim Shen

Re: -fuse-caller-save - Enable for MIPS

2014-04-27 Thread Tom de Vries
On 27-04-14 12:27, Richard Sandiford wrote: Tom de Vries writes: 2014-01-12 Radovan Obradovic Tom de Vries * config/mips/mips-protos.h (mips_emit_call_insn): Declare. * config/mips/mips.h (POST_CALL_TMP_REG): Define. * config/mips/mips.c (mips_emit_cal

Re: [gofrontend-dev] libgo patch committed: Fix madvise on systems with page size != 4096

2014-04-27 Thread Ian Lance Taylor
On Sun, Apr 27, 2014 at 2:45 PM, Michael Hudson-Doyle wrote: > "'Ian Lance Taylor ' via gofrontend-dev" > writes: > >> This patch from Anton Blanchard fixes libgo to adjust to the system page >> size when calling madvise. Bootstrapped and ran Go testsuite on >> x86_64-unknown-linux-gnu. Committ

Re: [DOC PATCH] Rewrite docs for inline asm

2014-04-27 Thread dw
Please take my comments below into account for an updated patch, and once Andrew and Richard have signed of, this is then good to commit. You did raise a technical question I'd like to get Andrew, Richard or someone to comment on: How does the user know what is dialect #0? Same for the oth

Re: [gofrontend-dev] libgo patch committed: Fix madvise on systems with page size != 4096

2014-04-27 Thread Michael Hudson-Doyle
"'Ian Lance Taylor ' via gofrontend-dev" writes: > This patch from Anton Blanchard fixes libgo to adjust to the system page > size when calling madvise. Bootstrapped and ran Go testsuite on > x86_64-unknown-linux-gnu. Committed to mainline and 4.9 branch. Hi, I think this patch will make my Ca

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Mon, Apr 28, 2014 at 2:13 AM, Andrew Pinski wrote: > On Sun, Apr 27, 2014 at 1:25 PM, Prathamesh Kulkarni > wrote: >> On Mon, Apr 28, 2014 at 1:31 AM, Andrew Pinski wrote: >>> On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni >>> wrote: On Sun, Apr 27, 2014 at 11:22 PM, wrote: >>>

Re: RFA: Avoid creating garbage CONSTs in cselib.c

2014-04-27 Thread Richard Sandiford
Steven Bosscher writes: >> It looks like ~1.5% to ~2% of all rtl created comes from wrap_constant >> in cselib.c. Not a huge amount, but it's easy to avoid. >> >> Tested on x86_64-linux-gnu. OK to install? > > Nice patch. OK after also testing this on an autoinc target. OK, installed after comp

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Andrew Pinski
On Sun, Apr 27, 2014 at 1:25 PM, Prathamesh Kulkarni wrote: > On Mon, Apr 28, 2014 at 1:31 AM, Andrew Pinski wrote: >> On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni >> wrote: >>> On Sun, Apr 27, 2014 at 11:22 PM, wrote: > On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Mon, Apr 28, 2014 at 1:31 AM, Andrew Pinski wrote: > On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni > wrote: >> On Sun, Apr 27, 2014 at 11:22 PM, wrote: >>> >>> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saun

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Andrew Pinski
On Sun, Apr 27, 2014 at 12:50 PM, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 11:22 PM, wrote: >> >> >>> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni >>> wrote: >>> On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014 at 06:21:20PM +0530,

Re: [wwwdocs] Buildstat update for 4.8

2014-04-27 Thread Gerald Pfeifer
On Sun, 27 Apr 2014, Tom G. Christensen wrote: > Testresults for 4.8.2: > aarch64-unknown-linux-gnu (new) > hppa-unknown-linux-gnu (new) > x86_64-unknown-linux-gnu Thanks, applied. Gerald

Re: [wwwdocs] Buildstat update for 4.7

2014-04-27 Thread Gerald Pfeifer
On Sun, 27 Apr 2014, Tom G. Christensen wrote: > Testresults for 4.7.3: > alphaev68-dec-osf5.1a That may be the last report for this platform we'll get ever, except for a GCC 4.7.4 perhaps. Thanks, applied. Gerald

Re: [wwwdocs] Buildstat update for 4.6

2014-04-27 Thread Gerald Pfeifer
On Sun, 27 Apr 2014, Tom G. Christensen wrote: > Testresults for 4.6.4: > alphaev68-dec-osf5.1a Applied, thanks. Gerald

Re: [wwwdocs] Buildstat update for 4.4

2014-04-27 Thread Gerald Pfeifer
On Sun, 27 Apr 2014, Tom G. Christensen wrote: > Testresults for 4.4.7: > i386-pc-solaris2.7 Wow. Solaris 7/x86? That's really old. :-) Applied. Gerald

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Sun, Apr 27, 2014 at 11:22 PM, wrote: > > >> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni >> wrote: >> >>> On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders >>> wrote: On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 5:31 PM, Trevo

[Patch, Fortran] Fix an issue with CLASS and -fcoarray=lib on the trunk

2014-04-27 Thread Tobias Burnus
First, I would be really delighted if someone could review my coarray patches for the trunk as it makes simpler to develop patches on top of it: * http://gcc.gnu.org/ml/fortran/2014-04/msg00087.html * http://gcc.gnu.org/ml/fortran/2014-04/msg00091.html * http://gcc.gnu.org/ml/fortran/2014-04/msg0

Re: patch fortran, pr 59746, internal compiler error : segmentation fault

2014-04-27 Thread Tobias Burnus
Given that we are now in stage 1: Mikael and Bud, what's the status of this patch? http://gcc.gnu.org/ml/fortran/2014-03/msg00098.html Tobias On January 13, 2014 22:18, Mikael Morin wrote: Hello, Le 10/03/2014 03:15, jimmie.da...@l-3com.com a écrit : Index: gcc/gcc/fortran/symbol.c

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread pinskia
> On Apr 27, 2014, at 10:09 AM, Prathamesh Kulkarni > wrote: > >> On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders >> wrote: >>> On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014

[PATCH] testsuite: Register loaded libs

2014-04-27 Thread Sebastian Huber
libffi/ChangeLog 2014-04-27 Sebastian Huber * testsuite/lib/libffi.exp (load_gcc_lib): Register loaded libs. libjava/ChangeLog 2014-04-27 Sebastian Huber * testsuite/lib/libjava.exp (load_gcc_lib): Register loaded libs. libstdc++-v3/ChangeLog 2014-04-27 Sebastian

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Sun, Apr 27, 2014 at 8:48 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: >> On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders >> wrote: >> > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: >> >> Hi, >> >> Shall it a go

[Patch, Fortran] Fix ucobound checking bug and -fcoarray=lib argument passing

2014-04-27 Thread Tobias Burnus
This patch fixes two issues: a) ucobound(x) of an assumed-size array was wrongly rejected. b) For assumed-shape arrays, the dummy argument expected an array descriptor, which contains the codimension. However, only for allocatable coarrays, the coshape is stored in the descriptor - for all ot

[Patch, Fortran] (port branch to trunk) this_image()/num_images() changes for TS18508 and minor cleanup

2014-04-27 Thread Tobias Burnus
This patch ports another* patch from the Fortran-caf branch to the trunk; it only affects -fcoarray=lib. An earlier patch was posted before,** remains unreviewed and is replaced by this patch (re-diffed, minutely enhanced). Besides some minor clean-up in libgfortran/caf, the patch changes the

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 06:21:20PM +0530, Prathamesh Kulkarni wrote: > On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders > wrote: > > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: > >> Hi, > >> Shall it a good idea to add new warning -Wsizeof-array-argument that > >> war

Re: [patch, libgfortran] Wrong result for UTF-8/UCS-4 list-directed and namelist read and nml write

2014-04-27 Thread Jerry DeLisle
On 04/27/2014 04:57 AM, Andreas Schwab wrote: > Jerry DeLisle writes: > >> +static void >> +push_char4 (st_parameter_dt *dtp, gfc_char4_t c) >> +{ >> + gfc_char4_t *new, *p = (gfc_char4_t *) dtp->u.p.saved_string; >> + >> + if (p == NULL) >> +{ >> + dtp->u.p.saved_string = xcalloc (SCR

Re: debug container patch

2014-04-27 Thread Jonathan Wakely
On 17/04/14 22:43 +0200, François Dumont wrote: Hi Here is a patch to globally enhance debug containers implementation. François, sorry for the delay, this is a large patch and I wanted to give it the time it deserves to review properly. I have isolated all code of special functions in

Re: [Patch 2/3] Make regex's infinite loop detection accurate

2014-04-27 Thread Jonathan Wakely
On 27/04/14 13:28 +0100, Jonathan Wakely wrote: On 26/04/14 22:34 -0400, Tim Shen wrote: On Sat, Apr 26, 2014 at 1:00 PM, Jonathan Wakely wrote: Maybe a dumb question (I don't understand a lot of the regex code!) but is it correct to set this to 1 in the case where __rep_count.first != _M_curr

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Prathamesh Kulkarni
On Sun, Apr 27, 2014 at 5:31 PM, Trevor Saunders wrote: > On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: >> Hi, >> Shall it a good idea to add new warning -Wsizeof-array-argument that >> warns when sizeof is applied on parameter declared as an array ? > > Seems reasonable

Re: [Patch 3/3] Separate `repeating` node from `alternative` node in regex

2014-04-27 Thread Jonathan Wakely
On 25/04/14 18:04 -0400, Tim Shen wrote: * include/bits/regex_automaton.h (_NFA<>::_M_insert_repeat): Add _S_opcode_repeat support to distingush a loop from _S_opcode_alternative. * include/bits/regex_automaton.tcc (_State_base::_M_print, _State_base::_M_do

Re: [Patch 2/3] Make regex's infinite loop detection accurate

2014-04-27 Thread Jonathan Wakely
On 26/04/14 22:34 -0400, Tim Shen wrote: On Sat, Apr 26, 2014 at 1:00 PM, Jonathan Wakely wrote: Maybe a dumb question (I don't understand a lot of the regex code!) but is it correct to set this to 1 in the case where __rep_count.first != _M_current ? Could that result in the count going downw

Re: [C PATCH] proposal to add new warning -Wsizeof-array-argument

2014-04-27 Thread Trevor Saunders
On Sun, Apr 27, 2014 at 02:31:46AM +0530, Prathamesh Kulkarni wrote: > Hi, > Shall it a good idea to add new warning -Wsizeof-array-argument that > warns when sizeof is applied on parameter declared as an array ? Seems reasonable enough. > Similar to clang's -Wsizeof-array-argument: > http://

Re: [patch, libgfortran] Wrong result for UTF-8/UCS-4 list-directed and namelist read and nml write

2014-04-27 Thread Andreas Schwab
Jerry DeLisle writes: > +static void > +push_char4 (st_parameter_dt *dtp, gfc_char4_t c) > +{ > + gfc_char4_t *new, *p = (gfc_char4_t *) dtp->u.p.saved_string; > + > + if (p == NULL) > +{ > + dtp->u.p.saved_string = xcalloc (SCRATCH_SIZE, sizeof (gfc_char4_t)); > + dtp->u.p.saved_

Re: [DOC PATCH] Rewrite docs for inline asm

2014-04-27 Thread Richard Kenner
> >>> any symbols it references. This may result in those symbols getting > >>> discarded by GCC as unreferenced. > > > > We can omit "by GCC" here. > > We can, but we should not. We should avoid the passive voice like the > plague in technical documentation, even if doing so leads to some > slig

Re: [patch, fortran] Fix PR 59604

2014-04-27 Thread Thomas Koenig
Hi Tobias, > Am 12.04.2014 21:33, schrieb Thomas Koenig: >> please find attached a patch for PR 59604. >> >> The patch makes sure that, if -fno-range-check is specified, >> using int on an overflowing boz constant yields the same >> result for compile-time simplification and run-time >> execution.

RFA: Avoid creating garbage CONSTs in cselib.c

2014-04-27 Thread Richard Sandiford
It looks like ~1.5% to ~2% of all rtl created comes from wrap_constant in cselib.c. Not a huge amount, but it's easy to avoid. Tested on x86_64-linux-gnu. OK to install? Thanks, Richard gcc/ * cselib.c (find_slot_memmode): Delete. (cselib_hasher): Change compare_type to a stru

Re: [wide-int 3/5] Fix large widths in shifted_mask

2014-04-27 Thread Richard Sandiford
Kenneth Zadeck writes: > I think that this patch is fine as is.but in looking at the > surrounding code, i saw something that appears to be somewhat troubling. > > I am worried about the two asserts. Given that we now require that > some users write code similar to the code in tree-vrp.c:2

Re: -fuse-caller-save - Enable for MIPS

2014-04-27 Thread Richard Sandiford
Tom de Vries writes: > 2014-01-12 Radovan Obradovic > Tom de Vries > > * config/mips/mips-protos.h (mips_emit_call_insn): Declare. > * config/mips/mips.h (POST_CALL_TMP_REG): Define. > * config/mips/mips.c (mips_emit_call_insn): Remove static. Use > last_c

[wwwdocs] Buildstat update for 4.9

2014-04-27 Thread Tom G. Christensen
Latest results for 4.9.x -tgc Testresults for 4.9.0: i386-pc-solaris2.9 (2) i386-pc-solaris2.10 i386-pc-solaris2.11 sparc-sun-solaris2.9 (2) sparc-sun-solaris2.11 sparc64-sun-solaris2.9 x86_64-unknown-linux-gnu (2) Index: buildstat.html =

[wwwdocs] Buildstat update for 4.8

2014-04-27 Thread Tom G. Christensen
Latest results for 4.8.x -tgc Testresults for 4.8.2: aarch64-unknown-linux-gnu (new) hppa-unknown-linux-gnu (new) x86_64-unknown-linux-gnu Index: buildstat.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.8/buildstat.html,v re

[wwwdocs] Buildstat update for 4.7

2014-04-27 Thread Tom G. Christensen
Latest results for 4.7.x -tgc Testresults for 4.7.3: alphaev68-dec-osf5.1a Index: buildstat.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.7/buildstat.html,v retrieving revision 1.11 diff -u -r1.11 buildstat.html --- buildstat.h

[wwwdocs] Buildstat update for 4.6

2014-04-27 Thread Tom G. Christensen
Latest results for 4.6.x -tgc Testresults for 4.6.4: alphaev68-dec-osf5.1a Index: buildstat.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.6/buildstat.html,v retrieving revision 1.15 diff -u -r1.15 buildstat.html --- buildstat.h

[wwwdocs] Buildstat update for 4.4

2014-04-27 Thread Tom G. Christensen
Latest results for 4.4.x -tgc Testresults for 4.4.7: i386-pc-solaris2.7 Index: buildstat.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-4.4/buildstat.html,v retrieving revision 1.28 diff -u -r1.28 buildstat.html --- buildstat.html

Re: [DOC PATCH] Rewrite docs for inline asm

2014-04-27 Thread Andrew Haley
On 04/26/2014 10:33 PM, Gerald Pfeifer wrote: >>> +any symbols it references. This may result in those symbols getting >>> discarded >>> >> +by GCC as unreferenced. > We can omit "by GCC" here. We can, but we should not. We should avoid the passive voice like the plague in technical documentati

[Patch, Fortran] Fix handling of polymorphic coarrays and coarray components

2014-04-27 Thread Tobias Burnus
This is patch is the first change from Fortran-caf which I want to merge to the trunk; it only affects -fcoarray=lib. Build and regtested xon 86-64-gnu-linux. OK for the trunk? Tobias PS: I am currently looking at another issue with polymophic coarrays, which also affects -fcoarray=single; th