Re: Typo in ipa-inline-analysis.c?

2014-02-01 Thread Jan Hubicka
> ipa-inline-analysis.c has > > /* Return true if P is (false). */ > Should it be (true)? Yes, too much of cut&past. Patch to fix it is preapproved of course. Thanks! Honza > > static inline bool > true_predicate_p (struct predicate *p) > { > return !p-

Re: [C,C++] integer constants in attribute arguments

2014-02-01 Thread Marc Glisse
Ping http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01168.html (conversation starts at http://gcc.gnu.org/ml/gcc-patches/2013-11/msg03822.html ) On Sat, 18 Jan 2014, Marc Glisse wrote: On Thu, 2 Jan 2014, Jason Merrill wrote: On 11/30/2013 05:41 AM, Marc Glisse wrote: for some reason one of

Typo in ipa-inline-analysis.c?

2014-02-01 Thread H.J. Lu
ipa-inline-analysis.c has /* Return true if P is (false). */ Should it be (true)? static inline bool true_predicate_p (struct predicate *p) { return !p->clause[0]; } /* Return true if P is (false). */ static inline bool false_predicate_p (struct predic

Re: [Patch, fortran] PR57033 ICE on extended derived type and default initialization

2014-02-01 Thread Paul Richard Thomas
Dear Mikael, We seem to be breaking records tonight :-) OK by me for trunk, 4.7 and 4.8. Thanks! Paul On 1 February 2014 19:49, Mikael Morin wrote: > Hello, > > here is a fix for PR57033. > The problem was gfc_convert_to_structure_constructor calling itself > recursively and changing `actual'

Re: [Patch, fortran] PR49906 [4.7/4.8/4.9 Regression] error: size of variable '' is too large

2014-02-01 Thread Paul Richard Thomas
Mikael, Je t'en remercie! That must be one of the fastest reviews on record! Committed as revision 207389 4.7 and 4.8 to follow next weekend. Paul On 1 February 2014 19:28, Mikael Morin wrote: > Le 01/02/2014 18:57, Paul Richard Thomas a écrit : >> Dear All, >> >> This regression was flagged

[Patch, fortran] PR57033 ICE on extended derived type and default initialization

2014-02-01 Thread Mikael Morin
Hello, here is a fix for PR57033. The problem was gfc_convert_to_structure_constructor calling itself recursively and changing `actual' behind its back without going through the loop condition. The fix is pretty obvious; I thought there was something missing (see the PR) but on second thought, it

Re: [Patch, fortran] PR49906 [4.7/4.8/4.9 Regression] error: size of variable '' is too large

2014-02-01 Thread Mikael Morin
Le 01/02/2014 18:57, Paul Richard Thomas a écrit : > Dear All, > > This regression was flagged by Harald and the trigger, r158683, was > identified by HJ. Many thanks to both. It surprises me that the bug > has lain dormant for so long. > > The fix is fortunately relatively simple. CHARACTER sc

[Patch, fortran] PR49906 [4.7/4.8/4.9 Regression] error: size of variable '' is too large

2014-02-01 Thread Paul Richard Thomas
Dear All, This regression was flagged by Harald and the trigger, r158683, was identified by HJ. Many thanks to both. It surprises me that the bug has lain dormant for so long. The fix is fortunately relatively simple. CHARACTER scalars are, in fact arrays in one shape or form and so using them

Re: [PATCH] Improve EDGE_ABNORMAL construction (PR middle-end/59917, tree-optimization/59920)

2014-02-01 Thread H.J. Lu
On Tue, Jan 28, 2014 at 2:44 PM, Jakub Jelinek wrote: > Hi! > > As discussed in the PR and similarly to what has been done previously > for __builtin_setjmp only, this patch attempts to decrease number of > EDGE_ABNORMAL edges in functions with non-local gotos and/or setjmp or > other functions th

PATCH: PR tree-optimization/60024: global-buffer-overflow in init_regs_for_mode

2014-02-01 Thread H.J. Lu
Hi, init_regs_for_mode accesses global_regs before checking if regno is OK for a mode, which leads to buffer overflow. This patch moves HARD_REGNO_MODE_OK for checking global_regs. There is no functional change. OK for trunk? Thanks. H.J. --- 2014-02-01 H.J. Lu PR tree-optimizati

Re: PATCH: PR target/59605: Create jump_around_label only if it doesn't exist

2014-02-01 Thread H.J. Lu
On Sat, Feb 1, 2014 at 2:28 AM, Richard Sandiford wrote: > "H.J. Lu" writes: >> On Thu, Jan 30, 2014 at 10:43 AM, Richard Sandiford >> wrote: >>> Hi H.J., >>> >>> "H.J. Lu" writes: diff --git a/gcc/testsuite/gcc.dg/pr59605.c b/gcc/testsuite/gcc.dg/pr59605.c new file mode 100644

Re: [Ping][Patch, trivial] PR 56653: Fix warning when verifying checksums from MD5SUMS file in tarballs

2014-02-01 Thread Gerald Pfeifer
Thanks Dmitry! On Wed, 29 Jan 2014, Dmitry Gorbachev wrote: > This patch is to fix `md5sum: WARNING: 1 line is improperly formatted' thing. It would have been helpful to indicate what the actual problem was; at first I did not see that indeed it was an empty line in MD5SUMS that was causing the p

Re: [testsuite, committed] Fix unresolved vector26.C for c++98

2014-02-01 Thread Jakub Jelinek
On Sat, Feb 01, 2014 at 11:55:22AM +, Richard Sandiford wrote: > Uros Bizjak writes: > >> The scan-assembler test in vector26.C was showing up unresolved for c++98, > >> since in that case we report an expected error and don't produce any asm. > >> > >> Tested on mips64-linux-gnu and applied a

Re: [testsuite, committed] Fix unresolved vector26.C for c++98

2014-02-01 Thread Richard Sandiford
Uros Bizjak writes: >> The scan-assembler test in vector26.C was showing up unresolved for c++98, >> since in that case we report an expected error and don't produce any asm. >> >> Tested on mips64-linux-gnu and applied as obvious. > > -// { dg-final { scan-assembler-not "globl\[ \t]*_Z3bar" } } >

Re: [testsuite, committed] Fix unresolved vector26.C for c++98

2014-02-01 Thread Andreas Schwab
Uros Bizjak writes: > Hello! > >> The scan-assembler test in vector26.C was showing up unresolved for c++98, >> since in that case we report an expected error and don't produce any asm. >> >> Tested on mips64-linux-gnu and applied as obvious. > > -// { dg-final { scan-assembler-not "globl\[ \t]*_

Re: [testsuite, committed] Fix unresolved vector26.C for c++98

2014-02-01 Thread Uros Bizjak
Hello! > The scan-assembler test in vector26.C was showing up unresolved for c++98, > since in that case we report an expected error and don't produce any asm. > > Tested on mips64-linux-gnu and applied as obvious. -// { dg-final { scan-assembler-not "globl\[ \t]*_Z3bar" } } +// { dg-final { scan

[testsuite, committed] Fix pr49718.C for MIPS PIC

2014-02-01 Thread Richard Sandiford
Similar to Alpha, g++.dg/pr49718.C would fail for MIPS PIC because each called function is mentioned twice, once in the GOT reference and once in the R_MIPS_JALR reloc used for relaxing jumps to branches. Tested on mips64-linux-gnu and applied. Thanks, Richard gcc/testsuite/ * g++.dg/pr

[testsuite, committed] Fix unresolved vector26.C for c++98

2014-02-01 Thread Richard Sandiford
The scan-assembler test in vector26.C was showing up unresolved for c++98, since in that case we report an expected error and don't produce any asm. Tested on mips64-linux-gnu and applied as obvious. Thanks, Richard gcc/testsuite/ * g++.dg/ext/vector26.C: Restrict scan-assembler test to

Re: PATCH: PR target/59605: Create jump_around_label only if it doesn't exist

2014-02-01 Thread Richard Sandiford
"H.J. Lu" writes: > On Thu, Jan 30, 2014 at 10:43 AM, Richard Sandiford > wrote: >> Hi H.J., >> >> "H.J. Lu" writes: >>> diff --git a/gcc/testsuite/gcc.dg/pr59605.c b/gcc/testsuite/gcc.dg/pr59605.c >>> new file mode 100644 >>> index 000..4556843 >>> --- /dev/null >>> +++ b/gcc/testsuite/gcc.

Re: [PATCH] Fix up cprop to canonicalize PLUS/MINUS with 2 CONSTANT_P arguments (PR rtl-optimization/57915)

2014-02-01 Thread Jakub Jelinek
On Fri, Jan 31, 2014 at 11:12:58PM -0700, Jeff Law wrote: > On 01/31/14 22:52, Richard Biener wrote: > >On February 1, 2014 12:56:45 AM GMT+01:00, Steven Bosscher > > wrote: > >>On Fri, Jan 31, 2014 at 10:28 PM, Jakub Jelinek wrote: > >> > >>>Without this patch, cprop can propagate e.g. a SYMBOL_R

Re: [C++ Patch] PR 51219

2014-02-01 Thread Paolo Carlini
On 01/31/2014 11:00 PM, Jason Merrill wrote: On 01/28/2014 01:37 PM, Paolo Carlini wrote: ... by the way, I don't understand why we are appending the constructor at all for the unnamed bit-field?!? Eg, what about the below? I agree, it doesn't seem necessary; output_constructor deals fine with