RE: [PATCH GCC]Catch more MEM_REFs sharing common addressing part in gimple strength reduction

2013-09-08 Thread bin.cheng
Thanks for reviewing, I will correct all stupid spelling problem in the next version of patch. On Mon, Sep 9, 2013 at 8:15 AM, Bill Schmidt wrote: > >>>+ int (i * S). >>>+ Otherwise, just return double int zero. */ > > This is sufficient, since you are properly checking the next_interp > c

Fix redirection in ipa.c

2013-09-08 Thread Jan Hubicka
Hi, this patch fixes ICE when edge redirection happens just before summary generation. At that time we still don't want edges to be redirected when underlying statements are not. Bootstrapped/regtested x86_64-linux, comitted. * ipa.c (walk_polymorphic_call_targets): Fix redirection befo

Enable reference removal for speculative edges

2013-09-08 Thread Jan Hubicka
Hi, this hack I put on place since ipa-prop was breaking without it. Martin fixed the problem and I tested it can now be removed for Firefx build. Bootstrapped/regtested x86_64-linux, comitted. * ipa-prop.c (try_make_edge_direct_simple_call): Do not special case speculative edge

Re: [C++ Patch] PR 43452

2013-09-08 Thread Jason Merrill
On 09/05/2013 06:44 PM, Paolo Carlini wrote: + && warning (0, "possible problem detected in invocation of " + "delete [] operator:")) The warning should probably be suppressible by some flag. Jason

PR bootstrap/58340

2013-09-08 Thread Jeff Law
This fixes the problem noted by Zhendong in c#4. I'll be working through other reports of issues related to the tree-ssa-threadedge.c to see if there's any lingering problems. Bootstrapped and regression tested on x86_64-unknown-linux-gnu. Installed onto the trunk. diff --git a/gcc/ChangeLog

Re: [PATCH][RFC] Move IVOPTs closer to RTL expansion

2013-09-08 Thread pinskia
On Sep 8, 2013, at 7:01 PM, "Bin.Cheng" wrote: > On Wed, Sep 4, 2013 at 5:20 PM, Richard Biener wrote: >> >> The patch below moves IVOPTs out of the GIMPLE loop pipeline more >> closer to RTL expansion. That's done for multiple reasons. >> >> First, the loop passes that at the moment preceede

Re: [PATCH][RFC] Move IVOPTs closer to RTL expansion

2013-09-08 Thread Bin.Cheng
On Mon, Sep 9, 2013 at 10:01 AM, Bin.Cheng wrote: > On Wed, Sep 4, 2013 at 5:20 PM, Richard Biener wrote: >> >> The patch below moves IVOPTs out of the GIMPLE loop pipeline more >> closer to RTL expansion. That's done for multiple reasons. >> >> First, the loop passes that at the moment preceede

Re: [PATCH][RFC] Move IVOPTs closer to RTL expansion

2013-09-08 Thread Bin.Cheng
On Wed, Sep 4, 2013 at 5:20 PM, Richard Biener wrote: > > The patch below moves IVOPTs out of the GIMPLE loop pipeline more > closer to RTL expansion. That's done for multiple reasons. > > First, the loop passes that at the moment preceede IVOPTs leave > around IL that is in desparate need of bas

Re: [PATCH] Add vtable verification feature announcement to news on main page...

2013-09-08 Thread Caroline Tice
I believe I have addressed all the issues with the Vtable Verification feature. I have updated the announcement patch, and have attached the updated patch. Is this OK to commit? -- Caroline Tice cmt...@google.com On Thu, Aug 8, 2013 at 9:00 AM, Richard Earnshaw wrote: > On 07/08/13 18:19, Car

Re: [PATCH GCC]Catch more MEM_REFs sharing common addressing part in gimple strength reduction

2013-09-08 Thread Bill Schmidt
On Mon, 2013-09-02 at 11:15 +0200, Richard Biener wrote: > On Mon, Sep 2, 2013 at 8:56 AM, bin.cheng wrote: > > Hi, > > > > The gimple-ssa-strength-reduction pass handles CAND_REFs in order to find > > different MEM_REFs sharing common part in addressing expression. If such > > MEM_REFs are found

Re: RFC: patch to build GCC for arm with LRA

2013-09-08 Thread Vladimir Makarov
On 13-09-08 2:04 PM, Richard Sandiford wrote: Yvan Roux writes: @@ -5786,7 +5796,11 @@ get_index_scale (const struct address_info *info) && info->index_term == &XEXP (index, 0)) return INTVAL (XEXP (index, 1)); - if (GET_CODE (index) == ASHIFT + if ((GET_CODE (index) == ASHI

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL

2013-09-08 Thread Kugan
On 06/09/13 16:16, Richard Biener wrote: On 9/3/13 2:15 PM, Kugan wrote: Thanks Richard for reviewing. On 02/09/13 22:15, Richard Biener wrote: On Wed, Jul 3, 2013 at 2:25 PM, Kugan wrote: On 17/06/13 18:33, Richard Biener wrote: On Mon, 17 Jun 2013, Kugan wrote: +/* Extract the value ran

Re: *PING* Re: [PATCH] Fix handling of very long asm statements in inliner

2013-09-08 Thread Jan Hubicka
> Andi Kleen writes: > > Ping! > > This problem is still open, and afaik no better solution has been > proposed. It is also a regression. > > Is it ok to commit if I rerun the tests and they pass? OK. Honza

[C++ diagnostic Patch] Partially fix c++/58363 and more

2013-09-08 Thread Paolo Carlini
Hi all, Gaby, I was having a look to c++/58363 and besides the main issue, that is we probably want to help the user and tell him/her something about destructors, etc, I noticed that we aren't able to pretty print the pseudo destructor expression at issue: cannot convert ‘f.#‘var_decl’ not s

PING Re: [PATCH] Add -fno-instrument-function v2

2013-09-08 Thread Andi Kleen
Andi Kleen writes: > From: Andi Kleen > > [I posted this originally quite some time ago. > This version fixes all review problems, particularly > it works for C++ too and the test case really works.] Ping! Could someone please review it. Note this might be obsolete with Honza's LTO option wor

*PING* Re: [PATCH 2/2] Fix HLE example in manual

2013-09-08 Thread Andi Kleen
Andi Kleen writes: > On Thu, Jun 20, 2013 at 11:05:15AM -0700, Richard Henderson wrote: >> On 06/20/2013 06:20 AM, Andi Kleen wrote: >> > gcc/: >> > 2013-06-13 Andi Kleen >> > >> >* doc/extend.texi: Dont use __atomic_clear in HLE >> >example. Fix typo. >> >> Ok. > > I would like to

*PING* Re: [PATCH] Fix handling of very long asm statements in inliner

2013-09-08 Thread Andi Kleen
Andi Kleen writes: Ping! This problem is still open, and afaik no better solution has been proposed. It is also a regression. Is it ok to commit if I rerun the tests and they pass? > An auto generated program with a 6.4mio line asm statement gave > with 4.7 and 4.8: > > xxx.c:6400017:1: intern

Re: *PING*BACKPORT* [PATCH] Handle target specific memory models in C frontend

2013-09-08 Thread Andi Kleen
Andi Kleen writes: > On Fri, Nov 09, 2012 at 07:08:07AM -0800, Richard Henderson wrote: >> On 2012-11-09 07:03, Andi Kleen wrote: >> >PR55139 >> >* c-common.c (get_atomic_generic_size): Mask with >> > MEMMODEL_MASK >> >> Ok. > > I would like to backport this patch to 4.8. Ok? >

[Patch to gcc/function] PR 58362

2013-09-08 Thread Paolo Carlini
Hi, this patchlet fixes the column # of the unused parameter warnings emitted by do_warn_unused_parameter by explicitly passing DECL_SOURCE_LOCATION (decl) instead of wrongly relying on '+', which in this case ends up meaning the location of the function declaration. Tested x86_64-linux. Th

Re: RFC: patch to build GCC for arm with LRA

2013-09-08 Thread Richard Sandiford
Yvan Roux writes: > @@ -5786,7 +5796,11 @@ get_index_scale (const struct address_info *info) >&& info->index_term == &XEXP (index, 0)) > return INTVAL (XEXP (index, 1)); > > - if (GET_CODE (index) == ASHIFT > + if ((GET_CODE (index) == ASHIFT > + || GET_CODE (index) == ASHIF

[PING^3] [PATCH 0/6] Contributing new target port: Andes 'nds32'.

2013-09-08 Thread Chung-Ju Wu
Hi, GCC Global Maintainers, The nds32 port initial patch is still awaiting for global maintainer's approval before it may be committed into trunk. All the issues of review comment have been addressed in the new v3 patches: [PATCH 1/6] Andes nds32: configure settings for nds32 target. http://gc

Re: [PATCH 6/6] Andes nds32: wwwdoc for nds32 target.

2013-09-08 Thread Chung-Ju Wu
On 7/8/13 7:05 PM, Chung-Ju Wu wrote: > Hi, > > This patch consists of webpage changes for describing a new 'nds32' > target port and related information. > > The following is a brief overview of changes: > > htdocs/ > 2013-07-08 Chung-Ju Wu > Shiva Chen > > * backends.html

Type inheritance graph analysis & speculative devirtualization, part 4/7 (unreachable virtual method removal)

2013-09-08 Thread Jan Hubicka
Hi, this patch make symtab_remove_unreachable_nodes to use polymorphic call analysis same was as the cgraph construction code. The use is basically simple - instead of marking all virtual functions as potentially reachable until inlining, we mark only those that appear in the list of possible targ

Re: [PATCH 5/6] Andes nds32: documentation for nds32 target.

2013-09-08 Thread Chung-Ju Wu
On 7/25/13 12:25 AM, Chung-Ju Wu wrote: > On 7/12/13 1:35 AM, Chung-Ju Wu wrote: >> >> Fixed accordingly. >> >> Thanks for the review comments. A revised patch is provided >> and the issues you mentioned are fixed: >>a. Describe nds32 built-in functions. >>b. Use "@:" and "16--47" >> > >

Re: [PATCH 4/6] Andes nds32: testsuite modifications for nds32 target.

2013-09-08 Thread Chung-Ju Wu
On 7/25/13 12:23 AM, Chung-Ju Wu wrote: > > A revised patch is provided and here is a summary: > > 1. The extend identifiers testcases are supposed to be tested. > 2. Add preliminary nds32-specific testcases. > > It has been a while since last v2 patch. So I create a new v3 patch to resolv

Re: [PATCH 3/6] Andes nds32: libgcc of nds32 porting.

2013-09-08 Thread Chung-Ju Wu
On 7/31/13 7:07 PM, Chung-Ju Wu wrote: > On 7/25/13 12:41 AM, Chung-Ju Wu wrote: > > According to Joseph's comment in this discussion thread: > http://gcc.gnu.org/ml/gcc-patches/2013-07/msg01372.html > > Using LGPLv2.1+ with exception seems appropriate for sfp-machine.h. > So I update our libgc

Re: [PATCH 1/6] Andes nds32: configure settings for nds32 target.

2013-09-08 Thread Chung-Ju Wu
On 7/24/13 11:46 PM, Chung-Ju Wu wrote: > On 7/10/13 6:56 AM, Joseph S. Myers wrote: >> On Mon, 8 Jul 2013, Chung-Ju Wu wrote: > > Thanks for the review comments. > A revised patch is provided and here is a summary: > > 1. Handle -march option within the compiler proper. > Simplify the hand

Re: Add varpool node removal/insertion hooks

2013-09-08 Thread Gabriel Dos Reis
On Sun, Sep 8, 2013 at 9:58 AM, Jan Hubicka wrote: >> On Sun, Sep 8, 2013 at 9:23 AM, Jan Hubicka wrote: >> > Hi, >> > this patch adds API for varpool node removal/insertion hooks that are >> > fully symmetric >> > to cgraph code. >> > >> > Bootstrapped/regtested x86_64-linux after working aroun

Re: RFC: patch to build GCC for arm with LRA

2013-09-08 Thread Vladimir Makarov
On 13-08-30 9:09 AM, Yvan Roux wrote: Hi, here is a request for comments on the 2 attached patches which enable the build of GCC on ARM with LRA. The patches introduce a new undocumented option -mlra to use LRA instead of reload, as what was done on previous LRA support, which is here to ease t

Re: RFA: Fix debug-insn sensitivity in RA

2013-09-08 Thread Vladimir Makarov
On 13-09-07 9:01 AM, Richard Sandiford wrote: Jakub Jelinek writes: On Sat, Sep 07, 2013 at 12:37:14PM +0100, Richard Sandiford wrote: Steven Bosscher writes: Can you please add a test case? What kind of test would you suggest? Do we have a harness for testing that -O2 and -O2 -g .text out

Re: Add varpool node removal/insertion hooks

2013-09-08 Thread Jan Hubicka
> On Sun, Sep 8, 2013 at 9:23 AM, Jan Hubicka wrote: > > Hi, > > this patch adds API for varpool node removal/insertion hooks that are fully > > symmetric > > to cgraph code. > > > > Bootstrapped/regtested x86_64-linux after working around PR58340, will > > commit it shortly. > > Hi Honza, > >

Re: Add varpool node removal/insertion hooks

2013-09-08 Thread Gabriel Dos Reis
On Sun, Sep 8, 2013 at 9:23 AM, Jan Hubicka wrote: > Hi, > this patch adds API for varpool node removal/insertion hooks that are fully > symmetric > to cgraph code. > > Bootstrapped/regtested x86_64-linux after working around PR58340, will commit > it shortly. Hi Honza, I can't bootstrap trunk

Add varpool node removal/insertion hooks

2013-09-08 Thread Jan Hubicka
Hi, this patch adds API for varpool node removal/insertion hooks that are fully symmetric to cgraph code. Bootstrapped/regtested x86_64-linux after working around PR58340, will commit it shortly. Honza * cgraph.h (varpool_node_hook, varpool_node_hook_list, varpool_add_node_rem

Re: [diagnostic patch] PR 54941

2013-09-08 Thread Gabriel Dos Reis
On Sun, Sep 8, 2013 at 8:59 AM, Paolo Carlini wrote: > Hi Gaby, > > > On 09/08/2013 03:41 PM, Gabriel Dos Reis wrote: >> >> On Sun, Sep 8, 2013 at 8:00 AM, Paolo Carlini >> wrote: >>> >>> Hi all, Gaby, >>> >>> in this bug Manuel noticed that the zeros in the diagnostic lines of the >>> form: >>>

Re: [diagnostic patch] PR 54941

2013-09-08 Thread Paolo Carlini
Hi Gaby, On 09/08/2013 03:41 PM, Gabriel Dos Reis wrote: On Sun, Sep 8, 2013 at 8:00 AM, Paolo Carlini wrote: Hi all, Gaby, in this bug Manuel noticed that the zeros in the diagnostic lines of the form: :0:0: don't provide useful information. Thus the below just avoids printing the zer

Re: [diagnostic patch] PR 54941

2013-09-08 Thread Gabriel Dos Reis
On Sun, Sep 8, 2013 at 8:00 AM, Paolo Carlini wrote: > Hi all, Gaby, > > in this bug Manuel noticed that the zeros in the diagnostic lines of the > form: > > :0:0: > > don't provide useful information. Thus the below just avoids printing the > zeros basing directly on the file name: admittedl

Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...

2013-09-08 Thread Gabriel Dos Reis
On Sun, Sep 8, 2013 at 4:36 AM, Paolo Carlini wrote: > .. it's r202296 aka bootstrap/58340, Jeff is already on it. Thanks for the detective work, Paolo. -- Gaby

[diagnostic patch] PR 54941

2013-09-08 Thread Paolo Carlini
Hi all, Gaby, in this bug Manuel noticed that the zeros in the diagnostic lines of the form: :0:0: don't provide useful information. Thus the below just avoids printing the zeros basing directly on the file name: admittedly, it may seem a bit gross, but in practice the strcmp would oft

Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...

2013-09-08 Thread Paolo Carlini
.. it's r202296 aka bootstrap/58340, Jeff is already on it. Paolo.

Re: [PATCH, vtv update] Add documentation for --enable-vtable-verify configure option...

2013-09-08 Thread Paolo Carlini
Hi, On 09/08/2013 02:26 AM, Gabriel Dos Reis wrote: /home/gdr/src/gcc.svn/gcc/cp/pt.c:7064:1: internal compiler error: in propagate_threaded_block_debug_into, at tree-ssa-threadedge.c:623 maybe_get_template_decl_from_type_decl (tree decl) Yes, this is the serious one, which of course I'm also