Re: [PATCH] Fix bootstrap with -O3

2013-02-12 Thread Marek Polacek
On Tue, Feb 12, 2013 at 08:21:06PM +, Alec Teal wrote: > Why did this occur? I am curious. It is caused by -fipa-cp-clone, which -O3 entails. Marek

Re: expansion of vector shifts...

2013-02-12 Thread David Miller
From: David Miller Date: Fri, 16 Nov 2012 00:33:05 -0500 (EST) > From: Richard Sandiford > Date: Mon, 29 Oct 2012 10:14:53 + > >> ...given that the code is like you say written: >> >> if (SHIFT_COUNT_TRUNCATED) >> { >> if (CONST_INT_P (op1) >> ... >> else if (GET_

Re: [google 4_7] Fix bad merge into coverage_init (issue7322063)

2013-02-12 Thread Teresa Johnson
Ok, I will apply the same fix to google/main after appropriate testing. Teresa On Tue, Feb 12, 2013 at 1:54 PM, Xinliang David Li wrote: > ok. The same problem exists in google/main too. > > David > > On Tue, Feb 12, 2013 at 1:38 PM, Teresa Johnson wrote: >> This patch fixes a bad merge from go

Re: [google 4_7] Fix bad merge into coverage_init (issue7322063)

2013-02-12 Thread Xinliang David Li
ok. The same problem exists in google/main too. David On Tue, Feb 12, 2013 at 1:38 PM, Teresa Johnson wrote: > This patch fixes a bad merge from google/integration to google/4_7. > > Passes regression tests. Ok for google/4_7? > > Thanks, > Teresa > > 2013-02-12 Teresa Johnson > > * c

[google 4_7] Fix bad merge into coverage_init (issue7322063)

2013-02-12 Thread Teresa Johnson
This patch fixes a bad merge from google/integration to google/4_7. Passes regression tests. Ok for google/4_7? Thanks, Teresa 2013-02-12 Teresa Johnson * coverage.c (coverage_init): Move test coverage handling to the correct location within coverage_init (as in trunk)

C++ PATCH for c++/56285 (wrong error with inheriting ctor)

2013-02-12 Thread Jason Merrill
We need to move for rvalue ref parms as well as value ones. Tested x86_64-pc-linux-gnu, applying to trunk. commit 29189e48dc7a62ff6a3a67984dbc64f4ada72862 Author: Jason Merrill Date: Tue Feb 12 12:56:52 2013 -0500 PR c++/56285 * method.c (add_one_base_init): Handle base constructor

Re: [PATCH] Fix bootstrap with -O3

2013-02-12 Thread Alec Teal
On 12/02/13 19:59, Marek Polacek wrote: Thanks for noticing, I used auto-completing of words... I'll fix it up and commit. Marek Why did this occur? I am curious. Alec

Re: [PATCH] Fix bootstrap with -O3

2013-02-12 Thread Marek Polacek
On Tue, Feb 12, 2013 at 08:52:27PM +0100, Jakub Jelinek wrote: > On Tue, Feb 12, 2013 at 08:26:37PM +0100, Marek Polacek wrote: > > That's right, so I used something hopefully better this time around ;) > > Ok for trunk now? > > > > 2013-02-12 Marek Polacek > > > > PR c/44938 > > * c-p

Re: [GCC 4.8 changes] PATCH: Mention several user-visible changes for x86

2013-02-12 Thread Uros Bizjak
On Tue, Feb 12, 2013 at 8:45 PM, Igor Zamyatin wrote: > This patch updates GCC 4.8 changes.html to mention Broadwell's > features, RTM and HLE support and fixed pre-reload scheduler. > > OK to commit? > > > Thanks, > Igor > > Index: htdocs/gcc-4.8/changes.html > ==

Re: [PATCH] Fix bootstrap with -O3

2013-02-12 Thread Jakub Jelinek
On Tue, Feb 12, 2013 at 08:26:37PM +0100, Marek Polacek wrote: > That's right, so I used something hopefully better this time around ;) > Ok for trunk now? > > 2013-02-12 Marek Polacek > > PR c/44938 > * c-parser.c (c_parser_postfix_expression_after_primar): Initialize The functio

[cxx-conversion] Add Record Builder Class

2013-02-12 Thread Lawrence Crowl
Add class record_builder to ease construction of records and unions. Use it in some appropriate places. Nathan please review the vxworks changes. tree.h New class record_builder. tree.c Implement record_builder member functions. asan.c Change asan_global_struct to use r

[GCC 4.8 changes] PATCH: Mention several user-visible changes for x86

2013-02-12 Thread Igor Zamyatin
Hi, This patch updates GCC 4.8 changes.html to mention Broadwell's features, RTM and HLE support and fixed pre-reload scheduler. OK to commit? Thanks, Igor Index: htdocs/gcc-4.8/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/g

Re: [PATCH] Fix bootstrap with -O3

2013-02-12 Thread Marek Polacek
On Sun, Feb 10, 2013 at 12:29:41AM +0100, Marc Glisse wrote: > >2013-02-07 Marek Polacek > > > > * c-parser.c (origtypes): Initialize to NULL. > > Maybe mention PR44938? (there may be a dup or two) Ok, I added that. > (I thought it was the name of the function that went inside the > paren

Re: [PATCH] Fix PR56181, rewrite fix_loop_structure

2013-02-12 Thread Marcus Shawcroft
On 12 February 2013 15:38, Richard Biener wrote: > On Tue, 12 Feb 2013, Marcus Shawcroft wrote: > >> Sorry, I'll send that again copying gcc-patches in this time... >> >> >> -- Forwarded message -- >> From: Marcus Shawcroft >> Date: 12 February 2013 15:17 >> Subject: Re: [PATCH] F

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Richard Sandiford
Aldy Hernandez writes: >> Rather than: >> >>/* Change optabs if needed. */ >>if (TREE_OPTIMIZATION_OPTABS (opts)) >> this_target_optabs >>= (struct target_optabs *) TREE_OPTIMIZATION_OPTABS (opts); >>else >> this_target_optabs = &default_targe

patch to fix PR56148

2013-02-12 Thread Vladimir Makarov
The following patch fixes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56148 The patch was successfully bootstrapped and tested on x86/x86-64. Committed as rev.195998. 2013-02-12 Vladimir Makarov PR inline-asm/56148 * lra-constraints.c (process_alt_operands): Match early clo

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Richard Sandiford
Richard Sandiford writes: > Aldy Hernandez writes: >>> Rather than: >>> >>> /* Change optabs if needed. */ >>> if (TREE_OPTIMIZATION_OPTABS (opts)) >>> this_target_optabs >>> = (struct target_optabs *) TREE_OPTIMIZATION_OPTABS (opts); >>> else >>> this

C++ PATCH for c++/56291 (ICE with constexpr constructor)

2013-02-12 Thread Jason Merrill
When a class has all non-polymorphic bases but has virtual functions itself, its vtable pointer goes before the bases but is still initialized after them, so sort_constexpr_mem_initializers needs to handle this case as well. Tested x86_64-pc-linux-gnu, applying to trunk and 4.7. commit 1e98e1c

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Aldy Hernandez
Rather than: /* Change optabs if needed. */ if (TREE_OPTIMIZATION_OPTABS (opts)) this_target_optabs = (struct target_optabs *) TREE_OPTIMIZATION_OPTABS (opts); else this_target_optabs = &default_target_optabs; I think it'd be

Re: [PATCH 2/2] [asan] Avoid instrumenting duplicated memory access in the same basic block

2013-02-12 Thread Jakub Jelinek
On Tue, Feb 12, 2013 at 05:28:11PM +0100, Dodji Seketeli wrote: > Thanks. Here is the updated patch that hopefully addresses your > comments. Thanks, yes. Just please add /* { dg-final { cleanup-tree-dump "asan0" } } */ lines to all new tests after the last dg-final line in those tests and check

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Richard Sandiford
Jakub Jelinek writes: > On Mon, Feb 11, 2013 at 06:15:05PM -0600, Aldy Hernandez wrote: >> How does this look? > > Looks good to me. > >> Jakub, what's this you mention in the PR about caching >> __optimize__((3))? You also mention I shouldn't compare against >> this_target_optabs, but default_ta

Re: [PATCH 2/2] [asan] Avoid instrumenting duplicated memory access in the same basic block

2013-02-12 Thread Dodji Seketeli
Jakub Jelinek writes: > On Tue, Feb 12, 2013 at 03:19:37PM +0100, Dodji Seketeli wrote: >> gcc/ >> * Makefile.in (asan.o): Add new dependency on hash-table.h >> * asan.c (struct asan_mem_ref, struct mem_ref_hasher): New types. >> (asan_mem_ref_init, asan_mem_ref_get_end, get_mem_re

RFC: c-common PATCH to allow __int128_t literals

2013-02-12 Thread Jason Merrill
Although __int128_t is technically not an extended integer type because we don't want to change intmax_t, it seems appropriate to me to give it the same semantics as an extended integer type apart from that one aspect. The only thing we weren't implementing is support for numeric literals, whi

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Jakub Jelinek
On Tue, Feb 12, 2013 at 09:58:38AM -0600, Aldy Hernandez wrote: > OK for trunk? I'd still prefer Richard to chime in, I'm really not familiar enough with MIPS switchable target stuff. > +/* Recompute the optabs. If they have changed, save the new set of > + optabs in the optimization node OPTN

[PATCH] PR55033: Fix

2013-02-12 Thread Sebastian Huber
This patch from Alan Modra fixes a section type conflict error. See also http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02172.html Test results on PowerPC without this patch: http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg01351.html Test results on PowerPC with this patch: http://gcc.gnu.org/

Re: libsanitizer merge from upstream r173241

2013-02-12 Thread Evgeniy Stepanov
Yes, this looks good. I've added some tests and committed to compiler-rt. Thanks! On Tue, Feb 12, 2013 at 5:46 PM, Jakub Jelinek wrote: > On Tue, Feb 12, 2013 at 05:28:53PM +0400, Evgeniy Stepanov wrote: >> Hey, >> >> seems like that last of the scanf changes are in. >> We're intercepting __isoc9

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Aldy Hernandez
Jakub, what's this you mention in the PR about caching __optimize__((3))? You also mention I shouldn't compare against this_target_optabs, but default_target_optabs. But what if this_target_optabs has changed? (See patch). The reason for that is that this_target_optabs could at that point b

New branch: c++-concepts

2013-02-12 Thread Gabriel Dos Reis
Hi, I've created a new branch, called c++-concepts for work being done for "C++ concepts" (yes, again.) This new effort is unrelated to previous "ConceptGCC" so I left alone the inactive branch "c++0x-concepts". The patch below has been committed. Thanks, -- Gaby Index: svn.html

Re: [PATCH] Fix PR56181, rewrite fix_loop_structure

2013-02-12 Thread Richard Biener
On Tue, 12 Feb 2013, Marcus Shawcroft wrote: > Sorry, I'll send that again copying gcc-patches in this time... > > > -- Forwarded message -- > From: Marcus Shawcroft > Date: 12 February 2013 15:17 > Subject: Re: [PATCH] Fix PR56181, rewrite fix_loop_structure > To: Richard Biene

[PATCH] Fix PR56181, rewrite fix_loop_structure

2013-02-12 Thread Marcus Shawcroft
Sorry, I'll send that again copying gcc-patches in this time... -- Forwarded message -- From: Marcus Shawcroft Date: 12 February 2013 15:17 Subject: Re: [PATCH] Fix PR56181, rewrite fix_loop_structure To: Richard Biener On 12 February 2013 14:54, Richard Biener wrote: > I ca

Re: [PATCH][ARM] Implement vectorizer cost hooks

2013-02-12 Thread Christophe Lyon
On 12 February 2013 14:42, Richard Earnshaw wrote: > On 11/02/13 15:43, Christophe Lyon wrote: >> >> Richard, >> >> Thanks for your comments. >> >> Here a new version with the changes you suggested. >> > > Thanks for turning this around quickly. This is fine. > > Ramana and I have discussed this

Re: [PATCH] Fix PR56181, rewrite fix_loop_structure

2013-02-12 Thread Richard Biener
On Tue, 12 Feb 2013, Marcus Shawcroft wrote: > On 7 February 2013 11:38, Richard Biener wrote: > > > > This rewrites fix_loop_structure to be equivalent to loop > > detection from scratch via flow_loops_find with re-using > > of existing loop tree entries. > > > > This addresses a few shortcoming

Re: [PATCH] Fix PR56181, rewrite fix_loop_structure

2013-02-12 Thread Marcus Shawcroft
On 7 February 2013 11:38, Richard Biener wrote: > > This rewrites fix_loop_structure to be equivalent to loop > detection from scratch via flow_loops_find with re-using > of existing loop tree entries. > > This addresses a few shortcomings of fix_loop_structure. First, > as shown by the testcase i

Re: [PATCH 2/2] [asan] Avoid instrumenting duplicated memory access in the same basic block

2013-02-12 Thread Jakub Jelinek
On Tue, Feb 12, 2013 at 03:19:37PM +0100, Dodji Seketeli wrote: > gcc/ > * Makefile.in (asan.o): Add new dependency on hash-table.h > * asan.c (struct asan_mem_ref, struct mem_ref_hasher): New types. > (asan_mem_ref_init, asan_mem_ref_get_end, get_mem_ref_hash_table) > (has_

[PATCH] Fix LTO with global register vars

2013-02-12 Thread Richard Biener
We add global register vars into the LTO symtab processed by the linker. That's of course bogus. Fixed with the following patch. Bootstrap & regtest running on x86_64-unknown-linux-gnu. Richard. 2013-02-12 Richard Biener PR lto/56297 * lto-streamer-out.c (write_symbol): Do

Re: PR target/52555: attribute optimize is overriding command line options

2013-02-12 Thread Jakub Jelinek
On Mon, Feb 11, 2013 at 06:15:05PM -0600, Aldy Hernandez wrote: > How does this look? Looks good to me. > Jakub, what's this you mention in the PR about caching > __optimize__((3))? You also mention I shouldn't compare against > this_target_optabs, but default_target_optabs. But what if > this_

[PATCH] Fix PR56295

2013-02-12 Thread Richard Biener
This fixes the code difference -O3 vs. -O3 -flto reported in PR56295. For the -flto run we are confused by the extra MEM_REF we wrap every global decl with in the IL (that is to support seamless and alias-correct replacement of global decls with their prevailing decl). The following un-wraps the

Re: libsanitizer merge from upstream r173241

2013-02-12 Thread Jakub Jelinek
On Tue, Feb 12, 2013 at 05:28:53PM +0400, Evgeniy Stepanov wrote: > Hey, > > seems like that last of the scanf changes are in. > We're intercepting __isoc99_*scanf irrespective of the glibc version, > because (a) it does not hurt (and with the static runtime, even > interceptor itself is thrown ou

Re: [PATCH][ARM] Implement vectorizer cost hooks

2013-02-12 Thread Richard Earnshaw
On 11/02/13 15:43, Christophe Lyon wrote: Richard, Thanks for your comments. Here a new version with the changes you suggested. Thanks for turning this around quickly. This is fine. Ramana and I have discussed this and we're agreed that we'd like this to go into 4.8. However, if any prob

Re: libsanitizer merge from upstream r173241

2013-02-12 Thread Evgeniy Stepanov
Hey, seems like that last of the scanf changes are in. We're intercepting __isoc99_*scanf irrespective of the glibc version, because (a) it does not hurt (and with the static runtime, even interceptor itself is thrown out by the linker), and (b) user program and tool's runtime can be built with di

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 01:47 PM, domi...@lps.ens.fr wrote: But the last time I checked, modern darwin defined _GLIBCXX_USE_C99_MATH_TR1, no problems. AFAICT this is true, but I think darwin10 was released in 2011 so I doubt it has any support for c++11. Anyway, about the cstdlib issue the below makes a

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Dominique Dhumieres
> But the last time I checked, modern darwin defined > _GLIBCXX_USE_C99_MATH_TR1, no problems. AFAICT this is true, but I think darwin10 was released in 2011 so I doubt it has any support for c++11. > Anyway, about the cstdlib issue the below makes available the new > functions in c_std/cstdlib

Re: [patch] [libffi] do not install libffi library, headers and documentation

2013-02-12 Thread Richard Biener
On Tue, Feb 12, 2013 at 1:44 PM, Richard Biener wrote: > On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose wrote: >> The libffi library, headers and documentation are still installed, although >> libffi provides separate releases for a long time. So do not install these >> anymore as part of a GCC

Re: [patch] [libffi] do not install libffi library, headers and documentation

2013-02-12 Thread Richard Biener
On Tue, Feb 12, 2013 at 1:30 PM, Matthias Klose wrote: > The libffi library, headers and documentation are still installed, although > libffi provides separate releases for a long time. So do not install these > anymore as part of a GCC install. Tested with a build and an install with go > and j

[PATCH] PR55033: Test case

2013-02-12 Thread Sebastian Huber
Test results with this patch: http://gcc.gnu.org/ml/gcc-testresults/2013-02/msg01351.html 2013-02-12 Sebastian Huber PR target/55033 * gcc.target/powerpc/pr55033.c: New. --- gcc/testsuite/gcc.target/powerpc/pr55033.c | 21 + 1 files changed, 21 insertion

[patch] [libffi] do not install libffi library, headers and documentation

2013-02-12 Thread Matthias Klose
The libffi library, headers and documentation are still installed, although libffi provides separate releases for a long time. So do not install these anymore as part of a GCC install. Tested with a build and an install with go and java enabled (both using libffi_convenience). Ok for the trunk?

Re: [Patch, Fortran, OOP] PR 46952: [OOP] Spurious "recursive call" error with type bound procedure

2013-02-12 Thread Janus Weil
>> here is a simple patch for a rejects-valid problem with deferred >> type-bound procedures. This is the patch from comment 5 in the PR. A >> simpler (but equivalent) patch can be found in comment 4. Both fix the >> problem and are free of testsuite regressions. >> >> Is any of the two versions st

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 12:40 PM, domi...@lps.ens.fr wrote: IIRC I have already asked a similar question about atan2, erf, ... which don't appear in the std namespace on darwin. You should check whether darwin by chance uses by default c_std instead of c_global. The former doesn't provide C++11 facilities

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Dominique Dhumieres
IIRC I have already asked a similar question about atan2, erf, ... which don't appear in the std namespace on darwin. Dominique

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 12:32 PM, Paolo Carlini wrote: On 02/12/2013 12:26 PM, domi...@lps.ens.fr wrote: The test fails on x86_64-apple-darwin10 with FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) Excess errors: /opt/gcc/work/libstdc++-v3/testsuite/18_support/quick_exit/quick_exit.cc:

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 12:26 PM, domi...@lps.ens.fr wrote: The test fails on x86_64-apple-darwin10 with FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) Excess errors: /opt/gcc/work/libstdc++-v3/testsuite/18_support/quick_exit/quick_exit.cc:36:3: error: 'at_quick_exit' is not a member

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Dominique Dhumieres
The test fails on x86_64-apple-darwin10 with FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) Excess errors: /opt/gcc/work/libstdc++-v3/testsuite/18_support/quick_exit/quick_exit.cc:36:3: error: 'at_quick_exit' is not a member of 'std' /opt/gcc/work/libstdc++-v3/testsuite/18_sup

Re: [PATCH] Cilk Plus merging to trunk (3 of n)

2013-02-12 Thread Richard Biener
On Mon, Feb 11, 2013 at 7:12 PM, Iyer, Balaji V wrote: > Hello Everyone, >Attached, please find a patch that implements Array Notations for C++. > This patch affects the C++ compiler and should build (or be applied) on top > of the Array Notation for C patch (2 of n: > http://gcc.gnu.org/ml

Re: [GCC 4.8 changes] PATCH: Mention -maddress-mode=[short|long]

2013-02-12 Thread Richard Biener
On Mon, Feb 11, 2013 at 7:05 PM, H.J. Lu wrote: > Hi, > > This patch updates GCC 4.8 changes.html to mention > -maddress-mode=[short|long] for x32. OK to install? > > > H.J. > --- > Index: changes.html > === > RCS file: /cvs/gcc/wwwd

[PATCH] Fix PR56288

2013-02-12 Thread Richard Biener
This fixes a oversight when introducing anonymous SSA names. I managed to change a checking piece to a noop. Oops. I took the opportunity to move the freelist check earlier, as the type check would trigger for freed SSA names as well. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied

Re: [Patch, Fortran, OOP] PR 46952: [OOP] Spurious "recursive call" error with type bound procedure

2013-02-12 Thread Tobias Burnus
Janus Weil wrote: here is a simple patch for a rejects-valid problem with deferred type-bound procedures. This is the patch from comment 5 in the PR. A simpler (but equivalent) patch can be found in comment 4. Both fix the problem and are free of testsuite regressions. Is any of the two versions

Re: [patch, Fortran] Fix PR 56224

2013-02-12 Thread Tobias Burnus
Thomas Koenig wrote: Am 09.02.2013 11:22, schrieb Tobias Burnus: Why did you put a FIXME there? What's wrong with adding the directory here? I think module files are different enough from include files that I would like to have them in different directories. I think they are similar enough

Re: [Patch,avr]: ad PR54222: Add saturated multiply

2013-02-12 Thread Denis Chertykov
2013/2/11 Georg-Johann Lay : > This patch adds optimized support for (short) (un)signed _Sat _Accum > multiplication (HA, UHA, SA, USA). > > The 32-bit multiply uses 64 = 32 * 32 widening multiplication. As a spin-off, > the widening mul is available as [u]mulsidi3 default pattern. > > > Okay for