Re: [Patch, Fortran] PR55763 - reject "type is(INTEGER)" with non-class(*) selector in SELECT TYPE

2013-01-06 Thread Paul Richard Thomas
Dear Tobias, This, as you say, is obvious. OKfor trunk. Thanks for the patch. Paul On 6 January 2013 16:32, Tobias Burnus wrote: > A rather obvious fix, though one can think about the error wording. > > Bootstrapped and regtested on x86-64-gnu-linux. > OK for the trunk? > > Tobias -- The

[PATCH] avoid undefined behavior in libiberty/cplus-dem.c

2013-01-06 Thread Nickolai Zeldovich
consume_count() in libiberty/cplus-dem.c relies on signed integer overflow (which is undefined behavior in C) to detect overflow when parsing a count value. As a result, recent versions of gcc (e.g., 4.7.2) will remove that if check altogether as dead code, since it can only be true with UB. T

[v3] fix PR 55728 and PR 55847

2013-01-06 Thread Jonathan Wakely
PR libstdc++/55847 * src/c++11/shared_ptr.cc (bad_weak_ptr::what()): Correct string. PR libstdc++/55728 * include/std/functional (bad_function_call::what()): Declare. * src/c++11/functional.cc (bad_function_call::what()): Define. * config/abi/pre/gnu

PR tree-optimization/55823 (ipa-inline-transform ICE)

2013-01-06 Thread Jan Hubicka
Hi, as discused in the PR log there seems to be ordering issue in update_indirect_edges_after_inlining that first updates info in call edge to correspond the situation after inlining and then it tries to devirtualize that is trying to look up the info prior inlining. Bootstrapped/regtested x86_64-

Support for MIPS r5900

2013-01-06 Thread Jürgen Urban
Hello, I created a patch from scratch to support MIPS r5900 used in the Playstation 2, but I have some problems with it. The attached patch only works with the latest binutils from CVS. The binutils forces the compiler to use r5900 compatible instructions which is good to find errors in the GCC

Re: [cxx-conversion] Change uses of htab_t in gcc/config to hash_table.

2013-01-06 Thread Lawrence Crowl
On 1/6/13, Richard Biener wrote: > On Sun, Jan 6, 2013 at 6:55 AM, Xinliang David Li wrote: >> I noticed that the traverse and traverse_noresize method takes >> Argument as the first template parameter. It should be moved to be the >> second after the callback. In most of the cases, the type of t

[v3] Document implementation-defined bucket counts

2013-01-06 Thread Jonathan Wakely
The standard says that the initial number of buckets in an unordered associative container is implementation-defined when not set by the user (I would have made it unspecified but noone asked me ;-) so this patch documents our implementation's choice. * include/bits/unordered_map.h: Fix ty

Re: [committed] 2011 and 2012 Copyright year updates

2013-01-06 Thread Richard Sandiford
Mike Stump writes: > On Jan 6, 2013, at 4:13 AM, Richard Sandiford > wrote: >> Anyway, here's my attempt a script to convert to ranges and, if enabled, >> to include the current year. > > I don't think we should update to the current year. It just seems easier than having to remember to update t

Re: [committed] 2011 and 2012 Copyright year updates

2013-01-06 Thread Richard Sandiford
Jakub Jelinek writes: > On Sun, Jan 06, 2013 at 12:13:32PM +, Richard Sandiford wrote: >> I never remember to update the copyright years, so I thought I'd have a go. >> And you were right of course. It ended up being a huge time sink. >> >> Anyway, here's my attempt a script to convert to ra

Re: [Patch, fortran] Fix PR53876 (regression), PR55990 (regression) and PR55992

2013-01-06 Thread Paul Richard Thomas
Indeed - all your nits are veritable nits. For some reason, I set the working directory as PR55990 and kept referring to that :-) The tescase was always checked with a local version but I did verify that DejaGnu agreed that it worked. Committed revision 194953 gnu central is taking its time ab

Re: abi doc out of date?

2013-01-06 Thread Jonathan Wakely
On 1 January 2013 13:04, Jonathan Wakely wrote: > On 1 January 2013 03:33, Kenny Simpson wrote: >> http://gcc.gnu.org/onlinedocs/libstdc++/manual/abi.html >> >> does not seem to have updates for gcc 4.7 in sections 3,4,7. >> >> e.g. should there be an entry in section 3 like... >> GCC 4.7.0: libstd

Re: [v3 testsuite] gdb-test.exp: catch error running gdb command

2013-01-06 Thread Mike Stump
On Jan 3, 2013, at 3:57 PM, Janis Johnson wrote: > The libstdc++ prettyprinter tests require a certain level of support > from GDB, and the check for that GDB support runs a command that > includes a quoted string. This causes an error from the testsuite > infrastructure for embedded processors w

Re: fixincludes for libquadmath build regression

2013-01-06 Thread Bruce Korb
On 01/06/13 12:12, Alexandre Oliva wrote: > On Dec 30, 2012, Bruce Korb wrote: > >> On 12/30/12 01:42, Paolo Bonzini wrote: >>> Not my territory anymore, but it looks much better! CCing Bruce. > >> Long time. It's no wonder you've forgotten this little world! :) > > Indeed! > >> Anyway, plea

Re: [committed] 2011 and 2012 Copyright year updates

2013-01-06 Thread Mike Stump
On Jan 6, 2013, at 12:24 PM, Mike Stump wrote: > I did the analysis by case reduction so that like case classes reduce to > generalized forms and then I audited all the forms of changes that appeared. > This lets me skip quickly the majority of changes and focus in on just the > weirdest of th

Re: [PATCH] Adding target rdos to GCC

2013-01-06 Thread Uros Bizjak
Hello! > Updated patches with the suggestions below, except that the initial value is 0 > (which is not meaningful). I also added a setting in rdos target file to use > r15 > for PIC instead of rbx. *** gcc-4.8-20121230/gcc/config/i386/i386.c Thu Dec 27 02:58:06 2012 --- gcc-work/gcc/config/

Re: [committed] 2011 and 2012 Copyright year updates

2013-01-06 Thread Mike Stump
On Jan 6, 2013, at 4:13 AM, Richard Sandiford wrote: > Anyway, here's my attempt a script to convert to ranges and, if enabled, > to include the current year. I don't think we should update to the current year. > The script only updates FSF copyright notices > and leaves others alone. I've tri

Re: fixincludes for libquadmath build regression

2013-01-06 Thread Alexandre Oliva
On Dec 30, 2012, Bruce Korb wrote: > On 12/30/12 01:42, Paolo Bonzini wrote: >> Not my territory anymore, but it looks much better! CCing Bruce. > Long time. It's no wonder you've forgotten this little world! :) Indeed! > Anyway, please make the expressions more readable and strip > out the

Re: [Bug bootstrap/53607] opt-functions.awk --> "awk: There is a regular expression error."

2013-01-06 Thread Daniel Richard G.
On Sun, 2013 Jan 6 18:45+0100, Andreas Schwab wrote: > > > sub(".* " name "\\(", "", flags) > > - if (flags ~ "^{") > > + if (flags ~ "^\{") > > { > > - sub ("^{", "", flags) > > + sub ("^\{", "", flags) > > sub("}\\).*", "", flags) > > You need to esca

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-06 Thread Alexandre Oliva
On Jan 2, 2013, Richard Biener wrote: > On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva wrote: >> On Dec 21, 2012, Richard Biener wrote: >> >>> On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva wrote: libmudflap emits a global initializer that registers memory ranges for global dat

Re: [Patch, Fortran] PR55758 - Non-C_Bool handling with BIND(C)

2013-01-06 Thread Steve Kargl
On Sun, Jan 06, 2013 at 05:52:23PM +0100, Tobias Burnus wrote: > > PS: If there is consensus that this patch is a bad idea, I propose to > reject non-C_BOOL LOGICALs unconditionally as dummy argument or result > variable of BIND(C) procedures. Or do you have a better suggestion? > IMHO, I thin

Re: RFA: Add missing copyright holders

2013-01-06 Thread Ian Lance Taylor
On Sun, Jan 6, 2013 at 3:50 AM, Richard Sandiford wrote: > I noticed three files are missing a copyright holder. Since claims of > copyright ownership never feel obvious: OK to install? > > Richard > > > gcc/ > * file-find.c, file-find.h, realmpfr.c: Add FSF as copyright holder. This is

Re: [Bug bootstrap/53607] opt-functions.awk --> "awk: There is a regular expression error."

2013-01-06 Thread Andreas Schwab
"Daniel Richard G." writes: > Index: gcc/opt-functions.awk > === > --- gcc/opt-functions.awk (revision 194916) > +++ gcc/opt-functions.awk (working copy) > @@ -62,9 +62,9 @@ > if (flags !~ " " name "\\(") >

Re: [PATCH] Adding target rdos to GCC

2013-01-06 Thread Leif Ekblad
Updated patches with the suggestions below, except that the initial value is 0 (which is not meaningful). I also added a setting in rdos target file to use r15 for PIC instead of rbx. New change log: * config/gthr.m4: Added rdos thread header. * gcc/config/i386/i386.c: Provided a way to define

Re: [Patch, Fortran] PR55758 - Non-C_Bool handling with BIND(C)

2013-01-06 Thread Tobias Burnus
** ping ** Attached is a small variation, which in addition handles the case that a non-BOOL_C LOGICAL, Bind(C) dummy argument (or result variable) is used in a procedure call. In that case, the variable is now converted to a TYPE_PRECISION == 1 variable. -- The updated patch was build and re

Re: [Bug bootstrap/53607] opt-functions.awk --> "awk: There is a regular expression error."

2013-01-06 Thread Daniel Richard G.
This patch addresses a build failure on HP-UX due to the vendor awk(1) apparently treating a lone curly-brace as an incomplete repetition operator: [...] awk -f /home/src/gcc-4.7.2/gcc/opt-functions.awk -f /home/src/gcc-4.7.2/gcc/opt-read.awk \ -f /home/src/gcc-4.7.2/gcc/opth-gen.aw

Re: [PATCH, dataflow]: Fix PR55845, 454.calculix miscompares on x86 AVX due to movement of vzeroupper

2013-01-06 Thread Eric Botcazou
> BTW, can't UNSPEC_VOLATILE be embedded deeply in the pattern? > So volatile_insn_p (insn) && asm_noperands (PATTERN (insn)) == -1? > But perhaps you want to treat that way only UNSPEC_VOLATILE directly in the > pattern and all other UNSPEC_VOLATILE insns must describe in detail what > exactly the

Re: [patch, Fortran] PR 55806 - Inefficient ANY with array constructors

2013-01-06 Thread Thomas Koenig
Ping? http://gcc.gnu.org/ml/fortran/2013-01/msg0.html Hello world, the attached patch replaces ANY(a, b, c) with a .or. b .or c, leading to reduced execution time. It also handles ALL, PRODUCT and SUM. This fixes a bug noted by Michael Metcalf. Regression-tested. OK for trunk?

Re: [PATCH, dataflow]: Fix PR55845, 454.calculix miscompares on x86 AVX due to movement of vzeroupper

2013-01-06 Thread Jakub Jelinek
On Sun, Jan 06, 2013 at 04:48:03PM +0100, Uros Bizjak wrote: > --- df-problems.c (revision 194945) > +++ df-problems.c (working copy) > @@ -3916,6 +3916,10 @@ can_move_insns_across (rtx from, rtx to, rtx acros > break; >if (NONDEBUG_INSN_P (insn)) > { > + /* Do not

Re: [Patch, fortran] PR fortran/42769 typebound call resolved incorrectly.

2013-01-06 Thread Mikael Morin
Le 06/01/2013 13:06, Thomas Koenig a écrit : Am 06.01.2013 12:45, schrieb Janus Weil: I think your patch is indeed ok for trunk. Thanks, applied as revision 194949. 4.7? 4.6? Since it's not a regression, it does not necessarily need to be backported. However, the sort of wrong-code behavior

[PATCH, dataflow]: Fix PR55845, 454.calculix miscompares on x86 AVX due to movement of vzeroupper

2013-01-06 Thread Uros Bizjak
Hello! Attached patch fixes runtime comparison failure of 454.calculix due to wrong movement of vzeroupper in jump2 pass. It turns out, that can_move_insns_accross function does not special-case unspec_volatiles, so vzeroupper is allowed to pass various 256bit avx instructions. The patch rejects

[Patch, Fortran] PR55763 - reject "type is(INTEGER)" with non-class(*) selector in SELECT TYPE

2013-01-06 Thread Tobias Burnus
A rather obvious fix, though one can think about the error wording. Bootstrapped and regtested on x86-64-gnu-linux. OK for the trunk? Tobias 2012-01-06 Tobias Burnus PR fortran/55763 * resolve.c (resolve_select_type): Reject intrinsic types for a non-unlimited-polymorphic selector. 2012-

Re: [Patch, Fortran] PR55763 - improve init-data checks for pointers

2013-01-06 Thread Tobias Burnus
Early * ping* http://gcc.gnu.org/ml/fortran/2013-01/msg00025.html On January 4, 2013, Tobias Burnus wrote: Fortran 2008 allows: integer :: pointer => init_data and type t integer :: pointer => init_data end type t The current check in gfc_check_assign_symbol was only called for fo

Re: [Patch, fortran] Fix PR53876 (regression), PR55990 (regression) and PR55992

2013-01-06 Thread Tobias Burnus
Paul Richard Thomas wrote: Boostratpped and regtested on FC17/x86_64 - OK for trunk? OK - with the below nits fixed. Thanks for the patch. PR fortran/PR53876 PR fortran/PR55990 PR fortran/PR55992 Change 55* into 54*. PR fortran/PR53876 PR fortran/PR55990 P

Re: [committed, libstdc++] Fix a couple of copyright typos

2013-01-06 Thread Paolo Carlini
>As per the subject, although I'd love to hear about this imaginary >2010. :-) Well, in physics imaginary time is a pretty useful abstraction, eg, you can easily switch between statistical mechanics and quantum field theory in interesting calculations :-) Paolo

[Patch, fortran] Fix PR53876 (regression), PR55990 (regression) and PR55992

2013-01-06 Thread Paul Richard Thomas
Dear All, These PRs all have a similar or identical cause. GFC_CLASS_TYPE_P was not being set and/or pointer references were not being cast correctly. The fundamental fix is in trans_types.c(gfc_get_derived_type), where the flag is now explicitly set for field_type, thereby ensuring that no matte

[Patch, Fortran, committed] PR54678 - don't use an uninitialized variable

2013-01-06 Thread Tobias Burnus
Committed as obvious (Rev. 194948) - with Thomas' approval in the PR. Tobias Index: libgfortran/ChangeLog === --- libgfortran/ChangeLog (Revision 194947) +++ libgfortran/ChangeLog (Arbeitskopie) @@ -1,3 +1,9 @@ +2013-01-06 Tobias Bu

Re: [committed] 2011 and 2012 Copyright year updates

2013-01-06 Thread Jakub Jelinek
On Sun, Jan 06, 2013 at 12:13:32PM +, Richard Sandiford wrote: > I never remember to update the copyright years, so I thought I'd have a go. > And you were right of course. It ended up being a huge time sink. > > Anyway, here's my attempt a script to convert to ranges and, if enabled, > to in

Re: [Ada] Remove dead code in elaborate_entity

2013-01-06 Thread Eric Botcazou
> Tested on x86_64-suse-linux, applied on mainline and 4.7 branch. Pasto: applied on mainline only. -- Eric Botcazou

[Ada] Refine diagnostics on size or position mistakes in component rep clause

2013-01-06 Thread Eric Botcazou
Atomic or Volatile components must occupy their "natural" size and position in records, with allocated room and alignment matching what the component type calls for in absence of a rep clause for the component. There was a dissimetry in the gigi code checking for this, with - the checks on positio

[Ada] Remove dead code in elaborate_entity

2013-01-06 Thread Eric Botcazou
Tested on x86_64-suse-linux, applied on mainline and 4.7 branch. 2013-01-06 Eric Botcazou * gcc-interface/decl.c (elaborate_entity) : Delete. -- Eric BotcazouIndex: gcc-interface/decl.c === --- gcc-interface/decl.c (re

Re: [Patch, fortran] PR fortran/42769 typebound call resolved incorrectly.

2013-01-06 Thread Thomas Koenig
Am 06.01.2013 12:45, schrieb Janus Weil: Since it's not a regression, it does not necessarily need to be backported. However, the sort of wrong-code behavior seen in comment #24 is severe enough that it might justify backporting. I leave that up to you. FWITW, I think it should be backported to

[Ada] Fix layout of misaligned integer subtypes on big-endian

2013-01-06 Thread Eric Botcazou
This is a regression present on mainline and 4.7 branch, exposed by a recent change in the propagation of alignment from types to subtypes. The layout of misaligned integer subtypes is incorrect on big-endian platforms (it is left justified instead of being right justified). Fixed thusly, test

[committed, libstdc++] Fix a couple of copyright typos

2013-01-06 Thread Richard Sandiford
As per the subject, although I'd love to hear about this imaginary 2010. :-) Committed as obvious. Richard libstdc++-v3/ * include/ext/pb_ds/detail/splay_tree_/insert_fn_imps.hpp: Fix typo in copyright years. * testsuite/22_locale/time_get/get_weekday/wchar_t/3.cc: Likew

RFA: Add missing copyright holders

2013-01-06 Thread Richard Sandiford
I noticed three files are missing a copyright holder. Since claims of copyright ownership never feel obvious: OK to install? Richard gcc/ * file-find.c, file-find.h, realmpfr.c: Add FSF as copyright holder. Index: gcc/file-find.c

Tweak config/tilepro/gen-mul-tables.cc copyright

2013-01-06 Thread Richard Sandiford
As minor as minor can be, but: put the config/tilepro/gen-mul-tables.cc copyright on a single line so that scripts can more easily update the printf() line. This is a trivial change, so I don't think 2013 needs to be added. Committed as obvious (I hope). Richard gcc/ * config/tilepro/g

Re: [Patch, fortran] PR fortran/42769 typebound call resolved incorrectly.

2013-01-06 Thread Janus Weil
Hi Mikael, > here is a fix for PR42769, where a type bound call was resolved statically > into a normal procedure call, but using the local procedure (with the same > name) instead of the original (and correct) one. > It turned out to not be OOP specific, and be a pure module loading problem > in

[Ada] Fix glitch in -gnatR output

2013-01-06 Thread Eric Botcazou
When the discriminant of a record type comes from a parent type, the size of the type isn't properly displayed in the -gnatR output. Fixed thusly, tested on x86_64-suse-linux, applied on mainline. 2013-01-06 Eric Botcazou * gcc-interface/decl.c (annotate_value) : Be prepared

Re: [cxx-conversion] Change uses of htab_t in gcc/config to hash_table.

2013-01-06 Thread Richard Biener
On Sun, Jan 6, 2013 at 6:55 AM, Xinliang David Li wrote: > I noticed that the traverse and traverse_noresize method takes > Argument as the first template parameter. It should be moved to be the > second after the callback. In most of the cases, the type of the > Argument can be deduced from the c

Re: [Patch, libfortran] Improve performance of byte swapped IO

2013-01-06 Thread Richard Biener
On Sat, Jan 5, 2013 at 10:13 PM, Janne Blomqvist wrote: > On Sat, Jan 5, 2013 at 5:35 PM, Richard Biener > wrote: >> On Fri, Jan 4, 2013 at 11:35 PM, Andreas Schwab >> wrote: >>> Janne Blomqvist writes: >>> diff --git a/libgfortran/io/file_pos.c b/libgfortran/io/file_pos.c index c8ec