Re: [PATCH] PR55679: skip invalid tests from r194458 on darwin

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 08:21:49PM -0500, Jack Howarth wrote: > 2012-12-13 Jack Howarth > > PR 55679/sanitizer PR sanitizer/55679 instead > * g++.dg/asan/interception-test-1.C: Skip on darwin. This I can live with. > --- gcc/testsuite/c-c++-common/asan/swapcontext-test-1.c (

Re: [PATCH] Fix LTO binary size increases (PR gcov-profile/55674) (issue6946049)

2012-12-13 Thread Jan Hubicka
> 2012-12-13 Teresa Johnson > > PR gcov-profile/55674 > * lto-cgraph.c (merge_profile_summaries): Set min correctly the > first time we merge into a histogram entry. OK, thanks! Honza

RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-12-13 Thread Joey Ye
> -Original Message- > From: H.J. Lu [mailto:hjl.to...@gmail.com] > Sent: Friday, December 14, 2012 11:55 > To: Joey Ye > Cc: gcc-patches@gcc.gnu.org; Joseph Prostko > Subject: Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c > > > 2012-12-12 Joey Ye > > > > * configu

[PATCH] Fix LTO binary size increases (PR gcov-profile/55674) (issue6946049)

2012-12-13 Thread Teresa Johnson
2012-12-13 Teresa Johnson PR gcov-profile/55674 * lto-cgraph.c (merge_profile_summaries): Set min correctly the first time we merge into a histogram entry. Index: lto-cgraph.c === --- lto-cgraph.c(r

Re: [PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Teresa Johnson
On Thu, Dec 13, 2012 at 8:58 PM, Xinliang David Li wrote: > A couple of comments: > > 1) please dump with source location if possible. What is the use of > the information if there is no line number The google branches have the code to identify a source location of the loop, and a similar message

[PATCH][Cilkplus] Fix pragma simd info being lost

2012-12-13 Thread Iyer, Balaji V
Hello Everyone, This patch is for the Cilk Plus branch mainly affecting both C and C++ compilers. Some of the pragma simd structure's indices were getting lost and this patch will restore them. It will also insert the appropriate error messages when assert (in pragma simd) is requested i

Re: [PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Xinliang David Li
A couple of comments: 1) please dump with source location if possible. What is the use of the information if there is no line number 2) Please do not use the existing dump report -- Loop 1,2,3 etc means nothing to user 3) The optimization report should be standardized with some template (similar t

Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-12-13 Thread H.J. Lu
On Thu, Dec 13, 2012 at 7:39 PM, Joey Ye wrote: >> -Original Message- >> From: H.J. Lu [mailto:hjl.to...@gmail.com] >> Sent: Tuesday, November 27, 2012 12:56 >> To: Joey Ye >> Cc: gcc-patches@gcc.gnu.org >> Subject: Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c >> >> > >>

RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-12-13 Thread Joey Ye
> -Original Message- > From: H.J. Lu [mailto:hjl.to...@gmail.com] > Sent: Tuesday, November 27, 2012 12:56 > To: Joey Ye > Cc: gcc-patches@gcc.gnu.org > Subject: Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c > >> > > >> > OK to trunk? > >> > > >> > 2012-09-21 Joey Ye > >

[PATCH] Use new dump scheme for loop unroll passes

2012-12-13 Thread Sharad Singhai
Hi, As per discussion in http://gcc.gnu.org/ml/gcc/2012-12/msg00056.html, the attached patch updates loop unroll passes to use new dump infrastructure. This patch filters relevant dump messages into the following three categories - optimized: an optimization was successfully applied - missed: an

[PATCH] PR55679: skip invalid tests from r194458 on darwin

2012-12-13 Thread Jack Howarth
The attached patch disables two asan tests introduced in r194458 which are invalid on darwin. The g++.dg/asan/interception-test-1.C test is invalid on darwin since mac function interposition is used instead of interception. The c-c++-common/asan/swapcontext-test-1.c test is invalid as uconte

[patch] don't allocate/free unused pointer set in verify_cgraph_node

2012-12-13 Thread Steven Bosscher
Hello, Looks like a remnant from pre GIMPLE tuples days. Will commit as obvious. Ciao! Steven * cgraph.c (verify_cgraph_node): Don't allocate/free visited_nodes set. Index: cgraph.c === --- cgraph.c(revision 194491) ++

Go patch committed: Accept trailing comma after varargs parameter

2012-12-13 Thread Ian Lance Taylor
This patch to the Go compiler fixes it to accept a trailing comma after a varargs parameter, as required by the language spec. Testing that uncovered a couple of other related bugs: the compiler was not seeing interface types that appeared only in a function or method declaration, as in func (t *

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread Jan Hubicka
> > me libc starts to be win only for rather large blocks (i.e. >8KB) > > > > Which glibc are you using? 2.15 as it comes with opensuse 12.2 Honza > > -- > H.J.

[v3] Fix management of non empty hash functor

2012-12-13 Thread François Dumont
Hi As part of a performance patch proposed in an other mailing thread was a patch to improve management of hash functor with state. This part is I think less sensible than the performance patch so I propose it independently. I only would like to commit the modification on the performance

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread H.J. Lu
On Thu, Dec 13, 2012 at 12:40 PM, Jan Hubicka wrote: >> > Here we speak about memcpy/memset only. I never got around to modernize >> > strlen and friends, unfortunately... >> > >> > memcmp and friends are different beats. They realy need some TLC... >> >> memcpy and memset in glibc are also extr

Re: [PATCH, AArch64] Make zero_extends explicit for common SImode patterns

2012-12-13 Thread Richard Henderson
On 12/13/2012 09:25 AM, Ian Bolton wrote: > This patch significantly reduces the number of redundant > uxtw instructions seen in a variety of programs. > > (There are further patterns that can be done, but I have them > in a separate patch that's still in development.) What do you get if you enab

[lra] patch to fix almost all new GCC testsuite regressions on PPC64

2012-12-13 Thread Vladimir Makarov
The following patch fixes most GCC testsuite regressions on PPC64 for LRA (now there are only 2 failed tests in comparison with reload. the tests expect a specific assembler code and LRA generates a bit different code). The patch also adds a parameter can be used to form EBB in which inherit

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread Jan Hubicka
> > Here we speak about memcpy/memset only. I never got around to modernize > > strlen and friends, unfortunately... > > > > memcmp and friends are different beats. They realy need some TLC... > > memcpy and memset in glibc are also extremely fast. The default strategy now is to inline only whe

Re: [PATCH, AArch64] Make zero_extends explicit for common SImode patterns

2012-12-13 Thread Richard Henderson
On 12/13/2012 09:25 AM, Ian Bolton wrote: > + "add\\t%w0, %w2, %w, xt" ^^^ %w1 r~

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread H.J. Lu
On Thu, Dec 13, 2012 at 12:26 PM, Jan Hubicka wrote: >> On Wed, Dec 12, 2012 at 10:21 PM, Jakub Jelinek wrote: >> > On Wed, Dec 12, 2012 at 10:09:14PM -0800, Xinliang David Li wrote: >> >> On Wed, Dec 12, 2012 at 5:19 PM, Jan Hubicka wrote: >> >> >> > libcall is not faster up to 8KB to rep seque

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread Jan Hubicka
> On Wed, Dec 12, 2012 at 10:21 PM, Jakub Jelinek wrote: > > On Wed, Dec 12, 2012 at 10:09:14PM -0800, Xinliang David Li wrote: > >> On Wed, Dec 12, 2012 at 5:19 PM, Jan Hubicka wrote: > >> >> > libcall is not faster up to 8KB to rep sequence that is better for > >> >> > regalloc/code > >> >> >

Re: [patch, libstdc++ testsuite] Shrink tests for simulator

2012-12-13 Thread Steve Ellcey
On Thu, 2012-12-13 at 20:27 +0100, Paolo Carlini wrote: > It's the same approach that we are following in many other places, right? Yes, it is the same approach. > > OK to checkin? > Yes, thanks. Done. Steve Ellcey sell...@mips.com

Re: [alpha] Fix dwarf2 call-arg-location ICE

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 11:37:24AM -0800, Richard Henderson wrote: > Here's me wishing that NOTE_INSN_CALL_ARG_LOCATION was a reg note > and not an insn note. Mainly because it's required to be adjacent > to the call insn, modulo barriers apparently. It can be changed (though I guess for 4.9?).

Re: [cxx-conversion] Convert tree-sra.c'candidates to hash_table

2012-12-13 Thread Martin Jambor
Hi, On Thu, Dec 13, 2012 at 11:05:49AM -0800, Lawrence Crowl wrote: > On 12/12/12, Jakub Jelinek wrote: > > On Tue, Dec 11, 2012 at 02:44:41PM -0800, Lawrence Crowl wrote: > > > +/* Hash a tree in a uid_decl_map. */ > > > + > > > +inline hashval_t > > > +uid_decl_hasher::hash (const value_type *

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread H.J. Lu
On Wed, Dec 12, 2012 at 10:21 PM, Jakub Jelinek wrote: > On Wed, Dec 12, 2012 at 10:09:14PM -0800, Xinliang David Li wrote: >> On Wed, Dec 12, 2012 at 5:19 PM, Jan Hubicka wrote: >> >> > libcall is not faster up to 8KB to rep sequence that is better for >> >> > regalloc/code >> >> > cache than f

[alpha] Fix dwarf2 call-arg-location ICE

2012-12-13 Thread Richard Henderson
Here's me wishing that NOTE_INSN_CALL_ARG_LOCATION was a reg note and not an insn note. Mainly because it's required to be adjacent to the call insn, modulo barriers apparently. This just started failing recently, though I didn't check to see what sort of other change might have precipitated this

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Jan Hubicka
> > Honza, I think the pass manager should call default_rtl_profile () before > > each > > RTL pass to avoid this, no? > > Please note that we have plenty of existing peephole2s that use > optimize_insn_for_speed_p predicate. It is assumed to work ... It is set by peep2 pass static void peephole

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Jan Hubicka
> On Wed, Dec 12, 2012 at 7:32 PM, Uros Bizjak wrote: > > On Wed, Dec 12, 2012 at 3:45 PM, Richard Biener > > wrote: > > > >>> I assume that this is not right way for fixing such simple performance > >>> anomaly since we need to do redundant work - combine load to > >>> conditional and then split

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread Jan Hubicka
> Try the following one. 1) -minline-all-stringops > -mstringop-strategy=rep_8byte -O2 vs 1) -mstringop_strategy=libcall > -O2. > > David > > > #include > #include > #include > #ifndef LEN > #define LEN 16 > #endif > > void copy(char* s1, char* s2,int len) __attribute__((noinline)); > void c

Re: [patch, libstdc++ testsuite] Shrink tests for simulator

2012-12-13 Thread Paolo Carlini
Hi, On 12/13/2012 07:42 PM, Steve Ellcey wrote: I have been running the libstdc++ testsuite using the gnu simulator for my mips-mti-elf target. Some of the tests fail due to the amount of memory they need and I would like to 'shrink' them when run on a simulator using the same technique I see o

Re: [cxx-conversion] Convert tree-sra.c'candidates to hash_table

2012-12-13 Thread Lawrence Crowl
On 12/12/12, Jakub Jelinek wrote: > On Tue, Dec 11, 2012 at 02:44:41PM -0800, Lawrence Crowl wrote: > > +/* Hash a tree in a uid_decl_map. */ > > + > > +inline hashval_t > > +uid_decl_hasher::hash (const value_type *item) > > +{ > > + return item->decl_minimal.uid; > > Ugh, why aren't you using

[google/gcc-4_7-mobile] Adding current test failures to dejagnu baseline

2012-12-13 Thread 沈涵
Hi Ahmad and Luis, I'd like you to do a code review. Temporarily adds below failures to baseline. Needs to be removed after a thorough analysis/fix. Patch below - --- /dev/null 2012-11-30 16:08:50.372341021 -0800 +++ contrib/testsuite-management/i686-pc-linux-gnu 2012-12-13 10:30:39.496677271 -0

[patch, libstdc++ testsuite] Shrink tests for simulator

2012-12-13 Thread Steve Ellcey
I have been running the libstdc++ testsuite using the gnu simulator for my mips-mti-elf target. Some of the tests fail due to the amount of memory they need and I would like to 'shrink' them when run on a simulator using the same technique I see other tests using. These four tests aren't the on

[PATCH, AArch64] Make zero_extends explicit for common SImode patterns

2012-12-13 Thread Ian Bolton
Season's greetings to you! :) I've made zero_extend versions of SI mode patterns that write to W registers in order to make the implicit zero_extend that they do explicit, so GCC can be smarter about when it actually needs to plant a zero_extend (uxtw). This patch significantly reduces the number

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Uros Bizjak
On Thu, Dec 13, 2012 at 4:02 PM, Yuri Rumyantsev wrote: > We did not see any performance improvement on Atom in 32-bit mode at > routelookup from eembc_2_0 (eembc_1_1). I assume that for x86_64 the patch works as expected. Let's take a bigger hammer for 32bit targets - the splitter that effectiv

PING^2: [PATCH] Support -fuse-ld=bfd and -fuse-ld=gold

2012-12-13 Thread H.J. Lu
On Fri, Dec 7, 2012 at 5:15 AM, H.J. Lu wrote: > On Wed, Nov 28, 2012 at 8:18 PM, H.J. Lu wrote: >> >> Binutils supports 2 linkers, ld.gold and ld.bfd. One of them is >> configured as the default linker, ld, which is used by GCC. Sometimes, >> we want to use the alternate linker with GCC at run

[PING^2, PATCH, ARM] Improved core -> NEON extend

2012-12-13 Thread Ulrich Weigand
> http://gcc.gnu.org/ml/gcc-patches/2012-11/msg00984.html > Ping. -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE ulrich.weig...@de.ibm.com

Re: [PATCH] Enable non-complex math builtins from C99 for Bionic

2012-12-13 Thread Alexander Ivchenko
Hello! Could you please take a look at the attached patch that implements the target libc_has_function hook? I didn't change so far the default presence of c99, but rather tried to preserve the current behaviour of TARGET_C99_FUNCTIONS. Thank you, Alexander 2012/12/1 Joseph S. Myers : > On Fri,

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 02:22:52PM +0400, Konstantin Serebryany wrote: > I've added two flags, both on by default for now. > > // Use fast (frame-pointer-based) unwinder on fatal errors (if available). > bool fast_unwind_on_fatal; > // Use fast (frame-pointer-based) unwinder on malloc/free (

[PATCH] Fix PR53476

2012-12-13 Thread Richard Biener
This fixes the weak alias regression FAIL: gcc.dg/attr-weakref-1.c. I tracked it down to the fact that this has both DECL_EXTERNAL and TREE_STATIC (and RTL) set but the trunk code differs from the 4.7 code in that it has an additional !DECL_EXTERNAL check (for no apparent reason, that is, no testc

Re: [PATCH] validate_failures.py: Fix performance regression

2012-12-13 Thread Bernhard Reutner-Fischer
On Fri, Dec 07, 2012 at 10:31:57AM -0500, Diego Novillo wrote: >On Thu, Dec 6, 2012 at 1:12 PM, Bernhard Reutner-Fischer > wrote: @@ -210,12 +211,12 @@ def IsInterestingResult(line): if '|' in line: (_, line) = line.split('|', 1) line = line.strip() - return any(line.startswith(resul

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Yuri Rumyantsev
Uros, We did not see any performance improvement on Atom in 32-bit mode at routelookup from eembc_2_0 (eembc_1_1). Best regards. Yuri. 2012/12/13 Uros Bizjak : > On Thu, Dec 13, 2012 at 3:27 PM, Uros Bizjak wrote: > >>> The patch proposed by Uros is useless since we don't have free scratch >>>

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Uros Bizjak
On Thu, Dec 13, 2012 at 3:27 PM, Uros Bizjak wrote: >> The patch proposed by Uros is useless since we don't have free scratch >> register to do splitting of memory operand: >> >> ;; regs ever live 0[ax] 1[dx] 2[cx] 3[bx] 4[si] 5[di] 6[bp] 7[sp] >> 17[flags] >> >> ... >> >> (insn 96 131 13

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Richard Biener
On Thu, Dec 13, 2012 at 3:23 PM, Yuri Rumyantsev wrote: > Hi Guys, > > The patch proposed by Uros is useless since we don't have free scratch > register to do splitting of memory operand: > > ;; regs ever live 0[ax] 1[dx] 2[cx] 3[bx] 4[si] 5[di] 6[bp] 7[sp] > 17[flags] > > ... > > (insn 96

Re: [PATCH][ARM] Add copyright notice to unspecs.md

2012-12-13 Thread Ramana Radhakrishnan
On 12/13/12 14:26, Kyrylo Tkachov wrote: Hi all, This patch adds a copyright notice to the recently added unspecs.md file in the arm backend (r193204). The file just gathered some unspecs definitions into one place. Ok for trunk? Ouch - my (real) bad at having missed this in the review. Plea

Re: [C++ PATCH] Fix ICE in merge_exception_specifiers (PR c++/55652)

2012-12-13 Thread Jason Merrill
OK. Jason

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Uros Bizjak
On Thu, Dec 13, 2012 at 3:23 PM, Yuri Rumyantsev wrote: > The patch proposed by Uros is useless since we don't have free scratch > register to do splitting of memory operand: > > ;; regs ever live 0[ax] 1[dx] 2[cx] 3[bx] 4[si] 5[di] 6[bp] 7[sp] > 17[flags] > > ... > > (insn 96 131 132 7 (

[PATCH][ARM] Add copyright notice to unspecs.md

2012-12-13 Thread Kyrylo Tkachov
Hi all, This patch adds a copyright notice to the recently added unspecs.md file in the arm backend (r193204). The file just gathered some unspecs definitions into one place. Ok for trunk? Thanks, Kyrill gcc/ChangeLog 2012-12-13 Kyrylo Tkachov * config/arm/unspecs.md: Add copyright

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Yuri Rumyantsev
Hi Guys, The patch proposed by Uros is useless since we don't have free scratch register to do splitting of memory operand: ;; regs ever live 0[ax] 1[dx] 2[cx] 3[bx] 4[si] 5[di] 6[bp] 7[sp] 17[flags] ... (insn 96 131 132 7 (set (reg/v/f:SI 6 bp [orig:70 trie_root ] [70]) (if_the

Re: [PATCH] Avoid -Wsign-compare warning

2012-12-13 Thread Richard Biener
On Thu, Dec 13, 2012 at 1:45 PM, Jakub Jelinek wrote: > Hi! > > I keep seeing a -Wsign-compare warning from GCC 4.7 here, > alloc_count is const int = 16, but length () method returns unsigned. > Perhaps GCC 4.8 folds it to 16 early enough for the -Wsign-compare warning > (might be related to the

[PATCH] Avoid -Wsign-compare warning

2012-12-13 Thread Jakub Jelinek
Hi! I keep seeing a -Wsign-compare warning from GCC 4.7 here, alloc_count is const int = 16, but length () method returns unsigned. Perhaps GCC 4.8 folds it to 16 early enough for the -Wsign-compare warning (might be related to the sizeof changes), but still I think it doesn't hurt to fix this up.

[PATCH] Use *Q instead of *L floating constants in libquadmath

2012-12-13 Thread Jakub Jelinek
Hi! I've noticed ../../../libquadmath/math/fmaq.c:83:4: warning: floating constant truncated to zero [-Woverflow] warning and a quick grep revealed a bunch of other bugs, mostly introduced during the recent ports from newer glibc. Built on x86_64-linux, committed to trunk. 2012-12-13 Jakub Jel

Re: [patch c/c++]: Fix for PR c/52991 issue about ignored packed-attribute for ms-structure-layout

2012-12-13 Thread Richard Biener
On Thu, Dec 13, 2012 at 1:02 PM, Kai Tietz wrote: > 2012/12/13 Jakub Jelinek : >> On Thu, Dec 13, 2012 at 11:29:47AM +0100, Richard Biener wrote: >>> On Thu, Dec 13, 2012 at 11:07 AM, Jakub Jelinek wrote: >>> > On Thu, Dec 13, 2012 at 11:03:58AM +0100, Richard Biener wrote: >>> >> struct X >>> >>

Re: [AArch64] Add support for TARGET_VECTORIZE_AUTOVECTORIZE_VECTOR_SIZES hook.

2012-12-13 Thread Marcus Shawcroft
On 06/12/12 15:09, James Greenhalgh wrote: Hi, This patch wires up TARGET_VECTORIZE_AUTOVECTORIZE_VECTOR_SIZES on AArch64 to allow for 64-bit or 128-bit vectorization if the preferred vector mode is not acceptable. The patch has been regression tested on aarch64-none-elf with no regressions.

Re: [PATCH, libgcc, ARM] __gnu_f2h_internal inaccuracy

2012-12-13 Thread nick clifton
Hi John, John Tytgat * config/arm/fp16.c (__gnu_f2h_internal): Fix inaccuracy. Approved and applied. Cheers Nick

Re: [patch c/c++]: Fix for PR c/52991 issue about ignored packed-attribute for ms-structure-layout

2012-12-13 Thread Kai Tietz
2012/12/13 Jakub Jelinek : > On Thu, Dec 13, 2012 at 11:29:47AM +0100, Richard Biener wrote: >> On Thu, Dec 13, 2012 at 11:07 AM, Jakub Jelinek wrote: >> > On Thu, Dec 13, 2012 at 11:03:58AM +0100, Richard Biener wrote: >> >> struct X >> >> { >> >> char c; >> >> short s; >> >> char c2; >> >>

*PING* RE: [AArch64] Add support for TARGET_VECTORIZE_AUTOVECTORIZE_VECTOR_SIZES hook.

2012-12-13 Thread James Greenhalgh
*ping* Thanks, James > -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of James Greenhalgh > Sent: 06 December 2012 15:10 > To: gcc-patches@gcc.gnu.org > Cc: Marcus Shawcroft > Subject: [AArch64] Add support for > TARGET_VECTORI

[PATCH] Fix PR55660

2012-12-13 Thread Richard Biener
This fixes PR55660 where a different setting of -f[un-]signed-char at compile vs. link-time lead to ICEs. This is because the not preloading of char_type_node isn't working on i?86 as char_type_node is reached via its va_list_type_node type (which is char *, not unsigned char * or signed char * a

Re: [patch c/c++]: Fix for PR c/52991 issue about ignored packed-attribute for ms-structure-layout

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 11:29:47AM +0100, Richard Biener wrote: > On Thu, Dec 13, 2012 at 11:07 AM, Jakub Jelinek wrote: > > On Thu, Dec 13, 2012 at 11:03:58AM +0100, Richard Biener wrote: > >> struct X > >> { > >> char c; > >> short s; > >> char c2; > >> short s2; > >> } __attribute__((pa

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Richard Biener
On Thu, Dec 13, 2012 at 11:20 AM, Uros Bizjak wrote: > On Thu, Dec 13, 2012 at 10:51 AM, Richard Biener > wrote: > > I assume that this is not right way for fixing such simple performance > anomaly since we need to do redundant work - combine load to > conditional and then split it ba

Re: [patch c/c++]: Fix for PR c/52991 issue about ignored packed-attribute for ms-structure-layout

2012-12-13 Thread Richard Biener
On Thu, Dec 13, 2012 at 11:07 AM, Jakub Jelinek wrote: > On Thu, Dec 13, 2012 at 11:03:58AM +0100, Richard Biener wrote: >> struct X >> { >> char c; >> short s; >> char c2; >> short s2; >> } __attribute__((packed,aligned(2))); > > As struct-layout-1.exp tests show, this is something that w

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-13 Thread Konstantin Serebryany
I've added two flags, both on by default for now. // Use fast (frame-pointer-based) unwinder on fatal errors (if available). bool fast_unwind_on_fatal; // Use fast (frame-pointer-based) unwinder on malloc/free (if available). bool fast_unwind_on_malloc; % clang -fsanitize=address -g ~/ll

Re: [PATCH i386]: Enable push/pop in pro/epilogue for modern CPUs

2012-12-13 Thread Richard Biener
On Thu, Dec 13, 2012 at 7:21 AM, Jakub Jelinek wrote: > On Wed, Dec 12, 2012 at 10:09:14PM -0800, Xinliang David Li wrote: >> On Wed, Dec 12, 2012 at 5:19 PM, Jan Hubicka wrote: >> >> > libcall is not faster up to 8KB to rep sequence that is better for >> >> > regalloc/code >> >> > cache than fu

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Uros Bizjak
On Thu, Dec 13, 2012 at 10:51 AM, Richard Biener wrote: I assume that this is not right way for fixing such simple performance anomaly since we need to do redundant work - combine load to conditional and then split it back in peephole2? Does it look reasonable? Why we should p

Re: [PATCH] DOT a function directly from a gdb session

2012-12-13 Thread Pedro Alves
On 12/12/2012 06:04 PM, Andi Kleen wrote: > Richard Biener writes: >> >> Probably not suitable for trunk because I use popen/pclose/fileno >> which I don't know whether they are available on all host platforms. > > Just add a ifdef HAVE_popen or somesuch around it? Better yet, use the pex routin

Re: [PATCH] Fix nonlocalized vars regression caused by vec changes (PR debug/55665)

2012-12-13 Thread Richard Biener
On Wed, Dec 12, 2012 at 8:58 PM, Jakub Jelinek wrote: > Hi! > > Before http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=193595 > aka the big vec.h changes, nonlocalized_list parameter to remap_decls > used to be **, but the changes changed it to *. That is a problem, > because then there is no di

Re: [patch c/c++]: Fix for PR c/52991 issue about ignored packed-attribute for ms-structure-layout

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 11:03:58AM +0100, Richard Biener wrote: > struct X > { > char c; > short s; > char c2; > short s2; > } __attribute__((packed,aligned(2))); As struct-layout-1.exp tests show, this is something that was ABI-wise changed already several times. That said, for non-ms-bi

Re: [PATCH] Fix extremely large LPBX arrays (PR gcov-profile/55650)

2012-12-13 Thread Richard Biener
On Wed, Dec 12, 2012 at 8:41 PM, Jakub Jelinek wrote: > Hi! > > On the attached testcase prg_ctr_mask is non-zero, presumably set > while there still were some functions in the TU, but later on none of them > are being emitted. This leads to n_functions in coverage_obj_finish being > 0, and the a

Re: [patch c/c++]: Fix for PR c/52991 issue about ignored packed-attribute for ms-structure-layout

2012-12-13 Thread Richard Biener
On Wed, Dec 12, 2012 at 5:23 PM, Kai Tietz wrote: > 2012/12/12 Richard Biener : >> On Wed, Dec 12, 2012 at 4:11 PM, Richard Henderson wrote: >>> On 12/12/2012 02:57 AM, Richard Biener wrote: That looks wrong. Having both TYPE_PACKED and TYPE_ALIGN != BITS_PER_UNIT is inconsistent, so t

Re: [PATCH,x86] Fix combine for condditional instructions.

2012-12-13 Thread Richard Biener
On Wed, Dec 12, 2012 at 7:32 PM, Uros Bizjak wrote: > On Wed, Dec 12, 2012 at 3:45 PM, Richard Biener > wrote: > >>> I assume that this is not right way for fixing such simple performance >>> anomaly since we need to do redundant work - combine load to >>> conditional and then split it back in pe

[PATCH] Add --param max-vartrack-reverse-op-size=N (PR debug/54402)

2012-12-13 Thread Jakub Jelinek
Hi! As the PR54402 go testcase shows, sometimes we end up with VALUEs with huge (many thousands) long locs lists because we add too many reverse ops for the same value. Such huge locs lists of equivalences are hardly useful in practice, reverse ops mainly help when there are just a few locs and m

Re: [patch] Make bitmap_head smaller again

2012-12-13 Thread Richard Biener
On Wed, Dec 12, 2012 at 6:43 PM, Steven Bosscher wrote: > Hello, > > This patch fixes a regression in the size of bitmap_head that resulted > from the removal of all the #ifdef GATHER_STATISTICS tests. > > Instead of a pointer to a descriptor, this patch gives each bitmap an > integer that is the

[PATCH] Do not leak SSA names in PRE

2012-12-13 Thread Richard Biener
When PRE creates representatives for expressions during PHI translation it never releases the SSA names again. The following patch arranges for SCCVN to release them. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. p3 Description: Binary data

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote: > On Wed, Dec 12, 2012 at 11:50 PM, Jakub Jelinek wrote: > > Various TM tests ICE when built with -fgnu-tm -fsanitizer=address. > > The problem is that asan.c pass adds calls to builtins that weren't there > > before and TM is upset ab

Re: [PATCH] asan unit tests from llvm lit-test incremental changes

2012-12-13 Thread Jakub Jelinek
On Thu, Dec 13, 2012 at 11:44:12AM +0400, Konstantin Serebryany wrote: > We are discussing it from time to time. > Sometimes, if e.g. an error happens inside a qsort callback, > the fp-based unwinder fails to unwind through libc, while _Unwind would work. > > I was opposed to this sometime ago bec