Re: another wrong-code problem with -fstrict-volatile-bitfields

A couple days ago I wrote: While I was grovelling around trying to swap in more state on the bitfield store/extract code for the patch rewrite being discussed here: http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01546.html I found a reference to PR23623 and found that it is broken again, but in

To-be-committed: correct out-of-tree .hidden support for mmix-knuth-mmixware

GCC configure should say that the linker does *not* support .hidden. For static-only linking (the only mode supported on this simulator-only system) this shouldn't really matter. But, different code is actually used (not just the attribute-hidden decorations), so different bugs are exposed. Like

[PATCH] Remove RS6000_CALL_GLUE

On all supported targets, plain "nop" is the correct thing to use ("cror 31,31,31" was for POWER). Tested on powerpc64-linux --enable-languages=c,c++,fortran; no regressions. Okay for mainline? Segher 2012-08-26 Segher Boessenkool gcc/ * config/rs6000/aix43.h (RS6000_CALL_GLUE): D

Re: [Patch, Fortran] Make -Wall no longer imply -Wcompare-reals

Hi Tobias, while -Wcompare-reals is a useful option to find bugs, practical experience and the discussion here and on c.l.f has shown that this option has too many false positives. Hence, it is not suitable for -Wall. With patch, -Wall no longer implies -Wcompare-reals. Build on x86-64-linu

To-be-committed: fix configure case when assembler COMDAT group support is lacking

If the out-of-tree target assembler supports neither: .section .text,"axG",@progbits,.foo,comdat (tsk tsk no leading space, though that's a red herring) nor: .section .text,"axG",%progbits,.foo,comdat then gcc/configure.ac drops through into the system-specific case seen in the patch, where for *-*

Re: [PATCH] Add sparc Niagara4 scheduling description and tweaks.

From: Gerald Pfeifer Date: Sun, 26 Aug 2012 23:34:54 +0200 (CEST) > Hi David, > > On Thu, 26 Apr 2012, David Miller wrote: >> * config/sparc/niagara4.md: New file. >> * config/sparc/sparc.md: Include it. >> * config/sparc/sparc.c (niagara4_costs): New processor costs. >> (spa

[Patch, Fortran] Make -Wall no longer imply -Wcompare-reals

Dear all, while -Wcompare-reals is a useful option to find bugs, practical experience and the discussion here and on c.l.f has shown that this option has too many false positives. Hence, it is not suitable for -Wall. With patch, -Wall no longer implies -Wcompare-reals. Build on x86-64-linux.

Re: [PATCH] Add sparc Niagara4 scheduling description and tweaks.

Hi David, On Thu, 26 Apr 2012, David Miller wrote: > * config/sparc/niagara4.md: New file. > * config/sparc/sparc.md: Include it. > * config/sparc/sparc.c (niagara4_costs): New processor costs. > (sparc_option_override): Use it. > (sparc_use_sched_lookahead): Return 2

[PATCH,PING]] gcc/config/freebsd-spec.h: Fix building PIE

I have tested this patch on i386-unknown-freebsd10.0 and volunteer to create a ChangeLog and apply if approved. Any reviewer? On Tue, 8 May 2012, Alexis Ballier wrote: > For the record, there's a similar logic in FreeBSD's gcc: > http://svnweb.freebsd.org/base/head/contrib/gcc/config/freebsd-spe

Re: Patches to enable -ftrack-macro-expansion by default

On Sun, Aug 26, 2012 at 3:00 PM, Gerald Pfeifer wrote: > I have applied the following, updated patch. Thank you! -- Gaby

Re: Patches to enable -ftrack-macro-expansion by default

On Sun, 26 Aug 2012, Dodji Seketeli wrote: > Gabriel Dos Reis writes: >> I think we show the stack not just for errors, but for any diagnostics. > I agree, FWIW. Good point, thanks for the feedback! I have applied the following, updated patch. Gerald Index: changes.html ===

Committed, btest-gcc.sh: make fortran tests optional

Some targets, like mmix-knuth-mmixware, has fortran turned off. This patch has seen a large amount of testing, both for targets with fortran on and off. A similar patch in the past () made the libstdc++ tests optional, so I'm calling it obvi

[MIPS, committed] Use round-robin allocation of floating-point condition codes

This is the last patch (for today) brought about by the upcoming gcc.target/mips patch. It's also the one I'm least happy about. For MIPS IV and above, we've traditionally created CCmode pseudo registers for floating-point conditions but defined AVOID_CCMODE_COPIES to try to stop the optimizers f

[MIPS, committed] Fix handling of long branches with delay slots

Converting gcc.target/mips to gcc-dg showed up a brown-paper-bag bug in my long-branch code. The function that checks whether $gp is needed only for long branches runs (and must run) after delayed-branch scheduling, but it wasn't looking inside the SEQUENCEs. I also made the code check the same j

[MIPS, committed] Tweak r10k cache barrier code

r10k_safe_mem_expr_p couldn't cope with a MEM_REF of an ADDR_EXPR, which for some reason is produced for r10k-cache-barrier-8.c when compiled with -O2 -lto but not when compiled with just -O2. This function is still much too conservative, but I wanted to be safe for kernel code that plays clever t

[MIPS, committed] Fix cost of CINS

CINS wasn't being used in -Os code because the combination didn't seem profitable enough. Tested on mipsisa64-elf, mips64-elf and mips64-linux-gnu. Applied. Will be tested once gcc.target/mips uses gcc-dg. Richard gcc/ * config/mips/mips.c (mips_rtx_costs): Add costs for CINS. Index:

[MIPS, committed] Add missing COSTS_N_INSNS call.

I'm preparing a patch to turn gcc.target/mips into a torture-like testsuite. This showed up a fair few problems, the first of which is fixed below. The code that calculated the size cost of multiplications was missing a COSTS_N_INSNS call. Tested on mipsisa64-elf, mips64-elf and mips64-linux-gnu

[obvious] Make scan-assembler-times require code generation

scan-assembler and scan-assembler-not force -ffat-lto-objects, so that there'll always be some assembly code to scan. This patch extends that to scan-assembler-times. Tested on mipsisa64-elf, mips64-elf and mips64-linux-gnu. Applied as obvious. Richard gcc/testsuite/ * lib/scanasm.exp

[Committed] Fix libffi on mips64 with soft-float

Hi, The problem here was before FFI_ASSERT was turned off in 99% of the time so nobody noticed that soft-float ABIS would fail. When the FFI_ASSERT was converted over to return FFI_BAD_ABI instead, n32 and n64 soft-float abis started to fail. I committed the following patch as obvious after a b

Re: [Patch, Fortran] Plug memory leaks; fix tree-check ICE for PR

Tobias Burnus wrote: PS: I wonder why gfortran.dg/interface_3.f90 passed before, given that "proc_locus" wasn't set before. I also wonder why my patch causes the test case to segfault. Well, at least that bug is now also fixed. Answer: Because I am too strupid to read the patch after spendin

[Patch, Fortran] Plug memory leaks; fix tree-check ICE for PR

This patch fixes one ICE and several memory leaks. But there are more. * The patch with symbol.c and resolve.c fixes the following issue: gfortran leaks memory for: REAL FUNCTION GGL(ds) GGL = 16806.D0 END The problem is the following code in resolve_sym

Re: [wwwdocs] Update links to C++ ABI (was: at exit alternative for AIX)

On Sun, Aug 26, 2012 at 11:55 AM, Ian Lance Taylor wrote: > On Sun, Aug 26, 2012 at 3:43 AM, Gerald Pfeifer wrote: >> On Tue, 7 Aug 2012, Ian Lance Taylor wrote: >>> The official link at http://codesourcery.com/cxx-abi/ (note trailing >>> slash) still works. >> >> It used to be http://sourcery.me

Re: [PATCH, middle-end]: Introduce TARGET_LEGITIMATE_COMBINED_INSN target hook

On Sun, Aug 26, 2012 at 12:24 PM, Georg-Johann Lay wrote: > >> Actually a v3 of TARGET_REJECT_COMBINED_INSN target hook. >> >> Changes: >> - rename the hook and reverse the return value >> >> 2012-08-25 Uros Bizjak >> >> * target.def (legitimate_combined_insn): New target hook. >>

RE: [wwwdocs] Update links to C++ ABI

Gerald -- I think that the GitHub address is more canonical at this point, so I would recommend that. That said, I would expect the codesourcery.com address to work "forever"; Mentor IT has set up permanent redirects for addresses from that domain. Thank you, -- Mark Mitchell Mentor Graphics

Re: random numbers in bulk

On 26 August 2012 18:34, Jonathan Wakely wrote: > On 26 August 2012 18:19, Ulrich Drepper wrote: >> Also, I consider the interface clean and now very C++-y. Iterators >> are used and transparently all kinds of overloads are possible. Only >> the iterator variants need to be documented, making the

Re: random numbers in bulk

Hi, On 08/26/2012 07:19 PM, Ulrich Drepper wrote: On Sun, Aug 26, 2012 at 10:27 AM, Paolo Carlini wrote: Thus, all in all, for the time being I would go with __generate. OK, here's a version of the patch with the patch for 54376 already assumed. I changed to function name to __generate. I f

Re: random numbers in bulk

On 26 August 2012 18:19, Ulrich Drepper wrote: > Also, I consider the interface clean and now very C++-y. Iterators > are used and transparently all kinds of overloads are possible. Only > the iterator variants need to be documented, making the extensions > easy to use. The only minor complicati

Re: RFA: Add Epiphany port

On Fri, 4 Nov 2011, Joern Rennecke wrote: install.texi is a bit funny. sourcebuild.texi says to add configurations to the list in config.texi even if you have nothing to say about them. install.texi says you shouldn't do that. But after a while, it does do that for a number of newer ports. So

Re: Is libstdcxx-time still experimental?

On 26 August 2012 18:06, Jonathan Wakely wrote: > On Aug 26, 2012 4:17 PM, "H.J. Lu" wrote: >> >> Hi, >> >> According to >> >> http://gcc.gnu.org/ml/libstdc++/2010-04/msg00064.html >> >> One reason of --enable-libstdcxx-time=no on Linux is >> "not all users will want for an experimental c++0x mode.

Re: Is libstdcxx-time still experimental?

On Aug 26, 2012 4:17 PM, "H.J. Lu" wrote: > > Hi, > > According to > > http://gcc.gnu.org/ml/libstdc++/2010-04/msg00064.html > > One reason of --enable-libstdcxx-time=no on Linux is > "not all users will want for an experimental c++0x mode." > Is this feature still experimental today? See http://

Re: [wwwdocs] Update links to C++ ABI

On Sun, 26 Aug 2012, Ian Lance Taylor wrote: >> It used to be http://sourcery.mentor.com/public/cxx-abi/ as of lately, >> and now redirects to http://mentorembedded.github.com/cxx-abi/ . >> >> I went ahead and updated all our references per the patch below. > I don't think that is wise. The docume

Re: [wwwdocs] Update links to C++ ABI (was: at exit alternative for AIX)

On Sun, Aug 26, 2012 at 3:43 AM, Gerald Pfeifer wrote: > On Tue, 7 Aug 2012, Ian Lance Taylor wrote: >> The official link at http://codesourcery.com/cxx-abi/ (note trailing >> slash) still works. > > It used to be http://sourcery.mentor.com/public/cxx-abi/ as of lately, > and now redirects to http

[doc] Add missing space in invoke.texi

Applied to mainline; probably not worth it on release branches. Gerald 2012-08-26 Gerald Pfeifer * doc/invoke.texi (C++ Dialect Options): Add missing space. Index: doc/invoke.texi === --- doc/invoke.texi (revision 19

Is libstdcxx-time still experimental?

Hi, According to http://gcc.gnu.org/ml/libstdc++/2010-04/msg00064.html One reason of --enable-libstdcxx-time=no on Linux is "not all users will want for an experimental c++0x mode." Is this feature still experimental today? Thanks. -- H.J.

Re: [PATCH] OpenBSD/amd64 support and OpenBSD/i386 cleanup

On Sun, 1 Jan 2012, Mark Kettenis wrote: > The diff below adds support for OpenBSD/amd64 and cleans up the > OpenBSD/i386 configury bits such that they can be shared. The OpenBSD > ports people have maintained their own set of patches for these > targets, but this is a re-implementation from scrat

Re: random numbers in bulk

On Sun, Aug 26, 2012 at 10:04 AM, Daniel Krügler wrote: > The typedef "pointer" should be removed, because it is not used at all. That 'pointer' type is needed for the __normal_iterator use. Unfortunately.

Re: [v3] fix PR 54297 - segfaults with std::async

* testsuite/30_threads/async/54297.cc: Add dg-require-nanosleep. Fixed on trunk and 4.7 branch. --- a/libstdc++-v3/testsuite/30_threads/async/54297.cc +++ b/libstdc++-v3/testsuite/30_threads/async/54297.cc @@ -5,6 +5,7 @@ // { dg-require-cstdint "" } // { dg-require-gthreads "" } // {

Re: random numbers in bulk

2012/8/26 Paolo Carlini : > On 08/26/2012 04:04 PM, Daniel Krügler wrote: >> >> The function really should have a different name, as mentioned by others. >> I also agree with others that generate would be a better name than fill. > > Thus, all in all, for the time being I would go with __generate.

Re: [v3] fix PR 54297 - segfaults with std::async

On 26 August 2012 15:48, H.J. Lu wrote: > On Sun, Aug 26, 2012 at 7:00 AM, Jonathan Wakely > wrote: >> On 26 August 2012 00:02, Jonathan Wakely wrote: >>> This fixes a stupid mistake I made where the functor and asynchronous >>> result can go out of scope before the async thread is joined. >>> >

Re: [v3] fix PR 54297 - segfaults with std::async

On Sun, Aug 26, 2012 at 7:00 AM, Jonathan Wakely wrote: > On 26 August 2012 00:02, Jonathan Wakely wrote: >> This fixes a stupid mistake I made where the functor and asynchronous >> result can go out of scope before the async thread is joined. >> >> The _Async_state_common destructor still needs t

[RFA:] fix configury version checks for in-tree binutils

Found while investigating PR54373. A combined tree (in-tree binutils) using binutils post-2.22 is semi-broken at the moment: the version of the assembler and linker can't be found. The configury doesn't expect the single-quote that has "appeared"; i.e. VERSION=2.22.0 vs. VERSION='2.23.51' You

[PATCH] fix for PR53986 - missing vrp on bit-mask test, LSHIFT_EXPR not handled

Richard, this patch fixes PR53986. The patch calculates the range of an LSHIFT_EXPR in case both operands are constants ranges, and the operation is guaranteed not to overflow. F.i., it evaluates [1, 2] << [1, 8] to [2, 512]. Bootstrapped and reg-tested (ada inclusive) on x86_64. Ok for trunk?

Re: random numbers in bulk

On 08/26/2012 04:04 PM, Daniel Krügler wrote: The function really should have a different name, as mentioned by others. I also agree with others that generate would be a better name than fill. Thus, all in all, for the time being I would go with __generate. Paolo.

Re: random numbers in bulk

Hi, On 08/26/2012 04:04 PM, Daniel Krügler wrote: Personally I consider it as very unfortunate that an overload for pointers should be necessary here. To solve the specialization problem I'm in favour to provide free function templates instead (I also think that they should better get an initi

Re: random numbers in bulk

2012/8/26 Ulrich Drepper : > On Sun, Aug 26, 2012 at 7:20 AM, Ulrich Drepper wrote: >> What I could imagine working is that the iterator fill/generate_n >> functions are defined and in addition the special versions which use >> pointers of the result_type of the distribution. > > How about the fol

Re: [v3] fix PR 54297 - segfaults with std::async

On 26 August 2012 00:02, Jonathan Wakely wrote: > This fixes a stupid mistake I made where the functor and asynchronous > result can go out of scope before the async thread is joined. > > The _Async_state_common destructor still needs to be exported from the > library, which is what the macro hack

Re: [PATCH 2/2] mips: Add R4700 scheduling support

On Sun, 3 Jun 2012, Richard Sandiford wrote: >> The R4700 is identical to the R4600 except for the integer and >> floating-point multiplication costs. > Applied, thanks. > > Richard And I just added the snippet below to our release notes. Gerald Index: changes.html =

Re: PATCH: Don't set HOST_LIB_PATH_bfd/HOST_LIB_PATH_opcodes

On Sun, Aug 26, 2012 at 6:22 AM, Paolo Bonzini wrote: > Il 25/08/2012 17:58, H.J. Lu ha scritto: >> The change was introduced by >> >> http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg01452.html >> >> Paolo, do you remember the reason for this? > > Actually, this patch came before bfd started using libtoo

Re: random numbers in bulk

Adding Daniel's correct address (Daniel, the thread started at http://gcc.gnu.org/ml/gcc-patches/2012-08/msg01752.html) On 26 August 2012 14:38, Jonathan Wakely wrote: > On 26 August 2012 14:08, Ulrich Drepper wrote: >> >> If people agree this is acceptable and the consensus is that >> generate_n(

Re: random numbers in bulk

On 26 August 2012 14:08, Ulrich Drepper wrote: > > If people agree this is acceptable and the consensus is that > generate_n() is the better name I can submit a patch so that the > remaining work can be submitted. Still ways to go... Unless you're thinking of changing the interface to take a poi

Re: PATCH: Don't set HOST_LIB_PATH_bfd/HOST_LIB_PATH_opcodes

Il 25/08/2012 17:58, H.J. Lu ha scritto: > The change was introduced by > > http://gcc.gnu.org/ml/gcc-cvs/2005-03/msg01452.html > > Paolo, do you remember the reason for this? Actually, this patch came before bfd started using libtool and hence .libs. The patch is okay if binutils always uses l

Re: [PATCH] Intrinsics for RDSEED

Hi Kirill, On Mon, 30 Jul 2012, Kirill Yukhin wrote: > Checked into the trunk: http://gcc.gnu.org/ml/gcc-cvs/2012-07/msg00878.html are you going to document this (and others) in the GCC 4.8 release notes at http://gcc.gnu.org/gcc-4.8/changes.html ? That will be good. Gerald

Re: [PATCH] Small change for cloog.m4 configuration file

On 08/26/2012 02:20 PM, Gerald Pfeifer wrote: On Wed, 22 Aug 2012, Art Haas wrote: I've been having to make this small change to the 'configure' script when building on sparc-sun-solaris2.10 to accomodate the shell executing the script. Without the change, I get an error message like so: config

Re: [PATCH] Small change for cloog.m4 configuration file

On Wed, 22 Aug 2012, Art Haas wrote: > I've been having to make this small change to the 'configure' script > when building on sparc-sun-solaris2.10 to accomodate the shell executing > the script. Without the change, I get an error message like so: > > configure: test: unknown operator == Thanks

Re: [Patch, fortran] [0/5] PR 45586: restrict vs. non-restrict type compatibility hell

On 26/08/2012 13:23, Dominique Dhumieres wrote: > With the modified patch, gfortran.dg/restrict_type_compat_1.f90 fails > for a regular test: > > FAIL: gfortran.dg/restrict_type_compat_1.f90 -O scan-tree-dump-times > original "VIEW_CONVERT_EXPR" 13 > > A manual check shows only 6 instances of

Re: [Patch, fortran] [0/5] PR 45586: restrict vs. non-restrict type compatibility hell

With the modified patch, gfortran.dg/restrict_type_compat_1.f90 fails for a regular test: FAIL: gfortran.dg/restrict_type_compat_1.f90 -O scan-tree-dump-times original "VIEW_CONVERT_EXPR" 13 A manual check shows only 6 instances of VIEW_CONVERT_EXPR. Cheers, Dominique

Re: random numbers in bulk

On Sun, Aug 26, 2012 at 4:52 AM, Marc Glisse wrote: > The std::generate(_n) function seems closer than std::fill. Not sure if > overloading that function (std::generate_n) would make sense, it avoids > changing the interface. I'm not wedded to fill. generate_n is fine as well. > If the goal is

[wwwdocs] Update links to C++ ABI (was: at exit alternative for AIX)

On Tue, 7 Aug 2012, Ian Lance Taylor wrote: > The official link at http://codesourcery.com/cxx-abi/ (note trailing > slash) still works. It used to be http://sourcery.mentor.com/public/cxx-abi/ as of lately, and now redirects to http://mentorembedded.github.com/cxx-abi/ . I went ahead and updated

Re: Commit: FRV: Add support for -fstack-usage

On Tue, 31 Jul 2012, Nick Clifton wrote: > I am applying the patch below to add support for the -fstack-usage > option to the FRV backend. I also added the below to our release notes. Feel free to tweak, add more, or let me know of changes you'd like to see. Gerald Index: changes.html =

Re: [PATCH, middle-end]: Introduce TARGET_LEGITIMATE_COMBINED_INSN target hook

Uros Bizjak schrieb: Hello! Actually a v3 of TARGET_REJECT_COMBINED_INSN target hook. Changes: - rename the hook and reverse the return value 2012-08-25 Uros Bizjak * target.def (legitimate_combined_insn): New target hook. * doc/tm.texi.in (TARGET_LEGITIMATE_COMBINED_INSN):

[PATCH, middle-end]: Introduce TARGET_LEGITIMATE_COMBINED_INSN target hook

Hello! Actually a v3 of TARGET_REJECT_COMBINED_INSN target hook. Changes: - rename the hook and reverse the return value 2012-08-25 Uros Bizjak * target.def (legitimate_combined_insn): New target hook. * doc/tm.texi.in (TARGET_LEGITIMATE_COMBINED_INSN): New hook. * do

Re: random numbers in bulk

On Sat, 25 Aug 2012, Ulrich Drepper wrote: On Sat, Aug 25, 2012 at 8:29 PM, Paolo Carlini wrote: Understood, but you do *not* loose performance by having those fill functions templates, Let's see. The prototypes will then be something like this: template class normal_distribution {

Re: Patches to enable -ftrack-macro-expansion by default

Gabriel Dos Reis writes: > I think we show the stack not just for errors, but for any diagnostics. I agree, FWIW. -- Dodji

Re: [Patch, fortran] [0/5] PR 45586: restrict vs. non-restrict type compatibility hell

> ... In the meantime is it by any chance better if the first patch in the serie > is replaced by the attached one? With the new patch for trans-expr.c (keeping those for trans-types.c and trans.h), typebound_proc_27.f03 -flto -O now works, but not class_array_7.f03 nor the other tests I have trie