Re: [google][4.6]Make option -freorder-functions= invoke function reordering linker plugin (issue 5825054)

2012-03-17 Thread davidxl
Ok for google branches after updating the doc/invoke.texi file. David http://codereview.appspot.com/5825054/

Re: remove wrong code in immed_double_const

2012-03-17 Thread Mike Stump
On Mar 17, 2012, at 12:37 AM, Richard Sandiford wrote: > Mike Stump writes: >> This removes some wrong code. >> >> Ok? >> >> Index: gcc/emit-rtl.c >> === >> --- gcc/emit-rtl.c (revision 184563) >> +++ gcc/emit-rtl.c (worki

Re: PATCH: Properly generate X32 IE sequence

2012-03-17 Thread H.J. Lu
On Sat, Mar 17, 2012 at 11:20 AM, Uros Bizjak wrote: > On Sat, Mar 17, 2012 at 7:18 PM, H.J. Lu wrote: > Since we must use reg64 in %fs:(%reg) memory operand like movq x@gottpoff(%rip),%reg64; mov %fs:(%reg64),%reg this patch optimizes x32 TLS IE load and store by wr

[fortran, patch] Follow-up "widechar error" patch

2012-03-17 Thread FX
This patch fixes PR 52559 (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=52559), which was due to my earlier patch for displaying error loci in lines containing wide characters (http://gcc.gnu.org/ml/fortran/2012-03/msg00015.html). In preexisting code, a tab is displayed as a single space when an

Re: [Patch, libfortran] PR 52608 F formatting with scale factor

2012-03-17 Thread Janne Blomqvist
On Sat, Mar 17, 2012 at 19:23, Janne Blomqvist wrote: > Hi, > > a recent patch by yours truly caused incorrect output for the > combination of scale factor, the value containing initial zeroes, and > F editing. Fixed by moving the removal of the initial zeros until > after the scale factor has bee

Re: PATCH: Properly generate X32 IE sequence

2012-03-17 Thread Uros Bizjak
On Sat, Mar 17, 2012 at 7:18 PM, H.J. Lu wrote: >>> Since we must use reg64 in %fs:(%reg) memory operand like >>> >>> movq x@gottpoff(%rip),%reg64; >>> mov %fs:(%reg64),%reg >>> >>> this patch optimizes x32 TLS IE load and store by wrapping >>> %reg64 inside of UNSPEC when Pmode == SImode.  OK fo

Re: PATCH: Properly generate X32 IE sequence

2012-03-17 Thread H.J. Lu
On Sat, Mar 17, 2012 at 11:10 AM, Uros Bizjak wrote: > On Sun, Mar 11, 2012 at 6:11 PM, H.J. Lu wrote: > >> Since we must use reg64 in %fs:(%reg) memory operand like >> >> movq x@gottpoff(%rip),%reg64; >> mov %fs:(%reg64),%reg >> >> this patch optimizes x32 TLS IE load and store by wrapping >> %r

Re: PATCH: Properly generate X32 IE sequence

2012-03-17 Thread Uros Bizjak
On Sun, Mar 11, 2012 at 6:11 PM, H.J. Lu wrote: > Since we must use reg64 in %fs:(%reg) memory operand like > > movq x@gottpoff(%rip),%reg64; > mov %fs:(%reg64),%reg > > this patch optimizes x32 TLS IE load and store by wrapping > %reg64 inside of UNSPEC when Pmode == SImode.  OK for > trunk? > >

Re: PATCH: Properly generate X32 IE sequence

2012-03-17 Thread H.J. Lu
On Tue, Mar 13, 2012 at 3:37 AM, Uros Bizjak wrote: > On Tue, Mar 13, 2012 at 8:11 AM, Uros Bizjak wrote: > > Please try attached patch.  It introduces TARGET_TLS_INDIRECT_SEG_REFS > to block only indirect seg references. >>> >>> There is no regression. >> >> Thanks, committed to mainline

[PATCH, i386] Remove empty predicates and/or constraints.

2012-03-17 Thread Uros Bizjak
On Sat, Mar 17, 2012 at 5:09 AM, Hans-Peter Nilsson wrote: >> A small no-op change - there is no need for a constraint in an expand >> pattern.  Plus some formatting. > > If you want to remove it, then remove it, don't just empty it. ;) Something like attached is probably even better ;) 2012-03

[Patch, libfortran] PR 52608 F formatting with scale factor

2012-03-17 Thread Janne Blomqvist
Hi, a recent patch by yours truly caused incorrect output for the combination of scale factor, the value containing initial zeroes, and F editing. Fixed by moving the removal of the initial zeros until after the scale factor has been applied to the value. Committed the patch below as obvious after

Re: [C++ Patch] PR 14710 (add -Wuseless-cast)

2012-03-17 Thread Jason Merrill
On 03/16/2012 05:42 PM, Paolo Carlini wrote: 3- References can be easily missed because wrapped in INDIRECT_REF: as explained at the beginning of tree.c and already used in many places, a REFERENCE_REF_P check (and in case a TREE_OPERAND (expr, 0)) takes care of that. I'm not 100% sure the soluti

Re: remove wrong code in immed_double_const

2012-03-17 Thread Richard Sandiford
Mike Stump writes: > This removes some wrong code. > > Ok? > > Index: gcc/emit-rtl.c > === > --- gcc/emit-rtl.c (revision 184563) > +++ gcc/emit-rtl.c (working copy) > @@ -540,8 +540,6 @@ immed_double_const (HOST_WIDE_INT i0