Re: [PATCH] PR50325 store_bit_field: Fix for big endian targets

2011-11-16 Thread David Edelsohn
Andreas, This patch seems to have introduced a failure for all of the gcc.dg-struct-layout tests on AIX. gcc.dg-struct-layout-1/t001_test.h:8:1: internal compiler error: in int_mode_for_mode, at stor-layout.c:424 After your change, int_mode_for_mode now is passed VOIDmode because the rtx is a CO

[arm-embedded] Backport mainline r178102 and partial r172017

2011-11-16 Thread Jiangning Liu
Backport mainline 178102 and partial r172017 to ARM/embedded-4_6-branch. Committed. 2011-11-17 Jiangning Liu Backport r178102 from mainline 2011-08-26 Jiangning Liu * config/arm/arm.md (*ior_scc_scc): Enable for Thumb2 as well. (*ior_scc_scc_cmp): Likewise

Re: [google] fix error caught by TREE_CHECKING (issue 5401045)

2011-11-16 Thread davidxl
Ok for google branches. David http://codereview.appspot.com/5401045/diff/1/gcc/dwarf2out.c File gcc/dwarf2out.c (right): http://codereview.appspot.com/5401045/diff/1/gcc/dwarf2out.c#newcode19777 gcc/dwarf2out.c:19777: { Use TYPE_P (decl_context) http://codereview.appspot.com/5401045/

[google] fix error caught by TREE_CHECKING (issue5401045)

2011-11-16 Thread Rong Xu
Fix a regression introduced in r180971. Only applicable to LIPO. For google branch only. Tested with internal benchmark suite. Thanks, -Rong 2011-11-16 Rong Xu * gcc/dwarf2out.c: use TYPE_CONTEXT to get the context for types. Index: gcc/dwarf2out.c

Re: [PATCH] Fix __atomic_compare_exchange library call and tests

2011-11-16 Thread Richard Henderson
On 11/16/2011 12:10 PM, Andrew MacLeod wrote: > > > * builtins.c (expand_builtin): Remove 4th parameter representing > weak/strong mode when __atomic_compare_exchange becomes a library call. > > testsuite > * gcc.dg/atomic-generic-aux.c (__atomic_compare_exchange): Fail

Fix alias set of memories created for atomic ops

2011-11-16 Thread Richard Henderson
Both Alpha and PPC create aligned memories for sub-word atomic ops. Neither were updated when ALIAS_SET_MEMORY_BARRIER was invented. I've no test case that fails because of this, just found by inspection. Built cross-compilers to both targets. Committed. r~ * config/alpha/alpha.c (alp

PR 44707 testcase failure

2011-11-16 Thread David Edelsohn
Hi, Uli and Jakub, I noticed that gcc.c-torture/compile/pr44707.c fails on AIX because it generates invalid assembly language: # 12 "/farm/dje/src/src/gcc/testsuite/gcc.c-torture/compile/pr44707.c" 1 /* 0(6) 0(7) 0(8) 0(9) 0(10) */ # 0 "" 2 I'm confused why __asm__ volatile ("/* %0

Re: Fix PRs 50644,50741, segfaults in set_is_used

2011-11-16 Thread Richard Guenther
On Wed, Nov 16, 2011 at 6:02 PM, Michael Matz wrote: > Hi, > > this patch fixes both problems by using the same condition as > add_referenced_var uses to guard walking into initializers.  I've > considered some other solutions but the real nice one (merging local_decls > and referenced_vars, and n

[PATCH] Fix __atomic_compare_exchange library call and tests

2011-11-16 Thread Andrew MacLeod
__atomic_compare_exchange has 6 parameters of which one is a boolean indicating whether its the weak or strong variation. The external library doesn't bother with the weak condition, so it only has 5 parameters. When generating the external call for the size specific __atomic_compare_exchange

[Patch, wwwdocs, committed] Update Fortran section in gcc-4.7/changes.html

2011-11-16 Thread Tobias Burnus
I have committed the following patch for http://gcc.gnu.org/gcc-4.7/changes.html#fortran Changes - Link F2003/F2008 sections to the wiki which gives the implementation status - Update backtrace information (Janne's changes from http://gcc.gnu.org/wiki/GFortran#GCC4.7) - Mention the just commi

Re: [Patch,Fortran] PR39427/37829 - implement F2003's constructors

2011-11-16 Thread Tobias Burnus
Paul Richard Thomas wrote: I think that a comment is in order every time that you exploit the upper/lower case distinction. OK for trunk. Thanks for the review and thanks for the comment. I have now added some comments to symbol.c's gfc_undo_symbols, decl.c's gfc_match_decl_type_spec and gfc

Re: [google] Backport r171347 from trunk to google/gcc-4_6 (issue5396043)

2011-11-16 Thread 關振德
Thanks Richard. I will wait for that patch. -Doug On Wed, Nov 16, 2011 at 8:41 AM, Richard Earnshaw wrote: > On 16/11/11 08:51, Doug Kwan wrote: >> This patch backports the upstream fix in r171347 for a problem caused by >> change in volatile bitfield access.  This is tested by building the >>

Re: Make x86-elf use DWARF-2 not stabs

2011-11-16 Thread Richard Henderson
On 11/15/2011 02:35 PM, Joseph S. Myers wrote: > 2011-11-15 Joseph Myers > > * config/i386/i386elf.h (PREFERRED_DEBUGGING_TYPE): Remove. Ok. r~

C++ Patch for c++/51141

2011-11-16 Thread Fabien Chêne
Hi, This patch fixes c++/51141, we simply need to strip the USING_DECL. Tested x86_64-unknown-linux-gnu. OK to commit ? gcc/testsuite/ChangeLog 2011-11-15 Fabien Chêne PR c++/51141 * g++.dg/lookup/using46.C: New. gcc/cp/ChangeLog 2011-11-15 Fabien Chêne PR c++/5

Re: [libitm] Support Solaris 8 and 9/x86 with Sun as

2011-11-16 Thread Iain Sandoe
On 16 Nov 2011, at 19:12, Richard Henderson wrote: On 11/16/2011 08:38 AM, Rainer Orth wrote: * config/generic/asmcfi.h: Fix comment. * config/x86/sjlj.S (_ITM_beginTransaction): Provide PIC code sequence without .hidden support. (GTM_longjmp) [__ELF__]: Only us

Re: [libitm] Support Solaris 8 and 9/x86 with Sun as

2011-11-16 Thread Richard Henderson
On 11/16/2011 08:38 AM, Rainer Orth wrote: > * config/generic/asmcfi.h: Fix comment. > * config/x86/sjlj.S (_ITM_beginTransaction): Provide PIC code > sequence without .hidden support. > (GTM_longjmp) [__ELF__]: Only use .hidden if > HAVE_ATTRIBUTE_VISIBILITY. Nearly

Re: [patch] trans-mem: Support noexcept specifications for transaction statements and expressions.

2011-11-16 Thread Torvald Riegel
Here is a revised version of the patch. It still fails when combined with transaction expressions (noexcept-4.C and noexcept-1.C) because gimplify_must_not_throw_expr() calls voidify_wrapper_expr() on a MUST_NOT_THROW_EXPR which it doesn't know to be a wrapper. What's the cleanest way to solve th

Re: [libitm] Provide all dummy functions in alloc_cpp.cc, eh_cpp.cc

2011-11-16 Thread Richard Henderson
On 11/16/2011 08:28 AM, Rainer Orth wrote: > 2011-11-16 Rainer Orth > > * alloc_cpp.cc [__osf__] (_ZnwX, _ZdlPv, _ZnaX, _ZdaPv, > _ZnwXRKSt9nothrow_t, _ZdlPvRKSt9nothrow_t, _ZdaPvRKSt9nothrow_t): > Dummy functions. > * eh_cpp.cc [__osf__] (__cxa_allocate_exception, __cxa

Re: [testsuite] Skip simulate-thread tests on all alpha targets

2011-11-16 Thread Richard Henderson
On 11/16/2011 08:31 AM, Rainer Orth wrote: > 2011-11-16 Rainer Orth > > * lib/gcc-simulate-thread.exp (simulate-thread): Skip on > alpha*-*-*. Ok. r~

[PATCH, committed] Handle NULL decl in rs6000_xcoff_section_type_flags

2011-11-16 Thread David Edelsohn
This patch fixes part of PR other/51174. rs6000_xcoff_section_type_flags() can be called with a NULL decl. This feature only was used on ELF paths which never called this XCOFF function. Bootstrapped on powerpc-ibm-aix5.3.0.0. - David * config/rs6000/rs6000.c (rs6000_xcoff_section_type_f

[libitm] Support Solaris 8 and 9/x86 with Sun as

2011-11-16 Thread Rainer Orth
libitm failed to build on Solaris 8 and 9/x86 with the native assembler, which lacks support for .hidden. The following patch deals with that by explicitly using the PIC code sequence, as inspired by libffi/src/x86/sysv.S. It allows libitm to build on i386-pc-solaris2.8, and testsuite results are

Re: [PATCH, i386]: Optimize v2df (x2) -> v4sf,v4si conversion sequences for AVX.

2011-11-16 Thread Uros Bizjak
On Tue, Nov 15, 2011 at 8:23 PM, Uros Bizjak wrote: > Attached patch optimizes  v2df (x2) -> v4sf,v4si conversion sequences > for AVX from: > >        vroundpd        $1, 32(%rsp), %xmm1 >        vroundpd        $1, 48(%rsp), %xmm0 >        vcvttpd2dqx     %xmm1, %xmm1 >        vcvttpd2dqx     %

[testsuite] Skip simulate-thread tests on all alpha targets

2011-11-16 Thread Rainer Orth
Tru64 UNIX suffers from the same problems running the simulate-thread tests as alpha-linux, even with gdb 7.3.1. To allow bootstraps/tests to complete, I think those tests should be skipped on all alpha targets as the following test does. Ok for mainline? Rainer 2011-11-16 Rainer Orth

[libitm] Provide all dummy functions in alloc_cpp.cc, eh_cpp.cc

2011-11-16 Thread Rainer Orth
I must have been dreaming the first time I looked at libitm testsuite results on Tru64 UNIX. Of course it cannot work to provide only a single dummy function, but all weak definitions must be backed by dummy definitions on that platform. The following patch does just that, and allows at least som

Re: [ARM] Fix PR49641

2011-11-16 Thread Richard Earnshaw
On 16/11/11 08:43, Sebastian Huber wrote: > On 11/08/2011 09:05 AM, Sebastian Huber wrote: >> On 10/31/2011 11:39 AM, Sebastian Huber wrote: >>> On 10/25/2011 06:56 PM, Richard Earnshaw wrote: On 24/10/11 14:30, Sebastian Huber wrote: > Hello, > > what about the attached patch base

Fix PRs 50644,50741, segfaults in set_is_used

2011-11-16 Thread Michael Matz
Hi, this patch fixes both problems by using the same condition as add_referenced_var uses to guard walking into initializers. I've considered some other solutions but the real nice one (merging local_decls and referenced_vars, and not using annotations for the used flag) doesn't seem appropri

Re: [google] Backport r171347 from trunk to google/gcc-4_6 (issue5396043)

2011-11-16 Thread Richard Earnshaw
On 16/11/11 08:51, Doug Kwan wrote: > This patch backports the upstream fix in r171347 for a problem caused by > change in volatile bitfield access. This is tested by building the > x86 toolchain with tests and checking that volatile bitfield access worked > on ARM. This is a backport for 4.6 onl

Re: [trans-mem] XFAIL known failures

2011-11-16 Thread Aldy Hernandez
What do you suggest, a bug report per failure with nothing but the directory/name of the test? I'd say a bug report for each distinct failure. It can get awful confusing when there's multiple bugs in a single PR... Done. PR numbers below. There is no trans-mem or libitm component, so I had

[PATCH] Add missing atomic macros to libstdc++-v3

2011-11-16 Thread Andrew MacLeod
Pr 51102 points out that a newish DR added these two macros into the standard. Bootstrapped and no new regressions. Checking in as trivial. Andrew * include/bits/atomic_base.h (ATOMIC_BOOL_LOCK_FREE, ATOMIC_POINTER_LOCK_FREE): New. Add missing macros. Index: include/bits/atomi

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-16 Thread David Edelsohn
On Wed, Nov 16, 2011 at 6:54 AM, Olivier Hainque wrote: > > On Nov 9, 2011, at 18:15 , Olivier Hainque wrote: >> I'm not convinced that the potential gain is worth the extra >> complexity and potential risk of running into another subtle >> subcase, with hard to track sporadic runtime failures for

Re: [C++ Patch] PR 51150

2011-11-16 Thread Gabriel Dos Reis
On Wed, Nov 16, 2011 at 9:00 AM, Paolo Carlini wrote: > Hi, > > this is an ICE on valid, 4.6/4.7 Regression, which manifests itself as tree > codes unhandled by cxx_eval_constant_expression. The patchlet below appears > to fix the issue and passes testing on x86_64-linux. > > Ok for mainline? Bran

Re: [google] Backport r171347 from trunk to google/gcc-4_6 (issue5396043)

2011-11-16 Thread Diego Novillo
On Wed, Nov 16, 2011 at 03:51, Doug Kwan wrote: > This patch backports the upstream fix in r171347 for a problem caused by > change in volatile bitfield access.  This is tested by building the > x86 toolchain with tests and checking that volatile bitfield access worked > on ARM.  This is a backpor

[C++ Patch] PR 51150

2011-11-16 Thread Paolo Carlini
Hi, this is an ICE on valid, 4.6/4.7 Regression, which manifests itself as tree codes unhandled by cxx_eval_constant_expression. The patchlet below appears to fix the issue and passes testing on x86_64-linux. Ok for mainline? Branch too? Thanks, Paolo. /cp 2011-

[PATCH, libitm]: FixPR51098, bootstrap failure on AVX target

2011-11-16 Thread Uros Bizjak
Hello! 2011-11-16 Uros Bizjak PR bootstrap/51098 * acinclude.m4 (LIBITM_CHECK_AS_AVX): Fix target selector. * configure: Regenerate. Tested on x86_64-pc-linux-gnu, committed to mainline SVN. Uros. Index: acinclude.m4 ===

Re: [Patch,Fortran] PR39427/37829 - implement F2003's constructors

2011-11-16 Thread Paul Richard Thomas
Dear Tobias, Sorry that I took an extra day over this approval; I kept getting disturbed. [Remark: The delected section in resolve_symbol with gfc_find_symbol(..&ds) was originally added in r133488 for PR fortran/33295] Hah! I plead guilty. I think that it must have been a necessary workaround

Re: [PATCH, ARM] Fix stack red zone bug (PR38644) for GCC 4.5

2011-11-16 Thread Ramana Radhakrishnan
On 16 November 2011 08:25, Sebastian Huber wrote: > Hi, > > this is Jiangning Liu's patch to fix PR38644 in ARM back-end > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38644. > > intended for the GCC 4.5 branch.  I didn't run the test suite.  I only > compiled the arm-eabi-gcc and checked that th

Re: [RFA/ARM] Make libgcc use UDIV/SDIV instructions when they are available.

2011-11-16 Thread Richard Earnshaw
On 15/11/11 16:17, Matthew Gretton-Dann wrote: > All, > > The attached patch causes libgcc to use the UDIV and SDIV instructions > when possible in the implementation of the ARM div/mod functions in libgcc. > > This will benefit Cortex-M3, Cortex-M4, all Cortex-R* CPUs, Cortex-A7, > and Cortex-

Re: [rs6000] Fix PR 50906, eh_frame and other woes

2011-11-16 Thread Olivier Hainque
On Nov 9, 2011, at 18:15 , Olivier Hainque wrote: > I'm not convinced that the potential gain is worth the extra > complexity and potential risk of running into another subtle > subcase, with hard to track sporadic runtime failures for > starters. I don't have numbers though. > > That's a port ma

Re: [PATCH] PR target/50038 fix: redundant zero extensions removal

2011-11-16 Thread Sergey Ostanevich
Eric, I will follow up while Ilya is on vacation. I can see only one patch along the dicussion so I will use it, making changes to follow phase renaming and documentation? I am covered by FSF agreement too, on the same Intel's list as Ilya. regards, Sergos On Fri, Nov 11, 2011 at 2:12 PM, Eric

Re: [PATCH] Fix PR51030, handle p ? &p->base : 0 in phiopt

2011-11-16 Thread Richard Guenther
On Fri, Nov 11, 2011 at 6:56 AM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 11/08/11 06:45, Richard Guenther wrote: >> >> This should optimize VEC_BASE that Jakub was patching by teaching >> phiopt to handle some one-statement intermediate basic-blocks. >> >> Bootstra

Re: PATCH, PR 50605] Handle MEM_REFs in is_gimple_ip_invariant_address

2011-11-16 Thread Richard Guenther
On Fri, Nov 11, 2011 at 4:21 PM, Martin Jambor wrote: > Hi, > > the problem in PR 50605 is that is_gimple_ip_invariant returns false > for > >  &MEM[(struct tRecorderImp *)&recorder + 8B] > > where &reorder is an IP gimple invariant.  This patch fixes that by > copying the code that handles MEM_RE

Re: [PATCH] Fold VEC_PERM_EXPR/VEC_INTERLEAVE*EXPR/VEC_EXTRACT*EXPR with VECTOR_CST/CONSTRUCTOR arguments (PR tree-optimization/51074, take 2)

2011-11-16 Thread Richard Guenther
On Fri, Nov 11, 2011 at 5:41 PM, Jakub Jelinek wrote: > On Fri, Nov 11, 2011 at 08:36:36AM -0800, Richard Henderson wrote: >> Ok, except >> >> > +    elts[i] >> > +      = fold_convert (TREE_TYPE (TREE_TYPE (arg)), integer_zero_node); >> >> build_int_cst. > > That would work for integer modes only

[arm-embedded] Revert r179307 and backport mainline r180964

2011-11-16 Thread Jiangning Liu
The original solution r179307 of stack red zone issue for PR38644 is completely reverted in ARM/embedded-4_6-branch. And backport mainline 180964 to ARM/embedded-4_6-branch. Committed. Undo changes committed in r179307. 2011-11-16 Jiangning Liu Backport r180964 from mainline

Re: [PATCH, ARM] Fix stack red zone bug (PR38644) for GCC 4.6

2011-11-16 Thread Ramana Radhakrishnan
On 16 November 2011 08:23, Sebastian Huber wrote: > Hi, > > this is Jiangning Liu's patch to fix PR38644 in ARM back-end > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38644. OK to backports in all release branches. Before committing the backport please modify the changelog entry to indicate th

Re: [PATCH] reload: Try alternative with swapped operands before going to the next

2011-11-16 Thread Andreas Krebbel
On 11/15/2011 11:31 PM, Maxim Kuvyrkov wrote: > I have eye-balled this patch for good half-an-hour and couldn't poke any > holes in it. I can't approve this patch, but below are some review comments. > Mostly these are suggested comments to make reload easier to understand for > future generat

[google] Backport r171347 from trunk to google/gcc-4_6 (issue5396043)

2011-11-16 Thread Doug Kwan
This patch backports the upstream fix in r171347 for a problem caused by change in volatile bitfield access. This is tested by building the x86 toolchain with tests and checking that volatile bitfield access worked on ARM. This is a backport for 4.6 only. 2011-11-16 Doug Kwan Backp

Re: [ARM] Fix PR49641

2011-11-16 Thread Sebastian Huber
On 11/08/2011 09:05 AM, Sebastian Huber wrote: On 10/31/2011 11:39 AM, Sebastian Huber wrote: On 10/25/2011 06:56 PM, Richard Earnshaw wrote: On 24/10/11 14:30, Sebastian Huber wrote: Hello, what about the attached patch based on the original patch provided by Bernd Schmidt with modifications

Re: [Patch] Fix compilation of libgcc/config/alpha/qrnnd.S on VMS

2011-11-16 Thread Tristan Gingold
On Nov 15, 2011, at 5:39 PM, Richard Henderson wrote: > On 11/15/2011 01:58 AM, Tristan Gingold wrote: >>* config/alpha/qrnnd.S: Use specific pseudos for VMS. > > Fine by me. Thanks, committed. > I know nothing about vms. Maybe you're lucky :-)

Re: [PATCH, ARM] Fix stack red zone bug (PR38644) for GCC 4.4

2011-11-16 Thread Sebastian Huber
Hi, this is Jiangning Liu's patch to fix PR38644 in ARM back-end http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38644. intended for the GCC 4.4 branch. I didn't run the test suite. I only compiled the arm-eabi-gcc and checked that this patch fixes the test case. -- Sebastian Huber, embedded b

Re: [PATCH, ARM] Fix stack red zone bug (PR38644) for GCC 4.5

2011-11-16 Thread Sebastian Huber
Hi, this is Jiangning Liu's patch to fix PR38644 in ARM back-end http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38644. intended for the GCC 4.5 branch. I didn't run the test suite. I only compiled the arm-eabi-gcc and checked that this patch fixes the test case. -- Sebastian Huber, embedded b

Re: [PATCH, ARM] Fix stack red zone bug (PR38644) for GCC 4.6

2011-11-16 Thread Sebastian Huber
Hi, this is Jiangning Liu's patch to fix PR38644 in ARM back-end http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38644. intended for the GCC 4.6 branch. Test results: http://gcc.gnu.org/ml/gcc-testresults/2011-11/msg01619.html -- Sebastian Huber, embedded brains GmbH Address : Obere Lagerstr. 3