Re: [google/integration] Support arm-grtev2-linux-*eabi (issue4628043)

2011-09-12 Thread Chris Demetriou
On Mon, Sep 12, 2011 at 15:24, Gerald Pfeifer wrote: > Should this be added to the GCC 4.7 release notes at > http://gcc.gnu.org/gcc-4.7/changes.html ?  If you need help doing > so, propose a text and I'll be happy to care of it. I absolutely need help (just ask Diego)... but not with that... 8-

Re: [2/4] SMS: Use ids to represent ps_insns

2011-09-12 Thread Ayal Zaks
Richard Sandiford wrote on 30/08/2011 03:03:59 PM: > From: Richard Sandiford > To: gcc-patches@gcc.gnu.org > Cc: Ayal Zaks/Haifa/IBM@IBMIL > Date: 30/08/2011 03:05 PM > Subject: [2/4] SMS: Use ids to represent ps_insns > > Instructions in a partial schedule are currently represented as a >

[v3] Declare std::tuple_cat constexpr (+ all std::get)

2011-09-12 Thread Paolo Carlini
Hi, Daniel kindly helped adjusting to enable constexpr for std::tuple_cat. At the same time all the std::get overloads, for std::pair and std::array too. Tested x86_64-linux, committed. Thanks, Paolo. 2011-09-12 Daniel Krugler Paolo Carlini

Re: Initial shrink-wrapping patch

2011-09-12 Thread Bernd Schmidt
On 09/01/11 15:57, Richard Sandiford wrote: > add_to_hard_reg_set (pused, GET_MODE (x), REGNO (x)); Done. > Strange line break, and comment doesn't match code (no "changed" variable). Fixed. >> +/* Return true if INSN requires the stack frame to be set up. >> + PROLOGUE_USED contains the hard

[pph] Restore -fno-dwarf2-cfi-asm. (issue4992051)

2011-09-12 Thread Lawrence Crowl
Restore compiling the tests with -fno-dwarf2-cfi-asm. Failure to do so results in different assembly output on different platforms due to different assembler support for exceptions. Index: gcc/testsuite/ChangeLog.pph 2011-09-12 Lawrence Crowl * lib/dg-pph.exp: Restore -fno-dwarf2-c

Re: [google/integration] Support arm-grtev2-linux-*eabi (issue4628043)

2011-09-12 Thread Gerald Pfeifer
On Thu, 16 Jun 2011, Chris Demetriou wrote: > This patch adds support for the arm-grtev2-linux-gnueabi configuration. > This is like the x86 linux config of similar 'vendor': > * it plays some spec games to support easier use of static NSS >configuration, and > * it adds RUNTIME_ROOT_PREFIX s

Re: [PATCH] c++/48320 - Template parameter packs cannot be expanded in

2011-09-12 Thread Jason Merrill
OK. Jason

Re: [pph] Remove XPASS noise from pph testsuite (issue4967063)

2011-09-12 Thread Lawrence Crowl
And I have confirmed the problem is still here. I'll be reinserting the option. On 9/12/11, Gabriel Charette wrote: > Oops forgot to reply all... > > On Mon, Sep 12, 2011 at 7:40 AM, Diego Novillo wrote: >> This patch removes all the XPASS noise from pph.exp runs by pruning >> the output from t

Re: [PATCH 7/7] Reduce memory waste due to non-power-of-2 allocs

2011-09-12 Thread Jason Merrill
On 07/16/2011 10:37 AM, Dodji Seketeli wrote: Ideally, I'd prefer some parts of this patch to be integrated into the memory allocator. That is, I'd like to see the memory allocator have an interface that returns the actual size of memory it has allocated. This would help client code like this on

Re: [PATCH 6/7] Kill pedantic warnings on system headers macros

2011-09-12 Thread Jason Merrill
On 07/16/2011 10:37 AM, Dodji Seketeli wrote: + location_t here = c_parser_peek_token (parser)->location; Perhaps "first_token_loc"? It's unfortunate that we don't retain the locations of the individual declspecs, but I don't expect you to fix that. + SYNTAX_ERROR2_AT (prev_virt

Re: [PATCH 5/7] Add line map statistics to -fmem-report output

2011-09-12 Thread Jason Merrill
On 07/16/2011 10:37 AM, Dodji Seketeli wrote: +#define ONE_M ONE_K * ONE_K Parenthesize this so that users don't need to. + macro_maps_used_size = +LINEMAPS_MACRO_USED (set) * sizeof (struct line_map) ++ macro_maps_locations_size; It seems odd to add in the locations size here sinc

Re: [PATCH 4/7] Support -fdebug-cpp option

2011-09-12 Thread Jason Merrill
On 08/24/2011 10:06 AM, Tom Tromey wrote: Dodji> Would it be acceptable to just change the output of -fdirective to fit? Dodji> Or are we bound to not breaking existing consumers? I think changing it would be fine. I agree. On 07/16/2011 10:37 AM, Dodji Seketeli wrote: } + +void +linemap_du

Re: [PATCH 3/7] Emit macro expansion related diagnostics

2011-09-12 Thread Jason Merrill
On 08/04/2011 11:32 AM, Dodji Seketeli wrote: +++ b/gcc/diagnostic.c @@ -30,6 +30,7 @@ along with GCC; see the file COPYING3. If not see #include "input.h" #include "intl.h" #include "diagnostic.h" +#include "vec.h" Do you still need this? // Just discard errors pointing at header files

[PATCH] c++/48320 - Template parameter packs cannot be expanded in

2011-09-12 Thread Dodji Seketeli
Hello, fixup_template_parms fixes up template parameters by substituting the result of current_template_args into each template parameter, from left to right. In the example the patch, when the compiler comes to the point of substituting into the default argument of template parameter Result, it

Re: [PATCH 2/7] Generate virtual locations for tokens

2011-09-12 Thread Jason Merrill
On 08/09/2011 10:54 AM, Dodji Seketeli wrote: + goto ftrack_macro_expansion_with_arg; + +case OPT_ftrack_macro_expansion_: +ftrack_macro_expansion_with_arg: Instead of the goto, just write /* Fall through. */ +consumption if necessary. Value @samp{0} of @var{level} de-activates

[Patch,AVR]: Fix PR 50358

2011-09-12 Thread Georg-Johann Lay
This patch introduces patterns for multiply-add and multiply-sub. On the enhanced core, these operations can be performed with the product in R0; there is no need to MOVW it out of that register. The code is smaller and faster and has lower register pressure. Tested without regressions. Ok to c

Re: [PATCH, rs6000] Preserve link stack for 476 cpus

2011-09-12 Thread David Edelsohn
On Mon, Sep 12, 2011 at 12:07 PM, Peter Bergner wrote: > The Power ISA declares the "bcl 20,31,..." instruction as the preferred > idiom for obtaining the next instruction address (NIA), which we use for > computing the address of the GOT.  This special branch and link is *not* > a subroutine call

Re: Add unwind information to mips epilogues

2011-09-12 Thread Richard Sandiford
Bernd Schmidt writes: > On 09/11/11 11:03, Richard Sandiford wrote: >> Richard Sandiford writes: >>> I think I need to play around with it a bit before I understand enough >>> to review. I'll try to find time this weekend. >> >> Does the attached patch look OK? It should fix a couple of things

Re: [PATCH] Fix -fno-dwarf2-cfi-asm bootstrap (PR bootstrap/50010)

2011-09-12 Thread Bernd Schmidt
On 09/12/11 17:13, Jakub Jelinek wrote: > dwarf2cfi.c generates sometimes different .eh_frame with/without > -fvar-tracking-assignments. The problem is that in add_cfis_to_fde > when adding NOTE_INSN_CFI_LABEL notes there is a scan to find consecutive > NOTE_INSN_CFI notes, but if there are any va

C++ PATCH to handling of template conversion functions

2011-09-12 Thread Jason Merrill
This was another change that I needed to make to fix the deduction issue mentioned in my previous mail, and brought my attention to an existing bug. When considering a template conversion function we don't want to allow derived-to-base conversions, but we should still allow qualification conve

Sequence of C++ PATCHes to C++11 reference semantics

2011-09-12 Thread Jason Merrill
While debugging a template deduction change that I didn't end up making, I fell down a rabbit hole into issues with our handling of C++11 reference semantics. Most of these changes are less necessary without the deduction change, but there is still a minor bug fix here, and I've been meaning t

Trivial C++ PATCH to implicit_conversion

2011-09-12 Thread Jason Merrill
While looking at something else I noticed that the middle test here can be much more expensive than the third if the type isn't complete yet, so I reordered them. This shouldn't have a significant effect on any code, but seemed like an improvement. Tested x86_64-pc-linux-gnu, applying to trun

Re: [PATCH, ARM] Support NEON's VABD with combine pass

2011-09-12 Thread Ramana Radhakrishnan
On 12 September 2011 17:11, Dmitry Melnik wrote: > >> Interesting but I would be a bit defensive and make sure that this >> matches only if -ffast-math in the FP case. You are sort of relying on >> the fact that vsub wouldn't be generated without ffast-math but I'd >> rather be defensive about it

Re: [PLUGIN] Fix PLUGIN_FINISH_TYPE

2011-09-12 Thread Dodji Seketeli
Romain Geissler a écrit: > I just checked again, and PLUGIN_FINISH_DECL is triggered for a > typedef in C mode, but not in C++ mode. I'll patch that. Correct. This is because the event is emitted at the end of cp_finish_decl, but that function has many return points. Maybe unifying all the tho

Re: [PATCH, ARM] Support NEON's VABD with combine pass

2011-09-12 Thread Dmitry Melnik
Interesting but I would be a bit defensive and make sure that this matches only if -ffast-math in the FP case. You are sort of relying on the fact that vsub wouldn't be generated without ffast-math but I'd rather be defensive about it . (This is in case it's not clear in the non-intrinsics case)

[PATCH, rs6000] Preserve link stack for 476 cpus

2011-09-12 Thread Peter Bergner
The Power ISA declares the "bcl 20,31,..." instruction as the preferred idiom for obtaining the next instruction address (NIA), which we use for computing the address of the GOT. This special branch and link is *not* a subroutine call, meaning it won't be paired with a blr (subroutine return). P

Re: Patch ping

2011-09-12 Thread Jeff Law
On 09/12/2011 09:18 AM, Jakub Jelinek wrote: Hi! I'd like to ping two patches of mine: http://gcc.gnu.org/ml/gcc-patches/2011-08/msg02385.html - PR rtl-optimization/50212 fix EH ICE with -freorder-blocks-and-partition Seems OK. Though I did wonder why we were deleting the label and wh

Re: [PLUGIN] Fix PLUGIN_FINISH_TYPE

2011-09-12 Thread Romain Geissler
Hi, 2011/9/12 Dodji Seketeli : > Hello Romain, > > Romain Geissler a écrit: > >> This patch solves some lacks with the PLUGIN_FINISH_TYPE event >> triggering. For now, both C and C++ parser won't trigger it for enums or >> for typedef. > > AFAICT, typedef declarations are reported by the PLUGIN_F

[lra] patch to solve code size regression on ppc32 SPEC2000

2011-09-12 Thread Vladimir Makarov
The following patch fixes ppc32 code size regression on SPEC2000. I already posted an analogous patch http://gcc.gnu.org/ml/gcc-patches/2011-08/msg02208.html but it resulted in wrong code generation on x86. The original patch was reworked to fix the x86 code generation. To do this, classes

Patch ping

2011-09-12 Thread Jakub Jelinek
Hi! I'd like to ping two patches of mine: http://gcc.gnu.org/ml/gcc-patches/2011-08/msg02385.html - PR rtl-optimization/50212 fix EH ICE with -freorder-blocks-and-partition http://gcc.gnu.org/ml/gcc-patches/2011-09/msg00386.html - PR debug/50299 addition original argument mode to

[PATCH] Fix -fno-dwarf2-cfi-asm bootstrap (PR bootstrap/50010)

2011-09-12 Thread Jakub Jelinek
Hi! dwarf2cfi.c generates sometimes different .eh_frame with/without -fvar-tracking-assignments. The problem is that in add_cfis_to_fde when adding NOTE_INSN_CFI_LABEL notes there is a scan to find consecutive NOTE_INSN_CFI notes, but if there are any var-tracking notes in between, more labels ar

Re: [PLUGIN] Fix PLUGIN_FINISH_TYPE

2011-09-12 Thread Dodji Seketeli
Hello Romain, Romain Geissler a écrit: > This patch solves some lacks with the PLUGIN_FINISH_TYPE event > triggering. For now, both C and C++ parser won't trigger it for enums or > for typedef. AFAICT, typedef declarations are reported by the PLUGIN_FINISH_DECL event. The predicate is_typedef_

Re: [pph] Remove XPASS noise from pph testsuite (issue4967063)

2011-09-12 Thread Gabriel Charette
Oops forgot to reply all... On Mon, Sep 12, 2011 at 7:40 AM, Diego Novillo wrote: > This patch removes all the XPASS noise from pph.exp runs by pruning > the output from the base compiles (thanks Ian for the pointer). It > add some comments as well. > > Lawrence, I noticed that we do not seem to

Re: [pph] Do not read pph files more than once (issue4983055)

2011-09-12 Thread Gabriel Charette
Oops forgot to reply all the first time... On Fri, Sep 9, 2011 at 4:54 PM, Diego Novillo wrote: > This was not causing any failures, but it is pretty wasteful to read > the same PPH more than once. > > We cannot just skip them, however. We need to read the line table to > properly modify the lin

Re: Add unwind information to mips epilogues

2011-09-12 Thread Bernd Schmidt
On 09/11/11 11:03, Richard Sandiford wrote: > Richard Sandiford writes: >> I think I need to play around with it a bit before I understand enough >> to review. I'll try to find time this weekend. > > Does the attached patch look OK? It should fix a couple of things. Sure! Bernd

Re: [pph] Fix method lookups (part 1) (issue4997042)

2011-09-12 Thread Diego Novillo
On Sat, Sep 10, 2011 at 11:30, Gabriel Charette wrote: > On Fri, Sep 9, 2011 at 4:37 PM, Diego Novillo wrote: >> >> The main problem fixed here is that name lookups for class methods >> uses a binary search that assumes that the methods in >> CLASSTYPE_METHOD_VEC are sorted by pointer value. >> >

Re: [PATCH] Fix up call_site_parameter (PR debug/50299)

2011-09-12 Thread Richard Sandiford
Jakub Jelinek writes: > 2011-09-06 Jakub Jelinek > > PR debug/50299 > * calls.c (load_register_parameters): Use use_reg_mode instead > of use_reg when adding a single register CALL_INSN_FUNCTION_USAGE > entry. > (expand_call): Set EXPR_LIST mode to TYPE_MODE of the

Re: [PATCH, SMS] Minor misc. fixes

2011-09-12 Thread Revital Eres
Hello, > OK. > While we're at it, an alternative would be to have > remove_node_from_ps() assert its own (parameters and) return value. > That is, replace "if (c) return false" by "assert (!c)" and have it > return void if successful. There's not much you can do if it returns > false. That would c

[pph] Remove XPASS noise from pph testsuite (issue4967063)

2011-09-12 Thread Diego Novillo
This patch removes all the XPASS noise from pph.exp runs by pruning the output from the base compiles (thanks Ian for the pointer). It add some comments as well. Lawrence, I noticed that we do not seem to need -I. -fno-dwarf2-cfi-asm anymore. So, I removed them. I'm not sure I remember exactly

Re: [wwwdocs] Revamp the news section on our title page

2011-09-12 Thread Gerald Pfeifer
This patchlet did not make it from my test environment to the patch I committed for production for some reason. Fixed thusly. Gerald Index: gcc.css === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc.css,v retrieving revision 1.24 diff -u -r1

Re: ARM: Emit conditions in push_multi

2011-09-12 Thread Jakub Jelinek
Hi! This last hunk is wrong, for sprintf you need to use %% instead of %. On Wed, Sep 07, 2011 at 09:23:36PM +0200, Bernd Schmidt wrote: > @@ -10631,7 +10633,7 @@ (define_insn "*push_fp_multi" >{ > char pattern[100]; > > -sprintf (pattern, \"sfmfd\\t%%1, %d, [%%m0]!\", XVECLEN (ope

[PLUGIN] Fix PLUGIN_FINISH_TYPE

2011-09-12 Thread Romain Geissler
Hi, This patch solves some lacks with the PLUGIN_FINISH_TYPE event triggering. For now, both C and C++ parser won't trigger it for enums or for typedef. In C++, when a struct, class or union declaration is parsed (without definition), the given event data is an error mark instead of the parsed ty

Re: [wwwdocs] Document recent (and less recent) SPARC changes

2011-09-12 Thread Eric Botcazou
> (Well, to live up to my reviewer's reputation :-) and provide a > nanonit, perhaps omit "and later"?) Installed with this change, thanks. -- Eric Botcazou