[PATCH, ARM] iWMMXT maintenance

2011-06-20 Thread Xinyu Qi
Hi, This patch maintains iWMMXT intrinsics code, adds WMMX pipeline description and supports iWMMXT auto-vectorization. Ran Arm testsuite on arm-linux-gnueabi. *gcc/config/arm/elf.h: Add option -mwmmxt. *gcc/config/arm/arm.opt: Same. *gcc/config/arm/arm.c (arm_option_override): Same. (arm_coproc

Re: [PATCH] parallelize gcc, gfortran and libstdc++ testing some more

2011-06-20 Thread Jason Merrill
OK. Jason

C++ PATCH for c++/49216 (problems with new T[1]{})

2011-06-20 Thread Jason Merrill
The reported problem was due to creating a CONSTRUCTOR with pointer type, expecting it to be an array; now we only build a CONSTRUCTOR for array type. While I was looking at this issue I noticed that the user-defined type case also had problems, because it was still using T() instead of {} to

Re: C++ PATCH for c++/48138 (losing __attribute ((aligned)) on template argument)

2011-06-20 Thread Jason Merrill
On 06/20/2011 10:23 AM, Jason Merrill wrote: strip_typedefs needs to propagate DECL_USER_ALIGN as well as attributes in the attribute list. ...except that we don't want to retain attributes on template type arguments, since they aren't part of mangling, so you could get a class template insta

Mark variables addressable if they are copied using libcall in RTL expander

2011-06-20 Thread Easwaran Raman
This fixes bugs introduced by r175063. OK for trunk if there are no test regressions? -Easwaran 2011-06-20 Easwaran Raman PR rtl-optimization/49429 * expr.c (emit_block_move_hints): Mark MEM_EXPR(x) and MEM_EXPR(y) addressable if emit_block_move_via_libcall is

Re: [Patch, Fortran, OOP] PR 49112: [4.6/4.7 Regression] Missing type-bound procedure, "duplicate save" warnings and internal compiler error

2011-06-20 Thread Steve Kargl
On Tue, Jun 21, 2011 at 12:29:01AM +0200, Janus Weil wrote: > Hi all, > > while I continue working on some of the yet unsolved parts of this PR, > I'm already posting a simple patch which fixes the part with > "duplicate save" warnings on CLASS variables (which is a regression on > 4.6 and trunk).

[pph] Fix binding_level's names_size streaming (issue4634071)

2011-06-20 Thread Gabriel Charette
We were streaming out the original names_size which includes the built-in names which are not streamed out. This only streams out the actual number of streamed names as names_size. It appears names_size is not even used anywhere in the code (or at least I couldn't find any use of it with `grep "n

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H. Peter Anvin
Richard Henderson wrote: >On 06/20/2011 04:39 PM, H. Peter Anvin wrote: >> sys_foo: >> cmpl$10, %edi >> jae .L1 >> >> movqfoo_table(,%rdi,3), %rax >> retq >> .L1: >> movq$-EINVAL, %rax >> retq >> >> Enter this function with a non-normalized %rdi and

Re: [RFC] Fix unwind info for sparc -mflat

2011-06-20 Thread Richard Henderson
On 06/20/2011 05:33 PM, Richard Henderson wrote: > The current code generation for -mflat uses 3 insn patterns > which emit up two three insns (sort of) emulating the save Lest I get sent back for remedial English, that was supposed to be "emit two or three" but fingers got ahead of brain. r~

[RFC] Fix unwind info for sparc -mflat

2011-06-20 Thread Richard Henderson
The current code generation for -mflat uses 3 insn patterns which emit up two three insns (sort of) emulating the save instruction. The problem is that the unwind info is only produced at the end of any pattern, leaving a 1 or 2 insn hole for which the unwind info is not correct. I tried to figur

Re: [patch] Improve detection of widening multiplication in the vectorizer

2011-06-20 Thread H.J. Lu
On Tue, Jun 7, 2011 at 1:50 PM, H.J. Lu wrote: > On Wed, Jun 1, 2011 at 2:23 AM, Ira Rosen wrote: >> Hi, >> >> The vectorizer expects widening multiplication pattern to be: >> >>     type a_t, b_t; >>     TYPE a_T, b_T, prod_T; >> >>     a_T = (TYPE) a_t; >>     b_T = (TYPE) b_t; >>     prod_T =

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread Richard Henderson
On 06/20/2011 04:39 PM, H. Peter Anvin wrote: > sys_foo: > cmpl$10, %edi > jae .L1 > > movqfoo_table(,%rdi,3), %rax > retq > .L1: > movq$-EINVAL, %rax > retq > > Enter this function with a non-normalized %rdi and you have a security > hole even

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H. Peter Anvin
On 06/20/2011 03:49 PM, Richard Henderson wrote: >> >> As I have already stated, if we *cannot* require pointers to be >> zero-extended on entry to the kernel, we're going to have to have >> special entry points for all the x32 system calls except the ones that >> don't take pointers. > > If it's

Re: SRA generates uninitialized var use

2011-06-20 Thread Xinliang David Li
Good point -- but why does SRA have to be so complicated? If it just do structure expansion and let subsequent phases to clean it up, would it be simpler? Anyway this is off the topic. Thanks, David On Mon, Jun 20, 2011 at 1:47 PM, Richard Guenther wrote: > On Mon, Jun 20, 2011 at 6:15 PM, Xin

RE: Backport AVX256 load/store split patches to gcc 4.6 for performance boost on latest AMD/Intel hardware.

2011-06-20 Thread Lu, Hongjiu
> > The patch that disables default setting of unaligned load splitting > for bdver1 has been committed > to trunk as revision 175230. > > Here is the patch: http://gcc.gnu.org/ml/gcc-patches/2011- > 06/msg01518.html. > > H. J., is there anything else that is pending to fix at this moment > rega

Re: __sync_swap* with acq/rel/full memory barrier semantics

2011-06-20 Thread Richard Henderson
On 06/20/2011 03:53 PM, Andrew MacLeod wrote: > On 06/20/2011 06:33 PM, Richard Henderson wrote: > If you want to standardize it with SYNC_ for all cases, I will create all > the new ones that way. I do think the name of all the bits related to handling a builtin function should match the builti

Re: __sync_swap* with acq/rel/full memory barrier semantics

2011-06-20 Thread Andrew MacLeod
On 06/20/2011 06:33 PM, Richard Henderson wrote: On 06/20/2011 09:22 AM, Andrew MacLeod wrote: builtins.c:expand_builtin_lock_test_and_set (enum machine_mode mode, tree exp, builtins.c:case BUILT_IN_LOCK_TEST_AND_SET_1: builtins.c:case BUILT_IN_LOCK_TEST_AND_SET_2: builtins.c:case BU

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread Richard Henderson
On 06/20/2011 07:33 AM, H. Peter Anvin wrote: > On 06/20/2011 07:01 AM, H.J. Lu wrote: >> On Mon, Jun 20, 2011 at 6:53 AM, Bernd Schmidt >> wrote: >>> On 06/20/2011 03:51 PM, H.J. Lu wrote: Promote pointers to Pmode when passing/returning in registers is a security concern. > > No. Pr

Patch: speed up compiler a little bit by optimizing lookup_attribute() and is_attribute_p()

2011-06-20 Thread Nicola Pero
This patch speeds up the C/C++/ObjC/ObjC++ compiler a little bit by optimizing lookup_attribute() and is_attribute_p(). The main change is that these functions are now inline. Benchmarking the C compiler (--enable-checking=release) compiling postgresql from source shows that total compilation t

Re: __sync_swap* with acq/rel/full memory barrier semantics

2011-06-20 Thread Richard Henderson
On 06/20/2011 09:22 AM, Andrew MacLeod wrote: > builtins.c:expand_builtin_lock_test_and_set (enum machine_mode mode, tree exp, > builtins.c:case BUILT_IN_LOCK_TEST_AND_SET_1: > builtins.c:case BUILT_IN_LOCK_TEST_AND_SET_2: > builtins.c:case BUILT_IN_LOCK_TEST_AND_SET_4: > > whereas eve

[Patch, Fortran, OOP] PR 49112: [4.6/4.7 Regression] Missing type-bound procedure, "duplicate save" warnings and internal compiler error

2011-06-20 Thread Janus Weil
Hi all, while I continue working on some of the yet unsolved parts of this PR, I'm already posting a simple patch which fixes the part with "duplicate save" warnings on CLASS variables (which is a regression on 4.6 and trunk). The warnings are silenced by making the vtab and default initialization

RE: Remove TARGET_HELP hook

2011-06-20 Thread Weddington, Eric
> -Original Message- > From: Joseph Myers [mailto:jos...@codesourcery.com] > Sent: Monday, June 20, 2011 4:03 PM > To: Weddington, Eric > Cc: Georg-Johann Lay; gcc-patches@gcc.gnu.org; cherty...@gmail.com; > ae...@post.ru > Subject: RE: Remove TARGET_HELP hook > > On Mon, 20 Jun 2011, We

RE: Backport AVX256 load/store split patches to gcc 4.6 for performance boost on latest AMD/Intel hardware.

2011-06-20 Thread Fang, Changpeng
The patch that disables default setting of unaligned load splitting for bdver1 has been committed to trunk as revision 175230. Here is the patch: http://gcc.gnu.org/ml/gcc-patches/2011-06/msg01518.html. H. J., is there anything else that is pending to fix at this moment regarding avx256 load/st

RE: [PATCH, PR 49089] Don't split AVX256 unaligned loads by default on bdver1 and generic

2011-06-20 Thread Fang, Changpeng
Thanks, Patch has been committed to trunk as revision 175230. Changpeng From: Uros Bizjak [ubiz...@gmail.com] Sent: Monday, June 20, 2011 1:38 PM To: Fang, Changpeng Cc: H.J. Lu; gcc-patches@gcc.gnu.org; hubi...@ucw.cz; rguent...@suse.de Subject: Re: [PATC

RE: Remove TARGET_HELP hook

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Weddington, Eric wrote: > > > As it's auto-generated: must it reside in repository? > > > > The machinery for selecting .opt files to use and for using them (both in > > the compiler and in .pot generation) expects them all to be in the source > > directory. > > Right. So, a

Re: [Patch, Fortran] (coarray) Add LOCK_TYPE

2011-06-20 Thread Tobias Burnus
Dear Paul, Paul Richard Thomas wrote: I have checked out the code for any obvious style or other minor errors and all looks well. However, I had a look at 8.5.6 "LOCK and UNLOCK statements" in the standard and can only confess to feeling very stupid tonight because I could not make head nor tai

[PATCH] parallelize gcc, gfortran and libstdc++ testing some more

2011-06-20 Thread Jakub Jelinek
On Mon, Jun 20, 2011 at 03:54:59PM +0200, Jakub Jelinek wrote: > On Mon, Jun 20, 2011 at 09:28:56AM -0400, Jason Merrill wrote: > > On 06/17/2011 08:20 PM, Mike Stump wrote: > > >On Jun 17, 2011, at 10:47 AM, Nathan Froyd wrote: > > >>I've done a lot of g++-only testsuite runs lately > > > > > >I t

RE: Remove TARGET_HELP hook

2011-06-20 Thread Weddington, Eric
> -Original Message- > From: Joseph Myers [mailto:jos...@codesourcery.com] > Sent: Monday, June 20, 2011 1:20 PM > To: Georg-Johann Lay > Cc: gcc-patches@gcc.gnu.org; cherty...@gmail.com; ae...@post.ru; > Weddington, Eric > Subject: Re: Remove TARGET_HELP hook > > On Mon, 20 Jun 2011, Ge

Re: [PATCH][RFC][1/2] Bitfield lowering, add BIT_FIELD_EXPR

2011-06-20 Thread Andrew Pinski
On Mon, Jun 20, 2011 at 1:54 PM, Richard Guenther wrote: > Yeah, well.  We have mostly no target dependency in those gimple > statement speed/size cost metric, so the above 3 is matching > how the expansion to gimple shift/mask stmts would measure. Except RTH has mentioned there is already a way

Re: [PATCH][RFC][1/2] Bitfield lowering, add BIT_FIELD_EXPR

2011-06-20 Thread Richard Guenther
On Mon, Jun 20, 2011 at 8:43 PM, Andrew Pinski wrote: > On Mon, Jun 20, 2011 at 7:19 AM, William J. Schmidt > wrote: >> On Thu, 2011-06-16 at 09:49 -0700, Richard Henderson wrote: >>> On 06/16/2011 04:35 AM, Richard Guenther wrote: >>> > >>> > +     /* Bit-field insertion needs several shift and

Re: SRA generates uninitialized var use

2011-06-20 Thread Richard Guenther
On Mon, Jun 20, 2011 at 6:15 PM, Xinliang David Li wrote: > It is used to indicate the fact the var decl needs to have a memory > home (addressable) -- is there another way to do this? this is to > avoid the following situation: > > 1) after SRA before update SSA, the IR looks like: > >   MEM[

[testsuite] scan-assembler variants to use 'unresolved' for missing file

2011-06-20 Thread Janis Johnson
Variants of scan-assembler, used in the dg-final steps of a test, do not check that the output file exists, so it's reported as an error. With this patch, if the file is missing then the check is reported as unresolved using the same message as for pass/fail, and the reason for the unresolved test

Re: Add __builtin_clrsb, similar to clz/ctz

2011-06-20 Thread Richard Henderson
On 06/20/2011 12:38 PM, Bernd Schmidt wrote: > D'oh. Blackfin has a (clrsb:HI (operand:SI)) instruction, so adding this > showed a problem with some of the existing simplify_const_unop cases: > for ffs/clz/ctz/clrsb/parity/popcount, we should look at the mode of the > operand, rather than the mode

Re: Add __builtin_clrsb, similar to clz/ctz

2011-06-20 Thread Bernd Schmidt
On 06/16/2011 06:25 PM, Richard Henderson wrote: > On 06/16/2011 05:44 AM, Bernd Schmidt wrote: >> +@deftypefn {Built-in Function} int __builtin_clrsb (unsigned int x) >> +Returns the number of leading redundant sign bits in @var{x}, starting >> +at the most significant bit position. >> +@end defty

Re: patch trunk: seek plugin also in a language specific directory when given a short name

2011-06-20 Thread Basile Starynkevitch
Hello All, Reference http://gcc.gnu.org/ml/gcc-patches/2011-06/msg00477.html - I am essentially pinging it, but improving the ChangeLog entry. The attached patch to trunk 175201 makes cc1, cc1plus, ... lto1 also search a language specific subdirectory. # gcc/ChangeLog entry ## 2011-06-20

Re: Remove TARGET_HELP hook

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Georg-Johann Lay wrote: > > Index: gcc/config/avr/avr-tables.opt > > === > > --- gcc/config/avr/avr-tables.opt (revision 0) > > +++ gcc/config/avr/avr-tables.opt (revision 0) > > As it's auto-generated: must

Re: [Patch, Fortran] (coarray) Add LOCK_TYPE

2011-06-20 Thread Paul Richard Thomas
Dear Tobias, I have checked out the code for any obvious style or other minor errors and all looks well. However, I had a look at 8.5.6 "LOCK and UNLOCK statements" in the standard and can only confess to feeling very stupid tonight because I could not make head nor tail of the example. Thus, I

Backport patches that are either bug fixes or make reasonably significant performance impact for latest AMD/Intel hardware

2011-06-20 Thread harsha.jagasia
Is it ok to backport patches, with Changelogs below, already in trunk to gcc 4.6? These patches are significant enough bugs fror recent AMD and Intel hardware. If ok and unless the individual authors want to backport, I will post backported patches for commit approval. [PATCH] Handle misaligned TF

Re: [PATCH][RFC][1/2] Bitfield lowering, add BIT_FIELD_EXPR

2011-06-20 Thread Andrew Pinski
On Mon, Jun 20, 2011 at 7:19 AM, William J. Schmidt wrote: > On Thu, 2011-06-16 at 09:49 -0700, Richard Henderson wrote: >> On 06/16/2011 04:35 AM, Richard Guenther wrote: >> > >> > +     /* Bit-field insertion needs several shift and mask operations.  */ >> > +     case BIT_FIELD_EXPR: >> > +    

Re: [PATCH, PR 49089] Don't split AVX256 unaligned loads by default on bdver1 and generic

2011-06-20 Thread Uros Bizjak
On Mon, Jun 20, 2011 at 8:03 PM, Fang, Changpeng wrote: >  I modified the patch as H.J. suggested (patch attached). > > Is it OK to commit to trunk now? Yes, this is OK for trunk. Thanks, Uros.

RE: [PATCH, PR 49089] Don't split AVX256 unaligned loads by default on bdver1 and generic

2011-06-20 Thread Fang, Changpeng
Hi, I modified the patch as H.J. suggested (patch attached). Is it OK to commit to trunk now? Thanks, Changpeng From: H.J. Lu [hjl.to...@gmail.com] Sent: Friday, June 17, 2011 5:44 PM To: Fang, Changpeng Cc: Richard Guenther; gcc-patches@gcc.gnu.org

[Patch, AVR]: Fix PR33049 (implement extzv)

2011-06-20 Thread Georg-Johann Lay
This is an optimization patch that implements extzv for 1-bit extracts. The nice thing is that AVR can do this easily with a BLD/CLR/BST sequence, without putting pressure on d-regs and without the requirement of source being in the same register as destination. extzv can also be seen in conjunct

Re: Remove TARGET_HELP hook

2011-06-20 Thread Georg-Johann Lay
Joseph S. Myers schrieb: > When moving hooks used in opts.c to the common hooks structure so they > can be called from the driver, I did not move the TARGET_HELP hook > because this hook is obsoleted by the generic Enum .opt facility (only > being used to print list of enumerated arguments to optio

Re: [patch fold-const.c]: Add some missing optimizations about binary and and truth-not

2011-06-20 Thread Mike Stump
On Jun 20, 2011, at 8:38 AM, Jeff Law wrote: >> "do not need" != "cannot" >> >>> This has been discussed several times. So no, this noise isn't at all >>> useful nor welcome. >> >> useful or welcome TO YOU. Obviously, it's useful to us. > Umm, it's neither welcome nor useful to many folks -

Simplify Solaris configuration

2011-06-20 Thread Rainer Orth
I had long meant to do another round of cleanups of the Solaris configuration, which has much duplication and inconsistencies between the SPARC and x86 versions. The following patch is the result of this work. It consists of several parts: * Move the common Solaris parts in config.gcc to the *-*

[x32] PATCH: Also allow x32 for gcc.dg/pr44194-1.c

2011-06-20 Thread H.J. Lu
Hi, I checked this patch into x32 branch. H.J. --- commit f68fa52c0474cbacd8c2e0cf41d2f472baebdf7c Author: H.J. Lu Date: Wed Jun 15 11:26:28 2011 -0700 Also allow x32 for gcc.dg/pr44194-1.c. diff --git a/gcc/testsuite/ChangeLog.x32 b/gcc/testsuite/ChangeLog.x32 index 43af9dd..ab8dd76 100

Re: [PATCH 0/4] Docs: extend.texi

2011-06-20 Thread Michael Witten
On Thu, Apr 28, 2011 at 01:20, Michael Witten wrote: > See the following emails for a few inlined patches > to /trunk/gcc/doc/extend.texi (revision 172911): > > [1] Docs: extend.texi: Add missing semicolon for consistency > [2] Docs: extend.texi: Remove trailing blanks from lines > [3] Docs: e

RE: Backport AVX256 load/store split patches to gcc 4.6 for performance boost on latest AMD/Intel hardware.

2011-06-20 Thread Jagasia, Harsha
> On Mon, Jun 20, 2011 at 9:58 AM, wrote: > > Is it ok to backport patches, with Changelogs below, already in trunk > to gcc > > 4.6? These patches are for AVX-256bit load store splitting. These > patches > > make significant performance difference >=3% to several CPU2006 and > > Polyhedron bench

Re: [PATCH] Fix ICEs with out of range immediates in SSE*/AVX*/XOP* intrinsics (PR target/49411)

2011-06-20 Thread Kirill Yukhin
Folks, I think that implementation of the patch is not as good. It introduces working with specific instructions in ix86_expand_multi_arg_builtin(), however before it was really generic. It operated only on abstract insns, only number/type of arguments was matter. But now there’re INSN_CODE switche

Re: Backport AVX256 load/store split patches to gcc 4.6 for performance boost on latest AMD/Intel hardware.

2011-06-20 Thread H.J. Lu
On Mon, Jun 20, 2011 at 9:58 AM, wrote: > Is it ok to backport patches, with Changelogs below, already in trunk to gcc > 4.6? These patches are for AVX-256bit load store splitting. These patches > make significant performance difference >=3% to several CPU2006 and > Polyhedron benchmarks on lates

Re: Removing target-libiberty (was: Re: Libiberty: POSIXify psignal definition)

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Hans-Peter Nilsson wrote: > It seems none in approval capacity have any objection to > (figuratively) s/target-libiberty//g in toplevel/configure.ac on > all branches. Is an --enable-target-libiberty or > --with-target-libiberty needed? (I'd just rather not.) There should b

Backport AVX256 load/store split patches to gcc 4.6 for performance boost on latest AMD/Intel hardware.

2011-06-20 Thread harsha.jagasia
Is it ok to backport patches, with Changelogs below, already in trunk to gcc 4.6? These patches are for AVX-256bit load store splitting. These patches make significant performance difference >=3% to several CPU2006 and Polyhedron benchmarks on latest AMD and Intel hardware. If ok, I will post backp

RE: Remove TARGET_HELP hook

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Weddington, Eric wrote: > I assume that this new method still prints out the avr mcu list in a > similar fashion? Yes. Any enumerated options get such lists printed as long as there is a help text on the Enum entry in the .opt file. -- Joseph S. Myers jos...@codesourcery

Re: Remove TARGET_HELP hook

2011-06-20 Thread Denis Chertykov
2011/6/20 Weddington, Eric : > > >> -Original Message- >> From: Joseph Myers [mailto:jos...@codesourcery.com] >> Sent: Monday, June 20, 2011 9:47 AM >> To: gcc-patches@gcc.gnu.org >> Cc: cherty...@gmail.com; ae...@post.ru; Weddington, Eric >> Subject: Remove TARGET_HELP hook >> >> When movi

Removing target-libiberty (was: Re: Libiberty: POSIXify psignal definition)

2011-06-20 Thread Hans-Peter Nilsson
On Wed, 18 May 2011, Joseph S. Myers wrote: > On Wed, 18 May 2011, DJ Delorie wrote: > > > At this point, though, I'm tempted to say "there's no such thing as a > > target libiberty" and rip all the target-libiberty rules out, and let > > Yes please. I've been arguing for that for some time. > > h

RE: Remove TARGET_HELP hook

2011-06-20 Thread Weddington, Eric
> -Original Message- > From: Joseph Myers [mailto:jos...@codesourcery.com] > Sent: Monday, June 20, 2011 9:47 AM > To: gcc-patches@gcc.gnu.org > Cc: cherty...@gmail.com; ae...@post.ru; Weddington, Eric > Subject: Remove TARGET_HELP hook > > When moving hooks used in opts.c to the common

Re: [Patch, AVR]: QI builtins for parity, popcount, 1<< n

2011-06-20 Thread Georg-Johann Lay
Richard Henderson schrieb: > On 06/20/2011 07:20 AM, Georg-Johann Lay wrote: >> A libcall could be added in TARGET_INIT_LIBCALLS, so a new hook is not >> needed. All that's needed is that optabs tests for presence of such >> an entry and prefers it over inline expansion (and prefers insn over >> l

Re: __sync_swap* with acq/rel/full memory barrier semantics

2011-06-20 Thread Andrew MacLeod
On 06/17/2011 02:12 PM, Andrew MacLeod wrote: --- machmode.h (working copy) *** extern enum machine_mode ptr_mode; *** 275,278 --- 275,291 /* Target-dependent machine mode initialization - in insn-modes.c. */ extern void init_adjust_machine_modes (void); + /* Memory

Re: SRA generates uninitialized var use

2011-06-20 Thread Xinliang David Li
It is used to indicate the fact the var decl needs to have a memory home (addressable) -- is there another way to do this? this is to avoid the following situation: 1) after SRA before update SSA, the IR looks like: MEM[ &SR_123] = ... other_var = SR_123; < (x) In this case, SR

Remove TARGET_HELP hook

2011-06-20 Thread Joseph S. Myers
When moving hooks used in opts.c to the common hooks structure so they can be called from the driver, I did not move the TARGET_HELP hook because this hook is obsoleted by the generic Enum .opt facility (only being used to print list of enumerated arguments to options). Instead, this patch converts

Re: [patch fold-const.c]: Add some missing optimizations about binary and and truth-not

2011-06-20 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/20/11 09:34, NightStrike wrote: > On Mon, Jun 20, 2011 at 10:47 AM, Jakub Jelinek wrote: >> On Mon, Jun 20, 2011 at 10:37:30AM -0400, NightStrike wrote: >>> On Mon, Jun 20, 2011 at 8:06 AM, Jakub Jelinek wrote: On Mon, Jun 20, 2011 at 01:5

Re: [build] Move unwinder to toplevel libgcc

2011-06-20 Thread Rainer Orth
[Dropping the target maintainers from the Cc: since this isn't relevant to the patch at hand.] "Joseph S. Myers" writes: > On Mon, 20 Jun 2011, Rainer Orth wrote: > >> Certainly: your wiki entry gives a good overview. For the moment, I'll >> probably concentrate on the build side of things, tho

Re: [Patch, AVR]: QI builtins for parity, popcount, 1<< n

2011-06-20 Thread Richard Henderson
On 06/20/2011 07:20 AM, Georg-Johann Lay wrote: > A libcall could be added in TARGET_INIT_LIBCALLS, so a new hook is not > needed. All that's needed is that optabs tests for presence of such > an entry and prefers it over inline expansion (and prefers insn over > libcall). It appears that + and -

Re: [patch fold-const.c]: Add some missing optimizations about binary and and truth-not

2011-06-20 Thread NightStrike
On Mon, Jun 20, 2011 at 10:47 AM, Jakub Jelinek wrote: > On Mon, Jun 20, 2011 at 10:37:30AM -0400, NightStrike wrote: >> On Mon, Jun 20, 2011 at 8:06 AM, Jakub Jelinek wrote: >> > On Mon, Jun 20, 2011 at 01:50:26PM +0200, Kai Tietz wrote: >> >> Applied at revision 175206 to trunk. >> > >> > There

Re: [build] Move unwinder to toplevel libgcc

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Rainer Orth wrote: > Certainly: your wiki entry gives a good overview. For the moment, I'll > probably concentrate on the build side of things, though. I may attack > gthr* stuff and fp-bit.[ch] next, both of which I can at least partially > test on my targets. fp-bit.[ch]

Re: Improve DSE in the presence of calls

2011-06-20 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/18/11 03:10, Ramana Radhakrishnan wrote: > This seems to have triggered > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49452 > > on arm-linux-gnueabi > > Might well be a DUP of PR49429 but I haven't looked at it yet. It is effectively a dupli

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H. Peter Anvin
On 06/20/2011 07:43 AM, H.J. Lu wrote: > On Mon, Jun 20, 2011 at 7:33 AM, H. Peter Anvin wrote: >> On 06/20/2011 07:01 AM, H.J. Lu wrote: >>> On Mon, Jun 20, 2011 at 6:53 AM, Bernd Schmidt >>> wrote: On 06/20/2011 03:51 PM, H.J. Lu wrote: > Promote pointers to Pmode when passing/returni

Re: [build] Move unwinder to toplevel libgcc

2011-06-20 Thread Rainer Orth
"Joseph S. Myers" writes: > On Mon, 20 Jun 2011, Rainer Orth wrote: > >> * Move all remaining unwinder-only macros to libgcc: UNW_IVMS_MODE, >> MD_UNW_COMPATIBLE_PERSONALITY_P, MD_FROB_UPDATE_CONTEXT. > > I don't see any sign of macros being poisoned in system.h. For macros > used in target-i

Re: [patch, 4.6/4.7] fix installation of plugin header files

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Matthias Klose wrote: > - PR45078; vxworks-dummy.h is included for cpu_type in arm, >i386, mips, sh and sparc but only installed when it's i386; copy it >manually anytime. I don't think you should list particular config/ headers in PLUGIN_HEADERS in Makefile.in; pro

Re: [build] Move unwinder to toplevel libgcc

2011-06-20 Thread Joseph S. Myers
On Mon, 20 Jun 2011, Rainer Orth wrote: > * Move all remaining unwinder-only macros to libgcc: UNW_IVMS_MODE, > MD_UNW_COMPATIBLE_PERSONALITY_P, MD_FROB_UPDATE_CONTEXT. I don't see any sign of macros being poisoned in system.h. For macros used in target-independent unwinder code - at least MD

Re: powerpc64 large-toc vs. reload

2011-06-20 Thread Alan Modra
On Sun, Jun 19, 2011 at 11:04:12PM -0400, David Edelsohn wrote: > On Sun, Jun 19, 2011 at 10:03 AM, Alan Modra wrote: > >* config/rs6000/rs6000.c (create_TOC_reference): Wrap high part > >of toc-relative address in CONST. > >(rs6000_delegitimize_address): Recognize changed

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H.J. Lu
On Mon, Jun 20, 2011 at 7:40 AM, Jeff Law wrote: > >>> Peter, do you think it is safe to assume upper 32bits are zero in >>> user space for x32? Kernel isn't a problem since pointer is 64bit >>> in kernel and we don't pass pointers on stack to kernel. >> >> As I have already stated, if we *cannot*

Re: [patch fold-const.c]: Add some missing optimizations about binary and and truth-not

2011-06-20 Thread Jakub Jelinek
On Mon, Jun 20, 2011 at 10:37:30AM -0400, NightStrike wrote: > On Mon, Jun 20, 2011 at 8:06 AM, Jakub Jelinek wrote: > > On Mon, Jun 20, 2011 at 01:50:26PM +0200, Kai Tietz wrote: > >> Applied at revision 175206 to trunk. > > > > There is no need to post such notices to gcc-patches, we have the gc

Re: [Patch, Fortran] (coarray) Add LOCK_TYPE

2011-06-20 Thread Tobias Burnus
*PING* On 06/16/2011 08:27 AM, Tobias Burnus wrote: This patch adds ISO_Fortran_Env's LOCK_TYPE, tons of constraint checks and a simple implementation for -fcoarray=single. With the implementation of LOCK_TYPE and (UN)LOCK, gfortran can now parse all coarrays constructs of Fortran 2008. (Howe

Re: Cgraph alias reorg 15/14 (New infrastructure for same body aliases)

2011-06-20 Thread Hans-Peter Nilsson
On Mon, 20 Jun 2011, Richard Guenther wrote: > On Sun, Jun 19, 2011 at 2:51 PM, Jan Hubicka wrote: > >> > On Sat, 11 Jun 2011, Jan Hubicka wrote: > >> > > >> > > Hi, > >> > > this patch complettes the same body alias rework by removing the old > >> > > same body > >> > > alias code and adding

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H.J. Lu
On Mon, Jun 20, 2011 at 7:33 AM, H. Peter Anvin wrote: > On 06/20/2011 07:01 AM, H.J. Lu wrote: >> On Mon, Jun 20, 2011 at 6:53 AM, Bernd Schmidt >> wrote: >>> On 06/20/2011 03:51 PM, H.J. Lu wrote: Promote pointers to Pmode when passing/returning in registers is a security concern. >

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread Jeff Law
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/20/11 08:33, H. Peter Anvin wrote: > On 06/20/2011 07:01 AM, H.J. Lu wrote: >> On Mon, Jun 20, 2011 at 6:53 AM, Bernd Schmidt >> wrote: >>> On 06/20/2011 03:51 PM, H.J. Lu wrote: Promote pointers to Pmode when passing/returning in register

Re: [patch fold-const.c]: Add some missing optimizations about binary and and truth-not

2011-06-20 Thread NightStrike
On Mon, Jun 20, 2011 at 8:06 AM, Jakub Jelinek wrote: > On Mon, Jun 20, 2011 at 01:50:26PM +0200, Kai Tietz wrote: >> > Ok. >> > Richard. >> >> Applied at revision 175206 to trunk. > > There is no need to post such notices to gcc-patches, we have the gcc-cvs > mailing list where this is automatica

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H. Peter Anvin
On 06/20/2011 07:01 AM, H.J. Lu wrote: > On Mon, Jun 20, 2011 at 6:53 AM, Bernd Schmidt > wrote: >> On 06/20/2011 03:51 PM, H.J. Lu wrote: >>> Promote pointers to Pmode when passing/returning in registers is >>> a security concern. No. Promoting *NON*-pointers (or rather, requiring non-pointers

C++ PATCH for c++/43831 (missing diagnostics for redundant captures)

2011-06-20 Thread Jason Merrill
Apparently it's ill-formed to explicitly specify a capture for a variable that would be captured the same way by default, so I've added this as a pedwarn. Tested x86_64-pc-linux-gnu, applying to trunk. commit ec4717b67c17d8970828f4f9c81ac8794f65a44f Author: Jason Merrill Date: Sat Jun 18 15:

C++ PATCH for c++/43321 (error on valid C++0x auto)

2011-06-20 Thread Jason Merrill
Here describable_type thought that a particular INDIRECT_REF was describable, but it really wasn't. Fixed by removing describable_type entirely; we can just try to deduce, and defer until instantiation if it doesn't work. Tested x86_64-pc-linux-gnu, applying to trunk. commit 9ffe8ed0665020e0

Re: [Patch, AVR]: QI builtins for parity, popcount, 1<< n

2011-06-20 Thread Georg-Johann Lay
Joseph S. Myers schrieb: > On Fri, 17 Jun 2011, Georg-Johann Lay wrote: > >> So here is my question: Would it be big deal to teach optabs to >> expand plus:di, minus:di as libcall? Maybe even compare is >> feasible? Like so: > > I don't know what the best approach would be, but for just about >

libiberty PATCH for c++/37089 (wrong demangling of reference to reference)

2011-06-20 Thread Jason Merrill
C++0x specifies that a reference to reference produced by template argument substitution collapses to a single reference. Tested x86_64-pc-linux-gnu, applying to trunk. commit b66f8ede160d3f3375d7cd68988f3d498d51cc41 Author: Jason Merrill Date: Sun Jun 19 10:01:02 2011 -0400 PR c++/3708

C++ PATCH for c++/47635 (ICE after error with enum scoped function)

2011-06-20 Thread Jason Merrill
If we see an enum as a scope for a declarator-id, we should avoid setting ctype in the first place as it can't possibly be right. Tested x86_64-pc-linux-gnu, applying to trunk. commit 5800b6d699b10f0c15355b8f37fa9beb7957ea72 Author: Jason Merrill Date: Sun Jun 19 22:38:46 2011 -0400 PR

C++ PATCH for c++/49205 (failure to use variadic template constructor as default constructor)

2011-06-20 Thread Jason Merrill
A variadic template can take no arguments, so it's a default constructor. Tested x86_64-pc-linux-gnu, applying to trunk. commit 9f50baae331019464a94de275ae370cfebb30600 Author: Jason Merrill Date: Sun Jun 19 21:55:11 2011 -0400 PR c++/49205 * call.c (sufficient_parms_p): Allow param

C++ PATCH for c++/48138 (losing __attribute ((aligned)) on template argument)

2011-06-20 Thread Jason Merrill
strip_typedefs needs to propagate DECL_USER_ALIGN as well as attributes in the attribute list. Tested x86_64-pc-linux-gnu, applying to trunk. commit fd43d02986ccbd7c43014ea093fe06f94d3d0af7 Author: Jason Merrill Date: Sun Jun 19 22:20:03 2011 -0400 PR c++/48138 * tree.c (strip_type

Re: [PATCH][RFC][1/2] Bitfield lowering, add BIT_FIELD_EXPR

2011-06-20 Thread William J. Schmidt
On Thu, 2011-06-16 at 09:49 -0700, Richard Henderson wrote: > On 06/16/2011 04:35 AM, Richard Guenther wrote: > > > > + /* Bit-field insertion needs several shift and mask operations. */ > > + case BIT_FIELD_EXPR: > > + return 3; > > ... depending on the target, of course. > Agre

C++ PATCH for c++/47080 (limits on explicit conversion operators)

2011-06-20 Thread Jason Merrill
The PR pointed out that explicit conversion operators are more restricted than normal ones even in direct-initialization; the return type must be convertible to the target type with no more than a qualification conversion. Tested x86_64-pc-linux-gnu, applying to trunk commit 8f60db54d602164cda

Re: [Ada] Fix bugs with volatile and components of aggregate types

2011-06-20 Thread Michael Matz
Hi, On Sun, 19 Jun 2011, Mike Stump wrote: > >> if T is a non-volatile composite type with volatile components, and O > >> is an object of type T, are the optimizers allowed to remove the > >> assignment "O := O"? > > > > Good question, that I'm not really qualified to answer. Any language >

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H.J. Lu
On Mon, Jun 20, 2011 at 6:53 AM, Bernd Schmidt wrote: > On 06/20/2011 03:51 PM, H.J. Lu wrote: >> Promote pointers to Pmode when passing/returning in registers is >> a security concern. > > Whuh? > Peter, do you think it is safe to assume upper 32bits are zero in user space for x32? Kernel isn't

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-20 Thread Christian Bruel
On 06/20/2011 03:41 PM, Rainer Orth wrote: Christian Bruel writes: 2011-06-16 Christian Bruel PR 49139/43654 Please use the correct PR number format here: PR middle-end/49139 PR middle-end/43654 Otherwise the check-in notices don't get into the PRs. OK

Re: [PATCH] parallelize g++ testing a bit more

2011-06-20 Thread Jakub Jelinek
On Mon, Jun 20, 2011 at 09:28:56AM -0400, Jason Merrill wrote: > On 06/17/2011 08:20 PM, Mike Stump wrote: > >On Jun 17, 2011, at 10:47 AM, Nathan Froyd wrote: > >>I've done a lot of g++-only testsuite runs lately > > > >I think it is reasonable to have even more of them, say, if you have 16 > >co

Re: [x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread Bernd Schmidt
On 06/20/2011 03:51 PM, H.J. Lu wrote: > Promote pointers to Pmode when passing/returning in registers is > a security concern. Whuh? > * combine.c (cant_combine_insn_p): Check zero/sign extended > hard registers. This part is OK. Bernd

[x32] PATCH: Remove ix86_promote_function_mode

2011-06-20 Thread H.J. Lu
Promote pointers to Pmode when passing/returning in registers is a security concern. This patch removes ix86_promote_function_mode, which exposes: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47725 There are 2 different patches for PR 47725: http://gcc.gnu.org/ml/gcc-patches/2011-02/threads.html

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-20 Thread Mike Stump
On Jun 20, 2011, at 6:41 AM, Rainer Orth wrote: > Christian Bruel writes: > >> 2011-06-16 Christian Bruel >> >> PR 49139/43654 > > Please use the correct PR number format here: > > PR middle-end/49139 >PR middle-end/43654 > > Otherwise the check-in notices don't get

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-20 Thread Richard Guenther
On Mon, Jun 20, 2011 at 3:32 PM, Christian Bruel wrote: > In addition to the approved part of the patch, I finally got the testsuite > and a full Linux distribution to build without false warnings, with the > additional following changes: > > * two false warnings detected during a Linux distrib re

[Patch, AVR]: Fix PR34734

2011-06-20 Thread Georg-Johann Lay
PR34734 produces annoying, false warnings if __attribute__((progmem)) is used in conjunction with C++. DECL_INITIAL is not yet set up in avr_handle_progmem_attribute. Johann PR target/34734 * config/avr/avr.c (avr_handle_progmem_attribute): Move warning about uninitialize

[patch, 4.6/4.7] fix installation of plugin header files

2011-06-20 Thread Matthias Klose
Two issues with the installation of plugin header files. - the c-family/* headers are used with the the c-family/ prefix in include directives. therefore they must not installed into the flattened plugin include dir, but kept in the subdir. - PR45078; vxworks-dummy.h is included for cpu_t

Re: [PATH] PR/49139 fix always_inline failures diagnostics

2011-06-20 Thread Rainer Orth
Christian Bruel writes: > 2011-06-16 Christian Bruel > > PR 49139/43654 Please use the correct PR number format here: PR middle-end/49139 PR middle-end/43654 Otherwise the check-in notices don't get into the PRs. Thanks. Rainer --

Re: [PATCH][RFC][1/2] Bitfield lowering, add BIT_FIELD_EXPR

2011-06-20 Thread Michael Matz
Hi, On Sun, 19 Jun 2011, William J. Schmidt wrote: > At the risk of being obvious...it seems you could easily combine C1 and > C2 into a single "bitfield descriptor" TREE_INT_CST operand by using > both the high and low portions of the constant. Accessor macros could > be used to hide the sli

  1   2   >