Re: C++ PATCHes relating to c++/48834, c++/40975 (array new)

On 05/02/2011 06:23 PM, Eric Botcazou wrote: I'm not sure you can copy statements if they have any side-effects; this looks quite dangerous to me. Instead statement-expressions should be wrapped up in a SAVE_EXPR/TARGET_EXPR to protect them and prevent copying. It sounds like Ada and C++ are u

Re: Improve DSE in the presence of calls

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 04/26/11 16:06, Easwaran Raman wrote: > >> You're right. The patch has correctness issues. It is not possible to >> simply not call add_wild_read because it also resets >> active_local_stores and frees read_recs. During the local phase it >> seems

Re: [PATCH] Fix switch conversion (PR tree-optimization/48809)

On Fri, Apr 29, 2011 at 9:43 AM, Jakub Jelinek wrote: > Hi! > > The following patch fixes a bug in tree-switch-conversion.c with > signed index_expr's.  build_arrays would compute index_expr - range_min > in index_expr's type and use that as index into CSWTCH.N array, > which is wrong, because in

Re: [PATCH] Properly build integer constants

On Sun, Apr 24, 2011 at 8:11 AM, H.J. Lu wrote: > On Fri, Apr 22, 2011 at 12:27 PM, Richard Guenther wrote: >> >> There is a scary comment before build_int_cst_type why build_int_cst >> can't be sane.  Fortunately it is not true.  If it were there would >> be other code to be fixed. >> >> Bootstr

Re: Improve jump threading 4 of N

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/02/11 15:40, Richard Guenther wrote: > > I've got no opinion on using a VEC if folks chime in with the request, > I'll make that change. > >> If it's fixed size there's no need for a VEC, it would be just overhead. VEC adds checking, which can

Re: [testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store

On 05/02/2011 07:20 AM, Rainer Orth wrote: gfortran.dg/fmt_g0_6.f08 execution seems to fail on all 32-bit x86 targets at -O1 and above. Running it under gdb, I find Program received signal SIGABRT, Aborted. [Switching to Thread 1 (LWP 1)] 0xfed0ff85 in _lwp_kill () from /lib/libc.so.1 (gdb) whe

Re: std::bind vs ::bind ambiguity

On 25 April 2011 19:11, Jonathan Wakely wrote: > > Here's a patch which removes std::bind from the overload set when the > first argument is "socketlike" which I've defined as is_integral || > is_enum.  I considered using is_convertible to int to detect > "socketlike" types, but a callable class ty

Re: update C++0x status table to FDIS

2011-05-03 Jonathan Wakely PR libstdc++/48848 * doc/xml/manual/status_cxx200x.xml: Update valarray status. * doc/html/*: Regenerate. A small tweak to the C++0x status table, as pointed out in PR 48848 Tested with 'make doc-xml-validate-docbook' and 'make doc-html' on x

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

On Mon, May 2, 2011 at 2:33 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 6:41 PM, Xinliang David Li wrote: >> On Mon, May 2, 2011 at 2:11 AM, Richard Guenther >> wrote: >>> On Fri, Apr 29, 2011 at 6:23 PM, Xinliang David Li >>> wrote: Here is the background for this feature:

Re: [PATCH] use build_function_type_list in the sh backend

Nathan Froyd wrote: > As $SUBJECT suggests. The only tricky bit is the initialization of > `args' to NULL_TREEs so that we can safely pass all of the relevant args > to build_function_type_list, regardless of whether the function type in > question has that many args. > > Tested with cross to sh

Re: C++ PATCHes relating to c++/48834, c++/40975 (array new)

> But Diego doesn't think there was any real reason to abort on trying to > copy a STATEMENT_LIST, so it seems to me that we could revert my earlier > patch for 40975 and just add support for copying STATEMENT_LIST. So > 40975-2.patch adds that support. FWIW this assertion caught an impressive nu

Re: [google]: initialize language field for clone function struct

Is this one ok? David On Fri, Apr 29, 2011 at 4:38 PM, Xinliang David Li wrote: > During function cloning, the language field of the src func is not > copied. This can lead to null dereference when gcc calls into langhook > functions.  Unfortunately, I lost track of the test case. > > Ok for tru

C++ PATCHes relating to c++/48834, c++/40975 (array new)

So, the problem in 48834 was that we had specified a particular target for the vec initialization, but it was getting clobbered by ending up on the rhs of an INIT_EXPR. So 48834.patch avoids that. But Diego doesn't think there was any real reason to abort on trying to copy a STATEMENT_LIST, s

Re: [google] Check if the nonnull attribute is applied to 'this' (issue4446070)

On 04/29/2011 04:08 PM, Basile Starynkevitch wrote: [...] which is also what I expect. I have no idea if it is conforming to standards. But I notice that the test about this is remaining in the code. So apparently GCC 4.6 does not make the hypothesis that this is never null, otherwise it would ha

Re: Improve jump threading 4 of N

On Mon, May 2, 2011 at 17:34, Jeff Law wrote: > I've got no opinion on using a VEC if folks chime in with the request, > I'll make that change. I have a slight preference for VEC by default. Diego.

[patch, ia64, pa] Improve UNIX 2003 compatibility on HP-UX 11.31

This patch improves unix 2003 conformance on HP-UX 11.31 systems by linking in the unix2003.o object instead of the unix98.o object. The only difference I am aware of between the two is that linking in unix2003.o alters the behaviour of snprintf when the buffer is not large enough to hold the strin

Re: Improve jump threading 4 of N

On Mon, May 2, 2011 at 11:34 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 05/02/11 15:18, Richard Guenther wrote: > >> >>> For (edge *)xmalloc (sizeof (edge) * 1) use XNEWVEC and friends. > Yup.  Good catch.  Will fix.  Old habits die hard. > >>> I wonder if it make

Re: Improve jump threading 4 of N

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05/02/11 15:18, Richard Guenther wrote: > >> For (edge *)xmalloc (sizeof (edge) * 1) use XNEWVEC and friends. Yup. Good catch. Will fix. Old habits die hard. >> I wonder if it makes sense to use a VEC instead (will the vector >> be of variable

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

On Mon, May 2, 2011 at 6:41 PM, Xinliang David Li wrote: > On Mon, May 2, 2011 at 2:11 AM, Richard Guenther > wrote: >> On Fri, Apr 29, 2011 at 6:23 PM, Xinliang David Li >> wrote: >>> Here is the background for this feature: >>> >>> 1) People relies on function multi-version to explore hw feat

[Patch, Fortran] PR18918: Implement THIS_IMAGE(coarray) for num_images() > 1

With this patch, now all coarray index intrinsics are implemented for num_images() >= 1 - except for bugs. Built and regtesting on x86-64-linux. The testcase was also tested with -fcoarray=single and with -fcoarray=lib -lcaf_mpi with mpirun -n 8. OK for the trunk? Tobias PS: I would like to

Re: Improve jump threading 4 of N

On Mon, May 2, 2011 at 7:07 PM, Jeff Law wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > This is merely an infrastructure patch in preparation for another > improvement in the jump threading code.  It shouldn't affect the code we > generate at all. > > Let's consider this CFG (from

Re: [google/main][RFA] change i386 pc_thunk prefix to be "__x86"

On Mon, May 2, 2011 at 11:49, Andrew Pinski wrote: > On Sat, Apr 30, 2011 at 2:14 PM, Chris Demetriou wrote: >> Makes -S output more easily preprocessable -- otherwise, the __i686 in >> __i686.get_pc_think.reg chokes things. > > IIRC the reason why it uses __i686 is because 586 and before does no

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

On Mon, May 2, 2011 at 1:44 PM, Eric Botcazou wrote: >> Thanks. I committed this patch. >> >> -Sri. >> >> svn commit >> Sending        gcc/ChangeLog.google-main >> Sending        gcc/Makefile.in >> Sending        gcc/builtin-types.def >> Sending        gcc/builtins.def >> Sending        gcc/c-fami

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

> Thanks. I committed this patch. > > -Sri. > > svn commit > Sendinggcc/ChangeLog.google-main > Sendinggcc/Makefile.in > Sendinggcc/builtin-types.def > Sendinggcc/builtins.def > Sendinggcc/c-family/c-common.c > Sendinggcc/common.opt > Sendingg

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

Thanks. I committed this patch. -Sri. svn commit Sendinggcc/ChangeLog.google-main Sendinggcc/Makefile.in Sendinggcc/builtin-types.def Sendinggcc/builtins.def Sendinggcc/c-family/c-common.c Sendinggcc/common.opt Sendinggcc/doc/invoke.texi Add

[PATCH] Fix bt[lq] related miscompilation (PR target/48774)

Hi! As written in the PR, the testcase in the patch is miscompiled on x86_64-linux, because during IRA a *btdi operand is changed from register to CONST_INT 1 (to which that register was initialized). Unfortunately when both 2nd and 3rd ZERO_EXTEND operands are constant integers, *testqi_ext_3{,_r

Re: [google] Normalize version number for google/gcc-4_6 (issue4454049)

On Mon, May 2, 2011 at 2:53 PM, Diego Novillo wrote: > > Since google/gcc-4_6 follows the 4.6 branch, changes in minor > revisions cause unnecessary churn in directory names. > > Fixed with this.  OK for google/gcc-4_6? Yes, okay for google/gcc-4_6. Thanks, Ollie

[google] Normalize version number for google/gcc-4_6 (issue4454049)

Since google/gcc-4_6 follows the 4.6 branch, changes in minor revisions cause unnecessary churn in directory names. Fixed with this. OK for google/gcc-4_6? Google ref 4335466. * BASE-VER: Change to 4.6.x-google. diff --git a/gcc/BASE-VER b/gcc/BASE-VER index 4110f74..33d4edd 1

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

Ok. There may be more correctness related comments -- but those can be addressed when available. For trunk, you need to address issues such as multi-way dispatch. Thanks, David On Mon, May 2, 2011 at 12:11 PM, Sriraman Tallam wrote: > Hi, > >  I want to submit this patch to google/main to make

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

Hi, I want to submit this patch to google/main to make sure it is available for our internal use at Google in order to materialize some optimization opportunities. Let us continue this dicussion as I make changes and submit this for review for trunk. Thanks, -Sri. On Mon, May 2, 2011 at 9:41

[PATCH 10/n, i386]: Merge SSE and AVX patterns using "enable" attribute.

Hello! Attached patch merges MMX move patterns in mmx.md and fixes a couple of problems in i386.md file. 2011-05-02 Uros Bizjak * config/i386/mmx.md (*mov_internal_rex64): Use %vmovq for reg<->xmm moves. (*mov_internal): Merge with *mov_internal_avx. (*movv2sf_

Re: [google/main][RFA] change i386 pc_thunk prefix to be "__x86"

On Sat, Apr 30, 2011 at 2:14 PM, Chris Demetriou wrote: > Makes -S output more easily preprocessable -- otherwise, the __i686 in > __i686.get_pc_think.reg chokes things. IIRC the reason why it uses __i686 is because 586 and before does not need to worry about the return stack addresses. And real

Re: C++ PATCH for c++/48446 (ICE with VLA)

On 04/14/2011 10:52 AM, Jason Merrill wrote: This patch avoids this issue by saving bounds values which have side effects into a local automatic variable (since VLAs can only appear in automatic variables). We stick with the SAVE_EXPR approach for bounds without side-effects to avoid breaking vla

Re: Ping^4 Re: Target header etc. cleanup patch

On 05/02/2011 05:27 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers > wrote: >> Ping^4. Parts of this patch >> are still >> pending review, for targets fr30, m32r, mn10300, rx, v850 (target >> maintainers CC:

Patch ping^2: RFA: Add makefile for cross-configuration torture test

Quoting Joern Rennecke : 2010-04-14 Joern Rennecke * config-list.mk: New file. http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01044.html

Re: [build] Move Solaris 2 startup files to toplevel libgcc

On Mon, 2 May 2011, Rainer Orth wrote: > * Another wart was that gcc/ada/gcc-interface/Makefile.in requires > TARGET_LIBGCC2_CFLAGS, which is otherwise only used in libgcc. It > often contains -fPIC, and if the variable is removed, libgnat.so won't > link (text relocations remain). > > T

Improve jump threading 4 of N

-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 This is merely an infrastructure patch in preparation for another improvement in the jump threading code. It shouldn't affect the code we generate at all. Let's consider this CFG (from a routine in cfgexpand.c) A / \

Re: Trivial patch to fix build with --enable-build-with-cxx

> 2011-05-02 Dmitry Gorbachev > > * parser.c (cp_parser_init_declarator): Replace false by NULL. I've installed the attached patch as obvious. 2011-05-02 Dmitry Gorbachev Eric Botcazou * parser.c (cp_parser_init_declarator): Set pushed_scope to NULL_TREE

m68k: support -fstack-usage

Checked into trunk. Andreas. 2011-05-02 Andreas Schwab PR target/47955 * config/m68k/m68k.c (m68k_expand_prologue): Set current_function_static_stack_size. Index: gcc/config/m68k/m68k.c === --- gcc/config

[build] Move Solaris 2 startup files to toplevel libgcc

It has long been on my agenda to perform/complete the toplevel libgcc migration for my targets. Although Solaris is the most complicated of the three, it lays some infrastructure for the others, so I'm starting with this patch. The ones for IRIX 6 and Tru64 UNIX will follow once the dust on this

Re: [google] Patch to support calling multi-versioned functions via new GCC builtin. (issue4440078)

On Mon, May 2, 2011 at 2:11 AM, Richard Guenther wrote: > On Fri, Apr 29, 2011 at 6:23 PM, Xinliang David Li wrote: >> Here is the background for this feature: >> >> 1) People relies on function multi-version to explore hw features and >> squeeze performance, but there is no standard ways of doin

Re: [PATCH][C] Change array size overflow check

On Mon, 2 May 2011, Richard Guenther wrote: > We do have similar testcases in gcc.dg/large-size-array*.c, but not > exactly testing the bound. The above testcase also complains with > -pedantic about > > t.c:3:13: error: size of array 'a' is too large > t.c:4:1: error: overflow in constant expre

Re: [Patch,AVR]: Fix PR45099

On Mon, May 02, 2011 at 05:23:48PM +0200, Georg-Johann Lay wrote: > PR45099 is an extension that gives an error when a fixed register is > needed to pass a parameter to a function. > > Because the program will show malfunction when such code is generated, > anyway, I think an error is more appropr

Re: [patch] make default linker --hash-style configurable option

On Mon, May 2, 2011 at 7:59 AM, Joseph S. Myers wrote: Thanks for your comments. > When pinging, please include the URL of the patch being pinged and CC http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00246.html > relevant maintainers (in this case, build system maintainers). All of them? [I've

Re: [google] Multiple source LIPO test cases and bug fixes (issue4441084)

thanks. Will correct. David On Mon, May 2, 2011 at 2:03 AM, Rainer Orth wrote: > David, > >> 2011-05-01  David Li   >> >>       * testsuite/lib/profopt.exp (proc): Multiple source file support. >                                     ^ > > This is wrong, the proc is called profopt-execute. > >>  

Re: [PATCH][C] Change array size overflow check

On Mon, 2 May 2011, Joseph S. Myers wrote: > On Mon, 2 May 2011, Richard Guenther wrote: > > > This changes the code that deals with too large array sizes to > > use int_fits_type_p instead of relying on the TREE_OVERFLOW setting > > of the tree folder. The latter will break once we don't treat

Re: [google] Remove unqualified lookups which break clang (issue4439085)

On 05/02/2011 05:19 PM, Paolo Carlini wrote: template struct base { void bar(T) { } }; template struct derived : base { void foo(T t) { bar(t); } }; template class derived; Gosh, c++/24163 Paolo.

Re: [PATCH][C] Change array size overflow check

On Mon, 2 May 2011, Richard Guenther wrote: > This changes the code that deals with too large array sizes to > use int_fits_type_p instead of relying on the TREE_OVERFLOW setting > of the tree folder. The latter will break once we don't treat > sizetypes specially (and they keep being unsigned).

Re: Turn streamer cache to pointer_map

2011/5/2 Jan Hubicka : >> Hi, >> >> On Mon, 2 May 2011, Richard Guenther wrote: >> >> > >> --- 348,367 >> > >>                            bool insert_at_next_slot_p) >> > >>   { >> > >>     void **slot; >> > >>     unsigned ix; >> > >>     bool existed_p; >> > >> >> > >>     gcc_assert (t); >>

Re: Ping^4 Re: Target header etc. cleanup patch

On Mon, May 2, 2011 at 5:21 PM, Joseph S. Myers wrote: > Ping^4.  Parts of this patch > are still > pending review, for targets fr30, m32r, mn10300, rx, v850 (target > maintainers CC:ed).  This version applies cleanly to current trunk. > >

Re: Turn streamer cache to pointer_map

> Hi, > > On Mon, 2 May 2011, Richard Guenther wrote: > > > >> --- 348,367 > > >>                            bool insert_at_next_slot_p) > > >>   { > > >>     void **slot; > > >>     unsigned ix; > > >>     bool existed_p; > > >> > > >>     gcc_assert (t); > > >> > > >> !   slot = pointer_ma

Re: Turn streamer cache to pointer_map

On Mon, May 2, 2011 at 5:15 PM, Michael Matz wrote: > Hi, > > On Mon, 2 May 2011, Richard Guenther wrote: > >> >> --- 348,367 >> >>                            bool insert_at_next_slot_p) >> >>   { >> >>     void **slot; >> >>     unsigned ix; >> >>     bool existed_p; >> >> >> >>     gcc_asse

[Patch,AVR]: Fix PR45099

PR45099 is an extension that gives an error when a fixed register is needed to pass a parameter to a function. Because the program will show malfunction when such code is generated, anyway, I think an error is more appropriate than a warning (as proposed in the PR). Johann 2011-05-02 Georg-Joha

Ping^4 Re: Target header etc. cleanup patch

Ping^4. Parts of this patch are still pending review, for targets fr30, m32r, mn10300, rx, v850 (target maintainers CC:ed). This version applies cleanly to current trunk. I have seen no comments from the mn10300 maintainers. For the o

[PATCH][?/n] TYPE_IS_SIZETYPE fixes

This is another tiny step towards making TYPE_IS_SIZETYPE not special wrt sign-extension. In output_constructor_regular_field we call tree_low_cst without first assuring it won't ICE. Instead of doing that simply compute the zero-based index in double-ints and assert that that result is represen

Re: [google] Remove unqualified lookups which break clang (issue4439085)

On 05/02/2011 04:58 PM, Paolo Carlini wrote: Why nobody noticed so far? Is there a latent C++ front-end bug? Please double check (the last time, I took care of filing the corresponding C++ front-end issue) -- Jason, is it known that we accept the below? Paolo. // template

Re: [Patch,AVR]: Fix PR27663

2011/5/2 Georg-Johann Lay : > This is a fix for an optimization flaw when a long value is composed > from byte values. > > For -fsplit-wide-types (which is still default for avr) the code is > worse than with -fno-split-wide-types. The code for the test case is > better in either situations, i.e. c

[PATCH][C] Change array size overflow check

This changes the code that deals with too large array sizes to use int_fits_type_p instead of relying on the TREE_OVERFLOW setting of the tree folder. The latter will break once we don't treat sizetypes specially (and they keep being unsigned). Bootstrapped and tested on x86_64-unknown-linux-gnu

Re: Turn streamer cache to pointer_map

Hi, On Mon, 2 May 2011, Richard Guenther wrote: > >> --- 348,367 > >>                            bool insert_at_next_slot_p) > >>   { > >>     void **slot; > >>     unsigned ix; > >>     bool existed_p; > >> > >>     gcc_assert (t); > >> > >> !   slot = pointer_map_insert (cache->node_map, t

Re: Turn streamer cache to pointer_map

On Mon, May 2, 2011 at 4:35 PM, Michael Matz wrote: > Hi, > > On Mon, 2 May 2011, Jan Hubicka wrote: > >> !   d_entry.base.from = t; >> !   slot = htab_find_slot (cache->node_map, &d_entry, INSERT); >> !   if (*slot == NULL) >>       { >>         /* Determine the next slot to use in the cache.  */

Re: [build] mips-tfile.c, mips-tdump.c cleanup

On Mon, 2 May 2011, Rainer Orth wrote: > Apart from the issues mentioned by Joseph, I'm removing Saber C support, > use of private Size_t/Ptrdiff_t, and STATIC. Those were the low-hanging > fruit; I currently don't plan to go for other stuff (like removal of the > remaining warnings) since I may

Re: [build] More --enable-threads cleanup

> In my last --enable-threads cleanup patch > > [build, doc] Cleanup --enable-threads support > http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00735.html > > I missed another opportunity, handled by this patch. BTW, feel free to also remove any trace of --enable-threads=gnat. This i

Re: [patch] make default linker --hash-style configurable option

On Mon, 2 May 2011, Paul Pluzhnikov wrote: > Ping? Ping? Ping? Ping? > > This is getting ridiculous. Would someone please accept the patch, > tell me what to fix in it to make it acceptable, or explain why it is > a bad idea? When pinging, please include the URL of the patch being pinged and CC

Re: [google] Remove unqualified lookups which break clang (issue4439085)

On 05/02/2011 04:52 PM, Ollie Wild wrote: Submitted to google/main. Adding libstd...@gcc.gnu.org for trunk approval. This is Ok for mainline and 4_6-branch. Why nobody noticed so far? Is there a latent C++ front-end bug? Please double check (the last time, I took care of filing the correspond

Re: Turn streamer cache to pointer_map

> > If you skip node_map you can end up with false entries for re-used > trees. So I don't think that's a good idea. The GTY marker is bogus there. I believed that the cache is GTY annotated and then the skip would be safe, since whether is in the map is also in the following array. But it is no

Re: [google] Remove unqualified lookups which break clang (issue4439085)

Submitted to google/main. Adding libstd...@gcc.gnu.org for trunk approval. Ollie On Mon, May 2, 2011 at 9:34 AM, Ollie Wild wrote: > > commit 99835abc5d2a7fd3ae0950c8a16fd6d223d408c9 > Author: Ollie Wild > Date:   Fri Apr 29 13:03:57 2011 -0400 > >    Remove unqualified lookups into dependent

Re: Turn streamer cache to pointer_map

Hi, On Mon, 2 May 2011, Richard Guenther wrote: > >>    /* The mapping between tree nodes and slots into the nodes array.  */ > >> !   struct pointer_map_t GTY((skip)) *node_map; > > > > If you skip node_map you can end up with false entries for re-used > > trees.  So I don't think that's a good

Re: Trivial patch to fix build with --enable-build-with-cxx

> 2011-05-02 Dmitry Gorbachev > > * parser.c (cp_parser_init_declarator): Replace false by NULL. Replace by NULL_TREE instead and install under the obvious rule. -- Eric Botcazou

Re: Turn streamer cache to pointer_map

On Mon, May 02, 2011 at 04:46:23PM +0200, Richard Guenther wrote: > >> *** typedef void (lto_free_section_data_f) ( > >> *** 346,355 > >>  struct lto_streamer_cache_d > >>  { > >>    /* The mapping between tree nodes and slots into the nodes array.  */ > >> !   htab_t node_map; > >

Re: Turn streamer cache to pointer_map

On Mon, May 2, 2011 at 4:38 PM, Richard Guenther wrote: > On Mon, May 2, 2011 at 4:16 PM, Jan Hubicka wrote: >> Hi, >> according to oprofile, libiberty hashing takes about 30% of streaming in time >> and according to callgrind, the most busy cache is node_map cache in the >> streamer. >> >> This

Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup

Uros Bizjak writes: > This still doesn't fix the build for alpha due to extra struct. From > sysinfo.go: > > type Timespec struct { Sec Timespec_sec_t; Nsec Timespec_nsec_t; } > type Stat_t struct { Dev uint64; Ino uint64; Rdev uint64; Size int64; > Blocks uint64; Mode uint32; Uid uint32; Gid ui

Re: Turn streamer cache to pointer_map

On Mon, May 2, 2011 at 4:16 PM, Jan Hubicka wrote: > Hi, > according to oprofile, libiberty hashing takes about 30% of streaming in time > and according to callgrind, the most busy cache is node_map cache in the > streamer. > > This patch turns it into pointer-map that also saves about 400MB of me

[build] mips-tfile.c, mips-tdump.c cleanup

Prompted by Joseph's message http://gcc.gnu.org/ml/gcc-patches/2011-04/msg01796.html I've done some cleanup on mips-tfile.c and mips-tdump.c that are now only used by Tru64 UNIX. Apart from the issues mentioned by Joseph, I'm removing Saber C support, use of private Size_t/Ptrdiff_t, and

Re: [google] Remove unqualified lookups which break clang (issue4439085)

On Mon, May 2, 2011 at 10:34, Ollie Wild wrote: > 2011-05-02  Ollie Wild   > >        * include/ext/sso_string_base.h (__sso_string_base<>::_M_construct): >        Fix unqualified lookup. >        (__sso_string_base<>::_M_construct): Likewise. >        (__sso_string_base<>::_M_construct): Likewis

Re: Turn streamer cache to pointer_map

Hi, On Mon, 2 May 2011, Jan Hubicka wrote: > ! d_entry.base.from = t; > ! slot = htab_find_slot (cache->node_map, &d_entry, INSERT); > ! if (*slot == NULL) > { > /* Determine the next slot to use in the cache. */ > if (insert_at_next_slot_p) > ix = VEC_length (t

[google] Remove unqualified lookups which break clang (issue4439085)

commit 99835abc5d2a7fd3ae0950c8a16fd6d223d408c9 Author: Ollie Wild Date: Fri Apr 29 13:03:57 2011 -0400 Remove unqualified lookups into dependent template base classes from STL headers. These break clang. See http://clang.llvm.org/compatibility.html#dep_lookup_bases. To b

Re: [testsuite] Don't XFAIL g++.dg/tree-ssa/pr43411.C

On Mon, May 2, 2011 at 4:13 PM, Rainer Orth wrote: > Given that g++.dg/tree-ssa/pr43411.C seems to XPASS everywhere, it seems > time to remove the xfail. > > Tested on i386-pc-solaris2.11 with the appropriate runtest invocation, > ok for mainline? I think the testcase wants to test for devirtual

[Patch,AVR]: Fix PR27663

This is a fix for an optimization flaw when a long value is composed from byte values. For -fsplit-wide-types (which is still default for avr) the code is worse than with -fno-split-wide-types. The code for the test case is better in either situations, i.e. compared to code without the patch, but

[build] More --enable-threads cleanup

In my last --enable-threads cleanup patch [build, doc] Cleanup --enable-threads support http://gcc.gnu.org/ml/gcc-patches/2011-04/msg00735.html I missed another opportunity, handled by this patch. Bootstrapped on i386-pc-solaris2.11 (not that it's relevant). Ok for mainline?

Re: [patch] make default linker --hash-style configurable option

Ping? Ping? Ping? Ping? This is getting ridiculous. Would someone please accept the patch, tell me what to fix in it to make it acceptable, or explain why it is a bad idea? Thanks! On Mon, Apr 25, 2011 at 9:08 AM, Paul Pluzhnikov wrote: > Ping? Ping? Ping? > > On Mon, Apr 18, 2011 at 9:45 AM, P

Re: Trivial patch to fix build with --enable-build-with-cxx

Uh, there is another one: ../../gcc-4.7/gcc/cp/parser.c: In function 'tree_node* cp_parser_init_declarator(cp_parser*, cp_decl_specifier_seq*, VEC_deferred_access_check_gc*, bool, bool, int, bool*, tree_node**)': ../../gcc-4.7/gcc/cp/parser.c:14612:19: error: converting 'false' to pointer type 'tr

[testsuite] Compile gfortran.dg/fmt_g0_6.f08 with -ffloat-store

gfortran.dg/fmt_g0_6.f08 execution seems to fail on all 32-bit x86 targets at -O1 and above. Running it under gdb, I find Program received signal SIGABRT, Aborted. [Switching to Thread 1 (LWP 1)] 0xfed0ff85 in _lwp_kill () from /lib/libc.so.1 (gdb) where #0 0xfed0ff85 in _lwp_kill () from /lib/l

Turn streamer cache to pointer_map

Hi, according to oprofile, libiberty hashing takes about 30% of streaming in time and according to callgrind, the most busy cache is node_map cache in the streamer. This patch turns it into pointer-map that also saves about 400MB of memory and is bit prettier. I get about 8-10% speedup on Mozilla

[testsuite] Don't XFAIL g++.dg/tree-ssa/pr43411.C

Given that g++.dg/tree-ssa/pr43411.C seems to XPASS everywhere, it seems time to remove the xfail. Tested on i386-pc-solaris2.11 with the appropriate runtest invocation, ok for mainline? Rainer 2011-04-30 Rainer Orth * g++.dg/tree-ssa/pr43411.C: Remove xfail. diff --git a/g

Re: [patch, spu] Fix sched_emit_insn after scheduler changes

Bernd Schmidt wrote: > On 04/27/2011 03:22 PM, Ulrich Weigand wrote: > > * haifa-sched.c (sched_emit_insn): Emit insn before first > > non-scheduled insn. Inform back-end about new insn. Add > > new insn to scheduled_insns list. > > Seems like this function is only used from spu.c. O

Re: Trivial patch to fix build with --enable-build-with-cxx

> 2011-05-02 Dmitry Gorbachev > > * tree-inline.c (maybe_inline_call_in_expr): Replace false by NULL. Thanks for spotting this. I'd apply it to all relevant branches (4.5/4.6). -- Eric Botcazou

Re: [google/main][RFA] change i386 pc_thunk prefix to be "__x86"

On Sat, Apr 30, 2011 at 17:14, Chris Demetriou wrote: > 2011-04-30  Chris Demetriou   > >        * config/i386/i386.c (get_pc_thunk_name): Make 32-bit >        thunk prefix be __x86.get_pc_thunk. OK. Diego.

Re: [patch libiberty include gcc]: PR debug/28047 DWARF output_file_names should really understand DOS pathnames

Can I ask for some clarifications on this patch (applied on 2011-02-28) ? This patch changed the equality function in a hashtable that holds file names, making for example "/" and "\" identical entries on MS-DOS, but it didn't change the hash function, meaning "/" and "\" are now identical hasht

[PATCH] Fix PR48822

This fixes PR48822, an issue we ran into the past as well. The problem is that due to various reasons (mostly simplification of expressions) we might be tempted to go up the lattice (from VARYING to some constant) during value-numbering. This is of course a recipie to oscillation as can be seen

Re: building binutils from same directory as gcc (was: Re: xgcc does not find gcc-4.6.0-go/./binutils/ar (because it is gcc-4.6.0-go/./binutils/binutils/ar))

On Sat, Apr 30, 2011 at 12:38 PM, Jonathan Wakely wrote: >> I tried to express this in this form: >> --- gcc-4.6.0.dist/gcc/doc/install.texi 2011-03-21 13:13:26.0 +0100 >> +++ gcc-4.6.0/gcc/doc/install.texi      2011-04-28 15:59:53.0 +0200 >> +via SVN, it is reliable. Unpacking int

Re: Trivial patch to fix build with --enable-build-with-cxx

On Mon, May 2, 2011 at 08:52, Dmitry Gorbachev wrote: > ../../gcc-4.7/gcc/tree-inline.c: In function 'tree_node* > maybe_inline_call_in_expr(tree)': > ../../gcc-4.7/gcc/tree-inline.c:5229:40: error: converting 'false' to > pointer type 'void (*)(tree)' [-Werror=conversion-null] > > 2011-05-02  Dmi

Trivial patch to fix build with --enable-build-with-cxx

../../gcc-4.7/gcc/tree-inline.c: In function 'tree_node* maybe_inline_call_in_expr(tree)': ../../gcc-4.7/gcc/tree-inline.c:5229:40: error: converting 'false' to pointer type 'void (*)(tree)' [-Werror=conversion-null] 2011-05-02 Dmitry Gorbachev * tree-inline.c (maybe_inline_call_in_exp

Re: [doc] Adjust reference to ACATS in sourcebuild.texi

Arnaud Charlet writes: >> It would be good (though probably not in sourcebuild.texi) to describe >> the modifications. I noticed some when trying to identify the exact >> version of upstream ACATS 2.5 that is included, and this info would help >> for a move to 3.0 in the future. > > You can use

Re: [C++ Patch] PR 47969

The goto variant is OK. Jason

Re: Turn LTO byte i/o functions inline

On Mon, 2 May 2011, Jan Hubicka wrote: > Hi, > lto_input_1_unsigned and lto_output_1_stream are the most frequently called > functions > during the WPA stage. Obviously these are simple accesors that should be > inline. > Note that even with LTO bootstrap these won't get inlined unless we decla

Re: [doc] Adjust reference to ACATS in sourcebuild.texi

> It would be good (though probably not in sourcebuild.texi) to describe > the modifications. I noticed some when trying to identify the exact > version of upstream ACATS 2.5 that is included, and this info would help > for a move to 3.0 in the future. You can use svn log and svn diff for that.

Re: [doc] Adjust reference to ACATS in sourcebuild.texi

Arnaud Charlet writes: >> I'll be happy to add the concrete version number if Arnaud prefers. > > I'd even go further and clarify that the tests represent "a modified subset of > executable tests from the ACATS 2.5 testsuite", to make it clear that these > have no "official" status and do not cor

Re: [doc] Adjust reference to ACATS in sourcebuild.texi

> >>* doc/sourcebuild.texi (Ada Tests): Adjust reference to ACATS > >>testsuite and make it version agnostic. > > I doubt this is a good idea: while you can find out what version of > > ACATS is included in GCC, the information is somewhat hard to find > > (gcc/testsuite/ada/acats/support/a

Turn LTO byte i/o functions inline

Hi, lto_input_1_unsigned and lto_output_1_stream are the most frequently called functions during the WPA stage. Obviously these are simple accesors that should be inline. Note that even with LTO bootstrap these won't get inlined unless we declare them inline or use -O3 or FDO. Bootstrapped/regt

[PATCH] Keep individual tree code stats

This patch makes us count individual tree codes instead of globbing them only. Bootstrapped on x86_64-unknown-linux-gnu, installed. Richard. 2011-05-02 Richard Guenther * tree.c (tree_code_counts): New global array. (record_node_allocation_statistics): Count individual tree

  1   2   >