Re: libiberty sha1.c: bug in adding 64-bit number to 64-bit number (binutils-2.22.90)

2012-09-18 Thread Florian Weimer
On 09/18/2012 02:13 AM, Geoff Pike wrote: Hello libiberty experts, I don't see anything saying that sha1_process_block() has a size limit on its input buffer, and if the length of the buffer is big (e.g., 2^32 on a 64-bit machine) then this code won't correctly add a 64-bit number to 64-bit numb

libiberty sha1.c: bug in adding 64-bit number to 64-bit number (binutils-2.22.90)

2012-09-17 Thread Geoff Pike
Hello libiberty experts, I don't see anything saying that sha1_process_block() has a size limit on its input buffer, and if the length of the buffer is big (e.g., 2^32 on a 64-bit machine) then this code won't correctly add a 64-bit number to 64-bit number: /* First increment the byte count. R