[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-25 Thread hjl at gcc dot gnu dot org
--- Comment #12 from hjl at gcc dot gnu dot org 2010-03-25 16:40 --- Subject: Bug 43402 Author: hjl Date: Thu Mar 25 16:39:51 2010 New Revision: 157726 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157726 Log: Backport regression testcases from mainline. 2010-03-25 H.J. Lu

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-18 Thread matz at gcc dot gnu dot org
--- Comment #11 from matz at gcc dot gnu dot org 2010-03-18 12:46 --- Fixed. -- matz at gcc dot gnu dot org changed: What|Removed |Added Status|ASSIGNED

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-18 Thread matz at gcc dot gnu dot org
--- Comment #10 from matz at gcc dot gnu dot org 2010-03-18 12:21 --- Subject: Bug 43402 Author: matz Date: Thu Mar 18 12:20:50 2010 New Revision: 157538 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=157538 Log: PR tree-optimization/43402 * tree-cfgcleanup.c (cl

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread matz at gcc dot gnu dot org
--- Comment #9 from matz at gcc dot gnu dot org 2010-03-17 17:03 --- http://gcc.gnu.org/ml/gcc-patches/2010-03/msg00774.html -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43402

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread rguenth at gcc dot gnu dot org
--- Comment #8 from rguenth at gcc dot gnu dot org 2010-03-17 16:42 --- (In reply to comment #7) > Hmm, I wonder how that could cause the bug. Probably because we can't rely > on SSA form being uptodate during cfgcleanup, and hence looking up PHI > arguments is wrong, at least for those

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread matz at gcc dot gnu dot org
--- Comment #7 from matz at gcc dot gnu dot org 2010-03-17 16:05 --- Hmm, I wonder how that could cause the bug. Probably because we can't rely on SSA form being uptodate during cfgcleanup, and hence looking up PHI arguments is wrong, at least for those SSA names that are registered for

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread hjl dot tools at gmail dot com
--- Comment #6 from hjl dot tools at gmail dot com 2010-03-17 15:51 --- It is caused by revision 157093: http://gcc.gnu.org/ml/gcc-cvs/2010-02/msg00676.html -- hjl dot tools at gmail dot com changed: What|Removed |Added ---

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread matz at gcc dot gnu dot org
--- Comment #5 from matz at gcc dot gnu dot org 2010-03-17 15:49 --- Hmm, create_edge_and_update_destination_phis is supposed to add new PHI arguments for the ultimate threading destination. But it only does so if there are already PHI nodes in that BB. We need to create new ones, whic

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread matz at gcc dot gnu dot org
--- Comment #4 from matz at gcc dot gnu dot org 2010-03-17 15:36 --- Um, we cleanup the CFG before updating SSA form, hence no wonder that the missing PHI nodes confuse it. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=43402

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread matz at gcc dot gnu dot org
--- Comment #3 from matz at gcc dot gnu dot org 2010-03-17 15:31 --- It seems the jump threading somehow confuses cfgcleanup. Right after the jumps are threaded (in tree_ssa_dominator_optimize after the call to thread_through_all_blocks) the function looks like so: : goto ; : # start_

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread rguenth at gcc dot gnu dot org
--- Comment #2 from rguenth at gcc dot gnu dot org 2010-03-17 15:21 --- Confirmed. -- rguenth at gcc dot gnu dot org changed: What|Removed |Added Status|UNCON

[Bug tree-optimization/43402] [4.5 Regression] dom1 miscompiles binary search

2010-03-17 Thread rguenth at gcc dot gnu dot org
-- rguenth at gcc dot gnu dot org changed: What|Removed |Added Summary|dom1 miscompiles binary |[4.5 Regression] dom1 |search