https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Bug 63892 depends on bug 65150, which changed state.
Bug 65150 Summary: [5 Regression] r220875 causes bootstrap failure on x86_64
darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65150
What|Removed |Added
--
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Jakub Jelinek changed:
What|Removed |Added
Status|REOPENED|RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #24 from Jakub Jelinek ---
As written right now, redirect_callers case doesn't have a fallthru into the
create_thunk case, i.e. we have to redirect all callers (and all other
references to it, but the latter we don't handle right now)
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #23 from Iain Sandoe ---
(In reply to Iain Sandoe from comment #22)
> yeah, it's not right yet.. looking at this:
> diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
> index e1af8bf..3b5553e 100644
> --- a/gcc/ipa-icf.c
> +++ b/gcc/ipa-icf.c
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #22 from Iain Sandoe ---
yeah, it's not right yet.. looking at this:
diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index e1af8bf..3b5553e 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -658,13 +658,16 @@ sem_function::merge (sem_item
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
howarth at bromo dot med.uc.edu changed:
What|Removed |Added
CC||howarth at bromo dot med
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #20 from Iain Sandoe ---
testing:
diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index e1af8bf..4d72e42 100644
--- a/gcc/ipa-icf.c
+++ b/gcc/ipa-icf.c
@@ -660,7 +660,8 @@ sem_function::merge (sem_item *alias_item)
/* When both alia
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #19 from Iain Sandoe ---
Created attachment 34836
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34836&action=edit
testcase to discuss.
So with the patch above, I get a failure to build LLVM stage#1.
the .ii here is a reduced
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #18 from Iain Sandoe ---
so - next increment - simplification of the previous.
(don't try to redirect callers if we don't have any)
diff --git a/gcc/ipa-icf.c b/gcc/ipa-icf.c
index e1af8bf..ca19967 100644
--- a/gcc/ipa-icf.c
+++ b
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #17 from Iain Sandoe ---
so .. the problem on Darwin seems to be when we have an alias which is a vtable
reference to a method.
Then we have alias->callers == NULL, and it seems we don't have anything in
place to replace the referenc
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #16 from Iain Sandoe ---
The first error that comes up is a missing
std::__codecvt_utf8_base::do_unshift(__mbstate_t&, char*, char*,
char*&) [libstdc++ reference to itself]
===
And indeed, if prevent the redirect_callers for darwin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #15 from Iain Sandoe ---
so .. in principle, if we are not creating an alias, it should not matter if
the target supports aliases or not.
I'm wondering if we're somehow deleting an alias that is used elsewhere in the
callgraph. I'm
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #14 from Iain Sandoe ---
https://gcc.gnu.org/ml/gcc-patches/2015-02/msg01320.html
(tested at r220887)
Looking at current output - recurser_void1 is sib-calling recurser_void2, but
not vice-versa.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Iain Sandoe changed:
What|Removed |Added
CC||iains at gcc dot gnu.org
--- Comment #13 f
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Dominique d'Humieres changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Jakub Jelinek changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #10 from Jakub Jelinek ---
Author: jakub
Date: Fri Feb 20 16:44:37 2015
New Revision: 220875
URL: https://gcc.gnu.org/viewcvs?rev=220875&root=gcc&view=rev
Log:
PR target/63892
* ipa-icf.c (sem_function::merge): If DECL_COMDAT
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #9 from Martin Liška ---
Thanks for cooperation, I'm going to bootstrap and run regression tests on
x86_64-linux-pc and I'm going to clone these tests too.
Martin
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #8 from Jakub Jelinek ---
Created attachment 34818
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34818&action=edit
V499
And let's copy and adjust the sibcall-{3,4}.c testcases so that they aren't ICF
optimized, so that we also
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #7 from Jakub Jelinek ---
Thanks, looks reasonable. That will hopefully render my #c5 patch undeeded.
Can you please bootstrap/regtest it on x86_64-linux (well, I can do that too
now). Don't have access to darwin nor time to test it
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #6 from Martin Liška ---
Created attachment 34817
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34817&action=edit
Fixed IPA ICF hooks
Hello Jakub.
Your patch in #c4 is correct, assert is caused due to wrong placement of
unreg
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
--- Comment #5 from Jakub Jelinek ---
Created attachment 34815
--> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34815&action=edit
gcc5-pr63892.patch
This untested patch fixes the issue too, though if the #c4 patch could be made
to work, it m
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Jakub Jelinek changed:
What|Removed |Added
CC||hubicka at gcc dot gnu.org
--- Comment #
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63892
Jeffrey A. Law changed:
What|Removed |Added
Priority|P1 |P2
CC|
24 matches
Mail list logo
