--- Comment #23 from rguenth at gcc dot gnu dot org 2005-12-08 11:24
---
Subject: Bug 24975
Author: rguenth
Date: Thu Dec 8 11:24:07 2005
New Revision: 108226
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=108226
Log:
2005-12-08 Richard Guenther <[EMAIL PROTECTED]>
--- Comment #22 from pcarlini at suse dot de 2005-11-27 02:10 ---
I think we can close the PR now: the miscompilation is fixed and some tricks in
basic_string are well known (and not present in ext/vstring.h and basic_string
in v7-branch).
--
pcarlini at suse dot de changed:
--- Comment #21 from paolo at gcc dot gnu dot org 2005-11-24 01:29 ---
Subject: Bug 24975
Author: paolo
Date: Thu Nov 24 01:29:51 2005
New Revision: 107447
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107447
Log:
2005-11-23 Paolo Carlini <[EMAIL PROTECTED]>
PR libst
--- Comment #20 from pcarlini at suse dot de 2005-11-22 18:00 ---
An observation: while I don't know all the details of current GCC alias
analysis, I'm fairly optimistic that this specific issue with basic_string is
not serious. The reason is that _S_empty_rep_storage, of which we are ta
--- Comment #19 from pcarlini at suse dot de 2005-11-22 16:59 ---
(In reply to comment #18)
> Well, yes. That would at least silence the warning (which would be annoying,
> if we apply the C++ warning patch).
It would be more than annoying, it would be awful, because would be also
emit
--- Comment #18 from rguenth at gcc dot gnu dot org 2005-11-22 16:40
---
Well, yes. That would at least silence the warning (which would be annoying,
if we apply the C++ warning patch).
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24975
--- Comment #17 from pcarlini at suse dot de 2005-11-22 16:14 ---
(In reply to comment #15)
> So that leaves us with basic_string and it's problems. What do you suggest to
> vendors needing ABI compatibility?
Richard, something we *can* safely apply (safely from the ABI point of view)
--- Comment #16 from pcarlini at suse dot de 2005-11-22 15:17 ---
(In reply to comment #15)
> So that leaves us with basic_string and it's problems. What do you suggest to
> vendors needing ABI compatibility?
I'm still trying to figure out whether we can do something not breaking the
A
--- Comment #15 from rguenth at gcc dot gnu dot org 2005-11-22 15:09
---
So that leaves us with basic_string and it's problems. What do you suggest to
vendors needing ABI compatibility?
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24975
--- Comment #14 from paolo at gcc dot gnu dot org 2005-11-22 14:55 ---
Subject: Bug 24975
Author: paolo
Date: Tue Nov 22 14:55:09 2005
New Revision: 107363
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107363
Log:
2005-11-22 Paolo Carlini <[EMAIL PROTECTED]>
PR libst
--- Comment #13 from paolo at gcc dot gnu dot org 2005-11-22 14:53 ---
Subject: Bug 24975
Author: paolo
Date: Tue Nov 22 14:53:03 2005
New Revision: 107362
URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=107362
Log:
2005-11-22 Paolo Carlini <[EMAIL PROTECTED]>
PR libst
--- Comment #12 from pcarlini at suse dot de 2005-11-21 23:07 ---
(In reply to comment #10)
> The patch_draft_24975 alone fixed it. Looks like libstdc++ needs some
> auditing
> for aliasing issues...
By the way, for your curiosity, I digged a bit and the set issue was already
there in
--
pcarlini at suse dot de changed:
What|Removed |Added
AssignedTo|unassigned at gcc dot gnu |pcarlini at suse dot de
|dot org |
--- Comment #11 from pcarlini at suse dot de 2005-11-21 23:02 ---
(In reply to comment #10)
> The patch_draft_24975 alone fixed it. Looks like libstdc++ needs some
> auditing for aliasing issues...
Indeed it does, but I expect that nothing is in a shape worse than basic_string
from the
--- Comment #10 from rguenth at gcc dot gnu dot org 2005-11-21 22:59
---
The patch_draft_24975 alone fixed it. Looks like libstdc++ needs some auditing
for aliasing issues...
Thanks Paolo!
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24975
--- Comment #9 from rguenth at gcc dot gnu dot org 2005-11-21 22:35 ---
Doing both fixed DLV! (now trying without that dynamic string thingie)
--
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=24975
--- Comment #8 from pcarlini at suse dot de 2005-11-21 19:49 ---
Another thing, about the basic_string warning: in order to figure out whether
that cast is really creating problems, you can add
--enable-fully-dynamic-string: with it the problematic code is not used at all.
(as I already
--- Comment #7 from pcarlini at suse dot de 2005-11-21 17:55 ---
Created an attachment (id=10314)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10314&action=view)
Draft for the set/multiset issue
Richard, can you see if the miscompilation goes away with the attached? In a
sense is
--- Comment #6 from pcarlini at suse dot de 2005-11-21 16:28 ---
Actually, to be 100% safe wrt binary compatibility (addresses, etc.) we can
also overload for _Rb_tree::const_iterator the involved _Rb_tree functions,
I'm preparing a patch.
--
http://gcc.gnu.org/bugzilla/show_bug.cgi
--- Comment #5 from pcarlini at suse dot de 2005-11-21 16:09 ---
One more bit of info (meant for Chris too): I think the cast has been added
when
set was changed to have both iterator and const_iterator as const iterator
types.
Since we are not exporting anything, I suppose we can fix th
--- Comment #4 from pcarlini at suse dot de 2005-11-21 16:05 ---
Thanks. I'm looking into the issue. The part involving set seems to me much
more
critical and hopefully solvable without breaking the ABI, because we are not
exporting anything from the library involving set/multiset. I sup
--- Comment #3 from chris at bubblescope dot net 2005-11-21 16:03 ---
While it does look like there might be an error in this warning code, I also
have a feeling we are doing something bad here. I looked at the examples in
stl_set.h and we are doing reference casting from a _Rb_tree_cons
--- Comment #2 from pinskia at gcc dot gnu dot org 2005-11-21 15:51 ---
(In reply to comment #1)
> Created an attachment (id=10312)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10312&action=view) [edit]
> patch to enable aliasing warnings for C++
Note I think this patch is slight
--- Comment #1 from rguenth at gcc dot gnu dot org 2005-11-21 15:44 ---
Created an attachment (id=10312)
--> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=10312&action=view)
patch to enable aliasing warnings for C++
Apply to see the warnings (even during a libstdc++ build).
--
ht
24 matches
Mail list logo
