[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-05 Thread marxin at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #24 from Martin Liška --- (In reply to rguent...@suse.de from comment #22) > On Thu, 5 Mar 2015, hubicka at gcc dot gnu.org wrote: > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > > > > --- Comment #18 from Jan Hubicka --

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-05 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #23 from rguenther at suse dot de --- On Thu, 5 Mar 2015, hubicka at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > > --- Comment #19 from Jan Hubicka --- > I tried to construct a testcase for __restr

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-05 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #22 from rguenther at suse dot de --- On Thu, 5 Mar 2015, hubicka at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > > --- Comment #18 from Jan Hubicka --- > Here is summary of my current understanding

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-05 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #21 from rguenther at suse dot de --- On Wed, 4 Mar 2015, hubicka at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > > --- Comment #16 from Jan Hubicka --- > Richard, > thanks, I also think alias trick

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-05 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #20 from Richard Biener --- Author: rguenth Date: Thu Mar 5 08:43:13 2015 New Revision: 221204 URL: https://gcc.gnu.org/viewcvs?rev=221204&root=gcc&view=rev Log: 2015-03-05 Richard Biener PR ipa/65270 * ipa-icf-gimple.c

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #19 from Jan Hubicka --- I tried to construct a testcase for __restrict__ case: int var; const int *varptr=&var; const int *__restrict__ varptr2=&var; int *__restrict__ varptr3 = &var; int *__restrict__ varptr4 = &var; int * retur

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #18 from Jan Hubicka --- Here is summary of my current understanding of remaining issues from my last weekend's audit. ICF specific: - ipa-icf-gimple.c needs to match dependence analysis Richard has propsed a patch for it, so I h

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #17 from Jan Hubicka --- Author: hubicka Date: Thu Mar 5 00:10:29 2015 New Revision: 221199 URL: https://gcc.gnu.org/viewcvs?rev=221199&root=gcc&view=rev Log: PR ipa/65270 * ipa-icf.c (sem_item::compare_cgraph_references):

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #16 from Jan Hubicka --- Richard, thanks, I also think alias trick makes gloal vars safe for merging across RESTRICT flags. One however needs to consider merging of items referring restricted vars. const restrict int *a=&var; const

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #15 from Richard Biener --- Ok, as variable merging always creates aliases accesses and their types remain the same. So we don't need any extra checks for merging globals here.

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #14 from Richard Biener --- Created attachment 34949 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34949&action=edit function parameter and variable part I am testing that in addition.

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #13 from Richard Biener --- Created attachment 34946 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=34946&action=edit patch I am testing the following patch for the dependence info compare (not sure where the function parameter

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #12 from rguenther at suse dot de --- On Tue, 3 Mar 2015, hubicka at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > > --- Comment #10 from Jan Hubicka --- > Hi, > while looking for a testcase that wou

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-04 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #11 from Richard Biener --- (In reply to Jan Hubicka from comment #9) > Lets reopen this. I agree with other type flags - they seem safe except for > TYPE_ATTRIBUTES of functions I will add compare of today. > > > No. But you can't

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-03 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #10 from Jan Hubicka --- Hi, while looking for a testcase that would trigger with tree-tail-merge (because gimple-fold seems to also miss MEM_REF merging) I noticed following oddity: struct a { int a[10]; }; typedef struct a b

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-03 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 Jan Hubicka changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|FIXED

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-03 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #8 from rguenther at suse dot de --- On March 3, 2015 4:08:17 PM CET, "howarth at bromo dot med.uc.edu" wrote: >https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > >howarth at bromo dot med.uc.edu changed: > > What|Rem

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-03 Thread howarth at bromo dot med.uc.edu
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 howarth at bromo dot med.uc.edu changed: What|Removed |Added CC||howarth at bromo dot med

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-03 Thread rguenther at suse dot de
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #6 from rguenther at suse dot de --- On Mon, 2 Mar 2015, hubicka at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 > > --- Comment #5 from Jan Hubicka --- Thanks > for looking into this! I think this w

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-02 Thread hubicka at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #5 from Jan Hubicka --- Thanks for looking into this! I think this was just the most obvoious of TYPE flags. Some more we need to look into: Is the alias class compare enough to handle TYPE_RESTRICT? We probably want to match TYPE_A

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 Richard Biener changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #3 from Richard Biener --- Author: rguenth Date: Mon Mar 2 14:31:46 2015 New Revision: 221117 URL: https://gcc.gnu.org/viewcvs?rev=221117&root=gcc&view=rev Log: 2015-03-02 Richard Biener PR ipa/65270 * ipa-icf-gimple.c:

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 --- Comment #2 from Richard Biener --- In theory comparing the object alignment with sth like unsigned int align1, align2; unsigned HOST_WIDE_INT tem; get_object_alignment_1 (t1, &align1, &tem); get_object_alignment_1 (t2

[Bug ipa/65270] [5 regression] ICF needs to match TYPE attributes on memory accesses

2015-03-02 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65270 Richard Biener changed: What|Removed |Added Status|UNCONFIRMED |ASSIGNED Last reconfirmed|