[Bug c/61328] valgrind finds problem in find_bswap_or_nop_1

2014-05-28 Thread thomas.preudhomme at arm dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61328 --- Comment #4 from Thomas Preud'homme --- Oh I think I see. When I wrote find_bswap_or_nop_load () I assumed that it would only return in find_bswap_or_nop_1 as called in the GIMPLE_UNARY_RHS case. It seems I was wrong.

[Bug c/61328] valgrind finds problem in find_bswap_or_nop_1

2014-05-28 Thread dcb314 at hotmail dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61328 --- Comment #3 from David Binderman --- (In reply to David Binderman from comment #0) > Maybe > > if (!source_expr2) > return NULL_TREE; > > if (n1.size != n2.size) > return NULL_TREE; > > would be better code.

[Bug c/61328] valgrind finds problem in find_bswap_or_nop_1

2014-05-27 Thread rguenth at gcc dot gnu.org
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61328 --- Comment #2 from Richard Biener --- (In reply to Thomas Preud'homme from comment #1) > *facepalm* > > Yes indeed. Does this qualify for an obvious fix as per commiting rules? Yes.

[Bug c/61328] valgrind finds problem in find_bswap_or_nop_1

2014-05-27 Thread thomas.preudhomme at arm dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61328 --- Comment #1 from Thomas Preud'homme --- *facepalm* Yes indeed. Does this qualify for an obvious fix as per commiting rules?