[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-02-17 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #20 from Sandra Loosemore 2012-02-17 18:51:48 UTC --- Apropos of the complaint that -frepo produces smaller executables than relying just on the linker discarding duplicate COMDAT groups I finally got around to packing up and sub

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-02-11 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 Jakub Jelinek changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-02-11 Thread jason at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #18 from Jason Merrill 2012-02-11 08:50:27 UTC --- Author: jason Date: Sat Feb 11 08:50:23 2012 New Revision: 184127 URL: http://gcc.gnu.org/viewcvs?root=gcc&view=rev&rev=184127 Log: PR c++/51910 * tlink.c (demangled_hash_ent

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-29 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #17 from Sandra Loosemore 2012-01-30 00:12:53 UTC --- Cleaned up version of patch, with Jason's test case. http://gcc.gnu.org/ml/gcc-patches/2012-01/msg01591.html

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-28 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #16 from Sandra Loosemore 2012-01-29 04:50:12 UTC --- Created attachment 26498 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26498 new patch The attached patch seems to DTRT; I tested it also with explicit -Wl,--demangle and -W

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #15 from Sandra Loosemore 2012-01-27 23:22:45 UTC --- I've just dug around in the code a bit and I think we can fix this. I don't have a build tree to use for this set up at the moment, but roughly: the loop to attempt relinking aft

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #14 from Jakub Jelinek 2012-01-27 20:24:14 UTC --- As can be seen from Jason's example, -frepo option is unfortunately not mandatory on the link line when some objects have been compiled with -frepo. And collect2 seems to work by runn

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #13 from Sandra Loosemore 2012-01-27 20:14:22 UTC --- Sigh. I think it would be OK to make -frepo imply --no-demangle, and document that this is the case. If my previous patch is reverted, that'll still leave -frepo broken on Window

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #12 from Jakub Jelinek 2012-01-27 15:50:54 UTC --- Unfortunately the patch doesn't work, I thought that there are separate ld invocations for rpo stuff only and then a final one without, but that is not the case. So, I'm withdrawing

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #11 from Sandra Loosemore 2012-01-27 15:31:14 UTC --- I like the first patch too. Since -frepo seems to depend on telling the linker not to demangle, better to just say so. I'm not familiar with the overall code flow here. Does -fr

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #10 from Jakub Jelinek 2012-01-27 11:05:04 UTC --- Created attachment 26479 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26479 gcc47-pr51910.patch The alternative patch. I like the first patch more, because it will work even

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 Jakub Jelinek changed: What|Removed |Added CC||jakub at gcc dot gnu.org --- Comment #9 f

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-27 Thread jakub at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #8 from Jakub Jelinek 2012-01-27 10:10:08 UTC --- Created attachment 26477 --> http://gcc.gnu.org/bugzilla/attachment.cgi?id=26477 gcc47-pr51910.patch Untested fix.

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-23 Thread sandra at codesourcery dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #7 from Sandra Loosemore 2012-01-23 23:14:18 UTC --- In addition to specifying an explicit command-line option, I think that if you configure GCC with --with-demangler-in-ld=no it'll restore the previous behavior, at least on systems

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-23 Thread jason at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 Jason Merrill changed: What|Removed |Added Status|UNCONFIRMED |NEW Last reconfirmed|

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-23 Thread rguenth at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 Richard Guenther changed: What|Removed |Added Target Milestone|--- |4.7.0

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-22 Thread nephatrine at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #5 from Daniel Wolf 2012-01-22 22:10:17 UTC --- If someone has any ideas about what the issue might be or can point me in the right direction, I'll try to suss this out myself and post a patch if possible. I'm just not very familiar w

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-19 Thread nephatrine at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #4 from Daniel Wolf 2012-01-20 04:46:33 UTC --- (In reply to comment #3) > That is the point of COMDAT so that duplicated function instantiations are not > done. They definitely are or the executable wouldn't be larger without -fre

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-19 Thread pinskia at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #3 from Andrew Pinski 2012-01-20 03:47:05 UTC --- > From your comment, I take it there is some way to enable something like COMDAT folding to remove the duplicated function instantiations? That is the point of COMDAT so that duplicat

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-19 Thread nephatrine at gmail dot com
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 --- Comment #2 from Daniel Wolf 2012-01-20 03:44:05 UTC --- (In reply to comment #1) > Is there a reason why you are using -frepo ? It is not as useful as it was > before elf had comdat. Removing -frepo seems to bloat my executable. The GCC doc

[Bug c++/51910] [4.7 Regression] -frepo linking failure

2012-01-19 Thread pinskia at gcc dot gnu.org
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=51910 Andrew Pinski changed: What|Removed |Added Known to work|4.6.2 | Summary|-frepo linking failur