[Bug tree-optimization/65724] __builtin_object_size difference for C and C++

2015-04-09 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65724 --- Comment #2 from xur at google dot com --- Do you mean the result of 0 in g++ is intentional? But I'm not quite understand the relation with _FORTIFY_SOURCE=2. This macro does not seem to be check in tree-objsz pass. In other words,

[Bug tree-optimization/65724] New: __builtin_object_size difference for C and C++

2015-04-09 Thread xur at google dot com
: tree-optimization Assignee: unassigned at gcc dot gnu.org Reporter: xur at google dot com For the following code: -- #include #include typedef struct { int i; char data[]; } foo; typedef struct { foo foo_var; } bar; int main() { bar *bar_var

[Bug gcov-profile/64123] [5 Regression] Instrumented Firefox segfaults on start

2015-02-02 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64123 --- Comment #25 from xur at google dot com --- attached the test case. replace CC in build_cmd with your compiler. On Mon, Feb 2, 2015 at 12:59 PM, nathan at acm dot org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64

[Bug gcov-profile/64123] [5 Regression] Instrumented Firefox segfaults on start

2015-02-02 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64123 --- Comment #23 from xur at google dot com --- I overlooked that gcov_master was also used in gcov_dump_int. The bug is exactly as Honza described. I can reproduce with a simple example. Nathan: did you use dlopen? It seems using dlopen will

[Bug gcov-profile/64123] [5 Regression] Instrumented Firefox segfaults on start

2015-01-30 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64123 --- Comment #16 from xur at google dot com --- I did not follow the trunk version closely. But from reading the code, I think the design is each DSO uses its own copy of gcov_* functions (including gcov_open and gcov_read_counter) and accesses

[Bug debug/63581] undefined references in debug_info

2014-10-17 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63581 --- Comment #1 from xur at google dot com --- Patches is here: https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01795.html

[Bug debug/63581] New: undefined references in debug_info

2014-10-17 Thread xur at google dot com
Assignee: unassigned at gcc dot gnu.org Reporter: xur at google dot com Created attachment 33752 --> https://gcc.gnu.org/bugzilla/attachment.cgi?id=33752&action=edit reproducer I got the following error when compiling a file with FDO. /tmp/cc6azLyK.o:(.debug_inf

[Bug gcov-profile/61889] [5 Regression] gcov-tool.c uses nftw, ftw.h

2014-10-13 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61889 --- Comment #20 from xur at google dot com --- Thanks for the comments. I'll work on this to get it fixed this time. Let me understand your idea correctly: We will have two patches: The first one will check FTW-API and make the gcov-tool

[Bug gcov-profile/61889] [5 Regression] gcov-tool.c uses nftw, ftw.h

2014-10-13 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61889 --- Comment #18 from xur at google dot com --- This patch is after Kai Tietz's comment. and it does check the nfw headers. On Mon, Oct 13, 2014 at 2:40 PM, fxcoudert at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?

[Bug gcov-profile/61889] [5 Regression] gcov-tool.c uses nftw, ftw.h

2014-10-13 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61889 --- Comment #16 from xur at google dot com --- I sent a patch to fix this, a few weeks ago, but I have got the review or approval. https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00186.html Honza, could you take a quick look? -Rong On Mon, Oct

[Bug middle-end/45631] Indirect call profiling can be improved to handle multiple targets

2014-09-25 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=45631 --- Comment #9 from xur at google dot com --- Sure. I will work on this. I will have a new mode that do multi-target value profiling and keep current single-target mode. Let me know if we only need to have multi-garget mode. The integration with

[Bug gcov-profile/61889] [5 Regression] gcov-tool.c uses nftw, ftw.h

2014-08-20 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61889 --- Comment #7 from xur at google dot com --- OK. I'll fix this and submit another patch. On Wed, Aug 20, 2014 at 11:26 AM, ktietz at gcc dot gnu.org wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61889 > > --- Comment #6

[Bug gcov-profile/61889] [5 Regression] gcov-tool.c uses nftw, ftw.h

2014-08-20 Thread xur at google dot com
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61889 --- Comment #5 from xur at google dot com --- I sent a patch for this a few days ago: https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg87155.html It's pending review. Thanks, -Rong On Wed, Aug 20, 2014 at 10:36 AM, ktietz at gc