Re: Naming flag for specifying the output file name for Binary Module Interface files

On 12/6/22 16:03, David Blaikie wrote: Over in https://reviews.llvm.org/D137059 we're discussing the naming of a clang flag - would be good to have it be consistent with GCC. The functionality is to name the BMI (.pcm in Clang's parlance) output file when compiling a C++20 module. Current propo

Re: Naming flag for specifying the output file name for Binary Module Interface files

On 12/7/22 10:23, Jonathan Wakely wrote: On Wed, 7 Dec 2022, 02:30 chuanqi.xcq via Gcc, > wrote: \ (2) If (1) is not acceptable and we love to keep the command line consistency, I think clang can use '-fmodule-output=' as long as we make it clear in the do

Re: Naming flag for specifying the output file name for Binary Module Interface files

On 12/7/22 11:18, Iain Sandoe wrote: I think it is reasonable to include c++ in the spelling, since other languages supported by GCC (and clang in due course) have modules. I disagree (about the reasonableness part). Other languages have modules, true, but if they want to name the output fi

Re: Naming flag for specifying the output file name for Binary Module Interface files

On 12/7/22 11:58, Iain Sandoe wrote: On 7 Dec 2022, at 16:52, Nathan Sidwell via Gcc wrote: On 12/7/22 11:18, Iain Sandoe wrote: I think it is reasonable to include c++ in the spelling, since other languages supported by GCC (and clang in due course) have modules. I disagree (about the

Re: Naming flag for specifying the output file name for Binary Module Interface files

On 12/9/22 12:33, Iain Sandoe wrote: Hello all. On 9 Dec 2022, at 01:58, chuanqi.xcq wrote: It looks like `-fmodule-file` is better from the discussion. So let's take it. Thanks for everyone here So FAOD (after this discussion) Chuanqi's current patchset implements the following in clang:

Re: Naming flag for specifying the output file name for Binary Module Interface files

I'm missing something from this discussion. IIUC the claim is that these 2 new options -fmodule-output{,=NAME} are for build systems that want to specify the module output file. But how do they specify the mapping from module/header-unit name to CMI, so that imports work? Is this really a c

Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies

On 6/22/23 22:45, Ben Boeckel wrote: On Thu, Jun 22, 2023 at 17:21:42 -0400, Jason Merrill wrote: On 1/25/23 16:06, Ben Boeckel wrote: They affect the build, so report them via `-MF` mechanisms. Why isn't this covered by the existing code in preprocessed_module? It appears as though it is n

Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies

On 7/18/23 16:52, Jason Merrill wrote: On 6/25/23 12:36, Ben Boeckel wrote: On Fri, Jun 23, 2023 at 08:12:41 -0400, Nathan Sidwell wrote: On 6/22/23 22:45, Ben Boeckel wrote: On Thu, Jun 22, 2023 at 17:21:42 -0400, Jason Merrill wrote: On 1/25/23 16:06, Ben Boeckel wrote: They affect the bui

Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies

On 7/18/23 20:01, Ben Boeckel wrote: On Tue, Jul 18, 2023 at 16:52:44 -0400, Jason Merrill wrote: On 6/25/23 12:36, Ben Boeckel wrote: On Fri, Jun 23, 2023 at 08:12:41 -0400, Nathan Sidwell wrote: On 6/22/23 22:45, Ben Boeckel wrote: On Thu, Jun 22, 2023 at 17:21:42 -0400, Jason Merrill wrote

Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies

On 7/19/23 20:47, Ben Boeckel wrote: On Wed, Jul 19, 2023 at 17:11:08 -0400, Nathan Sidwell wrote: GCC is neither of these descriptions. a CMI does not contain the transitive closure of its imports. It contains an import table. That table lists the transitive closure of its imports (it needs

Re: [PATCH v5 4/5] c++modules: report imported CMI files as dependencies

On 7/21/23 10:57, Ben Boeckel wrote: On Thu, Jul 20, 2023 at 17:00:32 -0400, Nathan Sidwell wrote: On 7/19/23 20:47, Ben Boeckel wrote: But it is inhibiting distributed builds because the distributing tool would need to know: - what CMIs are actually imported (here, "read the module mapper fil

PIC-text, ABS-data code generation

I've inherited a RISCV port, where we need to generate code such that text references are PIC, but data references are absolute. 1) Does such a mode have a name? It seems very eXecuteInPlace-like? It's be a shame to make up a new name for it. 2) The target is bare metal, no VM, no shared obj