Re: commits in Bugzilla attributed to others?

2020-03-13 Thread Marek Polacek via Gcc
On Fri, Mar 13, 2020 at 09:46:40AM -0600, Martin Sebor via Gcc wrote: > It looks as though commits with bug fixes appear in Bugzilla comments > made by others(*). Fox instance, commit r10-7151 for PR 92071 shows > in comment #16 on the bug under Martin Liška's name. > > https://gcc.gnu.org/bugz

Re: commits in Bugzilla attributed to others?

2020-03-13 Thread Marek Polacek via Gcc
On Fri, Mar 13, 2020 at 09:56:58AM -0600, Martin Sebor wrote: > On 3/13/20 9:50 AM, Marek Polacek wrote: > > On Fri, Mar 13, 2020 at 09:46:40AM -0600, Martin Sebor via Gcc wrote: > > > It looks as though commits with bug fixes appear in Bugzilla comments > > > made by others(*). Fox instance, comm

Re: New mklog script

2020-05-15 Thread Marek Polacek via Gcc
On Fri, May 15, 2020 at 10:59:56AM +0200, Martin Liška wrote: > Hi. > > Since we moved to git world and we're in the preparation for ChangeLog > messages > being in git commit messages, I think it's the right time to also simplify > mklog > script. > > I'm sending a new version (which should ev

Re: New mklog script

2020-05-15 Thread Marek Polacek via Gcc
On Fri, May 15, 2020 at 03:12:27PM +0200, Martin Liška wrote: > On 5/15/20 2:42 PM, Marek Polacek wrote: > > I actually use mklog -i all the time. But I can work around it if it > > disappears. > > Ah, I can see a consumer. > There's an updated version that supports that. > > For the future, wil

Re: ERR: file not changed in a patch:"gcc/cp/cp-tree.c"

2020-05-19 Thread Marek Polacek via Gcc
On Tue, May 19, 2020 at 01:03:09PM -0600, Martin Sebor via Gcc wrote: > I'm having trouble with the commit hook that tries to enforce > ChangeLog contents. It fails with an error that doesn't make > sense to me: the file it complains isn't mentioned clearly is > listed there and I can't tell what

Re: [IMPORTANT] ChangeLog related changes

2020-06-10 Thread Marek Polacek via Gcc
On Wed, Jun 10, 2020 at 01:34:54PM +, Tamar Christina wrote: > Hi All, > > We've been wondering since we no longer list authors in the changelog (at > least mklog doesn't generate it), > How do we handle multi author patches nowadays? > > Tried searching for it on the website but couldn’t fi

Re: gcc __attribute__

2020-08-06 Thread Marek Polacek via Gcc
On Thu, Aug 06, 2020 at 04:15:10PM +0100, Philip R Brenan via Gcc wrote: > Hi *GCC*: > > On page: > > https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/Function-Attributes.html > > you show the attribute coming after the parameter list. But when I try > this, I get the following: That manual is for

Re: is there a reason why "explicit specialization in non-namespace scope" is still an error in gcc-trunk?

2020-09-23 Thread Marek Polacek via Gcc
On Wed, Sep 23, 2020 at 02:42:01PM +0200, Dennis Luehring wrote: > i've read that scoped template specalization is allowed in C++17 > > > clang supports it starting with release 7 > > MSVC supports it with VS2017(i don't know what revision) > > Intel does not like it Because CWG 727 isn't impl

Re: What is pex_run

2021-02-25 Thread Marek Polacek via Gcc
On Thu, Feb 25, 2021 at 09:57:55PM +, Gary Oblock via Gcc wrote: > I've got collect2 finding a linker error and I'm out of > other options so I'm poking around in the collect2 > sources. I'm wondering what pex_run is (since it's > getting handed the arguments this might mater?) See libiberty/p

Re: Remove RMS from the GCC Steering Committee

2021-03-26 Thread Marek Polacek via Gcc
On Fri, Mar 26, 2021 at 04:02:30PM -0400, Nathan Sidwell wrote: > [double sigh, attaching a pdf causes it to be blocked, and I guess the > number of URLs is also triggering a spam trap for the follow up. I have > removed many of the URLS from this, you'll have to use your google-fu for > sources.

Re: help debug hash_map garbage collection issue

2021-04-20 Thread Marek Polacek via Gcc
On Tue, Apr 20, 2021 at 02:03:00PM -0600, Martin Sebor via Gcc wrote: > I have a static hash_map object that needs to persist across passes: > > static GTY(()) hash_map *map; > > I initialize the map like so: > > map = hash_map::create_ggc (4); > > But I see crashes when accessing the map a

Re: where is PRnnnn required again?

2021-07-06 Thread Marek Polacek via Gcc
On Tue, Jul 06, 2021 at 03:20:26PM -0600, Martin Sebor via Gcc wrote: > I came away from the recent discussion of ChangeLogs requirements > with the impression that the PR bit should be in the subject > (first) line and also above the ChangeLog part but doesn't need > to be repeated again in th

Re: where is PRnnnn required again?

2021-07-07 Thread Marek Polacek via Gcc
On Wed, Jul 07, 2021 at 03:35:35PM -0600, Martin Sebor wrote: > On 7/7/21 2:42 PM, Jonathan Wakely wrote: > > > > > > On Wed, 7 Jul 2021, 17:39 Martin Sebor, > > wrote: > > > > On 7/6/21 4:09 PM, Jonathan Wakely wrote: > > > > > > > > > On Tue, 6 Jul

Re: How to run C++ IPA tests?

2021-10-27 Thread Marek Polacek via Gcc
On Wed, Oct 27, 2021 at 04:29:32PM +0200, Erick Ochoa via Gcc wrote: > Hi, > > I have been adding tests to the gcc/testsuite/gcc.dg/ipa folder > successfully for a while now. I am starting to add some tests into > gcc/testsuite/g++.dg/ipa now but I am having some issues. > > 1. Using `make check-

Re: What replaces FOR_EACH_LOOP_FN

2022-03-02 Thread Marek Polacek via Gcc
On Wed, Mar 02, 2022 at 10:04:40PM +, Gary Oblock via Gcc wrote: > Guys, > > I've been working on an optimization for quite a bit of time and > in an attempt to move it to GCC 12 I found that FOR_EACH_LOOP_FN > no longer exists. I poked around in the archives and tried a Google > search but fo

Re: passing command-line arguments, still

2022-03-16 Thread Marek Polacek via Gcc
On Wed, Mar 16, 2022 at 02:34:09PM -0400, James K. Lowden wrote: > [I sent this to gcc-help by mistake. I'm reposting it here in case > anyone has a suggestion. I did take dje's advice, and deleted the build > directory, except that I preserved config.status and regenerated > Makefile. The observe

Re: passing command-line arguments, still

2022-03-17 Thread Marek Polacek via Gcc
On Thu, Mar 17, 2022 at 12:21:36PM -0400, James K. Lowden wrote: > On Wed, 16 Mar 2022 14:45:33 -0400 > Marek Polacek wrote: > > Hi Marek, > > > Let's avoid -f-foo; use -ffoo instead, like the rest of GCC. > > Sure. I hadn't noticed the distinction. > > > > In cobol/lang.opt, I have: > > >

Re: Buggy error message when dereferencing once a double pointer to struct

2022-05-23 Thread Marek Polacek via Gcc
On Mon, May 23, 2022 at 06:43:55PM +0200, Andrea Monaco via Gcc wrote: > > This snippet that I wrote > > > struct > str > { > int val; > }; > > > void > main (int argc, char **argv) > { > struct str **p; > int i; > > i = p->val; > } > > > is obviously inc

Re: Usage of the C++ stdlib unordered_map in GCC

2022-08-30 Thread Marek Polacek via Gcc
On Tue, Aug 30, 2022 at 09:57:45PM +0200, Tim Lange wrote: > Hello, > > I was preparing a patch for GCC and used the unordered_map from the C++ > stdlib in my patch. Later on, I noticed that it is used nowhere else inside > GCC except for some files in the go frontend. > > I wondered, now that bu

Re: C2x features status

2022-10-21 Thread Marek Polacek via Gcc
On Fri, Oct 21, 2022 at 08:31:09PM +0200, Florian Weimer via Gcc wrote: > * Joseph Myers: > > > I'm working on adding various C2x features to the C front end (and > > elsewhere in GCC as applicable). > > > > I suspect I won't get all the C2x features done for GCC 13. If anyone > > else is inter

Re: -Wint-conversion, -Wincompatible-pointer-types, -Wpointer-sign: Are they hiding constraint C violations?

2022-11-10 Thread Marek Polacek via Gcc
On Thu, Nov 10, 2022 at 07:25:21PM +0100, Florian Weimer via Gcc wrote: > GCC accepts various conversions between pointers and ints and different > types of pointers by default, issuing a warning. > > I've been reading the (hopefully) relevant partso f the C99 standard, > and it seems to me that C

Re: Feature request: Warning when .c file gets #include'd

2022-12-02 Thread Marek Polacek via Gcc
On Fri, Dec 02, 2022 at 03:57:44PM +0100, Jiří Wolker via Gcc wrote: > > Hi, > > I've met a guy that is learning C and got stuck when the linker produced > a screenful of messages about that he did something define multiple > times. The cause of the problem was trivial: > > He did ``#include

Re: No warning about duplicate values in enum

2023-03-10 Thread Marek Polacek via Gcc
On Fri, Mar 10, 2023 at 01:57:06PM +0100, Andrea Monaco via Gcc wrote: > > In gcc 8.3.0, compiling > > > enum > test > { > FIRST = 1, > SECOND = 1, > THIRD = 2 > }; > > int > main (void) > { > return 0; > } > > > generates no warning even with -Wextra. That hit me today, be

Re: No warning about duplicate values in enum

2023-03-13 Thread Marek Polacek via Gcc
On Sat, Mar 11, 2023 at 04:48:14PM +, Jonathan Wakely via Gcc wrote: > On Sat, 11 Mar 2023, 12:53 Basile Starynkevitch, > wrote: > > > Hello all, > > > > > > Andrea observed that: > > > > In gcc 8.3.0, compiling > > > > > > enum > > test > >{ > > FIRST = 1, > > SECOND = 1, > >

Re: lambda coding style

2024-01-10 Thread Marek Polacek via Gcc
On Wed, Jan 10, 2024 at 02:58:03PM -0500, Jason Merrill via Gcc wrote: > What formatting style do we want for non-trivial lambdas in GCC sources? > I'm thinking the most consistent choice would be > > auto l = [&] (parms) // space between ] ( > { // brace on new line, indented t

Re: lambda coding style

2024-01-10 Thread Marek Polacek via Gcc
On Wed, Jan 10, 2024 at 04:24:42PM -0500, Jason Merrill wrote: > On 1/10/24 15:59, Marek Polacek wrote: > > On Wed, Jan 10, 2024 at 02:58:03PM -0500, Jason Merrill via Gcc wrote: > > > What formatting style do we want for non-trivial lambdas in GCC sources? > > > I'm thinking the most consistent ch

Re: [attribs.cc] ICE with 4x underscores

2024-01-30 Thread Marek Polacek via Gcc
On Tue, Jan 30, 2024 at 12:25:24PM +, Jonathan Wakely via Gcc wrote: > On Tue, 30 Jan 2024, 10:35 Amol Surati via Gcc, wrote: > > > Hello, > > > > If a std attribute name is squeezed between 4x underscores, > > > > Which is undefined behaviour, but shouldn't crash. > > the compiler (both 13