Re: int vs. bool / _Bool (Was: Re: Committed: Fix distribute_loop)

2010-01-24 Thread Paolo Bonzini
On 01/23/2010 04:29 PM, Richard Guenther wrote: We could warn about this when building with C++ but with C we do not see bools but ints here. With such a warning there would be no reason not to build stage2 and stage3 with bool == _Bool. Paolo

Re: int vs. bool / _Bool (Was: Re: Committed: Fix distribute_loop)

2010-01-23 Thread Richard Guenther
On Sat, Jan 23, 2010 at 4:16 PM, Olivier Galibert wrote: > On Sat, Jan 23, 2010 at 09:21:47AM -0500, Joern Rennecke wrote: >> [This started on gcc-patches] >> Quoting Richard Guenther : > [...] >> >  bool all_critical_edge_p = true; >> >  all_critical_edge_p &= e->flags & EDGE_CRITICAL; > [...] >>

Re: int vs. bool / _Bool (Was: Re: Committed: Fix distribute_loop)

2010-01-23 Thread Olivier Galibert
On Sat, Jan 23, 2010 at 09:21:47AM -0500, Joern Rennecke wrote: > [This started on gcc-patches] > Quoting Richard Guenther : [...] > > bool all_critical_edge_p = true; > > all_critical_edge_p &= e->flags & EDGE_CRITICAL; [...] > I think a better long-term plan would be to add an option to insert

int vs. bool / _Bool (Was: Re: Committed: Fix distribute_loop)

2010-01-23 Thread Joern Rennecke
[This started on gcc-patches] Quoting Richard Guenther : On Sat, Jan 23, 2010 at 2:37 PM, Paolo Bonzini wrote: On 01/23/2010 01:36 PM, Richard Guenther wrote: Ugh.  I wonder if we should use _Bool instead of int if the host compiler supports it. Then we'd have another share of bugs if someo