Re: diagnostics-branch merged into mainline

2009-06-16 Thread NightStrike
On Mon, Jun 15, 2009 at 2:18 PM, NightStrike wrote: > On Mon, Jun 15, 2009 at 2:05 PM, Aldy Hernandez wrote: >>> ../../gcc/gcc/config/i386/winnt.c: In function >>> ?i386_pe_encode_section_info?: >>> ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to >>> function ?make_decl_one_only

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Dave Korn
Rafael Espindola wrote: >> This is ok, too. I assume you have done a regression test? ;) > > On the fix patch? The file would not build without it > > I did test the original patch, but missed the winnt file. > > Cheers, I did look at the file myself, but couldn't tell (without studying y

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Rafael Espindola
> This is ok, too. I assume you have done a regression test? ;) On the fix patch? The file would not build without it I did test the original patch, but missed the winnt file. Cheers, -- Rafael Avila de Espindola Google | Gordon House | Barrow Street | Dublin 4 | Ireland Registered in Dubl

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Dave Korn
Rafael Espindola wrote: > 2009/6/15 Aldy Hernandez : >>> ../../gcc/gcc/config/i386/winnt.c: In function >>> ?i386_pe_encode_section_info?: >>> ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to >>> function ?make_decl_one_only? >> make_decl_one_only expects one argument, and that's

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Kai Tietz
2009/6/16 Rafael Espindola : >> At revision 148493 decl_one_only was changed to take 2 arguments. >> Looks like I missed winnt.c. > > 148492  actually. Fixed in revision 148523: > > > 2009-06-16  Rafael Avila de Espindola   > >        * config/i386/winnt.c (i386_pe_encode_section_info): Update call

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Rafael Espindola
> At revision 148493 decl_one_only was changed to take 2 arguments. > Looks like I missed winnt.c. 148492 actually. Fixed in revision 148523: 2009-06-16 Rafael Avila de Espindola * config/i386/winnt.c (i386_pe_encode_section_info): Update call to make_decl_one_only. Cheers,

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Kai Tietz
2009/6/16 Rafael Espindola : > 2009/6/15 Aldy Hernandez : >>> ../../gcc/gcc/config/i386/winnt.c: In function >>> ?i386_pe_encode_section_info?: >>> ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to >>> function ?make_decl_one_only? >> >> make_decl_one_only expects one argument, an

Re: diagnostics-branch merged into mainline

2009-06-16 Thread Rafael Espindola
2009/6/15 Aldy Hernandez : >> ../../gcc/gcc/config/i386/winnt.c: In function ?i386_pe_encode_section_info?: >> ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to >> function ?make_decl_one_only? > > make_decl_one_only expects one argument, and that's what's being fed. > Could you pl

Re: diagnostics-branch merged into mainline

2009-06-15 Thread NightStrike
On Mon, Jun 15, 2009 at 2:05 PM, Aldy Hernandez wrote: >> ../../gcc/gcc/config/i386/winnt.c: In function ?i386_pe_encode_section_info?: >> ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to >> function ?make_decl_one_only? > > make_decl_one_only expects one argument, and that's what

Re: diagnostics-branch merged into mainline

2009-06-15 Thread Aldy Hernandez
> ../../gcc/gcc/config/i386/winnt.c: In function ?i386_pe_encode_section_info?: > ../../gcc/gcc/config/i386/winnt.c:288: error: too few arguments to > function ?make_decl_one_only? make_decl_one_only expects one argument, and that's what's being fed. Could you please debug this and find out what's

Re: diagnostics-branch merged into mainline

2009-06-15 Thread NightStrike
On Mon, Jun 15, 2009 at 9:52 AM, Aldy Hernandez wrote: >> Your committal of r148442 has caused an ICE during the build of libgcc >> for targetting win64: > > I have this pending patch, which may or may not fix this. > > http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01113.html > > Can you try and see

Re: diagnostics-branch merged into mainline

2009-06-15 Thread Aldy Hernandez
> Your committal of r148442 has caused an ICE during the build of libgcc > for targetting win64: I have this pending patch, which may or may not fix this. http://gcc.gnu.org/ml/gcc-patches/2009-06/msg01113.html Can you try and see if it fixes it? Otherwise, can you find out where the compiler i

Re: diagnostics-branch merged into mainline

2009-06-15 Thread NightStrike
On Fri, Jun 12, 2009 at 9:49 PM, Aldy Hernandez wrote: > On Sat, Jun 13, 2009 at 01:51:42AM +0100, Dave Korn wrote: >> Aldy Hernandez wrote: >> > Hi folks. >> > >> > At the last minute Ian got a patch in that touched a bunch of places >> > that I was also changing.  I resolved the conflicts, and bo

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Dave Korn
Aldy Hernandez wrote: >> Nope, I just meant that you presumably had every right to do so and should >> have felt free to exercise it because merging a branch justifies asking for a >> freeze. > > Ok, I was not aware of that. My apologies. For some reason I thought > only GWP folks (or thereabo

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
> And now you broke PowerPC and most other targets that call build_decl: Most other targets? You mean *every* target that uses build_decl. Oops, sorry about that. The patch below fixes it. I can't do a bootstrap (I can't find the PPC machine I have access to, and everyone seems to be in a hurry

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
> Nope, I just meant that you presumably had every right to do so and should > have felt free to exercise it because merging a branch justifies asking for a > freeze. Ok, I was not aware of that. My apologies. For some reason I thought only GWP folks (or thereabouts) could ask for a freeze. I

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Dave Korn
Aldy Hernandez wrote: > On Sat, Jun 13, 2009 at 01:51:42AM +0100, Dave Korn wrote: >> Aldy Hernandez wrote: >>> Hi folks. >>> >>> At the last minute Ian got a patch in that touched a bunch of places >>> that I was also changing. I resolved the conflicts, and bootstrapped >>> and tested for C and C

Re: diagnostics-branch merged into mainline

2009-06-12 Thread David Edelsohn
You do not have to make an announcement, but people generally have asked for a freeze around a major merge so that problems from the new functionality can be pinpointed and merge conflicts can be avoided. David On Fri, Jun 12, 2009 at 9:49 PM, Aldy Hernandez wrote: > On Sat, Jun 13, 2009 at 01:51

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
On Sat, Jun 13, 2009 at 01:51:42AM +0100, Dave Korn wrote: > Aldy Hernandez wrote: > > Hi folks. > > > > At the last minute Ian got a patch in that touched a bunch of places > > that I was also changing. I resolved the conflicts, and bootstrapped > > and tested for C and C++. Unfortunately, peop

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Dave Korn
Aldy Hernandez wrote: > Hi folks. > > At the last minute Ian got a patch in that touched a bunch of places > that I was also changing. I resolved the conflicts, and bootstrapped > and tested for C and C++. Unfortunately, people kept committing stuff > that caused conflicts, so I broke down and c

Re: diagnostics-branch merged into mainline

2009-06-12 Thread Andrew Pinski
On Fri, Jun 12, 2009 at 6:13 PM, Aldy Hernandez wrote: > Hi folks. > > At the last minute Ian got a patch in that touched a bunch of places > that I was also changing.  I resolved the conflicts, and bootstrapped > and tested for C and C++.  Unfortunately, people kept committing stuff > that caused

diagnostics-branch merged into mainline

2009-06-12 Thread Aldy Hernandez
Hi folks. At the last minute Ian got a patch in that touched a bunch of places that I was also changing. I resolved the conflicts, and bootstrapped and tested for C and C++. Unfortunately, people kept committing stuff that caused conflicts, so I broke down and committed after a minor C/C++ boots