Re: Static sem_item_optimizer instance in ipa-icf pass

2018-08-31 Thread Martin Liška
On 08/29/2018 03:54 PM, Martin Liška wrote: > Hi. > > There's a patch candidate for the issue that moves the hash > to sem_item. Doing that you'll have control over it when > you'll use sem_{item,variable,function} classes. > > Is it fine? > > Martin > Installed as r264014 into trunk. Martin

Re: Static sem_item_optimizer instance in ipa-icf pass

2018-08-29 Thread Martin Liška
Hi. There's a patch candidate for the issue that moves the hash to sem_item. Doing that you'll have control over it when you'll use sem_{item,variable,function} classes. Is it fine? Martin >From 95f2d9d940554ba40d5889df5b2c0e3d3f558388 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 29 Aug 201

Re: Static sem_item_optimizer instance in ipa-icf pass

2018-08-28 Thread Martin Liška
On 08/16/2018 02:54 PM, Florian Rommel wrote: > Hi Martin, > > >> That can definitely done better, if I see correctly only reference from >> sem_item, sem_function and sem_variable >> is in sem_item::add_type. That can be removed. > > Yes, only sem_item::add_type uses this variable.  Do you thi

Re: Static sem_item_optimizer instance in ipa-icf pass

2018-08-16 Thread Florian Rommel
Hi Martin, That can definitely done better, if I see correctly only reference from sem_item, sem_function and sem_variable is in sem_item::add_type. That can be removed. Yes, only sem_item::add_type uses this variable. Do you think the whole static optimizer variable should be removed?

Re: Static sem_item_optimizer instance in ipa-icf pass

2018-08-13 Thread Martin Liška
On 08/01/2018 02:17 PM, Florian Rommel wrote: > Hi, > > I stumbled across this during my work on a gcc compiler plugin [1]. > > During the ipa-icf pass semantic items (`sem_function` and `sem_variable`) > are generated to find potential candidates for function or variable merging. Hello. Sorry

Static sem_item_optimizer instance in ipa-icf pass

2018-08-01 Thread Florian Rommel
Hi, I stumbled across this during my work on a gcc compiler plugin [1]. During the ipa-icf pass semantic items (`sem_function` and `sem_variable`) are generated to find potential candidates for function or variable merging. In `ipa-icf.c` there is a static variable `optimizer` (of type `sem